Repository navigation
[backport core/1.57] fix(agent): send human links into widget inputs the agent-built doc lacks (PM-1897) - #21261
Conversation
…acks (PM-1897) (#21244) *PR Created by the Glary-Bot Agent* --- Reported for local rc34: the agent said `frame_load_cap` on Load Video (VHS) and an agent-made custom node was "a plain widget = 1000" when the user had wired a PrimitiveInt into both. Linear: PM-1897. ## Cause - When the agent creates a node, comfy-cli `workflow_ops._build_node` puts only its link inputs (`p.is_link`) into the CRDT doc. Widget-backed inputs like `frame_load_cap` get no input slot. - On the canvas, the same node does have a `frame_load_cap` socket. - When the user wires into that socket, `mintConnect` resolves the target by name against the doc's inputs (`docInputIndex`) and finds nothing. It only reports `agent_crdt_link_slot_not_in_doc` and never sends the connect. - So the doc, and the agent's `workflow print`, keep showing the static widget value. ## Commits 1. **Failing regression test** (`agentBuiltWidgetInputLink.regression.test.ts`). It sends a human connect through the real `attachDocOpMinter`, applies it with the pinned `comfy-multi-player` applier, then runs `project()` on the doc. On this commit no ops are minted, so the test fails. 2. **Fix** (pushed as a follow-up commit). When the doc has no slot for a widget-backed input, `mintConnect` sends a `grow` connect carrying the widget name. This is the same payload already used for autogrow inputs. The applier appends a named, widget-backed slot, and peers resolve it by name. The bypass half of the same report (Video Combine shown as bypassed) did not reproduce, so it is out of scope here. ## Status The fix commit is pushed. The regression test fails without the fix and passes with it. All other `agent/crdt` tests still pass, except `agentSubgraphDefinitions.test.ts > scans deeply nested definition ids`, which already fails on `main` with a stack overflow. ## Known limitation (follow-up) There is a narrow window after the user draws the link and before the server echoes the new slot back. During it, the local doc has no slot for this input yet: - **Disconnect in that window:** the disconnect is dropped, so the doc keeps a link the user already removed. - **Replace in that window:** a second grow is sent, so the doc ends up with two slots (`frame_load_cap` and `frame_load_cap.frame_load_cap0`). `main` already has the same weakness for autogrow inputs. The proper fix is to track grows that haven't been echoed yet, keyed by node and input name, and let a later disconnect or reconnect act on that pending slot. It could also be fixed on the applier side: comfy-multi-player could treat a grow that carries `widget` as a claim on an existing slot with the same name. ## Follow-ups (tracked) - Grow echo window (disconnect/replace before the echo): https://linear.app/comfyorg/issue/FE-3472 - Undo/redo restore drops a link into a doc-absent slot: https://linear.app/comfyorg/issue/FE-3473 - Root-cause companion for new agent-built nodes: Comfy-Org/comfy-cli#1028. A third test case pins that once the doc carries the widget socket (the shape that PR writes), the minter sends an ordinary connect with no grow. --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-18T03:49:55.194Z",
"gitSha": "3868bfb52c18904a494f9182ae0c07b997f734ba",
"branch": "backport-21244-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.834000000012,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.321,
"layouts": 8,
"layoutDurationMs": 2.518,
"taskDurationMs": 483.714,
"heapDeltaBytes": 22159256,
"heapUsedBytes": 87427184,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.448999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2018.5770000000502,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.09,
"layouts": 9,
"layoutDurationMs": 2.724,
"taskDurationMs": 551.831,
"heapDeltaBytes": -903212,
"heapUsedBytes": 73815932,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.741000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.8579999999793,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.448999999999998,
"layouts": 10,
"layoutDurationMs": 2.329,
"taskDurationMs": 842.712,
"heapDeltaBytes": -7282368,
"heapUsedBytes": 68115436,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 159.601,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1810.1580000000013,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.86,
"layouts": 9,
"layoutDurationMs": 2.6220000000000003,
"taskDurationMs": 889.6090000000002,
"heapDeltaBytes": -8264316,
"heapUsedBytes": 66756504,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 168.005,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.7469999999698,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.519,
"layouts": 11,
"layoutDurationMs": 3.033,
"taskDurationMs": 385.599,
"heapDeltaBytes": -4538572,
"heapUsedBytes": 69946316,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 11.8,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.8930000000282,
"styleRecalcs": 20,
"styleRecalcDurationMs": 6.085,
"layouts": 12,
"layoutDurationMs": 3.4479999999999995,
"taskDurationMs": 455.02400000000006,
"heapDeltaBytes": 18448,
"heapUsedBytes": 74958564,
"domNodes": 47,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 16.298,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 695.6950000000006,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.767999999999999,
"layouts": 8,
"layoutDurationMs": 2.719,
"taskDurationMs": 515.742,
"heapDeltaBytes": 25293636,
"heapUsedBytes": 90965344,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 176.461,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.08499999999999,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 724.6069999999918,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.5599999999999996,
"layouts": 8,
"layoutDurationMs": 2.5900000000000003,
"taskDurationMs": 517.728,
"heapDeltaBytes": -627788,
"heapUsedBytes": 65992460,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 170.333,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.06190476190477,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1180.3009999999858,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 879.346,
"heapDeltaBytes": -11493468,
"heapUsedBytes": 81054784,
"domNodes": -192,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 66.90599999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 514,
"frameDurationMs": 32.86944444444445,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1240.2430000000777,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 947.2090000000001,
"heapDeltaBytes": 589592,
"heapUsedBytes": 81000228,
"domNodes": -192,
"jsHeapTotalBytes": 13639680,
"scriptDurationMs": 67.88999999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 545,
"frameDurationMs": 33.33243243243244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 832.1200000000317,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.5499999999999,
"heapDeltaBytes": -4735360,
"heapUsedBytes": 74569508,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 147.05400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 213,
"frameDurationMs": 25.25151515151513,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.4389999999894,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.1710000000003,
"heapDeltaBytes": -5057332,
"heapUsedBytes": 75519388,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 158.96499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 214,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10649.757999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9710.571000000002,
"heapDeltaBytes": -3617980,
"heapUsedBytes": 95620828,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 7882.577,
"eventListeners": -68,
"totalBlockingTimeMs": 1073,
"frameDurationMs": 31.88473053892215,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10181.016999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9317.461,
"heapDeltaBytes": -17223572,
"heapUsedBytes": 81747036,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 7476.585,
"eventListeners": -68,
"totalBlockingTimeMs": 842,
"frameDurationMs": 30.76404833836858,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8655.807999999979,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3080000000000001,
"layouts": 1,
"layoutDurationMs": 0.29899999999999977,
"taskDurationMs": 7960.414,
"heapDeltaBytes": -11419364,
"heapUsedBytes": 87349488,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 6666.299,
"eventListeners": -67,
"totalBlockingTimeMs": 581,
"frameDurationMs": 32.95171102661597,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10445.007000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9567.973,
"heapDeltaBytes": -23760500,
"heapUsedBytes": 70560952,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 7754.894,
"eventListeners": -68,
"totalBlockingTimeMs": 929,
"frameDurationMs": 31.142985074626864,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 212.98000000001593,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.097999999999997,
"layouts": 11,
"layoutDurationMs": 3.0959999999999996,
"taskDurationMs": 153.67,
"heapDeltaBytes": 13048648,
"heapUsedBytes": 91849972,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.102000000000002,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 234.65600000008635,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.173,
"layouts": 11,
"layoutDurationMs": 3.385,
"taskDurationMs": 177.75000000000003,
"heapDeltaBytes": -7507404,
"heapUsedBytes": 80165912,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.055,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2023.7380000000371,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.423999999999999,
"layouts": 8,
"layoutDurationMs": 2.3089999999999993,
"taskDurationMs": 633.8419999999999,
"heapDeltaBytes": -22408424,
"heapUsedBytes": 74555192,
"domNodes": -258,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 33.394,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.336000000072,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.647000000000001,
"layouts": 8,
"layoutDurationMs": 2.533,
"taskDurationMs": 555.823,
"heapDeltaBytes": -2761772,
"heapUsedBytes": 75944608,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 37.445,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2629.058999999984,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.098999999999999,
"layouts": 7,
"layoutDurationMs": 2.121,
"taskDurationMs": 1705.8849999999998,
"heapDeltaBytes": 11471696,
"heapUsedBytes": 91652904,
"domNodes": -278,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 822.51,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.772611464968154,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2685.834,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.2829999999999995,
"layouts": 6,
"layoutDurationMs": 1.5119999999999998,
"taskDurationMs": 1811.1589999999999,
"heapDeltaBytes": -20762904,
"heapUsedBytes": 76845276,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 846.526,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.770625000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3743.192000000022,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.825,
"layouts": 62,
"layoutDurationMs": 10.274000000000001,
"taskDurationMs": 1768.2099999999998,
"heapDeltaBytes": -1536400,
"heapUsedBytes": 76480408,
"domNodes": -254,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 770.1519999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3864.3979999999374,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.347,
"layouts": 64,
"layoutDurationMs": 11.559999999999999,
"taskDurationMs": 1835.2740000000001,
"heapDeltaBytes": 2033704,
"heapUsedBytes": 101440144,
"domNodes": 24,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 825.2069999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.738095238095234,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2925.4440000000272,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.696000000000001,
"layouts": 5,
"layoutDurationMs": 1.2049999999999994,
"taskDurationMs": 1913.701,
"heapDeltaBytes": 8396616,
"heapUsedBytes": 86611020,
"domNodes": 0,
"jsHeapTotalBytes": 4681728,
"scriptDurationMs": 933.255,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.761142857142858,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3224.7650000000476,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.104999999999999,
"layouts": 4,
"layoutDurationMs": 1.0109999999999997,
"taskDurationMs": 2107.141,
"heapDeltaBytes": 16431768,
"heapUsedBytes": 94985644,
"domNodes": 0,
"jsHeapTotalBytes": 3563520,
"scriptDurationMs": 1030.9720000000002,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.10473684210526,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2053.0760000000328,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.176,
"layouts": 8,
"layoutDurationMs": 2.1380000000000003,
"taskDurationMs": 449.208,
"heapDeltaBytes": -3040348,
"heapUsedBytes": 78050808,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 30.311000000000003,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2052.180999999905,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1679999999999997,
"layouts": 6,
"layoutDurationMs": 2.225,
"taskDurationMs": 689.0540000000001,
"heapDeltaBytes": -22444756,
"heapUsedBytes": 76050556,
"domNodes": -258,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 36.51700000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 674.6279999999842,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.192,
"layouts": 11,
"layoutDurationMs": 3.437,
"taskDurationMs": 499.19199999999995,
"heapDeltaBytes": -1082812,
"heapUsedBytes": 75892668,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 154.95999999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926833,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 657.147000000009,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.952,
"layouts": 8,
"layoutDurationMs": 2.4130000000000003,
"taskDurationMs": 458.673,
"heapDeltaBytes": 21664316,
"heapUsedBytes": 88550408,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 149.561,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66923076923078,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2039.605999999992,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1149999999999998,
"layouts": 9,
"layoutDurationMs": 3.2,
"taskDurationMs": 539.261,
"heapDeltaBytes": -17782960,
"heapUsedBytes": 58903640,
"domNodes": -180,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 9.008,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.1629999999204,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.3679999999999994,
"layouts": 11,
"layoutDurationMs": 3.2030000000000003,
"taskDurationMs": 445.61500000000007,
"heapDeltaBytes": -7212156,
"heapUsedBytes": 59563440,
"domNodes": -180,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 11.397,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.1209999999955,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.241,
"layouts": 9,
"layoutDurationMs": 2.527,
"taskDurationMs": 665.0169999999999,
"heapDeltaBytes": 11704924,
"heapUsedBytes": 78597916,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 110.291,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1958.8939999999866,
"styleRecalcs": 86,
"styleRecalcDurationMs": 18.242,
"layouts": 9,
"layoutDurationMs": 2.683,
"taskDurationMs": 1090.8660000000002,
"heapDeltaBytes": 11732468,
"heapUsedBytes": 78627128,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 120.942,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66525423728814,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 983.2340000000386,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.409999999999997,
"layouts": 5,
"layoutDurationMs": 16.214000000000002,
"taskDurationMs": 790.5550000000001,
"heapDeltaBytes": 5352816,
"heapUsedBytes": 101051972,
"domNodes": 15953,
"jsHeapTotalBytes": 18751488,
"scriptDurationMs": 24.084,
"eventListeners": 3244,
"totalBlockingTimeMs": 158,
"frameDurationMs": 21.376086956521725,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10055.563000000006,
"styleRecalcs": 250,
"styleRecalcDurationMs": 18.862000000000002,
"layouts": 8,
"layoutDurationMs": 2.3480000000000003,
"taskDurationMs": 5910.8099999999995,
"heapDeltaBytes": 5634248,
"heapUsedBytes": 84200684,
"domNodes": -258,
"jsHeapTotalBytes": 3727360,
"scriptDurationMs": 2684.895,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666059602649007,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10720.585000000028,
"styleRecalcs": 249,
"styleRecalcDurationMs": 20.171000000000003,
"layouts": 7,
"layoutDurationMs": 1.9819999999999998,
"taskDurationMs": 6423.646,
"heapDeltaBytes": 13069244,
"heapUsedBytes": 92383792,
"domNodes": -258,
"jsHeapTotalBytes": 4251648,
"scriptDurationMs": 2893.0750000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.691900311526478,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23115.296000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22401.209000000003,
"heapDeltaBytes": -17638452,
"heapUsedBytes": 273244444,
"domNodes": -3330,
"jsHeapTotalBytes": 10997760,
"scriptDurationMs": 309.79699999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.2712543554007,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 23050.10200000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22323.108,
"heapDeltaBytes": -29559232,
"heapUsedBytes": 251773332,
"domNodes": -3330,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 323.74499999999995,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.15892857142857,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 28069.754000000044,
"styleRecalcs": 181,
"styleRecalcDurationMs": 15.764,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27675.535,
"heapDeltaBytes": -15021404,
"heapUsedBytes": 286119292,
"domNodes": -3330,
"jsHeapTotalBytes": 8306688,
"scriptDurationMs": 852.7819999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 25,
"frameDurationMs": 51.15154826958105,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 28066.51600000009,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.13999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27587.682,
"heapDeltaBytes": -36033000,
"heapUsedBytes": 264999516,
"domNodes": -3330,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 888.388,
"eventListeners": -651,
"totalBlockingTimeMs": 27,
"frameDurationMs": 51.02818181818183,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 5844.907000000035,
"styleRecalcs": 20,
"styleRecalcDurationMs": 89.48499999999999,
"layouts": 20,
"layoutDurationMs": 33.54000000000001,
"taskDurationMs": 5705.152999999999,
"heapDeltaBytes": -22036148,
"heapUsedBytes": 277295116,
"domNodes": -307,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 118.687,
"eventListeners": -7,
"totalBlockingTimeMs": 20,
"frameDurationMs": 34.410588235294114,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8373.317000000043,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.383,
"layouts": 20,
"layoutDurationMs": 22.55399999999999,
"taskDurationMs": 8269.649999999998,
"heapDeltaBytes": -24355848,
"heapUsedBytes": 271360796,
"domNodes": -307,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 123.89699999999999,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.90285714285713,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11474.638999999912,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11180.001,
"heapDeltaBytes": -4660856,
"heapUsedBytes": 250371012,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.79100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.010714285714286,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11424.216,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11169.321,
"heapDeltaBytes": 4568556,
"heapUsedBytes": 280091304,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.28300000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.568243243243245,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 499.79399999995167,
"styleRecalcs": 22,
"styleRecalcDurationMs": 18.443,
"layouts": 11,
"layoutDurationMs": 4.916,
"taskDurationMs": 157.21999999999997,
"heapDeltaBytes": 7004120,
"heapUsedBytes": 80098708,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.63,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.24482758620691,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 134.11699999994653,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.535,
"layouts": 9,
"layoutDurationMs": 4.228,
"taskDurationMs": 103.973,
"heapDeltaBytes": -15489088,
"heapUsedBytes": 68063632,
"domNodes": 120,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.253,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.73750000000001,
"p95FrameDurationMs": 33.20000000000027
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 463.4720000000243,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.36,
"layouts": 76,
"layoutDurationMs": 14.678,
"taskDurationMs": 407.327,
"heapDeltaBytes": 11116656,
"heapUsedBytes": 82340748,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 196.541,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 511.65899999989506,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9909999999999999,
"layouts": 76,
"layoutDurationMs": 15.043000000000001,
"taskDurationMs": 468.816,
"heapDeltaBytes": 11989756,
"heapUsedBytes": 83472816,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 226.78900000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483896,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 591.8830000000526,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.5149999999999997,
"layouts": 76,
"layoutDurationMs": 16.066,
"taskDurationMs": 548.9280000000001,
"heapDeltaBytes": 705088,
"heapUsedBytes": 123007684,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 222.50900000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.142857142857142,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 535.3089999999838,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.5149999999999997,
"layouts": 76,
"layoutDurationMs": 15.360000000000001,
"taskDurationMs": 492.69300000000004,
"heapDeltaBytes": -115256,
"heapUsedBytes": 121825792,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 191.285,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.8% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2276 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0182a2a294e8d6bcdddb947804ee1449742878ca
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #21261 +/- ##
============================================
Coverage 87.16% 87.17%
============================================
Files 2616 2616
Lines 147129 147136 +7
Branches 40354 38273 -2081
============================================
+ Hits 128250 128259 +9
+ Misses 18491 18489 -2
Partials 388 388
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Backport fidelity verified against merged PR 21244: all 310 sorted changed lines match, the same three files are changed, and no package manifest or lockfile is touched. The exact-head CI rollup is fully settled green with no review threads.
Backport of #21244 to
core/1.57Automatically created by backport workflow.