Repository navigation
test(agent): make completed-turn approval action test deterministic - #21249
Conversation
The answer does reach the endpoint after the turn completes; the expected-fail only "failed" when the 202 receipt retired the card before the aria-busy assertion ran. Hold the mocked answer until the busy state is asserted and drop test.fail so the test is a positive guard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-20T12:09:05.212Z",
"gitSha": "75c3cef6cfd127ca18eeea56ed08e786d7aac72e",
"branch": "fe-3471-approval-action-live",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.6729999999602,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.556000000000001,
"layouts": 10,
"layoutDurationMs": 3.589,
"taskDurationMs": 529.8879999999999,
"heapDeltaBytes": -19831532,
"heapUsedBytes": 83453032,
"domNodes": -180,
"jsHeapTotalBytes": 1925120,
"scriptDurationMs": 15.063000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2039.4890000000032,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9169999999999994,
"layouts": 9,
"layoutDurationMs": 2.8510000000000004,
"taskDurationMs": 584.4010000000001,
"heapDeltaBytes": -18573548,
"heapUsedBytes": 89087468,
"domNodes": -180,
"jsHeapTotalBytes": 2502656,
"scriptDurationMs": 9.209999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.6620000000112,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.190000000000001,
"layouts": 10,
"layoutDurationMs": 3.279,
"taskDurationMs": 877.51,
"heapDeltaBytes": -770972,
"heapUsedBytes": 102917176,
"domNodes": -200,
"jsHeapTotalBytes": 2711552,
"scriptDurationMs": 176.27499999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1825.604999999996,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.819,
"layouts": 10,
"layoutDurationMs": 2.6489999999999996,
"taskDurationMs": 940.1099999999999,
"heapDeltaBytes": 673176,
"heapUsedBytes": 104855044,
"domNodes": -180,
"jsHeapTotalBytes": 2093056,
"scriptDurationMs": 163.15699999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666972477064217,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.1190000000342,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.545999999999999,
"layouts": 11,
"layoutDurationMs": 3.7889999999999997,
"taskDurationMs": 492.16200000000003,
"heapDeltaBytes": -110964,
"heapUsedBytes": 105230288,
"domNodes": 49,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 16.92,
"eventListeners": 42,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.462000000064,
"styleRecalcs": 20,
"styleRecalcDurationMs": 6.285,
"layouts": 11,
"layoutDurationMs": 3.8539999999999996,
"taskDurationMs": 357.29900000000004,
"heapDeltaBytes": 220852,
"heapUsedBytes": 108351080,
"domNodes": 49,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 14.803999999999998,
"eventListeners": 42,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 755.0009999999929,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.967,
"layouts": 8,
"layoutDurationMs": 2.5599999999999996,
"taskDurationMs": 555.3000000000001,
"heapDeltaBytes": 5224332,
"heapUsedBytes": 111458828,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 179.854,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444456,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 694.611000000009,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.2150000000000003,
"layouts": 10,
"layoutDurationMs": 2.886,
"taskDurationMs": 508.73099999999994,
"heapDeltaBytes": 4774584,
"heapUsedBytes": 108980920,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 171.02900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285704,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1179.3270000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 857.399,
"heapDeltaBytes": 18455464,
"heapUsedBytes": 122407628,
"domNodes": 0,
"jsHeapTotalBytes": 15630336,
"scriptDurationMs": 69.64399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 560,
"frameDurationMs": 35.85757575757574,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1160.7130000001007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 803.18,
"heapDeltaBytes": 22063760,
"heapUsedBytes": 121013728,
"domNodes": 0,
"jsHeapTotalBytes": 14843904,
"scriptDurationMs": 70.367,
"eventListeners": 0,
"totalBlockingTimeMs": 533,
"frameDurationMs": 34.31176470588234,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.5639999999912,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.26,
"heapDeltaBytes": -3007440,
"heapUsedBytes": 102943056,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.27999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.2799999999788,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.88799999999986,
"heapDeltaBytes": -3477856,
"heapUsedBytes": 102680928,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.253,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11920.602000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10960.067000000001,
"heapDeltaBytes": -13914432,
"heapUsedBytes": 98448676,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8876.357,
"eventListeners": 0,
"totalBlockingTimeMs": 1433,
"frameDurationMs": 31.946648793565686,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10970.564999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10132.373000000001,
"heapDeltaBytes": -2310604,
"heapUsedBytes": 109247788,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8216.012,
"eventListeners": 0,
"totalBlockingTimeMs": 1065,
"frameDurationMs": 31.0657223796034,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10657.553000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9750.684,
"heapDeltaBytes": 118352,
"heapUsedBytes": 111206184,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7811.208,
"eventListeners": 0,
"totalBlockingTimeMs": 1127,
"frameDurationMs": 30.083333333333332,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10692.691000000083,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9882.58,
"heapDeltaBytes": -4762492,
"heapUsedBytes": 106711480,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8373.003999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1256,
"frameDurationMs": 32.227409638554214,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-combo-open",
"durationMs": 276.7699999999991,
"styleRecalcs": 25,
"styleRecalcDurationMs": 18.182999999999996,
"layouts": 13,
"layoutDurationMs": 4.465999999999999,
"taskDurationMs": 256.455,
"heapDeltaBytes": -20414248,
"heapUsedBytes": 100195760,
"domNodes": -2363,
"jsHeapTotalBytes": -4743168,
"scriptDurationMs": 10.040000000000001,
"eventListeners": -633,
"totalBlockingTimeMs": 10,
"frameDurationMs": 26.659999999999947,
"p95FrameDurationMs": 116.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 222.7340000000595,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.552999999999999,
"layouts": 8,
"layoutDurationMs": 2.471,
"taskDurationMs": 165.027,
"heapDeltaBytes": 15177636,
"heapUsedBytes": 106964480,
"domNodes": 927,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.472,
"eventListeners": 205,
"totalBlockingTimeMs": 8,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "large-graph-idle",
"durationMs": 2041.0819999999603,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5949999999999993,
"layouts": 4,
"layoutDurationMs": 1.3069999999999995,
"taskDurationMs": 739.11,
"heapDeltaBytes": -21638664,
"heapUsedBytes": 104123460,
"domNodes": -276,
"jsHeapTotalBytes": -6131712,
"scriptDurationMs": 42.108,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2048.2139999999163,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.4520000000000002,
"layouts": 4,
"layoutDurationMs": 1.3799999999999997,
"taskDurationMs": 556.282,
"heapDeltaBytes": -22441652,
"heapUsedBytes": 105086828,
"domNodes": -296,
"jsHeapTotalBytes": -6037504,
"scriptDurationMs": 37.91599999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2889.5559999999705,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.735999999999999,
"layouts": 8,
"layoutDurationMs": 2.5880000000000005,
"taskDurationMs": 1876.125,
"heapDeltaBytes": -34882132,
"heapUsedBytes": 94043392,
"domNodes": -296,
"jsHeapTotalBytes": -593920,
"scriptDurationMs": 866.39,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666473988439314,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2651.1460000000397,
"styleRecalcs": 64,
"styleRecalcDurationMs": 7.8900000000000015,
"layouts": 3,
"layoutDurationMs": 0.853,
"taskDurationMs": 1707.163,
"heapDeltaBytes": 16259464,
"heapUsedBytes": 109575960,
"domNodes": 0,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 826.4240000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.771518987341775,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3592.2010000000455,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.854,
"layouts": 64,
"layoutDurationMs": 11.424,
"taskDurationMs": 1724.076,
"heapDeltaBytes": -16667888,
"heapUsedBytes": 93960928,
"domNodes": -273,
"jsHeapTotalBytes": -4878336,
"scriptDurationMs": 795.8459999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.744392523364482,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3878.955000000019,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.993000000000002,
"layouts": 64,
"layoutDurationMs": 10.927,
"taskDurationMs": 1857.3659999999998,
"heapDeltaBytes": -19616320,
"heapUsedBytes": 94381488,
"domNodes": -272,
"jsHeapTotalBytes": -4448256,
"scriptDurationMs": 795.1270000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666233766233766,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3167.663999999945,
"styleRecalcs": 39,
"styleRecalcDurationMs": 4.403000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1938.7409999999998,
"heapDeltaBytes": 21379348,
"heapUsedBytes": 117141988,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1046.9550000000002,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.844385026737967,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3236.2399999999525,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.48,
"layouts": 3,
"layoutDurationMs": 1.203,
"taskDurationMs": 2158.916,
"heapDeltaBytes": 2677288,
"heapUsedBytes": 113584764,
"domNodes": -261,
"jsHeapTotalBytes": -4816896,
"scriptDurationMs": 1028.03,
"eventListeners": 52,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.839583333333337,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.124000000057,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6880000000000003,
"layouts": 2,
"layoutDurationMs": 0.778,
"taskDurationMs": 523.6260000000001,
"heapDeltaBytes": 12492820,
"heapUsedBytes": 106496136,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.754999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2103.01400000003,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.9430000000000005,
"layouts": 6,
"layoutDurationMs": 3.87,
"taskDurationMs": 769.398,
"heapDeltaBytes": -29816960,
"heapUsedBytes": 102509064,
"domNodes": -296,
"jsHeapTotalBytes": -1527808,
"scriptDurationMs": 38.951,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.8,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 722.5889999999708,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.6080000000000005,
"layouts": 9,
"layoutDurationMs": 2.7199999999999998,
"taskDurationMs": 478.729,
"heapDeltaBytes": -120380,
"heapUsedBytes": 108127644,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 155.637,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069753,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 647.3989999999503,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.486,
"layouts": 9,
"layoutDurationMs": 2.611,
"taskDurationMs": 467.92100000000005,
"heapDeltaBytes": -2256912,
"heapUsedBytes": 107223960,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 147.629,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2053.006000000039,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.3550000000000004,
"layouts": 8,
"layoutDurationMs": 3.1710000000000003,
"taskDurationMs": 708.1500000000001,
"heapDeltaBytes": -2349848,
"heapUsedBytes": 103366752,
"domNodes": -218,
"jsHeapTotalBytes": 2355200,
"scriptDurationMs": 13.375,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.763999999991,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.942,
"layouts": 10,
"layoutDurationMs": 2.7030000000000007,
"taskDurationMs": 608.508,
"heapDeltaBytes": 441948,
"heapUsedBytes": 106630160,
"domNodes": -218,
"jsHeapTotalBytes": 2879488,
"scriptDurationMs": 8.651000000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2041.2430000000086,
"styleRecalcs": 89,
"styleRecalcDurationMs": 16.545,
"layouts": 10,
"layoutDurationMs": 3.055,
"taskDurationMs": 1204.2169999999999,
"heapDeltaBytes": -6985076,
"heapUsedBytes": 98639940,
"domNodes": -198,
"jsHeapTotalBytes": 2617344,
"scriptDurationMs": 125.913,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.7270000000062,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.723000000000003,
"layouts": 9,
"layoutDurationMs": 2.2680000000000002,
"taskDurationMs": 898.8689999999999,
"heapDeltaBytes": -12331304,
"heapUsedBytes": 87357204,
"domNodes": -218,
"jsHeapTotalBytes": -905216,
"scriptDurationMs": 113.04400000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1469.3520000000717,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.792,
"layouts": 5,
"layoutDurationMs": 16.770000000000003,
"taskDurationMs": 1168.8539999999998,
"heapDeltaBytes": 11657360,
"heapUsedBytes": 127063752,
"domNodes": 16030,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 33.308,
"eventListeners": 3244,
"totalBlockingTimeMs": 171,
"frameDurationMs": 20.043243243243253,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 11302.705999999944,
"styleRecalcs": 247,
"styleRecalcDurationMs": 31.467000000000002,
"layouts": 4,
"layoutDurationMs": 1.1989999999999996,
"taskDurationMs": 6569.9710000000005,
"heapDeltaBytes": -6462780,
"heapUsedBytes": 119893036,
"domNodes": -296,
"jsHeapTotalBytes": -3842048,
"scriptDurationMs": 2923.2070000000003,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.71523668639053,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8319.66799999998,
"styleRecalcs": 249,
"styleRecalcDurationMs": 31.136000000000003,
"layouts": 7,
"layoutDurationMs": 2.549,
"taskDurationMs": 5512.986,
"heapDeltaBytes": -13438712,
"heapUsedBytes": 113971528,
"domNodes": -296,
"jsHeapTotalBytes": -4272128,
"scriptDurationMs": 2822.664,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.766868686868683,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 24847.16900000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24156.807,
"heapDeltaBytes": 259055836,
"heapUsedBytes": 621667056,
"domNodes": -3343,
"jsHeapTotalBytes": 271568896,
"scriptDurationMs": 377.132,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.692446043165475,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "vue-large-graph-idle",
"durationMs": 17011.074000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16498.004999999997,
"heapDeltaBytes": -34198220,
"heapUsedBytes": 279956600,
"domNodes": -3343,
"jsHeapTotalBytes": 16502784,
"scriptDurationMs": 305.31199999999995,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.108390410958904,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 28894.87500000007,
"styleRecalcs": 181,
"styleRecalcDurationMs": 24.263000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28594.225,
"heapDeltaBytes": -15428924,
"heapUsedBytes": 309653664,
"domNodes": -3343,
"jsHeapTotalBytes": 15716352,
"scriptDurationMs": 994.4979999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 71,
"frameDurationMs": 53.81545623836127,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 28960.947000000033,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.44299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28560.668,
"heapDeltaBytes": -1031848,
"heapUsedBytes": 309647008,
"domNodes": -3343,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 905.7539999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 53.509796672828095,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 6325.33699999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.655,
"layouts": 20,
"layoutDurationMs": 25.617999999999988,
"taskDurationMs": 6200.0470000000005,
"heapDeltaBytes": -27039564,
"heapUsedBytes": 283681620,
"domNodes": -307,
"jsHeapTotalBytes": 4444160,
"scriptDurationMs": 112.775,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.57921348314607,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 8432.467999999972,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.74700000000001,
"layouts": 20,
"layoutDurationMs": 23.751999999999995,
"taskDurationMs": 8298.952,
"heapDeltaBytes": -21414788,
"heapUsedBytes": 288717936,
"domNodes": -3343,
"jsHeapTotalBytes": 15454208,
"scriptDurationMs": 124.52899999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.59116022099448,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11790.705000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11501.798999999999,
"heapDeltaBytes": -4717352,
"heapUsedBytes": 301505640,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 169.095,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.34350877192982,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11574.182000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11275.694000000001,
"heapDeltaBytes": -639988,
"heapUsedBytes": 285235708,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.23899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.16049822064056,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 131.1990000000378,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.631,
"layouts": 8,
"layoutDurationMs": 3.639,
"taskDurationMs": 103.15700000000001,
"heapDeltaBytes": 5064892,
"heapUsedBytes": 106425448,
"domNodes": 128,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 13.278000000000002,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 124.77599999999711,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.916,
"layouts": 10,
"layoutDurationMs": 3.876,
"taskDurationMs": 88.31000000000002,
"heapDeltaBytes": 4764924,
"heapUsedBytes": 106226604,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.738000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142908,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 547.898000000032,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.679,
"layouts": 76,
"layoutDurationMs": 15.299,
"taskDurationMs": 502.818,
"heapDeltaBytes": 12727752,
"heapUsedBytes": 83324836,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 258.259,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.169696969696982,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 527.9129999998986,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6759999999999999,
"layouts": 76,
"layoutDurationMs": 16.261000000000003,
"taskDurationMs": 470.972,
"heapDeltaBytes": -20967028,
"heapUsedBytes": 65009996,
"domNodes": 4,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 228.324,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665624999999977,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 584.8610000000463,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.506,
"layouts": 76,
"layoutDurationMs": 14.971,
"taskDurationMs": 547.239,
"heapDeltaBytes": 1287336,
"heapUsedBytes": 120183516,
"domNodes": 4,
"jsHeapTotalBytes": 1437696,
"scriptDurationMs": 220.592,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 576.9659999998566,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.197,
"layouts": 76,
"layoutDurationMs": 15.793999999999999,
"taskDurationMs": 546.6500000000001,
"heapDeltaBytes": 1142908,
"heapUsedBytes": 120380236,
"domNodes": 4,
"jsHeapTotalBytes": 1699840,
"scriptDurationMs": 224.825,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2954 passed, 0 failed · 5 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9725d281725f7040924419ac1e700bd3d0e2696c
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (115)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
✅ No high-signal findings.
Panel: 6/6 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21249 +/- ##
==========================================
- Coverage 86.51% 85.39% -1.12%
==========================================
Files 3876 2733 -1143
Lines 180447 157069 -23378
Branches 47829 38665 -9164
==========================================
- Hits 156106 134135 -21971
- Misses 22075 22545 +470
+ Partials 2266 389 -1877
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…on-live # Conflicts: # browser_tests/tests/agent/agentReplyDrafts.spec.ts
This comment has been minimized.
This comment has been minimized.
…on-live Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
christian-byrne
left a comment
There was a problem hiding this comment.
Approving at exact head d070abac24.
This strengthens the pin rather than relaxing it, which is the thing worth saying plainly. The diff deletes test.fail(selection === 'run', …), so the run case stops being an expected failure and starts asserting for real. Before this, run had no effective coverage at all: when it passed it was reported as an unexpected pass, and when it failed that was recorded as correct.
The determinism mechanism is a held mocked reply, not a weakened assertion. Every assertion in the test body is byte-identical to main — the answer-endpoint poll, aria-busy="true", and the card retiring after releaseAnswer(). What changes is that the 202 receipt no longer arrives before the busy state is read. That window is exactly what commitAsk closes once no active turn owns the ask, so holding the route makes the in-flight state observable instead of a coin flip. It is the same technique #21268 already landed on main for cancel; this extends it to run so both parameterisations behave the same way, which also removes the asymmetry someone would otherwise have to re-explain later.
Checked at this head:
- all five required checks green (
test,lint-and-format,e2e-status,website-e2e,cla-assistant) MERGEABLE, zero unresolved review threads- one changed path,
browser_tests/tests/agent/agentReplyDrafts.spec.ts— test-only, no product change
No skip, test.fixme, retry wrapper or loosened matcher anywhere in the diff.
…fy-Org#22047) ## Summary Baseline drifted on `main` (`6ae3330a`). Four pins fixed, two new pins unrecorded. Ceiling 16 → 14. <details><summary>Full context for agent readers</summary> `pnpm test:expected-failure-ratchet` on `main` reports six findings. The step is informational since Comfy-Org#21815, so CI stays green, but the log shows drift. Removed (the `test.fail()` is gone because the defect was fixed): - `agentLocalNodeAppearanceSurvivesAgentEdit.spec.ts` recolour and reshape pins — fixed by Comfy-Org#21947. - `agentRateLimitDuplicateSubmit.spec.ts` repeated-Enter pin — fixed by Comfy-Org#22030. - `agentReplyDrafts.spec.ts` completed-turn approval action pin — made deterministic by Comfy-Org#21249. Added as `live-defect` (both from Comfy-Org#21931, PM-1410): a continuing turn on a still-unbound tab drops the updated draft, so a link the user severed is not carried. That is product behavior, not an infrastructure assertion. - `agentUnboundTabLinkSeverance.spec.ts`: "carries the canvas after the user severs a link" - `useAgentSession.test.ts`: "(h12) a second turn on a still-unbound tab carries the connection the user severed (PM-1410)" `LIVE_DEFECT_CEILING` 16 → 14 (16 − 4 + 2). Inventory test count fixtures updated to match. Part of Comfy-Org#19707. ## Verification - `pnpm test:expected-failure-ratchet` on this branch: `Expected-failure baseline matches: 14 live defects, 8 infrastructure assertions.` On `main`: 2 unclassified, 4 resolved-still-in-baseline. - `tools/expected-failures/src/inventory.test.ts`: 16/16 pass. - Pre-commit oxfmt, oxlint, `typecheck:tools`; pre-push depcruise and fallow: pass. </details>
ELI5
A browser test for the "Run / Cancel" approval buttons was flipping between pass and fail on unrelated pull requests. The feature itself works; the test was checking a brief "busy" state that sometimes vanished before the check ran. The test now pauses the fake server reply until it has looked, so it gives the same answer every time and actually protects the feature.
Summary
a completed turn keeps its run/cancel approval action livewas markedtest.fail, but the answer does reach/threads/*/asks/*/answerafter the turn completes. Once the turn is done,commitAsksees that no active turn owns the ask and retires the card as soon as the 202 receipt arrives (it skips the grace watchdog). So thearia-busyassertion raced the mocked reply: if the receipt landed first, the button was gone ("element(s) not found"), which was the "expected" failure; otherwise the whole test passed.Since this PR opened, #21268 on
mainapplied the same hold-the-answer fix to thecancelcase only, kepttest.failonrun, and stopped sendingagent_ask_resolved(the 202 receipt retires the card by itself). After mergingmain, this PR holds the mocked answer for both selections and drops the remainingruntest.fail. It keeps main's receipt-only retirement. Onmain, therunexpected-fail passes only because the un-held 202 wins the same race. The other tests in the spec and the product code are unchanged.Verification
pnpm typecheck:browser,oxfmt --check,oxlint: pass on the earlier merged head01d44bd. Pre-commit and pre-push hooks also passed. The latest head only merges newermain; the spec diff is unchanged.01d44bd,playwright-tests-cloud-sharded (4, 4)failed twice, in other agent specs (agentUndoSurvivesRemoteFrame,agentGhostFlagSurvival,agentHumanAddTabSwitch,agentPlacedNodeGhostFlag).agentReplyDraftspassed.mainfailed on the same shard in the same window (run 39382542126) and has passed since, somainwas merged again to retest.406eddabpassed every check, including the cloud E2E shards where bothrunandcancelwere positive assertions.d070abac, CI passed every chromium and cloud E2E shard, includingplaywright-tests-cloud-sharded (4, 4).Residual
--repeat-each=20 -g "approval action live"cloud run has not been done, so consistency rests on single CI passes (both approval cases passed on406eddabandd070abac).Provenance
mainmaintouches onlyagentReplyDrafts.spec.ts--repeat-each=20E2E run was not done because this host has no browser/backend for itrun🤖 Generated with Claude Code