Repository navigation
fix(billing): gate the personal-plan CTA on the server plan action - #21237
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-18T05:24:59.219Z",
"gitSha": "dec53502e479ee081db50f76ed35e20e4fa012ff",
"branch": "dante/pricing-cta-plan-action",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.0209999999715,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7619999999999996,
"layouts": 9,
"layoutDurationMs": 2.733,
"taskDurationMs": 566.7420000000001,
"heapDeltaBytes": 4221076,
"heapUsedBytes": 102970460,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.056,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2042.6410000000033,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.785,
"layouts": 9,
"layoutDurationMs": 3.007,
"taskDurationMs": 489.95900000000006,
"heapDeltaBytes": -13540896,
"heapUsedBytes": 90602636,
"domNodes": -196,
"jsHeapTotalBytes": 1740800,
"scriptDurationMs": 11.994000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2057.6880000000415,
"styleRecalcs": 83,
"styleRecalcDurationMs": 15.793999999999999,
"layouts": 9,
"layoutDurationMs": 2.913,
"taskDurationMs": 1141.7839999999999,
"heapDeltaBytes": 23144456,
"heapUsedBytes": 114887968,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 163.75699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1829.1350000000648,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.141000000000002,
"layouts": 10,
"layoutDurationMs": 2.8720000000000003,
"taskDurationMs": 845.399,
"heapDeltaBytes": -15305512,
"heapUsedBytes": 88866316,
"domNodes": -196,
"jsHeapTotalBytes": 2789376,
"scriptDurationMs": 150.60800000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665454545454544,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.9190000000235,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.375,
"layouts": 11,
"layoutDurationMs": 3.0939999999999994,
"taskDurationMs": 434.28,
"heapDeltaBytes": 1848724,
"heapUsedBytes": 105432040,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 13.111,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.366999999992,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.2989999999999995,
"layouts": 11,
"layoutDurationMs": 3.248999999999999,
"taskDurationMs": 441.964,
"heapDeltaBytes": 1789324,
"heapUsedBytes": 105938660,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 12.920999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 742.7939999999467,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.7150000000000003,
"layouts": 9,
"layoutDurationMs": 2.7030000000000007,
"taskDurationMs": 522.582,
"heapDeltaBytes": 4075116,
"heapUsedBytes": 95408724,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 163.356,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 739.3910000000687,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.444,
"layouts": 8,
"layoutDurationMs": 2.351,
"taskDurationMs": 531.0319999999999,
"heapDeltaBytes": 7993908,
"heapUsedBytes": 114767608,
"domNodes": 0,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 169.01,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909086,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1242.7859999999669,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 937.458,
"heapDeltaBytes": -9335676,
"heapUsedBytes": 102431148,
"domNodes": -212,
"jsHeapTotalBytes": 9965568,
"scriptDurationMs": 62.05200000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 533,
"frameDurationMs": 32.45526315789472,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1184.4499999999698,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 863.6750000000001,
"heapDeltaBytes": -15312748,
"heapUsedBytes": 101772372,
"domNodes": -226,
"jsHeapTotalBytes": 16166912,
"scriptDurationMs": 65.15099999999998,
"eventListeners": -168,
"totalBlockingTimeMs": 513,
"frameDurationMs": 33.80857142857143,
"p95FrameDurationMs": 33.19999999999982
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 814.1239999999925,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.76199999999994,
"heapDeltaBytes": -4615540,
"heapUsedBytes": 95303604,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 134.47800000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 183,
"frameDurationMs": 24.020588235294138,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 797.1260000000484,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.57100000000037,
"heapDeltaBytes": -4213816,
"heapUsedBytes": 97596808,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 126.17,
"eventListeners": 0,
"totalBlockingTimeMs": 175,
"frameDurationMs": 23.526470588235284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10425.649000000021,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.061999999999999555,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9601.121,
"heapDeltaBytes": 28990136,
"heapUsedBytes": 150350920,
"domNodes": -272,
"jsHeapTotalBytes": 36343808,
"scriptDurationMs": 7463.228999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 672,
"frameDurationMs": 31.66018237082067,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10348.954999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9516.422,
"heapDeltaBytes": 44531680,
"heapUsedBytes": 166228668,
"domNodes": -273,
"jsHeapTotalBytes": 45780992,
"scriptDurationMs": 7489.433,
"eventListeners": -126,
"totalBlockingTimeMs": 700,
"frameDurationMs": 31.173493975903614,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9135.493999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8453.673,
"heapDeltaBytes": 18878112,
"heapUsedBytes": 140334808,
"domNodes": -292,
"jsHeapTotalBytes": 31363072,
"scriptDurationMs": 6422.603,
"eventListeners": -130,
"totalBlockingTimeMs": 139,
"frameDurationMs": 28.101230769230767,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9573.802999999998,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06800000000000035,
"layouts": 1,
"layoutDurationMs": 0.3470000000000001,
"taskDurationMs": 8819.896999999999,
"heapDeltaBytes": 30992028,
"heapUsedBytes": 136022508,
"domNodes": -272,
"jsHeapTotalBytes": 30904320,
"scriptDurationMs": 6813.697,
"eventListeners": -130,
"totalBlockingTimeMs": 190,
"frameDurationMs": 27.809011627906976,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 215.35800000003746,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.378999999999998,
"layouts": 10,
"layoutDurationMs": 3.276,
"taskDurationMs": 178.829,
"heapDeltaBytes": 13264064,
"heapUsedBytes": 117259880,
"domNodes": 917,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 8.18,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.987499999999955,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 192.95899999997346,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.874999999999998,
"layouts": 11,
"layoutDurationMs": 3.4270000000000005,
"taskDurationMs": 144.245,
"heapDeltaBytes": 13218184,
"heapUsedBytes": 118012232,
"domNodes": 917,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 8.499999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222217,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2037.6479999999901,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.242,
"layouts": 7,
"layoutDurationMs": 1.8590000000000004,
"taskDurationMs": 521.865,
"heapDeltaBytes": 7097316,
"heapUsedBytes": 109639796,
"domNodes": -272,
"jsHeapTotalBytes": -5074944,
"scriptDurationMs": 35.77499999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.7669999999598,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5629999999999993,
"layouts": 8,
"layoutDurationMs": 2.7470000000000003,
"taskDurationMs": 536.491,
"heapDeltaBytes": -22721836,
"heapUsedBytes": 98208564,
"domNodes": -272,
"jsHeapTotalBytes": -1564672,
"scriptDurationMs": 31.416,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2364.4219999999905,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.248,
"layouts": 7,
"layoutDurationMs": 2.0060000000000002,
"taskDurationMs": 1753.161,
"heapDeltaBytes": -17445576,
"heapUsedBytes": 98526804,
"domNodes": -292,
"jsHeapTotalBytes": -552960,
"scriptDurationMs": 802.59,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2250.2980000000434,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.235000000000001,
"layouts": 7,
"layoutDurationMs": 1.92,
"taskDurationMs": 1590.296,
"heapDeltaBytes": 707340,
"heapUsedBytes": 104033120,
"domNodes": -292,
"jsHeapTotalBytes": -917504,
"scriptDurationMs": 816.4010000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79097744360902,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3600.881999999956,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.284999999999999,
"layouts": 63,
"layoutDurationMs": 11.110999999999999,
"taskDurationMs": 1669.3249999999998,
"heapDeltaBytes": -13312476,
"heapUsedBytes": 91796224,
"domNodes": -268,
"jsHeapTotalBytes": -487424,
"scriptDurationMs": 784.933,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574074074074,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3790.8270000000357,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.347999999999999,
"layouts": 65,
"layoutDurationMs": 11.996,
"taskDurationMs": 1894.932,
"heapDeltaBytes": -12059284,
"heapUsedBytes": 101579788,
"domNodes": -248,
"jsHeapTotalBytes": -159744,
"scriptDurationMs": 779.675,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665638766519823,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3189.458000000002,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.211,
"layouts": 6,
"layoutDurationMs": 1.6490000000000002,
"taskDurationMs": 2027.3919999999998,
"heapDeltaBytes": 19641972,
"heapUsedBytes": 121359492,
"domNodes": 0,
"jsHeapTotalBytes": 2519040,
"scriptDurationMs": 946.1850000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84157894736842,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3183.6789999999837,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.745000000000001,
"layouts": 3,
"layoutDurationMs": 0.8709999999999993,
"taskDurationMs": 2092.033,
"heapDeltaBytes": -9513436,
"heapUsedBytes": 97162296,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 985.932,
"eventListeners": 182,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.111229946524066,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2028.8949999999772,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.306,
"layouts": 6,
"layoutDurationMs": 1.9720000000000002,
"taskDurationMs": 520.291,
"heapDeltaBytes": 2063020,
"heapUsedBytes": 105492540,
"domNodes": -292,
"jsHeapTotalBytes": -5861376,
"scriptDurationMs": 31.252000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2035.476000000017,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0280000000000005,
"layouts": 7,
"layoutDurationMs": 2.4430000000000005,
"taskDurationMs": 703.6590000000001,
"heapDeltaBytes": 734184,
"heapUsedBytes": 103874700,
"domNodes": -292,
"jsHeapTotalBytes": -4812800,
"scriptDurationMs": 34.989,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.0000000000136,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.633,
"layouts": 8,
"layoutDurationMs": 2.393,
"taskDurationMs": 448.0179999999999,
"heapDeltaBytes": 25592776,
"heapUsedBytes": 117437528,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 139.824,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.0349999999389,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.17,
"layouts": 9,
"layoutDurationMs": 2.4070000000000005,
"taskDurationMs": 388.157,
"heapDeltaBytes": 22571984,
"heapUsedBytes": 112837636,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 144.02599999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2041.9969999999807,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.952,
"layouts": 9,
"layoutDurationMs": 2.938,
"taskDurationMs": 631.826,
"heapDeltaBytes": -14144128,
"heapUsedBytes": 77665640,
"domNodes": 0,
"jsHeapTotalBytes": 757760,
"scriptDurationMs": 10.476,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.718999999991,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.92,
"layouts": 9,
"layoutDurationMs": 2.785,
"taskDurationMs": 618.777,
"heapDeltaBytes": -14269484,
"heapUsedBytes": 91819364,
"domNodes": -214,
"jsHeapTotalBytes": 2527232,
"scriptDurationMs": 10.411999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.9699999999943,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.530000000000001,
"layouts": 10,
"layoutDurationMs": 3.0399999999999996,
"taskDurationMs": 803.45,
"heapDeltaBytes": -14017892,
"heapUsedBytes": 91706432,
"domNodes": -186,
"jsHeapTotalBytes": 4100096,
"scriptDurationMs": 107.422,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846145,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1974.2969999999787,
"styleRecalcs": 88,
"styleRecalcDurationMs": 16.426000000000002,
"layouts": 10,
"layoutDurationMs": 3.085,
"taskDurationMs": 1093.8780000000002,
"heapDeltaBytes": -6418924,
"heapUsedBytes": 94435116,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 106.78999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491525,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.8260000000241,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.515999999999995,
"layouts": 5,
"layoutDurationMs": 12.255000000000003,
"taskDurationMs": 1048.1370000000002,
"heapDeltaBytes": 35923104,
"heapUsedBytes": 137714884,
"domNodes": 15950,
"jsHeapTotalBytes": 11149312,
"scriptDurationMs": 42.278,
"eventListeners": 3244,
"totalBlockingTimeMs": 142,
"frameDurationMs": 19.634246575342456,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8476.648000000012,
"styleRecalcs": 249,
"styleRecalcDurationMs": 18.56,
"layouts": 7,
"layoutDurationMs": 2.0629999999999997,
"taskDurationMs": 6240.337,
"heapDeltaBytes": 1792160,
"heapUsedBytes": 103925640,
"domNodes": -292,
"jsHeapTotalBytes": -917504,
"scriptDurationMs": 2681.5220000000004,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73181818181818,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8255.81599999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 19.111,
"layouts": 8,
"layoutDurationMs": 2.1990000000000003,
"taskDurationMs": 5383.522,
"heapDeltaBytes": 1064532,
"heapUsedBytes": 103142800,
"domNodes": -272,
"jsHeapTotalBytes": -1179648,
"scriptDurationMs": 2669.002,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665858585858587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 20374.526,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19756.037,
"heapDeltaBytes": -52540968,
"heapUsedBytes": 277081576,
"domNodes": -3330,
"jsHeapTotalBytes": 6803456,
"scriptDurationMs": 279.28000000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.52795698924731,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 14200.602000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13311.805,
"heapDeltaBytes": 5342208,
"heapUsedBytes": 306466852,
"domNodes": -3330,
"jsHeapTotalBytes": 19124224,
"scriptDurationMs": 206.57199999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.49516407599309,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 16713.814000000013,
"styleRecalcs": 104,
"styleRecalcDurationMs": 9.955999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16314.164999999999,
"heapDeltaBytes": 5397760,
"heapUsedBytes": 310401396,
"domNodes": -3334,
"jsHeapTotalBytes": 18530304,
"scriptDurationMs": 941.867,
"eventListeners": -651,
"totalBlockingTimeMs": 152,
"frameDurationMs": 30.58976234003656,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 25033.36899999999,
"styleRecalcs": 178,
"styleRecalcDurationMs": 18.303000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24789.108000000004,
"heapDeltaBytes": -32579660,
"heapUsedBytes": 278408624,
"domNodes": -3330,
"jsHeapTotalBytes": 8376320,
"scriptDurationMs": 881.562,
"eventListeners": -651,
"totalBlockingTimeMs": 12,
"frameDurationMs": 47.49962049335864,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 5134.014000000036,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.85200000000002,
"layouts": 20,
"layoutDurationMs": 30.518000000000004,
"taskDurationMs": 5023.668,
"heapDeltaBytes": -44941884,
"heapUsedBytes": 275291860,
"domNodes": -3330,
"jsHeapTotalBytes": 13619200,
"scriptDurationMs": 83.57999999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.554166666666667,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 5110.095999999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.006,
"layouts": 20,
"layoutDurationMs": 35.61300000000001,
"taskDurationMs": 5033.591,
"heapDeltaBytes": -34510020,
"heapUsedBytes": 286120032,
"domNodes": -3330,
"jsHeapTotalBytes": 7065600,
"scriptDurationMs": 83.60000000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.822289156626507,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6898.377000000039,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6364.190999999998,
"heapDeltaBytes": -4375348,
"heapUsedBytes": 295258472,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 98.71599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.380565371024737,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6896.4469999999665,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6387.088000000001,
"heapDeltaBytes": 105012,
"heapUsedBytes": 298180032,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 101.28399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.20947368421053,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 142.7250000000413,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.463,
"layouts": 10,
"layoutDurationMs": 4.429,
"taskDurationMs": 107.683,
"heapDeltaBytes": 4887296,
"heapUsedBytes": 101735612,
"domNodes": 120,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.943999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.655555555555566,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 477.8069999999843,
"styleRecalcs": 18,
"styleRecalcDurationMs": 11.275,
"layouts": 11,
"layoutDurationMs": 4.409000000000001,
"taskDurationMs": 136.237,
"heapDeltaBytes": -12568440,
"heapUsedBytes": 88821356,
"domNodes": 121,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.759,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 450.78699999999117,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.743,
"layouts": 76,
"layoutDurationMs": 15.738999999999999,
"taskDurationMs": 407.99100000000004,
"heapDeltaBytes": -15724520,
"heapUsedBytes": 76110824,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 189.493,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 470.0759999999491,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.766,
"layouts": 76,
"layoutDurationMs": 16.149,
"taskDurationMs": 428.88200000000006,
"heapDeltaBytes": -15106096,
"heapUsedBytes": 77015708,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 198.876,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 621.2620000000015,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.0010000000000003,
"layouts": 76,
"layoutDurationMs": 16.688000000000002,
"taskDurationMs": 580.817,
"heapDeltaBytes": 880088,
"heapUsedBytes": 117570176,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 235.905,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 504.6189999999342,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.1159999999999997,
"layouts": 76,
"layoutDurationMs": 15.549999999999999,
"taskDurationMs": 463.956,
"heapDeltaBytes": -312236,
"heapUsedBytes": 119872780,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 176.27100000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2284 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 34cf76e7808a5ae202caf7f838d2d144966b9d75
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ECaution Some tests failed. Open the report below and fix the failures before merging. Test results
Warning 3 non-screenshot failures — these require manual review. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## update-ingest-types #21237 +/- ##
=======================================================
+ Coverage 86.59% 87.40% +0.81%
=======================================================
Files 3765 2688 -1077
Lines 177975 149297 -28678
Branches 47020 38829 -8191
=======================================================
- Hits 154111 130493 -23618
+ Misses 21797 18414 -3383
+ Partials 2067 390 -1677
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1085 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Render Plan.action for the matched personal plan as received: none disables the CTA and blocks the emit, reactivate resumes, and the other actions pick the label. denied_reason and denied_reason_params.effective_at drive the copy under the CTA. The client-side composition of canSelectPersonalPlan, offersTransition and personalPlanActionPermitted no longer decides the personal CTA. A missing plan fails closed, the default the contract names for unknown state.
1c557e5 to
8e89fba
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at exact head 8e89fba3aab80cb8959282320dc3883fa734f93d.
- Personal-plan buttons now render the server's per-plan action, fail closed when the catalog fact is unavailable, and block emits for
none. - Catalog adoption remains fenced by user and active workspace, preserving tab-local workspace selection and rejecting stale workspace responses.
- Required CI is settled green, with zero review threads.
Full context for agent readers
The merged backend contract in Cloud PR 13809 defines action as the exact plan-and-interval presentation fact and keeps write endpoints authoritative. This change consumes that fact without reconstructing eligibility from tier, subscription, or capability combinations.
Unknown or missing plan data disables the personal CTA. Known denial reasons use local copy, subscription_change_in_progress uses the server's optional effective date, and unknown reasons use a generic refusal. reactivate remains distinct from subscribe/change/downgrade, and both the disabled state and event routing have focused unit and browser coverage.
The dependency is exact: this head targets the live PR 20840 object 34cf76e7808a5ae202caf7f838d2d144966b9d75, which carries the required generated types and fixture updates. No package boundary, session transport, top-up state machine, or workspace-selection behavior changes here.
…rop the client-derived original owner (#21266) ## Summary Leave and Downgrade-to-personal now render the server's `can_leave_workspace` and `can_downgrade_to_personal`. The store's `isCurrentUserOriginalOwner`, a client-derived server fact (ADR-API-SERVER-FACTS-0042), is deleted. - Fixes FE-3435 - Stacked on PR 20840 (`update-ingest-types`), which syncs `can_manage_subscription` into `packages/ingest-types`. Base is `update-ingest-types`; retarget to `main` after it merges. **Why:** `useWorkspaceUI.getPermissions` decided Leave and Downgrade from the role plus `store.isCurrentUserOriginalOwner`, which matched the current user's email against the members list and fell back to the earliest-joined owner. The server already answers both questions on every rail: `can_leave_workspace` comes from ingest's workspace capabilities (rail-independent, cloud#13154), and `can_downgrade_to_personal` is served on Cloud and, since PR 21229, on local. **Root cause:** the gate predates the capability fields. `canLeaveWorkspace` re-implemented the server's leave rule (Team plan, not the creator, creator identity resolved) and on a team workspace granted Leave to everyone, so a team creator or sole owner only learned from the 403 after confirming (FE-2168). Off Cloud, `canDowngradeToPersonal` was `owner && isTeamPlan && isOriginalOwner`. **How:** - `useBillingCapabilities` exposes `canLeaveWorkspace` as a `ServerFact<'can_leave_workspace'>`. - `getPermissions` takes `canLeaveWorkspace` and `canDowngradeToPersonal` as received instead of role, plan and original-owner inputs. Consumers (`UnifiedPricingTable`, `useSubscriptionCheckout`, `useDowngradeToPersonal`, the workspace menu) are untouched: their `isCloud ? capability : permissions.canDowngradeToPersonal` branches now read the same fact on both sides, and collapsing them is left out of this PR to stay clear of PR 21229's follow-ups and FE-3455. - `isCurrentUserOriginalOwner` and `useWorkspaceUI().isOriginalOwner` are deleted (no remaining readers). `originalOwnerId` stays for the members panel creator badge and sort, which read member data. - `useBillingCapabilities` exposes `canManageSubscription` as a `ServerFact<'can_manage_subscription'>` (BE-20308, synced in PR 20840). `canManageSubscription` and `canManageSubscriptionLifecycle` render it as received; the `pendingServerFact('BE-20308', role === 'owner')` bridge is removed. Every consumer reads the same `permissions` fields, so a role-owner without the served fact (capabilities unread, or the server answering false) no longer gets subscription surfaces. - `useWorkspaceUI` takes its gate types from `useBillingCapabilities` instead of importing `serverFacts`, which clears the new `workspace/application -> server-facts/domain` boundary findings. Behaviour change: subscription surfaces now wait for `can_manage_subscription` instead of the owner role. Leave is hidden whenever `can_leave_workspace` is false (team creator, sole owner, SSO-managed membership, capabilities unread) instead of being offered and refused by the server. The denial copy for those reasons is FE-2168 / FE-3455. ## Verification - `pnpm exec vitest run src/platform/workspace src/components/actionbar src/composables/billing`: 3447 passed. - `useWorkspaceUI.test.ts`: one N + M + 1 server-fact table. Fact rows (all served, all withheld, one-hot per fact) run for a team member; actor rows give owners all-withheld and members all-served, so a role-derived gate fails. The menu opens for a team member and a personal owner only through `can_leave_workspace`. The original-owner derivation tests are replaced. - `useBillingCapabilities.test.ts`: `canManageSubscription` renders the served value both ways. - `teamWorkspaceStore.test.ts`: the `isCurrentUserOriginalOwner` block is removed with the getter; `originalOwnerId` tests remain. - `oxfmt`, `oxlint --type-aware`, `eslint`, `typecheck:app`, `lint:server-facts --base origin/main`: clean. ## Feature flag No rollout flag. `getPermissions` in `src/platform/workspace/composables/useWorkspaceUI.ts` now reads `can_leave_workspace`, `can_manage_subscription` and `can_downgrade_to_personal` as served, for every Cloud workspace user, on both the legacy Plan & Credits panel and the unified Billing tab. The `?pricing=` deep link (`usePricingTableUrlLoader.ts`) is unflagged too. `ff:unified_billing_settings=true` in the screenshots only selects the Billing tab layout (`src/platform/settings/composables/useSettingUI.ts`). ## AS IS / TO BE | AS IS | TO BE | | --- | --- | | <img width="480" src="https://gist.githubusercontent.com/dante01yoon/f05b225a0dd4f95ac7135d5653415008/raw/21266-asis-1.png"> | <img width="480" src="https://gist.githubusercontent.com/dante01yoon/f05b225a0dd4f95ac7135d5653415008/raw/21266-tobe-1.png"> | | Members ⋯ menu, team workspace the user created (`can_leave_workspace: false`, `workspace_creator`). Local `pnpm dev:cloud` against testcloud.comfy.org, 1440x900, signed in as a real account; `ff:unified_billing_settings=true` set locally. AS IS origin/main `c50a309fbc`: Leave offered. TO BE `69d3741fb5`: Leave hidden. | | | <img width="480" src="https://gist.githubusercontent.com/dante01yoon/f05b225a0dd4f95ac7135d5653415008/raw/21266-asis-2.png"> | <img width="480" src="https://gist.githubusercontent.com/dante01yoon/f05b225a0dd4f95ac7135d5653415008/raw/21266-tobe-2.png"> | | Billing tab, same workspace, owner with `can_manage_subscription: true`. AS IS origin/main `c50a309fbc`, TO BE `69d3741fb5`: Manage stays visible once the fact is served. | | The AS IS shots were taken on `main`, not on this PR's base `update-ingest-types`. The base also carries the ingest type sync, #21237 and #21289. The TO BE shots are from `69d3741fb5`. Later commits only touch E2E fixtures and the `?pricing=` deep-link loader, which these shots don't show. Not captured: Downgrade to personal. testcloud answers `can_downgrade_to_personal: false` (`rollout_disabled`) for every workspace on the test account, and Cloud already read that capability before this PR, so there is no visible difference to show. ## Plan position | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Sync types, decode denial reasons | FE-3432 | PR 20973 | Merged | | Delete follows `can_delete_workspace` | FE-3433 | PR 21117 | Merged | | Add credits follows `can_top_up` | FE-3434 | PR 21116 | Merged | | Local reads capabilities | FE-3453 | PR 21229 | Merged | | Leave denial copy | FE-2168 | — | Backlog | | Workspace menu (Leave/Delete) | FE-3455 | — | In progress | | Ingest types sync (`can_manage_subscription`) | BE-20308 | PR 20840 | Open | | **Remove client-derived original owner** | **FE-3435** | **This PR** | **Open** | ```mermaid flowchart LR A["FE-3432 sync (PR 20973)"] --> B["FE-3433 Delete (PR 21117)"] A --> C["FE-3434 Add credits (PR 21116)"] A --> L["FE-3453 local capabilities (PR 21229)"] B --> E["FE-3435 remove derived owner (this PR)"] L --> E S["ingest-types sync (PR 20840)"] --> E E --> F["FE-2168 Leave denial copy"] E --> G["FE-3455 workspace menu"] classDef here fill:#fde68a,stroke:#b45309,color:#000 class E here ```
Why
Answers christian-byrne's review on PR 20996: #20996 (review). The personal-plan CTA stayed live for plans the server refuses (
billing_operation_parked,billing_operation_in_progress, ...) until checkout rejected them.Root cause
UnifiedPricingTabledecided the personal CTA on the client:canSelectPersonalPlan && offersTransition(isCurrentPlan(tier)) && personalPlanActionPermitted, a composition of capabilities, tier and plan state. It never read the plan the server returned for that card. Addingavailability.availablewith another&&is the derivation ADR-API-SERVER-FACTS-0042 forbids, and the server-fact gate rejects it.How
Plannow carries a per-plan, per-intervalaction(subscribe | change | reactivate | downgrade | none) withdenied_reason/denied_reason_params("Render as received... none disables the choice"). The personal CTA renders that one field forgetApiPlanForTier(tier, cycle):nonedisables the CTA and blocks the emit.reactivateemitsresubscribewith "Resume {plan}".subscribeuses "Subscribe to {plan}".changeanddowngradeuse "Change to {plan}". All three emitsubscribe.none+same_planreads "Current Plan". A cancelled current plan getsreactivatefrom the server, so resubscribe is not blocked.isLoading(local UI state) can also disable it.canSelectPersonalPlan,offersTransition,personalPlanActionPermitted,isCurrentPlanand the tier/slug matching no longer decide the personal CTA.personalPlanActionPermitted,isCurrentPlan,isScheduledDestinationand the "Scheduled for {date}" card label are deleted; the footer notice still shows the scheduled change. The team CTA and the personal/team scope toggle are unchanged.pendingServerFactdoesn't apply, and the contract names "Unknown or unavailable state fails closed" as the default (ADR rule 3)./api/billing/plansis the only plans source for the unified table, so this state only appears while the catalog is loading or after its read fails.denied_reasoncopy shows under the CTA (map + generic fallback, same shape asuseDeleteWorkspaceGate).Plan.action,TeamCreditStopPrice.action, the new requiredBillingCapabilitiesfields, the new capability denial reasons) now lives on PR 20840 itself, so this PR's diff is only the CTA change.denied_reasonnot_a_membernot_workspace_ownernot_original_ownersales_managedbilling_operation_parkedbilling_operation_in_progresssubscription_change_in_progress+effective_atsubscription_change_in_progresswithout dateannual_to_monthly_unsupportedincompatible_transitionexceeds_max_seatsbilling_state_unknownsame_planNeeds backend sign-off (ADR rule 5): this PR picks
Plan.actionas the field that answers "can this personal card be chosen". Please confirm with the billing backend owners thataction(notavailability.availableor the capability set) is the intended answer for this CTA.Stacking: based on PR 20840 (
update-ingest-types, cloud@dbf02e1a plus its fixture fixes), so it must merge after that PR.Verification
pnpm exec vitest runon the touched unit tests (20 files, 1,268 tests) passes, includingUnifiedPricingTable.test.ts(52) with table-driven cases: each actionableactionenables the CTA and emits;nonefor everydenied_reasondisables it, blocks the emit and shows the copy;same_planreads "Current Plan" with no line; a cancelled current plan withreactivateresubscribes; a missing plan fails closed; billing capabilities never change the result (orthogonality).lint:server-facts --staged,typecheck:app,typecheck:browser, oxfmt, oxlint, eslint, unused-i18n. The pre-push knip/fallow audit passes.pricingTableCapabilityGating.spec.tsbecomes the plan-action e2e (server action decides, capabilities don't).pricingTableDeepLink.spec.tsplans carry the actions the server would send.AS IS / TO BE
Plan position
Plan.action