Repository navigation
[backport core/1.55] FE-1908 / DES-1033 fix(billing): offer hosted checkout when top-up has no default payment method (#21180) - #21222
Conversation
…s no default payment method (#21180) Consolidated-rail top-up now recovers from `NO_PAYMENT_METHOD` by offering Stripe-hosted Checkout for the same amount instead of ending on an error toast. Supersedes the copy change in #21171. **Why.** Off-session top-up (`POST /api/billing/topup`) is the only purchase path once a workspace leaves `legacy_stripe`. A workspace without a Stripe invoice default gets a dead-end toast and cannot buy credits at all. **Root cause (backend, confirmed on BE-5732).** `CreateTopup` charges only the customer's live Stripe `invoice_settings.default_payment_method`. A card saved only on the subscription, or merely attached, does not count, and the resolver deliberately does not promote one. `can_top_up` does not cover payment-method readiness: capabilities are UI guidance, so a `can_top_up: true` workspace can still be refused. **How.** - On a definitive `NO_PAYMENT_METHOD` refusal, the confirm step shows an inline hint and swaps **Pay** for **Continue to checkout**. Every other refusal keeps its existing toast. The refusal happens before any billing operation is reserved, so this cannot start a second payment for an in-flight purchase. - **Continue to checkout** calls the existing hosted endpoint `POST /api/billing/topup/checkout` with the selected amount and a `return_url` chosen by `topupCheckoutReturnUrl`: cloud web returns to `location.href`; Desktop, Desktop 2 and local web return to billing-web's neutral `/return/topup` page (#21199, renamed in #21205), because their own origin is not an allowed return host. The billing-web origin comes from `billing_web_url`, else from the connected Cloud environment (`billing.comfy.org` / `stagingbilling.comfy.org` / `testbilling.comfy.org`), since a local `/api/features` has none. If no origin resolves, checkout is not started. It goes through `sdk.topup.createHostedTopupCheckout` on the SDK rail and a new `workspaceApi.createTopupCheckout` on the legacy rail, so issue and recovery stay on one rail. It then sets the pending top-up marker so the balance refreshes on return, and opens Checkout. On Desktop the URL goes to the system browser through the host's popup handler. - Per DES review: a blocked checkout tab switches the dialog to a "Checkout didn't open" screen with an **Open checkout** retry (a fresh click) instead of navigating the app away, and a checkout that fails to open shows "The payment page couldn't open. Nothing was charged. Try again." inline instead of a Purchase Failed toast. - No new capability field: the hosted endpoint has no payment-method precondition, no rail branch and no flag gate, so a `can_top_up_hosted_checkout` would always equal `can_top_up` (agreed on FE-1908). - `noPaymentMethodError` is replaced by `noPaymentMethodCheckoutHint`: "This workspace has no card saved for one-click top-ups. Pay on a checkout page instead." It no longer points to Billing & invoices, because the generic portal does not set an invoice default. **Set a default card** (`flow_type: payment_method_update`, cloud#13970) follows once that flow is live in production. Linear: FE-1908, DES-1033 - Comfy Desktop 1.1.7 (Desktop 2) pointed at this branch (`dev:cloud`, testcloud, SDK rail), with `NO_PAYMENT_METHOD` stubbed on `POST /api/billing/topup`: the refused screen offers Continue to checkout; `POST /api/billing/topup/checkout` is sent with `return_url=https://testbilling.comfy.org/return/topup`; `window.open(checkout.comfy.org/...)` is handed to the system browser and the dialog closes without the blocked screen; a sandbox test-card payment lands on the neutral return page; switching back to the app fires `focus`, which refetches `/api/billing/balance` and moves the balance from 90,909 to 101,459 (+10,550). - Local e2e `topUpNoPaymentMethod.spec.ts` against a local backend: passed (local build sends the billing-web return page). - `topupCheckoutReturnUrl.test.ts`: cloud web, server origin, prefixed origin, each environment fallback, unresolved. - `pnpm exec vitest run` on `TopUpCreditsDialogContentWorkspace.test.ts`, `topupOperationView.test.ts`, `useTopupOperation.test.ts`, `billingSdkStore.test.ts`: 181 passed. - New: checkout opens for the refused amount and the marker is set (legacy rail); checkout failure keeps the dialog open with an error; other refusals do not offer checkout; SDK rail routes through `createHostedTopupCheckout`; hosted-checkout failure projection. - `oxfmt`, `oxlint --type-aware`, `eslint`, server-fact gate, `typecheck:app` clean. <table> <tr><th>AS IS</th><th>TO BE</th></tr> <tr> <td> https://github.com/user-attachments/assets/6e32d1f8-32ae-4898-9b17-d88d4c50c98d </td> <td> https://github.com/user-attachments/assets/bf51da8b-508b-40ae-92a9-53c9fb1f0570 </td> </tr> <tr> <td>main build in Comfy Desktop 2: Pay ends on a "Purchase Failed" toast that points at a Manage billing button that does not exist.</td> <td>This PR in Comfy Desktop 2: refused, Continue to checkout, Stripe sandbox checkout in the system browser, test-card payment, billing-web return page, and back in the app the balance goes from 101,459 to 112,009.<br><br>The return page in this recording still shows the old title; #21205 renames it to "Return to ComfyUI" at <code>/return/topup</code>.</td> </tr> </table> | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Fix "Manage billing" copy | FE-1908 | #21171 | Superseded by this PR | | **Hosted checkout recovery on `NO_PAYMENT_METHOD`** | **FE-1908 / DES-1033** | **this PR** | **In review** | | Migration gate reads the live Stripe invoice default, not the stored field | BE-20139 follow-up | – | Proposed | | Neutral billing-web return page | FE-3464 | #21199 | Merged | | Generic return path and title (`/return/topup`, "Return to ComfyUI") | FE-3464 | #21205 | In review | | Test/staging return hosts | – | Comfy-Org/cloud#13964 | Merged | | Set a default card (`payment_method_update`) | BE-21143 | Comfy-Org/cloud#13970 | Merged, not in prod | ```mermaid graph LR A["PR 21171: copy fix"] -.->|"superseded"| B["This PR: hosted checkout recovery"] C["BE: migration gate uses live invoice default"] --> D["Fewer NO_PAYMENT_METHOD refusals"] B --> D E["PR 21199: billing-web return page"] --> B style B fill:#f9d71c,stroke:#333,stroke-width:2px ``` (cherry picked from commit fe4189d) (cherry picked from commit 70ec2c4)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-17T04:03:16.131Z",
"gitSha": "ab09d10176ea803ac099802bd0b7486e4590072c",
"branch": "backport-21180-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1989.891,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.099000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.88999999999993,
"heapDeltaBytes": 3917052,
"heapUsedBytes": 72761572,
"domNodes": -260,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.241999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2007.5610000000097,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.856000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.57599999999996,
"heapDeltaBytes": 7800816,
"heapUsedBytes": 76662600,
"domNodes": -260,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.950000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1734.0050000000247,
"styleRecalcs": 44,
"styleRecalcDurationMs": 12.726,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 765.8510000000001,
"heapDeltaBytes": 4825748,
"heapUsedBytes": 73729424,
"domNodes": -262,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 158.35,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1748.7109999999575,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.173,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 795.8389999999999,
"heapDeltaBytes": -8352172,
"heapUsedBytes": 61039636,
"domNodes": -263,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 160.296,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.3519999999812,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.806999999999999,
"layouts": 6,
"layoutDurationMs": 1.05,
"taskDurationMs": 319.54499999999996,
"heapDeltaBytes": 2513660,
"heapUsedBytes": 65438120,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.169999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.5700000000088,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.056,
"layouts": 6,
"layoutDurationMs": 1.2100000000000002,
"taskDurationMs": 314.712,
"heapDeltaBytes": 3557432,
"heapUsedBytes": 72618808,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.939,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 615.1499999999714,
"styleRecalcs": 15,
"styleRecalcDurationMs": 8.001999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.531,
"heapDeltaBytes": -7994220,
"heapUsedBytes": 61269544,
"domNodes": 22,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 168.449,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 641.8139999999539,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.478000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.66300000000007,
"heapDeltaBytes": -7372592,
"heapUsedBytes": 61838304,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 170.796,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1166.4200000000164,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 808.8309999999999,
"heapDeltaBytes": 35417648,
"heapUsedBytes": 100858584,
"domNodes": -263,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 66.251,
"eventListeners": -195,
"totalBlockingTimeMs": 536,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1145.9559999999556,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 803.7379999999999,
"heapDeltaBytes": 34898192,
"heapUsedBytes": 102384508,
"domNodes": 0,
"jsHeapTotalBytes": 20082688,
"scriptDurationMs": 71.69600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 538,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 828.1110000000353,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.48499999999956,
"heapDeltaBytes": 14521444,
"heapUsedBytes": 90295412,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 155.704,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.911999999932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.17899999999986,
"heapDeltaBytes": 14365040,
"heapUsedBytes": 91058972,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.659,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9915.036999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9025.499,
"heapDeltaBytes": 1441932,
"heapUsedBytes": 82923524,
"domNodes": -18,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 7793.816,
"eventListeners": 0,
"totalBlockingTimeMs": 1360,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8903.894000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8100.746000000001,
"heapDeltaBytes": 11876072,
"heapUsedBytes": 85603788,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 6978.589999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 759,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9997.914000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9137.395999999999,
"heapDeltaBytes": 8709396,
"heapUsedBytes": 84561732,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7645.44,
"eventListeners": 0,
"totalBlockingTimeMs": 1049,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9474.26500000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8606.137,
"heapDeltaBytes": 3081984,
"heapUsedBytes": 84423948,
"domNodes": -12,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7166.382,
"eventListeners": 0,
"totalBlockingTimeMs": 846,
"frameDurationMs": 20.003333333333284,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2032.133999999985,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.923,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.5070000000001,
"heapDeltaBytes": -23502680,
"heapUsedBytes": 65921372,
"domNodes": -254,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 30.32699999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2024.695999999949,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.1,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.4429999999999,
"heapDeltaBytes": -23303308,
"heapUsedBytes": 65764920,
"domNodes": -254,
"jsHeapTotalBytes": 2912256,
"scriptDurationMs": 31.889999999999993,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2216.4399999999773,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.259,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1557.464,
"heapDeltaBytes": -24731924,
"heapUsedBytes": 65571096,
"domNodes": -220,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 844.176,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2184.035000000108,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.18,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1467.195,
"heapDeltaBytes": 30994752,
"heapUsedBytes": 95757744,
"domNodes": -244,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 807.122,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3542.2490000000266,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.061,
"layouts": 60,
"layoutDurationMs": 12.548,
"taskDurationMs": 1601.1540000000002,
"heapDeltaBytes": 97832,
"heapUsedBytes": 65738252,
"domNodes": 32,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 787.082,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3464.805999999953,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.239999999999997,
"layouts": 60,
"layoutDurationMs": 12.678999999999998,
"taskDurationMs": 1572.533,
"heapDeltaBytes": 942244,
"heapUsedBytes": 65956612,
"domNodes": 30,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 769.328,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2986.390999999969,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.081999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1889.715,
"heapDeltaBytes": -22644316,
"heapUsedBytes": 70854928,
"domNodes": -223,
"jsHeapTotalBytes": 1601536,
"scriptDurationMs": 1017.3519999999999,
"eventListeners": 28,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2938.9230000000452,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.045000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1802.8100000000002,
"heapDeltaBytes": 12774500,
"heapUsedBytes": 99510872,
"domNodes": 14,
"jsHeapTotalBytes": 6221824,
"scriptDurationMs": 959.773,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.21999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1989.8339999999735,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.036999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.29900000000004,
"heapDeltaBytes": 9551720,
"heapUsedBytes": 74198684,
"domNodes": -248,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.883,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2049.427000000037,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.274000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.9549999999999,
"heapDeltaBytes": -19278032,
"heapUsedBytes": 72718636,
"domNodes": -266,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 29.321,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.4019999999923,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.539000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.2009999999999,
"heapDeltaBytes": 13622744,
"heapUsedBytes": 84058504,
"domNodes": 21,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 139.502,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 571.1900000000014,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.766000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.30099999999993,
"heapDeltaBytes": 14284520,
"heapUsedBytes": 85337464,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 137.389,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2008.734000000004,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.733999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.91700000000003,
"heapDeltaBytes": 2470244,
"heapUsedBytes": 72892776,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.831999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.5250000000106,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.31,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.841,
"heapDeltaBytes": 7764428,
"heapUsedBytes": 78903684,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.035999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.6750000000043,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.305,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 685.097,
"heapDeltaBytes": -9739792,
"heapUsedBytes": 61425732,
"domNodes": -273,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 98.06700000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.0769999999184,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.800000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 716.3530000000001,
"heapDeltaBytes": -9364056,
"heapUsedBytes": 61424176,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 103.40599999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 933.0479999999852,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.144000000000002,
"layouts": 5,
"layoutDurationMs": 12.983000000000002,
"taskDurationMs": 703.2750000000001,
"heapDeltaBytes": -6317208,
"heapUsedBytes": 81896156,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 28.334999999999994,
"eventListeners": 2383,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8269.77599999998,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.134,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5440.928,
"heapDeltaBytes": -4835084,
"heapUsedBytes": 84588524,
"domNodes": -253,
"jsHeapTotalBytes": 5464064,
"scriptDurationMs": 2764.9680000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8201.902000000018,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.80799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4720.798999999999,
"heapDeltaBytes": 2914292,
"heapUsedBytes": 92305756,
"domNodes": -240,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 2668.255,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16834.569999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16336.455000000002,
"heapDeltaBytes": -63162316,
"heapUsedBytes": 172281884,
"domNodes": -8061,
"jsHeapTotalBytes": -10870784,
"scriptDurationMs": 246.60199999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16343.524000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15586.405,
"heapDeltaBytes": -74870520,
"heapUsedBytes": 165331864,
"domNodes": -8061,
"jsHeapTotalBytes": -15708160,
"scriptDurationMs": 251.145,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20118.032999999967,
"styleRecalcs": 157,
"styleRecalcDurationMs": 15.373999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19712.342,
"heapDeltaBytes": -54112872,
"heapUsedBytes": 181431500,
"domNodes": -8061,
"jsHeapTotalBytes": -14540800,
"scriptDurationMs": 891.7579999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 42,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19816.181999999913,
"styleRecalcs": 170,
"styleRecalcDurationMs": 16.359999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19470.141000000003,
"heapDeltaBytes": -47652348,
"heapUsedBytes": 192188096,
"domNodes": -8061,
"jsHeapTotalBytes": -17612800,
"scriptDurationMs": 860.6709999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 58,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4500.296999999932,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.28399999999998,
"layouts": 20,
"layoutDurationMs": 29.163999999999994,
"taskDurationMs": 4385.546,
"heapDeltaBytes": -49952028,
"heapUsedBytes": 177767188,
"domNodes": -8061,
"jsHeapTotalBytes": 6090752,
"scriptDurationMs": 81.14299999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 42,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5950.6979999999885,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.698,
"layouts": 20,
"layoutDurationMs": 21.41000000000001,
"taskDurationMs": 5809.473,
"heapDeltaBytes": -44940160,
"heapUsedBytes": 190625828,
"domNodes": -8061,
"jsHeapTotalBytes": 9838592,
"scriptDurationMs": 119.236,
"eventListeners": -14928,
"totalBlockingTimeMs": 316,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8249.11300000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8040.275,
"heapDeltaBytes": -5599044,
"heapUsedBytes": 171442408,
"domNodes": 0,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 124.92800000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8348.790000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8087.431999999998,
"heapDeltaBytes": -1509888,
"heapUsedBytes": 185124192,
"domNodes": -4,
"jsHeapTotalBytes": -16252928,
"scriptDurationMs": 118.969,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 447.96599999995124,
"styleRecalcs": 15,
"styleRecalcDurationMs": 25.017000000000003,
"layouts": 3,
"layoutDurationMs": 1.3890000000000002,
"taskDurationMs": 113.86699999999999,
"heapDeltaBytes": 5042788,
"heapUsedBytes": 71629024,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.083000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 101.67899999999008,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.627,
"layouts": 5,
"layoutDurationMs": 2.088,
"taskDurationMs": 81.234,
"heapDeltaBytes": 3078424,
"heapUsedBytes": 69842796,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.826999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2156 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (32 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7ab461f170c2bba8916faae4cda606278fa367a4
Full docs: ADR-DEVEX-LINT-0015 |
christian-byrne
left a comment
There was a problem hiding this comment.
Backport fidelity check against the merged original (#21180), per branch: diffed sorted +/- lines against the original, then diffed the resulting files for every mismatch rather than calling a line mismatch a failure on its own.
Every remaining difference traces to this branch's pre-existing state (before that PR), not to a content loss:
TopUpCreditsDialogContentWorkspace.vueuses<h2>for step titles here (vs<DialogTitle>on main) — confirmed the pre-backport file on this branch already used<h2>throughout, so this predates the design-systemDialogTitleadoption on main.- Toast assertions reference the branch's existing
useToast: () => ({ add: mockToastAdd })mock shape rather than main's newer.errorhelper — confirmed via the pre-backport test file. openHostedBillingTab.ts'sreserveBillingTab()null handling reads differently (early-returnif (!tab) return 'blocked'vs main'stab?.navigate(...)ternary) but is equivalently null-safe.
No package.json touched, so no packaging/exports risk. No open review threads. CI fully green at this head. Approving.
Manual backport of #21180 (FE-1908 / DES-1033). The bot's cherry-pick hit conflicts.
Why
On the consolidated billing rail, top-up dead-ends with
NO_PAYMENT_METHODwhen the workspace has no Stripe invoice default. This backport brings the hosted-checkout recovery, the billing-webreturn_urlfor non-cloud-web origins, and the Desktop billing-tab handoff (#21198, folded into #21180) to this release line.Root cause
Off-session top-up charges only the Stripe customer's invoice default, and the dialog had no recovery when that was missing. Details and fix design are in #21180.
How
Cherry-pick of the #21180 squash commit, with the conflicts resolved as below.
Conflict resolution
core/1.55 is the line ComfyUI core pins (
comfyui-frontend-package==1.55.17), so local users get the fix from here. It predates a lot ofmain's billing code, so the port keeps this branch's code and adds only #21180's behavior:TopUpCreditsDialogContentWorkspace.vue: keeps this branch's stepper, telemetry calls and toasts. Adds theNO_PAYMENT_METHODrefusal state, Continue to checkout, the "Checkout didn't open" screen and the inline open failure. Leaves out main'sreportTerminal/UncreditedTopupResponserefactor.topupOperationView.ts: addsprojectHostedTopupCheckoutResultand widenstopupFailureError. This branch'sWorkspaceApiErrorhas no failure category, so the test asserts the code only.workspaceApi.ts:createTopupCheckoutuses this branch'sgetAuthHeaderOrThrowand the one-argumenthandleAxiosError.openHostedBillingTaband Manage billing usereserveBillingTab; the subscription checkout, payment-method and SDK hosted-step opens useopenBillingUrl.useAuthActionsis left as on this branch: it never read a nullwindow.openas blocked.noPaymentMethodError(no longer used).After this merges, cut 1.55.18. ComfyUI's
requirements.txtthen needs to be bumped to it.Verification
viteston the top-up dialog,platform/workspace/billing,useTopupOperation,useWorkspaceBillingandcomposables/billing: all pass. The pre-commit hook ran lint and typecheck.AS IS / TO BE
See #21180 for the AS IS / TO BE recordings; this backport has no behavior of its own.