Repository navigation
[backport core/1.56] FE-1908 / DES-1033 fix(billing): offer hosted checkout when top-up has no default payment method (#21180) - #21220
Conversation
…s no default payment method (#21180) ## Summary Consolidated-rail top-up now recovers from `NO_PAYMENT_METHOD` by offering Stripe-hosted Checkout for the same amount instead of ending on an error toast. Supersedes the copy change in #21171. **Why.** Off-session top-up (`POST /api/billing/topup`) is the only purchase path once a workspace leaves `legacy_stripe`. A workspace without a Stripe invoice default gets a dead-end toast and cannot buy credits at all. **Root cause (backend, confirmed on BE-5732).** `CreateTopup` charges only the customer's live Stripe `invoice_settings.default_payment_method`. A card saved only on the subscription, or merely attached, does not count, and the resolver deliberately does not promote one. `can_top_up` does not cover payment-method readiness: capabilities are UI guidance, so a `can_top_up: true` workspace can still be refused. **How.** - On a definitive `NO_PAYMENT_METHOD` refusal, the confirm step shows an inline hint and swaps **Pay** for **Continue to checkout**. Every other refusal keeps its existing toast. The refusal happens before any billing operation is reserved, so this cannot start a second payment for an in-flight purchase. - **Continue to checkout** calls the existing hosted endpoint `POST /api/billing/topup/checkout` with the selected amount and a `return_url` chosen by `topupCheckoutReturnUrl`: cloud web returns to `location.href`; Desktop, Desktop 2 and local web return to billing-web's neutral `/return/topup` page (#21199, renamed in #21205), because their own origin is not an allowed return host. The billing-web origin comes from `billing_web_url`, else from the connected Cloud environment (`billing.comfy.org` / `stagingbilling.comfy.org` / `testbilling.comfy.org`), since a local `/api/features` has none. If no origin resolves, checkout is not started. It goes through `sdk.topup.createHostedTopupCheckout` on the SDK rail and a new `workspaceApi.createTopupCheckout` on the legacy rail, so issue and recovery stay on one rail. It then sets the pending top-up marker so the balance refreshes on return, and opens Checkout. On Desktop the URL goes to the system browser through the host's popup handler. - Per DES review: a blocked checkout tab switches the dialog to a "Checkout didn't open" screen with an **Open checkout** retry (a fresh click) instead of navigating the app away, and a checkout that fails to open shows "The payment page couldn't open. Nothing was charged. Try again." inline instead of a Purchase Failed toast. - No new capability field: the hosted endpoint has no payment-method precondition, no rail branch and no flag gate, so a `can_top_up_hosted_checkout` would always equal `can_top_up` (agreed on FE-1908). - `noPaymentMethodError` is replaced by `noPaymentMethodCheckoutHint`: "This workspace has no card saved for one-click top-ups. Pay on a checkout page instead." It no longer points to Billing & invoices, because the generic portal does not set an invoice default. **Set a default card** (`flow_type: payment_method_update`, cloud#13970) follows once that flow is live in production. Linear: FE-1908, DES-1033 ## Verification - Comfy Desktop 1.1.7 (Desktop 2) pointed at this branch (`dev:cloud`, testcloud, SDK rail), with `NO_PAYMENT_METHOD` stubbed on `POST /api/billing/topup`: the refused screen offers Continue to checkout; `POST /api/billing/topup/checkout` is sent with `return_url=https://testbilling.comfy.org/return/topup`; `window.open(checkout.comfy.org/...)` is handed to the system browser and the dialog closes without the blocked screen; a sandbox test-card payment lands on the neutral return page; switching back to the app fires `focus`, which refetches `/api/billing/balance` and moves the balance from 90,909 to 101,459 (+10,550). - Local e2e `topUpNoPaymentMethod.spec.ts` against a local backend: passed (local build sends the billing-web return page). - `topupCheckoutReturnUrl.test.ts`: cloud web, server origin, prefixed origin, each environment fallback, unresolved. - `pnpm exec vitest run` on `TopUpCreditsDialogContentWorkspace.test.ts`, `topupOperationView.test.ts`, `useTopupOperation.test.ts`, `billingSdkStore.test.ts`: 181 passed. - New: checkout opens for the refused amount and the marker is set (legacy rail); checkout failure keeps the dialog open with an error; other refusals do not offer checkout; SDK rail routes through `createHostedTopupCheckout`; hosted-checkout failure projection. - `oxfmt`, `oxlint --type-aware`, `eslint`, server-fact gate, `typecheck:app` clean. ### AS IS / TO BE <table> <tr><th>AS IS</th><th>TO BE</th></tr> <tr> <td> https://github.com/user-attachments/assets/6e32d1f8-32ae-4898-9b17-d88d4c50c98d </td> <td> https://github.com/user-attachments/assets/bf51da8b-508b-40ae-92a9-53c9fb1f0570 </td> </tr> <tr> <td>main build in Comfy Desktop 2: Pay ends on a "Purchase Failed" toast that points at a Manage billing button that does not exist.</td> <td>This PR in Comfy Desktop 2: refused, Continue to checkout, Stripe sandbox checkout in the system browser, test-card payment, billing-web return page, and back in the app the balance goes from 101,459 to 112,009.<br><br>The return page in this recording still shows the old title; #21205 renames it to "Return to ComfyUI" at <code>/return/topup</code>.</td> </tr> </table> ### Plan position | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Fix "Manage billing" copy | FE-1908 | #21171 | Superseded by this PR | | **Hosted checkout recovery on `NO_PAYMENT_METHOD`** | **FE-1908 / DES-1033** | **this PR** | **In review** | | Migration gate reads the live Stripe invoice default, not the stored field | BE-20139 follow-up | – | Proposed | | Neutral billing-web return page | FE-3464 | #21199 | Merged | | Generic return path and title (`/return/topup`, "Return to ComfyUI") | FE-3464 | #21205 | In review | | Test/staging return hosts | – | Comfy-Org/cloud#13964 | Merged | | Set a default card (`payment_method_update`) | BE-21143 | Comfy-Org/cloud#13970 | Merged, not in prod | ```mermaid graph LR A["PR 21171: copy fix"] -.->|"superseded"| B["This PR: hosted checkout recovery"] C["BE: migration gate uses live invoice default"] --> D["Fewer NO_PAYMENT_METHOD refusals"] B --> D E["PR 21199: billing-web return page"] --> B style B fill:#f9d71c,stroke:#333,stroke-width:2px ``` (cherry picked from commit fe4189d)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-17T03:58:00.835Z",
"gitSha": "44668259d38a93be94acfe56f3fb0213623035c8",
"branch": "backport-21180-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2015.6059999999911,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.9369999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.8790000000001,
"heapDeltaBytes": 1220292,
"heapUsedBytes": 69365280,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.053000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.2959999999966,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.6760000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.039,
"heapDeltaBytes": 1177532,
"heapUsedBytes": 69427708,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.62,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1772.499000000039,
"styleRecalcs": 54,
"styleRecalcDurationMs": 15.833,
"layouts": 12,
"layoutDurationMs": 4.449,
"taskDurationMs": 763.436,
"heapDeltaBytes": -2230596,
"heapUsedBytes": 62834564,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.156,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.6179999999322,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.732000000000003,
"layouts": 12,
"layoutDurationMs": 4.398,
"taskDurationMs": 782.1320000000001,
"heapDeltaBytes": 20676040,
"heapUsedBytes": 80778384,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.51300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1680.0690000000031,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.458000000000002,
"layouts": 6,
"layoutDurationMs": 1.171,
"taskDurationMs": 335.339,
"heapDeltaBytes": 140536,
"heapUsedBytes": 61998396,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.036999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1701.9970000000058,
"styleRecalcs": 30,
"styleRecalcDurationMs": 9.862,
"layouts": 6,
"layoutDurationMs": 1.2379999999999998,
"taskDurationMs": 332.42199999999997,
"heapDeltaBytes": 224636,
"heapUsedBytes": 62024612,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.921,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 671.6690000000085,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.7409999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.00700000000006,
"heapDeltaBytes": -6474672,
"heapUsedBytes": 61359220,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 168.013,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536566,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 675.1570000000129,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.2949999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.01200000000006,
"heapDeltaBytes": -7175060,
"heapUsedBytes": 61085572,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.22599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1147.9920000000448,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 800.9390000000001,
"heapDeltaBytes": 15127368,
"heapUsedBytes": 85858508,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 66.91,
"eventListeners": 0,
"totalBlockingTimeMs": 522,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1134.5460000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 796.841,
"heapDeltaBytes": 15906528,
"heapUsedBytes": 85288912,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 63.46399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 514,
"frameDurationMs": 34.34242424242425,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.4399999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.9909999999996,
"heapDeltaBytes": 16626540,
"heapUsedBytes": 103881472,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 165.70800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.2919999999722,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.1920000000004,
"heapDeltaBytes": 17378300,
"heapUsedBytes": 105320708,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 160.64300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9879.036999999982,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.0510000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9014.547,
"heapDeltaBytes": 493816,
"heapUsedBytes": 69464000,
"domNodes": -142,
"jsHeapTotalBytes": -3543040,
"scriptDurationMs": 7454.688,
"eventListeners": -74,
"totalBlockingTimeMs": 841,
"frameDurationMs": 32.34852459016394,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8448.847000000002,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.730999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7762.900000000001,
"heapDeltaBytes": -13678052,
"heapUsedBytes": 71848536,
"domNodes": -142,
"jsHeapTotalBytes": -11407360,
"scriptDurationMs": 6595.052,
"eventListeners": -74,
"totalBlockingTimeMs": 679,
"frameDurationMs": 34.20971659919028,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10460.756000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9702.869,
"heapDeltaBytes": 13258952,
"heapUsedBytes": 98705248,
"domNodes": -142,
"jsHeapTotalBytes": -5378048,
"scriptDurationMs": 8135.658999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 1164,
"frameDurationMs": 34.26098360655738,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8993.191000000024,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.1799999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8291.105,
"heapDeltaBytes": -12552036,
"heapUsedBytes": 72151176,
"domNodes": -142,
"jsHeapTotalBytes": -11407360,
"scriptDurationMs": 6819.806,
"eventListeners": -74,
"totalBlockingTimeMs": 559,
"frameDurationMs": 32.904761904761905,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2020.4800000000205,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.113,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.9920000000001,
"heapDeltaBytes": -9494436,
"heapUsedBytes": 78770532,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 32.52100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2024.2110000000366,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.583000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.00699999999995,
"heapDeltaBytes": -9579848,
"heapUsedBytes": 78915440,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.60099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2276.8669999999815,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.572,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1552.5950000000003,
"heapDeltaBytes": 10486268,
"heapUsedBytes": 90084744,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 842.2620000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666911764705887,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2311.9400000000496,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.078000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1565.9969999999998,
"heapDeltaBytes": -18828276,
"heapUsedBytes": 71102588,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 838.836,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666187050359714,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3582.321000000036,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.177999999999999,
"layouts": 60,
"layoutDurationMs": 14.03,
"taskDurationMs": 1644.6400000000003,
"heapDeltaBytes": 1211820,
"heapUsedBytes": 69713784,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 776.867,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66588785046729,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3539.6010000000615,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.830000000000002,
"layouts": 60,
"layoutDurationMs": 13.876000000000001,
"taskDurationMs": 1611.6739999999998,
"heapDeltaBytes": -18547100,
"heapUsedBytes": 68718732,
"domNodes": 24,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 767.9899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3147.8680000000168,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.320000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1892.303,
"heapDeltaBytes": 5789300,
"heapUsedBytes": 74571840,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 999.97,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755614973262038,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3098.2930000000124,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.065,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1831.768,
"heapDeltaBytes": 4887524,
"heapUsedBytes": 73305548,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 977.1339999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.846739130434777,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2020.8900000000085,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.9699999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.6500000000001,
"heapDeltaBytes": -9797716,
"heapUsedBytes": 79559320,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 39.07000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2006.7299999999477,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.759000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.837,
"heapDeltaBytes": -8885856,
"heapUsedBytes": 80057400,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.990999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.9729999999818,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.226000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.33,
"heapDeltaBytes": -11966796,
"heapUsedBytes": 57569204,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 147.55700000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.060999999916,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.851999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.89400000000006,
"heapDeltaBytes": -12772636,
"heapUsedBytes": 55872292,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 141.896,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2012.658999999985,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2960000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.191,
"heapDeltaBytes": 1141376,
"heapUsedBytes": 70703660,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.721000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2001.8649999999525,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.604,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.12,
"heapDeltaBytes": 1329936,
"heapUsedBytes": 72373436,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.232999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.7840000000274,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.485,
"layouts": 16,
"layoutDurationMs": 5.346,
"taskDurationMs": 719.254,
"heapDeltaBytes": 16568568,
"heapUsedBytes": 78824148,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 107.457,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.703000000014,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.18,
"layouts": 16,
"layoutDurationMs": 5.78,
"taskDurationMs": 731.994,
"heapDeltaBytes": -5971468,
"heapUsedBytes": 63828268,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 111.69700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.012999999958,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.471999999999998,
"layouts": 5,
"layoutDurationMs": 14.690000000000001,
"taskDurationMs": 891.9000000000001,
"heapDeltaBytes": -829348,
"heapUsedBytes": 93016128,
"domNodes": 14227,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.425999999999995,
"eventListeners": 2463,
"totalBlockingTimeMs": 136,
"frameDurationMs": 19.44305555555555,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8440.89200000002,
"styleRecalcs": 251,
"styleRecalcDurationMs": 34.719,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5722.364,
"heapDeltaBytes": -11933308,
"heapUsedBytes": 77391072,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2941.96,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698811881188117,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8487.36800000006,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.932,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5484.493,
"heapDeltaBytes": -19234680,
"heapUsedBytes": 69524436,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2743.873,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666011787819254,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18662.213000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17854.349,
"heapDeltaBytes": -44927576,
"heapUsedBytes": 178916032,
"domNodes": -3045,
"jsHeapTotalBytes": 1155072,
"scriptDurationMs": 283.20199999999994,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.15379310344828,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 17575.567999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16764.318,
"heapDeltaBytes": -33696112,
"heapUsedBytes": 179352596,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 308.05100000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.772711864406777,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 22216.042000000016,
"styleRecalcs": 178,
"styleRecalcDurationMs": 20.669999999999966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21806.851000000002,
"heapDeltaBytes": -29394364,
"heapUsedBytes": 183959676,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 881.222,
"eventListeners": -14915,
"totalBlockingTimeMs": 13,
"frameDurationMs": 41.680487804878055,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 21070.58799999993,
"styleRecalcs": 169,
"styleRecalcDurationMs": 17.297000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20639.289999999997,
"heapDeltaBytes": -37207088,
"heapUsedBytes": 175794424,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 912.4830000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 68,
"frameDurationMs": 37.888129496402875,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6599.075999999968,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.706,
"layouts": 20,
"layoutDurationMs": 23.26600000000001,
"taskDurationMs": 6412.002,
"heapDeltaBytes": 940128,
"heapUsedBytes": 224623600,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 111.87700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.29251336898396,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6328.32099999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.378,
"layouts": 20,
"layoutDurationMs": 23.181999999999995,
"taskDurationMs": 6233.452999999999,
"heapDeltaBytes": -12849940,
"heapUsedBytes": 213138100,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 103.427,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.1512048192771,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9260.028000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8759.949,
"heapDeltaBytes": -16376200,
"heapUsedBytes": 197441344,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 143.35799999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.143771043771046,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9122.707999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8708.542000000001,
"heapDeltaBytes": -34492984,
"heapUsedBytes": 179255064,
"domNodes": -3045,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 186.88499999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 2,
"frameDurationMs": 30.286710963455146,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 152.01600000000326,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.398000000000003,
"layouts": 4,
"layoutDurationMs": 1.9770000000000005,
"taskDurationMs": 106.36499999999998,
"heapDeltaBytes": 3967584,
"heapUsedBytes": 70450652,
"domNodes": 98,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.142000000000007,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 453.91799999993054,
"styleRecalcs": 14,
"styleRecalcDurationMs": 12.618000000000002,
"layouts": 3,
"layoutDurationMs": 0.83,
"taskDurationMs": 100.087,
"heapDeltaBytes": 5530428,
"heapUsedBytes": 71841768,
"domNodes": 99,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.535999999999996,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 773.1390000000147,
"styleRecalcs": 78,
"styleRecalcDurationMs": 95.471,
"layouts": 76,
"layoutDurationMs": 23.648,
"taskDurationMs": 732.583,
"heapDeltaBytes": 16856468,
"heapUsedBytes": 87766052,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 293.257,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667391304347824,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 917.3809999999776,
"styleRecalcs": 78,
"styleRecalcDurationMs": 102.882,
"layouts": 76,
"layoutDurationMs": 24.727,
"taskDurationMs": 885.441,
"heapDeltaBytes": 18493264,
"heapUsedBytes": 83385800,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 374.527,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667272727272724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1358.3810000000085,
"styleRecalcs": 78,
"styleRecalcDurationMs": 253.392,
"layouts": 76,
"layoutDurationMs": 28.076,
"taskDurationMs": 1345.2930000000001,
"heapDeltaBytes": 8678636,
"heapUsedBytes": 115574636,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 457.53099999999995,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.298734177215195,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1354.7119999999495,
"styleRecalcs": 78,
"styleRecalcDurationMs": 248.276,
"layouts": 76,
"layoutDurationMs": 27.644,
"taskDurationMs": 1332.797,
"heapDeltaBytes": 8744672,
"heapUsedBytes": 115368704,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 450.57599999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.082500000000003,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2206 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (34 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d628f0ae1df5ca0dcbb856888cdd7d732414e7b4
Full docs: ADR-DEVEX-LINT-0015 |
christian-byrne
left a comment
There was a problem hiding this comment.
Backport fidelity check against the merged original (#21180), per branch: diffed sorted +/- lines against the original, then diffed the resulting files for every mismatch rather than calling a line mismatch a failure on its own.
Every remaining difference traces to this branch's pre-existing state (before that PR), not to a content loss:
TopUpCreditsDialogContentWorkspace.vueuses<h2>for step titles here (vs<DialogTitle>on main) — confirmed the pre-backport file on this branch already used<h2>throughout, so this predates the design-systemDialogTitleadoption on main.- Toast assertions reference the branch's existing
useToast: () => ({ add: mockToastAdd })mock shape rather than main's newer.errorhelper — confirmed via the pre-backport test file. openHostedBillingTab.ts'sreserveBillingTab()null handling reads differently (early-returnif (!tab) return 'blocked'vs main'stab?.navigate(...)ternary) but is equivalently null-safe.
No package.json touched, so no packaging/exports risk. No open review threads. CI fully green at this head. Approving.
Manual backport of #21180 (FE-1908 / DES-1033). The bot's cherry-pick hit conflicts.
Why
On the consolidated billing rail, top-up dead-ends with
NO_PAYMENT_METHODwhen the workspace has no Stripe invoice default. This backport brings the hosted-checkout recovery, the billing-webreturn_urlfor non-cloud-web origins, and the Desktop billing-tab handoff (#21198, folded into #21180) to this release line.Root cause
Off-session top-up charges only the Stripe customer's invoice default, and the dialog had no recovery when that was missing. Details and fix design are in #21180.
How
Cherry-pick of the #21180 squash commit, with the conflicts resolved as below.
Conflict resolution
This branch predates several
mainchanges, so the cherry-pick keeps this branch's code and adds only #21180's behavior:TopUpCreditsDialogContentWorkspace.vue: keeps the PrimeVue toast,manageSubscription, the saved-card note with its Manage billing link,<h2>titles andretryPaymentAuthentication. Adds theNO_PAYMENT_METHODrefusal state, Continue to checkout, the "Checkout didn't open" screen and the inline open failure.useSubscriptionCheckout.ts: keeps the PrimeVuetoast.addrecovery toast and only swaps itswindow.openforopenBillingUrl(Desktop handoff from FE-1908 fix(billing): don't report Desktop's handed-off billing pages as blocked popups #21198).topupOperationView.ts: widenstopupFailureErrorto acceptHostedTopupCheckoutFailure, without main'sOPERATION_ALREADY_PENDINGbranch.workspaceApi.ts:handleAxiosErrortakes one argument on this branch.noPaymentMethodError(no longer used) and keeps this branch's other top-up keys.Verification
viteston the top-up dialog,platform/workspace/billing,useTopupOperation,useWorkspaceBillingandcomposables/billing: all pass. The pre-commit hook ran lint and typecheck.AS IS / TO BE
See #21180 for the AS IS / TO BE recordings; this backport has no behavior of its own.