Repository navigation
refactor: rename isDesktop to isLegacyDesktopBuild and add isComfyDesktop2 - #21213
benceruleanlu wants to merge 2 commits into
Conversation
…ktop2 isDesktop is true only for the DISTRIBUTION=desktop build, which ships only in the legacy Electron app (Desktop 1). Comfy-Desktop (Desktop 2) runs the standard localhost build, so isDesktop is false there, but the name reads as "running in the desktop app" and has been used to gate Desktop 2 behaviour by mistake. - Rename the constant to isLegacyDesktopBuild across src, tests and docs. - Add isComfyDesktop2(), a runtime check for window.__comfyDesktop2, and use it for the PostHog client axis. - AGENTS.md: note that "Desktop" means two apps and how to detect each. - ADR CRDT-FOLLOWER-0025: stop equating Comfy-Desktop with isDesktop.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Bundle: 9.49 MB gzip 🔴 +1 BDetailsSummary
Category Glance App Entry Points — 6.65 kB (baseline 6.65 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.47 MB (baseline 3.47 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 3 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 674 kB (baseline 674 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 30 unchanged User & Accounts — 150 kB (baseline 150 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 17 unchanged Editors & Dialogs — 359 kB (baseline 359 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 12 unchanged UI Components — 212 kB (baseline 212 kB) • ⚪ 0 BReusable component library chunks Status: 24 unchanged Data & Services — 1.11 MB (baseline 1.11 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 37 unchanged Utilities & Hooks — 987 kB (baseline 987 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 72 unchanged Vendor & Third-Party — 13.9 MB (baseline 13.9 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 19.7 MB (baseline 19.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 366 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-17T02:41:04.794Z",
"gitSha": "988c5f09c501926e85a86cdb2ef55db83733c620",
"branch": "bl/friendly-fermi-2w4l9n",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.6950000000083,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.703,
"layouts": 10,
"layoutDurationMs": 2.9709999999999996,
"taskDurationMs": 573.5450000000001,
"heapDeltaBytes": -21846060,
"heapUsedBytes": 56905300,
"domNodes": -162,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.309999999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2011.9770000000017,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2899999999999996,
"layouts": 8,
"layoutDurationMs": 2.5149999999999997,
"taskDurationMs": 541.9670000000001,
"heapDeltaBytes": 10051176,
"heapUsedBytes": 73465116,
"domNodes": -163,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 9.136999999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1740.3540000000248,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.099,
"layouts": 10,
"layoutDurationMs": 3.197,
"taskDurationMs": 898.829,
"heapDeltaBytes": -6278508,
"heapUsedBytes": 72386128,
"domNodes": -162,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 159.90200000000002,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1727.816999999959,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.517,
"layouts": 9,
"layoutDurationMs": 2.5149999999999997,
"taskDurationMs": 745.966,
"heapDeltaBytes": 15306844,
"heapUsedBytes": 79807296,
"domNodes": -162,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 157.646,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.8729999999787,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.564000000000001,
"layouts": 11,
"layoutDurationMs": 2.552,
"taskDurationMs": 280.591,
"heapDeltaBytes": 24089292,
"heapUsedBytes": 88411500,
"domNodes": 47,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.146000000000003,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1790.2950000000146,
"styleRecalcs": 20,
"styleRecalcDurationMs": 4.909,
"layouts": 12,
"layoutDurationMs": 2.8009999999999997,
"taskDurationMs": 434.05999999999995,
"heapDeltaBytes": 274008,
"heapUsedBytes": 79182032,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 10.706,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 659.5120000000065,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.581,
"layouts": 9,
"layoutDurationMs": 2.4749999999999996,
"taskDurationMs": 487.66700000000003,
"heapDeltaBytes": 7168340,
"heapUsedBytes": 85798924,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 165.61200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 664.6709999999985,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.6479999999999992,
"layouts": 9,
"layoutDurationMs": 2.5709999999999993,
"taskDurationMs": 497.1449999999999,
"heapDeltaBytes": 3289144,
"heapUsedBytes": 67781012,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 174.627,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66923076923077,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1163.8779999999542,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 831.846,
"heapDeltaBytes": 19480276,
"heapUsedBytes": 99204484,
"domNodes": 0,
"jsHeapTotalBytes": 18251776,
"scriptDurationMs": 67.383,
"eventListeners": 0,
"totalBlockingTimeMs": 527,
"frameDurationMs": 34.31470588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1147.9970000000321,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 835.754,
"heapDeltaBytes": 16472504,
"heapUsedBytes": 97001188,
"domNodes": 0,
"jsHeapTotalBytes": 15892480,
"scriptDurationMs": 69.319,
"eventListeners": 0,
"totalBlockingTimeMs": 522,
"frameDurationMs": 33.82058823529411,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.6110000000335,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.61199999999957,
"heapDeltaBytes": -4010592,
"heapUsedBytes": 74084812,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 154.057,
"eventListeners": 0,
"totalBlockingTimeMs": 211,
"frameDurationMs": 24.99705882352943,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 848.3830000000125,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.0109999999997,
"heapDeltaBytes": -4706184,
"heapUsedBytes": 73142980,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 151.881,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10936.90700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10023.565,
"heapDeltaBytes": -13433928,
"heapUsedBytes": 70608428,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8131.299,
"eventListeners": 0,
"totalBlockingTimeMs": 1236,
"frameDurationMs": 31.326647564469916,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10318.421999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9507.221,
"heapDeltaBytes": -12932392,
"heapUsedBytes": 70545764,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7727.883000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 887,
"frameDurationMs": 31.356534954407298,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8682.89900000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7965.831,
"heapDeltaBytes": 12197368,
"heapUsedBytes": 95682220,
"domNodes": 0,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 6630.885,
"eventListeners": 0,
"totalBlockingTimeMs": 579,
"frameDurationMs": 32.278810408921935,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9293.06100000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8451.699,
"heapDeltaBytes": 12046808,
"heapUsedBytes": 95492132,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7061.0779999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 811,
"frameDurationMs": 31.524067796610172,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 192.39300000003823,
"styleRecalcs": 20,
"styleRecalcDurationMs": 12.644999999999998,
"layouts": 8,
"layoutDurationMs": 2.322,
"taskDurationMs": 145.46399999999997,
"heapDeltaBytes": 13303992,
"heapUsedBytes": 77220816,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.427999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 5,
"frameDurationMs": 26.18571428571431,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-combo-open",
"durationMs": 217.47599999991962,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.844000000000003,
"layouts": 7,
"layoutDurationMs": 1.9900000000000004,
"taskDurationMs": 159.86800000000002,
"heapDeltaBytes": 13334576,
"heapUsedBytes": 76640640,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.212000000000002,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.670000000000073,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2039.8820000000342,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7719999999999994,
"layouts": 7,
"layoutDurationMs": 1.637,
"taskDurationMs": 609.548,
"heapDeltaBytes": -29149772,
"heapUsedBytes": 74958164,
"domNodes": -279,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 32.867,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2022.5789999999506,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9699999999999995,
"layouts": 7,
"layoutDurationMs": 1.8579999999999999,
"taskDurationMs": 426.21199999999993,
"heapDeltaBytes": -10625740,
"heapUsedBytes": 74941416,
"domNodes": -258,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.452,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2473.3659999999986,
"styleRecalcs": 65,
"styleRecalcDurationMs": 4.912000000000001,
"layouts": 4,
"layoutDurationMs": 1.025,
"taskDurationMs": 1596.9539999999997,
"heapDeltaBytes": 16136316,
"heapUsedBytes": 81480160,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 796.999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666216216216213,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2638.4380000000647,
"styleRecalcs": 65,
"styleRecalcDurationMs": 4.676,
"layouts": 3,
"layoutDurationMs": 0.7639999999999999,
"taskDurationMs": 1623.5530000000003,
"heapDeltaBytes": 15614884,
"heapUsedBytes": 81118808,
"domNodes": 0,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 790.4649999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.771974522292993,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3697.655999999995,
"styleRecalcs": 66,
"styleRecalcDurationMs": 5.572000000000001,
"layouts": 60,
"layoutDurationMs": 9.074,
"taskDurationMs": 1698.1009999999999,
"heapDeltaBytes": 3767808,
"heapUsedBytes": 71004656,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 763.664,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765766,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3770.236000000068,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.4990000000000006,
"layouts": 63,
"layoutDurationMs": 9.922,
"taskDurationMs": 1694.7360000000003,
"heapDeltaBytes": 35200,
"heapUsedBytes": 66999696,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 759.831,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66637168141593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3099.3670000000293,
"styleRecalcs": 41,
"styleRecalcDurationMs": 3.4649999999999994,
"layouts": 1,
"layoutDurationMs": 0.22999999999999973,
"taskDurationMs": 1902.467,
"heapDeltaBytes": 19918592,
"heapUsedBytes": 88841520,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 935.3889999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.93934426229508,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2986.494999999991,
"styleRecalcs": 41,
"styleRecalcDurationMs": 3.439,
"layouts": 1,
"layoutDurationMs": 0.28200000000000014,
"taskDurationMs": 1906.4319999999998,
"heapDeltaBytes": 15421900,
"heapUsedBytes": 85207152,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 932.5150000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.855113636363637,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2015.29000000005,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9010000000000008,
"layouts": 3,
"layoutDurationMs": 0.811,
"taskDurationMs": 585.2,
"heapDeltaBytes": 10010032,
"heapUsedBytes": 75444136,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.650000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2016.0529999999426,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0229999999999997,
"layouts": 4,
"layoutDurationMs": 1.006,
"taskDurationMs": 559.05,
"heapDeltaBytes": 10217604,
"heapUsedBytes": 75322612,
"domNodes": -258,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.455000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 622.3390000000109,
"styleRecalcs": 44,
"styleRecalcDurationMs": 3.973,
"layouts": 7,
"layoutDurationMs": 2.2200000000000006,
"taskDurationMs": 429.68600000000004,
"heapDeltaBytes": 2068164,
"heapUsedBytes": 82774560,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 138.789,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.6600000000053,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.169,
"layouts": 9,
"layoutDurationMs": 2.1569999999999996,
"taskDurationMs": 436.709,
"heapDeltaBytes": 2122904,
"heapUsedBytes": 82915912,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 143.809,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.3330000000033,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.66,
"layouts": 10,
"layoutDurationMs": 2.79,
"taskDurationMs": 559.159,
"heapDeltaBytes": -18432216,
"heapUsedBytes": 62214480,
"domNodes": -180,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.094999999999999,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.385000000062,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4699999999999998,
"layouts": 10,
"layoutDurationMs": 2.411,
"taskDurationMs": 548.429,
"heapDeltaBytes": -2517952,
"heapUsedBytes": 63007712,
"domNodes": -180,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.136000000000001,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.450000000014,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.669000000000002,
"layouts": 9,
"layoutDurationMs": 2.6860000000000004,
"taskDurationMs": 868.889,
"heapDeltaBytes": -511940,
"heapUsedBytes": 80285404,
"domNodes": -180,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 110.67399999999999,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1989.8749999999836,
"styleRecalcs": 87,
"styleRecalcDurationMs": 14.213,
"layouts": 10,
"layoutDurationMs": 2.5499999999999994,
"taskDurationMs": 1082.6470000000002,
"heapDeltaBytes": -1357572,
"heapUsedBytes": 79426000,
"domNodes": -180,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 109.117,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665546218487393,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1452.290000000005,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.709000000000003,
"layouts": 5,
"layoutDurationMs": 16.392,
"taskDurationMs": 1049.745,
"heapDeltaBytes": 11811192,
"heapUsedBytes": 111036448,
"domNodes": 15950,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 28.154,
"eventListeners": 3244,
"totalBlockingTimeMs": 151,
"frameDurationMs": 19.554666666666673,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9485.617999999988,
"styleRecalcs": 249,
"styleRecalcDurationMs": 16.813000000000002,
"layouts": 6,
"layoutDurationMs": 1.4820000000000002,
"taskDurationMs": 5843.313999999999,
"heapDeltaBytes": -25876476,
"heapUsedBytes": 76861208,
"domNodes": -258,
"jsHeapTotalBytes": -557056,
"scriptDurationMs": 2676.025,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665845070422534,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9407.86300000002,
"styleRecalcs": 247,
"styleRecalcDurationMs": 16.387999999999998,
"layouts": 4,
"layoutDurationMs": 1.0630000000000002,
"taskDurationMs": 5791.087,
"heapDeltaBytes": 12807824,
"heapUsedBytes": 77148296,
"domNodes": -258,
"jsHeapTotalBytes": 192512,
"scriptDurationMs": 2670.487,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808513,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 22843.976999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21840.103,
"heapDeltaBytes": -28700120,
"heapUsedBytes": 255069552,
"domNodes": -3330,
"jsHeapTotalBytes": 11522048,
"scriptDurationMs": 311.85699999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.19210977701544,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 16226.386999999932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15217.208999999999,
"heapDeltaBytes": -36122312,
"heapUsedBytes": 262367120,
"domNodes": -3330,
"jsHeapTotalBytes": 22269952,
"scriptDurationMs": 303.86600000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.958620689655174,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 27377.15300000002,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.068,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 26885.241,
"heapDeltaBytes": -31246712,
"heapUsedBytes": 252209812,
"domNodes": -3330,
"jsHeapTotalBytes": 10211328,
"scriptDurationMs": 860.7090000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 121,
"frameDurationMs": 50.18113553113553,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 18744.99000000003,
"styleRecalcs": 165,
"styleRecalcDurationMs": 12.379000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18333.765,
"heapDeltaBytes": 22509040,
"heapUsedBytes": 283297624,
"domNodes": -3023,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 824.064,
"eventListeners": -644,
"totalBlockingTimeMs": 28,
"frameDurationMs": 33.15486725663717,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8160.204000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.84899999999999,
"layouts": 20,
"layoutDurationMs": 28.914999999999996,
"taskDurationMs": 8034.469,
"heapDeltaBytes": -36964100,
"heapUsedBytes": 252790312,
"domNodes": -3330,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 144.78199999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 34,
"frameDurationMs": 45.62178770949721,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 8122.645000000034,
"styleRecalcs": 20,
"styleRecalcDurationMs": 94.21799999999998,
"layouts": 20,
"layoutDurationMs": 23.66800000000001,
"taskDurationMs": 7969.432,
"heapDeltaBytes": -18117144,
"heapUsedBytes": 272286320,
"domNodes": -3330,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 152.226,
"eventListeners": -653,
"totalBlockingTimeMs": 3,
"frameDurationMs": 47.56140350877192,
"p95FrameDurationMs": 83.5
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11541.547000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11092.312000000002,
"heapDeltaBytes": 2825604,
"heapUsedBytes": 276956116,
"domNodes": 0,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 161.13499999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.746391752577324,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8107.089999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7635.605999999999,
"heapDeltaBytes": 22919144,
"heapUsedBytes": 286217572,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.05,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.17986577181209,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 484.4269999999824,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.965000000000002,
"layouts": 11,
"layoutDurationMs": 4.36,
"taskDurationMs": 138.262,
"heapDeltaBytes": -8158072,
"heapUsedBytes": 68291612,
"domNodes": 124,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 13.028,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241382,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 464.382999999998,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.309000000000001,
"layouts": 11,
"layoutDurationMs": 4.443,
"taskDurationMs": 119.04900000000002,
"heapDeltaBytes": 6785360,
"heapUsedBytes": 71183568,
"domNodes": 95,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.92,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 514.393000000041,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.782,
"layouts": 76,
"layoutDurationMs": 15.07,
"taskDurationMs": 477.983,
"heapDeltaBytes": -20585872,
"heapUsedBytes": 71827220,
"domNodes": 4,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 240.648,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 413.8799999999492,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.76,
"layouts": 76,
"layoutDurationMs": 14.226,
"taskDurationMs": 362.251,
"heapDeltaBytes": -22083876,
"heapUsedBytes": 70633756,
"domNodes": 4,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 173.323,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999977,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 493.4969999999339,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.6969999999999998,
"layouts": 76,
"layoutDurationMs": 13.588,
"taskDurationMs": 457.13100000000003,
"heapDeltaBytes": -5004624,
"heapUsedBytes": 102535948,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 183.797,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 541.5160000000014,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.658,
"layouts": 76,
"layoutDurationMs": 13.426,
"taskDurationMs": 496.923,
"heapDeltaBytes": -270976,
"heapUsedBytes": 116123396,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 215.23600000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.27741935483872,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2284 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (75 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 91566d70625131c7826971d9edda327adc7e6257
Full docs: ADR-DEVEX-LINT-0015 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5201fe7220
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| * Whether this is the `DISTRIBUTION=desktop` build, which only the legacy | ||
| * Electron app (Desktop 1, `window.electronAPI`) ships. | ||
| * | ||
| * False inside Comfy-Desktop (Desktop 2): it runs the standard localhost | ||
| * build. Use {@link isComfyDesktop2} to detect Desktop 2. |
There was a problem hiding this comment.
Shorten the exported API documentation
Condense this JSDoc—and the new three-line isComfyDesktop2 JSDoc below—to at most two lines describing only the API contract. The added blocks repeat implementation and historical rationale, while the repository explicitly limits exported-API JSDoc to one or two contract-focused lines and classifies longer documentation as a violation.
AGENTS.md reference: AGENTS.md:L268-L273
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #21213 +/- ##
==========================================
+ Coverage 86.57% 87.40% +0.82%
==========================================
Files 3750 2671 -1079
Lines 177236 148162 -29074
Branches 46887 38528 -8359
==========================================
- Hits 153446 129501 -23945
+ Misses 21721 18270 -3451
+ Partials 2069 391 -1678
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1104 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Read the full diff: isDesktop → isLegacyDesktopBuild is a straight identifier rename (same DISTRIBUTION === 'desktop' logic) across ~25 call sites, with a new isComfyDesktop2() helper (Boolean(window.__comfyDesktop2)) layered in alongside it. Checked every call site individually — no flipped boolean sense, no missed rename. Confirmed no stray isDesktop references remain outside this PR's scope (the one hit, BaseModalLayout.vue's local watch() param, is an unrelated viewport-breakpoint variable that happens to share the name).
CI fully green, no unresolved threads (CodeRabbit approved; the one open comment from chatgpt-codex-connector is a doc-verbosity style nit, not correctness).
Approving.
Summary
isDesktopis true only for theDISTRIBUTION=desktopbuild, which ships only indist-desktop.zipfor the legacy Electron app (Desktop 1). Comfy-Desktop (Desktop 2) runs the standard localhost build, soisDesktopis false there. The name reads as "running in the desktop app", though, and it has been used to gate Desktop 2 behaviour by mistake: #21202 treated anullwindow.openas success only whenisDesktopwas set, so on Desktop 2 the deploy dialog acted as if the popup was blocked.isDesktoptoisLegacyDesktopBuild, with a doc comment saying it is false in Desktop 2. Pure rename: no behaviour change.isComfyDesktop2(), a runtime check forwindow.__comfyDesktop2that holds for any build Desktop 2 loads, cloud included. Use it for the PostHogclientfield, the one existing check that only tested whether the bridge exists. Same truthiness as before.isDesktop. Update the identifier indocs/SETTINGS.md,.coderabbit.yamland.agents/checks/follower-boundary.md.AGENTS.mdlabelspnpm dev:electronas Desktop 1 mocks.Whichever of this PR and #21202 merges second needs to switch to the new names.
Change breakdown (421 changed lines)
src/**, non-test)*.test.ts)AGENTS.md,docs/SETTINGS.md, ADR 0025,.coderabbit.yaml,.agents/checks/follower-boundary.md)Nearly all lines are the mechanical rename plus oxfmt re-wrapping lines that got longer.
Verification
pnpm typecheckpasses.vitest runon the 34 touched test files plusPostHogTelemetryProvider.test.ts: 35 files and 1160 tests pass.Generated by Claude Code