Repository navigation
[cloud/1.56] fix(agent): tag send failures with status and operation (PM-2103) (#21169) - #21173
Conversation
…1169) [PM-2103](https://linear.app/comfyorg/issue/PM-2103) is a thin Sentry relay with no stack frame, endpoint, or repro steps — just `AgentApiError: Agent request failed (HTTP 503)`. There wasn't enough in the alert to build a real fix from, so per the usual pattern for this kind of ticket this adds the missing diagnostic context instead of guessing at a root cause. Found the failure site: `recordSendError` → `reportSendFailure` in `useAgentSession.ts` reports every `AgentApiError` send failure that isn't shaped like a known admission or attachment rejection with only `{ surface: 'agent', errorType: 'agent_send_message_failed' }` — no status code, no operation, nothing to tell this occurrence apart from any other send failure. `AgentApiError` already carries `status`/`retryAfterSeconds` but never carried the operation name, and nothing forwarded any of it into the report. - `AgentApiError` now carries its `operation` (the same closed-union operation name already used for the PM-1802 auth-rejection tagging), passed through from `toApiError`. - `reportSendFailure` tags the report with `status`, `operation`, and `retryAfterSeconds` for any `AgentApiError`, mirroring the auth-rejection reporting pattern. Next prod/staging sighting of this error class will carry a status code and operation name, so it can actually be triaged instead of recurring as another unreproducible one-liner. - [x] Added a unit test asserting `toApiError` populates `operation` on the thrown `AgentApiError` - [x] Added a unit test asserting a 503 send failure is reported with `status`/`operation` tags - [x] Updated the three existing `agent_send_message_failed` assertions for the new `tags` field - [x] `pnpm vitest run` on both touched test files (351 passed) and the full `agent` extension suite (3672 passed) - [x] `pnpm typecheck:app` clean - [x] `pnpm exec eslint` / `pnpm exec oxlint` clean on touched files (cherry picked from commit 59965dd)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-17T00:31:28.069Z",
"gitSha": "ddc145d83496f958b7669431f39820610cbfdc51",
"branch": "backport-21169-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2005.7620000000043,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.3699999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.4960000000001,
"heapDeltaBytes": 993900,
"heapUsedBytes": 69304960,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.734999999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2018.6700000000428,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.327,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.3070000000001,
"heapDeltaBytes": -3677088,
"heapUsedBytes": 56787964,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.716000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1752.3969999999736,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.558999999999997,
"layouts": 12,
"layoutDurationMs": 4.475,
"taskDurationMs": 777.6070000000001,
"heapDeltaBytes": -2384312,
"heapUsedBytes": 65516924,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 149.70799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.789999999939,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.209,
"layouts": 12,
"layoutDurationMs": 4.595,
"taskDurationMs": 804.8210000000001,
"heapDeltaBytes": -2318996,
"heapUsedBytes": 65779444,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 155.057,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.4400000000487,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.183,
"layouts": 6,
"layoutDurationMs": 1.3579999999999999,
"taskDurationMs": 343.80800000000005,
"heapDeltaBytes": 185572,
"heapUsedBytes": 61927484,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.696,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.303999999971,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.588,
"layouts": 6,
"layoutDurationMs": 1.597,
"taskDurationMs": 353.10600000000005,
"heapDeltaBytes": 4147724,
"heapUsedBytes": 72016216,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.527999999999992,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 669.0090000000168,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.438,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.41200000000003,
"heapDeltaBytes": 15741032,
"heapUsedBytes": 75528796,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.69,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 704.2149999999765,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.837,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.09999999999997,
"heapDeltaBytes": -6715744,
"heapUsedBytes": 61041620,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.336,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1109.672000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 770.975,
"heapDeltaBytes": 15350012,
"heapUsedBytes": 82824800,
"domNodes": 0,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 61.70300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 490,
"frameDurationMs": 32.841176470588216,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1149.046999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 811.673,
"heapDeltaBytes": 15472772,
"heapUsedBytes": 84426992,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 58.919,
"eventListeners": 0,
"totalBlockingTimeMs": 516,
"frameDurationMs": 33.82058823529411,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.1990000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.95700000000016,
"heapDeltaBytes": 17179540,
"heapUsedBytes": 102767444,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 138.66400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 880.1869999999781,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.2529999999998,
"heapDeltaBytes": 18649476,
"heapUsedBytes": 103046700,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 159.45,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 25.23999999999999,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8989.517999999975,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8010.066999999999,
"heapDeltaBytes": 3290916,
"heapUsedBytes": 80856904,
"domNodes": -143,
"jsHeapTotalBytes": -6950912,
"scriptDurationMs": 6484.21,
"eventListeners": -82,
"totalBlockingTimeMs": 301,
"frameDurationMs": 30.245791245791246,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8040.124999999989,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.4569999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7288.39,
"heapDeltaBytes": -9439040,
"heapUsedBytes": 68588468,
"domNodes": -142,
"jsHeapTotalBytes": -5378048,
"scriptDurationMs": 6091.163,
"eventListeners": -78,
"totalBlockingTimeMs": 189,
"frameDurationMs": 31.625984251968504,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7992.475000000013,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.7310000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7396.086,
"heapDeltaBytes": 17573452,
"heapUsedBytes": 85324132,
"domNodes": -142,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 5956.714,
"eventListeners": -74,
"totalBlockingTimeMs": 110,
"frameDurationMs": 30.238636363636363,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8607.525000000009,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.9690000000000011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7871.469,
"heapDeltaBytes": 16034720,
"heapUsedBytes": 93883744,
"domNodes": -142,
"jsHeapTotalBytes": -4329472,
"scriptDurationMs": 6350.598,
"eventListeners": -74,
"totalBlockingTimeMs": 240,
"frameDurationMs": 30.933812949640284,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2023.5680000000116,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.440999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.754,
"heapDeltaBytes": -10548760,
"heapUsedBytes": 76849420,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.739999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.1059999999843,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.0169999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.839,
"heapDeltaBytes": -9872836,
"heapUsedBytes": 78379108,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 38.12500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2236.6779999999835,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.963000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1544.9100000000003,
"heapDeltaBytes": -18556988,
"heapUsedBytes": 69773540,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 805.465,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666417910447755,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2242.5960000000487,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.860999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1563.145,
"heapDeltaBytes": -59819988,
"heapUsedBytes": 64388940,
"domNodes": -348,
"jsHeapTotalBytes": -4030464,
"scriptDurationMs": 777.16,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791043,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3606.693000000007,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.156999999999998,
"layouts": 60,
"layoutDurationMs": 15.905000000000003,
"taskDurationMs": 1645.606,
"heapDeltaBytes": -20472512,
"heapUsedBytes": 69329108,
"domNodes": 24,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 787.4140000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3690.9840000000713,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.501,
"layouts": 60,
"layoutDurationMs": 16.033,
"taskDurationMs": 1688.4260000000002,
"heapDeltaBytes": 4518392,
"heapUsedBytes": 84963948,
"domNodes": 24,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 803.4399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765766,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3052.8909999999883,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.981,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1721.293,
"heapDeltaBytes": 3394408,
"heapUsedBytes": 72217524,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 992.0559999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75769230769231,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3133.195999999998,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.222,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1895.2330000000002,
"heapDeltaBytes": 3327012,
"heapUsedBytes": 72328412,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 1010.2229999999998,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.845161290322576,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.53399999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.4499999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.884,
"heapDeltaBytes": -11392784,
"heapUsedBytes": 68095356,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.895,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.0390000000489,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.811,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.5160000000001,
"heapDeltaBytes": -9829668,
"heapUsedBytes": 80143004,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 39.407,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 626.5030000000138,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.940999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.994,
"heapDeltaBytes": -12241360,
"heapUsedBytes": 57809660,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 150.032,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 621.1170000000266,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.048000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.52199999999993,
"heapDeltaBytes": -11338788,
"heapUsedBytes": 57950404,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 145.84,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2040.0549999999953,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.209000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.16099999999994,
"heapDeltaBytes": -27347676,
"heapUsedBytes": 76529400,
"domNodes": -270,
"jsHeapTotalBytes": -1572864,
"scriptDurationMs": 7.556,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.5170000000735,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.4129999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.238,
"heapDeltaBytes": 1194144,
"heapUsedBytes": 70719468,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.093999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1697.1410000000446,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.549,
"layouts": 16,
"layoutDurationMs": 5.561,
"taskDurationMs": 702.8779999999999,
"heapDeltaBytes": 17362068,
"heapUsedBytes": 80835100,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 99.64099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.2830000000804,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.308,
"layouts": 16,
"layoutDurationMs": 6.115,
"taskDurationMs": 765.965,
"heapDeltaBytes": -5795364,
"heapUsedBytes": 63651780,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.028,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 950.9399999999459,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.464000000000006,
"layouts": 5,
"layoutDurationMs": 13.574,
"taskDurationMs": 742.609,
"heapDeltaBytes": 1207024,
"heapUsedBytes": 92829940,
"domNodes": 14227,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 26.025000000000006,
"eventListeners": 2463,
"totalBlockingTimeMs": 128,
"frameDurationMs": 21.11111111111111,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8256.084999999985,
"styleRecalcs": 251,
"styleRecalcDurationMs": 41.631,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5443.254,
"heapDeltaBytes": 8382444,
"heapUsedBytes": 86874036,
"domNodes": 0,
"jsHeapTotalBytes": 1015808,
"scriptDurationMs": 2686.7680000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665858585858587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8704.447000000073,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.15200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5725.066999999999,
"heapDeltaBytes": -12027236,
"heapUsedBytes": 72830484,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 2920.4370000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6978886756238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 19043.75600000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18521.539,
"heapDeltaBytes": -33786764,
"heapUsedBytes": 179318860,
"domNodes": -3046,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 316.46399999999994,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.62650176678446,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 19013.84799999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18530.088,
"heapDeltaBytes": -47599632,
"heapUsedBytes": 180428748,
"domNodes": -3045,
"jsHeapTotalBytes": 6721536,
"scriptDurationMs": 314.59499999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.50828924162258,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 23778.407000000014,
"styleRecalcs": 180,
"styleRecalcDurationMs": 24.548000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23501.27,
"heapDeltaBytes": -45218392,
"heapUsedBytes": 176212032,
"domNodes": -3045,
"jsHeapTotalBytes": 1155072,
"scriptDurationMs": 897.982,
"eventListeners": -14915,
"totalBlockingTimeMs": 75,
"frameDurationMs": 44.87245283018868,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 24080.560999999987,
"styleRecalcs": 180,
"styleRecalcDurationMs": 25.061999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23772.983,
"heapDeltaBytes": -19738028,
"heapUsedBytes": 193043140,
"domNodes": -3048,
"jsHeapTotalBytes": 7290880,
"scriptDurationMs": 914.8,
"eventListeners": -14915,
"totalBlockingTimeMs": 35,
"frameDurationMs": 45.75209125475285,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6808.456999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.39999999999996,
"layouts": 20,
"layoutDurationMs": 27.973000000000013,
"taskDurationMs": 6728.812000000001,
"heapDeltaBytes": -13058396,
"heapUsedBytes": 213423384,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 126.957,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.0787356321839,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 6964.375000000018,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.374,
"layouts": 20,
"layoutDurationMs": 28.74600000000001,
"taskDurationMs": 6830.116,
"heapDeltaBytes": -17542528,
"heapUsedBytes": 222270692,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 124.22400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.71437125748503,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9459.441999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9175.324000000002,
"heapDeltaBytes": -33615284,
"heapUsedBytes": 183962200,
"domNodes": -3045,
"jsHeapTotalBytes": 6750208,
"scriptDurationMs": 164.83699999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.869534050179205,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9654.015000000072,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9445.682,
"heapDeltaBytes": -32520188,
"heapUsedBytes": 181296348,
"domNodes": -3045,
"jsHeapTotalBytes": 8671232,
"scriptDurationMs": 168.507,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.28078291814947,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 510.50499999996646,
"styleRecalcs": 21,
"styleRecalcDurationMs": 19.063999999999997,
"layouts": 4,
"layoutDurationMs": 2.8539999999999996,
"taskDurationMs": 145.272,
"heapDeltaBytes": 5921492,
"heapUsedBytes": 66115144,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.264000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 128.70599999996557,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.931000000000001,
"layouts": 4,
"layoutDurationMs": 1.809,
"taskDurationMs": 96.44699999999997,
"heapDeltaBytes": 3772980,
"heapUsedBytes": 69388544,
"domNodes": 94,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.194999999999995,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 952.2779999999784,
"styleRecalcs": 78,
"styleRecalcDurationMs": 113.27900000000001,
"layouts": 76,
"layoutDurationMs": 29.566,
"taskDurationMs": 926.611,
"heapDeltaBytes": 18421524,
"heapUsedBytes": 87688700,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 372.01099999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66724137931034,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1137.56699999999,
"styleRecalcs": 78,
"styleRecalcDurationMs": 126.31700000000001,
"layouts": 76,
"layoutDurationMs": 32.275999999999996,
"taskDurationMs": 1101.2040000000002,
"heapDeltaBytes": 19960388,
"heapUsedBytes": 90528916,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 445.326,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.43384615384615,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1537.824999999998,
"styleRecalcs": 78,
"styleRecalcDurationMs": 309.604,
"layouts": 76,
"layoutDurationMs": 33.342999999999996,
"taskDurationMs": 1525.3129999999999,
"heapDeltaBytes": 8870720,
"heapUsedBytes": 116322180,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 486.99899999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.135802469135804,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1585.5360000000474,
"styleRecalcs": 78,
"styleRecalcDurationMs": 308.406,
"layouts": 76,
"layoutDurationMs": 33.647000000000006,
"taskDurationMs": 1555.0220000000002,
"heapDeltaBytes": 8708884,
"heapUsedBytes": 116126516,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 514.722,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.545679012345666,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2205 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 07ca10eaefc58f1e3ebbc062dd7b882fd4307cd5
Full docs: ADR-DEVEX-LINT-0015 |
This comment has been minimized.
This comment has been minimized.
… complexity gate The backport's conflict resolution inlined #21169's `tags` ternary directly into `recordSendError`, because the `reportSendFailure`/`isAttachmentTypeRejection` refactor that owns it on `main` does not exist on this branch. That added one decision point and pushed `recordSendError` to cyclomatic 10 / CRAP 31.6, which fallow reports as a new finding in a changed file. Fallow is not advisory on a pull_request: `preflight` gates on `LINT == success && FALLOW == success`, and `test` and `e2e-status` both gate on `preflight`. So the single fallow finding was failing all three required checks, with `unit` and every e2e shard skipped rather than run. Extract the tag builder to a module-scope helper, mirroring main's structure without importing the unrelated refactor. The reported payload is unchanged: same three fields for an `AgentApiError`, `undefined` otherwise. - fallow audit (exact CI args): fail -> pass, complexity_introduced 1 -> 0 - pnpm vitest run on both touched test files: 296 passed - full agent extension suite: 145 files, 2873 passed - typecheck:app, eslint, oxlint, oxfmt --check: clean
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #21173 +/- ##
=============================================
Coverage ? 85.93%
=============================================
Files ? 2502
Lines ? 142705
Branches ? 38889
=============================================
Hits ? 122634
Misses ? 19685
Partials ? 386
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Manual backport of #21169 to
cloud/1.56— same conflict and resolution as #21172 (core/1.56): the automated backport workflow hit cherry-pick conflicts becausereportSendFailure/isAttachmentTypeRejection(a later, unrelated refactor) don't exist on this branch yet. Applied the equivalent minimal fix directly torecordSendError's existingreportErrorcall instead of introducing that refactor here.core/1.56andcloud/1.56have identical content for every touched file, so this is the same resolution.Note: the attachment-rejection-specific tests from #21169 aren't included — that feature doesn't exist on this branch, so those tests don't apply here.
Also: this branch's local pre-push hook (
knip) fails on an unrelated pre-existing issue (vite.electron.config.mts→ unresolvedvitest.console.setup.tsimport) that reproduces on a cleancloud/1.56checkout with no changes — pushed past it with--no-verifyrather than fix unrelated breakage on a stable release branch.Test plan
pnpm vitest runon both touched test files: 296 passedpnpm typecheck:appcleanpnpm exec eslintclean on touched files