Repository navigation
[backport cloud/1.54] fix: repair viewport and graph-load lifecycle defects from #11420 - #21167
christian-byrne wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation failed to run ( Evaluation budget remaining for this pull request: 99 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-16T10:32:42.782Z",
"gitSha": "fa2c0e00f50da875e70d9dce3fcb30c79313ea0e",
"branch": "backport-19976-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2043.102000000033,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.5569999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 533.9959999999999,
"heapDeltaBytes": -6519616,
"heapUsedBytes": 66751904,
"domNodes": -282,
"jsHeapTotalBytes": 3702784,
"scriptDurationMs": 9.948000000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2024.79900000003,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.8100000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.81600000000003,
"heapDeltaBytes": -12597440,
"heapUsedBytes": 61179304,
"domNodes": -280,
"jsHeapTotalBytes": 3964928,
"scriptDurationMs": 8.067000000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.369999999994,
"styleRecalcs": 73,
"styleRecalcDurationMs": 19.544,
"layouts": 14,
"layoutDurationMs": 2.91,
"taskDurationMs": 705.3259999999999,
"heapDeltaBytes": 6454596,
"heapUsedBytes": 80687264,
"domNodes": -282,
"jsHeapTotalBytes": 5275648,
"scriptDurationMs": 119.415,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1731.6859999999679,
"styleRecalcs": 74,
"styleRecalcDurationMs": 20.271,
"layouts": 14,
"layoutDurationMs": 3.3529999999999998,
"taskDurationMs": 724.893,
"heapDeltaBytes": -7459560,
"heapUsedBytes": 64117376,
"domNodes": -282,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 116.19299999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1663.4629999999788,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.518,
"layouts": 6,
"layoutDurationMs": 0.9420000000000001,
"taskDurationMs": 292.859,
"heapDeltaBytes": 4222608,
"heapUsedBytes": 75258972,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.189,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.1029999999946,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.684000000000001,
"layouts": 6,
"layoutDurationMs": 1.0669999999999997,
"taskDurationMs": 303.17299999999994,
"heapDeltaBytes": 4904232,
"heapUsedBytes": 78738088,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.901000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 581.4850000000433,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.554,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.598,
"heapDeltaBytes": -8232704,
"heapUsedBytes": 63375092,
"domNodes": 18,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 131.43500000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 542.6829999998972,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.163,
"heapDeltaBytes": -7940232,
"heapUsedBytes": 63025320,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 121.178,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2036.9200000000092,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.178,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.3009999999999,
"heapDeltaBytes": -7591032,
"heapUsedBytes": 69171576,
"domNodes": -281,
"jsHeapTotalBytes": -892928,
"scriptDurationMs": 34.589999999999996,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2032.8700000000026,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.632999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.6699999999999,
"heapDeltaBytes": -3767552,
"heapUsedBytes": 76640328,
"domNodes": -266,
"jsHeapTotalBytes": -2326528,
"scriptDurationMs": 28.643,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2158.131000000026,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.113,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1338.1980000000003,
"heapDeltaBytes": -10464820,
"heapUsedBytes": 67946976,
"domNodes": -277,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 656.555,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2193.1849999999713,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.789,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1290.568,
"heapDeltaBytes": -594264,
"heapUsedBytes": 78003572,
"domNodes": -283,
"jsHeapTotalBytes": -405504,
"scriptDurationMs": 624.478,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3180.864999999983,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.319000000000003,
"layouts": 60,
"layoutDurationMs": 11.445,
"taskDurationMs": 1343.473,
"heapDeltaBytes": -761292,
"heapUsedBytes": 67199024,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 595.82,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3178.7029999999277,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.289000000000001,
"layouts": 60,
"layoutDurationMs": 11.126,
"taskDurationMs": 1298.3400000000001,
"heapDeltaBytes": -10716,
"heapUsedBytes": 67541644,
"domNodes": 26,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 578.9519999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2313.357999999994,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.885000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1497.3189999999997,
"heapDeltaBytes": 9450088,
"heapUsedBytes": 92420652,
"domNodes": 12,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 746.364,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2525.6239999999934,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.575,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1540.04,
"heapDeltaBytes": -11893780,
"heapUsedBytes": 73900336,
"domNodes": -276,
"jsHeapTotalBytes": -1540096,
"scriptDurationMs": 760.0210000000001,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.8520000000094,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.6880000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.723,
"heapDeltaBytes": 12413052,
"heapUsedBytes": 92540036,
"domNodes": -285,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 26.403000000000002,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.5720000000156,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.726,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.7169999999999,
"heapDeltaBytes": -5281576,
"heapUsedBytes": 76690760,
"domNodes": -267,
"jsHeapTotalBytes": -2326528,
"scriptDurationMs": 33.977,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 524.5939999999791,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 310.681,
"heapDeltaBytes": 15147520,
"heapUsedBytes": 88412876,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 100.075,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 526.5660000000025,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.319999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.04900000000004,
"heapDeltaBytes": 14989028,
"heapUsedBytes": 88441600,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 103.256,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1993.6950000000024,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.315999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.82400000000007,
"heapDeltaBytes": -10155268,
"heapUsedBytes": 65360508,
"domNodes": -296,
"jsHeapTotalBytes": 4227072,
"scriptDurationMs": 8.027,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2001.6769999999724,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.016000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.49699999999996,
"heapDeltaBytes": -9670572,
"heapUsedBytes": 63711388,
"domNodes": -293,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.434999999999999,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.432999999971,
"styleRecalcs": 78,
"styleRecalcDurationMs": 20.843,
"layouts": 18,
"layoutDurationMs": 3.7290000000000005,
"taskDurationMs": 696.238,
"heapDeltaBytes": -9670340,
"heapUsedBytes": 63645684,
"domNodes": -294,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 82.05699999999999,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.5500000000775,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.165000000000003,
"layouts": 18,
"layoutDurationMs": 3.3499999999999996,
"taskDurationMs": 652.363,
"heapDeltaBytes": 6810452,
"heapUsedBytes": 82832056,
"domNodes": -296,
"jsHeapTotalBytes": 4227072,
"scriptDurationMs": 74.834,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 933.351000000016,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.62899999999999,
"layouts": 15,
"layoutDurationMs": 10.853000000000002,
"taskDurationMs": 793.2189999999999,
"heapDeltaBytes": -5084308,
"heapUsedBytes": 88963788,
"domNodes": 13831,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 23.919999999999998,
"eventListeners": 2385,
"totalBlockingTimeMs": 126,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8168.565999999999,
"styleRecalcs": 249,
"styleRecalcDurationMs": 28.209,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4373.173,
"heapDeltaBytes": -11870292,
"heapUsedBytes": 67548328,
"domNodes": -266,
"jsHeapTotalBytes": -1015808,
"scriptDurationMs": 1987.9050000000002,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8195.410000000038,
"styleRecalcs": 248,
"styleRecalcDurationMs": 27.947,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4425.018,
"heapDeltaBytes": -11787000,
"heapUsedBytes": 68461248,
"domNodes": -268,
"jsHeapTotalBytes": -1540096,
"scriptDurationMs": 2036.3770000000004,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12683.187999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11973.583,
"heapDeltaBytes": -40590776,
"heapUsedBytes": 184301904,
"domNodes": -8068,
"jsHeapTotalBytes": -7348224,
"scriptDurationMs": 183.745,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13049.79199999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12408.687,
"heapDeltaBytes": -38070236,
"heapUsedBytes": 184197796,
"domNodes": -8068,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 202.38699999999997,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 16505.09699999998,
"styleRecalcs": 103,
"styleRecalcDurationMs": 14.897000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15931.005,
"heapDeltaBytes": -58246952,
"heapUsedBytes": 170146052,
"domNodes": -8068,
"jsHeapTotalBytes": -21671936,
"scriptDurationMs": 803.2560000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 1,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 16165.905000000066,
"styleRecalcs": 95,
"styleRecalcDurationMs": 15.146999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15519.885000000002,
"heapDeltaBytes": -42336340,
"heapUsedBytes": 180974432,
"domNodes": -8077,
"jsHeapTotalBytes": -13905920,
"scriptDurationMs": 909.2900000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 173,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4915.70999999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.22299999999997,
"layouts": 20,
"layoutDurationMs": 22.789000000000005,
"taskDurationMs": 4789.016000000001,
"heapDeltaBytes": -51923104,
"heapUsedBytes": 179117204,
"domNodes": -8068,
"jsHeapTotalBytes": 2068480,
"scriptDurationMs": 87.67099999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 305,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4643.799999999942,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.27900000000003,
"layouts": 20,
"layoutDurationMs": 21.163,
"taskDurationMs": 4550.727999999999,
"heapDeltaBytes": -39354928,
"heapUsedBytes": 183200452,
"domNodes": -8068,
"jsHeapTotalBytes": 16072704,
"scriptDurationMs": 80.19999999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 69,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6718.2639999999765,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6374.842999999999,
"heapDeltaBytes": 120984,
"heapUsedBytes": 177713136,
"domNodes": 0,
"jsHeapTotalBytes": -18350080,
"scriptDurationMs": 105.46699999999998,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6825.122999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6418.5,
"heapDeltaBytes": -12769792,
"heapUsedBytes": 178007964,
"domNodes": 0,
"jsHeapTotalBytes": -21495808,
"scriptDurationMs": 113.51699999999998,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 458.49299999997584,
"styleRecalcs": 20,
"styleRecalcDurationMs": 19.697,
"layouts": 5,
"layoutDurationMs": 1.965,
"taskDurationMs": 126.89899999999999,
"heapDeltaBytes": -11892788,
"heapUsedBytes": 67128500,
"domNodes": 149,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 11.791999999999998,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 439.7510000000011,
"styleRecalcs": 14,
"styleRecalcDurationMs": 14.255,
"layouts": 2,
"layoutDurationMs": 0.441,
"taskDurationMs": 90.522,
"heapDeltaBytes": 4859132,
"heapUsedBytes": 74330196,
"domNodes": 121,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.997999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
🎭 Playwright: ✅ 1993 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 1 Pipeline job failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: c273c2b | Docs | View more details | Give us feedback! |
0dbd7cc to
0d09458
Compare
…1420 (#19976) Serializes graph imports so a second load cannot change the graph while another load is suspended in an extension hook (#11420 regressions). Fixes #19971. The viewport, DPR and framing repairs that this PR first carried moved to #20025. - `loadGraphData`, `loadApiJson` and the Automatic1111 import in `handleFile` enter one app-owned FIFO (`enqueueGraphLoad`). A failed or rejected load releases the queue, and the next load continues. - The load lifecycle otherwise matches `main`. Capture suppression starts right after `beforeLoadGraph` and ends after `afterLoadGraph`. Cleanup still runs before `beforeConfigureGraph`. A graph cleared during activation emits `onGraphLoadError(AbortError)` and resolves `undefined`. - The queue makes #20294's pending-load set and load-id ownership unnecessary, so they are removed. Its tests are restored and adapted to queued loads. - The `app` passed to a graph-load lifecycle hook rejects `loadGraphData`, `loadApiJson` and `handleFile` while that hook dispatch runs. This turns a nested load that would wait on itself into an error. After the dispatch, a retained argument behaves like the real app. - Known limitation: a hook that awaits a load through the global `app` (or `openWorkflow`, Undo or paste) during its own dispatch still waits behind its own load. No extension in the ecosystem search does this, and telling that call apart from an independent user action would need async context the browser does not provide. - `app.test.ts`: the restored #20294/#11420 tests, plus queue tests across workflow, API JSON and A1111 imports, rejection continuation, and cleanup order. - Against the previous head (`37559cc13a`), these restored tests fail: - `does not assign a cleared canvas to Undo while the newer workflow is still preparing` - `closes beforeLoadGraph with an abort when the graph is cleared during activation` - `allows capture while the loaded workflow resource scans are pending` - the pre-configure failure test's suppression assertions - With the queue removed, the restore-ordering, API JSON, A1111 and rejection tests fail. - `extensionService.test.ts`: one table over the three rejected entrypoints, which fails when the facade forwards, and a retained-argument test, which fails when the facade stays active. - `browser_tests/tests/workflow/workflowLoadQueue.spec.ts` (chromium): a second load does not enter `beforeLoadGraph` while the first is held. - Focused Vitest across app, extension, workflow and change-tracker suites: 1336 passed. App and browser typecheck, lint-staged, Knip and changed-file Fallow pass. The PR carries `needs-backport` and `core`/`cloud` 1.54–1.56 labels. Each release target needs its own ancestry check and exact-head validation after this merges. --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
0d09458 to
c273c2b
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 3 |
| 🟢 Low | 4 |
Panel: 8/8 reviewers contributed findings.
| } | ||
|
|
||
| private enqueueGraphLoad<T>(operation: () => Promise<T>): Promise<T> { | ||
| const result = this.graphLoadQueue.then(operation) |
There was a problem hiding this comment.
🟠 High — enqueueGraphLoad serializes every load onto one promise chain with no re-entrancy detection or timeout, so a load awaited from inside an in-flight load — an extension hook reaching the singleton via window.app or import { app }, or workflowService.loadDefaultWorkflow/openWorkflow — waits on a tail that only settles when the outer load returns, deadlocking graphLoadQueue and silently hanging every subsequent workflow load for the rest of the session. The createGraphLoadHookApp proxy only covers the app argument handed to hooks, which is not how most extensions reach it, so the re-entrancy check (or a timeout) belongs in enqueueGraphLoad itself. Raised by 6 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case).
| if (await abortIfSuperseded()) return undefined | ||
| await useExtensionService().invokeExtensionsAsync('afterLoadGraph') | ||
| if (await abortIfSuperseded()) return undefined | ||
| if (!isCurrentGraphLoad()) { |
There was a problem hiding this comment.
🟠 High — The isCurrentGraphLoad() replacement check runs only after afterLoadNewGraph has activated the workflow and afterLoadGraph has announced success, so a load whose graph is cleared during activation fires both a success hook and onGraphLoadError; listeners that pair open/close one-to-one (e.g. agentPanel's depth-counted dirty suppression, nodeSelectionStore.finishWorkflowLoad) get an extra close against a graph already declared replaced. The new test "closes beforeLoadGraph with an abort when the graph is cleared during activation" asserts the terminal hooks are exactly ['onGraphLoadError'], which this ordering contradicts — move the check before activation and before dispatching afterLoadGraph. Raised by 5 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case, claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| ) | ||
| } | ||
|
|
||
| private async loadApiJsonNow( |
There was a problem hiding this comment.
🟠 High — loadApiJsonNow and the newly queued A1111 branch invoke beforeLoadGraph and then clear and rebuild the graph with no catch, so a throw from rootGraph.configure, a custom node constructor or widget callback, importA1111, or activation rejects the public promise without ever dispatching onGraphLoadError. Any suppression/loading state an extension opened in beforeLoadGraph then stays open indefinitely — the exact leak the new try/catch in loadGraphDataNow was added to fix, left open on the two paths this PR just routed through the same queue. Raised by 4 of 8 reviewers (gemini-3.1-pro adversarial, gemini-3.1-pro edge-case, gpt-5.6-sol-max edge-case, gpt-5.6-sol-max adversarial).
| options: { deferWarnings?: boolean } | ||
| ): Promise<void> { | ||
| // false: no workflow load follows to republish the hash. | ||
| useWorkflowService().beforeLoadNewGraph(false) |
There was a problem hiding this comment.
🟡 Medium — Neither loadApiJsonNow nor the A1111 branch sets ChangeTracker.isLoadingGraph, yet both deactivate the outgoing tracker, clean() the root graph, and then build nodes across awaits (nodeReplacementStore.load, importA1111, activation). A capture triggered during that window by the mouseup/keyup/promptQueued listeners wired in ChangeTracker.init serializes the cleared or half-built graph into the still-active outgoing workflow's activeState, corrupting its undo/dirty state — precisely what the new isLoadingGraph = true placement at line 1356 prevents for loadGraphDataNow. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).
| if (await abortIfSuperseded()) return undefined | ||
| if (!isCurrentGraphLoad()) { | ||
| await cancelReplacedLoad() | ||
| return undefined |
There was a problem hiding this comment.
🟡 Medium — Returning undefined here is indistinguishable from success for workflowService.openWorkflow, which treats only loaded === false as failure: the workflow stays open and active, restoreRetainedWorkflow is skipped, and showPendingWarnings still runs even though the graph this load configured was discarded and afterLoadNewGraph already reset its change tracker. ChangeTracker.updateState handles undefined explicitly, so callers are expected to — either give this path a distinguishable outcome or roll back the activation. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| workflowNavigationId?: number | ||
| } = {} | ||
| ): Promise<LoadedComfyWorkflow | boolean | undefined> { | ||
| return this.enqueueGraphLoad(() => |
There was a problem hiding this comment.
🟡 Medium — Replacing abortIfSuperseded with a FIFO queue removes every early bail-out, so a load the user has already navigated past now runs to completion including runMissingModelPipeline/runMissingMediaPipeline (network calls) and showPendingWarnings. Rapid workflow switching therefore replays missing-model/media warnings and dialogs for workflows the user is no longer on, queued one behind the other; openWorkflow passes skipAssetScans: false for fresh remote loads, so this is the normal path rather than an edge case. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial).
| await useExtensionService().invokeExtensionsAsync('beforeLoadGraph') | ||
| } finally { | ||
| useMissingNodesErrorStore().setMissingNodeTypes([]) | ||
| return await this.enqueueGraphLoad(async () => { |
There was a problem hiding this comment.
🟢 Low — handleFile only reserves its queue slot after await getWorkflowDataFromFile(file) resolves, so queue position reflects when metadata parsing finished rather than when the user acted — a file dropped first but slow to parse can land behind, and then overwrite, a workflow opened afterwards. The non-workflow branches (image/audio/video paste, mesh import, templates) are not serialized at all, so they can add nodes to a graph that another queued load is about to clean(). Raised by 3 of 8 reviewers (claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case, gpt-5.6-sol-max adversarial).
| if (dispatching && graphLoadEntrypoints.has(property)) | ||
| return rejectNestedGraphLoad | ||
| const value: unknown = Reflect.get(target, property, target) | ||
| return typeof value === 'function' ? value.bind(target) : value |
There was a problem hiding this comment.
🟢 Low — The get trap returns a freshly bound function on every read and the proxy has no set trap, so hookApp.handleFile !== hookApp.handleFile and hookApp !== app, breaking the capture-original-and-restore monkey-patch idiom and any identity-keyed (Map/WeakMap) bookkeeping extensions do with the app object. A hook that reads an entrypoint into a variable (const original = app.loadGraphData) also captures rejectNestedGraphLoad and keeps it after endDispatch(), permanently installing the rejecting stub if it writes the wrapper back to the singleton. Raised by 4 of 8 reviewers (gemini-3.1-pro adversarial, claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| const graphLoadEntrypoints = new Set<PropertyKey>([ | ||
| 'loadGraphData', | ||
| 'loadApiJson', | ||
| 'handleFile' |
There was a problem hiding this comment.
🟢 Low — Blocking handleFile wholesale over-rejects: its image, audio, video, mesh, and template branches never enqueue a graph load, so an extension importing an asset from afterLoadGraph now fails with an opaque "nested graph load" error. onGraphLoadError is also in the lifecycle set, which rejects the natural recovery of falling back to app.loadGraphData() after a failed load instead of queueing it; per the entity-architecture rules this is a breaking change to the extension callback surface and needs migration guidance. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, kimi-k3-max edge-case).
| ] satisfies (keyof ComfyApp)[]) | ||
|
|
||
| function rejectNestedGraphLoad() { | ||
| return Promise.reject( |
There was a problem hiding this comment.
🟢 Low — rejectNestedGraphLoad hands back an already-rejected promise, so the common fire-and-forget shape void app.loadGraphData(...) inside a hook produces an unhandled rejection that escapes the per-extension try/catch in invokeExtensionsAsync and surfaces through the global handler and error telemetry instead of being logged against the offending extension. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial).
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #21167 +/- ##
=============================================
Coverage ? 66.77%
=============================================
Files ? 1641
Lines ? 75599
Branches ? 0
=============================================
Hits ? 50479
Misses ? 25120
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
backporting to 1.54 is no longer needed. |
Backports #19976 to
cloud/1.54after the automated cherry-pick conflicted with the release branch's earlier graph-load hardening and older extension loader.The resolution preserves the 1.54 workflow-path camera comparison, release-native toast/schema APIs, and cloud extension loading while applying the approved app-owned FIFO, cleanup-before-extension-preparation ordering, load suppression and abort lifecycle, scoped hook facade, and workflow/API/A1111 coverage.
Validation: formatting and diff checks pass. A direct typecheck with the shared current-main dependency tree reports no errors in the changed files after the release adaptations. Focused Vitest is not used as evidence because that cross-worktree dependency setup reproduces the documented invalid Node localStorage behavior; hosted CI is the authoritative exact-head gate.
Source merge: #19976
Resolves the failed automatic backport reported at #19976 (comment)