Repository navigation
[backport core/1.54] fix: repair viewport and graph-load lifecycle defects from #11420 - #21166
christian-byrne wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation failed to run ( Evaluation budget remaining for this pull request: 99 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-16T10:33:37.341Z",
"gitSha": "71cf60938b290e20ff14a30b9dbd31bafef72af1",
"branch": "backport-19976-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2032.2550000000206,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.795000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.911,
"heapDeltaBytes": -3323528,
"heapUsedBytes": 69983768,
"domNodes": -281,
"jsHeapTotalBytes": 3964928,
"scriptDurationMs": 9.069999999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2055.1869999999326,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.189000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.3089999999999,
"heapDeltaBytes": -8055152,
"heapUsedBytes": 65298168,
"domNodes": -279,
"jsHeapTotalBytes": 4227072,
"scriptDurationMs": 9.149999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1866.2419999999997,
"styleRecalcs": 77,
"styleRecalcDurationMs": 31.037000000000003,
"layouts": 14,
"layoutDurationMs": 3.979,
"taskDurationMs": 899.7949999999998,
"heapDeltaBytes": -12358172,
"heapUsedBytes": 61587276,
"domNodes": -279,
"jsHeapTotalBytes": 4489216,
"scriptDurationMs": 163.03400000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1909.4900000000052,
"styleRecalcs": 77,
"styleRecalcDurationMs": 31.406000000000002,
"layouts": 14,
"layoutDurationMs": 4.289000000000001,
"taskDurationMs": 896.215,
"heapDeltaBytes": 7953108,
"heapUsedBytes": 79818740,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 171.189,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1689.9980000000028,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.364,
"layouts": 6,
"layoutDurationMs": 1.111,
"taskDurationMs": 418.5519999999999,
"heapDeltaBytes": 4551204,
"heapUsedBytes": 76171968,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 14.894,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.9090000000115,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.633,
"layouts": 6,
"layoutDurationMs": 1.1789999999999996,
"taskDurationMs": 374.104,
"heapDeltaBytes": 4521500,
"heapUsedBytes": 75358308,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.331999999999997,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 795.4799999999977,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.494000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.226,
"heapDeltaBytes": 17902916,
"heapUsedBytes": 88742412,
"domNodes": 14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 186.87699999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 675.3420000000006,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.133999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.4069999999999,
"heapDeltaBytes": -8407768,
"heapUsedBytes": 63426152,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 162.952,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2070.7739999999717,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.091999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.439,
"heapDeltaBytes": -9590820,
"heapUsedBytes": 71188608,
"domNodes": -278,
"jsHeapTotalBytes": -2064384,
"scriptDurationMs": 36.504999999999995,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.2260000000988,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.878,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.432,
"heapDeltaBytes": 10087988,
"heapUsedBytes": 87782656,
"domNodes": -280,
"jsHeapTotalBytes": -368640,
"scriptDurationMs": 38.117,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2548.5310000000254,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.439,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1750.581,
"heapDeltaBytes": -4273204,
"heapUsedBytes": 77197840,
"domNodes": -278,
"jsHeapTotalBytes": -1576960,
"scriptDurationMs": 893.216,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2256.0569999999416,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.564,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1623.8129999999999,
"heapDeltaBytes": -11653524,
"heapUsedBytes": 67412112,
"domNodes": -275,
"jsHeapTotalBytes": -630784,
"scriptDurationMs": 841.6940000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3672.779000000048,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.149999999999999,
"layouts": 60,
"layoutDurationMs": 12.819,
"taskDurationMs": 1755.0349999999999,
"heapDeltaBytes": 4910848,
"heapUsedBytes": 84793216,
"domNodes": 32,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 817.789,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3641.5610000000243,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.88,
"layouts": 60,
"layoutDurationMs": 12.781,
"taskDurationMs": 1704.895,
"heapDeltaBytes": 3429692,
"heapUsedBytes": 86169652,
"domNodes": 30,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 795.558,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3164.7870000000466,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.811000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1941.9720000000002,
"heapDeltaBytes": 13817076,
"heapUsedBytes": 82010800,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 991.5039999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3095.770000000016,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.899999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1838.687,
"heapDeltaBytes": 4183508,
"heapUsedBytes": 72206756,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 947.1850000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2027.0380000000046,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.173999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.129,
"heapDeltaBytes": 8521272,
"heapUsedBytes": 88251212,
"domNodes": -284,
"jsHeapTotalBytes": -368640,
"scriptDurationMs": 34.653,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2027.8019999999515,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.430999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.8290000000001,
"heapDeltaBytes": 9660992,
"heapUsedBytes": 89235804,
"domNodes": -284,
"jsHeapTotalBytes": -892928,
"scriptDurationMs": 32.093999999999994,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.1649999999572,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.484,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.44100000000003,
"heapDeltaBytes": 14679688,
"heapUsedBytes": 88403504,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 146.352,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 605.6550000000698,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.882000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.58399999999995,
"heapDeltaBytes": 14877776,
"heapUsedBytes": 88235624,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 144.43,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2035.8289999999784,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.031,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.879,
"heapDeltaBytes": -7066728,
"heapUsedBytes": 65854436,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.985999999999997,
"eventListeners": -244,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2022.0160000000078,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.084999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.66900000000004,
"heapDeltaBytes": -4158688,
"heapUsedBytes": 69285240,
"domNodes": -299,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.367,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1731.6660000000184,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.156,
"layouts": 18,
"layoutDurationMs": 4.758,
"taskDurationMs": 842.857,
"heapDeltaBytes": -14555040,
"heapUsedBytes": 61307204,
"domNodes": -296,
"jsHeapTotalBytes": 3964928,
"scriptDurationMs": 114.148,
"eventListeners": -208,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.8999999999633,
"styleRecalcs": 75,
"styleRecalcDurationMs": 27.007,
"layouts": 18,
"layoutDurationMs": 4.894000000000001,
"taskDurationMs": 848.891,
"heapDeltaBytes": -9064860,
"heapUsedBytes": 64684312,
"domNodes": -300,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 115.28699999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.7990000000063,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.11699999999999,
"layouts": 15,
"layoutDurationMs": 15.710999999999999,
"taskDurationMs": 929.006,
"heapDeltaBytes": 20247640,
"heapUsedBytes": 104708280,
"domNodes": 13831,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.550999999999995,
"eventListeners": 2385,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8622.073999999997,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.26499999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6034.571,
"heapDeltaBytes": -9288340,
"heapUsedBytes": 68259944,
"domNodes": -284,
"jsHeapTotalBytes": 3563520,
"scriptDurationMs": 2860.039,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8436.793999999963,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.297,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5821.842000000001,
"heapDeltaBytes": 3330724,
"heapUsedBytes": 81204216,
"domNodes": -283,
"jsHeapTotalBytes": 643072,
"scriptDurationMs": 2769.247,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17328.935999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16753.754999999997,
"heapDeltaBytes": -45620352,
"heapUsedBytes": 179148968,
"domNodes": -8068,
"jsHeapTotalBytes": -16019456,
"scriptDurationMs": 286.757,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16930.293000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16545.068,
"heapDeltaBytes": -39902512,
"heapUsedBytes": 179561180,
"domNodes": -8068,
"jsHeapTotalBytes": -9822208,
"scriptDurationMs": 291.694,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21030.040999999983,
"styleRecalcs": 163,
"styleRecalcDurationMs": 17.554999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20686.591999999997,
"heapDeltaBytes": -40746176,
"heapUsedBytes": 183902036,
"domNodes": -8068,
"jsHeapTotalBytes": -16334848,
"scriptDurationMs": 931.067,
"eventListeners": -14927,
"totalBlockingTimeMs": 103,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20755.90299999999,
"styleRecalcs": 162,
"styleRecalcDurationMs": 17.74899999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20405.761000000002,
"heapDeltaBytes": -54594964,
"heapUsedBytes": 165757012,
"domNodes": -8068,
"jsHeapTotalBytes": -12054528,
"scriptDurationMs": 904.385,
"eventListeners": -14927,
"totalBlockingTimeMs": 18,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6152.301999999963,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.40999999999998,
"layouts": 20,
"layoutDurationMs": 22.560999999999996,
"taskDurationMs": 6050.259999999999,
"heapDeltaBytes": -34686448,
"heapUsedBytes": 183563512,
"domNodes": -8068,
"jsHeapTotalBytes": 16269312,
"scriptDurationMs": 110.47900000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 524,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6169.811999999979,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.202,
"layouts": 20,
"layoutDurationMs": 21.960999999999995,
"taskDurationMs": 6036.834999999999,
"heapDeltaBytes": -34468036,
"heapUsedBytes": 183961176,
"domNodes": -8068,
"jsHeapTotalBytes": 13881344,
"scriptDurationMs": 107.59500000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 361,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8526.211999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8374.07,
"heapDeltaBytes": 6007192,
"heapUsedBytes": 179335708,
"domNodes": 0,
"jsHeapTotalBytes": -12320768,
"scriptDurationMs": 139.23399999999998,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8684.213,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8444.02,
"heapDeltaBytes": 5454864,
"heapUsedBytes": 179302668,
"domNodes": 0,
"jsHeapTotalBytes": -16777216,
"scriptDurationMs": 160.28799999999998,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 118.53000000007796,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.477,
"layouts": 2,
"layoutDurationMs": 1.372,
"taskDurationMs": 80.16100000000002,
"heapDeltaBytes": 3009900,
"heapUsedBytes": 72552532,
"domNodes": 131,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.635000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 101.59699999996974,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.192,
"layouts": 2,
"layoutDurationMs": 0.5469999999999999,
"taskDurationMs": 71.55600000000001,
"heapDeltaBytes": 2994212,
"heapUsedBytes": 74763324,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.616000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
🎭 Playwright: ✅ 1988 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 1 Pipeline job failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 5bbbf45 | Docs | View more details | Give us feedback! |
9ae1eff to
186fc2a
Compare
…1420 (#19976) Serializes graph imports so a second load cannot change the graph while another load is suspended in an extension hook (#11420 regressions). Fixes #19971. The viewport, DPR and framing repairs that this PR first carried moved to #20025. - `loadGraphData`, `loadApiJson` and the Automatic1111 import in `handleFile` enter one app-owned FIFO (`enqueueGraphLoad`). A failed or rejected load releases the queue, and the next load continues. - The load lifecycle otherwise matches `main`. Capture suppression starts right after `beforeLoadGraph` and ends after `afterLoadGraph`. Cleanup still runs before `beforeConfigureGraph`. A graph cleared during activation emits `onGraphLoadError(AbortError)` and resolves `undefined`. - The queue makes #20294's pending-load set and load-id ownership unnecessary, so they are removed. Its tests are restored and adapted to queued loads. - The `app` passed to a graph-load lifecycle hook rejects `loadGraphData`, `loadApiJson` and `handleFile` while that hook dispatch runs. This turns a nested load that would wait on itself into an error. After the dispatch, a retained argument behaves like the real app. - Known limitation: a hook that awaits a load through the global `app` (or `openWorkflow`, Undo or paste) during its own dispatch still waits behind its own load. No extension in the ecosystem search does this, and telling that call apart from an independent user action would need async context the browser does not provide. - `app.test.ts`: the restored #20294/#11420 tests, plus queue tests across workflow, API JSON and A1111 imports, rejection continuation, and cleanup order. - Against the previous head (`37559cc13a`), these restored tests fail: - `does not assign a cleared canvas to Undo while the newer workflow is still preparing` - `closes beforeLoadGraph with an abort when the graph is cleared during activation` - `allows capture while the loaded workflow resource scans are pending` - the pre-configure failure test's suppression assertions - With the queue removed, the restore-ordering, API JSON, A1111 and rejection tests fail. - `extensionService.test.ts`: one table over the three rejected entrypoints, which fails when the facade forwards, and a retained-argument test, which fails when the facade stays active. - `browser_tests/tests/workflow/workflowLoadQueue.spec.ts` (chromium): a second load does not enter `beforeLoadGraph` while the first is held. - Focused Vitest across app, extension, workflow and change-tracker suites: 1336 passed. App and browser typecheck, lint-staged, Knip and changed-file Fallow pass. The PR carries `needs-backport` and `core`/`cloud` 1.54–1.56 labels. Each release target needs its own ancestry check and exact-head validation after this merges. --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
186fc2a to
5bbbf45
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 4 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
| } | ||
|
|
||
| private enqueueGraphLoad<T>(operation: () => Promise<T>): Promise<T> { | ||
| const result = this.graphLoadQueue.then(operation) |
There was a problem hiding this comment.
🟠 High — enqueueGraphLoad chains every load onto one promise with no reentrancy detection, timeout, or abort, so a nested load started from inside a graph-load lifecycle hook waits on a queue entry that is itself awaiting that hook — a permanent deadlock that wedges every later loadGraphData/loadApiJson/A1111 import until the page is reloaded (the old sequence model resolved this by superseding). The extensionService proxy only guards the app argument handed to the hook, so window.app, the imported app singleton, and useWorkflowService().openWorkflow() all bypass it, and it is released when the dispatch settles rather than when the load does. Enforce reentrancy inside enqueueGraphLoad itself.
Raised by 6 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case, claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| if (await abortIfSuperseded()) return undefined | ||
| await useExtensionService().invokeExtensionsAsync('afterLoadGraph') | ||
| if (await abortIfSuperseded()) return undefined | ||
| if (!isCurrentGraphLoad()) { |
There was a problem hiding this comment.
🟠 High — isCurrentGraphLoad() is consulted only after afterLoadNewGraph has already serialized this.rootGraph into the workflow's change tracker and after afterLoadGraph has announced success, so a graph replaced during afterConfigureGraph or activation gets committed and reported as loaded before being aborted, and extensions receive both afterLoadGraph and onGraphLoadError for a single beforeLoadGraph. Check isCurrentGraphLoad() immediately after afterConfigureGraph and again before dispatching afterLoadGraph; note that the new test's expect(terminalHooks).toEqual(['onGraphLoadError']) only holds once the check precedes that dispatch.
Raised by 6 of 8 reviewers (gemini-3.1-pro edge-case, gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case, claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| if (await abortIfSuperseded()) return undefined | ||
| if (!isCurrentGraphLoad()) { | ||
| await cancelReplacedLoad() | ||
| return undefined |
There was a problem hiding this comment.
🟠 High — This early return skips ChangeTracker.isLoadingGraph = false on the next line, and the only other reset is in the preparation catch, so the replaced-load path leaves isLoadingGraph stuck at true for the rest of the session — change capture and undo/redo silently stop working. Because the queue serializes loads, no subsequent load is guaranteed to clear it, and the PR's own 'graph is cleared during activation' test drives exactly this path. Reset the flag in a finally spanning the whole load instead.
Raised by 1 of 8 reviewers (gemini-3.1-pro adversarial).
| workflowNavigationId?: number | ||
| } = {} | ||
| ): Promise<LoadedComfyWorkflow | boolean | undefined> { | ||
| return this.enqueueGraphLoad(() => |
There was a problem hiding this comment.
🟡 Medium — Queued loads can no longer bail out: the removed abortIfSuperseded() checks used to stop an overtaken load before runMissingModelPipeline/runMissingMediaPipeline, so a burst of loads (multi-file drop, rapid workflow-tab clicks, repeated template opens) now serially replays every intermediate load to completion — clean(), configure(), activation, and the network-bound asset scans — while each pending closure retains its whole workflow JSON. Consider dropping or coalescing queued entries that a later enqueue supersedes.
Raised by 3 of 8 reviewers (gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max adversarial).
| const graphLoadEntrypoints = new Set<PropertyKey>([ | ||
| 'loadGraphData', | ||
| 'loadApiJson', | ||
| 'handleFile' |
There was a problem hiding this comment.
🟡 Medium — Only the workflow/API-JSON/A1111 branches of handleFile enqueue a graph load; the image, audio, video, mesh and template branches never touch the queue yet are rejected too, so an extension that drops a media file from a lifecycle hook now fails for no reason. The failure is also invisible — invokeExtensionsAsync only console.errors hook errors, and the idiomatic fire-and-forget app.handleFile(file) surfaces as an unhandled rejection. Gate on the file type, or guard only the entrypoints that actually enqueue.
Raised by 3 of 8 reviewers (gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| if (dispatching && graphLoadEntrypoints.has(property)) | ||
| return rejectNestedGraphLoad | ||
| const value: unknown = Reflect.get(target, property, target) | ||
| return typeof value === 'function' ? value.bind(target) : value |
There was a problem hiding this comment.
🟡 Medium — The get trap returns a freshly bound function on every read, so hookApp.foo !== hookApp.foo: api.addEventListener('x', app.onX) followed by removeEventListener('x', app.onX) never unsubscribes, and monkey-patch checks like app.method === original always fail. Creating a fresh Proxy per dispatch also means hookApp !== app, breaking extensions that key per-app state in a WeakMap or compare against the singleton, and a retained proxy keeps rebinding after endDispatch() so both effects outlive the hook. Returning the raw value (or wrapping only the guarded entrypoints) avoids this.
Raised by 4 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| try { | ||
| await this.reportGraphLoadFailure(error) | ||
| } finally { | ||
| ChangeTracker.isLoadingGraph = false |
There was a problem hiding this comment.
🟡 Medium — When preparation throws after clean(), this finally re-enables capture while the root graph is still empty and activeWorkflow still points at the outgoing workflow, since afterLoadNewGraph never ran on this path. The next captureCanvasState() — a canvas interaction, afterChange, or the debounced squash — then serializes the empty graph into the outgoing workflow's activeState and persists it as that workflow's draft. A malformed workflow file reaching clone(), validateWorkflow(), or loadSubgraphs() is enough to trigger it.
Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| const hookApp = new Proxy(app, { | ||
| get(target, property) { | ||
| if (dispatching && graphLoadEntrypoints.has(property)) | ||
| return rejectNestedGraphLoad |
There was a problem hiding this comment.
🟢 Low — dispatching is evaluated at property-access time, so a hook that caches hookApp.loadGraphData for a later callback keeps a permanently rejecting stub even after endDispatch() — the new 'retained hook app' test passes only because it reads the property after dispatch ends. Return a wrapper that checks dispatching when invoked, and prefer throwing (or rejecting with DOMException(..., 'AbortError'), as the rest of the load lifecycle does) so a fire-and-forget nested call is caught by invokeExtensionsAsync's per-extension handler instead of becoming an unhandled rejection.
Raised by 3 of 8 reviewers (gpt-5.6-sol-max edge-case, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case).
| // Resolves rather than throws: the close/replacement guards read this outcome. | ||
| return false | ||
| } | ||
| const configuredGraphState = this.rootGraph.state |
There was a problem hiding this comment.
🟢 Low — This snapshot assumes configure() ran, but LGraph.configure can return early before clear() (a vetoed configuring event, or an additive configure of a populated graph) and its return value is ignored at the call site. In that case state is still the previous load's object, so isCurrentGraphLoad() reports success and the load goes on to activate the workflow and return true against a graph that was never configured.
Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #21166 +/- ##
=============================================
- Coverage 84.37% 84.35% -0.02%
=============================================
Files 2135 2135
Lines 128311 128307 -4
Branches 32769 32748 -21
=============================================
- Hits 108256 108228 -28
- Misses 19867 19891 +24
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
backporting to 1.54 is no longer needed. |
Backports #19976 to
core/1.54after the automated cherry-pick conflicted with the release branch's earlier graph-load hardening and older browser fixtures.The resolution preserves the 1.54 workflow-path camera comparison and release-native toast/schema APIs while applying the approved app-owned FIFO, cleanup-before-extension-preparation ordering, load suppression and abort lifecycle, scoped hook facade, and workflow/API/A1111 coverage.
Validation: formatting and diff checks pass. A direct typecheck with the shared current-main dependency tree reports no errors in the changed files after the release adaptations. Focused Vitest is not used as evidence because that cross-worktree dependency setup reproduces the documented invalid Node localStorage behavior; hosted CI is the authoritative exact-head gate.
Source merge: #19976
Resolves the failed automatic backport reported at #19976 (comment)