Repository navigation
[backport cloud/1.55] fix: repair viewport and graph-load lifecycle defects from #11420 - #21165
christian-byrne wants to merge 1 commit into
Conversation
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation failed to run ( Evaluation budget remaining for this pull request: 99 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-16T10:20:25.439Z",
"gitSha": "f7e2dc1b8b14c0aaafa7b37a75faca782994bdd1",
"branch": "backport-19976-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1995.002999999997,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.2170000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.327,
"heapDeltaBytes": -714076,
"heapUsedBytes": 62232220,
"domNodes": 21,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 6.402999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2001.1349999999766,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.3309999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.668,
"heapDeltaBytes": -7474508,
"heapUsedBytes": 55500652,
"domNodes": -260,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.543,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.6910000000344,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.389,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.495,
"heapDeltaBytes": -8726416,
"heapUsedBytes": 60244656,
"domNodes": -258,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 103.21600000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.6309999999958,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.02,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.451,
"heapDeltaBytes": -10010764,
"heapUsedBytes": 58709948,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 104.067,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1694.4539999999506,
"styleRecalcs": 28,
"styleRecalcDurationMs": 9.752,
"layouts": 6,
"layoutDurationMs": 0.6809999999999999,
"taskDurationMs": 249.977,
"heapDeltaBytes": 3344368,
"heapUsedBytes": 72504408,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.756999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.5099999999702,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.587000000000002,
"layouts": 6,
"layoutDurationMs": 0.838,
"taskDurationMs": 254.27500000000003,
"heapDeltaBytes": 3632128,
"heapUsedBytes": 72903532,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.8439999999999985,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 511.3829999999666,
"styleRecalcs": 16,
"styleRecalcDurationMs": 6.756,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.727,
"heapDeltaBytes": -7982760,
"heapUsedBytes": 61254260,
"domNodes": 24,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 115.59,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 509.9200000000792,
"styleRecalcs": 16,
"styleRecalcDurationMs": 6.38,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.158,
"heapDeltaBytes": 18053812,
"heapUsedBytes": 81068196,
"domNodes": 23,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 108.736,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1031.232999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 649.433,
"heapDeltaBytes": 24646332,
"heapUsedBytes": 96707440,
"domNodes": -293,
"jsHeapTotalBytes": 19550208,
"scriptDurationMs": 39.992,
"eventListeners": -217,
"totalBlockingTimeMs": 411,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1047.5399999999127,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 633.907,
"heapDeltaBytes": 27824988,
"heapUsedBytes": 99435308,
"domNodes": -292,
"jsHeapTotalBytes": 18763776,
"scriptDurationMs": 43.278999999999996,
"eventListeners": -217,
"totalBlockingTimeMs": 424,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 733.3370000000059,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.4680000000002,
"heapDeltaBytes": 15455180,
"heapUsedBytes": 92352396,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 93.88899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 116,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 715.8670000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 312.78199999999987,
"heapDeltaBytes": 14776168,
"heapUsedBytes": 91627592,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 90.03499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 110,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6136.2100000000055,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.2560000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5033.508,
"heapDeltaBytes": 12072656,
"heapUsedBytes": 92539200,
"domNodes": -263,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 4137.772,
"eventListeners": -174,
"totalBlockingTimeMs": 4,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6072.535000000016,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.5019999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5007.179,
"heapDeltaBytes": -5361564,
"heapUsedBytes": 74478708,
"domNodes": -259,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 4115.181,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6177.601999999979,
"styleRecalcs": 3,
"styleRecalcDurationMs": 4.783,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5167.378,
"heapDeltaBytes": 17172840,
"heapUsedBytes": 98562920,
"domNodes": -256,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 4089.1079999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 20,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6354.314999999929,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.7619999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5448.359,
"heapDeltaBytes": 14592296,
"heapUsedBytes": 94835000,
"domNodes": -267,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 4300.32,
"eventListeners": -174,
"totalBlockingTimeMs": 30,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2008.8010000000054,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.280000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.64500000000004,
"heapDeltaBytes": 3189024,
"heapUsedBytes": 86590044,
"domNodes": -257,
"jsHeapTotalBytes": 2650112,
"scriptDurationMs": 21.718,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2006.633000000079,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.31,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.099,
"heapDeltaBytes": -23919184,
"heapUsedBytes": 66096972,
"domNodes": -250,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 21.914999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2127.4869999999737,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.504,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1100.711,
"heapDeltaBytes": -4306612,
"heapUsedBytes": 80228472,
"domNodes": -258,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 544.0729999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2118.7439999999924,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.999000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1134.6090000000002,
"heapDeltaBytes": 262480,
"heapUsedBytes": 91197368,
"domNodes": -244,
"jsHeapTotalBytes": 3399680,
"scriptDurationMs": 555.5049999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3056.937000000005,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.449000000000002,
"layouts": 60,
"layoutDurationMs": 8.381,
"taskDurationMs": 1104.7980000000002,
"heapDeltaBytes": -763188,
"heapUsedBytes": 65494860,
"domNodes": 36,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 499.356,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3094.966999999997,
"styleRecalcs": 74,
"styleRecalcDurationMs": 11.904,
"layouts": 60,
"layoutDurationMs": 8.463999999999999,
"taskDurationMs": 1057.067,
"heapDeltaBytes": 2247636,
"heapUsedBytes": 95318776,
"domNodes": 44,
"jsHeapTotalBytes": 6328320,
"scriptDurationMs": 515.409,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2261.9430000000307,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.669999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1271.658,
"heapDeltaBytes": 11516060,
"heapUsedBytes": 98896464,
"domNodes": 16,
"jsHeapTotalBytes": 5697536,
"scriptDurationMs": 647.274,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2233.985000000075,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.633,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1329.4420000000002,
"heapDeltaBytes": -25594912,
"heapUsedBytes": 68328080,
"domNodes": -218,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 653.934,
"eventListeners": 28,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2008.2090000000221,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.910999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.07000000000005,
"heapDeltaBytes": -19147980,
"heapUsedBytes": 74440528,
"domNodes": -237,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 18.568,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.1649999999772,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.333000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.77700000000004,
"heapDeltaBytes": -17856540,
"heapUsedBytes": 74146328,
"domNodes": -233,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 20.263999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 462.26000000001477,
"styleRecalcs": 49,
"styleRecalcDurationMs": 8.157,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 281.704,
"heapDeltaBytes": 13032640,
"heapUsedBytes": 84385032,
"domNodes": 23,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 97.83,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 429.2230000000927,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.4750000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 286.74499999999995,
"heapDeltaBytes": 13191328,
"heapUsedBytes": 84300588,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 97.563,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1994.3140000000312,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.135999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 298.336,
"heapDeltaBytes": 7586776,
"heapUsedBytes": 79090344,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.061000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2003.930999999966,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.957,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.74899999999997,
"heapDeltaBytes": 7916964,
"heapUsedBytes": 79092980,
"domNodes": -270,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.016999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1672.3910000000046,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.474,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.206,
"heapDeltaBytes": 18932004,
"heapUsedBytes": 82747168,
"domNodes": 25,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 63.64800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.9469999999565,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.049,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.535,
"heapDeltaBytes": -9249660,
"heapUsedBytes": 61946384,
"domNodes": -275,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 65.343,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 866.5929999999662,
"styleRecalcs": 17,
"styleRecalcDurationMs": 19.868999999999996,
"layouts": 5,
"layoutDurationMs": 8.462000000000002,
"taskDurationMs": 647.694,
"heapDeltaBytes": -6558592,
"heapUsedBytes": 86739068,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 18.288,
"eventListeners": 2383,
"totalBlockingTimeMs": 98,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8132.8050000000185,
"styleRecalcs": 250,
"styleRecalcDurationMs": 22.186999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3775.9379999999996,
"heapDeltaBytes": 2368288,
"heapUsedBytes": 92726760,
"domNodes": -241,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 1795.396,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8155.428000000029,
"styleRecalcs": 251,
"styleRecalcDurationMs": 21.443,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3799.759,
"heapDeltaBytes": -4627892,
"heapUsedBytes": 85961220,
"domNodes": -230,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 1815.2949999999998,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10552.298000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9784.822,
"heapDeltaBytes": -38115712,
"heapUsedBytes": 199118952,
"domNodes": -8062,
"jsHeapTotalBytes": -14368768,
"scriptDurationMs": 109.827,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10530.474000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9782.594,
"heapDeltaBytes": -68654524,
"heapUsedBytes": 172494404,
"domNodes": -8062,
"jsHeapTotalBytes": -15929344,
"scriptDurationMs": 104.171,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 12814.84499999999,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.688000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12133.507000000001,
"heapDeltaBytes": -52665604,
"heapUsedBytes": 188626744,
"domNodes": -8062,
"jsHeapTotalBytes": -13045760,
"scriptDurationMs": 506.09800000000007,
"eventListeners": -14928,
"totalBlockingTimeMs": 20,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 12818.314999999984,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.430999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12208.470000000001,
"heapDeltaBytes": -40677800,
"heapUsedBytes": 179248628,
"domNodes": -8062,
"jsHeapTotalBytes": -12304384,
"scriptDurationMs": 521.529,
"eventListeners": -14928,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3839.7579999999607,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.98900000000001,
"layouts": 20,
"layoutDurationMs": 15.424000000000007,
"taskDurationMs": 3671.176,
"heapDeltaBytes": -65364804,
"heapUsedBytes": 175867544,
"domNodes": -8062,
"jsHeapTotalBytes": 12120064,
"scriptDurationMs": 47.152,
"eventListeners": -14928,
"totalBlockingTimeMs": 85,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3836.7490000000544,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.60999999999999,
"layouts": 20,
"layoutDurationMs": 16.249,
"taskDurationMs": 3675.472,
"heapDeltaBytes": -40369056,
"heapUsedBytes": 173578788,
"domNodes": -8062,
"jsHeapTotalBytes": 14696448,
"scriptDurationMs": 49.29,
"eventListeners": -14928,
"totalBlockingTimeMs": 75,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5307.699000000071,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5000.754000000001,
"heapDeltaBytes": 14123520,
"heapUsedBytes": 191265156,
"domNodes": 0,
"jsHeapTotalBytes": -22282240,
"scriptDurationMs": 52.21199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5273.780999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5011.951,
"heapDeltaBytes": 14000632,
"heapUsedBytes": 184466640,
"domNodes": 0,
"jsHeapTotalBytes": -23592960,
"scriptDurationMs": 53.19299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 456.21600000004037,
"styleRecalcs": 23,
"styleRecalcDurationMs": 19.983,
"layouts": 5,
"layoutDurationMs": 2.0220000000000002,
"taskDurationMs": 116.24399999999999,
"heapDeltaBytes": 5485224,
"heapUsedBytes": 72159512,
"domNodes": 158,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.415000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 419.7360000000572,
"styleRecalcs": 22,
"styleRecalcDurationMs": 19.53,
"layouts": 4,
"layoutDurationMs": 1.4559999999999997,
"taskDurationMs": 94.02300000000001,
"heapDeltaBytes": 5104888,
"heapUsedBytes": 72464752,
"domNodes": 151,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.618000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2156 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6f006f3f600ce5acbfc7a9e02ac1ceedc127b0fd
Full docs: ADR-DEVEX-LINT-0015 |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 1 Pipeline job failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 6c2b7d9 | Docs | View more details | Give us feedback! |
…1420 (#19976) Serializes graph imports so a second load cannot change the graph while another load is suspended in an extension hook (#11420 regressions). Fixes #19971. The viewport, DPR and framing repairs that this PR first carried moved to #20025. - `loadGraphData`, `loadApiJson` and the Automatic1111 import in `handleFile` enter one app-owned FIFO (`enqueueGraphLoad`). A failed or rejected load releases the queue, and the next load continues. - The load lifecycle otherwise matches `main`. Capture suppression starts right after `beforeLoadGraph` and ends after `afterLoadGraph`. Cleanup still runs before `beforeConfigureGraph`. A graph cleared during activation emits `onGraphLoadError(AbortError)` and resolves `undefined`. - The queue makes #20294's pending-load set and load-id ownership unnecessary, so they are removed. Its tests are restored and adapted to queued loads. - The `app` passed to a graph-load lifecycle hook rejects `loadGraphData`, `loadApiJson` and `handleFile` while that hook dispatch runs. This turns a nested load that would wait on itself into an error. After the dispatch, a retained argument behaves like the real app. - Known limitation: a hook that awaits a load through the global `app` (or `openWorkflow`, Undo or paste) during its own dispatch still waits behind its own load. No extension in the ecosystem search does this, and telling that call apart from an independent user action would need async context the browser does not provide. - `app.test.ts`: the restored #20294/#11420 tests, plus queue tests across workflow, API JSON and A1111 imports, rejection continuation, and cleanup order. - Against the previous head (`37559cc13a`), these restored tests fail: - `does not assign a cleared canvas to Undo while the newer workflow is still preparing` - `closes beforeLoadGraph with an abort when the graph is cleared during activation` - `allows capture while the loaded workflow resource scans are pending` - the pre-configure failure test's suppression assertions - With the queue removed, the restore-ordering, API JSON, A1111 and rejection tests fail. - `extensionService.test.ts`: one table over the three rejected entrypoints, which fails when the facade forwards, and a retained-argument test, which fails when the facade stays active. - `browser_tests/tests/workflow/workflowLoadQueue.spec.ts` (chromium): a second load does not enter `beforeLoadGraph` while the first is held. - Focused Vitest across app, extension, workflow and change-tracker suites: 1336 passed. App and browser typecheck, lint-staged, Knip and changed-file Fallow pass. The PR carries `needs-backport` and `core`/`cloud` 1.54–1.56 labels. Each release target needs its own ancestry check and exact-head validation after this merges. --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
d17df01 to
6c2b7d9
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 4 |
| 🟡 Medium | 4 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
| let dispatching = true | ||
| const hookApp = new Proxy(app, { | ||
| get(target, property) { | ||
| if (dispatching && graphLoadEntrypoints.has(property)) |
There was a problem hiding this comment.
🟠 High — The nested-load guard only covers the app object handed to the hook, but the same ComfyApp singleton is reachable as the @/scripts/app import and as window.app — how most extensions actually get it — and service-level callers such as workflowService.openWorkflow bypass the proxy entirely. A hook that awaits a load through any of those now deadlocks graphLoadQueue permanently: the nested load cannot start until the in-flight load settles, and that load is awaiting the hook, so every later workflow open, import, and file drop hangs silently until reload (before this change the same call merely raced). A re-entrancy flag on ComfyApp checked inside enqueueGraphLoad would close the hole the proxy leaves open.
Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, kimi-k3-max adversarial).
| effectiveShareId | ||
| ) | ||
| await useExtensionService().invokeExtensionsAsync('afterLoadGraph') | ||
| if (!isCurrentGraphLoad()) { |
There was a problem hiding this comment.
🟠 High — The replacement guard is evaluated only after afterLoadNewGraph has activated the incoming workflow and after afterLoadGraph has been dispatched, so a clear/reconfigure landing during activation or during afterLoadGraph itself still serializes and activates the replacement and tells every extension the load succeeded, then emits onGraphLoadError(AbortError) for that same load. Extensions therefore observe the incoherent sequence afterLoadGraph → onGraphLoadError with side effects already applied. Move the check and abort ahead of the afterLoadGraph dispatch, ideally before activation.
Raised by 5 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, gemini-3.1-pro edge-case, kimi-k3-max edge-case, kimi-k3-max adversarial).
| await cancelReplacedLoad() | ||
| return undefined | ||
| } | ||
| ChangeTracker.isLoadingGraph = false |
There was a problem hiding this comment.
🟠 High — ChangeTracker.isLoadingGraph = true (line 1374) is cleared here on success and in the failure path's new finally at line 1529, but the abort return immediately above skips both, so a load that loses the replacement check leaves the flag true for the rest of the session: captureCanvasState() no-ops and undo history plus draft persistence silently stop working. Reset the flag in a finally that covers every exit from loadGraphDataNow, and have the new abort test assert ChangeTracker.isLoadingGraph === false.
Raised by 2 of 8 reviewers (gemini-3.1-pro adversarial, gemini-3.1-pro edge-case).
| fileName: string, | ||
| options: { deferWarnings?: boolean } = {} | ||
| ): Promise<void> { | ||
| return this.enqueueGraphLoad(() => |
There was a problem hiding this comment.
🟠 High — The new ChangeTracker.isLoadingGraph guard protects loadGraphDataNow only. loadApiJsonNow and the A1111 branch (line 2315) now share the same queue but clear and rebuild the root graph with the flag still false while activeWorkflow still points at the outgoing workflow, across awaits on nodeReplacementStore.load() and the /embeddings fetch. Any captureCanvasState() in that window (debounced squashState, mouseup, widget change) serializes the emptied or imported graph into the outgoing workflow's activeState — exactly the corruption the guard was added to prevent.
Raised by 3 of 8 reviewers (gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| } | ||
|
|
||
| private enqueueGraphLoad<T>(operation: () => Promise<T>): Promise<T> { | ||
| const result = this.graphLoadQueue.then(operation) |
There was a problem hiding this comment.
🟡 Medium — The queue has no timeout, cancellation, or supersede path, and the slot stays held through nodeReplacementStore.load(), the missing-model/missing-media verification scans, and the A1111 /embeddings fetch. A single third-party beforeLoadGraph hook that never settles, or an unresponsive backend, now wedges every later loadGraphData, loadApiJson, and import with no error surfaced, whereas committedGraphLoadSequence previously let a newer load overtake a stuck one. Releasing the queue once the graph is configured and activated — the same point where isLoadingGraph is cleared — keeps the ordering guarantee without holding it through asset verification.
Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial, gpt-5.6-sol-max edge-case).
| await useExtensionService().invokeExtensionsAsync('afterLoadGraph') | ||
| if (!isCurrentGraphLoad()) { | ||
| await cancelReplacedLoad() | ||
| return undefined |
There was a problem hiding this comment.
🟡 Medium — This abort resolves to undefined, but workflowService.openWorkflow treats only loaded === false as a failure, so an aborted load falls through to the success path: the tab is reported as opened while the canvas holds the cleared/replaced graph, and restoreRetainedWorkflow() never runs. Return false here, or teach the callers to treat undefined as a non-success.
Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial).
| const hookApp = new Proxy(app, { | ||
| get(target, property) { | ||
| if (dispatching && graphLoadEntrypoints.has(property)) | ||
| return rejectNestedGraphLoad |
There was a problem hiding this comment.
🟡 Medium — rejectNestedGraphLoad is substituted at property read time and returns an already-rejected promise, so an extension that destructures or monkey-patches an entrypoint during a hook (const orig = app.loadGraphData; app.loadGraphData = function (...a) { return orig.apply(this, a) }) captures a stub that keeps rejecting after endDispatch() — and because the proxy defines no set trap, that wrapper is written straight onto the real singleton, breaking loads for the rest of the session. Fire-and-forget calls (void app.handleFile(f)) also become unhandled rejections that escape the per-extension try/catch in invokeExtensionsAsync and reach global error telemetry instead of the extension author. Returning a bound wrapper that checks dispatching at call time and throws synchronously addresses both.
Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, kimi-k3-max edge-case).
| if (dispatching && graphLoadEntrypoints.has(property)) | ||
| return rejectNestedGraphLoad | ||
| const value: unknown = Reflect.get(target, property, target) | ||
| return typeof value === 'function' ? value.bind(target) : value |
There was a problem hiding this comment.
🟡 Medium — Binding on every read means hookApp.fn !== hookApp.fn, so idempotency-guarded patches (if (app.fn !== myWrapper) wrap()) re-wrap on every dispatch and a method stashed for a later removeEventListener or used as a Map/Set key never matches. bind also drops own properties, so hookApp.constructor loses the ComfyApp statics that changeTracker.ts reads as app.constructor.maskeditor_is_opended. Cache bound methods in a WeakMap, or bind only methods rather than every function-valued property.
Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gemini-3.1-pro adversarial).
| return false | ||
| } | ||
| const configuredGraphState = this.rootGraph.state | ||
| const isCurrentGraphLoad = () => |
There was a problem hiding this comment.
🟢 Low — Using LGraph.state object identity as the load token only detects a whole-object swap from clear(), and it is a mutable litegraph internal. In-place replacement leaves state identical and the stale load commits anyway (configure(data, keep_old), a listener cancelling configuring, or the CRDT/agent applier), while an extension calling the long-standing public app.graph.clear()/configure() inside a hook flips it and aborts a legitimate load. A monotonic token owned by ComfyApp, which is what committedGraphLoadSequence was, avoids both directions of failure.
Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial).
| await useExtensionService().invokeExtensionsAsync('beforeLoadGraph') | ||
| } finally { | ||
| useMissingNodesErrorStore().setMissingNodeTypes([]) | ||
| return await this.enqueueGraphLoad(async () => { |
There was a problem hiding this comment.
🟢 Low — This enqueued block has no try/catch, and neither does loadApiJsonNow, so once the beforeGraphClear callback has dispatched beforeLoadGraph any later throw (importA1111, afterConfigureGraph, afterLoadNewGraph, afterLoadGraph) escapes without ever dispatching onGraphLoadError, leaving any suppression/loading state a listener opened permanently open — the leak the comment at line 1524 says the terminal hook exists to prevent. Now that these paths share loadGraphData's queue, callers reasonably expect the same lifecycle guarantees.
Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #21165 +/- ##
=============================================
Coverage ? 66.02%
=============================================
Files ? 1782
Lines ? 79291
Branches ? 0
=============================================
Hits ? 52355
Misses ? 26936
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
backporting to 1.55 is no longer needed. |
Backports #19976 to
cloud/1.55after the automated cherry-pick conflicted with the release branch's earlier graph-load hardening.The resolution keeps the release-native toast API while applying the approved app-owned FIFO, cleanup-before-extension-preparation ordering, load suppression and abort lifecycle, scoped hook facade, and workflow/API/A1111 coverage. It is patch-equivalent to the core/1.55 repair.
Validation: formatting and diff checks pass. A direct typecheck with the shared current-main dependency tree reports only known release/dependency mismatches outside the changed files. Focused Vitest is not used as evidence because that cross-worktree dependency setup reproduces the documented invalid Node localStorage behavior; hosted CI is the authoritative exact-head gate.
Source merge: #19976
Resolves the failed automatic backport reported at #19976 (comment)