Repository navigation
[backport core/1.55] fix: repair viewport and graph-load lifecycle defects from #11420 - #21164
christian-byrne wants to merge 1 commit into
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation failed to run ( Evaluation budget remaining for this pull request: 99 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-16T10:22:07.651Z",
"gitSha": "1ea06994ee0beb4178ba33b19b62c0e76baf5aa0",
"branch": "backport-19976-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.1669999999813,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.943999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.36499999999995,
"heapDeltaBytes": 209596,
"heapUsedBytes": 69358244,
"domNodes": -261,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.354999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2008.073999999965,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.853,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.328,
"heapDeltaBytes": -6178496,
"heapUsedBytes": 56669544,
"domNodes": -260,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 12.076,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1698.912000000007,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.228999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 652.3030000000001,
"heapDeltaBytes": 8605780,
"heapUsedBytes": 77605372,
"domNodes": -260,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 118.463,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1734.3970000000581,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.546,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 735.5820000000001,
"heapDeltaBytes": 9462160,
"heapUsedBytes": 78403664,
"domNodes": -259,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 126.14899999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.4559999999692,
"styleRecalcs": 28,
"styleRecalcDurationMs": 14.910000000000002,
"layouts": 6,
"layoutDurationMs": 1.0600000000000003,
"taskDurationMs": 256.99000000000007,
"heapDeltaBytes": 3615648,
"heapUsedBytes": 72790864,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 13.031999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.8440000000091,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.119000000000003,
"layouts": 6,
"layoutDurationMs": 1.2489999999999999,
"taskDurationMs": 358.157,
"heapDeltaBytes": 3623856,
"heapUsedBytes": 72774048,
"domNodes": 81,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 14.951000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 551.037000000008,
"styleRecalcs": 16,
"styleRecalcDurationMs": 8.776000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.889,
"heapDeltaBytes": -8005992,
"heapUsedBytes": 61223696,
"domNodes": 23,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 134.657,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 576.3829999999643,
"styleRecalcs": 16,
"styleRecalcDurationMs": 9.179,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.97,
"heapDeltaBytes": 17932912,
"heapUsedBytes": 86887272,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 138.91,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 992.0039999999517,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.759,
"heapDeltaBytes": 35401260,
"heapUsedBytes": 103154684,
"domNodes": 0,
"jsHeapTotalBytes": 19296256,
"scriptDurationMs": 47.82800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 386,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1078.0899999999747,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 762.681,
"heapDeltaBytes": 39347412,
"heapUsedBytes": 107167604,
"domNodes": 0,
"jsHeapTotalBytes": 18509824,
"scriptDurationMs": 55.38700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 462,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 766.8100000000209,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.3639999999997,
"heapDeltaBytes": 14664188,
"heapUsedBytes": 92382928,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.75800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 156,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 777.5190000000975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.536,
"heapDeltaBytes": 14798380,
"heapUsedBytes": 90783548,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 124.14900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 160,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7978.621000000032,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.8469999999999971,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7035.7080000000005,
"heapDeltaBytes": -6854048,
"heapUsedBytes": 74905056,
"domNodes": -16,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 5693.543,
"eventListeners": 0,
"totalBlockingTimeMs": 125,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7370.011999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6472.837,
"heapDeltaBytes": -107424,
"heapUsedBytes": 81532504,
"domNodes": -16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 5205.058999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 38,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7719.752999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6809.580999999999,
"heapDeltaBytes": -12175964,
"heapUsedBytes": 69448404,
"domNodes": -18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 5529.855,
"eventListeners": 0,
"totalBlockingTimeMs": 115,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7911.681999999928,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.8689999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7008.0070000000005,
"heapDeltaBytes": -4592636,
"heapUsedBytes": 75458948,
"domNodes": -273,
"jsHeapTotalBytes": 9953280,
"scriptDurationMs": 5677.822000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 38,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2005.9179999999515,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.303999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.6760000000001,
"heapDeltaBytes": 2791236,
"heapUsedBytes": 86248324,
"domNodes": -259,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 32.677,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2006.9659999999203,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.770999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.132,
"heapDeltaBytes": 9578964,
"heapUsedBytes": 73310936,
"domNodes": -241,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.251000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2129.243000000031,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.696000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1276.715,
"heapDeltaBytes": 561384,
"heapUsedBytes": 64991924,
"domNodes": -241,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 672.345,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2184.332999999924,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.963000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1461.3960000000002,
"heapDeltaBytes": 973776,
"heapUsedBytes": 91553544,
"domNodes": -251,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 725.831,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3270.185000000083,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.66,
"layouts": 60,
"layoutDurationMs": 13.665999999999999,
"taskDurationMs": 1440.242,
"heapDeltaBytes": -15519240,
"heapUsedBytes": 76461408,
"domNodes": -240,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 643.091,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3329.498000000058,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.478,
"layouts": 60,
"layoutDurationMs": 14.239,
"taskDurationMs": 1513.0160000000003,
"heapDeltaBytes": -696344,
"heapUsedBytes": 65401208,
"domNodes": 30,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 696.216,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2347.7719999999636,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.517999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1507.348,
"heapDeltaBytes": 14165412,
"heapUsedBytes": 107136968,
"domNodes": 18,
"jsHeapTotalBytes": 6483968,
"scriptDurationMs": 777.1570000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2635.7570000000123,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.543,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1735.8669999999997,
"heapDeltaBytes": -17032388,
"heapUsedBytes": 77088920,
"domNodes": 14,
"jsHeapTotalBytes": 6328320,
"scriptDurationMs": 900.957,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.0349999999507,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.492,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.479,
"heapDeltaBytes": -23755580,
"heapUsedBytes": 68552464,
"domNodes": -254,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 32.792,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.0290000000132,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.562000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.2440000000001,
"heapDeltaBytes": -17289636,
"heapUsedBytes": 74103848,
"domNodes": -242,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 34.293,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 533.4609999999884,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.606000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.113,
"heapDeltaBytes": 13248056,
"heapUsedBytes": 84371532,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 120.31800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 557.3669999999993,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.956,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.33000000000004,
"heapDeltaBytes": 13270208,
"heapUsedBytes": 84069888,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 130.00099999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.0910000000163,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.367999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.451,
"heapDeltaBytes": -7390404,
"heapUsedBytes": 63818468,
"domNodes": -274,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.540999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.7909999999974,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.694,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.32899999999995,
"heapDeltaBytes": -5556828,
"heapUsedBytes": 65684752,
"domNodes": -273,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.852,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.7169999999924,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.665000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.545,
"heapDeltaBytes": 6332168,
"heapUsedBytes": 77339084,
"domNodes": -260,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 85.21300000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.691000000058,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.052999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 666.364,
"heapDeltaBytes": 4707664,
"heapUsedBytes": 75921056,
"domNodes": -276,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 94.35700000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1318.706999999904,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.831999999999994,
"layouts": 5,
"layoutDurationMs": 9.932,
"taskDurationMs": 810.7060000000001,
"heapDeltaBytes": -6392016,
"heapUsedBytes": 81809992,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 26.680999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 95,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8229.152999999997,
"styleRecalcs": 251,
"styleRecalcDurationMs": 43.171,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4747.81,
"heapDeltaBytes": -4505368,
"heapUsedBytes": 84876048,
"domNodes": -244,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 2292.476,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8206.099999999991,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.056000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4600.844,
"heapDeltaBytes": 2418068,
"heapUsedBytes": 92293380,
"domNodes": -241,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 2397.009,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14807.189999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14677.409000000001,
"heapDeltaBytes": -33002344,
"heapUsedBytes": 189934700,
"domNodes": -8062,
"jsHeapTotalBytes": -21467136,
"scriptDurationMs": 242.578,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14779.053999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14689.722,
"heapDeltaBytes": -46212596,
"heapUsedBytes": 182145700,
"domNodes": -8062,
"jsHeapTotalBytes": -24420352,
"scriptDurationMs": 246.7,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17597.79900000001,
"styleRecalcs": 123,
"styleRecalcDurationMs": 16.257000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17493.046,
"heapDeltaBytes": -32183904,
"heapUsedBytes": 190087868,
"domNodes": -8062,
"jsHeapTotalBytes": -22487040,
"scriptDurationMs": 714.6060000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 9,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17551.608999999986,
"styleRecalcs": 122,
"styleRecalcDurationMs": 16.80300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17436.435,
"heapDeltaBytes": -73912396,
"heapUsedBytes": 169187928,
"domNodes": -8062,
"jsHeapTotalBytes": -23154688,
"scriptDurationMs": 712.619,
"eventListeners": -14928,
"totalBlockingTimeMs": 26,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5450.34899999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.41199999999999,
"layouts": 20,
"layoutDurationMs": 22.592000000000002,
"taskDurationMs": 5417.979,
"heapDeltaBytes": -23775560,
"heapUsedBytes": 199054640,
"domNodes": -8062,
"jsHeapTotalBytes": 14319616,
"scriptDurationMs": 89.83999999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 281,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5455.073000000084,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.12100000000004,
"layouts": 20,
"layoutDurationMs": 23.357000000000003,
"taskDurationMs": 5415.952,
"heapDeltaBytes": -45125752,
"heapUsedBytes": 177187552,
"domNodes": -8061,
"jsHeapTotalBytes": 6090752,
"scriptDurationMs": 124.476,
"eventListeners": -14928,
"totalBlockingTimeMs": 327,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7358.559000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7255.547,
"heapDeltaBytes": 5387104,
"heapUsedBytes": 175789876,
"domNodes": 0,
"jsHeapTotalBytes": -27787264,
"scriptDurationMs": 109.45100000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7411.938999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7336.336000000001,
"heapDeltaBytes": -7817884,
"heapUsedBytes": 184893372,
"domNodes": 0,
"jsHeapTotalBytes": -15728640,
"scriptDurationMs": 101.85700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 463.91700000003766,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.589,
"layouts": 6,
"layoutDurationMs": 2.357,
"taskDurationMs": 127.38300000000002,
"heapDeltaBytes": 5339808,
"heapUsedBytes": 72486428,
"domNodes": 157,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.571,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 92.84299999990253,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.280999999999999,
"layouts": 3,
"layoutDurationMs": 1.6290000000000002,
"taskDurationMs": 66.108,
"heapDeltaBytes": 2931408,
"heapUsedBytes": 69769820,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.738000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2155 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7ab461f170c2bba8916faae4cda606278fa367a4
Full docs: ADR-DEVEX-LINT-0015 |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 1 Pipeline job failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: e429dc4 | Docs | View more details | Give us feedback! |
c6a4b77 to
d496057
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 6 |
| 🟢 Low | 1 |
Panel: 8/8 reviewers contributed findings.
| } | ||
|
|
||
| private enqueueGraphLoad<T>(operation: () => Promise<T>): Promise<T> { | ||
| const result = this.graphLoadQueue.then(operation) |
There was a problem hiding this comment.
🟠 High — enqueueGraphLoad chains every load onto one promise with no timeout, cancellation, or reentrancy check, and the chain only advances once the previous operation settles. A load started from inside a running queued operation — a lifecycle hook awaiting window.app.loadGraphData(...), useWorkflowService().openWorkflow(), or ChangeTracker.restoreState, or any hook that simply never settles — queues behind the operation that is awaiting it, leaving graphLoadQueue permanently pending so every later workflow/API-JSON/A1111 load hangs silently for the rest of the session. The previous supersede design could not deadlock this way; consider failing fast on reentrancy (an inGraphLoad flag checked inside the real methods) instead of enqueueing.
Raised by 6 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, kimi-k3-max edge-case, gemini-3.1-pro adversarial).
| effectiveShareId | ||
| ) | ||
| await useExtensionService().invokeExtensionsAsync('afterLoadGraph') | ||
| if (!isCurrentGraphLoad()) { |
There was a problem hiding this comment.
🟠 High — The isCurrentGraphLoad() abort fires only after afterLoadNewGraph and afterLoadGraph have already committed the load. If an extension clears or replaces the graph during afterConfigureGraph, this.rootGraph.serialize() captures the emptied graph and afterLoadNewGraph resets the workflow's changeTracker initialState/activeState to it before the abort is detected, destroying the workflow's in-memory content (and the draft persisted from it). It also emits both terminal hooks for one load (afterLoadGraph then onGraphLoadError), breaking the one-close-per-beforeLoadGraph contract the deleted test asserted — and which the new test's terminalHooks === ['onGraphLoadError'] expectation requires — so the check needs to run before activation, or activation needs rolling back.
Raised by 6 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, kimi-k3-max adversarial, gemini-3.1-pro edge-case).
| let dispatching = true | ||
| const hookApp = new Proxy(app, { | ||
| get(target, property) { | ||
| if (dispatching && graphLoadEntrypoints.has(property)) |
There was a problem hiding this comment.
🟠 High — The trap substitutes the property read, not the call, so the standard ComfyUI patch idiom run from a lifecycle hook — const original = app.loadGraphData; app.loadGraphData = async function (...a) { return original.apply(this, a) } — captures rejectNestedGraphLoad as original and, with no set trap, writes the wrapper straight onto the real app, so every later loadGraphData call in the session rejects. The guard is also bypassed entirely by hooks that reach the same instance via window.app or the imported module singleton, which re-enter the queue and deadlock rather than reject. Rejecting at call time (wrap the real method and check dispatching inside) closes both holes.
Raised by 4 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case).
| await useExtensionService().invokeExtensionsAsync('afterLoadGraph') | ||
| if (!isCurrentGraphLoad()) { | ||
| await cancelReplacedLoad() | ||
| return undefined |
There was a problem hiding this comment.
🟡 Medium — Returning undefined on the aborted path is read as success by callers that only test for false: workflowService.openWorkflow checks if (loaded === false), so a load aborted because the graph was replaced skips restoreRetainedWorkflow, still calls showPendingWarnings, and returns true — leaving the user with a cleared canvas and a workflow reported as successfully opened. This path was previously unreachable (supersession was detected before configure), so the new detection needs a return value callers can distinguish.
Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).
| fileName: string, | ||
| options: { deferWarnings?: boolean } = {} | ||
| ): Promise<void> { | ||
| return this.enqueueGraphLoad(() => |
There was a problem hiding this comment.
🟡 Medium — loadApiJsonNow is now serialized with loadGraphData through the same queue but never sets ChangeTracker.isLoadingGraph, even though it calls clean() and then rootGraph.add() per node plus rootGraph.arrange() while activeWorkflow still points at the outgoing workflow — exactly the window the flag exists to protect. Any captureCanvasState() triggered by those mutations serializes the incoming graph into the outgoing workflow's activeState and pushes an undo entry. The A1111 branch wrapped at line 2307 has the same gap.
Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| @@ -2280,55 +2304,61 @@ export class ComfyApp { | |||
|
|
|||
| // Use parameters strictly as the final fallback | |||
| if (parameters && typeof parameters === 'string') { | |||
There was a problem hiding this comment.
🟡 Medium — handleFile only reaches the queue after await getWorkflowDataFromFile(...), so imports take their queue slot in parse-completion order rather than call order — the PNG-workflow and API-JSON branches enqueue after parsing too. Dropping several files at once, or one large and one small, can therefore leave an earlier file's workflow on the canvas instead of the last one dropped. The new coverage only exercises the A1111 branch, so this ordering gap is untested.
Raised by 3 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max adversarial).
| await useExtensionService().invokeExtensionsAsync('beforeLoadGraph') | ||
| } finally { | ||
| useMissingNodesErrorStore().setMissingNodeTypes([]) | ||
| return await this.enqueueGraphLoad(async () => { |
There was a problem hiding this comment.
🟡 Medium — If importA1111 (or anything after it in this enqueued block) throws, the beforeLoadGraph dispatched inside the callback is never closed by afterLoadGraph or onGraphLoadError, so extensions that open suppression/loading state on beforeLoadGraph stay stuck. Wrap the enqueued body so every path emits exactly one terminal hook, the way loadGraphDataNow does via reportGraphLoadFailure.
Raised by 2 of 8 reviewers (gemini-3.1-pro adversarial, gemini-3.1-pro edge-case).
| return false | ||
| } | ||
| const configuredGraphState = this.rootGraph.state | ||
| const isCurrentGraphLoad = () => |
There was a problem hiding this comment.
🟡 Medium — Using rootGraph.state object identity as the "still my load" token couples the guard to unrelated bookkeeping: clean() skips rootGraph.clear() entirely when the canvas is inside a subgraph, and an entity-id rekey preserves the same state object, so several real "my graph was replaced" cases are invisible to the check and any future change to id/state bookkeeping silently breaks it. The loadId already minted on line 1352, recorded as the graph's current owner, would express the intent directly.
Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| workflowNavigationId?: number | ||
| } = {} | ||
| ): Promise<LoadedComfyWorkflow | boolean | undefined> { | ||
| return this.enqueueGraphLoad(() => |
There was a problem hiding this comment.
🟡 Medium — Removing the loadId < committedGraphLoadSequence abort means superseded loads are no longer skipped — every queued load now runs rootGraph.configure, the full node fix-up walk, and the runMissingModelPipeline/runMissingMediaPipeline backend scans. Arrow-key navigation through the workflows sidebar or a multi-file drop therefore replays each intermediate workflow in full and serially, and because the chain is unbounded each pending entry retains its whole workflow JSON closure until it runs.
Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| const graphLoadEntrypoints = new Set<PropertyKey>([ | ||
| 'loadGraphData', | ||
| 'loadApiJson', | ||
| 'handleFile' |
There was a problem hiding this comment.
🟢 Low — handleFile is blocked wholesale even though most of its branches — image paste, audio, video, 3D mesh, loadTemplateData — never enqueue a graph load; only the A1111 fallback does. An extension calling app.handleFile(imageFile) from afterLoadGraph to drop an image node now gets a misleading "cannot start a nested graph load", and that rejection is invisible: invokeExtensionsAsync funnels it to console.error with no toast and no reportError, while a fire-and-forget caller gets an unhandled rejection instead.
Raised by 4 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, kimi-k3-max edge-case).
…1420 (#19976) Serializes graph imports so a second load cannot change the graph while another load is suspended in an extension hook (#11420 regressions). Fixes #19971. The viewport, DPR and framing repairs that this PR first carried moved to #20025. - `loadGraphData`, `loadApiJson` and the Automatic1111 import in `handleFile` enter one app-owned FIFO (`enqueueGraphLoad`). A failed or rejected load releases the queue, and the next load continues. - The load lifecycle otherwise matches `main`. Capture suppression starts right after `beforeLoadGraph` and ends after `afterLoadGraph`. Cleanup still runs before `beforeConfigureGraph`. A graph cleared during activation emits `onGraphLoadError(AbortError)` and resolves `undefined`. - The queue makes #20294's pending-load set and load-id ownership unnecessary, so they are removed. Its tests are restored and adapted to queued loads. - The `app` passed to a graph-load lifecycle hook rejects `loadGraphData`, `loadApiJson` and `handleFile` while that hook dispatch runs. This turns a nested load that would wait on itself into an error. After the dispatch, a retained argument behaves like the real app. - Known limitation: a hook that awaits a load through the global `app` (or `openWorkflow`, Undo or paste) during its own dispatch still waits behind its own load. No extension in the ecosystem search does this, and telling that call apart from an independent user action would need async context the browser does not provide. - `app.test.ts`: the restored #20294/#11420 tests, plus queue tests across workflow, API JSON and A1111 imports, rejection continuation, and cleanup order. - Against the previous head (`37559cc13a`), these restored tests fail: - `does not assign a cleared canvas to Undo while the newer workflow is still preparing` - `closes beforeLoadGraph with an abort when the graph is cleared during activation` - `allows capture while the loaded workflow resource scans are pending` - the pre-configure failure test's suppression assertions - With the queue removed, the restore-ordering, API JSON, A1111 and rejection tests fail. - `extensionService.test.ts`: one table over the three rejected entrypoints, which fails when the facade forwards, and a retained-argument test, which fails when the facade stays active. - `browser_tests/tests/workflow/workflowLoadQueue.spec.ts` (chromium): a second load does not enter `beforeLoadGraph` while the first is held. - Focused Vitest across app, extension, workflow and change-tracker suites: 1336 passed. App and browser typecheck, lint-staged, Knip and changed-file Fallow pass. The PR carries `needs-backport` and `core`/`cloud` 1.54–1.56 labels. Each release target needs its own ancestry check and exact-head validation after this merges. --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
d496057 to
e429dc4
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.55 #21164 +/- ##
=============================================
- Coverage 85.04% 85.02% -0.03%
=============================================
Files 2348 2348
Lines 134238 134255 +17
Branches 33996 33984 -12
=============================================
- Hits 114167 114150 -17
- Misses 19706 19740 +34
Partials 365 365
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
backporting to 1.55 is no longer needed. |
Backports #19976 to
core/1.55after the automated cherry-pick conflicted with the release branch's earlier graph-load hardening.The resolution keeps the release-native toast API while applying the approved app-owned FIFO, cleanup-before-extension-preparation ordering, load suppression and abort lifecycle, scoped hook facade, and workflow/API/A1111 coverage.
Validation: formatting and diff checks pass. A direct typecheck with the shared current-main dependency tree reports only known release/dependency mismatches outside the changed files. Focused Vitest is not used as evidence because that cross-worktree dependency setup reproduces the documented invalid Node localStorage behavior; hosted CI is the authoritative exact-head gate.
Source merge: #19976
Resolves the failed automatic backport reported at #19976 (comment)