Skip to content

[backport cloud/1.57] ING-212 fix(auth): keep asset redirects off credentialed CORS - #21152

Merged
comfy-pr-bot merged 1 commit into
cloud/1.57from
backport-21145-to-cloud-1.57
Oct 16, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.57from
backport-21145-to-cloud-1.57

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #21145 to cloud/1.57

Automatically created by backport workflow.

## Summary

Cloud asset downloads now keep the session cookie on the same-origin
ingest request without requiring credentialed CORS after ingest
redirects to a signed storage URL. Workspace/CSRF headers and retries
are preserved; genuinely cross-origin ingest requests retain the
authorizer's `include` policy.

Fixes
https://linear.app/comfyorg/issue/ING-212/bug-cloud-completed-video-download-fails-with-cors-redirect-error

**Root cause / why now:** the existing download path already used
`api.fetchApi` to preserve workspace authentication (PR 18421). PR 18716
introduced `credentials: 'include'` for session authorization, and PR
18875 routed Cloud ingest requests through it. With
`unified_web_session` enabled, `/api/assets/{id}/content` still returns
a 302 to GCS, but the followed fetch remains credentialed. GCS's XML API
does not support `Access-Control-Allow-Credentials`, so the browser
rejects the bytes. This was a latent flag-on incompatibility, not a
newly changed download button: [Oct 15 QA records the 100% ramp at 10:04
EDT](https://comfy-organization.slack.com/archives/C0932CGKT5K/p1792075311777139),
and a [later update explicitly confirms 100% in
production](https://comfy-organization.slack.com/archives/C0C6V3NUXPU/p1792093817831899).
The previous tests checked authenticated requests against fetch doubles
without exercising a storage redirect in a browser.

**How:** select `same-origin` at the Cloud session transport boundary
when the request URL resolves to the page's origin. Keep the shared
account-core authorizer unchanged for clients that need cookies across
origins. Passing a download-only option to `fetchApi` would not fix this
because the transport overwrites it with the authorizer's credentials.

## Verification

- RED: with the original source, the new actual-app browser test fails
to download and Chromium logs the missing
`Access-Control-Allow-Credentials` error with credentials mode
`include`. Restoring the fix makes it pass.
- Browser: 2 passed, personal and team workspaces. Actual Media Assets
context-menu Download, authenticated ingest 302 double, separate real
HTTP storage server without ACAC, saved filename and byte comparison. A
cookie seeded for the storage host is not sent; the first hop retains
the session cookie and selected workspace.
- Unit: 364 passed in the 5 affected session/auth, asset-action and
download-utility suites. The URL table covers relative, absolute
same-origin and remote ingest requests. Existing flag-off, CSRF retry
and workspace-denial coverage passes.
- App + browser typechecks, touched-file oxlint/ESLint/oxfmt and knip
passed. Commit and push hooks run without bypasses.
- Browser proof uses the repository-pinned Chromium 153. System Chrome
155 aborts Playwright-intercepted redirects before reaching the storage
server; it is not used as a passing regression result.

### AS IS / TO BE

AS IS: [production report with the PNG
screenshot](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1792109025101229).

TO BE: actual-app Download regressions pass for personal/team workspaces
with this PR. Live production-storage check also passed from
`https://cloud.comfy.org`: a DevTools request using the PR's
`same-origin` credentials policy and workspace/client headers followed
the real authenticated asset-content redirect to
`storage.googleapis.com`, returned HTTP 200 (`image/png`, 2,620,563
bytes), and saved `Nano_Banana_2_00002_.png` (1024 x 1024; SHA-256
`54e4dc472f12a02c702ef71f0853490132e116b84475a9480ab0b03b3e3a9971`).
This validates the production request policy, not a deployed PR bundle
or production UI rollout. The local PR frontend cannot complete that
live GCS check because the production bucket does not allow the
localhost origin; an OPTIONS probe returned ACAO for Cloud but none for
localhost. No signed URL or credentials are included in the evidence.


Follow-up validation: 243 affected session/remote-widget unit tests and
both personal/team browser regressions passed. CI exposed an additional
remote-widget `include` expectation, now aligned with the same-origin
policy. The fixture also handles a missing cookie header via
`Headers.get()` before returning its intended 401 (CodeRabbit feedback).

### Plan position

| Item | Ticket | PR | Status |
| --- | --- | --- | --- |
| Session authorization policy | FE-2895 | [PR
18716](#18716) |
Merged |
| Cloud ingest on web session | FE-2904 | [PR
18875](#18875) |
Merged |
| **Storage redirect compatibility + browser regression** | **ING-212**
| **This PR** | **Ready for review** |

```mermaid
flowchart LR
  auth["FE-2895 / PR 18716"] --> ingest["FE-2904 / PR 18875"]
  ingest --> fix["ING-212 / this PR"]
  classDef current fill:#ffe08a,stroke:#b8860b,stroke-width:3px,color:#000
  class fix current
```

---------

Co-authored-by: GitHub Action <action@github.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Oct 16, 2026
@comfy-pr-bot
comfy-pr-bot requested a review from a team as a code owner October 16, 2026 02:02
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) October 16, 2026 02:02
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.2 MB heap
dom-widget-order-dense-n200-w200-i120: · 34.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 369ms TBT · 77.5 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 43.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 156ms TBT · 72.1 MB heap
extension-clean-combined-draw: · 40.7 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 69ms TBT · 84.4 MB heap
extension-rgthree-prototype-draw: · 40.5 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 29ms TBT · 78.8 MB heap
large-combo-open: · 48.6 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 75.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.1 MB heap
large-graph-pan: · 59.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.9 MB heap
large-graph-zoom: · 59.7 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
legacy-node-drag: · 59.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.3 MB heap
subgraph-transition-enter: · 53.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 110ms TBT · 98.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.6 MB heap
vue-large-graph-idle: · 30.0 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 252.1 MB heap
vue-large-graph-pan: · 27.6 avg FPS · 13.3 P5 FPS ❌ (target: ≥52) · 23ms TBT · 261.4 MB heap
vue-node-resize-workload: · 26.3 avg FPS · 13.3 P5 FPS ❌ (target: ≥52) · 8ms TBT · 257.1 MB heap
vue-zoom-out-idle: · 35.2 avg FPS · 17.2 P5 FPS ❌ (target: ≥52) · 0ms TBT · 253.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.9 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 90.6 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 105.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 2ms
canvas-idle: style recalc duration 2ms
canvas-idle: layout count 10
canvas-idle: style recalc count 11
canvas-idle: task duration 332ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 76.9 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 14ms
canvas-mouse-sweep: layout count 10
canvas-mouse-sweep: style recalc count 83
canvas-mouse-sweep: task duration 877ms
canvas-mouse-sweep: script duration 119ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 64.2 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 5ms
canvas-zoom-sweep: layout count 12
canvas-zoom-sweep: style recalc count 19
canvas-zoom-sweep: task duration 331ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 73.9 MB
canvas-zoom-sweep: DOM nodes 47
canvas-zoom-sweep: event listeners 37
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 2ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 10
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 395ms
dom-widget-clipping: script duration 132ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 75.2 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 29ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 678ms
dom-widget-order-dense-n200-w200-i120: script duration 50ms
dom-widget-order-dense-n200-w200-i120: TBT 369ms
dom-widget-order-dense-n200-w200-i120: heap used 77.5 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -192
dom-widget-order-dense-n200-w200-i120: event listeners -106
dom-widget-order-sparse-n1000-w20-i120: avg frame time 23ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 379ms
dom-widget-order-sparse-n1000-w20-i120: script duration 112ms
dom-widget-order-sparse-n1000-w20-i120: TBT 156ms
dom-widget-order-sparse-n1000-w20-i120: heap used 72.1 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 25ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 1ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 4
extension-clean-combined-draw: style recalc count 4
extension-clean-combined-draw: task duration 6394ms
extension-clean-combined-draw: script duration 5217ms
extension-clean-combined-draw: TBT 69ms
extension-clean-combined-draw: heap used 84.4 MB
extension-clean-combined-draw: DOM nodes -258
extension-clean-combined-draw: event listeners -68
extension-rgthree-prototype-draw: avg frame time 25ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 1ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 3
extension-rgthree-prototype-draw: style recalc count 3
extension-rgthree-prototype-draw: task duration 6025ms
extension-rgthree-prototype-draw: script duration 4764ms
extension-rgthree-prototype-draw: TBT 29ms
extension-rgthree-prototype-draw: heap used 78.8 MB
extension-rgthree-prototype-draw: DOM nodes -258
extension-rgthree-prototype-draw: event listeners -68
large-combo-open: avg frame time 21ms
large-combo-open: p95 frame time 50ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 12ms
large-combo-open: layout count 12
large-combo-open: style recalc count 23
large-combo-open: task duration 126ms
large-combo-open: script duration 7ms
large-combo-open: TBT 0ms
large-combo-open: heap used 75.5 MB
large-combo-open: DOM nodes 917
large-combo-open: event listeners 196
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 9
large-graph-idle: style recalc count 10
large-graph-idle: task duration 458ms
large-graph-idle: script duration 31ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 75.1 MB
large-graph-idle: DOM nodes -258
large-graph-idle: event listeners -68
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 6ms
large-graph-pan: layout count 8
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1365ms
large-graph-pan: script duration 643ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 64.9 MB
large-graph-pan: DOM nodes -258
large-graph-pan: event listeners -66
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 8ms
large-graph-zoom: layout count 67
large-graph-zoom: style recalc count 73
large-graph-zoom: task duration 1310ms
large-graph-zoom: script duration 626ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.6 MB
large-graph-zoom: DOM nodes -234
large-graph-zoom: event listeners -68
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 5
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1565ms
legacy-node-drag: script duration 771ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 79.2 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 9
minimap-idle: style recalc count 9
minimap-idle: task duration 428ms
minimap-idle: script duration 27ms
minimap-idle: TBT 0ms
minimap-idle: heap used 75.7 MB
minimap-idle: DOM nodes -258
minimap-idle: event listeners -68
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 2ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 10
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 365ms
subgraph-dom-widget-clipping: script duration 120ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.7 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 2ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 10
subgraph-idle: style recalc count 11
subgraph-idle: task duration 433ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 55.6 MB
subgraph-idle: DOM nodes -90
subgraph-idle: event listeners -57
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 2ms
subgraph-mouse-sweep: style recalc duration 14ms
subgraph-mouse-sweep: layout count 10
subgraph-mouse-sweep: style recalc count 81
subgraph-mouse-sweep: task duration 759ms
subgraph-mouse-sweep: script duration 90ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 74.3 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 6
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 21ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 819ms
subgraph-transition-enter: script duration 23ms
subgraph-transition-enter: TBT 110ms
subgraph-transition-enter: heap used 98.3 MB
subgraph-transition-enter: DOM nodes 15953
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 18ms
viewport-pan-sweep: layout count 9
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 4529ms
viewport-pan-sweep: script duration 2099ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 80.6 MB
viewport-pan-sweep: DOM nodes -258
viewport-pan-sweep: event listeners -66
vue-large-graph-idle: avg frame time 33ms
vue-large-graph-idle: p95 frame time 67ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 18882ms
vue-large-graph-idle: script duration 253ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 252.1 MB
vue-large-graph-idle: DOM nodes -3330
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 36ms
vue-large-graph-pan: p95 frame time 75ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 13ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 148
vue-large-graph-pan: task duration 19429ms
vue-large-graph-pan: script duration 707ms
vue-large-graph-pan: TBT 23ms
vue-large-graph-pan: heap used 261.4 MB
vue-large-graph-pan: DOM nodes -3330
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 38ms
vue-node-resize-workload: p95 frame time 75ms
vue-node-resize-workload: layout duration 20ms
vue-node-resize-workload: style recalc duration 55ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6770ms
vue-node-resize-workload: script duration 95ms
vue-node-resize-workload: TBT 8ms
vue-node-resize-workload: heap used 257.1 MB
vue-node-resize-workload: DOM nodes -3330
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 28ms
vue-zoom-out-idle: p95 frame time 58ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8004ms
vue-zoom-out-idle: script duration 109ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 253.8 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 3ms
workflow-execution: style recalc duration 11ms
workflow-execution: layout count 11
workflow-execution: style recalc count 14
workflow-execution: task duration 99ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 65.9 MB
workflow-execution: DOM nodes 122
workflow-execution: event listeners 1
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 11ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 241ms
agent-composer-empty-conversation-typing: script duration 115ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 90.6 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 11ms
agent-composer-long-conversation-typing: style recalc duration 2ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 284ms
agent-composer-long-conversation-typing: script duration 106ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 105.2 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-16T02:14:47.274Z",
  "gitSha": "bcc5490de2192e16cbb8c37e4343d73fdff70ed2",
  "branch": "backport-21145-to-cloud-1.57",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2010.7399999999984,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.568,
      "layouts": 10,
      "layoutDurationMs": 2.395,
      "taskDurationMs": 280.158,
      "heapDeltaBytes": 22156324,
      "heapUsedBytes": 87830416,
      "domNodes": 0,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 8.834000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2012.4650000000202,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.431,
      "layouts": 10,
      "layoutDurationMs": 2.3280000000000003,
      "taskDurationMs": 383.21500000000003,
      "heapDeltaBytes": -875828,
      "heapUsedBytes": 73475756,
      "domNodes": 0,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 7.961000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198342,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1959.649000000013,
      "styleRecalcs": 83,
      "styleRecalcDurationMs": 13.814,
      "layouts": 10,
      "layoutDurationMs": 2.2790000000000004,
      "taskDurationMs": 875.5010000000001,
      "heapDeltaBytes": -7807316,
      "heapUsedBytes": 66716276,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 118.93100000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666101694915252,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1961.2059999999474,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 14.094000000000001,
      "layouts": 10,
      "layoutDurationMs": 2.3480000000000003,
      "taskDurationMs": 878.126,
      "heapDeltaBytes": -7325856,
      "heapUsedBytes": 68024228,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 119.81199999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665254237288135,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1735.968000000014,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 4.582,
      "layouts": 12,
      "layoutDurationMs": 2.6300000000000003,
      "taskDurationMs": 296.69800000000004,
      "heapDeltaBytes": 18747928,
      "heapUsedBytes": 84213992,
      "domNodes": 47,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 9.962,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384617,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1808.928999999921,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.921,
      "layouts": 12,
      "layoutDurationMs": 2.616,
      "taskDurationMs": 364.692,
      "heapDeltaBytes": -4537344,
      "heapUsedBytes": 70832812,
      "domNodes": 47,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 10.328999999999999,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666972477064217,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 566.3499999999999,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 2.8970000000000002,
      "layouts": 10,
      "layoutDurationMs": 2.5390000000000006,
      "taskDurationMs": 404.274,
      "heapDeltaBytes": 3496612,
      "heapUsedBytes": 78803604,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 133.98100000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667647058823523,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 560.1439999999229,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 2.5789999999999997,
      "layouts": 10,
      "layoutDurationMs": 2.382,
      "taskDurationMs": 384.799,
      "heapDeltaBytes": 3953960,
      "heapUsedBytes": 78851128,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 130.183,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352937,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1026.7450000000053,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 666.0549999999998,
      "heapDeltaBytes": -11321036,
      "heapUsedBytes": 81215568,
      "domNodes": -192,
      "jsHeapTotalBytes": 20193280,
      "scriptDurationMs": 50.041000000000004,
      "eventListeners": -106,
      "totalBlockingTimeMs": 372,
      "frameDurationMs": 28.70555555555556,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1017.4329999999827,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 689.136,
      "heapDeltaBytes": 836616,
      "heapUsedBytes": 81387068,
      "domNodes": -192,
      "jsHeapTotalBytes": 13901824,
      "scriptDurationMs": 49.89500000000001,
      "eventListeners": -106,
      "totalBlockingTimeMs": 366,
      "frameDurationMs": 29.048571428571424,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 783.773999999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 384.53800000000007,
      "heapDeltaBytes": -4066952,
      "heapUsedBytes": 75906864,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 117.16500000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 157,
      "frameDurationMs": 23.03823529411765,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 766.2720000000718,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 373.945,
      "heapDeltaBytes": -5938584,
      "heapUsedBytes": 75196444,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 107.16899999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 154,
      "frameDurationMs": 23.230303030303013,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6690.089999999998,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 0.9989999999999999,
      "layouts": 4,
      "layoutDurationMs": 1.039,
      "taskDurationMs": 5766.581999999999,
      "heapDeltaBytes": -751992,
      "heapUsedBytes": 99104172,
      "domNodes": -258,
      "jsHeapTotalBytes": 4583424,
      "scriptDurationMs": 4749.938,
      "eventListeners": -68,
      "totalBlockingTimeMs": 36,
      "frameDurationMs": 24.66088560885609,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7822.563000000002,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.843,
      "layouts": 3,
      "layoutDurationMs": 0.745,
      "taskDurationMs": 7021.829000000001,
      "heapDeltaBytes": -22345572,
      "heapUsedBytes": 77901376,
      "domNodes": -258,
      "jsHeapTotalBytes": 15331328,
      "scriptDurationMs": 5683.311,
      "eventListeners": -67,
      "totalBlockingTimeMs": 101,
      "frameDurationMs": 24.42625,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6372.270000000015,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.5000000000000004,
      "layouts": 2,
      "layoutDurationMs": 0.4330000000000002,
      "taskDurationMs": 5787.756,
      "heapDeltaBytes": -19140956,
      "heapUsedBytes": 74666732,
      "domNodes": -258,
      "jsHeapTotalBytes": 3010560,
      "scriptDurationMs": 4542.174,
      "eventListeners": -68,
      "totalBlockingTimeMs": 27,
      "frameDurationMs": 24.933984374999998,
      "p95FrameDurationMs": 33.40000000000009
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6942.678999999998,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.7690000000000006,
      "layouts": 3,
      "layoutDurationMs": 0.7139999999999997,
      "taskDurationMs": 6263.035000000001,
      "heapDeltaBytes": -5101376,
      "heapUsedBytes": 90503628,
      "domNodes": -258,
      "jsHeapTotalBytes": 4845568,
      "scriptDurationMs": 4986.0509999999995,
      "eventListeners": -68,
      "totalBlockingTimeMs": 31,
      "frameDurationMs": 24.498233215547703,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "large-combo-open",
      "durationMs": 189.46099999999433,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 12.187000000000001,
      "layouts": 11,
      "layoutDurationMs": 2.716,
      "taskDurationMs": 131.72199999999998,
      "heapDeltaBytes": -8056680,
      "heapUsedBytes": 79249704,
      "domNodes": 917,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 6.843,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.366666666666635,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-combo-open",
      "durationMs": 161.596999999972,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 12.302,
      "layouts": 12,
      "layoutDurationMs": 2.956,
      "taskDurationMs": 120.18900000000002,
      "heapDeltaBytes": -8173832,
      "heapUsedBytes": 79066900,
      "domNodes": 917,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 6.580000000000001,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.82499999999999,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2026.5580000000227,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.5369999999999995,
      "layouts": 9,
      "layoutDurationMs": 2.3649999999999998,
      "taskDurationMs": 549.724,
      "heapDeltaBytes": -22914460,
      "heapUsedBytes": 74129592,
      "domNodes": -258,
      "jsHeapTotalBytes": 2260992,
      "scriptDurationMs": 31.209999999999994,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2008.1950000000006,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 1.9300000000000004,
      "layouts": 8,
      "layoutDurationMs": 1.8150000000000002,
      "taskDurationMs": 366.431,
      "heapDeltaBytes": 4197924,
      "heapUsedBytes": 83387832,
      "domNodes": -258,
      "jsHeapTotalBytes": -659456,
      "scriptDurationMs": 30.104999999999993,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2677.2169999999846,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 6.6309999999999985,
      "layouts": 7,
      "layoutDurationMs": 1.738,
      "taskDurationMs": 1405.281,
      "heapDeltaBytes": -12245668,
      "heapUsedBytes": 67861932,
      "domNodes": -258,
      "jsHeapTotalBytes": 4583424,
      "scriptDurationMs": 666.339,
      "eventListeners": -65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66645962732919,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2285.55700000004,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 6.051,
      "layouts": 8,
      "layoutDurationMs": 1.7640000000000002,
      "taskDurationMs": 1324.726,
      "heapDeltaBytes": -12238324,
      "heapUsedBytes": 68176876,
      "domNodes": -258,
      "jsHeapTotalBytes": 4059136,
      "scriptDurationMs": 620.0029999999999,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.7875,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3240.2809999999818,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 8.584999999999999,
      "layouts": 67,
      "layoutDurationMs": 11.324,
      "taskDurationMs": 1360.455,
      "heapDeltaBytes": -6425348,
      "heapUsedBytes": 75142328,
      "domNodes": -234,
      "jsHeapTotalBytes": 3796992,
      "scriptDurationMs": 632.4530000000001,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.751546391752576,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3233.4090000000515,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 7.327,
      "layouts": 66,
      "layoutDurationMs": 10.026,
      "taskDurationMs": 1259.307,
      "heapDeltaBytes": -6788736,
      "heapUsedBytes": 75117868,
      "domNodes": -234,
      "jsHeapTotalBytes": 4321280,
      "scriptDurationMs": 619.491,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.752331606217616,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2593.954999999994,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 4.501,
      "layouts": 4,
      "layoutDurationMs": 0.8749999999999999,
      "taskDurationMs": 1601.344,
      "heapDeltaBytes": 1005068,
      "heapUsedBytes": 78847472,
      "domNodes": 0,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 774.629,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.883660130718955,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2563.3229999999685,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 4.642,
      "layouts": 6,
      "layoutDurationMs": 1.3539999999999996,
      "taskDurationMs": 1528.791,
      "heapDeltaBytes": 3628708,
      "heapUsedBytes": 87254680,
      "domNodes": 0,
      "jsHeapTotalBytes": 5992448,
      "scriptDurationMs": 768.303,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.77516339869281,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2034.5630000000483,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.823,
      "layouts": 7,
      "layoutDurationMs": 1.676,
      "taskDurationMs": 483.2639999999999,
      "heapDeltaBytes": -2425584,
      "heapUsedBytes": 79326096,
      "domNodes": -258,
      "jsHeapTotalBytes": 4059136,
      "scriptDurationMs": 25.967000000000002,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2006.0980000000654,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.326,
      "layouts": 10,
      "layoutDurationMs": 2.4200000000000004,
      "taskDurationMs": 372.74500000000006,
      "heapDeltaBytes": -2434004,
      "heapUsedBytes": 79354096,
      "domNodes": -258,
      "jsHeapTotalBytes": 3010560,
      "scriptDurationMs": 27.181000000000004,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760334,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 564.0240000000176,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 4.446,
      "layouts": 9,
      "layoutDurationMs": 2.1599999999999997,
      "taskDurationMs": 377.654,
      "heapDeltaBytes": 21645308,
      "heapUsedBytes": 89039404,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 120.961,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667647058823523,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 516.4429999999811,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 4.639000000000001,
      "layouts": 11,
      "layoutDurationMs": 2.78,
      "taskDurationMs": 351.811,
      "heapDeltaBytes": 21678592,
      "heapUsedBytes": 88629648,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 118.21299999999998,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66774193548388,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2015.5880000000366,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.701,
      "layouts": 10,
      "layoutDurationMs": 2.4529999999999994,
      "taskDurationMs": 437.082,
      "heapDeltaBytes": -19423304,
      "heapUsedBytes": 57515620,
      "domNodes": 0,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 7.837999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.3809999999194,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.5989999999999998,
      "layouts": 10,
      "layoutDurationMs": 2.2630000000000003,
      "taskDurationMs": 428.31,
      "heapDeltaBytes": -8074476,
      "heapUsedBytes": 59176892,
      "domNodes": -180,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 6.958999999999998,
      "eventListeners": -114,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1960.1579999999785,
      "styleRecalcs": 86,
      "styleRecalcDurationMs": 14.992,
      "layouts": 9,
      "layoutDurationMs": 2.111,
      "taskDurationMs": 866.5740000000001,
      "heapDeltaBytes": 10823592,
      "heapUsedBytes": 77757100,
      "domNodes": 0,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 91.411,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666949152542372,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1694.6669999999813,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 13.541999999999998,
      "layouts": 10,
      "layoutDurationMs": 2.3480000000000003,
      "taskDurationMs": 651.0849999999999,
      "heapDeltaBytes": 10849628,
      "heapUsedBytes": 78131136,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 87.62100000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1319.3229999999971,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 20.702,
      "layouts": 5,
      "layoutDurationMs": 11.735999999999999,
      "taskDurationMs": 819.4799999999998,
      "heapDeltaBytes": 7192624,
      "heapUsedBytes": 103043596,
      "domNodes": 15953,
      "jsHeapTotalBytes": 16388096,
      "scriptDurationMs": 23.467999999999996,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 110,
      "frameDurationMs": 18.77887323943662,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8359.173999999995,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 18.627,
      "layouts": 8,
      "layoutDurationMs": 1.683,
      "taskDurationMs": 4557.820000000001,
      "heapDeltaBytes": 3058400,
      "heapUsedBytes": 82475480,
      "domNodes": -258,
      "jsHeapTotalBytes": 4022272,
      "scriptDurationMs": 2112.949,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66593625498008,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8408.334999999966,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 18.228,
      "layouts": 9,
      "layoutDurationMs": 1.9849999999999999,
      "taskDurationMs": 4499.929000000001,
      "heapDeltaBytes": -10612968,
      "heapUsedBytes": 86500072,
      "domNodes": -258,
      "jsHeapTotalBytes": 5369856,
      "scriptDurationMs": 2084.5119999999997,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665873015873018,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 19233.84500000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18834.016000000003,
      "heapDeltaBytes": -35317484,
      "heapUsedBytes": 259786440,
      "domNodes": -3330,
      "jsHeapTotalBytes": 17027072,
      "scriptDurationMs": 255.74600000000004,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 33.74140350877193,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 19374.615999999947,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18930.260000000002,
      "heapDeltaBytes": -8408968,
      "heapUsedBytes": 268976752,
      "domNodes": -3330,
      "jsHeapTotalBytes": 14409728,
      "scriptDurationMs": 249.36599999999999,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 32.8792869269949,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23273.04399999997,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 15.737000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22820.140000000003,
      "heapDeltaBytes": -41728988,
      "heapUsedBytes": 257219988,
      "domNodes": -3330,
      "jsHeapTotalBytes": 12832768,
      "scriptDurationMs": 720.052,
      "eventListeners": -651,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 43.6,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16741.049999999974,
      "styleRecalcs": 115,
      "styleRecalcDurationMs": 9.362000000000009,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16038.301000000001,
      "heapDeltaBytes": -169580,
      "heapUsedBytes": 291064820,
      "domNodes": -3330,
      "jsHeapTotalBytes": 19320832,
      "scriptDurationMs": 694.614,
      "eventListeners": -651,
      "totalBlockingTimeMs": 43,
      "frameDurationMs": 28.978027681660905,
      "p95FrameDurationMs": 66.69999999999982
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6891.081999999983,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 55.303999999999995,
      "layouts": 20,
      "layoutDurationMs": 19.946000000000005,
      "taskDurationMs": 6794.609,
      "heapDeltaBytes": -32046940,
      "heapUsedBytes": 259179244,
      "domNodes": -3330,
      "jsHeapTotalBytes": 17293312,
      "scriptDurationMs": 92.908,
      "eventListeners": -653,
      "totalBlockingTimeMs": 9,
      "frameDurationMs": 37.81868131868132,
      "p95FrameDurationMs": 66.79999999999927
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6838.200000000029,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 55.062,
      "layouts": 20,
      "layoutDurationMs": 19.575999999999997,
      "taskDurationMs": 6744.617,
      "heapDeltaBytes": -16274864,
      "heapUsedBytes": 280039804,
      "domNodes": -3330,
      "jsHeapTotalBytes": 31186944,
      "scriptDurationMs": 97.43499999999999,
      "eventListeners": -653,
      "totalBlockingTimeMs": 7,
      "frameDurationMs": 38.17374301675978,
      "p95FrameDurationMs": 83.19999999999891
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9409.487000000012,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9199.521,
      "heapDeltaBytes": 15717616,
      "heapUsedBytes": 275470544,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 120.22899999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 31.86338983050847,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7189.131999999972,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6809.226000000001,
      "heapDeltaBytes": -18625940,
      "heapUsedBytes": 256856292,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 96.87999999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 24.970034843205568,
      "p95FrameDurationMs": 49.900000000001455
    },
    {
      "name": "workflow-execution",
      "durationMs": 447.67000000001644,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 13.690999999999999,
      "layouts": 14,
      "layoutDurationMs": 4.288,
      "taskDurationMs": 117.452,
      "heapDeltaBytes": -12912660,
      "heapUsedBytes": 70304108,
      "domNodes": 128,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 13.652,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662962962962965,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 102.31300000009469,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.701999999999999,
      "layouts": 8,
      "layoutDurationMs": 2.4539999999999997,
      "taskDurationMs": 79.641,
      "heapDeltaBytes": -15502528,
      "heapUsedBytes": 67972860,
      "domNodes": 116,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 6.745000000000001,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.671428571428546,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 269.86199999998917,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.184,
      "layouts": 76,
      "layoutDurationMs": 11.075,
      "taskDurationMs": 228.143,
      "heapDeltaBytes": 9443316,
      "heapUsedBytes": 86974364,
      "domNodes": 4,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 106.835,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66874999999999,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 294.94499999998425,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.1139999999999999,
      "layouts": 76,
      "layoutDurationMs": 11.704,
      "taskDurationMs": 253.02700000000002,
      "heapDeltaBytes": 9923292,
      "heapUsedBytes": 103119376,
      "domNodes": 4,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 123.13799999999999,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663157894736862,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 336.09100000001035,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.8090000000000002,
      "layouts": 76,
      "layoutDurationMs": 11.091,
      "taskDurationMs": 303.96199999999993,
      "heapDeltaBytes": -6439648,
      "heapUsedBytes": 110602232,
      "domNodes": 4,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 113.968,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 296.73700000000736,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.656,
      "layouts": 76,
      "layoutDurationMs": 10.581,
      "taskDurationMs": 263.236,
      "heapDeltaBytes": -7050376,
      "heapUsedBytes": 109953108,
      "domNodes": 4,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 97.259,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66842105263162,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 56093 86855 64.6% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.6% 1172
src/LGraphNode.ts 70.6% 387
src/platform/workspace/stores/billingOperationStore.ts 7.9% 375
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 78.9% 274
src/platform/workspace/stores/teamWorkspaceStore.ts 47.5% 245
src/core/webSessionIdentity.ts 3.3% 231
src/core/graph/widgets/dynamicGroupWidget.ts 0.4% 224
src/scripts/pnginfo.ts 20.7% 222

🎭 Playwright: ✅ 2283 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2261 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/16/2026, 02:04:46 AM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since a83ec6a26334565dc5e385fa1adc086120c7cf98

Full docs: ADR-DEVEX-LINT-0015

@github-actions
github-actions Bot requested a review from thedatalife October 16, 2026 02:03
@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 16, 2026
@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.57   #21152   +/-   ##
=============================================
  Coverage              ?   87.19%           
=============================================
  Files                 ?     2626           
  Lines                 ?   147611           
  Branches              ?    38414           
=============================================
  Hits                  ?   128704           
  Misses                ?    18517           
  Partials              ?      390           
Flag Coverage Δ
e2e 64.58% <0.00%> (?)
unit 85.08% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/auth/session/webSessionFetch.ts 92.45% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport of #21145. Checks are green.

@comfy-pr-bot
comfy-pr-bot merged commit 9656f9f into cloud/1.57 Oct 16, 2026
143 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-21145-to-cloud-1.57 branch October 16, 2026 12:54

This branch was previously deployed

1 inactive deployment
website-approval — c1bbd35d Deployed Oct 16, 2026 by comfy-pr-bot via fast-lane #5260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants