Repository navigation
[backport core/1.57] ING-212 fix(auth): keep asset redirects off credentialed CORS - #21151
Conversation
## Summary Cloud asset downloads now keep the session cookie on the same-origin ingest request without requiring credentialed CORS after ingest redirects to a signed storage URL. Workspace/CSRF headers and retries are preserved; genuinely cross-origin ingest requests retain the authorizer's `include` policy. Fixes https://linear.app/comfyorg/issue/ING-212/bug-cloud-completed-video-download-fails-with-cors-redirect-error **Root cause / why now:** the existing download path already used `api.fetchApi` to preserve workspace authentication (PR 18421). PR 18716 introduced `credentials: 'include'` for session authorization, and PR 18875 routed Cloud ingest requests through it. With `unified_web_session` enabled, `/api/assets/{id}/content` still returns a 302 to GCS, but the followed fetch remains credentialed. GCS's XML API does not support `Access-Control-Allow-Credentials`, so the browser rejects the bytes. This was a latent flag-on incompatibility, not a newly changed download button: [Oct 15 QA records the 100% ramp at 10:04 EDT](https://comfy-organization.slack.com/archives/C0932CGKT5K/p1792075311777139), and a [later update explicitly confirms 100% in production](https://comfy-organization.slack.com/archives/C0C6V3NUXPU/p1792093817831899). The previous tests checked authenticated requests against fetch doubles without exercising a storage redirect in a browser. **How:** select `same-origin` at the Cloud session transport boundary when the request URL resolves to the page's origin. Keep the shared account-core authorizer unchanged for clients that need cookies across origins. Passing a download-only option to `fetchApi` would not fix this because the transport overwrites it with the authorizer's credentials. ## Verification - RED: with the original source, the new actual-app browser test fails to download and Chromium logs the missing `Access-Control-Allow-Credentials` error with credentials mode `include`. Restoring the fix makes it pass. - Browser: 2 passed, personal and team workspaces. Actual Media Assets context-menu Download, authenticated ingest 302 double, separate real HTTP storage server without ACAC, saved filename and byte comparison. A cookie seeded for the storage host is not sent; the first hop retains the session cookie and selected workspace. - Unit: 364 passed in the 5 affected session/auth, asset-action and download-utility suites. The URL table covers relative, absolute same-origin and remote ingest requests. Existing flag-off, CSRF retry and workspace-denial coverage passes. - App + browser typechecks, touched-file oxlint/ESLint/oxfmt and knip passed. Commit and push hooks run without bypasses. - Browser proof uses the repository-pinned Chromium 153. System Chrome 155 aborts Playwright-intercepted redirects before reaching the storage server; it is not used as a passing regression result. ### AS IS / TO BE AS IS: [production report with the PNG screenshot](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1792109025101229). TO BE: actual-app Download regressions pass for personal/team workspaces with this PR. Live production-storage check also passed from `https://cloud.comfy.org`: a DevTools request using the PR's `same-origin` credentials policy and workspace/client headers followed the real authenticated asset-content redirect to `storage.googleapis.com`, returned HTTP 200 (`image/png`, 2,620,563 bytes), and saved `Nano_Banana_2_00002_.png` (1024 x 1024; SHA-256 `54e4dc472f12a02c702ef71f0853490132e116b84475a9480ab0b03b3e3a9971`). This validates the production request policy, not a deployed PR bundle or production UI rollout. The local PR frontend cannot complete that live GCS check because the production bucket does not allow the localhost origin; an OPTIONS probe returned ACAO for Cloud but none for localhost. No signed URL or credentials are included in the evidence. Follow-up validation: 243 affected session/remote-widget unit tests and both personal/team browser regressions passed. CI exposed an additional remote-widget `include` expectation, now aligned with the same-origin policy. The fixture also handles a missing cookie header via `Headers.get()` before returning its intended 401 (CodeRabbit feedback). ### Plan position | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Session authorization policy | FE-2895 | [PR 18716](#18716) | Merged | | Cloud ingest on web session | FE-2904 | [PR 18875](#18875) | Merged | | **Storage redirect compatibility + browser regression** | **ING-212** | **This PR** | **Ready for review** | ```mermaid flowchart LR auth["FE-2895 / PR 18716"] --> ingest["FE-2904 / PR 18875"] ingest --> fix["ING-212 / this PR"] classDef current fill:#ffe08a,stroke:#b8860b,stroke-width:3px,color:#000 class fix current ``` --------- Co-authored-by: GitHub Action <action@github.com>
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-16T02:15:23.391Z",
"gitSha": "77e4ae9445a3c6d34faf62576f7384ec7fa7f0a1",
"branch": "backport-21145-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.062000000019,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.15,
"layouts": 10,
"layoutDurationMs": 2.403,
"taskDurationMs": 451.85699999999997,
"heapDeltaBytes": -850408,
"heapUsedBytes": 74055156,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 8.754999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2010.016999999948,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0690000000000004,
"layouts": 9,
"layoutDurationMs": 2.2110000000000003,
"taskDurationMs": 337.483,
"heapDeltaBytes": 22171992,
"heapUsedBytes": 88038220,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.783999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1708.2289999999603,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.158000000000001,
"layouts": 9,
"layoutDurationMs": 1.91,
"taskDurationMs": 720.998,
"heapDeltaBytes": -8197148,
"heapUsedBytes": 66656580,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 123.788,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.0600000000832,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.076999999999998,
"layouts": 9,
"layoutDurationMs": 2.028,
"taskDurationMs": 612.6049999999999,
"heapDeltaBytes": 15640068,
"heapUsedBytes": 82218540,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 122.508,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.007999999993,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.787999999999999,
"layouts": 11,
"layoutDurationMs": 2.304,
"taskDurationMs": 354.483,
"heapDeltaBytes": -4566788,
"heapUsedBytes": 70791860,
"domNodes": 47,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.758000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1809.4200000000455,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.792999999999999,
"layouts": 11,
"layoutDurationMs": 2.8979999999999997,
"taskDurationMs": 427.303,
"heapDeltaBytes": -4520296,
"heapUsedBytes": 70858192,
"domNodes": 47,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 12.425,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 571.7309999999998,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.3359999999999994,
"layouts": 10,
"layoutDurationMs": 2.391,
"taskDurationMs": 386.803,
"heapDeltaBytes": 25648644,
"heapUsedBytes": 91404072,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 149.475,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 645.4340000000229,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.1360000000000006,
"layouts": 9,
"layoutDurationMs": 1.8820000000000001,
"taskDurationMs": 455.65500000000003,
"heapDeltaBytes": -631496,
"heapUsedBytes": 65640852,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 147.71399999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1117.7449999999567,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 787.517,
"heapDeltaBytes": -3383856,
"heapUsedBytes": 80988332,
"domNodes": -192,
"jsHeapTotalBytes": 14163968,
"scriptDurationMs": 47.92800000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 438,
"frameDurationMs": 30.178378378378387,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1137.283000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 772.872,
"heapDeltaBytes": -12851100,
"heapUsedBytes": 81347172,
"domNodes": -192,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 57.478,
"eventListeners": -106,
"totalBlockingTimeMs": 456,
"frameDurationMs": 31.480555555555547,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 762.5859999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.98499999999956,
"heapDeltaBytes": -3322660,
"heapUsedBytes": 76388264,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 117.11199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 144,
"frameDurationMs": 23.230303030303013,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 761.4060000000791,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.79999999999984,
"heapDeltaBytes": -4778784,
"heapUsedBytes": 74693120,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 120.35500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 142,
"frameDurationMs": 22.547058823529397,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8671.155999999995,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.45999999999999946,
"layouts": 2,
"layoutDurationMs": 0.4400000000000003,
"taskDurationMs": 7673.963000000001,
"heapDeltaBytes": -15255504,
"heapUsedBytes": 84101816,
"domNodes": -258,
"jsHeapTotalBytes": 7729152,
"scriptDurationMs": 5870.894000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 144,
"frameDurationMs": 25.792857142857148,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8508.254999999963,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3810000000000003,
"layouts": 2,
"layoutDurationMs": 0.42099999999999993,
"taskDurationMs": 7574.491,
"heapDeltaBytes": 8938004,
"heapUsedBytes": 85902756,
"domNodes": -258,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 5843.794,
"eventListeners": -68,
"totalBlockingTimeMs": 103,
"frameDurationMs": 25.14704142011834,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8887.144000000035,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.45699999999999996,
"layouts": 2,
"layoutDurationMs": 0.3939999999999998,
"taskDurationMs": 7807.715,
"heapDeltaBytes": -24345428,
"heapUsedBytes": 75680768,
"domNodes": -258,
"jsHeapTotalBytes": 11399168,
"scriptDurationMs": 6164.543,
"eventListeners": -68,
"totalBlockingTimeMs": 187,
"frameDurationMs": 26.75602409638555,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8716.927000000054,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2020000000000008,
"layouts": 1,
"layoutDurationMs": 0.25100000000000033,
"taskDurationMs": 7718.686999999999,
"heapDeltaBytes": -9309636,
"heapUsedBytes": 85013452,
"domNodes": -258,
"jsHeapTotalBytes": 8777728,
"scriptDurationMs": 6120.951000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 145,
"frameDurationMs": 26.124924924924926,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 191.29700000002003,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.809999999999999,
"layouts": 11,
"layoutDurationMs": 3.1830000000000003,
"taskDurationMs": 139.52700000000002,
"heapDeltaBytes": -8208428,
"heapUsedBytes": 79065488,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8.442000000000002,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.92500000000001,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-combo-open",
"durationMs": 209.59300000004077,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.562000000000001,
"layouts": 12,
"layoutDurationMs": 3.1239999999999997,
"taskDurationMs": 143.20000000000002,
"heapDeltaBytes": -7507612,
"heapUsedBytes": 80624456,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.475999999999999,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.233333333333373,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2008.48000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.8059999999999994,
"layouts": 8,
"layoutDurationMs": 1.81,
"taskDurationMs": 563.337,
"heapDeltaBytes": -25496372,
"heapUsedBytes": 72348668,
"domNodes": -258,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 30.12200000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2041.8389999999818,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.157000000000001,
"layouts": 10,
"layoutDurationMs": 2.428,
"taskDurationMs": 568.9100000000001,
"heapDeltaBytes": -19354228,
"heapUsedBytes": 77320784,
"domNodes": -258,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 30.613,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2188.275000000033,
"styleRecalcs": 69,
"styleRecalcDurationMs": 5.3580000000000005,
"layouts": 8,
"layoutDurationMs": 1.694,
"taskDurationMs": 1433.761,
"heapDeltaBytes": -29867436,
"heapUsedBytes": 68134680,
"domNodes": -258,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 662.985,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665648854961834,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2235.759999999914,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.138,
"layouts": 6,
"layoutDurationMs": 1.476,
"taskDurationMs": 1527.126,
"heapDeltaBytes": -9014552,
"heapUsedBytes": 71462084,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 690.7299999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79172932330827,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3387.1350000000007,
"styleRecalcs": 70,
"styleRecalcDurationMs": 6.844,
"layouts": 64,
"layoutDurationMs": 10.043,
"taskDurationMs": 1551.785,
"heapDeltaBytes": -15417392,
"heapUsedBytes": 84021796,
"domNodes": -234,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 649.4369999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74851485148515,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3477.0429999999806,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.273,
"layouts": 65,
"layoutDurationMs": 11.692999999999998,
"taskDurationMs": 1616.4809999999998,
"heapDeltaBytes": -9115264,
"heapUsedBytes": 90276568,
"domNodes": -234,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 684.813,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665865384615383,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2269.2690000000084,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.177,
"layouts": 6,
"layoutDurationMs": 1.4220000000000002,
"taskDurationMs": 1465.5519999999997,
"heapDeltaBytes": 3330184,
"heapUsedBytes": 86658276,
"domNodes": 0,
"jsHeapTotalBytes": 6516736,
"scriptDurationMs": 751.52,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.916541353383458,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2346.490000000017,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.863,
"layouts": 4,
"layoutDurationMs": 1.108,
"taskDurationMs": 1515.654,
"heapDeltaBytes": -881172,
"heapUsedBytes": 82444616,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 792.543,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.907246376811592,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2047.6189999999974,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8530000000000004,
"layouts": 7,
"layoutDurationMs": 1.7349999999999999,
"taskDurationMs": 573.6320000000002,
"heapDeltaBytes": -1961252,
"heapUsedBytes": 79469460,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 36.17100000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.6960000000681,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8949999999999991,
"layouts": 6,
"layoutDurationMs": 1.6039999999999999,
"taskDurationMs": 593.837,
"heapDeltaBytes": -22521532,
"heapUsedBytes": 76572392,
"domNodes": -258,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 37.01,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 643.2709999999702,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.1290000000000004,
"layouts": 10,
"layoutDurationMs": 2.399,
"taskDurationMs": 420.71000000000004,
"heapDeltaBytes": 21549172,
"heapUsedBytes": 88893996,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 127.17500000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102567,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.4020000000019,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.679000000000001,
"layouts": 9,
"layoutDurationMs": 2.437,
"taskDurationMs": 398.985,
"heapDeltaBytes": -2271528,
"heapUsedBytes": 74256360,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 133.94599999999997,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.8839999999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.157,
"layouts": 10,
"layoutDurationMs": 2.255,
"taskDurationMs": 500.89799999999997,
"heapDeltaBytes": -7904592,
"heapUsedBytes": 68003376,
"domNodes": -180,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 8.414,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.278000000042,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.5390000000000006,
"layouts": 10,
"layoutDurationMs": 2.638000000000001,
"taskDurationMs": 456.7830000000001,
"heapDeltaBytes": -202488,
"heapUsedBytes": 76254188,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 8.993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1958.9599999999905,
"styleRecalcs": 86,
"styleRecalcDurationMs": 14.311,
"layouts": 9,
"layoutDurationMs": 2.006,
"taskDurationMs": 911.8839999999999,
"heapDeltaBytes": 11277364,
"heapUsedBytes": 78547156,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 89.208,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1973.0600000000322,
"styleRecalcs": 88,
"styleRecalcDurationMs": 16.216,
"layouts": 9,
"layoutDurationMs": 2.4560000000000004,
"taskDurationMs": 938.6699999999998,
"heapDeltaBytes": 11684616,
"heapUsedBytes": 79005308,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 93.94800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 933.0929999999853,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.850999999999996,
"layouts": 5,
"layoutDurationMs": 12.018999999999998,
"taskDurationMs": 718.6189999999999,
"heapDeltaBytes": 3576452,
"heapUsedBytes": 95542096,
"domNodes": 15953,
"jsHeapTotalBytes": 18227200,
"scriptDurationMs": 23.973999999999997,
"eventListeners": 3244,
"totalBlockingTimeMs": 148,
"frameDurationMs": 21.21136363636364,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8232.399000000043,
"styleRecalcs": 251,
"styleRecalcDurationMs": 18.819000000000003,
"layouts": 8,
"layoutDurationMs": 1.9780000000000002,
"taskDurationMs": 4564.877,
"heapDeltaBytes": 5374732,
"heapUsedBytes": 84573288,
"domNodes": -258,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 2262.02,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599190283401,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8253.167000000076,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.648,
"layouts": 7,
"layoutDurationMs": 2.033,
"taskDurationMs": 4666.437,
"heapDeltaBytes": 13091348,
"heapUsedBytes": 92717620,
"domNodes": -258,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 2347.594,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73367139959432,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12989.886000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12480.674,
"heapDeltaBytes": -163768,
"heapUsedBytes": 281212244,
"domNodes": -3330,
"jsHeapTotalBytes": 20701184,
"scriptDurationMs": 196.583,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.530348258706468,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 18800.427000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17972.621,
"heapDeltaBytes": -25825600,
"heapUsedBytes": 255817796,
"domNodes": -3330,
"jsHeapTotalBytes": 8900608,
"scriptDurationMs": 286.613,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.524740484429074,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 22135.748999999974,
"styleRecalcs": 173,
"styleRecalcDurationMs": 16.835000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21728.094,
"heapDeltaBytes": -20660352,
"heapUsedBytes": 256314548,
"domNodes": -3330,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 822.631,
"eventListeners": -651,
"totalBlockingTimeMs": 2,
"frameDurationMs": 41.13828996282528,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 16556.69899999998,
"styleRecalcs": 91,
"styleRecalcDurationMs": 10.20199999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15979.002,
"heapDeltaBytes": -2835180,
"heapUsedBytes": 288023200,
"domNodes": -3330,
"jsHeapTotalBytes": 12500992,
"scriptDurationMs": 791.158,
"eventListeners": -651,
"totalBlockingTimeMs": 15,
"frameDurationMs": 29.194894366197186,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 6734.002999999916,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.833999999999996,
"layouts": 20,
"layoutDurationMs": 22.347000000000005,
"taskDurationMs": 6628.822999999999,
"heapDeltaBytes": -25046284,
"heapUsedBytes": 256182668,
"domNodes": -3334,
"jsHeapTotalBytes": 19652608,
"scriptDurationMs": 110.11399999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.84082840236687,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6633.495000000039,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.14600000000001,
"layouts": 20,
"layoutDurationMs": 22.84699999999999,
"taskDurationMs": 6545.401,
"heapDeltaBytes": -2861216,
"heapUsedBytes": 273458168,
"domNodes": -3330,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 132.553,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.024712643678164,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9302.626000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8861.258,
"heapDeltaBytes": 19146120,
"heapUsedBytes": 268785316,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 128.32199999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.311784511784506,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9330.57599999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9121.196999999998,
"heapDeltaBytes": -14321176,
"heapUsedBytes": 258985972,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 134.871,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.687755102040818,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 469.4769999999835,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.24,
"layouts": 12,
"layoutDurationMs": 3.078,
"taskDurationMs": 110.53099999999999,
"heapDeltaBytes": 6795000,
"heapUsedBytes": 79947268,
"domNodes": 98,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.561,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 479.55100000001494,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.689,
"layouts": 10,
"layoutDurationMs": 3.823,
"taskDurationMs": 134.209,
"heapDeltaBytes": -13423648,
"heapUsedBytes": 70391220,
"domNodes": 121,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 10.247000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.257142857142867,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 467.0419999999922,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.46,
"layouts": 76,
"layoutDurationMs": 16.005,
"taskDurationMs": 416.769,
"heapDeltaBytes": -8730580,
"heapUsedBytes": 86954600,
"domNodes": 4,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 192.521,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 400.08700000009867,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3519999999999999,
"layouts": 76,
"layoutDurationMs": 15.06,
"taskDurationMs": 356.07899999999995,
"heapDeltaBytes": -9278912,
"heapUsedBytes": 86597524,
"domNodes": 4,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 155.63299999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 593.7610000000859,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.5010000000000003,
"layouts": 76,
"layoutDurationMs": 16.433,
"taskDurationMs": 553.785,
"heapDeltaBytes": 11597780,
"heapUsedBytes": 161773120,
"domNodes": 4,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 217.607,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.142857142857142,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 461.32599999998547,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.052,
"layouts": 76,
"layoutDurationMs": 14.63,
"taskDurationMs": 414.031,
"heapDeltaBytes": -601440,
"heapUsedBytes": 115525256,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.525,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2278 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 99626a099c1b5e0abce9a02a19355dae76bdc69e
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #21151 +/- ##
=============================================
- Coverage 87.17% 87.16% -0.01%
=============================================
Files 2614 2614
Lines 147005 147008 +3
Branches 40309 40312 +3
=============================================
+ Hits 128145 128146 +1
- Misses 18472 18474 +2
Partials 388 388
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Backport of #21145. Checks are green.
Backport of #21145 to
core/1.57Automatically created by backport workflow.