Repository navigation
[backport core/1.57] fix: draw a single card frame in the current user popover (FE-3436) - #21142
Conversation
…20983) *PR Created by the Glary-Bot Agent* --- - Fixes [FE-3436](https://linear.app/comfyorg/issue/FE-3436): when you open the avatar/account popover on Cloud, a second panel shows along its right and bottom edges. ## Root cause Only one popover opens, but it draws two frames: - **The Reka `PopoverContent` frame** (via `ImperativePopover`). `CurrentUserButton` sized it `w-80`, and it draws its own border, background, rounding and shadow. - **The card inside it** (`CurrentUserPopoverWorkspace` / `CurrentUserPopoverLegacy`). It drew a second full border, background, rounding and shadow, plus `-m-3`. `-m-3` was added to cancel PrimeVue Popover's built-in 0.75rem padding. #16272 moved the popover to Reka with `p-0` but left `-m-3` in place. The card was pulled 12px up and to the left, and with `overflow-visible` the frame shows past it on the right and bottom. ## Changes The popover now draws one frame: the Reka frame owns the frame styling, and the card is plain content. - **`CurrentUserButton.vue`:** the frame's `content-class` adds the frame styling: `border-border-default` and the card's shadow, on top of the base rounding and background. It also takes the width the cards used to set: `w-fit min-w-80 max-w-96` for the workspace variant and `w-80` for the legacy one. - **`CurrentUserPopoverWorkspace.vue` and `CurrentUserPopoverLegacy.vue`:** the card is now `current-user-popover p-2`. It no longer sets a border, background, rounding, shadow, width or `-m-3`. - **`currentUserPopoverCredits.spec.ts`:** a new `@cloud` test checks that the card has no border or shadow of its own, and that it sits inside the frame. The check polls with `expect.poll()`. ## Screenshots Taken from a local `pnpm build:cloud` served by ComfyUI, with the e2e cloud mocks in place. - **AS IS (`main`):** the card is at x=933 y=28 and is 320×513. The frame is at x=944 y=39 and is 320×491, so it shows past the card on the right and bottom. - **TO BE:** there is one frame, at x=944 y=39 and 320×513. The card sits 1px inside it, within the frame's border. The overall width is unchanged at 320px, and the content rows keep their 302px width. The whole popover now sits 11px further right and down than on `main`, because it is no longer pulled by `-m-3`. The workspace switcher is positioned off the card, so it moves the same distance. Its size is unchanged at 320×319. That move is why `workspace-switcher-scrolled-cloud-linux.png` needs a new baseline. ## Verification - **New test:** fails on `main` and passes on this branch, run locally against the cloud build. - **Screenshot tests:** the `Manage plan` and workspace-selector screenshot tests pass against their existing baselines. - **Unit tests:** the topbar and workspace popover suites pass (154 tests). - **Hooks:** lint, format and typecheck pass in the pre-commit hooks. - **Needs a maintainer:** `workspaceSwitcher.spec.ts` › "scrolls the list…" needs `/update-playwright`. The layout is identical; only the position moved. I can't generate the baseline in the CI container from the sandbox. --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com>
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-16T15:52:21.723Z",
"gitSha": "d83cb4b919e481f051298f9b81dbadfbb4c6e79c",
"branch": "backport-20983-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.1919999999845,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.184,
"layouts": 10,
"layoutDurationMs": 2.7749999999999995,
"taskDurationMs": 409.585,
"heapDeltaBytes": 22162584,
"heapUsedBytes": 87924404,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 12.018,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2009.5099999999775,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.9160000000000001,
"layouts": 9,
"layoutDurationMs": 1.828,
"taskDurationMs": 292.077,
"heapDeltaBytes": 22143712,
"heapUsedBytes": 88478536,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7.964,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1679.1049999999927,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.272,
"layouts": 10,
"layoutDurationMs": 2.664,
"taskDurationMs": 576.742,
"heapDeltaBytes": 15599144,
"heapUsedBytes": 81392240,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 121.80300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1679.715999999985,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.729000000000001,
"layouts": 9,
"layoutDurationMs": 2.0029999999999997,
"taskDurationMs": 542.778,
"heapDeltaBytes": 15514996,
"heapUsedBytes": 82242540,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 103.123,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.18500000002,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.888999999999999,
"layouts": 12,
"layoutDurationMs": 3.188,
"taskDurationMs": 300.633,
"heapDeltaBytes": -4522784,
"heapUsedBytes": 69908168,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 13.918000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.3169999999418,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.107,
"layouts": 12,
"layoutDurationMs": 2.3240000000000003,
"taskDurationMs": 218.244,
"heapDeltaBytes": 18744960,
"heapUsedBytes": 84506936,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7.41,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 565.6460000000152,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.9640000000000004,
"layouts": 9,
"layoutDurationMs": 2.4279999999999995,
"taskDurationMs": 396.181,
"heapDeltaBytes": 25681796,
"heapUsedBytes": 91305052,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 120.64499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 432.45600000000195,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.092,
"layouts": 10,
"layoutDurationMs": 2.6490000000000005,
"taskDurationMs": 291.703,
"heapDeltaBytes": -1006784,
"heapUsedBytes": 65165404,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 107.99900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230772,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 954.3280000000323,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.3479999999998,
"heapDeltaBytes": -13239912,
"heapUsedBytes": 80758344,
"domNodes": -192,
"jsHeapTotalBytes": 19668992,
"scriptDurationMs": 47.00299999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 295,
"frameDurationMs": 27.142857142857142,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 941.3289999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.48,
"heapDeltaBytes": -11403280,
"heapUsedBytes": 80868416,
"domNodes": -192,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 42.721,
"eventListeners": -106,
"totalBlockingTimeMs": 312,
"frameDurationMs": 27.140000000000004,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 716.4890000000241,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 306.24499999999966,
"heapDeltaBytes": -4726528,
"heapUsedBytes": 74799696,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 96.77700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 21.076470588235278,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 702.7949999999237,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 285.51800000000014,
"heapDeltaBytes": -4783068,
"heapUsedBytes": 75962080,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 93.56600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 93,
"frameDurationMs": 21.21212121212121,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6201.383000000022,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.1719999999999995,
"layouts": 4,
"layoutDurationMs": 1.0119999999999998,
"taskDurationMs": 5002.153,
"heapDeltaBytes": -26084828,
"heapUsedBytes": 72480640,
"domNodes": -258,
"jsHeapTotalBytes": 7729152,
"scriptDurationMs": 3967.691,
"eventListeners": -68,
"totalBlockingTimeMs": 16,
"frameDurationMs": 19.43510971786834,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6471.873000000016,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.667,
"layouts": 2,
"layoutDurationMs": 0.6289999999999998,
"taskDurationMs": 5523.715999999999,
"heapDeltaBytes": -13866756,
"heapUsedBytes": 85207092,
"domNodes": -258,
"jsHeapTotalBytes": 13234176,
"scriptDurationMs": 4199.625,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.994805194805192,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6813.878999999986,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.836,
"layouts": 3,
"layoutDurationMs": 0.7530000000000002,
"taskDurationMs": 5617.629,
"heapDeltaBytes": -1792348,
"heapUsedBytes": 96707016,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 4266.645,
"eventListeners": -67,
"totalBlockingTimeMs": 39,
"frameDurationMs": 20.408383233532934,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6340.688999999998,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9050000000000005,
"layouts": 3,
"layoutDurationMs": 0.6920000000000004,
"taskDurationMs": 5276.014999999999,
"heapDeltaBytes": -20826768,
"heapUsedBytes": 78525848,
"domNodes": -258,
"jsHeapTotalBytes": 9564160,
"scriptDurationMs": 4041.7740000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 26,
"frameDurationMs": 20.9009900990099,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 160.93399999999747,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.343999999999998,
"layouts": 11,
"layoutDurationMs": 2.998,
"taskDurationMs": 117.423,
"heapDeltaBytes": -7999172,
"heapUsedBytes": 79151396,
"domNodes": 917,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 6.017,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.82499999999999,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 164.75200000002133,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.845,
"layouts": 11,
"layoutDurationMs": 3.057,
"taskDurationMs": 114.49699999999999,
"heapDeltaBytes": -8293868,
"heapUsedBytes": 78923192,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 6.566000000000001,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.825000000000045,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2009.523999999999,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9900000000000007,
"layouts": 9,
"layoutDurationMs": 2.639,
"taskDurationMs": 453.29,
"heapDeltaBytes": -18855636,
"heapUsedBytes": 77606704,
"domNodes": -258,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 30.276999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2009.7680000000082,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.416,
"layouts": 9,
"layoutDurationMs": 2.152,
"taskDurationMs": 407.88100000000003,
"heapDeltaBytes": -25445984,
"heapUsedBytes": 73406732,
"domNodes": -258,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 26.859,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2629.9580000000446,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.5,
"layouts": 8,
"layoutDurationMs": 2.028,
"taskDurationMs": 1246.673,
"heapDeltaBytes": -889740,
"heapUsedBytes": 79781924,
"domNodes": -258,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 614.838,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66582278481013,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2566.5010000000166,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.048,
"layouts": 9,
"layoutDurationMs": 2.396,
"taskDurationMs": 1217.9569999999999,
"heapDeltaBytes": -29321656,
"heapUsedBytes": 68117600,
"domNodes": -258,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 572.387,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66558441558442,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3238.695000000007,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.985999999999999,
"layouts": 66,
"layoutDurationMs": 12.905,
"taskDurationMs": 1270.259,
"heapDeltaBytes": -1665408,
"heapUsedBytes": 79414204,
"domNodes": -234,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 574.856,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666494845360827,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3619.154999999978,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.407,
"layouts": 67,
"layoutDurationMs": 13.118,
"taskDurationMs": 1321.697,
"heapDeltaBytes": -10115632,
"heapUsedBytes": 71619120,
"domNodes": -234,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 548.995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662037037037,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2786.424000000011,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.609000000000001,
"layouts": 4,
"layoutDurationMs": 1.0910000000000004,
"taskDurationMs": 1408.8560000000002,
"heapDeltaBytes": 14678156,
"heapUsedBytes": 97902324,
"domNodes": 0,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 693.5160000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66586826347305,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2591.733999999974,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.085,
"layouts": 7,
"layoutDurationMs": 1.706,
"taskDurationMs": 1387.797,
"heapDeltaBytes": 2992156,
"heapUsedBytes": 83642312,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 696.6629999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66602564102564,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2014.1169999999988,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3569999999999998,
"layouts": 8,
"layoutDurationMs": 2.07,
"taskDurationMs": 425.979,
"heapDeltaBytes": -21559564,
"heapUsedBytes": 76741496,
"domNodes": -258,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 28.565999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2004.899000000023,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.9579999999999997,
"layouts": 10,
"layoutDurationMs": 1.8830000000000002,
"taskDurationMs": 362.27599999999995,
"heapDeltaBytes": -19752364,
"heapUsedBytes": 78245148,
"domNodes": -258,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 22.195999999999998,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 414.67099999999846,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.369,
"layouts": 10,
"layoutDurationMs": 2.719,
"taskDurationMs": 274.548,
"heapDeltaBytes": 21640932,
"heapUsedBytes": 88407448,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 101.866,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667999999999992,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 445.4399999999623,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.279000000000001,
"layouts": 10,
"layoutDurationMs": 2.586,
"taskDurationMs": 293.575,
"heapDeltaBytes": 3374548,
"heapUsedBytes": 80423528,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 99.17399999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2009.1219999999907,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.94,
"layouts": 10,
"layoutDurationMs": 2.878,
"taskDurationMs": 388.04200000000003,
"heapDeltaBytes": 21627872,
"heapUsedBytes": 88446524,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.983000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.6540000000687,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.321,
"layouts": 10,
"layoutDurationMs": 2.169,
"taskDurationMs": 221.956,
"heapDeltaBytes": 22505836,
"heapUsedBytes": 89398292,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7.211,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.3379999999966,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.074999999999998,
"layouts": 9,
"layoutDurationMs": 2.582,
"taskDurationMs": 529.0319999999999,
"heapDeltaBytes": 11646172,
"heapUsedBytes": 79064672,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 92.207,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.0989999999983,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.019,
"layouts": 9,
"layoutDurationMs": 1.852,
"taskDurationMs": 489.584,
"heapDeltaBytes": 11650360,
"heapUsedBytes": 78537216,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 74.36800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1235.320999999999,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.898,
"layouts": 5,
"layoutDurationMs": 10.082999999999998,
"taskDurationMs": 765.722,
"heapDeltaBytes": 7252804,
"heapUsedBytes": 103067832,
"domNodes": 15953,
"jsHeapTotalBytes": 17698816,
"scriptDurationMs": 25.701,
"eventListeners": 3244,
"totalBlockingTimeMs": 84,
"frameDurationMs": 18.655223880597024,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9740.75899999997,
"styleRecalcs": 250,
"styleRecalcDurationMs": 25.743,
"layouts": 9,
"layoutDurationMs": 2.3160000000000003,
"taskDurationMs": 4590.22,
"heapDeltaBytes": -9539424,
"heapUsedBytes": 86815504,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 2124.58,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665982905982904,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8337.388999999916,
"styleRecalcs": 251,
"styleRecalcDurationMs": 22.165,
"layouts": 9,
"layoutDurationMs": 2.435,
"taskDurationMs": 3912.089,
"heapDeltaBytes": -12194820,
"heapUsedBytes": 85764080,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 1922.4,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69939879759519,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16989.96699999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16336.210000000001,
"heapDeltaBytes": 6871628,
"heapUsedBytes": 288839788,
"domNodes": -3330,
"jsHeapTotalBytes": 12050432,
"scriptDurationMs": 224.508,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.615505226480842,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 14759.619999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13997.297,
"heapDeltaBytes": -23449128,
"heapUsedBytes": 277952508,
"domNodes": -3330,
"jsHeapTotalBytes": 46911488,
"scriptDurationMs": 180.384,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.386402753872634,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 15122.678000000007,
"styleRecalcs": 76,
"styleRecalcDurationMs": 10.142999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14542.484999999999,
"heapDeltaBytes": 4247860,
"heapUsedBytes": 289253080,
"domNodes": -3330,
"jsHeapTotalBytes": 21225472,
"scriptDurationMs": 656.882,
"eventListeners": -651,
"totalBlockingTimeMs": 19,
"frameDurationMs": 26.81309734513274,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 17804.193999999938,
"styleRecalcs": 143,
"styleRecalcDurationMs": 12.408000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17540.564,
"heapDeltaBytes": -23926776,
"heapUsedBytes": 267197620,
"domNodes": -3330,
"jsHeapTotalBytes": 12312576,
"scriptDurationMs": 608.2579999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.61490566037735,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6072.7009999999955,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.91899999999999,
"layouts": 20,
"layoutDurationMs": 22.756999999999998,
"taskDurationMs": 5931.181,
"heapDeltaBytes": 6612832,
"heapUsedBytes": 297889440,
"domNodes": -3330,
"jsHeapTotalBytes": 35901440,
"scriptDurationMs": 90.197,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.08033707865168,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 4456.848000000036,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.24300000000001,
"layouts": 20,
"layoutDurationMs": 20.641000000000005,
"taskDurationMs": 4312.711,
"heapDeltaBytes": 10713112,
"heapUsedBytes": 283231856,
"domNodes": -3330,
"jsHeapTotalBytes": 48750592,
"scriptDurationMs": 67.46,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.721387283236997,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8242.136000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7878.492999999999,
"heapDeltaBytes": 4553596,
"heapUsedBytes": 261358212,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 108.10999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.155972696245737,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7670.187999999939,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7365.152000000002,
"heapDeltaBytes": 2577748,
"heapUsedBytes": 279883924,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 99.74,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.311986301369863,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 115.41500000004135,
"styleRecalcs": 10,
"styleRecalcDurationMs": 12.11,
"layouts": 8,
"layoutDurationMs": 3.2459999999999996,
"taskDurationMs": 89.045,
"heapDeltaBytes": -15134776,
"heapUsedBytes": 68350504,
"domNodes": 124,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 11.279000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142908,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 442.6220000000285,
"styleRecalcs": 18,
"styleRecalcDurationMs": 11.573,
"layouts": 13,
"layoutDurationMs": 4.134,
"taskDurationMs": 91.60800000000002,
"heapDeltaBytes": 6715616,
"heapUsedBytes": 79282564,
"domNodes": 121,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.206,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 199.42600000001676,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.042,
"layouts": 76,
"layoutDurationMs": 10.016,
"taskDurationMs": 158.523,
"heapDeltaBytes": -19915824,
"heapUsedBytes": 71525668,
"domNodes": 4,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 62.233999999999995,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.658333333333342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 234.71700000004603,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8989999999999999,
"layouts": 76,
"layoutDurationMs": 12.886999999999999,
"taskDurationMs": 198.58299999999997,
"heapDeltaBytes": 9280084,
"heapUsedBytes": 94501412,
"domNodes": 4,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 85.985,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 316.47399999997106,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.234,
"layouts": 76,
"layoutDurationMs": 13.283,
"taskDurationMs": 276.299,
"heapDeltaBytes": -1933860,
"heapUsedBytes": 116884472,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 96.7,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263162,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 329.6139999999923,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.2560000000000002,
"layouts": 76,
"layoutDurationMs": 13.703,
"taskDurationMs": 289.438,
"heapDeltaBytes": -6432672,
"heapUsedBytes": 110540340,
"domNodes": 4,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 102.501,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661904761904786,
"p95FrameDurationMs": 16.799999999999272
}
]
}🎭 Playwright: ✅ 2276 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b9639b61be88cc3720b8a4d3eb55b16bc25673e3
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #21142 +/- ##
============================================
Coverage 87.16% 87.16%
============================================
Files 2614 2614
Lines 147007 147009 +2
Branches 38230 40313 +2083
============================================
+ Hits 128145 128147 +2
Misses 18474 18474
Partials 388 388
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: Faithful backport of #20983 to core/1.57, no adaptations.
I compared this branch against the merged source commit 63bf48c from #20983. Every hunk adds and removes the same lines as the source: the single-frame content-class in CurrentUserButton.vue, the slimmed root <div> in CurrentUserPopoverLegacy.vue and CurrentUserPopoverWorkspace.vue, the new frame test in currentUserPopoverCredits.spec.ts, and the updated workspace-switcher-scrolled-cloud-linux.png baseline. The PNG blob is identical before and after.
The two popover files start from different content on core/1.57 than on main. The differences are a text-muted-foreground class swap and BILLING_ACTION_NAME data attributes from other main PRs that were not backported. Neither touches the root <div> this PR rewrites, so the hunks apply unchanged and the result differs from main only by those unrelated lines. CurrentUserButton.vue already imports cn and defines showWorkspacePopover on core/1.57.
CI on this head passes lint, typecheck, preflight, the five playwright-tests projects, all four playwright-tests-cloud-sharded shards (which run the @cloud popover spec and the workspace switcher screenshot), and playwright-video-new-tests (cloud) for the new test. The chromium shards and the ecosystem matrix were still running, with no failures, when I reviewed.
Backport of #20983 to
core/1.57Automatically created by backport workflow.