Repository navigation
[backport cloud/1.57] fix: size legacy widget canvases from layout width, not zoomed rect (FE-3459) - #21135
Conversation
…FE-3459) (#21114) *PR Created by the Glary-Bot Agent* --- ## Summary Fixes [FE-3459](https://linear.app/comfyorg/issue/FE-3459): in Nodes 2.0, the widgets on VHS **Load Video (Upload)** overlap each other. In `WidgetLegacy.vue` `draw()`, #15453 ("test: cover direct widget array mutations", which landed on main through the ECS migration #14246) changed the order of the two canvas width sources. `getBoundingClientRect().width` now came first and `parentElement.clientWidth` became the fallback. - `getBoundingClientRect()` includes the graph canvas zoom transform. A legacy widget redrawn while the graph is zoomed out was therefore sized at the scaled width. That width was used for `computeSize`/height, `widget.width` and the canvas backing width, so the widget heights came out wrong. - A transform change doesn't trigger `ResizeObserver`, so the wrong size stayed after zooming back to 100%. The result was overlapping widgets. This PR puts the two lines back in their original order. Layout `clientWidth` (not affected by the transform) comes first, and the bounding rect is only the fallback for the zero-width case. The parent is still `w-full`, so `clientWidth` and the rect agree at 1× zoom. ## Changes - `WidgetLegacy.vue`: `parentElement.clientWidth || getBoundingClientRect().width` - `WidgetLegacy.test.ts`: new regression test. It mocks a layout width of 200 and a zoomed rect width of 100, then checks that `widget.width` is 200 and the canvas backing width is 400. I confirmed the test fails without the fix (`expected 100 to be 200`). ## Verification - `pnpm vitest run src/renderer/extensions/vueNodes/widgets/components/`: 497/497 pass - `pnpm typecheck`, oxlint, eslint, oxfmt: clean - Browser check (done in the FE-3459 investigation, not repeated here): production builds served by ComfyUI with the real VideoHelperSuite extension showed the overlap. Swapping only these two lines fixed it, both on the commit that introduced the overlap and on current `main`. I didn't take a separate Playwright screenshot for this PR, because the repro needs the VHS custom node plus an uploaded video in a backend. Linear: FE-3459 Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-15T22:57:29.292Z",
"gitSha": "278b8e3f81ba7d0111164d1373d19419eb8da43a",
"branch": "backport-21114-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.697000000017,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.0430000000000006,
"layouts": 10,
"layoutDurationMs": 2.018,
"taskDurationMs": 326.81,
"heapDeltaBytes": -875024,
"heapUsedBytes": 73944452,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 8.367999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.4350000000532,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.0619999999999994,
"layouts": 11,
"layoutDurationMs": 2.033,
"taskDurationMs": 294.09799999999996,
"heapDeltaBytes": 3552288,
"heapUsedBytes": 78519952,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 6.035,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.2469999999948,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.817,
"layouts": 10,
"layoutDurationMs": 2.332,
"taskDurationMs": 576.105,
"heapDeltaBytes": 15631128,
"heapUsedBytes": 81381448,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 110.542,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.9729999999518,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.166,
"layouts": 9,
"layoutDurationMs": 1.9460000000000002,
"taskDurationMs": 486.78900000000004,
"heapDeltaBytes": 15234992,
"heapUsedBytes": 81411088,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 91.342,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.0650000000055,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.123999999999999,
"layouts": 11,
"layoutDurationMs": 2.9180000000000006,
"taskDurationMs": 263.20899999999995,
"heapDeltaBytes": 18794248,
"heapUsedBytes": 84488320,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.638,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.6910000000444,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.449999999999999,
"layouts": 11,
"layoutDurationMs": 2.4699999999999998,
"taskDurationMs": 225.45200000000003,
"heapDeltaBytes": 18693572,
"heapUsedBytes": 84929428,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7.815999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 544.2160000000058,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.8480000000000008,
"layouts": 9,
"layoutDurationMs": 2.5190000000000006,
"taskDurationMs": 339.54499999999996,
"heapDeltaBytes": 6753604,
"heapUsedBytes": 81496176,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 112.354,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 415.3909999999996,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.9619999999999993,
"layouts": 9,
"layoutDurationMs": 2.118,
"taskDurationMs": 293.13800000000003,
"heapDeltaBytes": -1067536,
"heapUsedBytes": 65085324,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 102.43299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 908.8459999999827,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.1099999999999,
"heapDeltaBytes": -12933240,
"heapUsedBytes": 81149820,
"domNodes": -192,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 36.312999999999995,
"eventListeners": -106,
"totalBlockingTimeMs": 268,
"frameDurationMs": 26.188571428571425,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 893.3759999999893,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.0849999999999,
"heapDeltaBytes": -11405300,
"heapUsedBytes": 81293688,
"domNodes": -192,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 36.31,
"eventListeners": -106,
"totalBlockingTimeMs": 258,
"frameDurationMs": 25.714285714285715,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 702.855999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 271.85700000000026,
"heapDeltaBytes": -5236736,
"heapUsedBytes": 76043940,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 88.89300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 87,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 702.1859999999833,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 269.09099999999995,
"heapDeltaBytes": -5187464,
"heapUsedBytes": 74602284,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 86.9,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6275.113000000033,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8329999999999995,
"layouts": 3,
"layoutDurationMs": 0.761,
"taskDurationMs": 5065.802,
"heapDeltaBytes": -26630144,
"heapUsedBytes": 72814640,
"domNodes": -258,
"jsHeapTotalBytes": 12185600,
"scriptDurationMs": 4093.3219999999997,
"eventListeners": -67,
"totalBlockingTimeMs": 18,
"frameDurationMs": 21.08422818791946,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6289.918,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7949999999999997,
"layouts": 3,
"layoutDurationMs": 0.7049999999999998,
"taskDurationMs": 5129.132,
"heapDeltaBytes": -14848184,
"heapUsedBytes": 79095248,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 3906.6,
"eventListeners": -67,
"totalBlockingTimeMs": 13,
"frameDurationMs": 20.32161290322581,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6420.714999999973,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.254,
"layouts": 4,
"layoutDurationMs": 1.1340000000000001,
"taskDurationMs": 5325.022,
"heapDeltaBytes": -23869944,
"heapUsedBytes": 76002036,
"domNodes": -258,
"jsHeapTotalBytes": 7729152,
"scriptDurationMs": 4093.058,
"eventListeners": -67,
"totalBlockingTimeMs": 19,
"frameDurationMs": 20.49968051118211,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6394.263000000024,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8640000000000002,
"layouts": 3,
"layoutDurationMs": 0.7259999999999996,
"taskDurationMs": 5254.713000000001,
"heapDeltaBytes": -2848956,
"heapUsedBytes": 96299816,
"domNodes": -258,
"jsHeapTotalBytes": 8515584,
"scriptDurationMs": 4214.808000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 45,
"frameDurationMs": 21.277,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 181.11099999998714,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.173,
"layouts": 11,
"layoutDurationMs": 2.797,
"taskDurationMs": 124.47899999999998,
"heapDeltaBytes": -8050380,
"heapUsedBytes": 79035808,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 6.801,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.82499999999999,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 145.82699999999704,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.863000000000001,
"layouts": 13,
"layoutDurationMs": 3.013,
"taskDurationMs": 107.28999999999998,
"heapDeltaBytes": -8067440,
"heapUsedBytes": 79304520,
"domNodes": 917,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 5.976,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2025.6939999999872,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6239999999999988,
"layouts": 9,
"layoutDurationMs": 2.368,
"taskDurationMs": 410.72800000000007,
"heapDeltaBytes": -20994428,
"heapUsedBytes": 75682648,
"domNodes": -258,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 26.601999999999993,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2008.9460000000372,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8450000000000002,
"layouts": 8,
"layoutDurationMs": 1.8130000000000002,
"taskDurationMs": 364.878,
"heapDeltaBytes": -2356260,
"heapUsedBytes": 76487172,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 22.835,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2327.462999999966,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.5280000000000005,
"layouts": 8,
"layoutDurationMs": 1.9300000000000004,
"taskDurationMs": 1146.997,
"heapDeltaBytes": -11728124,
"heapUsedBytes": 67821308,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 553.3820000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2218.7419999999065,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.548,
"layouts": 9,
"layoutDurationMs": 2.236,
"taskDurationMs": 1122.83,
"heapDeltaBytes": -10699360,
"heapUsedBytes": 68909516,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 569.802,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3641.6419999999903,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.732,
"layouts": 66,
"layoutDurationMs": 13.940000000000001,
"taskDurationMs": 1309.915,
"heapDeltaBytes": -10124116,
"heapUsedBytes": 71796268,
"domNodes": -234,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 554.808,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666210045662098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3386.786000000029,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.951,
"layouts": 66,
"layoutDurationMs": 12.004999999999999,
"taskDurationMs": 1245.1509999999998,
"heapDeltaBytes": 6992660,
"heapUsedBytes": 88677376,
"domNodes": -234,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 543.941,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66600985221675,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2306.896999999992,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.06,
"layouts": 8,
"layoutDurationMs": 1.945,
"taskDurationMs": 1289.594,
"heapDeltaBytes": 4363788,
"heapUsedBytes": 87120512,
"domNodes": 0,
"jsHeapTotalBytes": 5730304,
"scriptDurationMs": 640.91,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665467625899282,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2323.7490000000207,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.2780000000000005,
"layouts": 5,
"layoutDurationMs": 1.272,
"taskDurationMs": 1269.266,
"heapDeltaBytes": 389556,
"heapUsedBytes": 83748476,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 637.9110000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7863309352518,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2021.2209999999686,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.796,
"layouts": 9,
"layoutDurationMs": 2.382,
"taskDurationMs": 396.74899999999997,
"heapDeltaBytes": -20085884,
"heapUsedBytes": 77729588,
"domNodes": -258,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 25.816999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2036.1829999999372,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.750999999999999,
"layouts": 9,
"layoutDurationMs": 2.7,
"taskDurationMs": 418.596,
"heapDeltaBytes": -2094324,
"heapUsedBytes": 79018968,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 24.769,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 412.571000000014,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.4750000000000005,
"layouts": 10,
"layoutDurationMs": 2.681,
"taskDurationMs": 291.068,
"heapDeltaBytes": -1128088,
"heapUsedBytes": 76164032,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 98.402,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66800000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 397.4959999999328,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.061,
"layouts": 10,
"layoutDurationMs": 2.3240000000000003,
"taskDurationMs": 272.433,
"heapDeltaBytes": -1496284,
"heapUsedBytes": 75932308,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 91.80400000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.1960000000313,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.909000000000001,
"layouts": 9,
"layoutDurationMs": 3.257,
"taskDurationMs": 337.291,
"heapDeltaBytes": 22391728,
"heapUsedBytes": 89299384,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.990999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.6199999999035,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2970000000000006,
"layouts": 10,
"layoutDurationMs": 2.048,
"taskDurationMs": 215.861,
"heapDeltaBytes": 22517276,
"heapUsedBytes": 89291480,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7.414999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.4990000000116,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.503000000000002,
"layouts": 9,
"layoutDurationMs": 2.395,
"taskDurationMs": 458.719,
"heapDeltaBytes": 10896208,
"heapUsedBytes": 77708396,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 82.172,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1685.5809999999565,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.037000000000003,
"layouts": 11,
"layoutDurationMs": 2.197,
"taskDurationMs": 524.142,
"heapDeltaBytes": -9129872,
"heapUsedBytes": 57573444,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 75.441,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1270.1629999999682,
"styleRecalcs": 20,
"styleRecalcDurationMs": 20.877999999999993,
"layouts": 5,
"layoutDurationMs": 10.913999999999998,
"taskDurationMs": 783.1579999999998,
"heapDeltaBytes": 7395816,
"heapUsedBytes": 101667004,
"domNodes": 15953,
"jsHeapTotalBytes": 17440768,
"scriptDurationMs": 26.742999999999995,
"eventListeners": 3244,
"totalBlockingTimeMs": 85,
"frameDurationMs": 18.597101449275375,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8538.67200000002,
"styleRecalcs": 251,
"styleRecalcDurationMs": 24.097,
"layouts": 9,
"layoutDurationMs": 3.714,
"taskDurationMs": 4041.569,
"heapDeltaBytes": 12359604,
"heapUsedBytes": 91494280,
"domNodes": -258,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 1877.877,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665886939571152,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8421.880999999985,
"styleRecalcs": 251,
"styleRecalcDurationMs": 22.713,
"layouts": 10,
"layoutDurationMs": 2.467,
"taskDurationMs": 3855.275,
"heapDeltaBytes": 5494504,
"heapUsedBytes": 84105956,
"domNodes": -258,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 1860.106,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665810276679842,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12553.404,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11918.543999999998,
"heapDeltaBytes": 19198192,
"heapUsedBytes": 300942812,
"domNodes": -3330,
"jsHeapTotalBytes": 45867008,
"scriptDurationMs": 170.60399999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.020770519262985,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 16496.10800000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15428.641,
"heapDeltaBytes": 15576632,
"heapUsedBytes": 306909284,
"domNodes": -3330,
"jsHeapTotalBytes": 45867008,
"scriptDurationMs": 222.93999999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.366609589041094,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 19103.485000000033,
"styleRecalcs": 141,
"styleRecalcDurationMs": 15.20100000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18713.803,
"heapDeltaBytes": -9088440,
"heapUsedBytes": 272400872,
"domNodes": -3330,
"jsHeapTotalBytes": 16506880,
"scriptDurationMs": 683.02,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.01080586080587,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18774.83600000005,
"styleRecalcs": 153,
"styleRecalcDurationMs": 15.103000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18356.596,
"heapDeltaBytes": -22144396,
"heapUsedBytes": 259263192,
"domNodes": -3330,
"jsHeapTotalBytes": 12312576,
"scriptDurationMs": 663.612,
"eventListeners": -651,
"totalBlockingTimeMs": 4,
"frameDurationMs": 34.68743068391866,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6005.863999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 56.57699999999999,
"layouts": 20,
"layoutDurationMs": 23.806999999999995,
"taskDurationMs": 5880.036999999999,
"heapDeltaBytes": -3498592,
"heapUsedBytes": 278260276,
"domNodes": -3334,
"jsHeapTotalBytes": 29614080,
"scriptDurationMs": 92.41,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.48160919540229,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 4807.313000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.11499999999999,
"layouts": 20,
"layoutDurationMs": 21.079,
"taskDurationMs": 4588.959,
"heapDeltaBytes": 986584,
"heapUsedBytes": 281622620,
"domNodes": -3330,
"jsHeapTotalBytes": 32759808,
"scriptDurationMs": 75.19700000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.805376344086017,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8305.774999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7951.184000000001,
"heapDeltaBytes": -4413788,
"heapUsedBytes": 259572352,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 107.52699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.521305841924395,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7833.520000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7441.966999999998,
"heapDeltaBytes": -8612200,
"heapUsedBytes": 261346124,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 91.443,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.917869415807555,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 126.25000000002728,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.485999999999999,
"layouts": 7,
"layoutDurationMs": 4.194,
"taskDurationMs": 95.86600000000001,
"heapDeltaBytes": -15201440,
"heapUsedBytes": 68071044,
"domNodes": 97,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 9.427999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.057142857142804,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 73.81499999996777,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.646999999999999,
"layouts": 5,
"layoutDurationMs": 1.629,
"taskDurationMs": 50.083000000000006,
"heapDeltaBytes": 4353960,
"heapUsedBytes": 77375480,
"domNodes": 116,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.8140000000000005,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 219.98999999993885,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.065,
"layouts": 76,
"layoutDurationMs": 11.393,
"taskDurationMs": 179.924,
"heapDeltaBytes": -10710376,
"heapUsedBytes": 82839324,
"domNodes": 4,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 73.25800000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 207.2410000000673,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.071,
"layouts": 76,
"layoutDurationMs": 10.44,
"taskDurationMs": 171.504,
"heapDeltaBytes": 8971164,
"heapUsedBytes": 100146616,
"domNodes": 4,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 75.22,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661538461538456,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 234.06699999998182,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.403,
"layouts": 76,
"layoutDurationMs": 9.485000000000001,
"taskDurationMs": 192.411,
"heapDeltaBytes": -2477468,
"heapUsedBytes": 131922348,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 63.43,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 263.7650000000349,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.643,
"layouts": 76,
"layoutDurationMs": 10.607,
"taskDurationMs": 227.568,
"heapDeltaBytes": -2285780,
"heapUsedBytes": 119322736,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 76.167,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66874999999999,
"p95FrameDurationMs": 16.700000000000273
}
]
}🎭 Playwright: ✅ 2280 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 02782f72989211f1fce86beb69c342c8f6763538
Full docs: ADR-DEVEX-LINT-0015 |
There was a problem hiding this comment.
Verdict: Faithful backport of #21114 to cloud/1.57, no adaptations.
I compared this branch against the merged source commit 24f1250 from #21114. The patch is byte-identical, blob hashes included. Both WidgetLegacy.vue and WidgetLegacy.test.ts on cloud/1.57 start from the same content as on main, so nothing needed adapting. The width fallback swap in draw() and the new zoomed-canvas test both come over unchanged.
Checks on the target:
- CI on this head passes
lint-pr / lint,lint-pr / typecheck,typecheck-aux,lint-and-format, andpreflight. The unit and e2e jobs had not reported when I reviewed. - Locally, with cloud/1.57's own dependencies installed,
WidgetLegacy.test.tspasses (9 tests). - With only the
WidgetLegacy.vuechange reverted, the new test fails withexpected 100 to be 200, so it guards the fix on this branch.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21135 +/- ##
=============================================
Coverage ? 87.21%
=============================================
Files ? 2626
Lines ? 147561
Branches ? 40497
=============================================
Hits ? 128699
Misses ? 18472
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #21114 to
cloud/1.57Automatically created by backport workflow.