Repository navigation
fix: tighten legacy-manager tip and tag pack-search rewrites (follow-up to #14732) - #21133
Conversation
A pasted kijai/comfyui-kjnodes.git kept its .git suffix while the GitHub URL form already dropped it. Match the URL form, case-insensitively.
Both cases shared the id 'single-id', so the memoized toRegistryPack returned the first case's object to the second and the objectID case passed even with the objectID fallback removed.
Rewrite requests carry analyticsTags ['rewrite'] so dashboards and query suggestions can segment machine-made queries away from what users typed. The raw query stays untagged.
The tip matched any query containing "manager", so a pasted willmiao/comfyui-lora-manager rescued by a rewrite showed LoRA Manager under a banner telling the user to start ComfyUI with --enable-manager-legacy-ui. It now fires only when the owner-stripped, trimmed, lowercased query is comfyui-manager or one of its listed spellings, and the raw query found nothing. The tip read the live search box while rawResultsEmpty belonged to the previous search, which runs 320ms after typing stops, so the banner could flash before the new search ran. useRegistrySearch now exposes searchedQuery, the query behind the shown results, and the tip reads that instead. The tip rendered both inside the empty-state message and as a banner above results. It now renders only as the banner, which covers both the empty and the rescued case.
The integration test replays recorded nodes_index responses and throws on any query that was not recorded, but no recorder was in the repo and the fixture's _README pointed at PR history. Add scripts/record-algolia-nodes-fixture.ts, which sends the provider's packs-mode request for each seed query, records the rewrites of seeds that return no hits, and writes the fixture. Its test regenerates the committed fixture from the same answers, so the two stay in step. Drop the entries no test reads (gaclove/comfyui-vfi and its rewrites, EulerDiscreteScheduler and Euler Discrete Scheduler, comfyui 3d) and the hits past the first page of 64, matching what the recorder requests. The recorder has not been run against the live index; the fixture data is the existing recording, pruned.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle: 9.49 MB gzip 🔴 +327 BDetailsSummary
Category Glance App Entry Points — 6.62 kB (baseline 6.62 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.46 MB (baseline 3.46 MB) • 🔴 +1.06 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 3 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 670 kB (baseline 670 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 29 unchanged User & Accounts — 151 kB (baseline 151 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 17 unchanged Editors & Dialogs — 359 kB (baseline 359 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 12 unchanged UI Components — 212 kB (baseline 212 kB) • ⚪ 0 BReusable component library chunks Status: 24 unchanged Data & Services — 1.11 MB (baseline 1.11 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 37 unchanged Utilities & Hooks — 998 kB (baseline 998 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 72 unchanged Vendor & Third-Party — 13.9 MB (baseline 13.9 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 19.7 MB (baseline 19.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 365 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-16T01:30:17.364Z",
"gitSha": "423513154169740620ef8e1d40caf1e0857f541e",
"branch": "search/pack-search-followups",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.3420000000085,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.259,
"layouts": 10,
"layoutDurationMs": 2.019,
"taskDurationMs": 250.75499999999994,
"heapDeltaBytes": -22426256,
"heapUsedBytes": 56181260,
"domNodes": -162,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 6.075000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2010.8410000000276,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.945,
"layouts": 10,
"layoutDurationMs": 1.7579999999999998,
"taskDurationMs": 314.937,
"heapDeltaBytes": -20202580,
"heapUsedBytes": 58434424,
"domNodes": -162,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 5.066999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.1210000000144,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.921,
"layouts": 9,
"layoutDurationMs": 2.1280000000000006,
"taskDurationMs": 551.3399999999999,
"heapDeltaBytes": -8439648,
"heapUsedBytes": 55802160,
"domNodes": -162,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 99.732,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1705.2240000000438,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.32,
"layouts": 10,
"layoutDurationMs": 2.195,
"taskDurationMs": 485.954,
"heapDeltaBytes": -7635044,
"heapUsedBytes": 55250968,
"domNodes": -162,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 96.913,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.4899999999834,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.0809999999999995,
"layouts": 12,
"layoutDurationMs": 2.4280000000000004,
"taskDurationMs": 227.87599999999998,
"heapDeltaBytes": -229576,
"heapUsedBytes": 78340264,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 6.214999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.434000000011,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.7790000000000004,
"layouts": 13,
"layoutDurationMs": 2.433,
"taskDurationMs": 178.474,
"heapDeltaBytes": -148804,
"heapUsedBytes": 78420940,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 6.468999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 494.7400000000073,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.651,
"layouts": 10,
"layoutDurationMs": 2.417,
"taskDurationMs": 310.527,
"heapDeltaBytes": 6209816,
"heapUsedBytes": 84724332,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 99.634,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 449.4589999999903,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.4850000000000003,
"layouts": 11,
"layoutDurationMs": 2.3600000000000003,
"taskDurationMs": 346.243,
"heapDeltaBytes": 6221196,
"heapUsedBytes": 84833320,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 96.961,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670370370370367,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 953.218000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.538,
"heapDeltaBytes": 17398748,
"heapUsedBytes": 97930940,
"domNodes": 0,
"jsHeapTotalBytes": 17727488,
"scriptDurationMs": 33.157999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 319,
"frameDurationMs": 27.140000000000004,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 841.3779999999633,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.938,
"heapDeltaBytes": 14499136,
"heapUsedBytes": 94755908,
"domNodes": 0,
"jsHeapTotalBytes": 16941056,
"scriptDurationMs": 32.344,
"eventListeners": 0,
"totalBlockingTimeMs": 247,
"frameDurationMs": 25.757575757575758,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 686.885000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 257.79299999999995,
"heapDeltaBytes": -5050920,
"heapUsedBytes": 72771120,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 80.86600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 78,
"frameDurationMs": 20.097058823529416,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 687.3509999999783,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 266.59200000000016,
"heapDeltaBytes": -4215688,
"heapUsedBytes": 74052424,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 84.60800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 78,
"frameDurationMs": 20,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5566.4969999999985,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.17600000000000082,
"layouts": 1,
"layoutDurationMs": 0.196,
"taskDurationMs": 4576.017999999999,
"heapDeltaBytes": -7850820,
"heapUsedBytes": 75744680,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 3523.774,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.784025559105434,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5418.394999999975,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5389999999999996,
"layouts": 2,
"layoutDurationMs": 0.461,
"taskDurationMs": 4511.782,
"heapDeltaBytes": -13568504,
"heapUsedBytes": 70702176,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 3489.619,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.195238095238096,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5397.817000000004,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6389999999999998,
"layouts": 3,
"layoutDurationMs": 0.591,
"taskDurationMs": 4563.169999999999,
"heapDeltaBytes": 10629580,
"heapUsedBytes": 94760472,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 3528.714,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.475080906148868,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5293.188000000044,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.503,
"layouts": 2,
"layoutDurationMs": 0.4210000000000004,
"taskDurationMs": 4399.6320000000005,
"heapDeltaBytes": 4116848,
"heapUsedBytes": 88063048,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 3377.941,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.151456310679613,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-combo-open",
"durationMs": 140.1310000000251,
"styleRecalcs": 22,
"styleRecalcDurationMs": 9.557,
"layouts": 12,
"layoutDurationMs": 2.449,
"taskDurationMs": 93.089,
"heapDeltaBytes": 13484880,
"heapUsedBytes": 77048220,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.667999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.042857142857105,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "large-combo-open",
"durationMs": 136.6769999999633,
"styleRecalcs": 22,
"styleRecalcDurationMs": 9.596,
"layouts": 12,
"layoutDurationMs": 2.3709999999999996,
"taskDurationMs": 88.23999999999998,
"heapDeltaBytes": 13426856,
"heapUsedBytes": 77682764,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.596,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.05714285714287,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2007.491000000016,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.895,
"layouts": 7,
"layoutDurationMs": 1.6280000000000001,
"taskDurationMs": 355.96000000000004,
"heapDeltaBytes": 10635140,
"heapUsedBytes": 75681044,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 23.924,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2033.5880000000088,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.5250000000000004,
"layouts": 8,
"layoutDurationMs": 1.3400000000000003,
"taskDurationMs": 352.814,
"heapDeltaBytes": -24892496,
"heapUsedBytes": 73742852,
"domNodes": -258,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 19.179999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2094.573999999994,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.677999999999999,
"layouts": 8,
"layoutDurationMs": 1.7000000000000002,
"taskDurationMs": 974.369,
"heapDeltaBytes": -26738136,
"heapUsedBytes": 77479176,
"domNodes": -258,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 527.4540000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2149.338,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.175000000000001,
"layouts": 6,
"layoutDurationMs": 2.365,
"taskDurationMs": 1021.423,
"heapDeltaBytes": 16961680,
"heapUsedBytes": 81792400,
"domNodes": -258,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 514.838,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.796850393700787,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3307.7880000000164,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.444,
"layouts": 65,
"layoutDurationMs": 10.187999999999999,
"taskDurationMs": 1080.067,
"heapDeltaBytes": -115428,
"heapUsedBytes": 66792340,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 476.53999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532663316583,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3106.722999999988,
"styleRecalcs": 72,
"styleRecalcDurationMs": 7.078,
"layouts": 65,
"layoutDurationMs": 9.899,
"taskDurationMs": 951.9920000000002,
"heapDeltaBytes": 495064,
"heapUsedBytes": 67110716,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 481.298,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665775401069517,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2168.9179999999906,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.86,
"layouts": 5,
"layoutDurationMs": 1.029,
"taskDurationMs": 1113.759,
"heapDeltaBytes": 3792788,
"heapUsedBytes": 71255832,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 608.401,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2093.786000000023,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.670000000000001,
"layouts": 5,
"layoutDurationMs": 0.9849999999999998,
"taskDurationMs": 1040.8460000000002,
"heapDeltaBytes": 4337836,
"heapUsedBytes": 71410756,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 576.05,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6664,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.1169999999752,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.254,
"layouts": 7,
"layoutDurationMs": 1.143,
"taskDurationMs": 331.392,
"heapDeltaBytes": 9743800,
"heapUsedBytes": 74656004,
"domNodes": -172,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 18.128,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2014.7000000000048,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.5850000000000004,
"layouts": 8,
"layoutDurationMs": 1.3860000000000001,
"taskDurationMs": 244.17899999999997,
"heapDeltaBytes": 9784580,
"heapUsedBytes": 74573240,
"domNodes": -259,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.837000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 446.8130000000201,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.343000000000001,
"layouts": 11,
"layoutDurationMs": 2.3899999999999997,
"taskDurationMs": 329.187,
"heapDeltaBytes": 20780284,
"heapUsedBytes": 85658272,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 88.18900000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 380.79900000002453,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.15,
"layouts": 11,
"layoutDurationMs": 2.44,
"taskDurationMs": 238.614,
"heapDeltaBytes": 2139848,
"heapUsedBytes": 82680592,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 87.70899999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2027.0969999999977,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.698,
"layouts": 11,
"layoutDurationMs": 2.554,
"taskDurationMs": 351.853,
"heapDeltaBytes": -4265520,
"heapUsedBytes": 76433672,
"domNodes": -180,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 7.035999999999999,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.206000000006,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.621,
"layouts": 10,
"layoutDurationMs": 1.556,
"taskDurationMs": 309.135,
"heapDeltaBytes": 13876556,
"heapUsedBytes": 79188084,
"domNodes": -180,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 4.752000000000001,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.3540000000082,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.007000000000001,
"layouts": 9,
"layoutDurationMs": 2.1580000000000004,
"taskDurationMs": 488.654,
"heapDeltaBytes": 16223608,
"heapUsedBytes": 81049164,
"domNodes": -180,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 78.225,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.403000000003,
"styleRecalcs": 75,
"styleRecalcDurationMs": 10.735,
"layouts": 10,
"layoutDurationMs": 1.9080000000000001,
"taskDurationMs": 434.00000000000006,
"heapDeltaBytes": -8366068,
"heapUsedBytes": 57212984,
"domNodes": -180,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 68.23800000000001,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 817.416000000037,
"styleRecalcs": 19,
"styleRecalcDurationMs": 15.687000000000003,
"layouts": 5,
"layoutDurationMs": 9.325999999999999,
"taskDurationMs": 607.2610000000001,
"heapDeltaBytes": 11892164,
"heapUsedBytes": 110572736,
"domNodes": 15950,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 16.997000000000003,
"eventListeners": 3244,
"totalBlockingTimeMs": 61,
"frameDurationMs": 18.99069767441859,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8089.5859999999975,
"styleRecalcs": 249,
"styleRecalcDurationMs": 20.54,
"layouts": 8,
"layoutDurationMs": 1.6430000000000002,
"taskDurationMs": 3421.974,
"heapDeltaBytes": -31899128,
"heapUsedBytes": 66842940,
"domNodes": -258,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 1632.589,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665773195876287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8145.083999999997,
"styleRecalcs": 251,
"styleRecalcDurationMs": 20.229,
"layouts": 8,
"layoutDurationMs": 1.626,
"taskDurationMs": 3445.0629999999996,
"heapDeltaBytes": 2434364,
"heapUsedBytes": 66969792,
"domNodes": -258,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1657.5030000000002,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665983606557376,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15139.97599999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14409.366000000002,
"heapDeltaBytes": -22072076,
"heapUsedBytes": 264105620,
"domNodes": -3330,
"jsHeapTotalBytes": 10211328,
"scriptDurationMs": 218.9,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.735884353741497,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 14823.718999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13953.747999999998,
"heapDeltaBytes": -4632644,
"heapUsedBytes": 279253436,
"domNodes": -2264,
"jsHeapTotalBytes": 16240640,
"scriptDurationMs": 163.152,
"eventListeners": -423,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.197278911564627,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 17777.023999999983,
"styleRecalcs": 152,
"styleRecalcDurationMs": 12.269999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17451.766000000003,
"heapDeltaBytes": -17772644,
"heapUsedBytes": 271839592,
"domNodes": -3330,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 565.5060000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.488888888888894,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 17724.84099999997,
"styleRecalcs": 159,
"styleRecalcDurationMs": 13.728000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17381.909,
"heapDeltaBytes": -24854444,
"heapUsedBytes": 273654760,
"domNodes": -3330,
"jsHeapTotalBytes": 8376320,
"scriptDurationMs": 561.0260000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.552846975088976,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5335.943000000043,
"styleRecalcs": 20,
"styleRecalcDurationMs": 43.55700000000001,
"layouts": 20,
"layoutDurationMs": 16.834000000000003,
"taskDurationMs": 5192.4259999999995,
"heapDeltaBytes": 3705772,
"heapUsedBytes": 287554012,
"domNodes": -3330,
"jsHeapTotalBytes": 26202112,
"scriptDurationMs": 68.276,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.131073446327683,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "vue-node-resize-workload",
"durationMs": 4106.627000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 43.906,
"layouts": 20,
"layoutDurationMs": 16.764000000000003,
"taskDurationMs": 3966.6810000000005,
"heapDeltaBytes": -17697620,
"heapUsedBytes": 271371644,
"domNodes": -3330,
"jsHeapTotalBytes": 47173632,
"scriptDurationMs": 54.64999999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.0683615819209,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5495.181000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5118.962999999999,
"heapDeltaBytes": 14892060,
"heapUsedBytes": 286392724,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 63.22,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.64338983050847,
"p95FrameDurationMs": 33.30000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7200.857000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6706.180999999999,
"heapDeltaBytes": -8542780,
"heapUsedBytes": 282146472,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 73.82099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.079264214046827,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 442.60399999996025,
"styleRecalcs": 16,
"styleRecalcDurationMs": 8.853,
"layouts": 11,
"layoutDurationMs": 3.351000000000001,
"taskDurationMs": 89.144,
"heapDeltaBytes": -12837460,
"heapUsedBytes": 63366992,
"domNodes": 124,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.886,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 435.1840000000493,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.726999999999999,
"layouts": 12,
"layoutDurationMs": 3.174,
"taskDurationMs": 81.278,
"heapDeltaBytes": 6786068,
"heapUsedBytes": 71029792,
"domNodes": 95,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.732,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 181.36500000002798,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.626,
"layouts": 76,
"layoutDurationMs": 8.701,
"taskDurationMs": 133.075,
"heapDeltaBytes": 8588468,
"heapUsedBytes": 81377688,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 55.248,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 158.72299999989536,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.643,
"layouts": 76,
"layoutDurationMs": 8.626999999999999,
"taskDurationMs": 127.23400000000001,
"heapDeltaBytes": 8509128,
"heapUsedBytes": 82465072,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 53.835,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65999999999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 226.6020000000708,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.211,
"layouts": 76,
"layoutDurationMs": 9.08,
"taskDurationMs": 190.706,
"heapDeltaBytes": -2718308,
"heapUsedBytes": 127327728,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 64.17200000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428578,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 233.20300000000316,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.217,
"layouts": 76,
"layoutDurationMs": 8.576,
"taskDurationMs": 183.433,
"heapDeltaBytes": -7364004,
"heapUsedBytes": 104475320,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 59.203,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2281 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 61eca01a973ae0545243f7d084f7156c930add5b
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21133 +/- ##
==========================================
+ Coverage 86.46% 87.35% +0.89%
==========================================
Files 3712 2657 -1055
Lines 176549 148259 -28290
Branches 48791 40914 -7877
==========================================
- Hits 152655 129514 -23141
+ Misses 21836 18354 -3482
+ Partials 2058 391 -1667
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1130 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 3 |
| ⚪ Nit | 4 |
Panel: 6/6 reviewers contributed findings.
stripRepoOwner already allowed a trailing slash on GitHub URLs but not on a bare slug, so kijai/comfyui-kjnodes/ kept its owner and got no fallback rewrites. The bare-slug pattern now takes an optional trailing slash after the optional .git, matching the URL form.
…ager tip The tip compared the owner-stripped query against a fixed list of spellings, so comfyui_manager, "ComfyUI Manager", comfyui-manager.git and ltdrdata/ComfyUI-Manager/ missed it. The query is now lowercased, owner-stripped, cleared of a trailing .git and slashes, and has each run of spaces, underscores and hyphens collapsed to one hyphen before it is compared with comfyui-manager and manager-comfyui.
When the tip moved from the empty state into a banner it stopped depending on what the content area shows, so on the Unresolved tab, or on a local tab after the search box was cleared, it could stay up over content that is not a registry search. It now also requires isSearchBacked.
- Shorten descriptions by code point, so a cut never splits a surrogate pair. - Fail with "Missing response for query X" when the index answers fewer queries than were sent, and with a count when it answers more, instead of zipping in undefined. - Key recorded responses by a Map, so a rewrite named like an Object.prototype key is not mistaken for one already recorded. - Resolve FIXTURE_PATH from the script's own URL, so the recorder writes the fixture whatever directory it runs from.
This comment has been minimized.
This comment has been minimized.
benceruleanlu
left a comment
There was a problem hiding this comment.
This review was performed agentically. Ben will be notified to review manually soon.
Review details
Original Claude reviewer output, captured before publication:
I reviewed PR #21133, "fix: tighten legacy-manager tip and tag pack-search rewrites" (+536/−184 across 13 files). The idea is sound: the tip now follows the query whose results are on screen instead of the text in the search box. But there are a few correctness gaps, and none of the dialog wiring has tests. I checked findings 1 and 4 in the code myself; the rest come from the review and I didn't re-check them. Nothing has been posted to GitHub.
Should fix
-
The "Looking for ComfyUI-Manager?" tip can show for a search the user already cleared (
ManagerDialog.vue:385,utils/pagedList.ts:150).- What happens: type
comfyui-manager, then clear the box while that search is still running. The new empty search is silently dropped, becausepreempthands back the promise of the search already running instead of queuing the new one. The old search then finishes and setssearchedQuery='comfyui-manager'andrawResultsEmpty=true. - Result: the tip sits over an empty search box. Before this PR the tip read the live box (
'') and stayed hidden. - Fix: the queue bug is older than this PR, but the PR makes it visible. Make
preemptschedule the latest runner instead of returning the stale promise.
- What happens: type
-
Filtered tabs lost their way to show the tip (
ManagerDialog.vue:472). The PR removed the tip fromemptyStateMessage, which was the only path that worked withoutrawResultsEmpty. On tabs like Installed, Updates or Missing, a ComfyUI-Manager search can return results from the search service that the tab filter then hides. In that case the user now sees only "Try a different search". Every tip test stubsrawResultsEmpty=true, so no test covers this. -
The analytics tag can't separate user searches from rewrites (
algoliaSearchProvider.ts:55). Only the rewrite requests get therewritetag. As far as I know, Algolia's tag filters can't exclude a tag, so the queries users actually typed can't be selected on their own. Give the raw query a positive tag too (e.g.['user']). -
A pasted
repo.gitkeeps.gitin its rewrite (searchQueryUtil.ts:32).buildPackSearchFallbacks('ComfyUI-KJNodes.git')returns['ComfyUI KJNodes.git'], so the search also needs a match for "git" and the fallback likely returns nothing. The tip code strips.gitfrom the same input, but the search path doesn't. -
No tests for the dialog changes (
ManagerDialog.vue:385). Any of these would still pass every test, so all three of the PR's fixes could regress silently:- going back to the live
searchQuery - dropping the
isSearchBackedargument - adding the tip back to the empty-state message
- going back to the live
Worth addressing
-
Some spellings of ComfyUI-Manager miss the tip (
useLegacySearchTip.ts:16). The owner is removed before trailing.gitand slashes are cleaned up, and separators at the ends aren't trimmed. Soltdrdata/ComfyUI-Manager//,comfyui-manager-and_comfyui_managernever match. -
rewriteQueryreplaces the caller'sanalyticsTagsinstead of merging with them (algoliaSearchProvider.ts:139). The raw request keeps the caller's tag and the rewrites lose it. -
One result is tracked in two pieces of state (
useRegistrySearch.ts:56).reloadresetsrawResultsEmptybut notsearchedQuery, and a failed first page updates neither. A single{ query, rawResultsEmpty } | nullvalue set once per first page would prevent them from disagreeing. -
The test fixture claims more pages than it has (
record-algolia-nodes-fixture.ts:95). It stores the search service's total hit count but only one page of hits. Forqwen3that means 138 total but 64 stored, so a replay reports 3 pages and page 1 comes back empty.
Cleanups
- Duplicated separator rule:
WORD_SEPARATOR_RUNcopiesWORD_SEPARATORSandsplitOnSeparators. ReusingsplitOnSeparatorswould also fix the edge cases in finding 6. - Repo-name cleanup lives in two places: stripping
.git, slashes and the owner happens separately for the search and for the tip. OnetoRepoName()helper insearchQueryUtil, used by both, would fix findings 4 and 6 together. - The tip helper is now just an AND of four positional refs: three of them are adjacent booleans, so swapping two at the call site still compiles and passes. A plain
isLegacyManagerQueryfunction inside the dialog's own computed would be simpler. - The recorder builds its own request: it doesn't reuse the provider's
packQuery, so re-recorded fixtures can drift from what production sends. TheRecordedResponsetype is also declared twice. - A hidden test default decides every result: in
useLegacySearchTip.test.ts, thetipForhelper defaultsrawResultsEmpty=true, and that default decides every row's expected outcome. The repo's testing guidance says not to hide those values.
I'd focus on 1, 2 and 5 first; 4 and 6 are cheap to fix together via the shared helper. I can post these as inline PR comments if you want.
Reviewed head: ccf15ada423a2a756a10f6aa5af40376b1a40bbe
Original reviewed base: 8bdadd52e74507f2d5da7ed259213c4e6ca60c07
Accepted current base: 24f12506902f88a572976292ade7405d52bc8143
Base reuse: the effective PR diff is byte-for-byte identical (SHA-256 f19da5e9cf13ed6bf90dd2df1c1ac43949f7f65ff8a9f3ed54ba4fac3ae03ef7). The intervening #21114 changes only the unrelated WidgetLegacy component and its test.
Validation: the Claude process exited 0. Its recorded unit-test run passed 6 files and 172 tests. Reviewer classifications and stated verification limits are retained above; no explicit Blocking section was supplied.
… name
buildPackSearchFallbacks('ComfyUI-KJNodes.git') kept the suffix, so the
rewrite still required a match for "git". toRepoName drops a trailing
.git and any trailing slashes before removing the owner, and the search
rewrites now use it.
Algolia analytics can filter on a tag but not exclude one, so only tagging rewrites left the queries users typed impossible to select on their own. The typed query now carries a user tag, and both it and its rewrites append to the caller's analyticsTags instead of replacing them.
- Track the first page as one { query, rawResultsEmpty } value that a
reload or a failed first page clears, instead of two refs that could
disagree.
- Show the tip only while that page's query matches the search box, so a
search the user already cleared cannot raise it after it returns.
- Also show it when a search-backed tab hides every registry hit, as on
Installed, which lost the tip when it left the empty-state message.
- Match ComfyUI-Manager after stripping a trailing .git and slashes and
trimming separators, reusing the shared query helpers.
- Cover the dialog wiring with component tests.
benceruleanlu
left a comment
There was a problem hiding this comment.
This review was performed agentically. Ben will be notified to review manually soon.
Review details
I found no blocking bugs in PR #21133, and it's close to mergeable. Every correctness finding from your previous review (at ccf15ada42) and from the Cursor panel has been fixed in the five newer commits. What's left is one analytics-accuracy issue, an out-of-date PR description, and two small cleanups.
I ran the 7 changed test files locally at head 7639d37: 197 tests pass, and CI is green (109 pass, 21 skipped).
Worth fixing
-
The
usertag also covers searches nobody typed (algoliaSearchProvider.ts:168). Every main search request from the manager dialog getsuser, including:- the empty-query listing sent when the dialog opens;
- every infinite-scroll page;
- the deep-link search that opens the dialog on a pack id (
ErrorGroupList.vue:891,MissingPackGroupRow.vue:148). That id goes into the search box (ManagerDialog.vue:357) and runs as a normal search.
The commit says "tag typed pack searches as user", but filtering Algolia analytics by
userwill also count deep-link lookups. The fix is to let the caller decide the tag, for example only tagging requests that started from typing. The tag-merging code added in this PR already supports that, and nothing passesanalyticsTagstoday. -
The PR description no longer matches the code. It still describes:
useLegacySearchTip, which is deleted;LEGACY_MANAGER_QUERIES,searchedQuery,rewriteQueryandREWRITE_ANALYTICS_TAGS, which have been renamed or reworked;- "the raw query stays untagged", but it is now tagged
user; - the tip depending only on
rawResultsEmpty, but it now also shows when a filtered tab ends up empty (ManagerDialog.vue:422); - the recorder sending "the provider's packs-mode request", but it builds its own (see 4);
- the 971-test verification count, which comes from an earlier commit.
Cleanups
-
The
.git/trailing-slash handling is in two places, and they disagree (searchQueryUtil.ts:6).toRepoNamestrips trailing.gitand slashes before it callsstripRepoOwner, and nothing else in production callsstripRepoOwner. So the new(?:\.git)?\/?inBARE_COMPOUND_REPO_SLUGonly matters for odd inputs likeowner/repo/.git. The tests also contradict each other:stripRepoOwneris expected to leavekijai/comfyui-kjnodes//unchanged (searchQueryUtil.test.ts:114), whiletoRepoNamestrips both slashes (:128). I'd revert the regex to the base version, makestripRepoOwnermodule-private, and keep its test cases undertoRepoName. -
The recorder still builds its own request (
record-algolia-nodes-fixture.ts:129). This was a cleanup item in your earlier review and is still open. IfpackQuerylater gains a parameter that changes ranking, re-recorded fixtures won't reflect it. If they'd rather not share the code, at least correct the description.
Note, not blocking
The old queue bug the PR declares out of scope is still there: a new search is dropped while another is in flight (usePreemptableQueue). The new check that the shown results match the text in the search box hides the tip correctly when that happens. The grid can still show results for an older query, though, so it's worth a follow-up issue.
Status of your earlier findings
| Finding | Status |
|---|---|
| 1. Tip shows after clearing the search box | Fixed. The tip now requires the shown results' query to equal the text in the box, with a test for it. |
| 2. Filtered tabs lost the tip | Fixed with displayPacks.length === 0, tested on the Installed tab. |
| 3. Analytics needs a positive tag | Added user, but it covers too much (see 1 above). |
4. A pasted repo.git keeps .git in its rewrite |
Fixed via toRepoName. |
| 5. No dialog tests | Fixed: ManagerDialog.test.ts has 7 cases covering the regressions you listed. |
| 6. Some spellings of ComfyUI-Manager miss the tip | Fixed, with a 37-case test table. |
| 7. Rewrites replace the caller's tags | Fixed; tags are merged now. |
| 8. One result tracked in two pieces of state | Fixed: a single firstPage value. |
| 9. Fixture claims more pages than it has | Fixed: replaying a page that was never recorded now throws. |
| Cleanups | All done except the recorder building its own request (4 above). |
I haven't posted anything to GitHub. Want me to post these as inline comments on the PR?
Reviewed head: 7639d37c0240b79e8f14ca2131b43dd5cdbf1835
Original reviewed base: f2c829248b7ef405a69132eeb7a1593d88cd03df
Accepted current base: d6b5605efe1608a4e5b436464144ec8907210307
Base reuse: Base advanced from f2c8292 to d6b5605 via #19981 (agent ask-user UI) and #21116 (billing can_top_up). The effective PR diff is byte-for-byte identical, SHA-256 ac605163133dcd115dc9952a15c9f65a321d2f110ef8f9d4b8501fb52c098087. The base changes do not touch reviewed manager search/provider/recorder code; the shared English locale changes are unrelated agent/billing keys. No material effect on the reviewed changes or findings.
Validation: the fresh Claude process exited 0. Its original classifications and validation statements are preserved above. No explicit Blocking section was supplied; all findings remain inside this details block.
The provider no longer adds the user tag to every request. The manager dialog passes it for the first page of a non-empty query the user typed, so the opening listing, later pages and the deep-link pack search stay untagged. Rewrites keep the caller's tags and add rewrite.
Revert the bare-slug pattern so the suffix is handled in one place, make stripRepoOwner private and test its cases through toRepoName.
…ilder Move the nodes_index pack request into a shared buildPackSearchRequest with no runtime imports. The provider and the recorder both use it, and the recorder overrides only analytics and the retrieved attributes, so ranking parameters cannot drift between them.
Keeps doLoadMore under the fallow complexity limit.
benceruleanlu
left a comment
There was a problem hiding this comment.
This review was performed agentically. Ben will be notified to review manually soon.
Review details
Detailed Claude findings
The detailed skill result referenced by the final reviewer summary is reproduced below with its original wording. The pre-existing queue finding was omitted as directed by the final reviewer report. No severity has been added.
1. src/services/providers/algoliaPackSearchRequest.ts:52
Rewrite requests keep the caller's analyticsTags and add 'rewrite' on top, so every fallback for a typed search is also tagged 'user'. That puts the rewrites back into the 'user' analytics segment the PR is trying to keep clean.
The user types 'kijai/comfyui-kjnodes' and the raw query gets 0 hits. Algolia then receives the raw query tagged ['user'] plus 2 rewrites tagged ['user','rewrite']. A dashboard filtered on tag 'user' counts 3 searches instead of 1, and zero-hit rewrites push the no-results rate up. Algolia analytics tag filters only combine tags with AND/OR, so the 'user' view cannot exclude 'rewrite'. Tagging rewrites with only 'rewrite' would keep the user segment clean.
2. src/workbench/extensions/manager/components/manager/ManagerDialog.vue:432
The tip depends on rawResultsEmpty, which describes the raw query only. An owner/repo slug or GitHub URL never matches as typed, so for those forms the tip shows even when the rewrite found ComfyUI-Manager and it is displayed right below.
Searching 'comfyui-manager' returns the registry's ComfyUI-Manager pack with no tip. Pasting 'https://github.com/ltdrdata/ComfyUI-Manager' or 'ltdrdata/ComfyUI-Manager' gets 0 raw hits, and the fallback 'ComfyUI-Manager' shows the same pack. The tip 'Looking for ComfyUI-Manager? start with --enable-manager-legacy-ui' then renders above the pack the user found. Same results, different banner, depending only on how the name was typed.
3. src/workbench/extensions/manager/components/manager/ManagerDialog.vue:432
displayPacks.value.length === 0 is also true while the installed list is still loading, when the manager API errored, and when a paged filtered tab has more pages to fetch. The tip flashes in all of these cases, which goes against the PR's no-flash goal.
The user opens the All Installed tab and searches 'comfyui-manager'. comfyManagerStore.installedPacksIds is still empty, so filterInstalledPack(results) returns [] and the tip shows above the skeleton. It disappears once the installed list loads and matching packs appear. The same happens on Not Installed when page 1 is fully filtered out but hasMore is true and page 2 has packs. With a manager connection error, the tip shows next to 'Error connecting'.
4. src/workbench/extensions/manager/composables/useRegistrySearch.ts:109
The tip check compares trimmed queries, but useRegistrySearch reloads on the raw, untrimmed debounced query. A whitespace-only edit therefore clears firstPage, hides the tip and sends another search tagged 'user'.
The tip is showing for 'comfyui-manager' and the user types a trailing space. 320ms later the debounced value changes to 'comfyui-manager ', reload() sets firstPage to null and the tip disappears during the request, then comes back. Algolia also logs a second page-0 search tagged ['user'] for what is effectively the same query, under a different cache key.
5. src/utils/searchQueryUtil.ts:24
toRepoName now removes trailing slashes from any query. Every zero-hit query that ends in '/' therefore gets a rewrite that differs only by the slash, which Algolia tokenizes the same way, so the extra request is wasted.
The user searches 'image/upscaling/' or 'https://github.com/kijai/' and gets 0 hits. buildPackSearchFallbacks returns ['image/upscaling'] or ['https://github.com/kijai'], since collapseWhitespace(candidate) differs from the raw query. Algolia receives another request tagged 'rewrite' (and 'user') that cannot match anything the raw query missed.
6. src/workbench/extensions/manager/components/manager/ManagerDialog.vue:386
isTypedQuery latches true on the first change to searchQuery and never resets. Later page-0 reloads are tagged 'user' even when the query in the box is still the untyped opening one.
The dialog opens with the restored query 'gguf'. The user types 'x' and deletes it within 320ms, so the debounced query never changes and the flag is now true. Switching the mode to Nodes and back re-runs 'gguf' tagged ['user'] each time. That inflates user-search counts for a query the user never typed in this session.
7. src/services/providers/algoliaSearchProvider.integration.test.ts:24
The replay guard uses request.query in responses, and so does the recorder test's indexFrom. in also sees inherited Object.prototype keys, even though the recorder explicitly supports recording such keys.
A rewrite or seed named 'constructor' or 'toString' (the recorder test already records '-constructor' → 'constructor') passes the in check even when it was never recorded. responses[query].hits then reads undefined from a function and crashes with a TypeError instead of the 'No recorded Algolia response' message. Object.hasOwn(responses, query) would fix it.
8. src/services/providers/algoliaSearchProvider.integration.test.ts:34
The new 'unrecorded page' guard only rejects pages that start at or past the recorded hits. A page that straddles the recorded boundary quietly returns a truncated slice.
A test requests qwen3 (64 of 138 hits recorded) with pageSize 50, page 1. pageStart = 50 < 64, so no error is thrown, and replay returns 14 hits with nbPages 3 as if they were a real page of 50. The guard should check pageStart + hitsPerPage > recordedHits.length && recordedHits.length < nbHits.
9. src/workbench/extensions/manager/components/manager/ManagerDialog.vue:374
The PR adds a code comment, which AGENTS.md forbids.
AGENTS.md: 'NEVER add code comments. No // lines, no /* */ blocks...'. The added line is // The opening query (a deep link or the restored one) was not typed now. The rationale belongs in the commit message or PR description, or the variable name should carry it.
10. src/services/providers/algoliaPackSearchRequest.ts:39
The exported JSDoc explains why the code is shaped this way, which AGENTS.md does not allow in JSDoc.
AGENTS.md: JSDoc on an exported API 'does not narrate the implementation, give a history or rationale, list the alternatives'. The JSDoc says 'Kept free of runtime imports so the fixture recorder script can send the same request.', which is rationale. It belongs in the commit message or an ADR.
11. src/workbench/extensions/manager/components/manager/ManagerDialog.vue:376
A watch writes hasEditedSearchQuery, and useRegistrySearch's reload effect reads it. That is the effect-chain pattern the state guidance lists as bad; an input event handler would be simpler.
docs/guidance/state-and-effects.md §5 lists as a bad effect 'an effect that writes state a second effect reads', and AGENTS.md says to prefer 'a computed to a watch'. An @update:model-value handler on SearchAutocomplete, which only fires on user input, would set the flag without a watch and without depending on effect ordering.
12. src/services/providers/algoliaSearchProvider.ts:184
analyticsTags now goes into the LRU cache key, because paramsToCacheKey includes every param. The same results are cached twice and identical queries miss the cache.
A deep-link search for 'comfyui-kjnodes' is cached without tags. The user then types the same query and gets a cache miss on 'analyticsTags:user&...', so an identical Algolia request is sent and a second entry fills the 64-slot cache. In the other direction, a cache hit sends no request at all, so a re-typed query is never logged as a 'user' search.
13. src/services/providers/algoliaPackSearchRequest.ts:8
PACK_SEARCHABLE_ATTRIBUTES is a mutable exported array shared by reference by every request and cache key, where each call used to get a fresh literal. It also makes the provider-agnostic useRegistrySearch import from an Algolia-specific provider module.
Every searchPacks call from useRegistrySearch passes the same array instance as restrictSearchableAttributes. Any consumer that sorts or pushes onto it changes all future pack searches and cache keys. The gateway can also route to the ComfyRegistry provider, yet the workbench composable is now coupled to the Algolia request builder module.
14. src/workbench/extensions/manager/components/manager/ManagerDialog.test.ts:71
The test hard-codes SEARCH_DEBOUNCE_MS = 320, copying the component's private constant.
If the component's debounce is raised, say to 400ms, settleSearch() advances only 320ms. The search never fires, and tests asserting the tip is hidden keep passing for the wrong reason while tests asserting it shows fail. Exporting the constant or advancing timers until the search call settles would avoid this.
Final Claude reviewer summary
I reviewed PR #21133 and found 14 issues. I checked each one against the code, and the list above has the details. I haven't posted anything to GitHub.
The three that matter most:
- The tip depends on how the name was typed. It checks whether the search as typed found nothing.
comfyui-managergets hits that way, so no tip.ltdrdata/ComfyUI-Manageror the GitHub URL never matches as typed, so the tip shows even when the rewrite fills the grid with the same packs. - The tip can still flash. It isn't held back while the installed list is loading. On filtered tabs (Installed, Not Installed), it can briefly show above the loading skeleton.
- Rewrites are also tagged
user. They getuserplusrewrite. Algolia's analytics tag filter only supports AND/OR, so a dashboard filtered onuserstill counts every rewrite. #14732's review asked to keep those apart.
The rest are smaller:
- Edge cases in when a search gets tagged
user. analyticsTagsnow splits the search cache key.- Queries ending in
/get a rewrite that can't find anything new. - Two gaps in how the test fixtures replay recorded searches.
- One added
//comment and one JSDoc that gives a reason; AGENTS.md bans both.
I left out one point the review raised: a new search gets dropped while an older one is still loading. That bug predates this PR, and the author already lists it as a follow-up. It still deserves its own issue, because the grid can keep showing results for an older query.
I can post these as inline PR comments if you want.
Reviewed head: 4e650f3b24aae946aa44ba03bd7f622651c9c929
Reviewed base: 61eca01a973ae0545243f7d084f7156c930add5b
Validation: the fresh Claude process exited 0. No local test run was recorded for this revision. The findings and final reviewer summary above retain the reviewer's wording; no explicit Blocking section was supplied, so all review content remains inside details.
A rewrite tagged user and rewrite was still counted in the user segment, and Algolia analytics cannot exclude a tag from a filter. Rewrites now drop user, keep any other caller tags and add rewrite.
The same query searched with and without tags returns the same results, so it now shares one cache entry instead of sending a second request.
Algolia tokenizes image/upscaling/ and image/upscaling the same way, so that rewrite could not find anything the raw query missed. Candidates are now compared to the query with trailing slashes removed. Owner stripping still rewrites kijai/comfyui-kjnodes/ to comfyui-kjnodes.
A trailing space reloaded the search, hid the legacy-manager tip during the request and sent another page-0 search tagged user under a new cache key. The query is now trimmed before it drives the reload, the request and the analytics tag.
… tab is still settling A pasted ltdrdata/ComfyUI-Manager slug or GitHub URL gets no raw hits, so the tip showed above the ComfyUI-Manager pack its rewrite found. The tip now stays hidden while the shown results include that pack. An empty filtered tab also showed the tip while the installed packs were loading, next to a manager connection error, or before later pages that could still hold matches. That path now waits until the tab is loaded, has no manager error and has no more pages.
…ng query The typed flag latched on the first keystroke, so an edit undone before it searched still tagged later reloads of the deep-link or restored query as user. The flag is now derived from the searched query, which also drops the watch that fed it and its code comment. The opening query is not typed in this session, so it stays untagged.
…onstant Every pack search passed the same mutable array, and the workbench search composable imported it from the Algolia request module. It now lives in searchConstants as a readonly list that each request copies. The request builder's JSDoc keeps only its contract.
The replay and regeneration lookups used the in operator, so an unrecorded query named like an Object.prototype key passed the guard and crashed. They now check own keys. Replay also refuses a page that runs past the recorded hits instead of returning a truncated slice.
The test copied the dialog's 320ms debounce, so raising it would let the tip-hidden tests pass without a search ever running. Settling now runs whatever timers are pending, whatever the debounce is.
benceruleanlu
left a comment
There was a problem hiding this comment.
This review was performed agentically. Ben will be notified to review manually soon.
Review details
Detailed Claude findings
The detailed skill result referenced by the final reviewer summary is reproduced below with its original wording. The final report states that only correctness findings 1 and 3 were independently rechecked by the parent reviewer; that qualification is retained below. No severity has been added.
1. src/workbench/extensions/manager/composables/useRegistrySearch.ts:83
firstPage records only the query, not the search mode. The tip's stale-result guard (firstPage.query === searchQuery.trim() in ManagerDialog.vue:507) therefore can't tell when the page on screen came from the other mode.
The user searches 'comfyui-manager' in Nodes mode, and while that request is in flight switches to Packs. usePreemptableQueue.preempt sees queue[0] is a running PREEMPT and drops the new reload. The nodes-mode page lands with rawResultsEmpty: true and its query still equals the search box, so the guard passes. The legacy tip shows, and the grid shows node results, while the selector says Packs. A Packs search may well have found the ComfyUI-Manager pack. The PR says stale results keep the tip hidden, but that only holds when the query changed.
2. src/workbench/extensions/manager/composables/useRegistrySearch.ts:91
doLoadMore (edited by this PR) catches every search failure, logs it with console.error only, and sets morePages = false. The outage is never sent through reportError and the user sees it as an empty result.
When every search provider fails, the gateway throws 'All search providers failed'. The error is caught here, items stay [] and firstPage stays null. ManagerDialog then shows 'No results found / Try a different search', so a backend outage looks like a bad query and never reaches telemetry. src/AGENTS.md says: 'Report failures with reportError()'.
3. src/utils/searchQueryUtil.ts:26
toRepoName (and toComparableQuery at line 34) trims before stripping trailing slashes, so whitespace before the slash is left behind. That trailing space stops the anchored owner regex from matching and gets past the 'only drops a trailing slash' filter.
Checked by running it: 'kijai/comfyui-kjnodes /' gives toRepoName 'kijai/comfyui-kjnodes ' (owner kept) and rewrites ['kijai/comfyui-kjnodes ', 'kijai/comfyui kjnodes']. 'comfyui-kjnodes /' sends a rewrite 'comfyui-kjnodes ' that differs from the query only by the slash. isLegacyManagerQuery('ltdrdata/ComfyUI-Manager /') returns false, so the tip is missed. Trimming again after the strip fixes all three.
4. src/services/providers/algoliaSearchProvider.ts:197
Because analyticsTags is left out of the cache key, a typed search whose result is already cached from an untagged request sends no request at all, so the 'user' tag never reaches Algolia.
The dialog opens with the restored query 'gguf', which is searched untagged and cached. The user clears the box and later types 'gguf2', then 'gguf' again, or toggles mode and back. Each cached query gets no request, so typed searches go uncounted in the 'user' analytics segment. The PR description admits this only for a search typed back to exactly the opening query; it also affects any cached query, including within the 64-entry LRU across dialog reopenings.
5. src/workbench/extensions/manager/components/manager/ManagerDialog.vue:494
The isSettledWithNoPacks branch shows the legacy-manager tip on every tab that filters search results: Update Available, Conflicting, Workflow and Missing, not just Installed. It shows even when the registry did return the ComfyUI-Manager pack.
On the Missing or Update Available tab, a search for 'comfyui-manager' returns the pack from the registry (rawResultsEmpty false), but filterWorkflowPack or filterOutdated removes it. displayPacks is empty and settled, so the banner tells the user to restart with --enable-manager-legacy-ui, when they were only checking whether that pack is missing or outdated.
6. src/services/providers/algoliaPackSearchRequest.ts:8
The RETRIEVE_ATTRIBUTES list, moved here unchanged, leaves out 'category', 'author' and 'tags', yet toRegistryPack maps algoliaNode.category, .author and .tags.
Algolia returns only the attributes listed in attributesToRetrieve, so every pack from an Algolia search has category, author and tags undefined until getPackById merges the full record on selection. The extraction kept this pre-existing gap instead of fixing it.
7. src/workbench/extensions/manager/components/manager/ManagerDialog.vue:507
Altitude: comparing firstPage.query with the search box works around usePreemptableQueue.preempt dropping a new reload while another preempt is running, rather than fixing the queue.
The guard hides the tip, but the grid keeps showing results for an older query or mode with nothing in flight to replace them. It also misses mode switches (first finding). If preempt remembered a pending follow-up and ran it after the active one, the stale-grid bug would be fixed and the query-equality guard and firstPage.query could be removed.
8. src/workbench/extensions/manager/components/manager/ManagerDialog.vue:379
Altitude: isTypedQuery guesses whether the user typed by comparing the debounced text with the opening query, instead of using the input event (an edit from SearchAutocomplete).
The dialog opens with the restored query 'gguf'. The user clears the box and deliberately types 'gguf' again: the search goes out untagged. Toggling search mode on an edited query tags the re-search 'user' again. Setting a 'user edited' flag from the input's update event would give the real signal without special cases tied to the opening query.
9. src/workbench/extensions/manager/components/manager/ManagerDialog.test.ts:30
This new test file declares vi.mock<unknown>(import('@/workbench/extensions/manager/services/comfyManagerService'), ...), which skips type-checking of the mock factory.
Breaks docs/guidance/vitest.md (loaded via AGENTS.md): 'vi.mock<unknown>(import('…'), …) is only for legacy partial factories that cannot satisfy the module type. For new mocks, type the factory instead.' The partial service object (listInstalledPacks, isLoading, error) can drift from the real service without a compile error.
10. src/workbench/extensions/manager/components/manager/ManagerDialog.test.ts:305
The mock factories hold module-level refs (useInstalledPacks().isLoading, useComfyManagerService().error, useWorkflowPacks().unresolvedNodeNames). Each test mutates them and registers its own restore, instead of the mock registering it.
Breaks docs/guidance/vitest.md: 'Register the restore with onTestFinished inside the mock function, so every test that touches the mock cleans up after itself' and 'Keep module mocks contained - no global mutable state'. A future test that sets isLoading.value = true without its own onTestFinished leaks that loading state into later tests.
11. src/services/providers/algoliaSearchProvider.ts:197
Reuse: removing analyticsTags by destructuring into an unused _analyticsTags binding re-implements omit. This same PR just deleted this file's omit import from es-toolkit.
The unused-binding workaround relies on the lint rule's underscore exemption and is less clear than paramsToCacheKey({ query, ...omit(params, ['analyticsTags']) }), which the repo already uses ('Use es-toolkit for utility functions').
12. src/workbench/extensions/manager/components/manager/ManagerDialog.vue:494
Simplification: isSettledWithNoPacks re-derives the template's empty-state condition (displayPacks.length === 0 && !canLoadMorePacks, after isLoading and isUnresolvedTab), and the two have already drifted apart.
One uses hasMorePacks and the other canLoadMorePacks, and only the computed checks isManagerErrorRelevant. So 'empty state shown' and 'tip shown on empty' can disagree, for example during a search load on a non-search-backed path. A single isShowingEmptyState computed used by both places would keep them in sync.
13. src/services/providers/algoliaSearchProvider.ts:122
Efficiency: toRewriteParams(params) runs inside fallbackQueries.map(...), so it rebuilds the same params object and filtered tag array for every fallback query.
Each rewrite request allocates a new params spread and tag array with identical contents. Computing const rewriteParams = toRewriteParams(params) once before the map does the same work once.
14. scripts/record-algolia-nodes-fixture.ts:57
Simplification: the recorded hit shape is listed three times: RecordedHit in __fixtures__/algoliaNodesIndexFixture.ts, the RetrievedHit Pick list, and the RECORDED_ATTRIBUTES array.
Adding a replayed field means editing three parallel lists in two files. If one is missed, the recorder silently writes defaults ('' or 0) for the field, or the type and the request disagree. Deriving RetrievedHit and RecordedHit from one RECORDED_ATTRIBUTES const tuple removes the duplication.
Final Claude reviewer summary
I reviewed PR #21133 and found 14 issues; the list above has the full details. Five are correctness bugs, and the rest are test-convention and code-cleanup problems. I checked the first and third against the code myself; the others come from the review pass and I didn't re-check each one. Nothing was posted to the PR.
Correctness bugs:
- Wrong tip after switching search mode. If you switch from Nodes to Packs while a search is still loading, the new search gets dropped (
src/utils/pagedList.ts:150). The old Nodes results still match the search box, becausefirstPagesaves the query but not the mode. So the legacy-manager tip and the Nodes results show while the selector says Packs. - Search outages look like "No results found".
doLoadMoreonly logs errors to the console, so a backend failure never reachesreportErrorand the user sees an empty result. - Space before a trailing slash breaks matching.
toRepoNameandtoComparableQuerytrim whitespace before stripping trailing slashes. Soltdrdata/ComfyUI-Manager /misses the tip, and queries likekijai/comfyui-kjnodes /produce bad rewrites. Trimming again after the strip fixes it. - Typed searches lose the
usertag when cached. The Algolia cache key ignoresanalyticsTags, so a typed search that's already cached sends no request. The PR description mentions this only for retyping the opening query, but it applies to any query in the 64-entry cache. - Tip shows when the pack was found. On the Update Available, Conflicting, Workflow and Missing tabs, the tip appears even when the search found the ComfyUI-Manager pack but the tab's filter hid it.
Worth raising with the author: the query-equality check that hides the tip works around preempt dropping a new search while one is still loading. Making preempt run the newer search once the current one finishes would fix the stale results directly, including bug 1, and the check could be removed.
Smaller items:
RETRIEVE_ATTRIBUTESleaves outcategory,authorandtags. This predates the PR, but the PR moved that code without fixing it.ManagerDialog.test.tsdoesn't follow the repo's test guidelines: one mock is declared withvi.mock<unknown>, and each test restores shared mock state itself instead of the mock doing it.- The rest are cleanups:
- Use
omitinstead of the unused_analyticsTagsbinding. - The "no results" condition is written twice and the copies have already drifted apart.
toRewriteParamsis recomputed for every fallback query.- The recorded hit shape is declared three times.
- Use
Reviewed head: 384d650750c8a51ee5fb20c94bafb98ef0568f16
Reviewed base: 61eca01a973ae0545243f7d084f7156c930add5b
Validation: the fresh Claude process exited 0. Original classifications and verification limits are preserved above. No explicit Blocking section was supplied, so all review content remains inside details.
benceruleanlu
left a comment
There was a problem hiding this comment.
Approving at 384d650. Every finding from the Cursor panel and the three earlier review rounds is addressed in later commits, and CI is green.
I checked the head against the live nodes_index, using the PR's own buildPackSearchRequest, buildPackSearchFallbacks and isLegacyManagerQuery with analytics off. These results are for the All tab:
| Query | Raw hits | Shown | Tip before | Tip now |
|---|---|---|---|---|
comfyui-manager |
6 | comfyui-manager first | no | no |
ltdrdata/ComfyUI-Manager |
0 | rewrite finds comfyui-manager | yes | no |
https://github.com/ltdrdata/ComfyUI-Manager |
0 | rewrite finds comfyui-manager | yes | no |
willmiao/comfyui-lora-manager |
0 | rewrite finds comfyui-lora-manager | yes | no |
The original bug is fixed. A pasted slug or URL no longer shows the tip above the pack it found.
No further review rounds from me on this one. The dropped-search issue in usePreemptableQueue predates this PR and should get its own issue.
Generated by Claude Code
Conflict in algoliaSearchProvider.ts imports: main (#21133) dropped omit, leaving only memoize from es-toolkit/compat. This branch removes the memo, so the resolution drops that import line entirely.
…and search edge cases (Comfy-Org#21154) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C08F7K6JTDF/p1785867068886719?thread_ts=1785867068.886719&cid=C08F7K6JTDF)_ ## Summary Follow-up to Comfy-Org#21133: Manager pack search now shows failures instead of empty results, and the "Looking for ComfyUI-Manager?" tip and query rewrites handle more edge cases. - Before: offline, the registry fallback turned a failed search into "No results found", kept old suggestions, could show the tip, and an empty opening listing left the skeleton up forever. Switching mode or query mid-load could show the old mode's results and tip. `owner/repo /` queries rewrote badly, and a long pasted slug took about 1 s. - After: a failed search shows "Error connecting to the Comfy Node Registry" with Retry and is reported once per outage. The results and the tip reflect only the current query and mode. The skeleton shows only while the first page loads. Trailing ` /` is stripped, and long slugs are matched in linear time. How: providers return `{ ok: true, result } | { ok: false, cause }` instead of throwing; the registry provider fails on a null or malformed response and evicts that cache entry, and Algolia also fails on a malformed response, so the gateway falls back to the registry. When every provider fails, the cause is an `AggregateError` of each provider's error. The gateway tries each provider once per search, pins later pages to the provider of page one, and exposes `resetCircuits()` for Retry. `useRegistrySearch` tracks a request generation, drops stale responses and reruns for the current inputs, and exposes the first page as loading, failed or loaded. Known limitations: - In-flight requests are not aborted; the new search waits for the stale one. - A failed later page ends the list with no message or retry. - Typed searches respect an open circuit for a minute; only Retry resets it. - A hidden-tab listing failure is not reported, even after switching to a tab that shows it. - The reported registry error can fall back to a generic message if another request starts first. - `useCachedRequest` still caches failures as `null` for its other callers. - After one Algolia failure, later searches go to the registry first until Retry or a registry failure. - A cached success clears the report limit, so switching between cached and failing queries while offline reports each failure. - `analyticsTags` are not in the cache key, so a cached repeat logs no analytics event. ## Verification Unit and integration tests cover each fix (each red without it), including a real gateway, providers and registry service over a mocked axios adapter. `pnpm typecheck`, lint and `oxfmt --check` pass; the 10 touched test files pass (298 tests). --------- Co-authored-by: Claude <noreply@anthropic.com>
Requested by Christian Byrne · Slack thread
Summary
Follow-up to #14732, addressing the review on that PR by @benceruleanlu.
Before: pasting
willmiao/comfyui-lora-managershowed the "Looking for ComfyUI-Manager? start with --enable-manager-legacy-ui" banner above the correct pack, because any query containing "manager" counted. The banner could flash while typing, and it appeared twice on empty results. In Algolia analytics, rewrite requests looked the same as real searches.After: the tip shows only for real ComfyUI-Manager searches, such as
comfyui-manager,Comfy-Org/ComfyUI-Manageror its GitHub URL. It shows when that search found nothing in the registry, or when the current tab filters every result away (for example Installed) once that tab has loaded, has no manager error and has no more pages to fetch. It stays hidden while the ComfyUI-Manager pack itself is shown, for example after a pasted slug or GitHub URL was rewritten to it. It only shows for the search whose results are on screen, and it renders once, as the banner. In analytics, a search the user typed is taggeduser, and rewrite requests are taggedrewriteinstead ofuser. The listing shown on open, infinite-scroll pages and the deep-link or restored search are not taggeduser, and adding a trailing space sends no new search. A pastedowner/repo.gitorowner/repo/now rewrites to the bare repo name, while a query that would only lose a trailing slash, such asimage/upscaling/, gets no rewrite.How:
isLegacyManagerQuery(manager/utils/legacyManagerQuery.ts) replacesuseLegacySearchTip. It reduces the query withtoRepoName, lowercases it, splits on separators, and matches it againstLEGACY_MANAGER_PACK_NAMES.useRegistrySearchexposesfirstPage, which holds{ query, rawResultsEmpty }for the first page on screen. It isnullwhile that page loads or after it failed. InManagerDialog.vue,isUnmatchedLegacyManagerSearchshows the tip only whenfirstPage.querymatches the trimmed search box and no shown pack has the ComfyUI-Manager id. On top of that, eitherrawResultsEmptyis set, ordisplayPacksis empty while the tab is not loading, has no manager error and has no more pages. The empty-state copy no longer appends the tip.useRegistrySearchsearches the trimmed query, takesisTypedQueryand passesanalyticsTags: ['user']for page 0 of a non-empty typed query.ManagerDialog.vuetreats the searched query as typed when it differs from the opening query (a deep link or the restored one), so the opening query stays untagged. Rewrite requests dropuser, keep any other caller tags and addrewrite. Analytics tags are left out of the provider's cache key.buildPackSearchRequest(services/providers/algoliaPackSearchRequest.ts) builds thenodes_indexpack request. It has no runtime imports, so the provider and the fixture recorder share it.PACK_SEARCHABLE_ATTRIBUTESis a readonly list inconstants/searchConstants.tsthat each request copies.toRepoNameinsearchQueryUtil.tstrims the query, drops a trailing.gitand slashes, then strips the owner or GitHub URL.buildPackSearchFallbacksuses it, and drops a candidate that equals the query once trailing slashes are removed. The owner-stripping helper is private now.scripts/record-algolia-nodes-fixture.tssendsbuildPackSearchRequestfor each seed inRECORDED_QUERIES, overriding onlyanalytics: falseand the attributes to retrieve. It records rewrites for seeds with no hits, then writes__fixtures__/algoliaNodesIndex.json. Its test regenerates the committed fixture from the same answers, so the two stay in step. Replaying a query or a page that was never fully recorded throws.Judgment call: bare
managerwas dropped from the tip keywords, since it matched too many unrelated packs. A search typed back to exactly the opening query is not taggeduser; it is usually served from the cache anyway.Out of scope / follow-up: in
usePreemptableQueue, a new search is dropped while another is in flight. This was already the case before this PR. The tip stays hidden correctly when it happens, because the shown results no longer match the search box. The grid can still show results for an older query, which needs its own fix.Verification
pnpm typecheck,pnpm typecheck:scripts, oxlint, eslint, knip andfallow auditpass.src/services,src/utils,src/workbench/extensions/managerand the recorder test, 2110 tests pass in 129 files.user; the empty listing, later pages and the deep-link search are untagged; rewrites getrewriteand the caller's tags other thanuser. The tip tests cover a rewritten ComfyUI-Manager slug or URL, a loading installed tab, a manager error and a tab with more pages. These tests failed before the change.analytics: false, so recording runs stay out of the dashboards.