Repository navigation
FE-3433 fix(workspace): gate Delete workspace on can_delete_workspace - #21117
Conversation
Render the Delete item from the server's can_delete_workspace and its denied reason in both the Plan & credits overflow and the Members panel menu, instead of deriving it from role, personal workspace and tier.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-15T20:43:36.016Z",
"gitSha": "9260b22bb17828de39df465d2d92dc3ac88ef863",
"branch": "dante01yoon/fe-3433-delete-from-capability",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.0290000000414,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6449999999999996,
"layouts": 9,
"layoutDurationMs": 2.7220000000000004,
"taskDurationMs": 487.3399999999999,
"heapDeltaBytes": 2465432,
"heapUsedBytes": 77634148,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 8.677000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.836999999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0829999999999997,
"layouts": 9,
"layoutDurationMs": 3.2509999999999994,
"taskDurationMs": 567.446,
"heapDeltaBytes": 3238828,
"heapUsedBytes": 78057376,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 13.329,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1722.537999999986,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.932,
"layouts": 9,
"layoutDurationMs": 2.9610000000000003,
"taskDurationMs": 689.23,
"heapDeltaBytes": 14986624,
"heapUsedBytes": 80358356,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 155.368,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1790.8040000000938,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.13,
"layouts": 9,
"layoutDurationMs": 2.623,
"taskDurationMs": 892.583,
"heapDeltaBytes": -8058144,
"heapUsedBytes": 67437860,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 168.7,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1696.0240000000226,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.195,
"layouts": 10,
"layoutDurationMs": 2.6260000000000003,
"taskDurationMs": 382.80199999999996,
"heapDeltaBytes": 18172372,
"heapUsedBytes": 83535264,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.832999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.8550000000241,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.255999999999999,
"layouts": 11,
"layoutDurationMs": 3.4139999999999997,
"taskDurationMs": 323.825,
"heapDeltaBytes": 18224924,
"heapUsedBytes": 84005796,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 13.741999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 674.6319999999741,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.9890000000000003,
"layouts": 9,
"layoutDurationMs": 2.9060000000000006,
"taskDurationMs": 487.062,
"heapDeltaBytes": 25427288,
"heapUsedBytes": 91718524,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 172.059,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 697.4609999999757,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.5509999999999993,
"layouts": 9,
"layoutDurationMs": 2.275,
"taskDurationMs": 504.8159999999999,
"heapDeltaBytes": 25429032,
"heapUsedBytes": 91364060,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 169.09799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66341463414635,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1185.0149999999644,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 846.7040000000001,
"heapDeltaBytes": -12350676,
"heapUsedBytes": 80060716,
"domNodes": -192,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 65.47999999999999,
"eventListeners": -105,
"totalBlockingTimeMs": 535,
"frameDurationMs": 33.80571428571428,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1216.2170000000287,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 889.0250000000001,
"heapDeltaBytes": -11791668,
"heapUsedBytes": 80822872,
"domNodes": -192,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 69.87400000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 555,
"frameDurationMs": 33.79444444444445,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 840.3549999999882,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.3130000000001,
"heapDeltaBytes": -4299356,
"heapUsedBytes": 76333484,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 157.188,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 24.99999999999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.4799999999759,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.2900000000004,
"heapDeltaBytes": -4309768,
"heapUsedBytes": 76558768,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 155.736,
"eventListeners": 0,
"totalBlockingTimeMs": 214,
"frameDurationMs": 25.00294117647057,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11086.118999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10079.257,
"heapDeltaBytes": -25179104,
"heapUsedBytes": 73918028,
"domNodes": -258,
"jsHeapTotalBytes": 10350592,
"scriptDurationMs": 8624.103,
"eventListeners": -68,
"totalBlockingTimeMs": 1674,
"frameDurationMs": 33.584545454545456,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10129.688999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9255.942,
"heapDeltaBytes": -10822812,
"heapUsedBytes": 88858128,
"domNodes": -258,
"jsHeapTotalBytes": 9564160,
"scriptDurationMs": 7827.83,
"eventListeners": -68,
"totalBlockingTimeMs": 1112,
"frameDurationMs": 31.6653125,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8728.433999999994,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.379,
"layouts": 1,
"layoutDurationMs": 0.2949999999999997,
"taskDurationMs": 7973.256,
"heapDeltaBytes": -20314572,
"heapUsedBytes": 78686844,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 6665,
"eventListeners": -68,
"totalBlockingTimeMs": 596,
"frameDurationMs": 33.021268656716416,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10364.758000000053,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.04099999999999937,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9535.743,
"heapDeltaBytes": 1776284,
"heapUsedBytes": 89120172,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 7740.040000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 975,
"frameDurationMs": 31.223795180722895,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 224.53799999999546,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.439,
"layouts": 11,
"layoutDurationMs": 3.306,
"taskDurationMs": 171.128,
"heapDeltaBytes": -7619552,
"heapUsedBytes": 80640336,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.892000000000001,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.70000000000027
},
{
"name": "large-combo-open",
"durationMs": 245.91300000008687,
"styleRecalcs": 23,
"styleRecalcDurationMs": 17.250999999999998,
"layouts": 11,
"layoutDurationMs": 3.464,
"taskDurationMs": 186.35299999999998,
"heapDeltaBytes": -7511952,
"heapUsedBytes": 79739856,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.437,
"eventListeners": 195,
"totalBlockingTimeMs": 5,
"frameDurationMs": 25.933333333333294,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "large-graph-idle",
"durationMs": 2055.291000000011,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5130000000000003,
"layouts": 8,
"layoutDurationMs": 2.3399999999999994,
"taskDurationMs": 623.494,
"heapDeltaBytes": -2637412,
"heapUsedBytes": 75949852,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 31.848999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2024.4169999999713,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0360000000000005,
"layouts": 8,
"layoutDurationMs": 2.0210000000000004,
"taskDurationMs": 605.1469999999999,
"heapDeltaBytes": -17116928,
"heapUsedBytes": 79015056,
"domNodes": -258,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 32.071,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2314.1330000000266,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.047000000000001,
"layouts": 7,
"layoutDurationMs": 1.6460000000000004,
"taskDurationMs": 1549.6670000000001,
"heapDeltaBytes": -10006968,
"heapUsedBytes": 69955364,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 875.0490000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665942028985505,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2473.310000000083,
"styleRecalcs": 68,
"styleRecalcDurationMs": 5.585,
"layouts": 7,
"layoutDurationMs": 1.4330000000000003,
"taskDurationMs": 1708.9530000000002,
"heapDeltaBytes": -8139376,
"heapUsedBytes": 68999956,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 851.4730000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.779591836734696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3676.240000000007,
"styleRecalcs": 70,
"styleRecalcDurationMs": 6.973999999999999,
"layouts": 63,
"layoutDurationMs": 10.503,
"taskDurationMs": 1745.923,
"heapDeltaBytes": -997408,
"heapUsedBytes": 76471828,
"domNodes": -234,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 774.629,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665454545454544,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3552.7739999999994,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.470000000000001,
"layouts": 64,
"layoutDurationMs": 10.409,
"taskDurationMs": 1579.733,
"heapDeltaBytes": -14004380,
"heapUsedBytes": 67385000,
"domNodes": -234,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 782.832,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74481132075472,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2841.4980000000014,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.872000000000001,
"layouts": 4,
"layoutDurationMs": 1.2339999999999998,
"taskDurationMs": 1741.2859999999996,
"heapDeltaBytes": 12222196,
"heapUsedBytes": 95171100,
"domNodes": 0,
"jsHeapTotalBytes": 6971392,
"scriptDurationMs": 964.738,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.965269461077842,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2821.822999999995,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.5520000000000005,
"layouts": 4,
"layoutDurationMs": 1.1469999999999996,
"taskDurationMs": 1737.7150000000001,
"heapDeltaBytes": 11790672,
"heapUsedBytes": 95350516,
"domNodes": 0,
"jsHeapTotalBytes": 8282112,
"scriptDurationMs": 964.298,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.864880952380947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2056.4410000000066,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8989999999999987,
"layouts": 7,
"layoutDurationMs": 1.9070000000000003,
"taskDurationMs": 621.5430000000001,
"heapDeltaBytes": -3922900,
"heapUsedBytes": 73897188,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 33.568999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.980000000075,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0419999999999994,
"layouts": 7,
"layoutDurationMs": 1.9970000000000006,
"taskDurationMs": 636.966,
"heapDeltaBytes": -23721172,
"heapUsedBytes": 74650212,
"domNodes": -258,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 36.147999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 548.6989999999992,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.1209999999999996,
"layouts": 10,
"layoutDurationMs": 2.733,
"taskDurationMs": 381.44499999999994,
"heapDeltaBytes": 21479596,
"heapUsedBytes": 88353744,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 152.74099999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 628.1390000000329,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.787000000000001,
"layouts": 11,
"layoutDurationMs": 3.214,
"taskDurationMs": 456.723,
"heapDeltaBytes": 1427520,
"heapUsedBytes": 78292644,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 146.51999999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.9419999999905,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.457,
"layouts": 9,
"layoutDurationMs": 2.6319999999999997,
"taskDurationMs": 336.808,
"heapDeltaBytes": 20628108,
"heapUsedBytes": 87604696,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 8.263000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2054.557999999929,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.3150000000000004,
"layouts": 9,
"layoutDurationMs": 3.277,
"taskDurationMs": 596.063,
"heapDeltaBytes": -6367476,
"heapUsedBytes": 70253472,
"domNodes": -180,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 11.261000000000001,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1974.0439999999921,
"styleRecalcs": 87,
"styleRecalcDurationMs": 16.084999999999997,
"layouts": 9,
"layoutDurationMs": 1.9619999999999997,
"taskDurationMs": 859.8280000000001,
"heapDeltaBytes": 10840180,
"heapUsedBytes": 77668068,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 105.55799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665254237288135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1959.9610000000212,
"styleRecalcs": 86,
"styleRecalcDurationMs": 19.090000000000003,
"layouts": 9,
"layoutDurationMs": 2.7060000000000004,
"taskDurationMs": 1026.92,
"heapDeltaBytes": 15078952,
"heapUsedBytes": 92049316,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 109.321,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491525,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1469.0279999999802,
"styleRecalcs": 21,
"styleRecalcDurationMs": 42.282999999999994,
"layouts": 5,
"layoutDurationMs": 26.95,
"taskDurationMs": 1047.5839999999998,
"heapDeltaBytes": 4948116,
"heapUsedBytes": 99524576,
"domNodes": 15953,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 30.324000000000005,
"eventListeners": 3244,
"totalBlockingTimeMs": 185,
"frameDurationMs": 19.775999999999996,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9122.185000000001,
"styleRecalcs": 249,
"styleRecalcDurationMs": 18.008000000000003,
"layouts": 7,
"layoutDurationMs": 1.756,
"taskDurationMs": 5850.623,
"heapDeltaBytes": -12350576,
"heapUsedBytes": 84145232,
"domNodes": -258,
"jsHeapTotalBytes": 5599232,
"scriptDurationMs": 2719.446,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.727339449541283,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8356.402000000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 18.146,
"layouts": 8,
"layoutDurationMs": 2.15,
"taskDurationMs": 5111.052000000001,
"heapDeltaBytes": 9366508,
"heapUsedBytes": 88450360,
"domNodes": -258,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 2704.8269999999998,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.732665330661323,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23023.154999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22389.658,
"heapDeltaBytes": -3166908,
"heapUsedBytes": 287787540,
"domNodes": -3330,
"jsHeapTotalBytes": 9424896,
"scriptDurationMs": 309.54900000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.34324786324786,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 23172.96500000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22556.089,
"heapDeltaBytes": -32310036,
"heapUsedBytes": 258807324,
"domNodes": -3330,
"jsHeapTotalBytes": 9687040,
"scriptDurationMs": 326.197,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.66729452054795,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 27769.498999999996,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.02100000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27355.207,
"heapDeltaBytes": -24778812,
"heapUsedBytes": 270292348,
"domNodes": -3330,
"jsHeapTotalBytes": 6017024,
"scriptDurationMs": 938.098,
"eventListeners": -651,
"totalBlockingTimeMs": 105,
"frameDurationMs": 51.070220588235294,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 19643.525000000067,
"styleRecalcs": 161,
"styleRecalcDurationMs": 13.170000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19175.204,
"heapDeltaBytes": -27384956,
"heapUsedBytes": 253749792,
"domNodes": -3330,
"jsHeapTotalBytes": 7856128,
"scriptDurationMs": 847.4029999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 57,
"frameDurationMs": 36.018131868131874,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8284.913999999957,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.77499999999998,
"layouts": 20,
"layoutDurationMs": 23.352999999999998,
"taskDurationMs": 8147.411000000002,
"heapDeltaBytes": -9318092,
"heapUsedBytes": 272720124,
"domNodes": -3330,
"jsHeapTotalBytes": 15716352,
"scriptDurationMs": 128.18699999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.06250000000001,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 6003.135000000043,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.95599999999999,
"layouts": 20,
"layoutDurationMs": 23.165000000000006,
"taskDurationMs": 5855.722999999999,
"heapDeltaBytes": -36466448,
"heapUsedBytes": 259073856,
"domNodes": -3330,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 98.761,
"eventListeners": -653,
"totalBlockingTimeMs": 19,
"frameDurationMs": 34.28514285714286,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11417.958999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11131.014000000003,
"heapDeltaBytes": 19541756,
"heapUsedBytes": 269343880,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 158.48399999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.96279863481228,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11387.613999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11023.321,
"heapDeltaBytes": -6793296,
"heapUsedBytes": 256218996,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.741,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.08028169014084,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 487.5880000000734,
"styleRecalcs": 21,
"styleRecalcDurationMs": 15.035000000000002,
"layouts": 12,
"layoutDurationMs": 4.798,
"taskDurationMs": 151.112,
"heapDeltaBytes": 7105292,
"heapUsedBytes": 79531720,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 16.337,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.24137931034483,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 161.99700000004214,
"styleRecalcs": 10,
"styleRecalcDurationMs": 14.707999999999998,
"layouts": 10,
"layoutDurationMs": 4.947,
"taskDurationMs": 128.04399999999998,
"heapDeltaBytes": -10886568,
"heapUsedBytes": 68370284,
"domNodes": 116,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 8.980000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 373.30599999995684,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.236,
"layouts": 76,
"layoutDurationMs": 14.125,
"taskDurationMs": 321.35200000000003,
"heapDeltaBytes": -15192964,
"heapUsedBytes": 80065552,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 145.32299999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 503.8310000001047,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3339999999999999,
"layouts": 76,
"layoutDurationMs": 15.004999999999999,
"taskDurationMs": 452.816,
"heapDeltaBytes": 11845900,
"heapUsedBytes": 82687292,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 218.582,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 486.45299999998315,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.9400000000000002,
"layouts": 76,
"layoutDurationMs": 14.154,
"taskDurationMs": 442.112,
"heapDeltaBytes": -314796,
"heapUsedBytes": 122112512,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 175.403,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241396,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 650.7269999999608,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.045,
"layouts": 76,
"layoutDurationMs": 17.252,
"taskDurationMs": 598.019,
"heapDeltaBytes": 798008,
"heapUsedBytes": 129973772,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 249.164,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.56756756756757,
"p95FrameDurationMs": 33.30000000000018
}
]
}🔬 E2E CoverageNote The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge.
Top 10 files by uncovered lines
🎭 Playwright: ✅ 1998 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9562e4b5076e506774bf96649cac14ef5927f890
Full docs: ADR-DEVEX-LINT-0015 |
christian-byrne
left a comment
There was a problem hiding this comment.
Read the diff against the stacked base, useDeleteWorkspaceGate.ts, useBillingCapabilities.ts, and the ServerFact/pendingServerFact helpers in src/platform/serverFacts/.
The new gate matches the PR description precisely: resolveDeleteWorkspaceGate checks !resolved || enterpriseHidden first (hidden takes priority, never a grant before capabilities resolve or while the backend ticket that gates Enterprise support (BE-20592) is still open), then canDelete (enabled), then the HIDDEN_DENIALS set for personal_workspace / workspace_sso_attached / not_workspace_owner / not_a_member, and falls through everything else (including not_original_owner and any reason this client predates) to disabled with the generic tooltip. That ordering is the right one for a gate that must never synthesize a grant.
Both WorkspaceMenuButton.vue and useWorkspaceMenuItems.ts now read the same useDeleteWorkspaceGate() result, and both re-check deleteGate.value.status !== 'enabled' inside the click handler rather than trusting the disabled attribute alone, closing the stale-read race the old code had via canManageSubscription re-checks. Tests cover the full denial table, the unresolved-capabilities hide, the Enterprise hide via pendingServerFact, and the date-only-when-served tooltip case. FE-3454 (the Members panel deep link, #21103, reviewed separately) is unrelated to this change.
One non-blocking note: this PR targets dante01yoon/fe-3432-original-owner-server-facts rather than main, so it can't land until that base PR, the ingest-type sync ticket FE-3432 (#20973), merges and this retargets — flagging for sequencing, not asking for a change here.
Approving on the diff as written; CI is green (perf-tests/typecheck show pending at rollup level but the individual jobs have already completed successfully).
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## dante01yoon/fe-3432-original-owner-server-facts #21117 +/- ##
===================================================================================
+ Coverage 86.38% 87.02% +0.63%
===================================================================================
Files 3672 2614 -1058
Lines 175297 146936 -28361
Branches 48379 40285 -8094
===================================================================================
- Hits 151429 127865 -23564
+ Misses 21826 18682 -3144
+ Partials 2042 389 -1653
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1119 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…capabilities The SDK rail's capabilities projection dropped the snapshot's denials, so the Delete gate never saw personal_workspace and showed a disabled item.
43f272c
into
dante01yoon/fe-3432-original-owner-server-facts
Summary
Render the Delete workspace item from the server's
can_delete_workspaceand its denied reason, in both menus, instead of deriving it from role, personal workspace and tier.Stacked on #20973 (FE-3432), which syncs the ingest types that carry
can_delete_workspaceand itsdenied_reasons. Base is that branch; retarget tomainonce it merges.Why
A wrongly hidden or disabled Delete emits nothing, and the server already resolves the answer with a reason (
workspace_sso_attached,personal_workspace,billing_operation_in_progress,billing_operation_parked,plan_not_ended). ADR-API-SERVER-FACTS-0042: a gate renders one server fact as received.Root cause
useWorkspaceMenuItemsgated Delete oncanManageSubscription && !isInPersonalWorkspace && tier !== 'ENTERPRISE', andWorkspaceMenuButton.vueonworkspaceMenuAction === 'delete' && canManageSubscription. The disabled state came fromcanAccessSubscriptionFeatures/ the workspace'sisWorkspaceSubscribed, two different local proxies for "the plan has not ended", so the two menus could disagree with each other and with the server.How
useBillingCapabilitiesexposescanDeleteWorkspace(aServerFact<'can_delete_workspace'>,falsewhile unresolved) anddeleteWorkspaceDenial(the rawdenied_reasons.can_delete_workspacestring).useDeleteWorkspaceGateis the single source for both menus:hidden/enabled/disabledplus the tooltip.personal_workspace,workspace_sso_attached: hidden (as before).not_workspace_owner/not_a_member: hidden too, so members keep not seeing Delete.plan_not_ended,billing_operation_parked,billing_operation_in_progress: disabled with the ticket copy.plan_not_endednames the plan end date only when the subscription is cancelled and the server served an end date; no date is computed.projectBillingCapabilities) dropped the snapshot'sdenials, so on the raildenied_reasonswas absent and an owner Personal Workspace read as "refused, no reason" (disabled, generic tooltip). It now carriesdenied_reasons; the read type isBillingCapabilitiesRead. Observed on testcloud for that workspace:can_delete_workspace: falsewithdenied_reasons: { can_delete_workspace: "personal_workspace", can_leave_workspace: "personal_workspace_creator", can_cancel: "no_subscription", can_reactivate: "no_subscription" }.canManageSubscription,isInPersonalWorkspace,isDeleteDisabled,isWorkspaceSubscribed.isDeleteDisabled/deleteDisabledTooltipKeyare removed fromuseWorkspaceUI.pendingServerFact('BE-20592', tier === 'ENTERPRISE')and expires with that ticket.not_original_ownercopy is not added (FE-3432 decodes it, BE-20592 not shipped); it falls into the generic disabled state.Follow-up, not in this PR:
uiConfig.workspaceMenuAction/workspaceMenuDisabledTooltipand thedeleteWorkspaceDisabledTooltipstring are now unused by these menus; removing them touches several unrelated fixtures.AS IS / TO BE
Plan position
can_delete_workspace(this PR)not_original_ownerand Enterprise expressed by the serverVerification
pnpm vitest run src/platform/workspace: 95 files, 2833 tests pass. New:useDeleteWorkspaceGate.test.ts(reason table incl. unknown/no reason, unresolved capabilities, Enterprise hide, tooltip copy, date only when served), capability exposure inuseBillingCapabilities.test.ts, both menus' tests.--type-aware, oxfmt, eslint on touched files clean; pre-committypecheck:appandlint:server-factspass.