Repository navigation
feat(website): link FLUX 3 Image Klein from the footer Models column - #21115
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e3e8698aa5227718438a477180429420196710dd
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-21115.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-709qso9td-comfyui.vercel.app Last updated: 2026-10-15T19:59:08Z for |
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21115 +/- ##
==========================================
- Coverage 86.45% 86.34% -0.12%
==========================================
Files 3705 3600 -105
Lines 176357 173119 -3238
Branches 48731 47628 -1103
==========================================
- Hits 152465 149473 -2992
+ Misses 21835 21745 -90
+ Partials 2057 1901 -156
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 105 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Requested by June · Slack thread
Summary
Before: the new FLUX 3 Image Klein page (https://comfy.org/flux-3-image-klein/) has no link from anywhere on the site.
After: "FLUX 3 Image Klein" is the last link in the footer Models column, linking to
/flux-3-image-klein/(/zh-CN/flux-3-image-klein/for zh-CN).How: mirrors #20956 (Nvidia VFX). Uses the existing
routes.flux3ImageKlein, adds afooter.flux3ImageKleinlabel to the en and zh-CN catalogs (model name kept in English, like the sibling zh-CN footer labels), and adds a footer unit test. The Nvidia VFX test now checks that link is present instead of last, since FLUX 3 Image Klein takes the last slot. Footer only; top nav and Products menu are untouched.Verification
pnpm vitest run src/components/common/SiteFooter.test.ts src/i18n/translations.test.tsinapps/websitepasses (39 tests).pnpm typecheckinapps/websitepasses (0 errors); the pre-commit hook ran format, lint and server-facts checks cleanly.🤖 Generated with Claude Code
Generated by Claude Code