Skip to content

feat(website): link FLUX 3 Image Klein from the footer Models column - #21115

Merged
june-bump merged 2 commits into
mainfrom
website/footer-flux-3-image-klein
Oct 15, 2026
Merged

june-bump merged 2 commits into
mainfrom
website/footer-flux-3-image-klein

Conversation

@claude

@claude claude Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Requested by June · Slack thread

Summary

Before: the new FLUX 3 Image Klein page (https://comfy.org/flux-3-image-klein/) has no link from anywhere on the site.

After: "FLUX 3 Image Klein" is the last link in the footer Models column, linking to /flux-3-image-klein/ (/zh-CN/flux-3-image-klein/ for zh-CN).

How: mirrors #20956 (Nvidia VFX). Uses the existing routes.flux3ImageKlein, adds a footer.flux3ImageKlein label to the en and zh-CN catalogs (model name kept in English, like the sibling zh-CN footer labels), and adds a footer unit test. The Nvidia VFX test now checks that link is present instead of last, since FLUX 3 Image Klein takes the last slot. Footer only; top nav and Products menu are untouched.

Verification

  • Tests: pnpm vitest run src/components/common/SiteFooter.test.ts src/i18n/translations.test.ts in apps/website passes (39 tests).
  • pnpm typecheck in apps/website passes (0 errors); the pre-commit hook ran format, lint and server-facts checks cleanly.

🤖 Generated with Claude Code


Generated by Claude Code

@claude
claude Bot requested a review from a team October 15, 2026 19:45
@claude
claude Bot temporarily deployed to website-approval October 15, 2026 19:45 Inactive
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 015ec93a-8f46-4a38-ba79-1f2fe3d74242

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since e3e8698aa5227718438a477180429420196710dd

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21115.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-709qso9td-comfyui.vercel.app

Last updated: 2026-10-15T19:59:08Z for f17172d

@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #21115      +/-   ##
==========================================
- Coverage   86.45%   86.34%   -0.12%     
==========================================
  Files        3705     3600     -105     
  Lines      176357   173119    -3238     
  Branches    48731    47628    -1103     
==========================================
- Hits       152465   149473    -2992     
+ Misses      21835    21745      -90     
+ Partials     2057     1901     -156     
Flag Coverage Δ
billing-web-unit ?
website-unit 80.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/components/common/SiteFooter.vue 100.00% <ø> (ø)

... and 105 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 15, 2026
@claude
claude Bot temporarily deployed to website-approval October 15, 2026 19:56 Inactive
@june-bump
june-bump enabled auto-merge October 15, 2026 19:58
@june-bump
june-bump added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit bc5735c Oct 15, 2026
102 checks passed
@june-bump
june-bump deleted the website/footer-flux-3-image-klein branch October 15, 2026 20:37

This branch was previously deployed

1 inactive deployment
website-approval — f17172df Deployed Oct 15, 2026 by claude[bot] via fast-lane #4584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants