Repository navigation
[backport cloud/1.57] feat: report DynamicGroup row refusals and remote count mismatches - #21090
Conversation
…20993) ## Summary When DynamicGroup refuses a row change, or a remote frame sets a row count that the live group does not reach, nothing is reported in production ([DynamicGroup architecture and safety review](https://app.notion.com/p/comfy-org/DynamicGroup-architecture-and-safety-review-3f06d73d365081679352c7032c88fd1c), "Operational monitoring"). This PR reports both cases through `reportError()`: - `failure_resizing_dynamic_group_rows` (`surface: 'graph'`, `level: 'warning'`): sent when the controller setter or a row's remove button ends with a different row count than requested. Today these failures are swallowed by `break`. A count clamped up to `min` is not reported. - `agent_graph_dynamic_group_rows_mismatch` (`surface: 'agent'`, existing `agent-crdt` / `graph-api` / `degraded` tags): sent when `LiveGraphApplier` writes a DynamicGroup count and the live value read back afterwards differs from the document's value. It counts toward `apply_failure_count`. Per AGENT-OBSERVABILITY-0034, only degradation is reported. There is no positive "effect observed" event. Tags are `node_type`, `operation` (`add_row` | `remove_row` | `remote_apply`) and `in_subgraph`. Context is `{ requested, actual }`, numbers only. Reports never include widget values, labels, input names or workflow content, and the message strings are constant. Each (error type, node type, operation) is reported at most once per session. Consent: Sentry also runs in local builds, and the repo has no shared gate for this, so both reports are sent only when `isCloud || isHostTelemetryEnabled()`. The reporters live in a new `dynamicGroupDiagnostics.ts`. Keeping them out of the node-widgets and agent domains avoids new cross-domain imports, which the Fallow boundary audit would reject. Follow-ups, not in this PR: signal 3, orphaned promotions after row removal; signal 5, trailing widgets displaced on positional restore (the named-vs-positional shadow diff from #14375 partly covers this). Stacked on #20992. Part of CORE-186 ## Verification - `dynamicGroupDiagnostics.test.ts` (11 tests) covers: refused add, refused count reduction and refused remove button; no report on success or on a `min` clamp; dedupe; the three consent cases (local without host telemetry, Desktop with telemetry, Cloud); remote mismatch reported once and counted; remote success not reported; remote mismatch without consent counted but not sent. - Red: with the two call sites reverted, 8 of 11 fail (the 3 that still pass assert no report). Mutations that open the gate, drop the Cloud branch, remove the dedupe, or compare against the unclamped count each turn the matching test red. - `vitest run src/core/graph/widgets src/workbench/extensions/agent/crdt` passes (1177 tests). Typecheck, oxlint, eslint, oxfmt, knip and the Fallow audit pass through the commit and push hooks.
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-15T07:36:49.407Z",
"gitSha": "5069bd657b6735e9ffb239599fd5ae8c4c3c6e5a",
"branch": "backport-20993-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2016.4000000000328,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9169999999999994,
"layouts": 9,
"layoutDurationMs": 3.159,
"taskDurationMs": 507.17400000000004,
"heapDeltaBytes": 22158804,
"heapUsedBytes": 87588312,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.756,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.2159999999476,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1729999999999996,
"layouts": 9,
"layoutDurationMs": 2.9510000000000005,
"taskDurationMs": 422.811,
"heapDeltaBytes": 22151584,
"heapUsedBytes": 87981596,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 13.149999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1750.1980000000117,
"styleRecalcs": 74,
"styleRecalcDurationMs": 14.204,
"layouts": 9,
"layoutDurationMs": 2.5900000000000003,
"taskDurationMs": 849.211,
"heapDeltaBytes": 15676264,
"heapUsedBytes": 81425944,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 159.85100000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1993.6069999999972,
"styleRecalcs": 84,
"styleRecalcDurationMs": 16.453,
"layouts": 9,
"layoutDurationMs": 2.8960000000000004,
"taskDurationMs": 1111.2040000000002,
"heapDeltaBytes": -8293296,
"heapUsedBytes": 66733640,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 170.989,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583333333333,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.905000000002,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.938000000000001,
"layouts": 11,
"layoutDurationMs": 2.9270000000000005,
"taskDurationMs": 375.861,
"heapDeltaBytes": -4131632,
"heapUsedBytes": 71208792,
"domNodes": 47,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.459,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.878000000008,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.805999999999999,
"layouts": 11,
"layoutDurationMs": 3.1079999999999997,
"taskDurationMs": 424.183,
"heapDeltaBytes": -4082248,
"heapUsedBytes": 71344124,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 14.327,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 687.3620000000074,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.111999999999999,
"layouts": 10,
"layoutDurationMs": 2.9939999999999998,
"taskDurationMs": 483.06800000000004,
"heapDeltaBytes": 26032476,
"heapUsedBytes": 91809892,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 164.541,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 726.3850000000502,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.5800000000000005,
"layouts": 8,
"layoutDurationMs": 2.346,
"taskDurationMs": 523.145,
"heapDeltaBytes": 2389220,
"heapUsedBytes": 77442272,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 174.94500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.053488372093028,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1170.642999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 825.8420000000001,
"heapDeltaBytes": -11982712,
"heapUsedBytes": 80562060,
"domNodes": -192,
"jsHeapTotalBytes": 19931136,
"scriptDurationMs": 67.41400000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 516,
"frameDurationMs": 33.32857142857143,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1287.3389999999745,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1021.5610000000001,
"heapDeltaBytes": -11436504,
"heapUsedBytes": 81651752,
"domNodes": -192,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 73.70800000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 593,
"frameDurationMs": 34.68378378378379,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.2070000000399,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.2700000000004,
"heapDeltaBytes": -3632004,
"heapUsedBytes": 76477304,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 163.09199999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 24.99705882352943,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.504000000039,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.387,
"heapDeltaBytes": -4362956,
"heapUsedBytes": 76627116,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 164.54000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 229,
"frameDurationMs": 25.491176470588258,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10543.930999999986,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.03600000000000044,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9581.337,
"heapDeltaBytes": -10685144,
"heapUsedBytes": 88555356,
"domNodes": -258,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 7751.024,
"eventListeners": -68,
"totalBlockingTimeMs": 893,
"frameDurationMs": 31.441492537313433,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9246.902999999975,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.04900000000000043,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8501.947,
"heapDeltaBytes": -16082644,
"heapUsedBytes": 83526836,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 7124.705,
"eventListeners": -68,
"totalBlockingTimeMs": 751,
"frameDurationMs": 32.45508771929825,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9971.187999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9157.231000000002,
"heapDeltaBytes": -10901252,
"heapUsedBytes": 88148316,
"domNodes": -258,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 7420.915,
"eventListeners": -64,
"totalBlockingTimeMs": 787,
"frameDurationMs": 31.340566037735847,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10083.091999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9255.329,
"heapDeltaBytes": -19671332,
"heapUsedBytes": 74552356,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 7540.126,
"eventListeners": -68,
"totalBlockingTimeMs": 784,
"frameDurationMs": 31.807255520504732,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 199.81500000000096,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.030000000000001,
"layouts": 10,
"layoutDurationMs": 2.707,
"taskDurationMs": 158.71199999999996,
"heapDeltaBytes": -7521704,
"heapUsedBytes": 80230420,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.040999999999999,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 231.55500000007123,
"styleRecalcs": 24,
"styleRecalcDurationMs": 16.279000000000003,
"layouts": 11,
"layoutDurationMs": 3.438,
"taskDurationMs": 178.20700000000002,
"heapDeltaBytes": -8184060,
"heapUsedBytes": 79202560,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8.557,
"eventListeners": 195,
"totalBlockingTimeMs": 3,
"frameDurationMs": 23.329999999999927,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2058.2660000000033,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.418,
"layouts": 8,
"layoutDurationMs": 2.1799999999999997,
"taskDurationMs": 621.107,
"heapDeltaBytes": -21651464,
"heapUsedBytes": 74887512,
"domNodes": -258,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 32.408,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2020.6840000000739,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.810000000000001,
"layouts": 8,
"layoutDurationMs": 2.7710000000000004,
"taskDurationMs": 532.508,
"heapDeltaBytes": -2832264,
"heapUsedBytes": 75969028,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 38.718,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2447.025999999994,
"styleRecalcs": 69,
"styleRecalcDurationMs": 5.5760000000000005,
"layouts": 8,
"layoutDurationMs": 1.807,
"taskDurationMs": 1716.285,
"heapDeltaBytes": -7638836,
"heapUsedBytes": 69507920,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 871.4889999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598639455782,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2289.749000000029,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.368,
"layouts": 6,
"layoutDurationMs": 2.1129999999999995,
"taskDurationMs": 1551.993,
"heapDeltaBytes": -10850368,
"heapUsedBytes": 69102084,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 825.43,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.788888888888888,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3469.886000000031,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.056000000000001,
"layouts": 64,
"layoutDurationMs": 10.695,
"taskDurationMs": 1549.8410000000003,
"heapDeltaBytes": 11570444,
"heapUsedBytes": 92984652,
"domNodes": -234,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 762.6409999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3762.5779999999622,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.948,
"layouts": 64,
"layoutDurationMs": 10.791,
"taskDurationMs": 1817.589,
"heapDeltaBytes": -19236240,
"heapUsedBytes": 80162224,
"domNodes": -234,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 790.104,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.740444444444446,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2660.7700000000136,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.859000000000001,
"layouts": 5,
"layoutDurationMs": 1.3399999999999996,
"taskDurationMs": 1696.4419999999998,
"heapDeltaBytes": 6229096,
"heapUsedBytes": 89756508,
"domNodes": 0,
"jsHeapTotalBytes": 8089600,
"scriptDurationMs": 928.5889999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.878980891719745,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3183.2500000000437,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.9510000000000005,
"layouts": 5,
"layoutDurationMs": 1.2989999999999997,
"taskDurationMs": 2060.263,
"heapDeltaBytes": -1776640,
"heapUsedBytes": 77182592,
"domNodes": 0,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 1035.3400000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.111764705882354,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2053.8740000000075,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.309,
"layouts": 8,
"layoutDurationMs": 2.5410000000000004,
"taskDurationMs": 599.2250000000001,
"heapDeltaBytes": -2860276,
"heapUsedBytes": 74865220,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 30.773000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.5610000000106,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.9140000000000008,
"layouts": 6,
"layoutDurationMs": 2.216,
"taskDurationMs": 516.2730000000001,
"heapDeltaBytes": -2059888,
"heapUsedBytes": 79350000,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 33.303999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.9859999999958,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.462,
"layouts": 9,
"layoutDurationMs": 2.4,
"taskDurationMs": 430.49299999999994,
"heapDeltaBytes": -2280960,
"heapUsedBytes": 74104496,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 145.29500000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.15588235294118,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 551.1329999999361,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.206,
"layouts": 9,
"layoutDurationMs": 2.62,
"taskDurationMs": 392.956,
"heapDeltaBytes": 21579852,
"heapUsedBytes": 89114212,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 149.63000000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.7910000000452,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.5720000000000005,
"layouts": 10,
"layoutDurationMs": 2.775,
"taskDurationMs": 493.304,
"heapDeltaBytes": 22365464,
"heapUsedBytes": 89715104,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7.659000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2007.9159999999092,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1780000000000004,
"layouts": 9,
"layoutDurationMs": 3.2569999999999997,
"taskDurationMs": 595.562,
"heapDeltaBytes": 22432448,
"heapUsedBytes": 89833912,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 13.483000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1975.356999999974,
"styleRecalcs": 87,
"styleRecalcDurationMs": 16.423000000000002,
"layouts": 10,
"layoutDurationMs": 2.6889999999999996,
"taskDurationMs": 1015.633,
"heapDeltaBytes": -11405316,
"heapUsedBytes": 65518052,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 107.196,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2010.0790000000188,
"styleRecalcs": 88,
"styleRecalcDurationMs": 17.985999999999997,
"layouts": 10,
"layoutDurationMs": 2.9850000000000003,
"taskDurationMs": 1090.5420000000001,
"heapDeltaBytes": -11432516,
"heapUsedBytes": 65639836,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 116.891,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 983.5709999999835,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.234999999999996,
"layouts": 5,
"layoutDurationMs": 16.048000000000002,
"taskDurationMs": 771.9120000000001,
"heapDeltaBytes": 4833464,
"heapUsedBytes": 101297260,
"domNodes": 15953,
"jsHeapTotalBytes": 17436672,
"scriptDurationMs": 25.031,
"eventListeners": 3244,
"totalBlockingTimeMs": 158,
"frameDurationMs": 21.37826086956521,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9156.755999999972,
"styleRecalcs": 250,
"styleRecalcDurationMs": 17.747000000000003,
"layouts": 8,
"layoutDurationMs": 2.113,
"taskDurationMs": 5709.552000000001,
"heapDeltaBytes": 7436048,
"heapUsedBytes": 86810292,
"domNodes": -258,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 2617.0170000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.726824817518246,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10053.928000000042,
"styleRecalcs": 251,
"styleRecalcDurationMs": 19.058,
"layouts": 8,
"layoutDurationMs": 2.392,
"taskDurationMs": 6065.495999999999,
"heapDeltaBytes": -9576900,
"heapUsedBytes": 87198916,
"domNodes": -258,
"jsHeapTotalBytes": 5074944,
"scriptDurationMs": 2737.7290000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.721464226289516,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 22960.166999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22072.565000000002,
"heapDeltaBytes": -43357540,
"heapUsedBytes": 257332836,
"domNodes": -3330,
"jsHeapTotalBytes": 14405632,
"scriptDurationMs": 317.031,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.083542039356,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 23030.532999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22221.745,
"heapDeltaBytes": -8922820,
"heapUsedBytes": 282370652,
"domNodes": -3330,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 356.61299999999994,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.68241379310345,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 27692.699000000004,
"styleRecalcs": 181,
"styleRecalcDurationMs": 15.113999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27161.523,
"heapDeltaBytes": -11034596,
"heapUsedBytes": 265005352,
"domNodes": -3330,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 851.2919999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 32,
"frameDurationMs": 51.010865561694295,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 27607.880000000023,
"styleRecalcs": 181,
"styleRecalcDurationMs": 15.33799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27175.064000000002,
"heapDeltaBytes": -8261120,
"heapUsedBytes": 287498128,
"domNodes": -3334,
"jsHeapTotalBytes": 9879552,
"scriptDurationMs": 881.393,
"eventListeners": -651,
"totalBlockingTimeMs": 35,
"frameDurationMs": 50.088566243194194,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8278.427999999964,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.402,
"layouts": 20,
"layoutDurationMs": 23.023000000000003,
"taskDurationMs": 8153.198999999999,
"heapDeltaBytes": -12586420,
"heapUsedBytes": 263955028,
"domNodes": -307,
"jsHeapTotalBytes": 18599936,
"scriptDurationMs": 131.74,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.510989010989015,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 5694.370999999933,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.52599999999998,
"layouts": 20,
"layoutDurationMs": 21.581000000000003,
"taskDurationMs": 5577.503,
"heapDeltaBytes": -44027928,
"heapUsedBytes": 260238864,
"domNodes": -3330,
"jsHeapTotalBytes": 17817600,
"scriptDurationMs": 91.9,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.13779069767441,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11403.646999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11011.709,
"heapDeltaBytes": -16225836,
"heapUsedBytes": 256791312,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.42999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.90648464163823,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11334.384,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10905.776,
"heapDeltaBytes": 5049332,
"heapUsedBytes": 278764324,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.83400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.07931034482758,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 136.82999999991807,
"styleRecalcs": 9,
"styleRecalcDurationMs": 12.226,
"layouts": 7,
"layoutDurationMs": 3.142,
"taskDurationMs": 101.917,
"heapDeltaBytes": -15257692,
"heapUsedBytes": 67747248,
"domNodes": 125,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.493,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.05714285714287,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "workflow-execution",
"durationMs": 503.57899999994515,
"styleRecalcs": 20,
"styleRecalcDurationMs": 12.757000000000001,
"layouts": 10,
"layoutDurationMs": 3.993,
"taskDurationMs": 146.612,
"heapDeltaBytes": -13264892,
"heapUsedBytes": 70390612,
"domNodes": 121,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 12.313999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999995,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 463.8159999999516,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4369999999999998,
"layouts": 76,
"layoutDurationMs": 15.061,
"taskDurationMs": 409.77399999999994,
"heapDeltaBytes": -14372888,
"heapUsedBytes": 80695540,
"domNodes": 4,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 196.153,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 420.19600000003265,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9470000000000001,
"layouts": 76,
"layoutDurationMs": 14.200000000000001,
"taskDurationMs": 370.09299999999996,
"heapDeltaBytes": 10919856,
"heapUsedBytes": 82007232,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 178.735,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66923076923079,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 528.3430000000635,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.911,
"layouts": 76,
"layoutDurationMs": 13.833,
"taskDurationMs": 489.831,
"heapDeltaBytes": -49996,
"heapUsedBytes": 131230716,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 201.617,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000017,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 583.6199999999963,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.975,
"layouts": 76,
"layoutDurationMs": 14.113999999999999,
"taskDurationMs": 547.713,
"heapDeltaBytes": 11366284,
"heapUsedBytes": 165466796,
"domNodes": 4,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 224.32399999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.138235294117642,
"p95FrameDurationMs": 33.30000000000018
}
]
}🎭 Playwright: ❌ 2278 passed, 1 failed❌ Failed Tests📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 194ad03c09263774345b4b3c387ca5e93485a5b1
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.57 #21090 +/- ##
=============================================
Coverage ? 87.19%
=============================================
Files ? 2625
Lines ? 147559
Branches ? 40493
=============================================
Hits ? 128662
Misses ? 18507
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
🔗 Commit SHA: 2c1c8c2 | Docs | View more details | Give us feedback! |
Backport of #20993 to
cloud/1.57Automatically created by backport workflow.