Repository navigation
Conversation
On cloud an asset card's attachment ref is its content hash, which has no extension, so the agent panel fell back to the card's display label. A PNG labelled "Flux.dev", "render.v2" or "Upscale 1.5x" became an invalid file and blocked Send, while a stored .usdz behind an extensionless label was attached and sent. The drag payload already carries the stored file name. The panel now judges a card by its ref, then by its stored file name, and uses the label only when the payload has no stored name. A card that has to be downloaded first is named after its stored file name, so the uploaded file is judged by the same name. The canvas drop path is unchanged.
📦 Bundle: 9.47 MB gzip 🟢 -229 BDetailsSummary
Category Glance App Entry Points — 5.25 kB (baseline 5.25 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.45 MB (baseline 2.45 MB) • 🟢 -8 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 9 unchanged Panels & Settings — 670 kB (baseline 670 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 3 added / 3 removed / 26 unchanged User & Accounts — 293 kB (baseline 293 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 13 unchanged Editors & Dialogs — 345 kB (baseline 345 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed / 5 unchanged UI Components — 212 kB (baseline 212 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 17 unchanged Data & Services — 2.19 MB (baseline 2.19 MB) • 🟢 -736 BStores, services, APIs, and repositories
Status: 6 added / 6 removed / 19 unchanged Utilities & Hooks — 984 kB (baseline 984 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 23 added / 23 removed / 45 unchanged Vendor & Third-Party — 13.9 MB (baseline 13.9 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 19.5 MB (baseline 19.5 MB) • ⚪ 0 BBundles that do not match a named category
Status: 66 added / 66 removed / 286 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-15T03:44:10.570Z",
"gitSha": "aae72f05452380f5c27dee1661c06cd7d49feee7",
"branch": "ryan-di/agent-asset-card-stored-name",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.7009999999973,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5590000000000006,
"layouts": 8,
"layoutDurationMs": 2.7680000000000007,
"taskDurationMs": 423.18799999999993,
"heapDeltaBytes": 5142880,
"heapUsedBytes": 69687472,
"domNodes": -162,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 11.16,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2024.676999999997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.73,
"layouts": 9,
"layoutDurationMs": 2.9570000000000003,
"taskDurationMs": 577.8950000000001,
"heapDeltaBytes": 2571988,
"heapUsedBytes": 81022852,
"domNodes": -162,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 11.556000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1846.4869999999962,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.154,
"layouts": 9,
"layoutDurationMs": 3.052,
"taskDurationMs": 940.233,
"heapDeltaBytes": 13011488,
"heapUsedBytes": 76291080,
"domNodes": -162,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 152.731,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576576576577,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1815.2539999999817,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.679,
"layouts": 9,
"layoutDurationMs": 2.7,
"taskDurationMs": 910.699,
"heapDeltaBytes": 15685400,
"heapUsedBytes": 78627828,
"domNodes": -162,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 150.72600000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666972477064224,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.6020000000044,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.132,
"layouts": 11,
"layoutDurationMs": 3.913,
"taskDurationMs": 436.34,
"heapDeltaBytes": 395544,
"heapUsedBytes": 74655936,
"domNodes": 47,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 14.791000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1805.8679999999185,
"styleRecalcs": 20,
"styleRecalcDurationMs": 6.175,
"layouts": 12,
"layoutDurationMs": 3.714,
"taskDurationMs": 484.31,
"heapDeltaBytes": -2142488,
"heapUsedBytes": 76278420,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 13.92,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664814814814818,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 744.0840000000151,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.15,
"layouts": 9,
"layoutDurationMs": 2.725,
"taskDurationMs": 497.83,
"heapDeltaBytes": 5914364,
"heapUsedBytes": 84269684,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 165.05,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668888888888887,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 728.1069999999659,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.0759999999999996,
"layouts": 10,
"layoutDurationMs": 2.6359999999999992,
"taskDurationMs": 532.316,
"heapDeltaBytes": 9465360,
"heapUsedBytes": 87415800,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 171.52,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909086,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1163.7350000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 810.103,
"heapDeltaBytes": 16164792,
"heapUsedBytes": 96025592,
"domNodes": 0,
"jsHeapTotalBytes": 16416768,
"scriptDurationMs": 58.33900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 536,
"frameDurationMs": 34.31470588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1151.2009999999577,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 787.0820000000001,
"heapDeltaBytes": 12977256,
"heapUsedBytes": 93059464,
"domNodes": 0,
"jsHeapTotalBytes": 15368192,
"scriptDurationMs": 59.517,
"eventListeners": 0,
"totalBlockingTimeMs": 526,
"frameDurationMs": 34.84545454545454,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 831.4849999999865,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.1220000000001,
"heapDeltaBytes": -6129008,
"heapUsedBytes": 71433428,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 138.828,
"eventListeners": 0,
"totalBlockingTimeMs": 176,
"frameDurationMs": 23.147222222222226,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 796.8849999999748,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.5839999999997,
"heapDeltaBytes": -5047956,
"heapUsedBytes": 72649788,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 132.772,
"eventListeners": 0,
"totalBlockingTimeMs": 175,
"frameDurationMs": 23.526470588235284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9547.82800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8606.921,
"heapDeltaBytes": -1967244,
"heapUsedBytes": 81623700,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 6687.936,
"eventListeners": 0,
"totalBlockingTimeMs": 293,
"frameDurationMs": 29.2420245398773,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8380.81100000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7497.427000000001,
"heapDeltaBytes": -1536952,
"heapUsedBytes": 81719060,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 6115.918,
"eventListeners": 0,
"totalBlockingTimeMs": 111,
"frameDurationMs": 28.849310344827582,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9250.30000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8452.232,
"heapDeltaBytes": 11573956,
"heapUsedBytes": 95686120,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 6635.3640000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 356,
"frameDurationMs": 30.895681063122925,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8900.770000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8142.35,
"heapDeltaBytes": -2187324,
"heapUsedBytes": 81097092,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 6347.47,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 29.90909090909091,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 192.3450000000173,
"styleRecalcs": 20,
"styleRecalcDurationMs": 13.065,
"layouts": 9,
"layoutDurationMs": 2.9890000000000003,
"taskDurationMs": 147.199,
"heapDeltaBytes": 13219864,
"heapUsedBytes": 77223256,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.546999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-combo-open",
"durationMs": 207.50199999997676,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.998000000000001,
"layouts": 11,
"layoutDurationMs": 3.8510000000000004,
"taskDurationMs": 165.436,
"heapDeltaBytes": 13046684,
"heapUsedBytes": 89487900,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.581,
"eventListeners": 196,
"totalBlockingTimeMs": 2,
"frameDurationMs": 24.077777777777808,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2041.1470000000236,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7010000000000003,
"layouts": 6,
"layoutDurationMs": 1.6950000000000003,
"taskDurationMs": 649.14,
"heapDeltaBytes": -28472752,
"heapUsedBytes": 70630128,
"domNodes": -258,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.354000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2044.1280000000006,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4949999999999999,
"layouts": 5,
"layoutDurationMs": 1.4919999999999998,
"taskDurationMs": 483.78699999999986,
"heapDeltaBytes": -28191740,
"heapUsedBytes": 70960748,
"domNodes": -258,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.861999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2354.771000000028,
"styleRecalcs": 64,
"styleRecalcDurationMs": 5.304,
"layouts": 3,
"layoutDurationMs": 0.9429999999999998,
"taskDurationMs": 1497.8640000000003,
"heapDeltaBytes": 10338852,
"heapUsedBytes": 75478720,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 821.207,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.905755395683457,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2206.5430000000106,
"styleRecalcs": 64,
"styleRecalcDurationMs": 4.857,
"layouts": 2,
"layoutDurationMs": 0.6050000000000001,
"taskDurationMs": 1631.378,
"heapDeltaBytes": 10724144,
"heapUsedBytes": 76664932,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 778.3969999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793893129770996,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3569.5690000000013,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.631,
"layouts": 62,
"layoutDurationMs": 10.377999999999998,
"taskDurationMs": 1576.91,
"heapDeltaBytes": 21950816,
"heapUsedBytes": 89225828,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 769.7900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666355140186916,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3692.08900000001,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.107,
"layouts": 62,
"layoutDurationMs": 10.791,
"taskDurationMs": 1644.267,
"heapDeltaBytes": 22032916,
"heapUsedBytes": 89154028,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 807.095,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666063348416287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3152.643000000012,
"styleRecalcs": 41,
"styleRecalcDurationMs": 3.9059999999999997,
"layouts": 1,
"layoutDurationMs": 0.30999999999999994,
"taskDurationMs": 1988.121,
"heapDeltaBytes": 6924972,
"heapUsedBytes": 74203944,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 970.9490000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755614973262027,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3115.6220000000303,
"styleRecalcs": 40,
"styleRecalcDurationMs": 3.641,
"layouts": 1,
"layoutDurationMs": 0.21399999999999977,
"taskDurationMs": 1949.151,
"heapDeltaBytes": 6534080,
"heapUsedBytes": 76168368,
"domNodes": 0,
"jsHeapTotalBytes": 2322432,
"scriptDurationMs": 916.502,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755675675675676,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.3189999999863,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5979999999999995,
"layouts": 2,
"layoutDurationMs": 0.4230000000000002,
"taskDurationMs": 600.7919999999999,
"heapDeltaBytes": 6708852,
"heapUsedBytes": 72165040,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.016,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2026.0760000001028,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9709999999999996,
"layouts": 3,
"layoutDurationMs": 1.0579999999999998,
"taskDurationMs": 605.47,
"heapDeltaBytes": 6833288,
"heapUsedBytes": 72674808,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.102999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 627.8409999999894,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.175,
"layouts": 9,
"layoutDurationMs": 2.4869999999999997,
"taskDurationMs": 445.319,
"heapDeltaBytes": 215408,
"heapUsedBytes": 80539876,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 140.215,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 663.9810000000352,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.6690000000000005,
"layouts": 10,
"layoutDurationMs": 2.8939999999999997,
"taskDurationMs": 472.80699999999996,
"heapDeltaBytes": 172532,
"heapUsedBytes": 80556808,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 151.584,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2021.7930000000024,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.164000000000001,
"layouts": 11,
"layoutDurationMs": 3.199,
"taskDurationMs": 591.09,
"heapDeltaBytes": -24276360,
"heapUsedBytes": 56138240,
"domNodes": -180,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 11.237,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2042.888000000005,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.713,
"layouts": 10,
"layoutDurationMs": 2.739,
"taskDurationMs": 583.0949999999999,
"heapDeltaBytes": -8459368,
"heapUsedBytes": 56042492,
"domNodes": -180,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 11.482000000000001,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1778.8060000000314,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.148000000000003,
"layouts": 9,
"layoutDurationMs": 2.5109999999999997,
"taskDurationMs": 786.757,
"heapDeltaBytes": 15007608,
"heapUsedBytes": 79288752,
"domNodes": -180,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 112.00699999999999,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747666,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1745.3610000000594,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.983999999999998,
"layouts": 9,
"layoutDurationMs": 2.496,
"taskDurationMs": 788.4949999999999,
"heapDeltaBytes": -3731180,
"heapUsedBytes": 76682788,
"domNodes": -180,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 109.396,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.7319999999731,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.808999999999997,
"layouts": 5,
"layoutDurationMs": 13.718000000000005,
"taskDurationMs": 1039.613,
"heapDeltaBytes": 2944020,
"heapUsedBytes": 96956132,
"domNodes": 15950,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 28.493000000000006,
"eventListeners": 3244,
"totalBlockingTimeMs": 145,
"frameDurationMs": 19.59324324324324,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8309.361999999965,
"styleRecalcs": 250,
"styleRecalcDurationMs": 18.644,
"layouts": 7,
"layoutDurationMs": 2.1319999999999992,
"taskDurationMs": 5412.469,
"heapDeltaBytes": -16579696,
"heapUsedBytes": 86342928,
"domNodes": -259,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 2787.941,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69939637826962,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8385.70900000002,
"styleRecalcs": 246,
"styleRecalcDurationMs": 18.325,
"layouts": 4,
"layoutDurationMs": 1.0119999999999998,
"taskDurationMs": 6032.5160000000005,
"heapDeltaBytes": 21115584,
"heapUsedBytes": 86020372,
"domNodes": -258,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2702.8630000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69940119760479,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 20247.307999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19612.225000000002,
"heapDeltaBytes": -17681132,
"heapUsedBytes": 284814096,
"domNodes": -3330,
"jsHeapTotalBytes": 8900608,
"scriptDurationMs": 304.146,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.786363636363646,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 20500.576000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19789.217999999997,
"heapDeltaBytes": -27445928,
"heapUsedBytes": 256689628,
"domNodes": -3330,
"jsHeapTotalBytes": 10473472,
"scriptDurationMs": 274.78600000000006,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.935495495495495,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 24932.80599999997,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.459000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24620.702999999998,
"heapDeltaBytes": -25271644,
"heapUsedBytes": 282265180,
"domNodes": -3330,
"jsHeapTotalBytes": 5685248,
"scriptDurationMs": 915.958,
"eventListeners": -651,
"totalBlockingTimeMs": 13,
"frameDurationMs": 47.7036328871893,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 24974.294999999984,
"styleRecalcs": 177,
"styleRecalcDurationMs": 18.43599999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24658.968,
"heapDeltaBytes": -33784596,
"heapUsedBytes": 273658540,
"domNodes": -3330,
"jsHeapTotalBytes": 6541312,
"scriptDurationMs": 902.235,
"eventListeners": -651,
"totalBlockingTimeMs": 12,
"frameDurationMs": 47.463498098859304,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "vue-node-resize-workload",
"durationMs": 7450.425999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.81099999999998,
"layouts": 20,
"layoutDurationMs": 24.696999999999996,
"taskDurationMs": 7351.67,
"heapDeltaBytes": -18761688,
"heapUsedBytes": 270149256,
"domNodes": -307,
"jsHeapTotalBytes": 9687040,
"scriptDurationMs": 113.91600000000001,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.5654970760234,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7244.6670000000495,
"styleRecalcs": 20,
"styleRecalcDurationMs": 92.03699999999998,
"layouts": 20,
"layoutDurationMs": 30.479999999999993,
"taskDurationMs": 7180.235,
"heapDeltaBytes": -14319484,
"heapUsedBytes": 269106784,
"domNodes": -3330,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 141.142,
"eventListeners": -653,
"totalBlockingTimeMs": 123,
"frameDurationMs": 43.15238095238095,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10174.519000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9907.976,
"heapDeltaBytes": -8226988,
"heapUsedBytes": 258834644,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 164.45999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.02872727272728,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10158.838999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9896.778000000002,
"heapDeltaBytes": 6153228,
"heapUsedBytes": 275382620,
"domNodes": 0,
"jsHeapTotalBytes": -5767168,
"scriptDurationMs": 141.725,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.15601503759399,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "workflow-execution",
"durationMs": 134.17899999996052,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.839999999999998,
"layouts": 8,
"layoutDurationMs": 3.8549999999999995,
"taskDurationMs": 114.65200000000002,
"heapDeltaBytes": -11553296,
"heapUsedBytes": 64256092,
"domNodes": 124,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 12.490000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "workflow-execution",
"durationMs": 149.91900000006808,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.985,
"layouts": 10,
"layoutDurationMs": 4.582,
"taskDurationMs": 104.28499999999998,
"heapDeltaBytes": -10772296,
"heapUsedBytes": 65543992,
"domNodes": 117,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 7.1469999999999985,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.655555555555566,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 410.50299999994877,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.032,
"layouts": 76,
"layoutDurationMs": 15.426,
"taskDurationMs": 371.035,
"heapDeltaBytes": 10546360,
"heapUsedBytes": 79260472,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.805,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664000000000016,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 404.6890000000758,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8109999999999999,
"layouts": 76,
"layoutDurationMs": 16.666,
"taskDurationMs": 359.22800000000007,
"heapDeltaBytes": 10244068,
"heapUsedBytes": 85526648,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 158.743,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999977,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 614.373999999998,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.254,
"layouts": 76,
"layoutDurationMs": 16.682,
"taskDurationMs": 570.5819999999999,
"heapDeltaBytes": 1294888,
"heapUsedBytes": 120808128,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 230.42000000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 496.5750000000071,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.965,
"layouts": 76,
"layoutDurationMs": 14.275,
"taskDurationMs": 458.787,
"heapDeltaBytes": -90420,
"heapUsedBytes": 116080348,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 175.62,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333326,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2283 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 859914c247accace81e4d38c3e158b0443a788ad
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21075 +/- ##
==========================================
+ Coverage 86.43% 87.23% +0.79%
==========================================
Files 3703 2635 -1068
Lines 176251 147720 -28531
Branches 48695 38464 -10231
==========================================
- Hits 152348 128867 -23481
+ Misses 21849 18463 -3386
+ Partials 2054 390 -1664
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1075 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: comment. The fix works and its tests go red on main, but one product question needs an answer first: downloaded cards on cloud now show and upload under the hashed stored name.
Nothing here blocks merge. I'd like the author to answer the two questions and tidy the tests before a human approves.
- P2, question (inline on
eventUtils.ts:57): a card that has to be downloaded now has its chip renamed to the stored name, which on cloud is the hash. The description says no UI changed. - P2 (inline on
AgentPanelRoot.test.ts:4312): no test fails if the verdict judgesfilenamebefore the ref. - P2: no browser test drags a hashed card with a misleading label (item 5 below).
- P3, question (inline on
AgentPanelRoot.vue:1847): the verdict ranks the ref abovefilename, but the upload name ranksfilenameabove the ref. - P3: multi-output cards are now judged by the first output's stored name (item 6), plus test-placement and description items below and inline.
Findings without an anchorable line
-
P3: the stored-name order has no unit row.
src/utils/eventUtils.test.ts:101-123already holds thefetchDroppedAsset({ nameFromSource: true })naming table, and this PR adds no row to it. Placingfilenameafter the URL basename insourceFileNamepasses both eventUtils test files (35 passed) and the attach-flow component tests. One row in that table catches it in milliseconds. In my run the row below also failed whenfilenamewas dropped or moved after the label. That file is outside the diff, so here is the row:[ 'the stored file name outranks the storage key and the label', 'https://storage/bucket/0123456789abcdef0123456789abcdef.png', { filename: 'abcdef.heic', ref: 'blake3:abcdef' }, 'abcdef.heic' ]
The table would need a
sourcecolumn spread into the asset ({ name: 'Holiday.v2', uri: 'https://api/assets/abc/content', ...source }), with the two existing rows passing{ ref: 'cat.png' }. -
P3: the "explicit filename parameter over everything" test leaves out the new candidate.
src/utils/eventUtils.test.ts:125-136gives the asset nofilename, so movingfilenameabove the?filename=query parameter passes. Addingfilename: 'stored.png'to that fixture makes the test fail under that mutation. -
P3: the description overstates the local case. "Local ComfyUI already did this, because its download URL carries the stored name" holds only when
getAssetFileUrlreturns a/view?filename=URL, which happens when the assets API is off. With assets enabled the URL is/api/assets/<id>/contentwith nofilenamequery, so base fell back to the URL basename and then the label. The code at head handles both cases; only the sentence needs a qualifier. -
P3: one more agent-only naming rule in the generic
eventUtils.ts.sourceFileNameruns only whennameFromSourceis true, andAgentPanelRoot.vue:1897is the only caller that sets it. This PR addsfilenameto that agent-only order. You list moving it out (T7/T8) as follow-up work, so I'm only noting that the deferred area grew by one candidate. -
P2: a browser case for the user-visible path. The three specs you ran (
agentComposerAssetDrop,agentAttachFileTypes,agentUploadedImageAttachment) don't reach the changed branch: the drop spec seeds{ ...AGENT_VIDEO_ASSET, display_name: null }(agentComposerAssetDrop.spec.ts:38-44), and that fixture has nohash(assetFixtures.ts:67-76). The component tests build theAssetItemby hand, so only a browser case covers the real path from the asset-list response to the card tostartAssetDrag. A mapper that put the label intonameor droppedhashwould bring the bug back, and every unit test would still pass. One case in a new top-leveldescribeinagentComposerAssetDrop.spec.ts, with its own boot as the hostile-filename describe has, would cover it:- seed one asset with
name: 'abcdef0123456789.png',hash: 'blake3:abcdef0123456789',display_name: 'Flux.dev' - drag its card from the assets tab onto the agent panel
- expect the
Flux.devchip, no unsupported-type status, and an enabled Send after typing
- seed one asset with
Existing findings confirmed or contested
-
CodeRabbit's grouped-card hardening proposal (summary comment): confirmed, P3, and this PR gives it more weight.
startAssetDragtakesfilenameanddisplay_namefromallOutputs[0](assetDragUtil.ts:79-87), butattachment_refcomes from the card's representative, the last previewable output (assetMappers.ts:114-120). Cloud refs are extensionless hashes, so the verdict for a grouped cloud card falls through to the first output's names. Before this PR it used that output'sdisplay_name. When that had no extension, the verdict wasunknownand the card was staged by its own ref. Now the first output'sfilenamedecides. I reproduced this with the realunflattenOutputAssetsandstartAssetDrag: a job whose first output isfirst.usdzwith display nameMy scene, and whose card showscard.png, isrejectedat head and wasunknownon base, which attached the PNG. The user sees "My scene isn't a file type the agent accepts" on a card that shows a PNG. The description already names this limitation, and it needs an extensionless display name on the first output, so I rate it P3. The fix belongs inassetDragUtil.ts: takefilenameanddisplay_namefrom the output whoseassetIdmatches the representative. -
CodeRabbit's E2E suggestion (pre-merge check): case 1 confirmed, cases 2 and 3 contested. The valid-stored-name case is item 5. The refused-type case is already covered by the new component test, and the download-naming case belongs in the eventUtils table row in item 1, which proves it at a lower level without content and upload routes.
Unverified
- P3:
filenamenow outranks the basename ofresponse.url. If the content endpoint redirects to a URL whose last segment is the real file name, a multi-output card's bytes would be uploaded under the first output's name. With a redirect to.../second-stored.json, head names the filefirst.txtand base named itsecond-stored.json. Whether cloud's/api/assets/<id>/contentever redirects to such a URL is unverified. Capturingresponse.urlfor one real cloud fetch settles it. The fix for item 6 removes this case as well.
Checked and cleared
- Adding
filenameto the producer round-trip assertion inassetDragUtil.test.ts: not needed.assetPanelDragcalls the realstartAssetDrag(AgentPanelRoot.test.ts:2422), so a producer that writes the label intofilenamealready fails the new rows at line 4329. stubUploadFetchanswers every non-upload fetch with a thread list, so the "downloaded".heicbytes are JSON: true, but the helper and its catch-all are unchanged from base.- The mock count in
AgentPanelRoot.test.ts: every double predates this PR, and the new tests add none. - Canvas drops:
extractFilesFromDragEventstill callsfetchDroppedAssetwithoutnameFromSource, so the new field does not change canvas file names (head and base both giveHoliday.heic). - Comments,
any, assertions, suppressions,dark:, class arrays, PrimeVue, raw error sinks: none in the diff. - Open PRs: none conflict. #20339 changes cloud
getAssetFileUrlto/view?filename=<hash>; that query value has no extension, so the payloadfilenamestill decides.
Coverage
- Depth standard, head
391d838. Correctness, maintainability and tests lanes ran with their standard lenses. The diff adds no comment blocks. - Red and green: with
eventUtils.tsandAgentPanelRoot.vuereverted to main, all five new tests fail. At head,AgentPanelRoot.test.ts,__tests__/eventUtils.test.tsandassetDragUtil.test.tspass (460 tests). - With only the verdict change, the download test still fails, as the description says.
- Mutations were run in a separate worktree against the attach-flow tests and both eventUtils test files:
||for??,filenamedropped or moved insourceFileName, verdict by label,filenamebefore the ref in the verdict, andfilenamedropped fromgetDroppedAsset. - CI at this head: all check runs succeeded or were skipped, including typecheck, lint, knip, Fallow and every Playwright shard.
- Not traced: real cloud redirect behavior (item 8). I did no manual run against cloud.
| const resolvedUrl = new URL(responseUrl || uri, 'http://localhost') | ||
| const named = [ | ||
| resolvedUrl.searchParams.get('filename'), | ||
| filename, |
There was a problem hiding this comment.
P2, question. Putting the stored name first here changes what the user sees on cloud. addDeferredFile stages the chip under the label, and once the download finishes uploadFile runs options.update(id, { name: file.name }) (useAttachment.ts:310-313), so the chip switches to this name. On cloud the stored name is the hash (abcdef0123456789.heic in your own test).
Before this PR, a card labelled Holiday.heic was uploaded as Holiday.heic and kept that chip. Now it is uploaded as the hash, and the chip turns into the hash partway through the upload. Cards staged by ref keep their label, so one turn can mix labels and hashes. I reproduced the naming half with the real startAssetDrag payload: head names the file abc.heic, base named it Holiday.heic. This also contradicts "No screenshots, because no UI changed" in the description.
Which name should the user see? The options I see:
- keep the label for the chip and the upload when its extension matches the stored one, and fall back to the stored name only when the label has no extension or a different one
- upload as
<label stem>.<stored extension> - keep the stored name, and add before/after screenshots of the chip to the description
Prose because this needs a product decision.
| const fromRef = asset.ref ? agentAttachRefVerdict(asset.ref) : 'unknown' | ||
| return fromRef === 'unknown' ? agentAttachVerdict(asset.name) : fromRef | ||
| return fromRef === 'unknown' | ||
| ? agentAttachVerdict(asset.filename ?? asset.name) |
There was a problem hiding this comment.
P3, question. The verdict and the upload name now rank the stored name differently. Here the ref wins when it has a recognized extension and filename comes second. In sourceFileName (eventUtils.ts:55-61) filename comes before ref.
With { name: 'Label', filename: 'stored.pdf', ref: 'hash.png' } on the fetch path, the panel accepts the card because of hash.png and uploads it as stored.pdf. I ran the real agentAttachRefVerdict, agentAttachVerdict and fetchDroppedAsset on that input and got verdict= accepted uploadName= stored.pdf. The two only disagree when both names carry different extensions, which today takes a multi-output card or a dotted hash, so this is minor.
No test pins either order. Moving filename after ref in sourceFileName passes the attach-flow tests and both eventUtils test files, and so does checking filename before ref here. Which order do you intend? If the ref should win in both places, moving filename below ref in sourceFileName gives the same name for extensionless cloud hashes and makes the two orders match. Prose because the fix is in the other file and depends on that answer.
| return uri || ref | ||
| ? { | ||
| name: name ?? ref ?? uri!, | ||
| filename: asset?.filename, |
There was a problem hiding this comment.
P3 Nit. zResultItem.filename is z.string().optional(), so a payload can carry filename: '', for example from another tab, another frontend version, or an asset with an empty name. droppedAssetVerdict then passes '' through ??, gets unknown, and never looks at the label. sourceFileName skips the empty string instead. With label brief.pdf and filename: '', head returns unknown where base returned rejected. Normalizing at the parse gives both readers the same meaning of "no stored name".
| filename: asset?.filename, | |
| filename: asset?.filename || undefined, |
|
|
||
| export interface DroppedAsset { | ||
| name: string | ||
| filename?: string |
There was a problem hiding this comment.
P3 Nit. DroppedAsset now has name, which holds the display label (display_name ?? filename ?? ref ?? uri), right next to filename, which holds the stored name. Nothing on the type says which is which, and the bug this PR fixes came from judging a card by name as if it were the file name. Renaming name to label would make the two read differently at every use in AgentPanelRoot.vue (lines 1857-1901). Prose because the rename touches unchanged lines in two files. It would fit in the deferred T7/T8 move.
| it.for(['Flux.dev', 'render.v2', 'Upscale 1.5x'])( | ||
| 'attaches a hashed image card labelled %s by its stored file name', |
There was a problem hiding this comment.
P3. The three labels take one path. On main each has an extension the panel does not accept, so agentAttachVerdict(label) returned rejected. With the fix all three are judged by the stored .png. Every mutation I ran failed all three rows together or none of them, so two of the rows add runtime without catching anything the first one misses.
The body also repeats the existing producer-payload table at line 2674 (same assetPanelDrag, drop, attachments equality and empty uploaded), apart from the hash and name overrides. I'd add one row there, for example { displayName: 'Flux.dev', overrides: { name: 'abcdef0123456789.png', hash: 'blake3:abcdef0123456789' }, label: 'Flux.dev', ref: 'blake3:abcdef0123456789' }, give the existing rows overrides: {} and ref: 'stored-library.png', pass overrides to assetPanelDrag, assert ref, and delete this it.for. Prose because the change spans this block and the table at lines 2674-2708.
| const uploaded = stubUploadFetch() | ||
| renderWithSelectedTarget() | ||
| await nextTick() | ||
| const data = assetPanelDrag(label, { | ||
| name: 'abcdef0123456789.png', | ||
| hash: 'blake3:abcdef0123456789' | ||
| }) | ||
|
|
||
| dispatchDrag(screen.getByRole('textbox'), 'drop', data) | ||
|
|
||
| await screen.findByRole('group', { name: label }) | ||
| expect(useAgentComposerStore().attachments).toEqual([ | ||
| expect.objectContaining({ | ||
| name: label, | ||
| ref: 'blake3:abcdef0123456789' | ||
| }) | ||
| ]) | ||
| expect(screen.queryByRole('status')).not.toBeInTheDocument() | ||
| await userEvent.type(screen.getByRole('textbox'), 'Describe this') | ||
| expect(screen.getByRole('button', { name: 'Send' })).not.toHaveAttribute( | ||
| 'aria-disabled' | ||
| ) | ||
| expect(uploaded).toEqual([]) |
There was a problem hiding this comment.
P3. If you keep this test, the status check and the uploaded check follow from the attachments equality: a refused chip has ref: '' (your next test asserts that), and an uploaded file would carry the upload's ref instead of the hash. In my mutation runs every failure in these rows landed on line 4329. I'd keep the Send check, since a blocked Send is the symptom the PR fixes and objectContaining does not rule out validationError or uploading.
| const uploaded = stubUploadFetch() | |
| renderWithSelectedTarget() | |
| await nextTick() | |
| const data = assetPanelDrag(label, { | |
| name: 'abcdef0123456789.png', | |
| hash: 'blake3:abcdef0123456789' | |
| }) | |
| dispatchDrag(screen.getByRole('textbox'), 'drop', data) | |
| await screen.findByRole('group', { name: label }) | |
| expect(useAgentComposerStore().attachments).toEqual([ | |
| expect.objectContaining({ | |
| name: label, | |
| ref: 'blake3:abcdef0123456789' | |
| }) | |
| ]) | |
| expect(screen.queryByRole('status')).not.toBeInTheDocument() | |
| await userEvent.type(screen.getByRole('textbox'), 'Describe this') | |
| expect(screen.getByRole('button', { name: 'Send' })).not.toHaveAttribute( | |
| 'aria-disabled' | |
| ) | |
| expect(uploaded).toEqual([]) | |
| stubUploadFetch() | |
| renderWithSelectedTarget() | |
| await nextTick() | |
| const data = assetPanelDrag(label, { | |
| name: 'abcdef0123456789.png', | |
| hash: 'blake3:abcdef0123456789' | |
| }) | |
| dispatchDrag(screen.getByRole('textbox'), 'drop', data) | |
| await screen.findByRole('group', { name: label }) | |
| expect(useAgentComposerStore().attachments).toEqual([ | |
| expect.objectContaining({ | |
| name: label, | |
| ref: 'blake3:abcdef0123456789' | |
| }) | |
| ]) | |
| await userEvent.type(screen.getByRole('textbox'), 'Describe this') | |
| expect(screen.getByRole('button', { name: 'Send' })).not.toHaveAttribute( | |
| 'aria-disabled' | |
| ) |
| } | ||
| ) | ||
|
|
||
| it('refuses a hashed card whose stored file is a refused type behind an extensionless label', async () => { |
There was a problem hiding this comment.
P3. This is the existing stages an opaque asset card with a rejected label as an invalid chip test (line 4185) plus a display label: the same hashed ref with no extension, the same .usdz stored file, the same refusal status. The older test hand-builds a payload with no display_name, which is why it passed on main. One it.for over displayName: [null, 'My scene'], expecting abcdef0123456789.usdz or My scene as the label and driven by assetPanelDrag, would cover both cases and retire the hand-built payload. Prose because it merges two separate tests.
| const uploaded = stubUploadFetch() | ||
| renderWithSelectedTarget() | ||
| await nextTick() | ||
| const data = assetPanelDrag('My scene', { | ||
| name: 'abcdef0123456789.usdz', | ||
| hash: 'blake3:abcdef0123456789' | ||
| }) | ||
|
|
||
| dispatchDrag(screen.getByRole('textbox'), 'drop', data) | ||
|
|
||
| expect( | ||
| await screen.findByRole('status', { | ||
| name: unsupportedTypeMessage('My scene') | ||
| }) | ||
| ).toBeVisible() | ||
| expect(useAgentComposerStore().attachments).toEqual([ | ||
| expect.objectContaining({ | ||
| name: 'My scene', | ||
| ref: '', | ||
| validationError: 'unsupported-type' | ||
| }) | ||
| ]) | ||
| expect(fetchRequests(data.getData('text/uri-list'))).toEqual([]) | ||
| expect(uploaded).toEqual([]) |
There was a problem hiding this comment.
P3 Nit. A dropped card can only be uploaded after fetchDroppedAsset fetches it (AgentPanelRoot.vue:1894-1898), so an empty fetchRequests(...) already shows nothing was uploaded. The fetchRequests check is the one to keep, since it also catches a design that downloads before judging.
| const uploaded = stubUploadFetch() | |
| renderWithSelectedTarget() | |
| await nextTick() | |
| const data = assetPanelDrag('My scene', { | |
| name: 'abcdef0123456789.usdz', | |
| hash: 'blake3:abcdef0123456789' | |
| }) | |
| dispatchDrag(screen.getByRole('textbox'), 'drop', data) | |
| expect( | |
| await screen.findByRole('status', { | |
| name: unsupportedTypeMessage('My scene') | |
| }) | |
| ).toBeVisible() | |
| expect(useAgentComposerStore().attachments).toEqual([ | |
| expect.objectContaining({ | |
| name: 'My scene', | |
| ref: '', | |
| validationError: 'unsupported-type' | |
| }) | |
| ]) | |
| expect(fetchRequests(data.getData('text/uri-list'))).toEqual([]) | |
| expect(uploaded).toEqual([]) | |
| stubUploadFetch() | |
| renderWithSelectedTarget() | |
| await nextTick() | |
| const data = assetPanelDrag('My scene', { | |
| name: 'abcdef0123456789.usdz', | |
| hash: 'blake3:abcdef0123456789' | |
| }) | |
| dispatchDrag(screen.getByRole('textbox'), 'drop', data) | |
| expect( | |
| await screen.findByRole('status', { | |
| name: unsupportedTypeMessage('My scene') | |
| }) | |
| ).toBeVisible() | |
| expect(useAgentComposerStore().attachments).toEqual([ | |
| expect.objectContaining({ | |
| name: 'My scene', | |
| ref: '', | |
| validationError: 'unsupported-type' | |
| }) | |
| ]) | |
| expect(fetchRequests(data.getData('text/uri-list'))).toEqual([]) |
|
|
||
| await vi.waitFor(() => expect(uploaded).toEqual(['abcdef0123456789.heic'])) | ||
| expect(fetchRequests(data.getData('text/uri-list'))).toHaveLength(1) | ||
| expect(screen.queryByRole('status')).not.toBeInTheDocument() |
There was a problem hiding this comment.
P3 Nit. Once uploaded equals ['abcdef0123456789.heic'], there can be no refusal status, because the panel uploads only accepted files. None of my mutations reached this line; the ones that broke this test failed at line 4382.
| expect(screen.queryByRole('status')).not.toBeInTheDocument() |
| @@ -4312,6 +4312,78 @@ describe('AgentPanelRoot attach flow', () => { | |||
| expect(useToast().toasts).toEqual([]) | |||
There was a problem hiding this comment.
P2. The test this line closes (line 4290) is the only one that pits a ref with an extension against a different filename, which is the "ref first" half of the order in the PR description. It checks only that a group named renamed.usdz exists and that no toast appeared. A refused chip renders the same group with no toast. So if droppedAssetVerdict judged filename before ref, this test and the other attach-flow tests would still pass (10 passed in my run). Asserting the staged ref catches it: under that mutation it fails with - "ref": "stored.png" + "ref": "".
The title also clashes with this PR's wording. The new tests use "stored file name" for filename, while judges an asset by its stored filename rather than its display label means the ref. A title like judges an asset by its ref ahead of its file name would match what it checks. Line 4290 is outside the diff, so I can't put that in a suggestion.
| expect(useToast().toasts).toEqual([]) | |
| expect(useAgentComposerStore().attachments).toEqual([ | |
| expect.objectContaining({ name: 'renamed.usdz', ref: 'stored.png' }) | |
| ]) | |
| expect(useToast().toasts).toEqual([]) |
dante01yoon
left a comment
There was a problem hiding this comment.
The fix looks right to me. Judging by the stored file name follows the #19601 review thread, the drag payload already carries filename, and the new tests use the real startAssetDrag payload (the description says they fail on main). Gates are clean: DroppedAsset is a frontend-only type, not an API response.
I'm holding approval on one open product question that I agree with and won't repeat inline: #21075 (comment) (eventUtils.ts:57). On cloud the stored name is a hash, so a card that has to be downloaded (e.g. .heic) now uploads as <hash>.heic, and its chip changes from the label to the hash mid-upload. That is a visible change, but the description says no UI changed. Could you confirm the intended name, or keep the label and use the stored name only for the verdict/extension? The verdict-vs-upload order question in the same review (#21075 (comment)) also still needs an answer. Once both are answered, I'm happy to approve.
Summary
Dragging an asset card into the agent panel on cloud judged the file by its display label instead of its stored file name. A PNG labelled
Flux.dev,render.v2orUpscale 1.5xbecame an invalid file and blocked Send, while a stored.usdzbehind a label likeMy scenewas attached and sent. Cards are now judged by their stored file name. Follow-up to #19601 (review thread #19601 (comment)).What the user sees:
.heic) is uploaded under its stored file name, and its chip shows that name once the download finishes. Local ComfyUI already did this, because its download URL carries the stored name.Notes:
src/utils/eventUtils.tsand share one extension rule (T7/T8), collapse the three-way verdict (T5), read?filename=after a redirect for drags without a stored name (T2), and drops on the chat-history view (T3).Verification
AgentPanelRoottests use the realstartAssetDragpayload (Flux.dev/render.v2/Upscale 1.5xwith a stored.png, a stored.usdzbehindMy scene, a stored.heicthat has to be downloaded). All 5 fail on main3da607ac16and pass with the fix. With only the judging change, the download test still fails (the file is named after the label).pnpm test:unit src/workbench/extensions/agent src/utils src/platform/assets: 289 files, 5445 passed, 1 expected fail.typecheck:app, oxfmt, oxlint (type-aware), eslint, knip and the changed-line Fallow audit pass (also run by the commit and push hooks).pnpm build:cloudoutput, 1 worker, no retries:agentComposerAssetDrop,agentAttachFileTypes,agentUploadedImageAttachment, 17/17 passed.