Repository navigation
[backport cloud/1.57] FE-3446 fix(billing): name the pending top-up instead of an unknown error - #21074
Conversation
…rror (#21056) ## Why In 1.57 QA on testcloud, a 3DS top-up whose verification failed left its operation `pending` (`authentication_state: failed_retryable`). Pressing **Add credits** again in the in-app top-up dialog then showed "Purchase failed: An unknown error occurred". Nothing was charged and no request was sent, but the message gives the customer no way to know what to do. ## Root cause Before issuing a top-up, the billing SDK reads the billing status. When the server already has a top-up pending, `resubmitTarget` in `operationLifecycle.ts` refuses the new one with `OPERATION_ALREADY_PENDING` and sends no `POST /api/billing/topup`. That guard is correct (one charge at a time). The problem is `topupFailureError` in `topupOperationView.ts`: it turns every SDK refusal into `credits.topUp.unknownError`. ## How - `topupFailureError` maps `OPERATION_ALREADY_PENDING` to a new top-up message, `billingOperation.topupAlreadyPendingDetail`, with failure category `stale_operation`. `subscriptionOperationView.ts` already does the same for subscriptions. Its existing string talks about choosing a plan, so top-ups get their own. - A unit test in `topupOperationView.test.ts` checks the message, code and failure category. It fails on `main`. No backport label: the 1.57 release doesn't strictly need this. ## AS IS / TO BE Local dev server against testcloud, signed in, in-app top-up dialog: Add credits → Verify your payment → Start over → Pay. To get a pending top-up without leaving a real stuck charge on a shared account, the page answered `GET /api/billing/status` with `pending_billing_op_id` + `pending_billing_op_type: topup` and `GET /api/billing/ops/<id>` with the payload Chae reported (`pending`, `in_progress`, `failed_retryable`). Every non-GET billing request was blocked; none was attempted. AS IS = `topupOperationView.ts` from `main`, TO BE = this branch. | AS IS | TO BE | | --- | --- | | <img width="760" alt="AS IS: Purchase Failed, An unknown error occurred" src="https://github.com/user-attachments/assets/71536beb-75ce-4c6a-8642-12f29a940d7e" /> | <img width="760" alt="TO BE: A top-up you started earlier is still going through" src="https://github.com/user-attachments/assets/14c8a0e4-d9f6-4d68-917d-244bc1b840cf" /> | ## Plan position | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Capabilities read with unified_web_session off | FE-3441 | #21004 | Merged | | **Pending top-up message in the in-app dialog** | **FE-3446** | **this PR** | **In review** | ```mermaid graph LR A["FE-3441 capabilities read (PR 21004)"] B["FE-3446 pending top-up message (this PR)"] style B fill:#ffd54f,stroke:#f57f17 ```
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-15T03:38:24.679Z",
"gitSha": "c03c17e71107e7d9585693ef6ba2406ac718f8c3",
"branch": "backport-21056-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.29699999998,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9779999999999998,
"layouts": 9,
"layoutDurationMs": 3.2390000000000008,
"taskDurationMs": 391.474,
"heapDeltaBytes": 22114488,
"heapUsedBytes": 87913792,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.487999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2021.5239999999994,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.1930000000000005,
"layouts": 10,
"layoutDurationMs": 3.3269999999999995,
"taskDurationMs": 407.746,
"heapDeltaBytes": 22126296,
"heapUsedBytes": 88121168,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 12.381,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1968.6980000000176,
"styleRecalcs": 82,
"styleRecalcDurationMs": 17.025,
"layouts": 9,
"layoutDurationMs": 2.618,
"taskDurationMs": 930.6529999999999,
"heapDeltaBytes": 15614184,
"heapUsedBytes": 81470528,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 151.812,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491525,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1810.416000000032,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.703000000000001,
"layouts": 9,
"layoutDurationMs": 2.732,
"taskDurationMs": 881.39,
"heapDeltaBytes": 15621836,
"heapUsedBytes": 81529744,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 148.28799999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.0320000000265,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.788,
"layouts": 12,
"layoutDurationMs": 3.656,
"taskDurationMs": 430.37899999999996,
"heapDeltaBytes": -405084,
"heapUsedBytes": 74487744,
"domNodes": 47,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 13.671999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1703.341000000023,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.433000000000001,
"layouts": 11,
"layoutDurationMs": 3.336,
"taskDurationMs": 327.5439999999999,
"heapDeltaBytes": 18663324,
"heapUsedBytes": 84560480,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 14.169,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 617.2980000000052,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.6990000000000007,
"layouts": 10,
"layoutDurationMs": 3.017,
"taskDurationMs": 438.80800000000005,
"heapDeltaBytes": 26115500,
"heapUsedBytes": 91857416,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 164.602,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 684.6849999999449,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.281,
"layouts": 9,
"layoutDurationMs": 3.133,
"taskDurationMs": 488.11,
"heapDeltaBytes": 25250428,
"heapUsedBytes": 91169372,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 170.626,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1223.8859999999931,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 919.442,
"heapDeltaBytes": -13205408,
"heapUsedBytes": 80830952,
"domNodes": -192,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 66.035,
"eventListeners": -106,
"totalBlockingTimeMs": 509,
"frameDurationMs": 32.018421052631574,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1211.8659999999863,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 920.891,
"heapDeltaBytes": -11785160,
"heapUsedBytes": 80893692,
"domNodes": -192,
"jsHeapTotalBytes": 19406848,
"scriptDurationMs": 63.510999999999996,
"eventListeners": -105,
"totalBlockingTimeMs": 521,
"frameDurationMs": 32.018421052631574,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 814.0459999999621,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.12500000000034,
"heapDeltaBytes": -5151004,
"heapUsedBytes": 75401544,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 135.57799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 182,
"frameDurationMs": 24.020588235294113,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 826.2750000000096,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.06699999999967,
"heapDeltaBytes": -3612016,
"heapUsedBytes": 76274704,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 143.411,
"eventListeners": 0,
"totalBlockingTimeMs": 193,
"frameDurationMs": 24.50882352941177,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9893.293000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8977.866,
"heapDeltaBytes": -25455328,
"heapUsedBytes": 73917124,
"domNodes": -258,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 6952.695,
"eventListeners": -68,
"totalBlockingTimeMs": 334,
"frameDurationMs": 28.69449275362319,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9324.64200000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8424.166,
"heapDeltaBytes": -3687472,
"heapUsedBytes": 96160200,
"domNodes": -258,
"jsHeapTotalBytes": 7204864,
"scriptDurationMs": 6556.387999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 174,
"frameDurationMs": 27.892814371257483,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8988.746999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8081.842999999999,
"heapDeltaBytes": -3472036,
"heapUsedBytes": 96492764,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 6582.821,
"eventListeners": -68,
"totalBlockingTimeMs": 269,
"frameDurationMs": 29.744701986754965,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8735.344999999996,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.31500000000000017,
"layouts": 1,
"layoutDurationMs": 0.3139999999999996,
"taskDurationMs": 7928.160999999999,
"heapDeltaBytes": -15366972,
"heapUsedBytes": 84268504,
"domNodes": -258,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 6419.886999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 263,
"frameDurationMs": 30.641754385964916,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 247.65800000000127,
"styleRecalcs": 24,
"styleRecalcDurationMs": 19.919,
"layouts": 12,
"layoutDurationMs": 4.715000000000001,
"taskDurationMs": 190.648,
"heapDeltaBytes": -9017328,
"heapUsedBytes": 78714928,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.155000000000001,
"eventListeners": 195,
"totalBlockingTimeMs": 11,
"frameDurationMs": 25.922222222222192,
"p95FrameDurationMs": 100.00000000000045
},
{
"name": "large-combo-open",
"durationMs": 241.94899999997688,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.872999999999998,
"layouts": 11,
"layoutDurationMs": 3.412,
"taskDurationMs": 184.897,
"heapDeltaBytes": -8191824,
"heapUsedBytes": 79578412,
"domNodes": 917,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.021,
"eventListeners": 195,
"totalBlockingTimeMs": 2,
"frameDurationMs": 20.833333333333332,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2051.9989999999666,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.843,
"layouts": 6,
"layoutDurationMs": 2.0349999999999997,
"taskDurationMs": 719.794,
"heapDeltaBytes": -3194540,
"heapUsedBytes": 75876680,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 36.661,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2040.4839999999922,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3689999999999998,
"layouts": 8,
"layoutDurationMs": 2.4329999999999994,
"taskDurationMs": 653.087,
"heapDeltaBytes": -19793228,
"heapUsedBytes": 77568020,
"domNodes": -258,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 30.389000000000006,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2412.475000000029,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.279999999999999,
"layouts": 7,
"layoutDurationMs": 1.975,
"taskDurationMs": 1776.4609999999998,
"heapDeltaBytes": -26388492,
"heapUsedBytes": 71179144,
"domNodes": -258,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 833.784,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665972222222226,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2344.0879999999424,
"styleRecalcs": 68,
"styleRecalcDurationMs": 5.948,
"layouts": 6,
"layoutDurationMs": 1.6280000000000001,
"taskDurationMs": 1699.465,
"heapDeltaBytes": -2813828,
"heapUsedBytes": 77019060,
"domNodes": -258,
"jsHeapTotalBytes": 3760128,
"scriptDurationMs": 807.769,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.028260869565223,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3781.772999999987,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.906,
"layouts": 64,
"layoutDurationMs": 11.509,
"taskDurationMs": 1852.4519999999998,
"heapDeltaBytes": -18757232,
"heapUsedBytes": 80542908,
"domNodes": -234,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 777.9699999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.739823008849555,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3645.2449999999317,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.263,
"layouts": 65,
"layoutDurationMs": 11.429,
"taskDurationMs": 1657.394,
"heapDeltaBytes": -9052352,
"heapUsedBytes": 72468108,
"domNodes": -234,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 781.201,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.742396313364058,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3014.3130000000156,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.177999999999999,
"layouts": 6,
"layoutDurationMs": 1.6620000000000004,
"taskDurationMs": 1800.1450000000002,
"heapDeltaBytes": 14714836,
"heapUsedBytes": 97801896,
"domNodes": 0,
"jsHeapTotalBytes": 7495680,
"scriptDurationMs": 950.22,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758333333333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2970.2270000000226,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.178999999999999,
"layouts": 5,
"layoutDurationMs": 1.5540000000000003,
"taskDurationMs": 1800.5850000000003,
"heapDeltaBytes": 14253812,
"heapUsedBytes": 98272544,
"domNodes": 0,
"jsHeapTotalBytes": 6971392,
"scriptDurationMs": 961.292,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.952,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2011.103999999989,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.889,
"layouts": 6,
"layoutDurationMs": 2.034,
"taskDurationMs": 504.173,
"heapDeltaBytes": -3990132,
"heapUsedBytes": 77501744,
"domNodes": -278,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 32.157000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.4559999999246,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0510000000000006,
"layouts": 6,
"layoutDurationMs": 1.6980000000000004,
"taskDurationMs": 523.7120000000001,
"heapDeltaBytes": -5679924,
"heapUsedBytes": 76460548,
"domNodes": -278,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 32.10900000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 657.1670000000154,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.035,
"layouts": 8,
"layoutDurationMs": 2.5889999999999995,
"taskDurationMs": 452.68299999999994,
"heapDeltaBytes": 21588296,
"heapUsedBytes": 88351660,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 147.79500000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 622.1189999999979,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.0600000000000005,
"layouts": 9,
"layoutDurationMs": 2.7430000000000003,
"taskDurationMs": 438.77899999999994,
"heapDeltaBytes": 21633720,
"heapUsedBytes": 88468820,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 143.182,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2010.8569999999872,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4330000000000003,
"layouts": 8,
"layoutDurationMs": 2.674,
"taskDurationMs": 539.449,
"heapDeltaBytes": 22386052,
"heapUsedBytes": 89249860,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.407000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.0040000000145,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.758,
"layouts": 9,
"layoutDurationMs": 2.816,
"taskDurationMs": 378.30699999999996,
"heapDeltaBytes": 21609220,
"heapUsedBytes": 88758996,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.622000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.9609999999743,
"styleRecalcs": 79,
"styleRecalcDurationMs": 16.811,
"layouts": 10,
"layoutDurationMs": 2.7849999999999997,
"taskDurationMs": 882.0020000000001,
"heapDeltaBytes": -11381784,
"heapUsedBytes": 65968652,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 105.395,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2008.224000000041,
"styleRecalcs": 87,
"styleRecalcDurationMs": 17.320999999999998,
"layouts": 9,
"layoutDurationMs": 3.136,
"taskDurationMs": 1119.7459999999999,
"heapDeltaBytes": -11298140,
"heapUsedBytes": 65931144,
"domNodes": -172,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 108.908,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.9329999999618,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.021,
"layouts": 5,
"layoutDurationMs": 14.189,
"taskDurationMs": 1027.3389999999997,
"heapDeltaBytes": 7244732,
"heapUsedBytes": 104175296,
"domNodes": 15953,
"jsHeapTotalBytes": 18223104,
"scriptDurationMs": 29.999,
"eventListeners": 3244,
"totalBlockingTimeMs": 147,
"frameDurationMs": 19.4054794520548,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8462.673999999992,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.085,
"layouts": 7,
"layoutDurationMs": 2.206,
"taskDurationMs": 6129.943,
"heapDeltaBytes": -7197356,
"heapUsedBytes": 71965468,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 2666.684,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73181818181818,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8461.418999999978,
"styleRecalcs": 251,
"styleRecalcDurationMs": 19.334,
"layouts": 9,
"layoutDurationMs": 3.022,
"taskDurationMs": 6116.63,
"heapDeltaBytes": -17393136,
"heapUsedBytes": 79596692,
"domNodes": -258,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 2678.1189999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73207920792079,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14187.378000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13531.616,
"heapDeltaBytes": -4426556,
"heapUsedBytes": 267754280,
"domNodes": -3330,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 220.55400000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.326428571428572,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 20992.346999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20529.19,
"heapDeltaBytes": -35289440,
"heapUsedBytes": 265386848,
"domNodes": -3330,
"jsHeapTotalBytes": 14405632,
"scriptDurationMs": 295.907,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.806306306306304,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 16628.202999999987,
"styleRecalcs": 89,
"styleRecalcDurationMs": 9.11199999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16100.166000000001,
"heapDeltaBytes": 10168564,
"heapUsedBytes": 294561860,
"domNodes": -3330,
"jsHeapTotalBytes": 18796544,
"scriptDurationMs": 792.902,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.731071428571425,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 25769.788999999946,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.44900000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25499.983,
"heapDeltaBytes": -16368336,
"heapUsedBytes": 274566164,
"domNodes": -3330,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 933.4239999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 4,
"frameDurationMs": 48.431578947368415,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7476.447000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.364,
"layouts": 20,
"layoutDurationMs": 24.652000000000008,
"taskDurationMs": 7408.294,
"heapDeltaBytes": -28741560,
"heapUsedBytes": 270737928,
"domNodes": -3330,
"jsHeapTotalBytes": 13881344,
"scriptDurationMs": 118.41399999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.1578034682081,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7461.803000000032,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.067,
"layouts": 20,
"layoutDurationMs": 23.608000000000004,
"taskDurationMs": 7393.1449999999995,
"heapDeltaBytes": -19954316,
"heapUsedBytes": 261426760,
"domNodes": -3330,
"jsHeapTotalBytes": 19390464,
"scriptDurationMs": 113.189,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.18248587570621,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10087.012000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9849.717,
"heapDeltaBytes": -3336912,
"heapUsedBytes": 249266012,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 138.21000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.46064981949458,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10069.377000000031,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9755.292000000001,
"heapDeltaBytes": -18415744,
"heapUsedBytes": 253997560,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 139.768,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.20971223021582,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 520.717999999988,
"styleRecalcs": 13,
"styleRecalcDurationMs": 13.378,
"layouts": 12,
"layoutDurationMs": 5.424,
"taskDurationMs": 160.489,
"heapDeltaBytes": -13003052,
"heapUsedBytes": 70345480,
"domNodes": 98,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 14.849,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 447.78999999994085,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.9049999999999985,
"layouts": 10,
"layoutDurationMs": 3.162,
"taskDurationMs": 102.987,
"heapDeltaBytes": -13628860,
"heapUsedBytes": 69967608,
"domNodes": 95,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 9.534999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962965,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 481.5760000000182,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9380000000000001,
"layouts": 76,
"layoutDurationMs": 16.91,
"taskDurationMs": 437.061,
"heapDeltaBytes": -22070004,
"heapUsedBytes": 71686176,
"domNodes": 4,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 203.61300000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 440.550999999914,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3290000000000002,
"layouts": 76,
"layoutDurationMs": 17.026,
"taskDurationMs": 400.048,
"heapDeltaBytes": 10839620,
"heapUsedBytes": 87525940,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 178.925,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 642.5600000000031,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.478,
"layouts": 76,
"layoutDurationMs": 17.636,
"taskDurationMs": 611.73,
"heapDeltaBytes": 377128,
"heapUsedBytes": 106869024,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 247.16100000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 661.5229999999883,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.269,
"layouts": 76,
"layoutDurationMs": 16.722,
"taskDurationMs": 611.141,
"heapDeltaBytes": 585740,
"heapUsedBytes": 119089480,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 234.29999999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.0162162162162,
"p95FrameDurationMs": 16.800000000000182
}
]
}🎭 Playwright: ✅ 2278 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e1eda8f23790d817579ac2e242deab28d3dba015
Full docs: ADR-DEVEX-LINT-0015 |
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport of #21056, diff matches.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21074 +/- ##
=============================================
Coverage ? 87.17%
=============================================
Files ? 2612
Lines ? 146878
Branches ? 38187
=============================================
Hits ? 128037
Misses ? 18453
Partials ? 388
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #21056 to
cloud/1.57Automatically created by backport workflow.