Repository navigation
[backport core/1.57] FE-3446 fix(billing): name the pending top-up instead of an unknown error - #21073
Conversation
…rror (#21056) ## Why In 1.57 QA on testcloud, a 3DS top-up whose verification failed left its operation `pending` (`authentication_state: failed_retryable`). Pressing **Add credits** again in the in-app top-up dialog then showed "Purchase failed: An unknown error occurred". Nothing was charged and no request was sent, but the message gives the customer no way to know what to do. ## Root cause Before issuing a top-up, the billing SDK reads the billing status. When the server already has a top-up pending, `resubmitTarget` in `operationLifecycle.ts` refuses the new one with `OPERATION_ALREADY_PENDING` and sends no `POST /api/billing/topup`. That guard is correct (one charge at a time). The problem is `topupFailureError` in `topupOperationView.ts`: it turns every SDK refusal into `credits.topUp.unknownError`. ## How - `topupFailureError` maps `OPERATION_ALREADY_PENDING` to a new top-up message, `billingOperation.topupAlreadyPendingDetail`, with failure category `stale_operation`. `subscriptionOperationView.ts` already does the same for subscriptions. Its existing string talks about choosing a plan, so top-ups get their own. - A unit test in `topupOperationView.test.ts` checks the message, code and failure category. It fails on `main`. No backport label: the 1.57 release doesn't strictly need this. ## AS IS / TO BE Local dev server against testcloud, signed in, in-app top-up dialog: Add credits → Verify your payment → Start over → Pay. To get a pending top-up without leaving a real stuck charge on a shared account, the page answered `GET /api/billing/status` with `pending_billing_op_id` + `pending_billing_op_type: topup` and `GET /api/billing/ops/<id>` with the payload Chae reported (`pending`, `in_progress`, `failed_retryable`). Every non-GET billing request was blocked; none was attempted. AS IS = `topupOperationView.ts` from `main`, TO BE = this branch. | AS IS | TO BE | | --- | --- | | <img width="760" alt="AS IS: Purchase Failed, An unknown error occurred" src="https://github.com/user-attachments/assets/71536beb-75ce-4c6a-8642-12f29a940d7e" /> | <img width="760" alt="TO BE: A top-up you started earlier is still going through" src="https://github.com/user-attachments/assets/14c8a0e4-d9f6-4d68-917d-244bc1b840cf" /> | ## Plan position | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Capabilities read with unified_web_session off | FE-3441 | #21004 | Merged | | **Pending top-up message in the in-app dialog** | **FE-3446** | **this PR** | **In review** | ```mermaid graph LR A["FE-3441 capabilities read (PR 21004)"] B["FE-3446 pending top-up message (this PR)"] style B fill:#ffd54f,stroke:#f57f17 ```
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport of #21056, diff matches.
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-15T03:38:35.086Z",
"gitSha": "7536d15174f9aa16bc6096f1477a37c7bcafff58",
"branch": "backport-21056-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.1010000000206,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.417,
"layouts": 11,
"layoutDurationMs": 2.802,
"taskDurationMs": 501.1720000000001,
"heapDeltaBytes": -872624,
"heapUsedBytes": 73929800,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 7.865,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.8680000000168,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2900000000000005,
"layouts": 9,
"layoutDurationMs": 2.569,
"taskDurationMs": 479.716,
"heapDeltaBytes": 22131536,
"heapUsedBytes": 87983616,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.473,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.5799999999754,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.21,
"layouts": 10,
"layoutDurationMs": 2.7019999999999995,
"taskDurationMs": 819.819,
"heapDeltaBytes": -7293316,
"heapUsedBytes": 67985092,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 156.072,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1707.365999999979,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.019000000000002,
"layouts": 11,
"layoutDurationMs": 2.966,
"taskDurationMs": 676.8870000000001,
"heapDeltaBytes": 15709572,
"heapUsedBytes": 81497676,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 149.886,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.2309999999843,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.93,
"layouts": 11,
"layoutDurationMs": 2.5000000000000004,
"taskDurationMs": 266.218,
"heapDeltaBytes": 18217288,
"heapUsedBytes": 84567084,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 9.808999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1791.9370000000754,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.274,
"layouts": 12,
"layoutDurationMs": 2.795,
"taskDurationMs": 423.66,
"heapDeltaBytes": 18765880,
"heapUsedBytes": 84932876,
"domNodes": 47,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 9.913000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 587.2099999999705,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.4819999999999998,
"layouts": 9,
"layoutDurationMs": 2.355,
"taskDurationMs": 405.29099999999994,
"heapDeltaBytes": 25700404,
"heapUsedBytes": 91017848,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 166.48000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66285714285714,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 568.0959999999686,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.5839999999999996,
"layouts": 9,
"layoutDurationMs": 2.406,
"taskDurationMs": 414.39399999999995,
"heapDeltaBytes": 24425836,
"heapUsedBytes": 91223752,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 169.792,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1194.49800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 909.3190000000001,
"heapDeltaBytes": 612880,
"heapUsedBytes": 80841928,
"domNodes": -192,
"jsHeapTotalBytes": 15212544,
"scriptDurationMs": 68.47900000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 511,
"frameDurationMs": 32.42972972972972,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1181.2700000000405,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 860.477,
"heapDeltaBytes": 1245668,
"heapUsedBytes": 81326448,
"domNodes": -192,
"jsHeapTotalBytes": 14426112,
"scriptDurationMs": 63.012000000000015,
"eventListeners": -106,
"totalBlockingTimeMs": 494,
"frameDurationMs": 31.978378378378398,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.1489999999881,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.67700000000025,
"heapDeltaBytes": -3152896,
"heapUsedBytes": 76583520,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 153.885,
"eventListeners": 0,
"totalBlockingTimeMs": 237,
"frameDurationMs": 25.49117647058823,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.0540000000283,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.41999999999973,
"heapDeltaBytes": -4735436,
"heapUsedBytes": 76352872,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 157.296,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 25.00000000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9267.186000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8432.47,
"heapDeltaBytes": -10967084,
"heapUsedBytes": 87801828,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 7103.244,
"eventListeners": -68,
"totalBlockingTimeMs": 864,
"frameDurationMs": 33.45234657039712,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9934.068000000081,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9111.292000000001,
"heapDeltaBytes": -11992232,
"heapUsedBytes": 87474620,
"domNodes": -258,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 7376.44,
"eventListeners": -68,
"totalBlockingTimeMs": 611,
"frameDurationMs": 32.14563106796116,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9483.598000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8695.804,
"heapDeltaBytes": 8627952,
"heapUsedBytes": 96123868,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 7019.513,
"eventListeners": -68,
"totalBlockingTimeMs": 688,
"frameDurationMs": 32.14542372881356,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9935.780000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9121.642000000002,
"heapDeltaBytes": -3631700,
"heapUsedBytes": 83469276,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 7430.063,
"eventListeners": -64,
"totalBlockingTimeMs": 741,
"frameDurationMs": 31.633757961783445,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 208.88700000000426,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.120000000000001,
"layouts": 11,
"layoutDurationMs": 3.044,
"taskDurationMs": 159.882,
"heapDeltaBytes": -8105832,
"heapUsedBytes": 79038092,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7.957000000000001,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 202.71700000000692,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.42,
"layouts": 10,
"layoutDurationMs": 2.873,
"taskDurationMs": 154.01899999999998,
"heapDeltaBytes": -7627604,
"heapUsedBytes": 80229900,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7.891,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2025.7210000000327,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.8789999999999996,
"layouts": 8,
"layoutDurationMs": 1.9889999999999999,
"taskDurationMs": 613.3199999999999,
"heapDeltaBytes": -20657128,
"heapUsedBytes": 75797396,
"domNodes": -258,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 30.245,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.8459999999486,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7140000000000002,
"layouts": 8,
"layoutDurationMs": 2.018,
"taskDurationMs": 428.51399999999995,
"heapDeltaBytes": -2634524,
"heapUsedBytes": 76236760,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 28.326999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2372.4559999999997,
"styleRecalcs": 69,
"styleRecalcDurationMs": 5.703999999999999,
"layouts": 8,
"layoutDurationMs": 2.015,
"taskDurationMs": 1643.6320000000003,
"heapDeltaBytes": -30292364,
"heapUsedBytes": 67737888,
"domNodes": -258,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 808.365,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.784397163120563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2254.417999999987,
"styleRecalcs": 68,
"styleRecalcDurationMs": 5.528,
"layouts": 7,
"layoutDurationMs": 1.991,
"taskDurationMs": 1455.75,
"heapDeltaBytes": -11945648,
"heapUsedBytes": 68100696,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 784.137,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78955223880597,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3554.206000000022,
"styleRecalcs": 70,
"styleRecalcDurationMs": 6.556000000000001,
"layouts": 64,
"layoutDurationMs": 9.98,
"taskDurationMs": 1669.3310000000001,
"heapDeltaBytes": -1944092,
"heapUsedBytes": 97344220,
"domNodes": 24,
"jsHeapTotalBytes": 5279744,
"scriptDurationMs": 761.1629999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.744811320754714,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3599.511000000007,
"styleRecalcs": 71,
"styleRecalcDurationMs": 6.853999999999999,
"layouts": 64,
"layoutDurationMs": 9.956,
"taskDurationMs": 1694.114,
"heapDeltaBytes": -13952156,
"heapUsedBytes": 67899288,
"domNodes": -234,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 746.1070000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74372093023256,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2655.192999999997,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.364000000000001,
"layouts": 4,
"layoutDurationMs": 0.8839999999999998,
"taskDurationMs": 1688.7469999999998,
"heapDeltaBytes": 5416004,
"heapUsedBytes": 88504056,
"domNodes": 0,
"jsHeapTotalBytes": 8613888,
"scriptDurationMs": 923.777,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.878343949044584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2825.578999999948,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.710000000000001,
"layouts": 5,
"layoutDurationMs": 1.166,
"taskDurationMs": 1883.1799999999998,
"heapDeltaBytes": 2502476,
"heapUsedBytes": 86060776,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 931.3100000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.967469879518074,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2043.1010000000356,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5520000000000005,
"layouts": 7,
"layoutDurationMs": 1.6689999999999998,
"taskDurationMs": 597.631,
"heapDeltaBytes": -1824684,
"heapUsedBytes": 79623236,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 32.701,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2035.5839999999716,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5269999999999997,
"layouts": 7,
"layoutDurationMs": 1.5890000000000002,
"taskDurationMs": 439.5330000000001,
"heapDeltaBytes": -2489600,
"heapUsedBytes": 78977688,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 30.783999999999992,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.4580000000415,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.22,
"layouts": 9,
"layoutDurationMs": 2.335,
"taskDurationMs": 411.96799999999996,
"heapDeltaBytes": 21441328,
"heapUsedBytes": 89082016,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 147.497,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.6439999999593,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.2620000000000005,
"layouts": 9,
"layoutDurationMs": 2.255,
"taskDurationMs": 421.231,
"heapDeltaBytes": 21671720,
"heapUsedBytes": 88429368,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 144.547,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.3400000000324,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.159000000000001,
"layouts": 9,
"layoutDurationMs": 2.4029999999999996,
"taskDurationMs": 337.146,
"heapDeltaBytes": 22475872,
"heapUsedBytes": 89798496,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7.664000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2010.3240000000824,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.172,
"layouts": 9,
"layoutDurationMs": 2.257,
"taskDurationMs": 321.484,
"heapDeltaBytes": 22398380,
"heapUsedBytes": 89881396,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7.5,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.5960000000332,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.261000000000001,
"layouts": 10,
"layoutDurationMs": 2.6620000000000004,
"taskDurationMs": 761.6089999999999,
"heapDeltaBytes": -6866144,
"heapUsedBytes": 70100036,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 100.06,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.2500000000346,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.043,
"layouts": 10,
"layoutDurationMs": 2.2770000000000006,
"taskDurationMs": 760.255,
"heapDeltaBytes": -11369588,
"heapUsedBytes": 66041660,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 101.893,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.9580000000515,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.564000000000004,
"layouts": 5,
"layoutDurationMs": 16.089,
"taskDurationMs": 1010.1859999999998,
"heapDeltaBytes": 7157300,
"heapUsedBytes": 103366000,
"domNodes": 15953,
"jsHeapTotalBytes": 17174528,
"scriptDurationMs": 27.048000000000002,
"eventListeners": 3244,
"totalBlockingTimeMs": 163,
"frameDurationMs": 19.863013698630137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8753.579000000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 16.75,
"layouts": 8,
"layoutDurationMs": 2.1470000000000002,
"taskDurationMs": 5626.047,
"heapDeltaBytes": -12316372,
"heapUsedBytes": 84174072,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 2578.915,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.729885057471265,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8287.337999999978,
"styleRecalcs": 249,
"styleRecalcDurationMs": 16.39,
"layouts": 7,
"layoutDurationMs": 1.65,
"taskDurationMs": 4818.311000000001,
"heapDeltaBytes": 8998588,
"heapUsedBytes": 88248660,
"domNodes": -258,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 2558.288,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699596774193548,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 22791.177000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21818.987,
"heapDeltaBytes": 8081212,
"heapUsedBytes": 284250680,
"domNodes": -3330,
"jsHeapTotalBytes": 11788288,
"scriptDurationMs": 322.211,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.308793103448274,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 22156.698000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21331.375,
"heapDeltaBytes": -14941448,
"heapUsedBytes": 276361064,
"domNodes": -3330,
"jsHeapTotalBytes": 7327744,
"scriptDurationMs": 288.087,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.73270868824531,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 27396.97699999999,
"styleRecalcs": 179,
"styleRecalcDurationMs": 14.55300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 26922.358000000004,
"heapDeltaBytes": -14150424,
"heapUsedBytes": 286380952,
"domNodes": -3330,
"jsHeapTotalBytes": 8572928,
"scriptDurationMs": 868.873,
"eventListeners": -651,
"totalBlockingTimeMs": 17,
"frameDurationMs": 50.6449168207024,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 19158.46799999997,
"styleRecalcs": 176,
"styleRecalcDurationMs": 12.622000000000021,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18796.647,
"heapDeltaBytes": -14431532,
"heapUsedBytes": 281002708,
"domNodes": -3330,
"jsHeapTotalBytes": 15716352,
"scriptDurationMs": 840.899,
"eventListeners": -651,
"totalBlockingTimeMs": 9,
"frameDurationMs": 34.53315315315316,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5700.824000000011,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.67299999999999,
"layouts": 20,
"layoutDurationMs": 21.08199999999999,
"taskDurationMs": 5546.822,
"heapDeltaBytes": -3473556,
"heapUsedBytes": 277683560,
"domNodes": -3330,
"jsHeapTotalBytes": 22274048,
"scriptDurationMs": 87.409,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.02134831460674,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5563.247000000047,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.297,
"layouts": 20,
"layoutDurationMs": 20.594,
"taskDurationMs": 5402.965,
"heapDeltaBytes": -8877420,
"heapUsedBytes": 290213756,
"domNodes": -3334,
"jsHeapTotalBytes": 24895488,
"scriptDurationMs": 87.88499999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.366292134831465,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7253.996000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6952.6179999999995,
"heapDeltaBytes": -23088556,
"heapUsedBytes": 242387816,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 98.56400000000009,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.492229729729733,
"p95FrameDurationMs": 49.89999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10989.002000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10526.584,
"heapDeltaBytes": -15915792,
"heapUsedBytes": 256139024,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 145.11000000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.855704697986575,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 147.99899999997024,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.747,
"layouts": 7,
"layoutDurationMs": 2.3899999999999997,
"taskDurationMs": 109.46899999999998,
"heapDeltaBytes": -15325076,
"heapUsedBytes": 68093924,
"domNodes": 97,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 11.787999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.428571428571427,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 447.667000000024,
"styleRecalcs": 14,
"styleRecalcDurationMs": 14.14,
"layouts": 13,
"layoutDurationMs": 4.632,
"taskDurationMs": 111.80999999999999,
"heapDeltaBytes": 6545360,
"heapUsedBytes": 79333776,
"domNodes": 95,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.156,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66296296296295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 382.36800000004223,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.87,
"layouts": 76,
"layoutDurationMs": 12.925,
"taskDurationMs": 345.438,
"heapDeltaBytes": -9348756,
"heapUsedBytes": 86000572,
"domNodes": 4,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 161.68099999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 423.80900000000565,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.895,
"layouts": 76,
"layoutDurationMs": 13.517,
"taskDurationMs": 375.616,
"heapDeltaBytes": -14637044,
"heapUsedBytes": 79773216,
"domNodes": 4,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 180.536,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 559.6550000000207,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.987,
"layouts": 76,
"layoutDurationMs": 13.735000000000001,
"taskDurationMs": 530.932,
"heapDeltaBytes": 11405032,
"heapUsedBytes": 166463272,
"domNodes": 4,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 216.974,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.152941176470584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 593.729000000053,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.9269999999999998,
"layouts": 76,
"layoutDurationMs": 14.202,
"taskDurationMs": 561.5219999999999,
"heapDeltaBytes": 11454772,
"heapUsedBytes": 161588220,
"domNodes": 4,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 216.78399999999996,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.135294117647042,
"p95FrameDurationMs": 33.30000000000018
}
]
}🎭 Playwright: ✅ 2278 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 04e20247a66200a63af441328ae4fe3c1c57bb4f
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #21073 +/- ##
============================================
Coverage 87.16% 87.16%
============================================
Files 2612 2612
Lines 146878 146880 +2
Branches 40269 38188 -2081
============================================
+ Hits 128021 128024 +3
+ Misses 18469 18468 -1
Partials 388 388
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #21056 to
core/1.57Automatically created by backport workflow.