Repository navigation
[backport cloud/1.56] FE-2434 feat(workspace): a deployment switcher under the workspace selector - #21051
Conversation
…lector (#19965) A member of a workspace on Comfy Cloud can choose which of the workspace's developer-platform deployments this browser runs on, from a switcher under the workspace selector, and a workspace owner can set the workspace default. A link of the form `<cloud>/?workspace=<workspace id>&deployment=<deployment id>` opens the Cloud editor already running on that deployment, for the Developer Platform's **Open in ComfyUI** button and shared links. Ref [FE-2434](https://linear.app/comfyorg/issue/FE-2434), [BE-20294](https://linear.app/comfyorg/issue/BE-20294) (parent [BE-17141](https://linear.app/comfyorg/issue/BE-17141)), [BE-19175](https://linear.app/comfyorg/issue/BE-19175). Folds in #20832. Folds in #21009. Backend: cloud#9390 (pick), cloud#9645 (listing), cloud#10901 (workspace default). **Why**: studios on the Developer Platform (Contender's agencies first) want the Cloud editor with their own custom nodes and models. Today a Cloud workspace only runs on Comfy's own node set; the backend can already run a picked browser's jobs on a workspace deployment (cloud#9390, #9578, run on staging), and this is the control that makes the pick. - **What**: - `DeploymentSwitcher.vue` (with `DeploymentSwitcherList`, `DeploymentSwitcherRow`, `DeploymentSwitcherOwnerFooter` and `useDeploymentLabels`) under the workspace selector in the user popover. It shows "Running on: Comfy Cloud", or the picked deployment's name, and lists the workspace's deployments, each row titled by the deployment's name, with its Build name and the Release it runs now, its id and its status in the caption. A deployment the server returns without a name is titled by its Build name and Release version, and by its short id only when those are absent too. Picking one, or going back to Comfy Cloud, reloads the editor, because the pick changes what the editor is served at boot (the node catalog and the packs' JavaScript). - A pick names a deployment, not a Release: a deployment keeps its URL while its owner updates it to new Releases (stable deployments), so a pick follows those updates. - Workspace default: when this browser has no pick of its own it follows the default ("Workspace default"); a browser that picked can return to it ("Use the workspace default"); an owner sets or clears the default from the footer. The page reloads only when the change alters what this browser runs on. - `workspaceApi`: GET `/api/workspaces/{id}/deployments`, PUT/DELETE `/api/workspaces/{id}/deployment` (DELETE with `?follow=workspace`), PUT/DELETE `/api/workspaces/{id}/default-deployment`; the shared automock gains the five methods. - `deploymentPickStore` and `deploymentPickState` hold the listing and the pick state; the pick itself is an HttpOnly cookie the editor never reads. - The switcher renders nothing until the listing answers, and nothing when the account is outside the rollout (`cloud_on_customer_build_enabled`), so nobody sees a control they cannot use. A refused pick shows the server's message as a toast and reloads nothing. - Deployment link (`?workspace=<id>&deployment=<id>`), handled by the new `useDeploymentUrlLoader`, run first among the URL action loaders because with `?deployment` it handles `?workspace` too: - In the named workspace: the two params are removed from the address, then the deployment is picked with the switcher's own request (`deploymentPickStore.pickFromLink`), which reloads the editor onto the deployment's nodes. A link to the deployment this browser already runs on just removes the params. - In another workspace: the editor switches to the named workspace first, with the workspace switcher's own switch, and keeps the link for the page that loads after the switch, which then picks. A switch happens at most once per link, so a switch that does not land never reloads again; if the browser cannot save that marker, the link stays in the current workspace and shows a refusal. - Refused: someone outside the workspace stays where they are, with a toast saying which workspace they are still in. A refused pick (account outside the rollout, a deployment that is gone or not the workspace's) shows the server's message as a toast; the params are removed and nothing changes. - Signed out: sign-in already returns to the full address, query included (`previousFullPath`); `deployment` is also stashed through the sign-in redirect the same way `workspace` is (`preservedQueryDefinitions`). - Not acted on: a link missing either value, a bare or repeated value, an API-key session, and non-Cloud builds. - Bounded: the first deployment listing and the pick each have the shared 45-second startup limit (the 30-second request deadline plus time for authorization). Past it the editor continues startup, asks the user to reopen the link, and cancels the pending request; a late listing, authorization or response cannot pick or reload. Picks are serialized, so a later listing cannot start a competing pick. Three new strings under `deploymentSwitcher`. - **Dependencies**: none new. `WorkspaceDeployment`, `WorkspaceDeploymentList` and `PickWorkspaceDeploymentRequest` come from `@comfyorg/ingest-types`. - The reload on pick: the editor's node catalog and pack JavaScript are fixed at boot, so a pick reloads instead of swapping in place. - Hidden until the listing answers and outside the rollout. - The deployment link's order against the `?workspace=` loader, and its 45-second startup limit. Screenshots: in the review ask's Slack thread, and on [FE-2434](https://linear.app/comfyorg/issue/FE-2434) (the switcher, seven states, taken on staging from this branch) and [BE-20294](https://linear.app/comfyorg/issue/BE-20294) (the deployment link, four states, from the local end-to-end test). Design follow-up: once this is on staging, Willie and Pablo use it there and iterate on it; their changes come as follow-up PRs ([BE-20668](https://linear.app/comfyorg/issue/BE-20668)). Try it: [Storybook, Components/DeploymentSwitcher](https://cdd7cb47.comfy-storybook.pages.dev/?path=/story/components-deploymentswitcher--default) (built from this PR's head; the stories cover a pick, the workspace default, a gone default, no deployments, hidden build names and named deployments). Against staging: `pnpm dev:cloud:staging` from this branch, then the account menu, under the workspace selector. For the link, sign in and open `http://localhost:5173/?workspace=<your team workspace id>&deployment=<a deployment id in that workspace>`: with `cloud_on_customer_build_enabled` on for the workspace the editor reloads onto the deployment; with it off you get the refusal toast and nothing changes. Tested: unit tests for the switcher, its labels, its store, the boot listing, the missing-model scan and the deployment link (`useDeploymentUrlLoader`, `pickFromLink`, the URL action order, the sign-in stash, the startup limit and cancellation); the link end to end locally; on staging from this branch (real deployment listing, a pick and its reload, setting and clearing the workspace default, a node the Release lacks). Not run: the browser (Playwright) suite locally; CI runs it. (cherry picked from commit f3bf32f)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-15T00:53:16.302Z",
"gitSha": "8ec0893e7a88b83e5f710b52d65a3e06ea1c7a11",
"branch": "backport-19965-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.71699999999,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.681000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.65599999999995,
"heapDeltaBytes": -3452120,
"heapUsedBytes": 56894476,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.491,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2007.261000000085,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.947000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.492,
"heapDeltaBytes": 1276292,
"heapUsedBytes": 69381632,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.057999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1830.4899999999975,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.092,
"layouts": 12,
"layoutDurationMs": 5.013,
"taskDurationMs": 840.27,
"heapDeltaBytes": -2185668,
"heapUsedBytes": 65541656,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 170.285,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665454545454544,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1779.8740000000635,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.31,
"layouts": 12,
"layoutDurationMs": 4.589,
"taskDurationMs": 804.7939999999999,
"heapDeltaBytes": -2153404,
"heapUsedBytes": 64536728,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 164.8,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.6889999999494,
"styleRecalcs": 29,
"styleRecalcDurationMs": 8.741999999999997,
"layouts": 6,
"layoutDurationMs": 1.217,
"taskDurationMs": 343.738,
"heapDeltaBytes": 3836968,
"heapUsedBytes": 71312512,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.753999999999994,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.7059999999265,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.752,
"layouts": 6,
"layoutDurationMs": 1.13,
"taskDurationMs": 350.30699999999996,
"heapDeltaBytes": 3967656,
"heapUsedBytes": 73326416,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.930999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66699029126214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 722.0730000000231,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.813,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.987,
"heapDeltaBytes": -6687808,
"heapUsedBytes": 61081884,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 171.924,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069753,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 689.1419999999471,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.800999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.3090000000001,
"heapDeltaBytes": 15690148,
"heapUsedBytes": 76158168,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.594,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926822,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1170.3830000000153,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 832.1030000000001,
"heapDeltaBytes": 38737360,
"heapUsedBytes": 106765228,
"domNodes": 0,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 75.987,
"eventListeners": 0,
"totalBlockingTimeMs": 526,
"frameDurationMs": 34.31176470588234,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1218.8190000000532,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 867.2109999999999,
"heapDeltaBytes": 11375640,
"heapUsedBytes": 92582132,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 73.872,
"eventListeners": 0,
"totalBlockingTimeMs": 574,
"frameDurationMs": 34.762857142857136,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 863.4779999999864,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.77000000000015,
"heapDeltaBytes": 17415292,
"heapUsedBytes": 102273076,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 169.18800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 229,
"frameDurationMs": 25.491176470588258,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.7780000000193,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.05699999999973,
"heapDeltaBytes": 17136920,
"heapUsedBytes": 93039948,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 163.52100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9739.85399999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8992.805,
"heapDeltaBytes": 11693768,
"heapUsedBytes": 89075132,
"domNodes": -171,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 7655.541,
"eventListeners": -78,
"totalBlockingTimeMs": 1495,
"frameDurationMs": 37.00722433460076,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9480.58400000002,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5389999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8709.083999999999,
"heapDeltaBytes": 24512344,
"heapUsedBytes": 92810344,
"domNodes": -142,
"jsHeapTotalBytes": -12193792,
"scriptDurationMs": 7150.2,
"eventListeners": -74,
"totalBlockingTimeMs": 731,
"frameDurationMs": 32.813148788927336,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10231.528000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9373.813,
"heapDeltaBytes": 20009068,
"heapUsedBytes": 97894460,
"domNodes": -142,
"jsHeapTotalBytes": -659456,
"scriptDurationMs": 7821.81,
"eventListeners": -78,
"totalBlockingTimeMs": 1246,
"frameDurationMs": 33.27752442996742,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9912.285999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9106.759,
"heapDeltaBytes": 6137240,
"heapUsedBytes": 84180572,
"domNodes": -142,
"jsHeapTotalBytes": -1970176,
"scriptDurationMs": 7526.853,
"eventListeners": -78,
"totalBlockingTimeMs": 1023,
"frameDurationMs": 32.67161716171617,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-graph-idle",
"durationMs": 2015.5960000000164,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.8049999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.41100000000006,
"heapDeltaBytes": -9866404,
"heapUsedBytes": 78680280,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 39.049,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2012.974999999983,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.9299999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.357,
"heapDeltaBytes": -7822588,
"heapUsedBytes": 76125852,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 31.976999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2513.238000000001,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.436,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1615.0090000000002,
"heapDeltaBytes": -18215008,
"heapUsedBytes": 70294804,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 847.743,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.777333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2381.087999999977,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.118,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1588.9349999999997,
"heapDeltaBytes": 10119768,
"heapUsedBytes": 90096308,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 842.052,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.783098591549294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3568.6960000000454,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.114,
"layouts": 60,
"layoutDurationMs": 13.988,
"taskDurationMs": 1639.392,
"heapDeltaBytes": -20579572,
"heapUsedBytes": 69184088,
"domNodes": 24,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 769.522,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66588785046729,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3577.272999999991,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.655,
"layouts": 60,
"layoutDurationMs": 14.149999999999999,
"taskDurationMs": 1638.442,
"heapDeltaBytes": -20067596,
"heapUsedBytes": 68825048,
"domNodes": 24,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 778.568,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666511627906974,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3143.2719999999676,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.2799999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1870.929,
"heapDeltaBytes": 8488836,
"heapUsedBytes": 77470928,
"domNodes": 0,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 968.794,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755080213903742,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3112.3999999999796,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.129,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1889.6209999999999,
"heapDeltaBytes": 3333964,
"heapUsedBytes": 72526292,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 982.558,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75537634408602,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.4599999999855,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.724999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.35200000000003,
"heapDeltaBytes": -11321324,
"heapUsedBytes": 68760736,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 32.25300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.6479999999938,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.923000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.9680000000001,
"heapDeltaBytes": -9628372,
"heapUsedBytes": 79706152,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 38.42200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 627.0799999999781,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.5249999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.1960000000001,
"heapDeltaBytes": -11538568,
"heapUsedBytes": 57488944,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 147.13,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 643.0490000000191,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.8420000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.07700000000006,
"heapDeltaBytes": -11869252,
"heapUsedBytes": 57935044,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 148.068,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.4789999999566,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.706000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.8160000000001,
"heapDeltaBytes": 1156432,
"heapUsedBytes": 71035416,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.153999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.2710000000598,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.875,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.017,
"heapDeltaBytes": 1155072,
"heapUsedBytes": 70756848,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.718999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.9789999999616,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.938,
"layouts": 16,
"layoutDurationMs": 5.55,
"taskDurationMs": 759.6389999999999,
"heapDeltaBytes": -5970456,
"heapUsedBytes": 64035792,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.32800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.0210000000307,
"styleRecalcs": 78,
"styleRecalcDurationMs": 18.259,
"layouts": 16,
"layoutDurationMs": 5.568999999999999,
"taskDurationMs": 778.9019999999999,
"heapDeltaBytes": -5743872,
"heapUsedBytes": 64053200,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 113.372,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.449000000047,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.949999999999996,
"layouts": 5,
"layoutDurationMs": 14.609,
"taskDurationMs": 910.9430000000001,
"heapDeltaBytes": 1072980,
"heapUsedBytes": 95325472,
"domNodes": 14227,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 28.975,
"eventListeners": 2463,
"totalBlockingTimeMs": 136,
"frameDurationMs": 19.675000000000004,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8443.275999999969,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.54599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5597.787,
"heapDeltaBytes": -18940272,
"heapUsedBytes": 69093740,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 2795.027,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666074950690337,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8260.04899999998,
"styleRecalcs": 251,
"styleRecalcDurationMs": 36.03,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4984.664000000001,
"heapDeltaBytes": -18481012,
"heapUsedBytes": 69361932,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2755.979,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18273.325999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17414.552999999996,
"heapDeltaBytes": -47518248,
"heapUsedBytes": 178975988,
"domNodes": -3045,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 265.45099999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.906806282722517,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 18443.754999999896,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17363.278,
"heapDeltaBytes": -47605360,
"heapUsedBytes": 178985104,
"domNodes": -3045,
"jsHeapTotalBytes": 806912,
"scriptDurationMs": 326.92900000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 3,
"frameDurationMs": 31.808965517241376,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 22497.903999999948,
"styleRecalcs": 174,
"styleRecalcDurationMs": 20.459000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22061.816,
"heapDeltaBytes": -20566868,
"heapUsedBytes": 192211152,
"domNodes": -3046,
"jsHeapTotalBytes": 6504448,
"scriptDurationMs": 875.0530000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 15,
"frameDurationMs": 41.10127970749543,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 22191.314000000035,
"styleRecalcs": 172,
"styleRecalcDurationMs": 20.382000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21744.147999999997,
"heapDeltaBytes": -43229036,
"heapUsedBytes": 183582220,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 850.1540000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 19,
"frameDurationMs": 40.851565377532225,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6595.988000000034,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.84900000000003,
"layouts": 20,
"layoutDurationMs": 26.20099999999999,
"taskDurationMs": 6475.851,
"heapDeltaBytes": 14970672,
"heapUsedBytes": 217178744,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 112.941,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.286440677966105,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6584.811000000059,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.74300000000001,
"layouts": 20,
"layoutDurationMs": 23.895,
"taskDurationMs": 6411.879999999999,
"heapDeltaBytes": -12993884,
"heapUsedBytes": 215130840,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 114.899,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.584324324324335,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9255.521000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8788.133999999998,
"heapDeltaBytes": -34108768,
"heapUsedBytes": 179683932,
"domNodes": -3046,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 142.853,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.879598662207357,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9385.449999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8872.279999999999,
"heapDeltaBytes": -33728060,
"heapUsedBytes": 179230640,
"domNodes": -3045,
"jsHeapTotalBytes": 806912,
"scriptDurationMs": 145.401,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.699324324324323,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 471.7950000000428,
"styleRecalcs": 14,
"styleRecalcDurationMs": 15.988000000000003,
"layouts": 3,
"layoutDurationMs": 0.8730000000000001,
"taskDurationMs": 119.44099999999999,
"heapDeltaBytes": 5744976,
"heapUsedBytes": 71262184,
"domNodes": 104,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.407999999999996,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 129.74499999995714,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.422,
"layouts": 3,
"layoutDurationMs": 1.8010000000000002,
"taskDurationMs": 97.09599999999999,
"heapDeltaBytes": 3715328,
"heapUsedBytes": 69560364,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.823999999999996,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 913.5250000000497,
"styleRecalcs": 78,
"styleRecalcDurationMs": 105.24,
"layouts": 76,
"layoutDurationMs": 26.112,
"taskDurationMs": 876.261,
"heapDeltaBytes": 17997368,
"heapUsedBytes": 84680152,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 358.106,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664814814814825,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1041.394000000082,
"styleRecalcs": 78,
"styleRecalcDurationMs": 109.43700000000001,
"layouts": 76,
"layoutDurationMs": 27.997999999999998,
"taskDurationMs": 999.341,
"heapDeltaBytes": 18972248,
"heapUsedBytes": 86194108,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 411.724,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.943333333333324,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1397.9009999999334,
"styleRecalcs": 78,
"styleRecalcDurationMs": 263.983,
"layouts": 76,
"layoutDurationMs": 28.195999999999998,
"taskDurationMs": 1381.135,
"heapDeltaBytes": 8389676,
"heapUsedBytes": 115325964,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 453.109,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.931645569620258,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1395.3149999999823,
"styleRecalcs": 78,
"styleRecalcDurationMs": 256.99899999999997,
"layouts": 76,
"layoutDurationMs": 28.105999999999998,
"taskDurationMs": 1368.059,
"heapDeltaBytes": 8287708,
"heapUsedBytes": 119417784,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 454.9200000000001,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.72151898734177,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2203 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 47e18c55154e8590246bb732aeac2d031e57265d
Full docs: ADR-DEVEX-LINT-0015 |
wei-hai
left a comment
There was a problem hiding this comment.
Conflict resolution on cloud/1.56 looks correct (missingModelPipeline / GraphView.test keep branch-local imports; toasts use this branch’s useToastStore). Also folds in deployment-menu cancellation (AbortSignal, workspace-id guards, 45s backstop) — intentional hardening beyond #19965, well covered in tests. Staging smoke on a live 1.56 backend remains the main release check.
Backport of ComfyUI_frontend#19965 - a deployment switcher under the workspace selector to
cloud/1.56.The automatic backport stopped on conflicts. This branch keeps its existing imports in
missingModelPipeline.tsandGraphView.test.ts, adds the switcher's imports, and uses this branch'suseToastStorefor the three deployment notifications.This also changes how pending menu requests finish: changing workspace cancels the old request, and a request that stalls during sign-in or transport is canceled after 45 seconds. Late results cannot unlock a newer selection, reload the page, or replace the new workspace's default. Previously an old account's failure could unlock a new selection, and a stalled request could leave the menu disabled indefinitely. The same cancellation applies to deployment links.
Validation: 229 deployment store, API, switcher, link and reducer tests pass. The broader workspace, missing-model and view run has 3,250 passes and one failure:
UnifiedPricingTable.test.ts"prompts free-tier users to subscribe". That Firebase initialization failure also reproduces with the unchanged production files at466cc580b5. Type checking, formatting, lint, server-fact checks, knip and the architecture audit pass. The new failure and timeout regressions fail before the fix; the deleted-pick warning regression fails when its workspace guard is removed.Not run: browser switching against a live backend, including deployment cookies and the node catalog after reload.
Ref FE-2434 - Editor: pick one of the workspace's deployments and see what it carries.