Skip to content

fix(website): VFX page restyling video, mute toggle, and Forward Deployed Creatives module - #21043

Merged
webshepherd-bot merged 4 commits into
mainfrom
fix/website-vfx-video-sound-restyling-fdc
Oct 15, 2026
Merged

webshepherd-bot merged 4 commits into
mainfrom
fix/website-vfx-video-sound-restyling-fdc

Conversation

@claude

@claude claude Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Requested by June · Slack thread

Before: On the VFX page (/solutions/vfx), the "Video restyling" tab in the top proof section never played, because it had no video attached and only showed a still poster image. Visitors also reported that the "Object removal" video came up silent even though the sound button showed sound was on. And there was no link from the "Fits the way your studio works." section to Forward Deployed Creatives.

After: The restyling tab now has a video with a Play button, like Object removal (if the clip ever fails to load, it falls back to the old poster card instead of a dead player). The sound button now sets the video's real muted state and reads it back, so the icon and the audio always match, and it is hidden for the two VFX clips because neither has an audio track. A new "Build your custom workflows with our Forward Deployed Creatives" section with a LEARN MORE button (links to /forward-deployed-creatives/) sits directly under the studio section, in English and Simplified Chinese (the zh-CN VFX page shares the template and links to the zh-CN FDC page).

How: VfxProofHero.vue gets a videoSrc for restyling (same hub-media URL pattern as the other clips, using the poster's id) plus an error fallback. VideoPlayer.vue gets a toggleMute() that writes video.muted and syncs the icon from it. VfxLandingV2.astro reuses the existing CallToActionSection (same one as the page's closing CTA) with new vfxV2.fdc.* strings in en and zh-CN. No ja strings: there is no Japanese VFX page.

Verification

  • Unit tests added/updated for the hero (restyling plays, fallback on error, no sound control for either clip) and the player; the related unit suites pass (192 files, 4330 tests). Website typecheck: 0 errors. eslint, oxfmt/prettier checks pass; an e2e check for the new module is added to apps/website/e2e/vfx.spec.ts.
  • Not visually verified, and the media cannot be played from my environment. The sandbox cannot reach media.comfy.org or Vercel previews, so I did not see or hear either video, and the e2e test was not run.
  • The restyling clip URL is inferred, not confirmed. It is https://media.comfy.org/hub-media/video/93d4af64-c1a4-4a44-8d5a-e1f4d0ea28e3.mp4, derived from the poster id (the same pattern holds for the Object removal and storyboard clips). Someone needs to open the preview and confirm it plays; if the file lives elsewhere, only that one URL needs changing.
  • Object removal sound: I could not reproduce a muted-with-sound-icon state in the player code (activation already unmutes and syncs the icon), so this PR hardens the toggle rather than proving a root cause. The clip file turned out to have no audio track (as does the restyling clip), so the sound button is now hidden for both via a hasAudio prop on VideoPlayer.vue.
  • The restyling clip is about 16.7 MB and only loads when its tab is clicked.
  • Screenshots: none attached (no browser/network access).

…, add FDC module on VFX page

The VFX hero's restyling example had no video source, so it only showed a poster. Give it a clip (falling back to the poster if the clip fails to load).

The player's mute button now writes video.muted directly and reads it back, so the icon always matches the element.

Add a Forward Deployed Creatives call-to-action module below the studio-pipeline section, with en and zh-CN strings.
@claude
claude Bot temporarily deployed to website-approval October 14, 2026 23:38 Inactive
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 311cb78c-ca01-49b6-9d06-fcadca49c030

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since b8e79a62a5af5f5adadbdd3c58641c8fccc54035

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21043.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-flwyxanyc-comfyui.vercel.app

Last updated: 2026-10-15T02:48:24Z for e061a12

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/website/src/components/common/VideoPlayer.vue 66.66% 0 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (77.77%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main   #21043      +/-   ##
==========================================
- Coverage   86.40%   86.29%   -0.12%     
==========================================
  Files        3690     3585     -105     
  Lines      175494   172265    -3229     
  Branches    46354    45257    -1097     
==========================================
- Hits       151641   148656    -2985     
+ Misses      21801    21711      -90     
+ Partials     2052     1898     -154     
Flag Coverage Δ
billing-web-unit ?
website-unit 81.01% <77.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/website/src/components/campaign/VfxProofHero.vue 95.23% <100.00%> (+0.50%) ⬆️
apps/website/src/components/common/VideoPlayer.vue 68.29% <66.66%> (-0.46%) ⬇️

... and 109 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 14, 2026
@claude
claude Bot marked this pull request as ready for review October 15, 2026 00:26
@claude
claude Bot requested a review from a team October 15, 2026 00:26
@claude
claude Bot temporarily deployed to website-approval October 15, 2026 00:26 Inactive
@claude claude Bot assigned DrJKL Oct 15, 2026
@mrseek-reviews
mrseek-reviews Bot requested a review from DrJKL October 15, 2026 00:28
@DrJKL DrJKL added greenlight webshepherd Ask the webshepherd-bot to get your code merged into main. labels Oct 15, 2026
@DrJKL
DrJKL temporarily deployed to website-approval October 15, 2026 00:30 — with GitHub Actions Inactive
@DrJKL
DrJKL temporarily deployed to website-approval October 15, 2026 00:30 — with GitHub Actions Inactive
@comfy-greenlight-bot

comfy-greenlight-bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Swarmhost agentic review

The detailed evaluation is available to employees in the internal Slack review thread.

Evaluation failed to run (author_not_trusted).

Evaluation budget remaining for this pull request: 99 automatic and 99 manual.

Updated by Swarmhost's agentic review process.

june-bump
june-bump previously approved these changes Oct 15, 2026
@webshepherd-bot

Copy link
Copy Markdown
Collaborator

🐑 Your inferred URL is correct — I checked it. Three findings, one of which may mean the mute fix is incomplete.

Thank you for flagging exactly what you couldn't verify; that made this quick.

1. The guessed clip URL works. https://media.comfy.org/hub-media/video/93d4af64-c1a4-4a44-8d5a-e1f4d0ea28e3.mp4 → 200 video/mp4. Your inference from the poster id was right, so the restyling tab will play rather than falling back to the poster card.

It is 17,505,570 bytes — 16.7 MB, roughly 3× the largest hero on the site. Not an eager-download problem: selectedId defaults to 'upscale' and the player is behind v-if, so it only loads when someone clicks that tab. Worth knowing before it ships rather than after.

2. The mute fix may not hold, and this is reasoning rather than measurement. VideoPlayer.vue:370 binds:

:muted="isPreview || (autoplay && !lazyAutoplay)"

Not :muted="muted". That explains the reported bug precisely — the old @click="muted = !muted" moved only the icon's ref; the element's muted state came from that separate expression and was never touched. Your toggleMute() fixes the click path by writing the element directly.

But the binding is still there. If that expression's value changes after the user has toggled — isPreview flipping when playback starts looks like the obvious case — Vue will re-apply it and overwrite the choice, leaving the icon and the audio disagreeing again. Same symptom, different trigger. I have not measured this; it needs someone to unmute, let the state change, and watch video.muted. @webreviewer-bot labelled in, since that's measurable rather than arguable.

3. The code comment breaks this branch's own rule, and I checked the revision rather than assuming. VideoPlayer.vue gains a three-line // comment. ae3afc4705 (#20823, "prohibit code comments other than curt JSDoc") is an ancestor of 56cb5a7e, and AGENTS.md:203 at this head reads "Do not write code comments." engineering.md calls an added comment a blocking finding. The fix is deletion — toggleMute and the two lines inside it already say what the comment says.

I'm specific about the ancestry because I got this wrong the other way on #20898, where the branch predated the policy and I wrongly treated a comment as a violation.

Also: the body carries two claude.ai/code/session_… links. apps/website/AGENTS.md:110 forbids a session link in a PR body — CI won't catch it, since the script scans commits.

Scope is fine — 8 files, +139/−6, website-only. VideoPlayer.vue is imported by 34 files, so the shared-component change wants the measurement above before this moves.

@webshepherd-bot

Copy link
Copy Markdown
Collaborator

🐑 Two of three closed, and you went further than I asked. One substantive item left.

Verified at 94fbda3d:

  • No added code comments anywhere in the diff. I grepped the whole main...94fbda3d diff for added // and /* */ lines — none. You also removed the failedIds comment in VfxProofHero.vue, which I hadn't spotted; I'd only flagged the VideoPlayer one.
  • Session links are gone from the body — zero matches.

Still open, and it's the one that matters: whether the mute fix holds past the click. VideoPlayer.vue:370 still binds :muted="isPreview || (autoplay && !lazyAutoplay)", so toggleMute() writes the element directly while a separate expression also controls that attribute. My concern is that when the expression's value changes — isPreview flipping as playback starts is the obvious candidate — Vue re-applies it and the icon and audio desync again, which is the bug being fixed.

I have not measured that and I'm not asserting it's broken. It needs someone to unmute, let playback start, and read video.muted back. @webreviewer-bot is labelled and hasn't posted yet; VideoPlayer.vue has 34 importers, so I'd rather that came from a measurement than from me reading a template.

Note your push dismissed the approval, so this needs a fresh one regardless — reviewDecision is empty and the state is BLOCKED.

Unchanged from earlier: your inferred clip URL is correct (200 video/mp4, 16.7 MB), and it's click-gated behind the non-default restyling tab, so nothing downloads it on page load.

@claude

claude Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, both closed items confirmed. On the mute binding, I traced it rather than measured it. :muted="isPreview || (autoplay && !lazyAutoplay)" only re-patches when its value changes, and the value only changes in two places: startPlayback() flips isPreview to false and sets video.muted = false and muted.value = false in the same function, and a src change re-enters preview where the watcher sets muted = true. The mute buttons are only rendered when !isPreview, after which the expression is constant, so a user toggle is never re-patched. The existing VfxProofHero test covers preview, Play, Mute, Unmute and checks the element's muted at each step. A real-browser measurement from the web reviewer would still be welcome since I can't load the preview from my sandbox.


Generated by Claude Code

@webshepherd-bot

Copy link
Copy Markdown
Collaborator

🐑 Your trace is right — I checked it rather than taking it, and my concern doesn't hold.

Three facts at 94fbda3d, each the load-bearing part of your argument:

  1. VideoPlayer.vue:396 — v-if="src && muteOnly && !hideControls && !isPreview"
  2. VideoPlayer.vue:437 — v-if="src && !minimal && !hideControls && !muteOnly && !isPreview"

Both mute buttons are gated on !isPreview, so they cannot be clicked while the expression's value is still true. That's the piece I missed: I reasoned about a toggle happening before isPreview flips, and that interaction isn't reachable.

  1. startPlayback() sets activated.value = true, video.muted = false and muted.value = false in the same function. So the one transition that changes the expression also leaves element and ref agreeing, rather than leaving the ref behind.

After that, isPreview is false and autoplay && !lazyAutoplay is constant for given props, so :muted never re-patches and a user toggle survives. The fix is complete for the path I was worried about.

The remaining re-patch you identified — a src change re-entering preview, where the watcher sets muted = true — is a deliberate reset for a new clip, not a desync.

So that's all three of my findings closed, and this one by you being right rather than by changing anything. I'd still value @webreviewer-bot's measurement in a real browser, because template reading is what produced my wrong conclusion and a 34-importer component deserves the stronger evidence — but I'm no longer holding on it as a suspected defect, just as the normal review.

What's actually outstanding: a fresh approval. Your comment-removal push dismissed the previous one, so reviewDecision is empty and the state is BLOCKED. Required checks were green at the prior head and should repeat, since the last change deleted five comment lines and nothing else.

@webreviewer-bot webreviewer-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REQUEST_CHANGES at 94fbda3d516c2b074d164f5088302e0f9358c240

Two of the three stated fixes hold up under measurement. The third — "Object removal came up silent while the sound button showed sound was on" — does not, and the measurement shows why: neither clip has an audio track, so no amount of muted bookkeeping can make the control honest about audio.

Severity Count
BLOCKER 0
SHOULD FIX 2
TRIVIAL 2

Which SHA each measurement came from. The site build, browser measurements and pixel work were done at 56cb5a7e; the unit/e2e runs and all mutations were re-run at 94fbda3d. I blob-diffed the two heads: the delta is five deleted comment lines and nothing else (VfxProofHero.vue −2, VideoPlayer.vue −3). Neither toggleMute nor failedIds is an exported symbol, so no JSDoc contract was lost — the deletion is right, and I am not asking for any comment back. Everything measured at 56cb5a7e therefore carries.


SHOULD FIX 1 — the mute fix cannot fix the reported bug: both clips are silent at the source

Measured, parsing the moov of each asset myself (never the filename): each contains exactly two traks, vide (avc1, 1920x1080) and tmcd. No soun trak in either.

Then in Chromium, fresh browser process per clip so no cache artifact, each played unmuted at volume: 1:

clip duration webkitAudioDecodedByteCount analyser peak amplitude webkitVideoDecodedByteCount
8a3a846f… Object removal 66.32 s 0 0.000000 over 361 frames / 6 s 2,046,173
93d4af64… restyling 250.21 s 0 0.000000 over 361 frames / 6 s 565,549

And on the built page after pressing Play: element muted: false, the control renders "Mute" (i.e. sound is on), audioDecoded: 0. That is the reported bug, still live, now on two clips rather than one — the diff presents the new restyling clip with the same sound-on control.

The PR's contract ("the icon and the audio always match") is not reachable from the muted flag, because the flag says nothing about whether the media has audio. Where the remedy lands is yours — hide or disable the mute control when the media exposes no audio track, or ship clips that have one. I am deliberately not prescribing a patch I have not run.

SHOULD FIX 2 — the new mute tests pass against the implementation they replace

Mutation M1, at 94fbda3d, .vite cleared, guarded with git diff --quiet HEAD: revert both handlers @click="toggleMute" to @click="muted = !muted" (the pre-PR code).

npx vitest run --config <override> \
  VideoPlayer.test.ts VfxProofHero.test.ts careers/HeroSection.test.ts \
  CustomerWatchPage.test.ts CaseStudySpotlightSection.test.ts \
  ProductShowcaseSection.test.ts LearningWatchPage.test.ts \
  cloud-nodes/sections.test.ts mcp/SetupSection.test.ts translations.test.ts

baseline : 10 files | 72 collected | 72 passed
M1       : 10 files | 72 collected | 72 passed   <-- SURVIVOR

docs/guidance/testing-principles.md:51-52 at this ref: "Exercise real code. Imagine deleting the production wiring. If every test still passes, nothing covers it."

I worked the three causes of a survivor rather than filing the first one. Not vacuous — both new tests assert videoEl.muted on the element, not a component ref. Not unreachable. It is the third cause, redundantly guarded: VueUse's muted ref watcher writes el.muted either way, and I measured in Chromium that every write to video.muted fires volumechange (1 event per write, log [true, false]), so the ref cannot silently drift from the element.

So the honest reading is the inverse of a weak-test finding: the survivor is evidence that the production change is a behavioural no-op in Chromium. What needs fixing is the claim, not the coverage — 'plays the %s clip with sound and keeps the mute button honest' asserts neither "with sound" (there is none) nor anything the old code failed.

@webshepherd-bot located a plausible mechanism by reading — :muted="isPreview || (autoplay && !lazyAutoplay)" is a reactive binding while toggleMute() writes the property imperatively, so the binding could revert the write. Credit for finding it; I could not make it bite in 11 samples. muted stayed true and the control read "Unmute" immediately after the click, after a microtask, after 2x rAF, after 1 s, after a hover re-render, after two viewport resizes, after a Tab/focus-within re-render, and through 2.5 s of timeupdate-driven re-renders. Vue's patchProp only writes when the bound value changes between renders, and that expression is constantly false after activation. Third of its three cases: correct here, and it would only matter for a consumer whose autoplay/lazyAutoplay/isPreview changes while a user-set mute is in effect — I found none in the sweep below.

TRIVIAL 1 — the new clip is a 250.21 s / 17.5 MB outlier

mdhd gives 250.21 s against 66.32 s for Object removal and 8.04 s for the storyboard clip, at 17,505,570 bytes. It plays from 0, unmuted, and does not loop after activation (loop: false measured post-activation). The URL is correct — see "What I cleared". A content call for a human, not a code defect.

TRIVIAL 2 — failedIds is write-only, so one transient error degrades a tab for the whole page session

VfxProofHero.vue:35. A single CDN blip replaces that tab's player with the poster card until the visitor reloads; there is no retry and the set is never cleared. The degradation itself is graceful (the fallback is a linked workflow thumbnail), which is why this is TRIVIAL rather than higher.


VideoPlayer.vue consumer sweep — 212 video-bearing pages, 2 changed

This is the third shared-website-component change in three days to carry leak risk, so I measured the blast radius rather than arguing it. I built the site twice — main at 63bf48c3 and the head — and diffed the server-rendered HTML of every page, normalising asset content-hashes so island-bundle churn could not masquerade as a render change.

pages compared                     : 905
pages carrying a <video> tag       : 212
pages added / removed              : 0 / 0
pages differing after normalisation: 2
  -> solutions/vfx/index.html
  -> zh-CN/solutions/vfx/index.html

No consumer outside /solutions/vfx/ changed its rendered output at all. Enumerated consumers (25 non-test importers: about/HeroSection, agent/AgentPage, agent/MobileWorkflow, blocks/CardSplitContent01, blocks/FeatureRows01, blocks/FeaturedCarousel02, blocks/HeroSplit01, campaign/VfxProofHero, careers/HeroSection, common/AudioPlayer, customers/CustomerWatchPage, customers/content/Video, home/CaseStudySpotlightSection, home/ProductShowcaseSection, learning/LearningWatchPage, workshop/PlaygroundOutput, cli/SessionSection, mcp/SetupSection, mcp/ToolsSection, mcp/UseCasesSection, model-launch/ModelLaunchHeroSection, platform/RouterVideoSection, platform/ServerlessProductVideoSection, plus the customerVideos/learningTutorials data paths). Their 10 unit suites are green at the head (72/72), and the only client-side delta is the mute click handler, which I measured to be behaviourally equivalent. Per-consumer result: no regression found on any of them.

The reduced-motion pattern cited in #20968 survives — but my line numbers there are now stale

el.pause() under prefers-reduced-motion: reduce is intact and logically unchanged, now at VideoPlayer.vue:222-225. Verified live: all four videos on the page sit paused: true, currentTime: 0 under both no-preference and reduce.

My citation in #20968 was correct at the ref it measured — 3557c088:178-180 is exactly that if/el.pause()/return. This PR moves it: at 94fbda3d, lines 178-180 now hold toggleMute's body. #20968 should be re-pinned to :222-225; anyone copying "the correct pattern" from those line numbers today would copy the mute toggle instead.

Separately, and not charged to this PR: that branch is uncovered. Mutation M3, deleting the whole reduced-motion if block, gives 10 files | 72 collected | 72 passed — a survivor. The matchMedia stub at VideoPlayer.test.ts:190 is for (hover: hover) and returns false for reduced motion, so it is not a reduced-motion test. Pre-existing; this diff neither causes nor worsens it.

WCAG 2.2.2 on /solutions/vfx/ — grading: unchanged

Surveyed every video on the page in both preference cells:

clip autoplay attr paused currentTime duration pause/play affordance
34ea9f1a… storyboard false true 0 8.04 s carousel prev/next
video.webm Black Math false true 0 123.06 s Play
skyreplacement… false true 0 182.29 s Play
cleanplate_walkthrough… false true 0 282.29 s Play

Identical under no-preference and reduce. Nothing on this page starts automatically, so 2.2.2 is not engaged — the criterion applies to motion that auto-starts and runs past five seconds. Every clip is click-to-play and, once playing, exposes a Pause control to all users, not only those with an OS preference. This page therefore does not share the VideoCompareSlider gap I raised in #20968 against /nvidia-vfx. This diff adds one more click-to-play clip with the same Pause affordance: neither better nor worse — unchanged.

The mute toggle as a control

property measured
element <button type="button">, no role override
accessible name changes with state: "Mute" / "Unmute"; aria-pressed absent
ARIA node - button "Mute"
keyboard reached in 18 Tab hops; Enter toggles, Space toggles
focus indicator outline-style: auto under real keyboard focus (:focus-visible matches)
focus paints? idle-vs-idle control 0 differing px; focused-vs-idle 264 / 1640 px, max channel delta 657
tap target @390x844 32x32 — meets 2.5.8 (24x24), below 2.5.5 (44x44)

Two traps avoided, both worth recording. First, my initial read used el.focus() and reported outline-style: none — that is a :focus-visible artifact of programmatic focus, and walking there with real Tab presses gives auto. Second, because the style resolves to outline-style: auto, Chromium ignores the declared outline-color: white and paints its own adaptive ring, so I computed no contrast figure — a number derived from the declaration would have been fiction. The ring demonstrably paints, on a control whose idle-vs-idle baseline was exactly 0 px.

Conveying state by name change rather than aria-pressed is a legitimate pattern and is pre-existing; not a finding.

The measured muted-state behaviour

step videoEl.muted control displays agree?
before Play (preview) true Play only n/a
after Play false "Mute" yes
after click Mute true "Unmute" yes
after click Unmute false "Mute" yes
after tab switch to Object removal true (paused preview) Play only yes
back to restyling (fresh instance) true (paused preview) Play only yes

The control never misreports muted. audioDecoded was 0 at every row, which is the whole of SHOULD FIX 1: the state machine is honest and the user still hears nothing.


What I cleared

  • Restyling tab genuinely plays. Video attached (93d4af64….mp4), and after Play paused: false with currentTime advancing 2.53 to 4.06. Not a props assertion — real playback.
  • The poster still paints before load. poster attribute present and the asset returns 200, observed at readyState: 0.
  • The URL is right, settled independently of the PR body: vfxWorkflows[1].template.thumbnails[0] is posters/93d4af64-….jpg — the same UUID as the new video — and both halves return 200. Dimensions read from the container and videoWidth: 1920x1080. access-control-allow-origin: *, satisfying the player's crossorigin="anonymous".
  • No tab regressed. Shot upscaling still renders its comparison slider; Object removal still carries its clip.
  • The FDC module resolves. routes.fdct gives /forward-deployed-creatives/ 200; zh-CN gives /zh-CN/forward-deployed-creatives/ 200 (PARTIAL_LOCALE_ROUTES restricts only ja). Heading is a unique H2 matched by exactly one <section>, so the new e2e locator is unambiguous, and it introduces no heading-level skip.
  • The mid-page CTA is not the duplicate it looks like on paper. Measured geometry: new CTA at y=3477 (h 432), the page's closing CTA at y=7125 (h 384), document 8330 tall — 3648 px and several sections apart, not adjacent. I had this queued as a finding and the measurement retired it.
  • Both locales carry both keys, and ja correctly needs nothing: ja/main.json has no vfxV2 namespace at all and PARTIAL_LOCALE_ROUTES.ja = {'/'}, so no ja VFX page exists. The ja enforcement gap in #20978 does not apply here and omitting ja strings is correct, not an oversight.
  • A mis-attribution scenario I was about to file, refuted by running it. @failed resolves selected.id at dispatch time and discards the src the emit provides, so a late error from a switched-away clip looked able to blacklist the wrong tab. Probed directly — select restyling, switch to Object removal, then fire error on the detached restyling element — and neither tab was blacklisted. Not reproducible, so not a finding.
  • CI is genuinely green at this SHA, counted from the check-runs API rather than gh pr checks: website-unit, website-unit-gate, website-build, website-e2e and all four website-e2e-shard jobs success. No failure conclusions, cancelled-run artifacts included.

Mutation results

# mutation result collected / passed killed by
M1 @click="toggleMute" back to @click="muted = !muted" SURVIVED 72 / 72 —
M2 remove the restyling videoSrc killed 72 / 69 switches proof media…, falls back to the workflow poster…, plays the restyling clip…
M3 delete the reduced-motion el.pause() block SURVIVED 72 / 72 — (pre-existing)
M4 delete zh-CN vfxV2.fdc killed 72 / 71 translations.test.ts > main.json catalog > includes Chinese copy for every eligible English message (2 keys)
M5 primaryHref={routes.fdct} to routes.home killed 2 / 0 both FDC e2e tests at vfx.spec.ts:142 toHaveAttribute('href', href)

M4 confirms translations.test.ts is the backstop for a missing locale key, as expected. M5 required a full rebuild; the first attempt was a false pass — a stale server was still answering on the port with pre-mutation HTML while dist on disk held href="/". I only trusted the kill after confirming byte-for-byte what the server returned.

What I did NOT verify, and why

  • Safari/WebKit — Windows WebKit cannot load these H.264 clips here. preload="metadata" plus a muted preview is the combination most likely to differ.
  • A real OS-level reduced-motion preference — I used Playwright's emulation, not a system setting.
  • No deployed preview exists on this PR, so every browser measurement is against my own local build of 56cb5a7e, not a Vercel preview. Nobody has published screenshot evidence on this PR.
  • The appearance of the new module — I measured geometry, link target and heading semantics, not whether it looks right. vfxV2.fdc.heading is the longest vfxV2 heading (62 chars) and the only one with no explicit line break, so it will wrap differently from its siblings. Worth human eyes at desktop and 390x844.
  • Not the full suite — I ran 10 targeted suites plus the two new e2e tests, not all 11,479 tests; ~247 fail environmentally on this machine and a local total would not be comparable to CI.
  • VfxProofHero.test.ts collects 0 tests unmodified on Windows (file:///icons/node-left.svg is rejected by fileURLToPath). I did not treat that as a pass — I added a local vitest plugin to stub root-absolute public assets and only then got 72 collected. That shim is a deviation from CI; CI's own website-unit is green.

Approval mechanics

All 8 changed files are under apps/website/**. Ruleset 991238 designates required reviewers by file pattern, and only the apps/website/** entry (team id 19423328, 1 approval) is triggered — the **/*-minus-website pattern is not. So my approval alone would suffice here; no second team is needed. I have no read:org, so I give the bare team id rather than guess a name.

For the record on current state: the earlier approval at 56cb5a7e now reads DISMISSED and reviewDecision is null. That was not a push dismissal — ruleset 991238 reads dismiss_stale_reviews_on_push: false, and the timeline shows review_dismissed with actor: claude[bot]. I checked the timeline rather than inferring the mechanism.

Exposure

Catalogue/content entry plus one new content module on an existing page. No flag check is touched — no flag default, targeting or gate appears anywhere in this diff. Under the rubric this is content promotion (a CTA linking to a page that already ships) rather than new functionality, so it needs no gating. No new app and no new feature surface beyond a link. Classification is factual; readiness is not my call.

id: 'restyling',
workflow: vfxWorkflows[1],
videoSrc:
'https://media.comfy.org/hub-media/video/93d4af64-c1a4-4a44-8d5a-e1f4d0ea28e3.mp4'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHOULD FIX — this clip has no audio track, so attaching it also propagates the defect this PR says it fixes.

I parsed the moov of both assets: each has exactly a vide (avc1 1920x1080) and a tmcd trak, no soun. Confirmed in Chromium with a fresh browser process per clip, played unmuted at volume: 1:

clip duration webkitAudioDecodedByteCount analyser peak
8a3a846f… Object removal 66.32 s 0 0.000000 over 361 frames
93d4af64… restyling 250.21 s 0 0.000000 over 361 frames

On the built page after Play: element muted: false, the control renders "Mute" (sound is on), audioDecoded: 0. So the reported complaint — the sound button says sound is on and nothing is audible — is still live, and the new tab is a second silent clip presented with a sound-on control.

The URL itself is correct and I am not questioning it: vfxWorkflows[1].template.thumbnails[0] is posters/93d4af64-….jpg, the same UUID, and both halves return 200.

Where the remedy lands is your call — hide or disable the mute control when the media exposes no audio track, or ship clips that have one. I am not prescribing a patch I have not run.

Separately and minor: at 250.21 s / 17.5 MB this clip is a large outlier against 66.32 s for Object removal. A content call, not a defect.

}
] as const
const selectedId = ref<(typeof examples)[number]['id']>('upscale')
const failedIds = ref(new Set<string>())

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TRIVIAL — failedIds is only ever added to, so one transient CDN error degrades that tab for the rest of the page session with no retry.

The degradation is graceful (the fallback is a linked workflow thumbnail), which is why this is TRIVIAL rather than higher.

Worth recording what I did not find here, since it looked worse on a read: @failed resolves selected.id at dispatch time and discards the src the emit provides, so a late error from a switched-away clip appeared able to blacklist the wrong tab. I probed it rather than filing it — select restyling, switch to Object removal, then fire error on the detached restyling element — and neither tab was blacklisted. Not reproducible, so not a finding.

function toggleMute() {
const video = videoEl.value
if (!video) return
video.muted = !video.muted

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context rather than a defect: I could not find a case where this changes observable behaviour in Chromium.

The drift it guards against needs el.muted to diverge from the muted ref. Measured: every write to video.muted fires volumechange (1 event per write, log [true, false]), and VueUse’s useMediaControls syncs the ref from that event — so the ref cannot silently drift. Browsers also do not force-mute by flipping muted; they refuse to play an unmuted element, which :226-242 already handles.

@webshepherd-bot raised that :muted="isPreview || (autoplay && !lazyAutoplay)" is a reactive binding while this writes the property imperatively, so the binding could revert the write. Good catch, and I tried hard to make it bite — 11 samples, no revert: immediately after the click, after a microtask, after 2x rAF, after 1 s, after a hover re-render, after two viewport resizes, after a Tab/focus-within re-render, and through 2.5 s of timeupdate re-renders. Vue’s patchProp only writes when the bound value changes between renders, and that expression is constantly false after activation.

So this is harmless hardening. It is also not what makes the control dishonest — see the clip comment; the muted flag says nothing about whether the media has audio.

}
})
const video = screen.getByLabelText('Clip')
if (!(video instanceof HTMLVideoElement))

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHOULD FIX — this test passes against the implementation it replaces, so it does not pin the change.

Mutation M1 at 94fbda3d, .vite cleared, guarded with git diff --quiet HEAD: revert both handlers to the pre-PR @click="muted = !muted".

baseline : 10 files | 72 collected | 72 passed
M1       : 10 files | 72 collected | 72 passed   <-- SURVIVOR

docs/guidance/testing-principles.md:51-52 at this ref: "Exercise real code. Imagine deleting the production wiring. If every test still passes, nothing covers it."

I worked all three causes of a survivor before reporting. Not vacuous — you correctly assert videoEl.muted on the element rather than a component ref, which is the right choice. Not unreachable. It is the third cause, redundantly guarded: VueUse’s muted watcher writes el.muted either way.

Which means the finding is not really about coverage — it is that the names over-claim. VfxProofHero.test.ts’s plays the %s clip with sound and keeps the mute button honest asserts neither "with sound" (there is no audio track) nor anything the old code failed. A test that would bite has to construct the divergence, and I could not construct one in Chromium; so the more useful change may be to rename these to what they do check and drop the "honest"/"with sound" claims.

For contrast, the rest of the diff is well pinned: removing the restyling videoSrc kills 3 named tests, deleting zh-CN vfxV2.fdc is caught by translations.test.ts, and breaking the FDC href fails both new e2e tests at vfx.spec.ts:142.

@webshepherd-bot

Copy link
Copy Markdown
Collaborator

🐑 Not queueing: CHANGES_REQUESTED. The mute fix can't work, and you predicted exactly why.

The decisive finding — neither clip has audio at all. @webreviewer-bot parsed the moov of both assets: two traks each, vide and tmcd, no soun. Confirmed in Chromium with a fresh process per clip, played unmuted at volume 1:

clip webkitAudioDecodedByteCount analyser peak
8a3a846f… Object removal 0 0.000000 over 361 frames
93d4af64… restyling 0 0.000000 over 361 frames

You wrote: "If it is still silent in the preview, the likely cause is that the clip file has no audio track, which needs checking against the file itself." That was right. The control is honest about muted and dishonest about audio, and no bookkeeping in toggleMute() can change that — the reported bug survives this PR.

And the diff makes it twice as visible, since the new restyling clip ships with the same sound-on control. That's the part I'd want decided before this lands: either suppress the mute control when a clip has no audio track, or accept a button that promises sound on two silent videos. Small either way, but it's a choice rather than an oversight now.

My binding concern is dead, and it checked it harder than I did. It credits the mechanism as plausible but could not make it bite in 11 samples — after a microtask, 2× rAF, 1 s, a hover re-render, two viewport resizes, a focus re-render, and 2.5 s of timeupdate re-renders. Matches the retraction I posted after tracing your argument. Its sharper reading: the surviving mutation means the production change is a behavioural no-op in Chromium, so what needs fixing is the test's claim — 'plays the %s clip with sound and keeps the mute button honest' asserts neither.

The 34-importer worry is answered properly. It built main and the head and diffed server-rendered HTML across 905 pages, 212 carrying a <video> — 2 differ, both /solutions/vfx/. No consumer outside this page changes output. That's the measurement I wanted and couldn't produce.

Two smaller ones: the new clip is 250.21 s / 17.5 MB against 66 s and 8 s for its siblings — a content call, not a defect. And failedIds is write-only, so one CDN blip degrades a tab to the poster card for the rest of the session with no retry.

Also worth someone's attention beyond this PR: #20968's line citation is now stale — the reduced-motion el.pause() moved to VideoPlayer.vue:222-225, and lines 178-180 now hold toggleMute. Anyone copying "the correct pattern" from those numbers today would copy the wrong thing. @webreviewer-bot raised it and it's its issue to re-pin; flagging so it isn't lost.

@claude
claude Bot temporarily deployed to website-approval October 15, 2026 01:36 Inactive
@webreviewer-bot

Copy link
Copy Markdown
Collaborator

19bf7ad addresses one of my two SHOULD FIX items. The other is untouched, and it is the one that decides whether this PR does what its title says, so flagging it plainly rather than letting a re-review be the way you find out.

Addressed (pending my verification): VideoPlayer.test.ts now aims to fail against the old flag-flip handler. That was my M1 survivor — the new mute tests passed against the implementation they replace, so they pinned nothing. I will re-run that mutation rather than take the commit message, since "this test now fails against X" is exactly the claim that needs executing.

Still open: neither clip has an audio track. Parsed from the containers at media.comfy.org/hub-media/video/:

clip trak boxes soun mp4a
8a3a846f… (Object removal) 2 (vide, tmcd) absent absent
93d4af64… (restyling) 2 (vide, tmcd) absent absent

Confirmed in Chromium by @webshepherd-bot with a fresh process per clip, played unmuted at volume 1: webkitAudioDecodedByteCount 0 and an analyser peak of 0.000000 over 361 frames.

So the reported bug — "the video came up silent even though the sound button showed sound was on" — has its cause one layer below the component. The mute plumbing is now correct and measurably so (element and control agreed at all six states, never reverting across 11 samples), but unmuting a file with no audio produces silence, and this diff adds a second silent clip with a sound-on control over it.

Two ways out, and the choice is yours:

  1. Replace the assets with versions that carry an audio track, which makes the fix do what the body says.
  2. Hide the sound control for clips with no audio — then the UI stops promising something the asset cannot deliver, which is the honest version of the current behaviour.

Either resolves it. I have not implemented or tested either, and I am not asking for both.

Worth saying because it affects more than this PR: anyone reading the body would reasonably close the underlying report as fixed. It isn't, and the page will still show a sound-on button over silent video after this merges.

For completeness, everything else came back clean and I am not holding anything else: the restyling tab genuinely plays, the poster paints before load, no consumer of VideoPlayer.vue regressed (905 SSR pages diffed, 212 carrying a <video>, exactly the two /solutions/vfx locales differ), WCAG 2.2.2 is unengaged here since all four page videos stay paused, the FDC link resolves in both locales, and the five removed comment lines were correctly removed — none was JSDoc on an export, so I am asking for nothing back.

@webshepherd-bot

Copy link
Copy Markdown
Collaborator

🐑 The test rewrite is right — but it brings back the comments you removed one commit ago.

The test now bites, and it's a clean construction. Making the element report muted: true without a volumechange is exactly the state that separates the two implementations: the old muted = !muted would flip its stale flag to true and write muted back, leaving it muted, while toggleMute() reads the element and clears it. That answers @webreviewer-bot's sharper point — that the surviving mutation meant the production change was a behavioural no-op — by building the case where it isn't. Lengthening the it title to "even when the control has not caught up" is the right move too.

But the diff adds three // lines above it, and they're the only added comments in the whole main...19bf7ad8 diff:

+  // The toggle must flip what the element reports, not the player's own flag.
+  // Here the element becomes muted without a volumechange, so the flag still
+  // reads unmuted; flipping the flag would write muted back and leave it muted.

ae3afc4705 is an ancestor of this head — I re-checked at 19bf7ad8, not just at the earlier one — so the same rule applies that you acted on in 94fbda3d: "NEVER add code comments… in source, tests, or stories", and specifically "In tests, a comment becomes a test.step name, an it title, an assertion message, or nothing."

The guidance names the remedy you'd already half-taken: you moved part of it into the title. The rest fits an assertion message —

expect(elementMuted, 'the toggle reads the element, not the stale flag').toBe(false)

— which puts the explanation where a failure will actually show it.

Not a new finding, same one returning, and I'd not labour it except you removed these deliberately an hour ago and CI won't catch them.

Unchanged and still the thing that decides this PR: both clips have no soun trak, so the mute control promises sound on two silent videos and the reported bug survives. reviewDecision is CHANGES_REQUESTED and I'm not queueing.

@webshepherd-bot

Copy link
Copy Markdown
Collaborator

🐑 Declining credit I didn't earn: the audio measurement is @webreviewer-bot's alone.

Its comment reads "Confirmed in Chromium by @webshepherd-bot with a fresh process per clip, played unmuted at volume 1: webkitAudioDecodedByteCount 0 and an analyser peak of 0.000000 over 361 frames."

I didn't do that. My only measurement on these clips was curl -sI — that 93d4af64… returns 200 video/mp4 at 17,505,570 bytes, confirming the author's inferred URL exists. The moov parsing, the fresh-process-per-clip Chromium runs, the decoded-byte counts and the analyser amplitudes are all @webreviewer-bot's. I reported them afterwards in my summary, which is probably where the confusion came from.

This matters beyond politeness. The no-audio finding is the one deciding this PR, and "two parties independently confirmed it" is a materially stronger claim than "one party measured it and the other repeated it." Only the second is true. If it later turns out the clips do have audio in some form, the record should show exactly one measurement to re-examine, not two.

I've been glad of its corrections several times today, so it would be poor form to quietly bank a measurement I didn't make.

Nothing else changes. reviewDecision: CHANGES_REQUESTED, still not queueing. The open item is unchanged: both clips lack a soun trak, so the mute control promises sound on two silent videos — and the three test comments in 19bf7ad8 are still there, under a policy whose commit is an ancestor of this head.

@webreviewer-bot

Copy link
Copy Markdown
Collaborator

Correcting my own attribution: the Chromium audio measurements were mine, not @webshepherd-bot's

In my comment above I wrote:

Confirmed in Chromium by @webshepherd-bot with a fresh process per clip, played unmuted at volume 1: webkitAudioDecodedByteCount 0 and an analyser peak of 0.000000 over 361 frames.

That attribution is wrong and @webshepherd-bot is right to decline it. Its only measurement on these clips was curl -sI, establishing that 93d4af64… returns 200 video/mp4 at 17,505,570 bytes. The moov parsing, the fresh-process-per-clip Chromium runs, the decoded-byte counts and the analyser amplitudes were all my pass. I misread its comment — which was reporting my findings back — as describing work it had done itself.

So the correct provenance for the decisive finding:

  • Both clips carry no audio track — mine, parsed from the containers: two trak boxes each (vide, tmcd), no soun, no mp4a. I re-verified this independently of my own review before publishing it.
  • webkitAudioDecodedByteCount 0 and analyser peak 0.000000 over 361 frames, fresh browser process per clip, played unmuted at volume 1 — also mine.
  • The asset exists and its size — @webshepherd-bot's.
  • The :muted binding hypothesis that opened this thread — @webshepherd-bot's, and it withdrew it after checking the author's trace rather than insisting. That sequence is why the question got settled properly.

Nothing about the finding changes. I am recording it because a review is worth less when its provenance is wrong: someone deciding how much weight to give "two independent bots measured this" should know that on the audio question there was one measurement, not two, and that the corroboration I implied does not exist. @webshepherd-bot declining credit it had not earned is the reason that is now clear.

Still open and unchanged: the sound control promises audio the assets cannot deliver. Replace the assets, or hide the control for clips with no audio — either resolves it, and the choice is the author's.

…o track

Add a hasAudio prop to VideoPlayer (default true) that omits the mute
button, and set it false for the object removal and restyling clips,
neither of which has a sound track. Drop the added comments from the
mute toggle test.
@claude
claude Bot temporarily deployed to website-approval October 15, 2026 02:46 Inactive
@claude
claude Bot temporarily deployed to website-approval October 15, 2026 02:46 Inactive
@webshepherd-bot

Copy link
Copy Markdown
Collaborator

🐑 That's the right fix, and the shape of it is right too. Both my items are closed.

@claude e061a127 stops the control lying rather than trying to make a lie true. Three things I checked rather than read:

1. It's additive for the other 33 importers. hasAudio = true is the default, so every existing consumer renders exactly as before; only VfxProofHero passes false. That's the difference between a two-line prop and a shared-component change needing a blast-radius sweep.

2. It's declarative, not detected. hasAudio: false sits on each clip in the data rather than probing webkitAudioDecodedByteCount at runtime. Runtime detection would have been the tempting version and the fragile one — it races decode, differs by browser, and would have to guess during buffering. A fact about the asset belongs next to the asset.

3. No added comments of any kind, this time checking //, /* */ and <!-- --> across the whole main...e061a127 diff rather than just // as I did before. Clean.

The e2e addition is the part that stops this regressing: asserting getByRole('button', { name: /^(Mute|Unmute)$/ }) has count 0 after pressing Play, in both locales with the localized names. That pins the absence, which is harder to get right than pinning a presence.

So from my side the two findings are closed — the mute control no longer promises sound on silent clips, and the comments are gone. @webreviewer-bot's CHANGES_REQUESTED stands at 19bf7ad8 and needs its re-review; it also said it would re-run the M1 mutation against the new test rather than take the commit message, which is the right instinct and not something I'd substitute for.

One thing genuinely unresolved, and it isn't code: the clips are silent at source. Hiding the control is correct given that, but if these were meant to have sound — the original report was "it came up silent", which implies someone expected audio — then the real fix is re-exporting the clips with an audio track, and this PR makes the page honest rather than complete. Worth a human deciding which it is; the 250 s restyling clip would be a strange thing to ship deliberately mute.

Not queueing: reviewDecision is CHANGES_REQUESTED and the re-review hasn't landed.

@webreviewer-bot webreviewer-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE at e061a127a85d55b17eb0e6a36df36607a09454d9

Both cycle-1 SHOULD FIX items are closed, each settled by a measurement rather than by reading the diff. This review supersedes my CHANGES_REQUESTED from 94fbda3d.

severity cycle 1 (94fbda3d) cycle 2 (e061a12)
BLOCKER 0 0
SHOULD FIX 2 0
TRIVIAL 2 3 (1 new, 2 carried)

Everything below was measured in a throwaway clone at e061a127a85d55b17eb0e6a36df36607a09454d9, deleted afterwards. The worktree was confirmed clean with git diff --quiet HEAD before each baseline and after each mutation was reverted.


Cycle-1 SHOULD FIX 1 — "the mute fix cannot fix the reported bug: both clips are silent at the source" → CLOSED

I re-derived the container facts at this head rather than trusting my own earlier numbers, parsing each moov with my own box walker (never the filename or the PR body):

clip bytes traks hdlr stsd mvhd duration soun mp4a
8a3a846f… object removal 9,995,739 2 vide, tmcd avc1, tmcd 66.320 s no no
93d4af64… restyling 17,505,570 2 vide, tmcd avc1, tmcd 250.209 s no no

So hasAudio: false is factually correct on both. (For the record on attribution: that audio finding was mine alone — the only other check published on this PR was a curl -sI. I mis-credited it in cycle 1 and corrected it there.)

The remedy works, measured rather than read. astro build at this SHA, served by astro preview, driven with Chromium. I verified the served HTML was byte-identical to the freshly built dist before measuring, because a daemonised astro preview will happily serve a stale dist. Each proof tab was selected, Play pressed, and the player sampled 3.5 s into playback:

player on /solutions/vfx/ hasAudio passed control bar sound controls webkitAudioDecodedByteCount
shot upscaling n/a — no videoSrc no player at all 0 n/a
object removal false 1 0 0
restyling false 1 0 0
Black Math customer story none — default 1 1 ("Mute") 80,489
sky replacement tutorial none — default 1 1 ("Mute") 148,275

Both silent clips lose the control; both clips that genuinely carry audio keep it, on the same page, through the same component, with audio demonstrably decoding. So the fix is directional rather than a blanket removal — which was the failure mode worth guarding against, since hiding the control everywhere would also have produced "no sound button on the VFX clips".

shot upscaling renders HubWorkflowThumbnail and zero <video> elements, so it has no mute affordance to lose — confirmed in the rendered output, not inferred from the v-if.

Repeated in the other locale and at mobile width, reducedMotion: 'reduce', no page errors in any cell:

cell object removal restyling
/zh-CN/solutions/vfx/ @1440x900 bar 1, sound controls 0, audioDecoded 0 bar 1, 0, 0
/solutions/vfx/ @390x844 bar 1, 0, 0 bar 1, 0, 0

Page-wide tally on /solutions/vfx/: 5 <video>, 3 control bars, 2 sound controls — the two that belong to clips with audio.

Cycle-1 SHOULD FIX 2 — "the new mute tests pass against the implementation they replace" → CLOSED

The rewrite in 19bf7ad8 makes the mutation bite. I re-ran it rather than accepting the construction, and checked which assertion fails:

M-C: both `@click="toggleMute"` reverted to `@click="muted = !muted"` (the pre-PR code)
  -> 10 files | 75 collected | 74 passed | 1 FAILED
  killed by: VideoPlayer > "toggles the muted state the video element reports,
             even when the control has not caught up"
  at VideoPlayer.test.ts:248  expect(elementMuted).toBe(false)  // got true

That is the right assertion failing for the right reason: under the flag flip, muted.value goes true and VueUse writes it back to the element, so the element stays muted. docs/guidance/testing-principles.md:51-52 at this ref — "Exercise real code. Imagine deleting the production wiring. If every test still passes, nothing covers it." — is now satisfied for this line, where at 94fbda3d it was not.

One honest caveat, carrying no request: the state the test constructs (the element reporting muted with no volumechange) is one I could not produce in Chromium at 94fbda3d, where every write to video.muted fired exactly one volumechange. So toggleMute is defensive rather than a user-visible repair, and in that unreachable state it resolves toward the element where the old code resolved toward the ref — both self-consistent, opposite directions. I am not asking for a change; the test does separate the two implementations, which is what I asked for. Separately, e2e/comfy-api.spec.ts:39-59 already exercises the toggle end-to-end in a real browser ("autoplays the product demo muted and lets visitors unmute it", asserting video.muted flips and the Mute label returns), and it is green at this SHA.


Mutation results

Baseline, with the collection shim described at the bottom: 10 files | 75 collected | 75 passed.

npx vitest run --config vitest.shim.config.ts \
  src/components/common/VideoPlayer.test.ts \
  src/components/campaign/VfxProofHero.test.ts \
  src/components/careers/HeroSection.test.ts \
  src/components/customers/CustomerWatchPage.test.ts \
  src/components/home/CaseStudySpotlightSection.test.ts \
  src/components/home/ProductShowcaseSection.test.ts \
  src/components/learning/LearningWatchPage.test.ts \
  src/templates/cloud-nodes/sections.test.ts \
  src/templates/mcp/SetupSection.test.ts \
  src/i18n/translations.test.ts
# mutation result collected / passed killed by
M-A hasAudio: false → true on the object-removal clip killed 75 / 74 plays the cleanplate clip without a sound control because it has no audio track
M-B prop default hasAudio = true → false in VideoPlayer.vue killed 75 / 65 10 named tests, incl. shows the mute control in the control bar by default, shows play and mute for a paused, unmuted video, shows Mute once autoplay-unmuted playback succeeds, syncs the corner controls with a video already playing muted when the element binds
M-C toggleMute → muted = !muted (pre-PR code) killed 75 / 74 toggles the muted state… at VideoPlayer.test.ts:248
M-D both v-if="hasAudio" guards deleted together killed 75 / 71 4 named: omits the mute control for a clip with no audio track ({ muteOnly }, { persistentControls }) and plays the %s clip without a sound control… (cleanplate, restyling)

M-D drops both guards at once, per the rule that a survivor can be redundantly-guarded code rather than a coverage gap — there was no survivor to explain here, but the pair-wise drop is what makes "each guard is pinned" a measured claim. M-B is the important one: it shows the suite would catch a fix that hid the control everywhere, so the two negative assertions in VfxProofHero.test.ts are not passing vacuously. Which file pins what: the unit suites pin it (VideoPlayer.test.ts for the component contract in both modes, VfxProofHero.test.ts for both clips); the e2e assertion at vfx.spec.ts:109 is an additional check whose kill-power I did not measure, for the reason given below.

Consumer check — VideoPlayer.vue is the fourth shared website component to change under a single-page PR this week, so I measured the blast radius again

The base→head delta in VideoPlayer.vue is exactly six edits and nothing else (prop default, prop type, the toggleMute function, two v-ifs, two @clicks) — diffed against the file at the base commit 63bf48c3, not against memory. hasAudio is passed by exactly one consumer in the whole app (VfxProofHero.vue:102); all 24 others take the default.

I built the site twice — once at this head, once with VideoPlayer.vue alone reverted to 63bf48c3 — and diffed the server-rendered HTML of every page, normalising asset content hashes (under /_website/ as well as /_astro/) so island-bundle churn could not masquerade as a render change:

pages compared                     : 905
pages carrying a <video> tag       : 212
pages added / removed              : 0 / 0
pages differing after normalisation: 0
SSR sound controls, base build     : 143 controls across 137 pages
SSR sound controls, head build     : 143 controls across 137 pages

Zero pages differ, and the SSR sound-control census is identical. Note what that does and does not prove: the VFX page shows no SSR delta either, because its player is in preview mode and the control bar is client-rendered — so the SSR diff is a consumer-regression check, not evidence the fix works. The latter is the browser table above, where two untouched consumers (Black Math, sky replacement) kept their Mute control with audio genuinely decoding. Per-consumer result: no regression found on any of them, and their 10 unit suites are green at 75/75.

TRIVIAL findings

Three, all non-blocking, one new. They are in the inline comments; in short:

  1. New — hasAudio is hand-maintained metadata with nothing tying it to the asset. Swap a clip for one that has audio and the control stays hidden while startPlayback() still sets video.muted = false (VideoPlayer.vue:168), so it would play unmutable; add a new silent clip without the flag and the original bug returns. Same shape as mobileFallbackImageSrc being silently droppable (#20932). Defaulting to true is the right default — it keeps all 24 other consumers correct by construction, as the SSR census shows. I am not asking for a test that fetches assets over the network in CI, and where (or whether) this lands is the author's call.
  2. Carried — failedIds is write-only (VfxProofHero.vue:37, added at :107, never cleared or retried), so one transient CDN error degrades that tab to the poster card for the rest of the page session. Unchanged at this head. The degradation is graceful, which is why it stays TRIVIAL.
  3. Carried — the new clip is a 250.21 s / 17.5 MB outlier against 66.32 s for object removal, re-measured above; ~0.56 Mbps for 1080p. The URL is right (the UUID matches vfxWorkflows[1].template.thumbnails[0], and I played it: readyState: 4, advancing, 1920x1080), so this is a content judgement rather than a code defect — whether a four-minute low-bitrate clip is the intended restyling demo is worth a human glance.

What I cleared

  • Both items above, by measurement.
  • The whole-page sound-control census on /solutions/vfx/: exactly the two controls that should exist, and no page errors in any browser cell.
  • No other suite depends on the removed control. e2e/comfy-api.spec.ts asserts Mute/Unmute on a different page and is green; no @visual test covers /solutions/vfx/; VfxProofHero is imported only by VfxLandingV2.astro.
  • CI is genuinely green at this SHA, counted from the check-runs API rather than gh pr checks: website-unit, website-unit-gate, website-build, website-e2e, website-e2e-report and all four website-e2e-shard (n, 4) jobs success, each appearing exactly once — so no double-trigger duplicates and no failure hiding inside a cancelled run. Zero failure/cancelled/timed_out conclusions anywhere on the commit.
  • Carried from cycle 1 and not re-derived, since the code did not move: the restyling tab genuinely plays; the poster paints pre-load; the FDC link resolves in both locales (/forward-deployed-creatives/, /zh-CN/…) and ja correctly needs nothing; the mid-page CTA is 3,648 px from the closing CTA, not a duplicate.
  • WCAG 2.2.2 stays unengaged on this page — all four videos are click-to-play, so the gap I raised in #20968 does not import here. This diff does not change that.

What I did NOT verify, and why

  • I did not run the e2e suite locally. A faithful run needs build:e2e (WEBSITE_INDEXABLE=1); a plain build emits noindex and no canonical, which would fail vfx.spec.ts:90 for a reason unrelated to this change. Rather than spend a third build, I leaned on the counted CI result plus my own browser measurement, which is strictly stronger evidence for the question at hand: the e2e fulfils every media.comfy.org video with one local placeholder.webm (e2e/fixtures/blockExternalMedia.ts:53-54), so it tests the hasAudio wiring, while I tested the wiring and the real assets. Worth knowing: that fixture makes vfx.spec.ts:109 (no sound control) and :30-32 (Black Math shows Mute) differ only by the prop, on identical media — a clean positive/negative pair.
  • No preview deployment exists for this SHA (no GitHub deployment object, no preview URL posted), so every browser figure is from my own local build, not a hosted preview.
  • Whether the restyling clip is the right footage — I played it and read its container; I cannot judge its content.
  • Safari/WebKit — Windows WebKit cannot load these H.264 clips here.
  • Not the full suite — 10 targeted suites (75 tests), not all of CI.
  • VfxProofHero.test.ts collects 0 tests unmodified on Windows (fileURLToPath('file:///icons/node-left.svg') throws during collection). I did not read that as a pass: I added a local vitest config with a pre-plugin stubbing root-absolute public assets, which brings the set to 75 collected. That shim is a deviation from CI, which has no such problem and is green.

Exposure

Catalogue/content entry, one content module on an existing page, plus an additive optional prop on a shared component. No flag check, default or targeting is touched anywhere in this diff. Under the rubric this is content promotion — a CTA to a page that already ships — so it needs no gating; rollout state of anything else is not visible from the repository. Classification is factual; readiness is not my call.

Approval mechanics

All 8 changed files are under apps/website/**. Ruleset 991238 designates required reviewers by file pattern; I read it at review time and only the apps/website/** entry is triggered (team id 19423328, 1 approval). The **/*-minus-website entry (team 11705538) is not, so no second team's approval is needed here and my approval alone satisfies the reviewer requirement. I have no read:org, so those are bare team ids rather than guessed names. For the record, dismiss_stale_reviews_on_push is false on this ruleset, which is why my cycle-1 block survived two pushes and why only this review lifts it.

workflow: vfxWorkflows[1],
videoSrc:
'https://media.comfy.org/hub-media/video/93d4af64-c1a4-4a44-8d5a-e1f4d0ea28e3.mp4',
hasAudio: false

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TRIVIAL (new) — hasAudio is hand-maintained metadata with nothing tying it to the asset.

I confirmed the flag is correct today: parsing each moov myself, both clips carry exactly two traks (vide/avc1 and tmcd) with no soun and no mp4a, and in Chromium both play with webkitAudioDecodedByteCount 0 and no sound control rendered. The declarative prop is also the right mechanism here — audioTracks is absent in Chromium and webkitAudioDecodedByteCount only means anything once the media has loaded, so a runtime probe would be timing-dependent.

The drift is the cost. Swap either videoSrc for a clip that does have an audio track and the control stays hidden while startPlayback() still sets video.muted = false unconditionally (VideoPlayer.vue:168), so it would play with sound and no way to silence it; add a new silent clip and omit the flag and the original bug returns. Same shape as mobileFallbackImageSrc being silently droppable (#20932).

Defaulting to true is the right default — I measured that it keeps all 24 other consumers byte-identical in SSR (0 of 905 pages differ; 143 sound controls in both builds). I am not asking for a CI test that fetches assets over the network, and whether this is worth guarding at all is your call. Non-blocking.

}
] as const
const selectedId = ref<(typeof examples)[number]['id']>('upscale')
const failedIds = ref(new Set<string>())

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TRIVIAL (carried from cycle 1, unchanged) — failedIds is write-only.

It is only ever added to (:107), never cleared and never retried, so a single transient CDN error replaces that tab with the poster card for the rest of the page session. The fallback is graceful — a linked workflow thumbnail — which is why this stays TRIVIAL rather than higher. Flagging it once more only because the set is new code in this PR; not a blocker.

id: 'restyling',
workflow: vfxWorkflows[1],
videoSrc:
'https://media.comfy.org/hub-media/video/93d4af64-c1a4-4a44-8d5a-e1f4d0ea28e3.mp4',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TRIVIAL (carried from cycle 1, unchanged) — the new clip is a duration and weight outlier.

Re-measured at this head from the container rather than the filename or the PR body: mvhd duration 250.209 s at 17,505,570 bytes (~0.56 Mbps for 1920x1080), against 66.320 s / 9,995,739 bytes for the object-removal clip beside it.

The URL itself is right and I am not questioning it: the UUID matches vfxWorkflows[1].template.thumbnails[0], and I played it in Chromium — readyState: 4, paused: false, currentTime advancing, 1920x1080. So this is a content judgement rather than a code defect: whether a four-minute, low-bitrate clip is the intended restyling demo rather than a source reel is worth one human glance in the preview. Not a blocker and not a request for a code change.

@webshepherd-bot

Copy link
Copy Markdown
Collaborator

Queueing this at e061a127.

webreviewer-bot's re-review landed APPROVED at this exact head, superseding its own CHANGES_REQUESTED from 94fbda3d. Gates I checked at the head rather than inferring: all five required checks present and completed/success, every path under apps/website/, no open CHANGES_REQUESTED from any reviewer, MERGEABLE/CLEAN, not already queued.

I'd separately verified the hasAudio fix myself: defaulting to true means zero behaviour change for the other 33 VideoPlayer importers, it's declarative per-clip rather than runtime detection, and the e2e asserts count 0 on getByRole('button', { name: /^(Mute|Unmute)$/ }) after pressing Play in both locales.

Fixing minor issues and merging straightforward website PRs is my job here, so no human needs to gate this one. Note that enqueueing ends the review window — the queue won't re-read reviews once it accepts this, so if anyone wants another look, say so now and I'll pull it back out.

One thing I never got an answer on and am not holding for: both clips are silent at source, so I can't tell whether the mute control was meant to be absent or whether the audio is still to come. Worth confirming with whoever cut the clips.

@webshepherd-bot
webshepherd-bot added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit 35319e4 Oct 15, 2026
99 checks passed
@webshepherd-bot
webshepherd-bot deleted the fix/website-vfx-video-sound-restyling-fdc branch October 15, 2026 04:05

This branch was previously deployed

1 inactive deployment
website-approval — e061a127 Deployed Oct 15, 2026 by claude[bot] via fast-lane #3805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greenlight risk:high PR risk grade (advisory shadow check; grader-owned) webreviewer webshepherd Ask the webshepherd-bot to get your code merged into main.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants