Skip to content

fix: make fallow boundary violations warn-only - #21017

Merged
DrJKL merged 1 commit into
mainfrom
fix/fallow-boundaries-warn-only
Oct 14, 2026
Merged

DrJKL merged 1 commit into
mainfrom
fix/fallow-boundaries-warn-only

Conversation

@DrJKL

@DrJKL DrJKL commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Fallow treats boundary-violation as an error by default. That made the new domain boundaries fail the fallow audit gate on any PR touching code that already crosses zones (e.g. #19189, 16 boundary findings). This sets the rule to warn in .fallowrc.jsonc. The generated boundaries.json only declares zones, so the override lives in the hand-written config, where pnpm architecture:update won't overwrite it.

Verification

Ran fallow audit --root . --format json --changed-since 55c9746 on #19189's head:

  • Before: verdict fail, with boundary violations counted as errors.
  • After: the boundary findings are warnings. The verdict is still fail, but only because of an unrelated unused class member (ComfySettingsDialog.getSettingValue) that refactor: break the small app import cycles #19189 introduces. Setting that rule to warn as well, only to isolate it, gives verdict warn, exit 0.

https://ampcode.com/threads/T-3b0cb205-c956-4aef-8d70-1d643cdffcf2

Domain boundaries were just introduced and existing code still crosses
many zones, so fallow's default error severity failed the audit gate on
any PR touching those files. Report them as warnings until the
boundaries settle.

Amp-Thread-ID: https://ampcode.com/threads/T-3b0cb205-c956-4aef-8d70-1d643cdffcf2
@DrJKL
DrJKL requested a review from a team October 14, 2026 19:59
@DrJKL
DrJKL temporarily deployed to website-approval October 14, 2026 19:59 — with GitHub Actions Inactive
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 87944a28-02ae-4fe0-80ad-056364c20634
📥 Commits

Reviewing files that changed from the base of the PR and between 55c9746 and 93baa6f.

📒 Files selected for processing: 1
  • .fallowrc.jsonc

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

📝 Walkthrough

The Fallow rules configuration now sets boundary-violation to warning severity.

Changes: Fallow boundary warning

Layer / File(s) Summary
Configure boundary violation warning
.fallowrc.jsonc
The configuration sets the boundary-violation rule to warn.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: christian-byrne

Merge Risk: ⚪ Minimal · up to 93baa

Boundary violations will be warnings rather than audit errors, as intended. The reported remaining audit failure was attributed to an unrelated rule; the change appears mergeable.

Pre-merge checks: Passed 7
Passed Passed checks: 7 passed
Check name Status Explanation
Description check Passed The description includes the required Summary and Verification sections. It explains the problem, the configuration change, the design rationale, verification command, observed results, and remaining …
Title check Passed The title is concise, specific, and accurately identifies the main change: making Fallow boundary violations warn-only.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
End-To-End Test Suggestion For User-Facing Changes Passed The PR changes only .fallowrc.jsonc, which is tooling configuration. It does not change the main frontend application under src/ or packages/, so this check is not applicable.
Website End-To-End Regression Coverage Passed The PR changes only .fallowrc.jsonc. It does not change files under apps/website/src/ or apps/website/public/, so this website-specific check does not apply.
Adr Compliance For Entity/Litegraph Changes Passed PASS: The PR changes only .fallowrc.jsonc. No changed file is under src/lib/litegraph/, src/ecs/, or a graph-entity-related path. The ADR compliance check does not apply.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: 9.44 MB gzip 🟢 -2 B

Details

Summary

  • Raw size: 40.6 MB baseline 40.6 MB — ⚪ 0 B
  • Gzip: 9.44 MB baseline 9.44 MB — 🟢 -2 B
  • Brotli: 7.31 MB baseline 7.31 MB — 🟢 -23 B
  • Bundles: 556 current • 556 baseline • 2 added / 2 removed

Category Glance
Other ⚪ 0 B (19.4 MB) · Vendor & Third-Party ⚪ 0 B (13.9 MB) · Graph Workspace ⚪ 0 B (2.45 MB) · Data & Services ⚪ 0 B (2.17 MB) · Utilities & Hooks ⚪ 0 B (999 kB) · Panels & Settings ⚪ 0 B (670 kB) · + 5 more

App Entry Points — 4.98 kB (baseline 4.98 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-D00nVA8G.js (new) — 4.98 kB 🔴 +4.98 kB 🔴 +2.55 kB 🔴 +2.17 kB
assets/index-hSpfRwf_.js (removed) 4.98 kB — 🟢 -4.98 kB 🟢 -2.55 kB 🟢 -2.17 kB

Status: 1 added / 1 removed

Graph Workspace — 2.45 MB (baseline 2.45 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 3 unchanged

Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 18 unchanged

Panels & Settings — 670 kB (baseline 670 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 29 unchanged

User & Accounts — 275 kB (baseline 275 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 17 unchanged

Editors & Dialogs — 340 kB (baseline 340 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 12 unchanged

UI Components — 212 kB (baseline 212 kB) • ⚪ 0 B

Reusable component library chunks

Status: 24 unchanged

Data & Services — 2.17 MB (baseline 2.17 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 24 unchanged

Utilities & Hooks — 999 kB (baseline 999 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 63 unchanged

Vendor & Third-Party — 13.9 MB (baseline 13.9 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 17 unchanged

Other — 19.4 MB (baseline 19.4 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/main-CbK3_KJQ.js (new) — 56.5 kB 🔴 +56.5 kB 🔴 +17.3 kB 🔴 +14.7 kB
assets/main-DzLEH7tU.js (removed) 56.5 kB — 🟢 -56.5 kB 🟢 -17.3 kB 🟢 -14.7 kB

Status: 1 added / 1 removed / 347 unchanged

⚡ Performance

⏳ Performance tests in progress…

🎭 Playwright: ✅ 2276 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2254 / ❌ 0 / ⚠️ 2 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 55c974688a2ff022ee0a463774228b6399c81b47

Full docs: ADR-DEVEX-LINT-0015

@DrJKL
DrJKL enabled auto-merge October 14, 2026 20:03
@DrJKL
DrJKL disabled auto-merge October 14, 2026 20:05
@DrJKL
DrJKL enabled auto-merge October 14, 2026 20:06

@AustinMroz AustinMroz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this get moved back to error once the untangling is done? 🤔

@DrJKL
DrJKL disabled auto-merge October 14, 2026 20:08
@DrJKL
DrJKL merged commit c9d837d into main Oct 14, 2026
115 checks passed
@DrJKL
DrJKL deleted the fix/fallow-boundaries-warn-only branch October 14, 2026 20:09
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 14, 2026
@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #21017      +/-   ##
==========================================
+ Coverage   86.38%   87.18%   +0.79%     
==========================================
  Files        3674     2613    -1061     
  Lines      175334   146929   -28405     
  Branches    46306    38209    -8097     
==========================================
- Hits       151470   128096   -23374     
+ Misses      21822    18445    -3377     
+ Partials     2042      388    -1654     
Flag Coverage Δ
billing-web-unit ?
unit 85.05% <ø> (ø)
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1061 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch was previously deployed

1 inactive deployment
website-approval — 93baa6f3 Deployed Oct 14, 2026 by DrJKL via fast-lane #2973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants