Repository navigation
fix: make fallow boundary violations warn-only - #21017
Conversation
Domain boundaries were just introduced and existing code still crosses many zones, so fallow's default error severity failed the audit gate on any PR touching those files. Report them as warnings until the boundaries settle. Amp-Thread-ID: https://ampcode.com/threads/T-3b0cb205-c956-4aef-8d70-1d643cdffcf2
📦 Bundle: 9.44 MB gzip 🟢 -2 BDetailsSummary
Category Glance App Entry Points — 4.98 kB (baseline 4.98 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.45 MB (baseline 2.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 670 kB (baseline 670 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 29 unchanged User & Accounts — 275 kB (baseline 275 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 17 unchanged Editors & Dialogs — 340 kB (baseline 340 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 12 unchanged UI Components — 212 kB (baseline 212 kB) • ⚪ 0 BReusable component library chunks Status: 24 unchanged Data & Services — 2.17 MB (baseline 2.17 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 24 unchanged Utilities & Hooks — 999 kB (baseline 999 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 63 unchanged Vendor & Third-Party — 13.9 MB (baseline 13.9 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 19.4 MB (baseline 19.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 347 unchanged ⚡ Performance
🎭 Playwright: ✅ 2276 passed, 0 failed · 2 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 55c974688a2ff022ee0a463774228b6399c81b47
Full docs: ADR-DEVEX-LINT-0015 |
AustinMroz
left a comment
There was a problem hiding this comment.
Will this get moved back to error once the untangling is done? 🤔
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21017 +/- ##
==========================================
+ Coverage 86.38% 87.18% +0.79%
==========================================
Files 3674 2613 -1061
Lines 175334 146929 -28405
Branches 46306 38209 -8097
==========================================
- Hits 151470 128096 -23374
+ Misses 21822 18445 -3377
+ Partials 2042 388 -1654
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
Fallow treats
boundary-violationas an error by default. That made the new domain boundaries fail thefallowaudit gate on any PR touching code that already crosses zones (e.g. #19189, 16 boundary findings). This sets the rule towarnin.fallowrc.jsonc. The generatedboundaries.jsononly declares zones, so the override lives in the hand-written config, wherepnpm architecture:updatewon't overwrite it.Verification
Ran
fallow audit --root . --format json --changed-since 55c9746on #19189's head:fail, with boundary violations counted as errors.fail, but only because of an unrelated unused class member (ComfySettingsDialog.getSettingValue) that refactor: break the small app import cycles #19189 introduces. Setting that rule to warn as well, only to isolate it, gives verdictwarn, exit 0.https://ampcode.com/threads/T-3b0cb205-c956-4aef-8d70-1d643cdffcf2