Repository navigation
[backport cloud/1.57] FE-3441 fix(billing): accept the server's own user id on the capabilities read - #21013
Conversation
…ties read (#21004) ## Summary Accept the server's canonical user id in `resolved_for` on the billing SDK capabilities read, so capabilities resolve with `unified_web_session` off. - Fixes FE-3441 - Found in 1.57 QA on testcloud (billing case): https://comfy-organization.slack.com/archives/C0932CGKT5K/p1791995382106729?thread_ts=1791952563.933479&cid=C0932CGKT5K ## Why With `web_session_enabled` ON, `unified_web_session` OFF and the billing SDK rail on, a personal-workspace user has no Upgrade plan button in Settings -> Plan & Credits, and Plans & pricing -> Monthly -> "Change to Pro" does nothing. `GET /api/billing/capabilities` returns 200 with `can_subscribe_self_serve: true`, but the app logs `billing.capability_read.failed` on every load. With `unified_web_session` ON it works. ## Root cause On the OFF path the SDK is built on the unified session client (`billingSdkStore.sessionPorts()`), and `sessionBillingScopeSource` sets `scope.userId` to the Firebase uid. On the ON path `createWebSessionBillingSession` uses the session's Comfy user id. `projectCapabilities` in `packages/account-core/src/core/billing/capabilities.ts` required both `resolved_for.user_id === scope.userId` and the workspace to match. The server puts its canonical user id in `resolved_for.user_id`, which is not always the Firebase uid. When they differ, every read becomes `REQUEST_FAILED` on a 200, `readOnRail` throws, `useBillingCapabilities` marks the read unavailable, and `canSubscribeSelfServe` stays false. Evidence from the reporter's account (staging PostHog, last 24h): | distinct id | event | count | | - | - | - | | Firebase uid (`EJfiug…`) | `billing.capability_read.failed` | 38 | | canonical id (`C3Niv…`, the `resolved_for.user_id` the server returned) | `billing.capability_read.succeeded` | 357 | The workspace ids match (`resolved_for.workspace_id` equals the minted session's workspace). ## How - Check only `resolved_for.workspace_id` in `projectCapabilities`. The legacy composable already checks only the workspace (its test "accepts a canonical server user ID distinct from the Firebase UID"). The user half is the credential's to prove: the server resolves for the caller the request was sent as, and ingest checks both halves upstream. - `capabilities.test.ts`: the "refuses another member's answer" case is replaced by one that accepts the server's own user id for the caller. - `webSessionFlagOff.test.ts`: new test on the real SDK, unified session client and flags (`unified_cloud_auth` + SDK rails on, `unified_web_session` absent / false), where the server answers with a canonical user id. Fails before the fix with `status: 'error'`, passes after. Trade-off for reviewers: this drops the user-id half of a defence-in-depth check. Keeping it would need the canonical user id on the OFF path, and nothing there carries it today (token exchange and `/workspaces/current` don't return it). Backport to `cloud/1.56` (prod path, see Impact) and `cloud/1.57` (found in 1.57 QA; testcloud serves `cloud/1.57`). Cloud only: the capabilities read runs only on the cloud billing rail. ## Impact `cloud/1.56` has the same check and the same rail, and prod `billing_sdk_subscription_enabled` has been at 100% since Oct 8 while prod `web_session_enabled` is at 0%, so prod users are on this path. Prod PostHog, last 24h: 59 users had only `billing.capability_read.failed` and no `succeeded` (3,407 failed reads), consistent with users whose canonical id differs from their Firebase uid. A further 2,467 users had both; those include transient failures this PR does not change. Out of scope: when the capabilities read is unavailable for another reason (timeout, outage, no scope yet), `handleSubscribeClick` still returns silently while the CTA renders enabled. Tracked separately. ## AS IS / TO BE ### AS IS _Placeholder: testcloud, unified_web_session OFF, Plan & Credits without Upgrade plan._ ### TO BE _Placeholder: same account on this branch, Upgrade plan shown and Change to Pro opens checkout._ ## Plan position | # | Item | Ticket | PR | Status | | - | ---- | ------ | -- | ------ | | 1 | Name personal-type workspaces on session requests | FE-3438 | PR 20997 | merged | | **2** | **Accept canonical user id on SDK capabilities read** | **FE-3441** | **this PR** | **in review** | | 3 | Backport to cloud/1.56 and cloud/1.57 | FE-3441 | auto (needs-backport) | pending merge | | 4 | Re-check 1.57 billing case on testcloud (unified OFF) | FE-3441 | none | pending | ```mermaid flowchart LR A["FE-3438 PR 20997"] --> C["1.57 billing QA re-check"] B["FE-3441 this PR"] --> C style B fill:#ffd54f,stroke:#f57f17,stroke-width:3px ```
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-14T18:29:52.856Z",
"gitSha": "ed32e20fbfc83a8abf188b49bd2dd91e781b1bcf",
"branch": "backport-21004-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.4530000000177,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9539999999999993,
"layouts": 9,
"layoutDurationMs": 2.909,
"taskDurationMs": 550.6999999999999,
"heapDeltaBytes": 21360184,
"heapUsedBytes": 87152520,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 11.827,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2019.3800000000692,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9369999999999994,
"layouts": 9,
"layoutDurationMs": 2.904,
"taskDurationMs": 560.9439999999998,
"heapDeltaBytes": 22035180,
"heapUsedBytes": 87997532,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 12.947000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1789.9590000000103,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.761999999999999,
"layouts": 9,
"layoutDurationMs": 2.6650000000000005,
"taskDurationMs": 883.585,
"heapDeltaBytes": -8256896,
"heapUsedBytes": 66673628,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 161.674,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1961.2869999999702,
"styleRecalcs": 82,
"styleRecalcDurationMs": 17.692,
"layouts": 9,
"layoutDurationMs": 2.997,
"taskDurationMs": 994.8050000000001,
"heapDeltaBytes": 15574572,
"heapUsedBytes": 81461408,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 173.801,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.6890000000358,
"styleRecalcs": 20,
"styleRecalcDurationMs": 7.067,
"layouts": 11,
"layoutDurationMs": 3.8800000000000003,
"taskDurationMs": 462.151,
"heapDeltaBytes": -4111936,
"heapUsedBytes": 71218780,
"domNodes": 47,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 16.158999999999995,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1780.255000000011,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.242000000000001,
"layouts": 11,
"layoutDurationMs": 3.4140000000000006,
"taskDurationMs": 492.7049999999999,
"heapDeltaBytes": 19115836,
"heapUsedBytes": 85021404,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 16.462999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 608.8039999999637,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.665,
"layouts": 9,
"layoutDurationMs": 2.8069999999999995,
"taskDurationMs": 442.505,
"heapDeltaBytes": 25683356,
"heapUsedBytes": 91053056,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 171.11300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.142857142857142,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 675.0800000000936,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.269,
"layouts": 10,
"layoutDurationMs": 3.0210000000000004,
"taskDurationMs": 461.36600000000004,
"heapDeltaBytes": 25603496,
"heapUsedBytes": 91049696,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 177.245,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1290.6370000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1026.008,
"heapDeltaBytes": -11639416,
"heapUsedBytes": 81447216,
"domNodes": -192,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 85.87000000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 589,
"frameDurationMs": 33.768421052631574,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1240.4719999999543,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 939.2270000000001,
"heapDeltaBytes": -11274756,
"heapUsedBytes": 81360692,
"domNodes": -192,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 75.543,
"eventListeners": -106,
"totalBlockingTimeMs": 552,
"frameDurationMs": 33.33243243243244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 854.3789999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.33099999999985,
"heapDeltaBytes": -4345876,
"heapUsedBytes": 76535520,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 161.553,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.1849999999913,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.4010000000006,
"heapDeltaBytes": -5256704,
"heapUsedBytes": 75814700,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 156.29,
"eventListeners": 0,
"totalBlockingTimeMs": 211,
"frameDurationMs": 25.0029411764706,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11246.938999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10339.357999999998,
"heapDeltaBytes": -16883692,
"heapUsedBytes": 70484188,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 8356.81,
"eventListeners": -68,
"totalBlockingTimeMs": 1386,
"frameDurationMs": 31.46470588235294,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10306.269000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9458.162000000002,
"heapDeltaBytes": -9794316,
"heapUsedBytes": 84492824,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 7659.979,
"eventListeners": -68,
"totalBlockingTimeMs": 924,
"frameDurationMs": 31.21090909090909,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11721.176000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10853.353000000001,
"heapDeltaBytes": -22988720,
"heapUsedBytes": 75972304,
"domNodes": -258,
"jsHeapTotalBytes": 11661312,
"scriptDurationMs": 8850.442,
"eventListeners": -64,
"totalBlockingTimeMs": 1415,
"frameDurationMs": 31.751219512195117,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9683.958999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8837.956,
"heapDeltaBytes": -2711936,
"heapUsedBytes": 97051260,
"domNodes": -258,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 7098.127,
"eventListeners": -68,
"totalBlockingTimeMs": 696,
"frameDurationMs": 31.23548387096774,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 246.57200000001467,
"styleRecalcs": 23,
"styleRecalcDurationMs": 18.008,
"layouts": 11,
"layoutDurationMs": 3.612,
"taskDurationMs": 183.475,
"heapDeltaBytes": -7400112,
"heapUsedBytes": 80619032,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 9.745,
"eventListeners": 195,
"totalBlockingTimeMs": 9,
"frameDurationMs": 25,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 248.09100000004491,
"styleRecalcs": 24,
"styleRecalcDurationMs": 19.785,
"layouts": 11,
"layoutDurationMs": 4.239,
"taskDurationMs": 198.689,
"heapDeltaBytes": -7757720,
"heapUsedBytes": 80119840,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.431000000000001,
"eventListeners": 195,
"totalBlockingTimeMs": 7,
"frameDurationMs": 25,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2040.8649999999966,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.0690000000000004,
"layouts": 8,
"layoutDurationMs": 2.5849999999999995,
"taskDurationMs": 745.229,
"heapDeltaBytes": -26101312,
"heapUsedBytes": 72126092,
"domNodes": -258,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 41.155,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.7090000000453,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.8719999999999994,
"layouts": 8,
"layoutDurationMs": 3.0140000000000002,
"taskDurationMs": 699.9649999999999,
"heapDeltaBytes": -2312880,
"heapUsedBytes": 76432192,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 35.497,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2531.4199999999687,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.306000000000001,
"layouts": 7,
"layoutDurationMs": 1.9549999999999996,
"taskDurationMs": 1713.007,
"heapDeltaBytes": -12214228,
"heapUsedBytes": 67724740,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 810.926,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77682119205298,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2744.6820000000116,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.276,
"layouts": 7,
"layoutDurationMs": 1.8639999999999999,
"taskDurationMs": 1745.625,
"heapDeltaBytes": -11714860,
"heapUsedBytes": 68142012,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 834.8149999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76768292682927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3637.04800000005,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.212,
"layouts": 64,
"layoutDurationMs": 11.270999999999999,
"taskDurationMs": 1610.438,
"heapDeltaBytes": 1637532,
"heapUsedBytes": 83090464,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 796.7339999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.742396313364054,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3640.190000000075,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.578,
"layouts": 65,
"layoutDurationMs": 11.777,
"taskDurationMs": 1663.8099999999997,
"heapDeltaBytes": -9668324,
"heapUsedBytes": 71664140,
"domNodes": -234,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 804.9150000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.742396313364058,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3082.0919999999887,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.888,
"layouts": 5,
"layoutDurationMs": 1.2360000000000002,
"taskDurationMs": 1860.3939999999998,
"heapDeltaBytes": 18291572,
"heapUsedBytes": 101538488,
"domNodes": 0,
"jsHeapTotalBytes": 8806400,
"scriptDurationMs": 1015.8430000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.030601092896173,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3177.5579999999763,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.45,
"layouts": 6,
"layoutDurationMs": 1.8440000000000005,
"taskDurationMs": 2076.922,
"heapDeltaBytes": 8897168,
"heapUsedBytes": 87398300,
"domNodes": 0,
"jsHeapTotalBytes": 2846720,
"scriptDurationMs": 1005.2959999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.93191489361702,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2056.5689999999677,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1670000000000007,
"layouts": 7,
"layoutDurationMs": 2.585,
"taskDurationMs": 741.2640000000001,
"heapDeltaBytes": -22392684,
"heapUsedBytes": 76061328,
"domNodes": -258,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 41.79500000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.430000000024,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.255000000000001,
"layouts": 7,
"layoutDurationMs": 2.416,
"taskDurationMs": 548.6450000000001,
"heapDeltaBytes": -1689220,
"heapUsedBytes": 79319972,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 40.112,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 631.8769999999745,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.441000000000001,
"layouts": 9,
"layoutDurationMs": 3.023,
"taskDurationMs": 451.589,
"heapDeltaBytes": -1087544,
"heapUsedBytes": 76296200,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 151.22299999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 681.1679999999569,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.555,
"layouts": 9,
"layoutDurationMs": 2.8789999999999996,
"taskDurationMs": 471.785,
"heapDeltaBytes": -2315600,
"heapUsedBytes": 74289460,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 152.10999999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2025.7859999999823,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.952000000000001,
"layouts": 9,
"layoutDurationMs": 2.8669999999999995,
"taskDurationMs": 546.267,
"heapDeltaBytes": 22514236,
"heapUsedBytes": 89256912,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.249,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.1940000000268,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8260000000000005,
"layouts": 9,
"layoutDurationMs": 2.6620000000000004,
"taskDurationMs": 407.32599999999996,
"heapDeltaBytes": 22022732,
"heapUsedBytes": 89395236,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 11.472000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1979.9750000000245,
"styleRecalcs": 87,
"styleRecalcDurationMs": 17.639000000000003,
"layouts": 9,
"layoutDurationMs": 2.8810000000000002,
"taskDurationMs": 1088.908,
"heapDeltaBytes": 15677332,
"heapUsedBytes": 92508320,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 116.806,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1972.6200000000063,
"styleRecalcs": 88,
"styleRecalcDurationMs": 17.950999999999997,
"layouts": 9,
"layoutDurationMs": 2.8539999999999996,
"taskDurationMs": 936.0949999999999,
"heapDeltaBytes": 11716540,
"heapUsedBytes": 78534648,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 119.203,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66525423728813,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1451.5239999999494,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.910999999999998,
"layouts": 5,
"layoutDurationMs": 17.011999999999997,
"taskDurationMs": 1111.693,
"heapDeltaBytes": 7291556,
"heapUsedBytes": 105356976,
"domNodes": 15953,
"jsHeapTotalBytes": 19013632,
"scriptDurationMs": 31.136999999999997,
"eventListeners": 3244,
"totalBlockingTimeMs": 164,
"frameDurationMs": 19.81756756756757,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10639.828999999963,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.936,
"layouts": 7,
"layoutDurationMs": 1.9880000000000002,
"taskDurationMs": 6206.419000000001,
"heapDeltaBytes": 13554732,
"heapUsedBytes": 92702992,
"domNodes": -258,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2790.079,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.718553459119498,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10859.114999999974,
"styleRecalcs": 251,
"styleRecalcDurationMs": 20.747,
"layouts": 8,
"layoutDurationMs": 2.404,
"taskDurationMs": 6367.787000000001,
"heapDeltaBytes": -4249764,
"heapUsedBytes": 93621480,
"domNodes": -258,
"jsHeapTotalBytes": 5599232,
"scriptDurationMs": 2900.3929999999996,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605222734255,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16712.327000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15715.366,
"heapDeltaBytes": 2609800,
"heapUsedBytes": 287299928,
"domNodes": -3330,
"jsHeapTotalBytes": 20959232,
"scriptDurationMs": 308.516,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.771084337349397,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 23333.76199999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22838.677,
"heapDeltaBytes": -7634580,
"heapUsedBytes": 264643844,
"domNodes": -3330,
"jsHeapTotalBytes": 13357056,
"scriptDurationMs": 342.155,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.158864027538726,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 28625.02900000004,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.621,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28203.554999999997,
"heapDeltaBytes": -21871328,
"heapUsedBytes": 279062704,
"domNodes": -3330,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 887.467,
"eventListeners": -651,
"totalBlockingTimeMs": 105,
"frameDurationMs": 52.05854545454546,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 27962.867000000075,
"styleRecalcs": 180,
"styleRecalcDurationMs": 17.112000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27546.966999999997,
"heapDeltaBytes": -31194988,
"heapUsedBytes": 264259992,
"domNodes": -3330,
"jsHeapTotalBytes": 8638464,
"scriptDurationMs": 912.2090000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 65,
"frameDurationMs": 51.98048327137546,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8397.20699999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.431,
"layouts": 20,
"layoutDurationMs": 24.09,
"taskDurationMs": 8250.719000000001,
"heapDeltaBytes": -3164436,
"heapUsedBytes": 278922528,
"domNodes": -3338,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 132.21500000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.31546961325966,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8350.330999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.45099999999998,
"layouts": 20,
"layoutDurationMs": 24.318000000000005,
"taskDurationMs": 8236.180999999999,
"heapDeltaBytes": -29138524,
"heapUsedBytes": 271304080,
"domNodes": -3330,
"jsHeapTotalBytes": 19910656,
"scriptDurationMs": 143.294,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.53579545454545,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8261.573999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7818.334999999999,
"heapDeltaBytes": 3951692,
"heapUsedBytes": 268597568,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 126.03299999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.744599303135892,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11853.357999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11503.737000000001,
"heapDeltaBytes": 11178268,
"heapUsedBytes": 262031992,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.61599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.471326164874554,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 154.500999999982,
"styleRecalcs": 12,
"styleRecalcDurationMs": 12.971,
"layouts": 10,
"layoutDurationMs": 4.308,
"taskDurationMs": 114.35000000000001,
"heapDeltaBytes": -15362112,
"heapUsedBytes": 67707860,
"domNodes": 120,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 9.447000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 111.8539999999939,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.183000000000002,
"layouts": 7,
"layoutDurationMs": 3.154,
"taskDurationMs": 86.27900000000001,
"heapDeltaBytes": -15809548,
"heapUsedBytes": 67440840,
"domNodes": 116,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 4.392,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.44999999999997,
"p95FrameDurationMs": 33.20000000000027
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 550.2199999999675,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.359,
"layouts": 76,
"layoutDurationMs": 16.226,
"taskDurationMs": 499.60499999999996,
"heapDeltaBytes": 12340908,
"heapUsedBytes": 83535532,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 247.43200000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 462.26400000000467,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.323,
"layouts": 76,
"layoutDurationMs": 15.549999999999999,
"taskDurationMs": 416.508,
"heapDeltaBytes": 11393788,
"heapUsedBytes": 88122100,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 199.24,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 540.7159999999749,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.333,
"layouts": 76,
"layoutDurationMs": 14.043,
"taskDurationMs": 505.224,
"heapDeltaBytes": 19544228,
"heapUsedBytes": 182908804,
"domNodes": 4,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 194.082,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 642.8859999999759,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.362,
"layouts": 76,
"layoutDurationMs": 15.437,
"taskDurationMs": 594.1260000000001,
"heapDeltaBytes": 1513432,
"heapUsedBytes": 113557284,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 253.809,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.105263157894736,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2278 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 00093126f511e96b497867e2b353b73ccb50063e
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21013 +/- ##
=============================================
Coverage ? 86.34%
=============================================
Files ? 3665
Lines ? 175103
Branches ? 46226
=============================================
Hits ? 151191
Misses ? 21896
Partials ? 2016
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport of #21004 (diff identical). Approving.
Backport of #21004 to
cloud/1.57Automatically created by backport workflow.