Repository navigation
[backport cloud/1.56] FE-3441 fix(billing): accept the server's own user id on the capabilities read - #21012
Conversation
…ties read (#21004) ## Summary Accept the server's canonical user id in `resolved_for` on the billing SDK capabilities read, so capabilities resolve with `unified_web_session` off. - Fixes FE-3441 - Found in 1.57 QA on testcloud (billing case): https://comfy-organization.slack.com/archives/C0932CGKT5K/p1791995382106729?thread_ts=1791952563.933479&cid=C0932CGKT5K ## Why With `web_session_enabled` ON, `unified_web_session` OFF and the billing SDK rail on, a personal-workspace user has no Upgrade plan button in Settings -> Plan & Credits, and Plans & pricing -> Monthly -> "Change to Pro" does nothing. `GET /api/billing/capabilities` returns 200 with `can_subscribe_self_serve: true`, but the app logs `billing.capability_read.failed` on every load. With `unified_web_session` ON it works. ## Root cause On the OFF path the SDK is built on the unified session client (`billingSdkStore.sessionPorts()`), and `sessionBillingScopeSource` sets `scope.userId` to the Firebase uid. On the ON path `createWebSessionBillingSession` uses the session's Comfy user id. `projectCapabilities` in `packages/account-core/src/core/billing/capabilities.ts` required both `resolved_for.user_id === scope.userId` and the workspace to match. The server puts its canonical user id in `resolved_for.user_id`, which is not always the Firebase uid. When they differ, every read becomes `REQUEST_FAILED` on a 200, `readOnRail` throws, `useBillingCapabilities` marks the read unavailable, and `canSubscribeSelfServe` stays false. Evidence from the reporter's account (staging PostHog, last 24h): | distinct id | event | count | | - | - | - | | Firebase uid (`EJfiug…`) | `billing.capability_read.failed` | 38 | | canonical id (`C3Niv…`, the `resolved_for.user_id` the server returned) | `billing.capability_read.succeeded` | 357 | The workspace ids match (`resolved_for.workspace_id` equals the minted session's workspace). ## How - Check only `resolved_for.workspace_id` in `projectCapabilities`. The legacy composable already checks only the workspace (its test "accepts a canonical server user ID distinct from the Firebase UID"). The user half is the credential's to prove: the server resolves for the caller the request was sent as, and ingest checks both halves upstream. - `capabilities.test.ts`: the "refuses another member's answer" case is replaced by one that accepts the server's own user id for the caller. - `webSessionFlagOff.test.ts`: new test on the real SDK, unified session client and flags (`unified_cloud_auth` + SDK rails on, `unified_web_session` absent / false), where the server answers with a canonical user id. Fails before the fix with `status: 'error'`, passes after. Trade-off for reviewers: this drops the user-id half of a defence-in-depth check. Keeping it would need the canonical user id on the OFF path, and nothing there carries it today (token exchange and `/workspaces/current` don't return it). Backport to `cloud/1.56` (prod path, see Impact) and `cloud/1.57` (found in 1.57 QA; testcloud serves `cloud/1.57`). Cloud only: the capabilities read runs only on the cloud billing rail. ## Impact `cloud/1.56` has the same check and the same rail, and prod `billing_sdk_subscription_enabled` has been at 100% since Oct 8 while prod `web_session_enabled` is at 0%, so prod users are on this path. Prod PostHog, last 24h: 59 users had only `billing.capability_read.failed` and no `succeeded` (3,407 failed reads), consistent with users whose canonical id differs from their Firebase uid. A further 2,467 users had both; those include transient failures this PR does not change. Out of scope: when the capabilities read is unavailable for another reason (timeout, outage, no scope yet), `handleSubscribeClick` still returns silently while the CTA renders enabled. Tracked separately. ## AS IS / TO BE ### AS IS _Placeholder: testcloud, unified_web_session OFF, Plan & Credits without Upgrade plan._ ### TO BE _Placeholder: same account on this branch, Upgrade plan shown and Change to Pro opens checkout._ ## Plan position | # | Item | Ticket | PR | Status | | - | ---- | ------ | -- | ------ | | 1 | Name personal-type workspaces on session requests | FE-3438 | PR 20997 | merged | | **2** | **Accept canonical user id on SDK capabilities read** | **FE-3441** | **this PR** | **in review** | | 3 | Backport to cloud/1.56 and cloud/1.57 | FE-3441 | auto (needs-backport) | pending merge | | 4 | Re-check 1.57 billing case on testcloud (unified OFF) | FE-3441 | none | pending | ```mermaid flowchart LR A["FE-3438 PR 20997"] --> C["1.57 billing QA re-check"] B["FE-3441 this PR"] --> C style B fill:#ffd54f,stroke:#f57f17,stroke-width:3px ```
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-14T18:40:04.370Z",
"gitSha": "18543397db5099928b26654a5d8c3c1490d94eaf",
"branch": "backport-21004-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2102.969999999914,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.658000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 732.5270000000002,
"heapDeltaBytes": 936284,
"heapUsedBytes": 68413204,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.530000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.8,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2076.767000000018,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.453999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 686.7719999999999,
"heapDeltaBytes": 1243876,
"heapUsedBytes": 67532244,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.880000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 15,
"frameDurationMs": 16.666935483870972,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2526.0220000000118,
"styleRecalcs": 58,
"styleRecalcDurationMs": 26.181,
"layouts": 12,
"layoutDurationMs": 7.146000000000001,
"taskDurationMs": 1439.88,
"heapDeltaBytes": -1747272,
"heapUsedBytes": 66070796,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 290.067,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.236986301369864,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2502.9850000000806,
"styleRecalcs": 54,
"styleRecalcDurationMs": 30.950000000000003,
"layouts": 12,
"layoutDurationMs": 8.068000000000001,
"taskDurationMs": 1439.6100000000001,
"heapDeltaBytes": -2024388,
"heapUsedBytes": 66776160,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 296.525,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.00890410958905,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1902.208999999857,
"styleRecalcs": 29,
"styleRecalcDurationMs": 17.622000000000003,
"layouts": 6,
"layoutDurationMs": 2.497,
"taskDurationMs": 669.9,
"heapDeltaBytes": 4170624,
"heapUsedBytes": 72536612,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 23.25300000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.117117117117118,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1856.3230000002022,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.135000000000002,
"layouts": 6,
"layoutDurationMs": 2.3040000000000003,
"taskDurationMs": 624.836,
"heapDeltaBytes": -150824,
"heapUsedBytes": 62025340,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 21.801000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.969090909090895,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 1113.4549999999308,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.489999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 778.231,
"heapDeltaBytes": -7148348,
"heapUsedBytes": 61879964,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 270.709,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.30655737704919,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "dom-widget-clipping",
"durationMs": 1137.7719999998135,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.7090000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 794.861,
"heapDeltaBytes": -32875692,
"heapUsedBytes": 69276424,
"domNodes": -232,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 268.46500000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.446875000000006,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1723.3310000000301,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1492.9829999999997,
"heapDeltaBytes": 15322528,
"heapUsedBytes": 84814128,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 122.45200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 1081,
"frameDurationMs": 50.48823529411766,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1821.3329999998678,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1567.9990000000003,
"heapDeltaBytes": 14880692,
"heapUsedBytes": 84359700,
"domNodes": 0,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 121.37400000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 1130,
"frameDurationMs": 49.10000000000002,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 1175.8839999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 847.6420000000005,
"heapDeltaBytes": 17180696,
"heapUsedBytes": 103361428,
"domNodes": 0,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 319.66099999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 464,
"frameDurationMs": 31.52972972972974,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 1227.9110000001765,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 869.2370000000009,
"heapDeltaBytes": -12451252,
"heapUsedBytes": 78263908,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 352.74499999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 489,
"frameDurationMs": 31.19487179487176,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 21041.229000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19527.754999999997,
"heapDeltaBytes": 18681668,
"heapUsedBytes": 96686380,
"domNodes": -173,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 17275.579,
"eventListeners": -82,
"totalBlockingTimeMs": 9485,
"frameDurationMs": 61.61078717201165,
"p95FrameDurationMs": 116.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 24047.649999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22646.521999999997,
"heapDeltaBytes": 15105896,
"heapUsedBytes": 93229120,
"domNodes": -176,
"jsHeapTotalBytes": -3543040,
"scriptDurationMs": 19839.468,
"eventListeners": -78,
"totalBlockingTimeMs": 10839,
"frameDurationMs": 60.841518987341765,
"p95FrameDurationMs": 116.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 23537.771000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22143.083000000002,
"heapDeltaBytes": -662720,
"heapUsedBytes": 83990764,
"domNodes": -142,
"jsHeapTotalBytes": -4067328,
"scriptDurationMs": 19309.046,
"eventListeners": -78,
"totalBlockingTimeMs": 10706,
"frameDurationMs": 59.635606060606065,
"p95FrameDurationMs": 116.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 23889.428999999836,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22491.586,
"heapDeltaBytes": -2435708,
"heapUsedBytes": 82431212,
"domNodes": -142,
"jsHeapTotalBytes": -3543040,
"scriptDurationMs": 19635.519000000004,
"eventListeners": -78,
"totalBlockingTimeMs": 10668,
"frameDurationMs": 60.266919191919186,
"p95FrameDurationMs": 116.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2031.917999999905,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.4470000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 901.937,
"heapDeltaBytes": 14799576,
"heapUsedBytes": 92716208,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 59.22700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2098.7170000000788,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.937999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 875.3410000000001,
"heapDeltaBytes": -9610432,
"heapUsedBytes": 79164928,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 59.93100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665873015873014,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 4292.015000000106,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.093999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2947.932,
"heapDeltaBytes": -18115092,
"heapUsedBytes": 71128068,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 1625.825,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.48244897959184,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-pan",
"durationMs": 4197.32799999997,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.505,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2912.0419999999995,
"heapDeltaBytes": -16592184,
"heapUsedBytes": 71930208,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 1659.913,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.49916666666667,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 5240.940999999907,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.856999999999996,
"layouts": 60,
"layoutDurationMs": 22.197000000000003,
"taskDurationMs": 2929.6910000000003,
"heapDeltaBytes": 5618260,
"heapUsedBytes": 73990504,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 1410.746,
"eventListeners": 0,
"totalBlockingTimeMs": 20,
"frameDurationMs": 17.795932203389835,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-zoom",
"durationMs": 5138.034999999945,
"styleRecalcs": 69,
"styleRecalcDurationMs": 19.343,
"layouts": 60,
"layoutDurationMs": 20.767,
"taskDurationMs": 2851.097,
"heapDeltaBytes": 5484204,
"heapUsedBytes": 73661324,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 1354.21,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.397972972972976,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 5073.90799999996,
"styleRecalcs": 40,
"styleRecalcDurationMs": 7.699999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3580.95,
"heapDeltaBytes": 30283360,
"heapUsedBytes": 99138288,
"domNodes": 0,
"jsHeapTotalBytes": 1433600,
"scriptDurationMs": 1936.2110000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 21,
"frameDurationMs": 18.81881918819188,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 4923.0589999999665,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.302000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3473.598,
"heapDeltaBytes": 8534972,
"heapUsedBytes": 97271560,
"domNodes": 0,
"jsHeapTotalBytes": 1470464,
"scriptDurationMs": 1863.9830000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 23,
"frameDurationMs": 18.06996336996337,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "minimap-idle",
"durationMs": 2090.4890000001615,
"styleRecalcs": 3,
"styleRecalcDurationMs": 4.061999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 872.9150000000001,
"heapDeltaBytes": -8809408,
"heapUsedBytes": 80654492,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 59.158000000000015,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.934677419354852,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2080.684999999903,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.310999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 842.612,
"heapDeltaBytes": -8731936,
"heapUsedBytes": 81580148,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 50.68999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.799199999999995,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 1082.9089999999724,
"styleRecalcs": 44,
"styleRecalcDurationMs": 15.542,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 690.286,
"heapDeltaBytes": -11566852,
"heapUsedBytes": 57009608,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 213.794,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.75737704918034,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 973.7310000000434,
"styleRecalcs": 39,
"styleRecalcDurationMs": 4.253,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 654.3739999999999,
"heapDeltaBytes": -11789828,
"heapUsedBytes": 57251900,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 214.01600000000005,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.588461538461544,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "subgraph-idle",
"durationMs": 2118.906000000038,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.671999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 750.5509999999999,
"heapDeltaBytes": 1158552,
"heapUsedBytes": 70344404,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.733999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283467,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2061.030999999957,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.8439999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 673.5759999999999,
"heapDeltaBytes": 1427120,
"heapUsedBytes": 71265128,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.282,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.801626016260165,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2694.3260000000464,
"styleRecalcs": 84,
"styleRecalcDurationMs": 31.259999999999994,
"layouts": 16,
"layoutDurationMs": 8.803999999999998,
"taskDurationMs": 1500.617,
"heapDeltaBytes": -5480520,
"heapUsedBytes": 64407340,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 214.04300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.418709677419354,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2572.535000000016,
"styleRecalcs": 66,
"styleRecalcDurationMs": 32.419000000000004,
"layouts": 16,
"layoutDurationMs": 9.216000000000001,
"taskDurationMs": 1474.102,
"heapDeltaBytes": -5472736,
"heapUsedBytes": 65156428,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 205.56199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.99473684210527,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 2173.3220000000983,
"styleRecalcs": 13,
"styleRecalcDurationMs": 52.077999999999996,
"layouts": 5,
"layoutDurationMs": 32.168,
"taskDurationMs": 1732.336,
"heapDeltaBytes": -769496,
"heapUsedBytes": 95413952,
"domNodes": 14227,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 63.88000000000001,
"eventListeners": 2463,
"totalBlockingTimeMs": 259,
"frameDurationMs": 20.79238095238094,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 15585.807000000159,
"styleRecalcs": 247,
"styleRecalcDurationMs": 46.589,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10351.278,
"heapDeltaBytes": 4741664,
"heapUsedBytes": 92862368,
"domNodes": 0,
"jsHeapTotalBytes": 1015808,
"scriptDurationMs": 5283.813999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.992701525054464,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 15227.567000000136,
"styleRecalcs": 248,
"styleRecalcDurationMs": 46.829,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10019.223,
"heapDeltaBytes": 674892,
"heapUsedBytes": 88048228,
"domNodes": 0,
"jsHeapTotalBytes": 1015808,
"scriptDurationMs": 5146.563999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.00122905027933,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 30612.30099999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29958.039000000004,
"heapDeltaBytes": -44365928,
"heapUsedBytes": 172214328,
"domNodes": -3045,
"jsHeapTotalBytes": -6414336,
"scriptDurationMs": 498.62600000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 53.5236013986014,
"p95FrameDurationMs": 116.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 22012.29699999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21379.734,
"heapDeltaBytes": -11083768,
"heapUsedBytes": 186590436,
"domNodes": -3042,
"jsHeapTotalBytes": 18350080,
"scriptDurationMs": 460.21299999999997,
"eventListeners": -14905,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.52732049036777,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 38572.960000000196,
"styleRecalcs": 182,
"styleRecalcDurationMs": 30.79700000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 38349.003000000004,
"heapDeltaBytes": -34150084,
"heapUsedBytes": 164723860,
"domNodes": -3042,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 1555.188,
"eventListeners": -14905,
"totalBlockingTimeMs": 482,
"frameDurationMs": 69.58212996389891,
"p95FrameDurationMs": 133.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 37632.86600000015,
"styleRecalcs": 182,
"styleRecalcDurationMs": 27.195999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 37373.452,
"heapDeltaBytes": -45031028,
"heapUsedBytes": 189375880,
"domNodes": -3045,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 1598.5800000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 553,
"frameDurationMs": 66.45795053003533,
"p95FrameDurationMs": 133.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 11396.058999999923,
"styleRecalcs": 20,
"styleRecalcDurationMs": 167.764,
"layouts": 20,
"layoutDurationMs": 40.775000000000006,
"taskDurationMs": 11280.275000000001,
"heapDeltaBytes": 1096896,
"heapUsedBytes": 217410608,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 212.10399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 70,
"frameDurationMs": 61.19784946236559,
"p95FrameDurationMs": 133.39999999999782
},
{
"name": "vue-node-resize-workload",
"durationMs": 10931.606999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 164.984,
"layouts": 20,
"layoutDurationMs": 40.30899999999998,
"taskDurationMs": 10788.023000000001,
"heapDeltaBytes": 5654092,
"heapUsedBytes": 215489704,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 198.314,
"eventListeners": 0,
"totalBlockingTimeMs": 48,
"frameDurationMs": 60.07087912087913,
"p95FrameDurationMs": 133.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 15635.20799999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15316.79,
"heapDeltaBytes": -44636204,
"heapUsedBytes": 172312384,
"domNodes": -3045,
"jsHeapTotalBytes": -5046272,
"scriptDurationMs": 239.8730000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 56.172661870503596,
"p95FrameDurationMs": 133.29999999999563
},
{
"name": "vue-zoom-out-idle",
"durationMs": 15243.834000000106,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14979.841,
"heapDeltaBytes": -53896084,
"heapUsedBytes": 161767036,
"domNodes": -3045,
"jsHeapTotalBytes": 1216512,
"scriptDurationMs": 254.34999999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 52.89131944444446,
"p95FrameDurationMs": 116.70000000000437
},
{
"name": "workflow-execution",
"durationMs": 250.65700000004654,
"styleRecalcs": 8,
"styleRecalcDurationMs": 23.733000000000004,
"layouts": 3,
"layoutDurationMs": 2.3449999999999998,
"taskDurationMs": 203.445,
"heapDeltaBytes": 3895552,
"heapUsedBytes": 70054612,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 19.846000000000004,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.16249999999991,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 217.12999999999738,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.252000000000002,
"layouts": 2,
"layoutDurationMs": 0.9209999999999999,
"taskDurationMs": 170.456,
"heapDeltaBytes": 3863684,
"heapUsedBytes": 69680956,
"domNodes": 95,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 20.433999999999994,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.33000000000011,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1612.060000000156,
"styleRecalcs": 78,
"styleRecalcDurationMs": 174.477,
"layouts": 76,
"layoutDurationMs": 46.955999999999996,
"taskDurationMs": 1570.643,
"heapDeltaBytes": 19154644,
"heapUsedBytes": 85529532,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 689.076,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.923809523809506,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1663.4420000000318,
"styleRecalcs": 78,
"styleRecalcDurationMs": 172.87900000000002,
"layouts": 76,
"layoutDurationMs": 50.835,
"taskDurationMs": 1617.748,
"heapDeltaBytes": 19180488,
"heapUsedBytes": 84623664,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 680.222,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.612903225806452,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 2198.556999999937,
"styleRecalcs": 78,
"styleRecalcDurationMs": 449.177,
"layouts": 76,
"layoutDurationMs": 47.118,
"taskDurationMs": 2156.5109999999995,
"heapDeltaBytes": 13665416,
"heapUsedBytes": 131025348,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 763.884,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.706024096385548,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 2152.7679999999236,
"styleRecalcs": 78,
"styleRecalcDurationMs": 451.31,
"layouts": 76,
"layoutDurationMs": 45.172,
"taskDurationMs": 2115.3050000000003,
"heapDeltaBytes": -13235408,
"heapUsedBytes": 107785104,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 737.0329999999999,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.748148148148175,
"p95FrameDurationMs": 33.400000000001455
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2203 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0aa88cc345f566c906b10434e155d8a0b0cd0271
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #21012 +/- ##
=============================================
Coverage ? 85.13%
=============================================
Files ? 3532
Lines ? 169749
Branches ? 44260
=============================================
Hits ? 144522
Misses ? 23235
Partials ? 1992
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport of #21004 (diff identical). Approving.
Backport of #21004 to
cloud/1.56Automatically created by backport workflow.