Skip to content

FE-3440 fix(billing): scope the token-session billing SDK by the user its Cloud JWT names - #21005

Closed
dante01yoon wants to merge 2 commits into
mainfrom
dante01yoon/fix-billing-capability-scope
Closed

dante01yoon wants to merge 2 commits into
mainfrom
dante01yoon/fix-billing-capability-scope

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Summary

On the token session (unified_web_session off, unified_cloud_auth on) with the billing SDK rail on, an account whose Firebase uid differs from its Comfy user id never resolves billing capabilities: no Upgrade plan button, "Change to Pro" does nothing, billing.capability_read.failed on every load. The SDK now scopes the token session by the user its Cloud JWT names.

Why

GET /api/billing/capabilities answers 200 with can_subscribe_self_serve: true, but the UI never sees it. It works with unified_web_session on.

Root cause

billingSdkStore built the token-session SDK with account-core's default scope source, which takes userId from the Firebase user (state.user.uid). The billing API resolves resolved_for.user_id to the canonical Comfy user id, the sub of the Cloud JWT. Since identity mappings, a new Firebase subject (second provider, SSO) can link to an existing Comfy user, so the two ids differ. The capabilities reader treats a resolved_for that does not match its scope as a contract violation (REQUEST_FAILED), so capabilities stay null. The web session already scopes by the server's user id, which is why it works there.

Evidence for the QA account (PostHog staging): token-session sessions identify as Firebase uid EJfiug… and fail; resolved_for.user_id and the web-session user are C3Niv… and succeed.

How

On the token session, the store hands the SDK a scope source that reads the user from the minted Cloud JWT's sub (the same claim reader local web sign-in uses), with the workspace and role from the credential. Nothing is derived: sub is the identity the server resolved the token to and echoes in resolved_for. A BE follow-up could return the user id on POST /api/auth/token so the claim read is not needed.

Impact

Present on main, cloud/1.57 and cloud/1.56 (prod). Prod is on the token session for everyone, so linked-identity users on the SDK rail are affected; Sentry prod shows the REQUEST_FAILED + HTTP 200 capability signature (2 users, 188 events in 14 days), and exposure grows with SSO.

Verification

  • billingSdkStore.tokenSession.test.ts runs the real billing SDK through the store on the token session with a Firebase uid that differs from the token's sub; it fails on main (status: 'error') and passes with the fix.
  • vitest run src/platform/workspace/billing/sdk/ useBillingCapabilities useSubscriptionOperationView TopUpCreditsDialogContentWorkspace src/platform/auth/localWeb: 512 passed.
  • No E2E: the failure needs a backend identity mapping where the Firebase uid differs from the Comfy user id, which the mocked E2E backend cannot produce; the unit test runs the real SDK reader against that response.

AS IS / TO BE

AS IS TO BE
screenshot pending screenshot pending

… not the Firebase uid

The billing SDK on the token session scopes itself by the Firebase uid,
but /billing/capabilities answers resolved_for.user_id with the Comfy
user id the Cloud JWT names. For a linked identity the two differ and the
capabilities reader drops the 200 as out of scope.

FE-3440
…ud JWT names

On the token session the billing SDK took its scope user from the Firebase
uid. /billing/capabilities answers resolved_for.user_id with the Comfy
user id the Cloud JWT was issued for, and since identity mappings a
Firebase subject can link to an existing Comfy user, so the two differ for
linked accounts. The capabilities reader then rejected every 200 as out of
scope: no Upgrade plan button, Change to Pro inert, capability_read.failed
on every load. The web session already scopes by the server's user id.

The token-session scope now reads the user from the minted Cloud JWT's sub,
the identity the server resolves the request to.

FE-3440
@dante01yoon dante01yoon added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.57 Backport PRs for core 1.57 cloud/1.57 Backport PRs for cloud 1.57 labels Oct 14, 2026
@dante01yoon
dante01yoon requested a review from a team October 14, 2026 16:55
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: 9.44 MB gzip 🔴 +779 B

Details

Summary

  • Raw size: 40.6 MB baseline 40.6 MB — 🔴 +1.27 kB
  • Gzip: 9.44 MB baseline 9.44 MB — 🔴 +779 B
  • Brotli: 7.31 MB baseline 7.31 MB — 🔴 +434 B
  • Bundles: 557 current • 556 baseline • 89 added / 88 removed

Category Glance
Utilities & Hooks 🔴 +547 B (999 kB) · Other 🔴 +465 B (19.4 MB) · Graph Workspace 🔴 +95 B (2.45 MB) · User & Accounts 🔴 +42 B (275 kB) · App Entry Points 🔴 +40 B (5.02 kB) · Data & Services 🔴 +39 B (2.17 MB) · + 5 more

App Entry Points — 5.02 kB (baseline 4.98 kB) • 🔴 +40 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-COKUqovh.js (new) — 5.02 kB 🔴 +5.02 kB 🔴 +2.58 kB 🔴 +2.21 kB
assets/index-DfqC3GnR.js (removed) 4.98 kB — 🟢 -4.98 kB 🟢 -2.55 kB 🟢 -2.17 kB

Status: 1 added / 1 removed

Graph Workspace — 2.45 MB (baseline 2.45 MB) • 🔴 +95 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-CERi3Fk4.js (new) — 2.44 MB 🔴 +2.44 MB 🔴 +536 kB 🔴 +389 kB
assets/GraphView-DW7sQh2J.js (removed) 2.44 MB — 🟢 -2.44 MB 🟢 -535 kB 🟢 -389 kB
assets/WidgetCompositor-CRMJnWQW.js (new) — 8.4 kB 🔴 +8.4 kB 🔴 +2.79 kB 🔴 +2.48 kB
assets/WidgetCompositor-FX49Q7Ay.js (removed) 8.4 kB — 🟢 -8.4 kB 🟢 -2.79 kB 🟢 -2.5 kB

Status: 2 added / 2 removed / 1 unchanged

Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudLoginView-B2cECniQ.js (new) — 15.9 kB 🔴 +15.9 kB 🔴 +4.21 kB 🔴 +3.7 kB
assets/CloudLoginView-CvO-rkq7.js (removed) 15.9 kB — 🟢 -15.9 kB 🟢 -4.21 kB 🟢 -3.7 kB
assets/useCloudAuthPage-CJpx6vcN.js (removed) 15.4 kB — 🟢 -15.4 kB 🟢 -5.28 kB 🟢 -4.54 kB
assets/useCloudAuthPage-DhtElZs9.js (new) — 15.4 kB 🔴 +15.4 kB 🔴 +5.28 kB 🔴 +4.54 kB
assets/CloudSignupView-BWNGGojM.js (new) — 7.54 kB 🔴 +7.54 kB 🔴 +2.45 kB 🔴 +2.16 kB
assets/CloudSignupView-CgnMxF5V.js (removed) 7.54 kB — 🟢 -7.54 kB 🟢 -2.45 kB 🟢 -2.16 kB
assets/CloudSubscriptionRedirectView-BUUoQW5b.js (new) — 5.81 kB 🔴 +5.81 kB 🔴 +1.96 kB 🔴 +1.71 kB
assets/CloudSubscriptionRedirectView-C2PB6sD3.js (removed) 5.81 kB — 🟢 -5.81 kB 🟢 -1.96 kB 🟢 -1.7 kB
assets/CloudForgotPasswordView-BkJjbrUr.js (new) — 5.37 kB 🔴 +5.37 kB 🔴 +1.76 kB 🔴 +1.54 kB
assets/CloudForgotPasswordView-C-3td_-4.js (removed) 5.37 kB — 🟢 -5.37 kB 🟢 -1.76 kB 🟢 -1.54 kB
assets/CloudAuthTimeoutView--JnaJS3V.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.55 kB 🟢 -1.34 kB
assets/CloudAuthTimeoutView-Lf0pU1xu.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.55 kB 🔴 +1.34 kB

Status: 6 added / 6 removed / 12 unchanged

Panels & Settings — 670 kB (baseline 670 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CreditsPanel-BjXz8k1a.js (removed) 41.6 kB — 🟢 -41.6 kB 🟢 -9.77 kB 🟢 -8.58 kB
assets/CreditsPanel-CVSNdNvS.js (new) — 41.6 kB 🔴 +41.6 kB 🔴 +9.77 kB 🔴 +8.59 kB
assets/UserPanel-CdYNYKuc.js (removed) 8.25 kB — 🟢 -8.25 kB 🟢 -2.48 kB 🟢 -2.13 kB
assets/UserPanel-CJuuXyXh.js (new) — 8.25 kB 🔴 +8.25 kB 🔴 +2.48 kB 🔴 +2.13 kB
assets/CreditsPanel-CqdgWsCJ.js (removed) 116 B — 🟢 -116 B 🟢 -95 B 🟢 -92 B
assets/CreditsPanel-FXvKLBZL.js (new) — 116 B 🔴 +116 B 🔴 +95 B 🔴 +90 B

Status: 3 added / 3 removed / 26 unchanged

User & Accounts — 275 kB (baseline 275 kB) • 🔴 +42 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useAuthDialogs-DzZ7bfW1.js (new) — 6.29 kB 🔴 +6.29 kB 🔴 +2.54 kB 🔴 +2.23 kB
assets/useAuthDialogs-DL5M6tSP.js (removed) 6.25 kB — 🟢 -6.25 kB 🟢 -2.52 kB 🟢 -2.21 kB
assets/InviteWrongAccountDialogContent-BMmpvNwJ.js (new) — 3.63 kB 🔴 +3.63 kB 🔴 +1.38 kB 🔴 +1.18 kB
assets/InviteWrongAccountDialogContent-CCDCXpm8.js (removed) 3.63 kB — 🟢 -3.63 kB 🟢 -1.38 kB 🟢 -1.18 kB
assets/UpdatePasswordContent-CeB-jQ-V.js (new) — 2.06 kB 🔴 +2.06 kB 🔴 +945 B 🔴 +816 B
assets/UpdatePasswordContent-EdUa29I-.js (removed) 2.06 kB — 🟢 -2.06 kB 🟢 -944 B 🟢 -817 B

Status: 3 added / 3 removed / 14 unchanged

Editors & Dialogs — 340 kB (baseline 340 kB) • 🔴 +39 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useComfyHubPublishDialog-BAgbFmeN.js (removed) 91.7 kB — 🟢 -91.7 kB 🟢 -19.6 kB 🟢 -16.8 kB
assets/useComfyHubPublishDialog-obfkcEkO.js (new) — 91.7 kB 🔴 +91.7 kB 🔴 +19.6 kB 🔴 +16.7 kB
assets/useShareDialog-9H1DS3ym.js (removed) 23.1 kB — 🟢 -23.1 kB 🟢 -5.49 kB 🟢 -4.89 kB
assets/useShareDialog-XdXGHcuW.js (new) — 23.1 kB 🔴 +23.1 kB 🔴 +5.49 kB 🔴 +4.88 kB
assets/layerEditorDialog-CkxWFgFD.js (new) — 4.12 kB 🔴 +4.12 kB 🔴 +2.08 kB 🔴 +1.8 kB
assets/layerEditorDialog-ikox7om4.js (removed) 4.08 kB — 🟢 -4.08 kB 🟢 -2.05 kB 🟢 -1.8 kB
assets/useLayerEditor-CoQGC9FR.js (removed) 1.2 kB — 🟢 -1.2 kB 🟢 -564 B 🟢 -498 B
assets/useLayerEditor-UdVjhe6t.js (new) — 1.2 kB 🔴 +1.2 kB 🔴 +565 B 🔴 +508 B
assets/useSubscriptionDialog-B1M9jOHI.js (new) — 112 B 🔴 +112 B 🔴 +106 B 🔴 +106 B
assets/useSubscriptionDialog-DDnZ2h9L.js (removed) 112 B — 🟢 -112 B 🟢 -106 B 🟢 -105 B

Status: 5 added / 5 removed / 7 unchanged

UI Components — 212 kB (baseline 212 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useMoreOptionsMenu-DvPubcXA.js (new) — 66.2 kB 🔴 +66.2 kB 🔴 +16.6 kB 🔴 +14.4 kB
assets/useMoreOptionsMenu-DZV7Q7b7.js (removed) 66.2 kB — 🟢 -66.2 kB 🟢 -16.6 kB 🟢 -14.4 kB
assets/InviteMembersForm-Ck4yON2I.js (removed) 10.6 kB — 🟢 -10.6 kB 🟢 -3.18 kB 🟢 -2.84 kB
assets/InviteMembersForm-D2bPqk-i.js (new) — 10.6 kB 🔴 +10.6 kB 🔴 +3.18 kB 🔴 +2.84 kB
assets/SubscribeButton-Don-8Z6S.js (new) — 2.19 kB 🔴 +2.19 kB 🔴 +975 B 🔴 +849 B
assets/SubscribeButton-Rp51L4bx.js (removed) 2.19 kB — 🟢 -2.19 kB 🟢 -974 B 🟢 -850 B

Status: 3 added / 3 removed / 21 unchanged

Data & Services — 2.17 MB (baseline 2.17 MB) • 🔴 +39 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/load3dService-DA8Z80bn.js (new) — 97.1 kB 🔴 +97.1 kB 🔴 +23.1 kB 🔴 +19.8 kB
assets/load3dService-DmJ3RgbS.js (removed) 97.1 kB — 🟢 -97.1 kB 🟢 -23.1 kB 🟢 -19.8 kB
assets/workflowShareService-CCMvY6G3.js (new) — 28 kB 🔴 +28 kB 🔴 +7.54 kB 🔴 +6.68 kB
assets/workflowShareService-DKLwxDs3.js (removed) 28 kB — 🟢 -28 kB 🟢 -7.54 kB 🟢 -6.69 kB

Status: 2 added / 2 removed / 22 unchanged

Utilities & Hooks — 999 kB (baseline 999 kB) • 🔴 +547 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useBillingContext-t51fOAPL.js (new) — 396 kB 🔴 +396 kB 🔴 +97 kB 🔴 +76.1 kB
assets/useBillingContext-BOm_FPAy.js (removed) 395 kB — 🟢 -395 kB 🟢 -96.9 kB 🟢 -76.1 kB
assets/useLayerEditorSession-CfeSghzT.js (new) — 159 kB 🔴 +159 kB 🔴 +41 kB 🔴 +34.5 kB
assets/useLayerEditorSession-CmSCNzgC.js (removed) 159 kB — 🟢 -159 kB 🟢 -41 kB 🟢 -34.4 kB
assets/useConflictDetection-BjO8RAHb.js (removed) 83 kB — 🟢 -83 kB 🟢 -21.1 kB 🟢 -18.3 kB
assets/useConflictDetection-Ca9T4qSS.js (new) — 83 kB 🔴 +83 kB 🔴 +21.1 kB 🔴 +18.3 kB
assets/outputAssetUtil-CpmvK2bq.js (new) — 67.9 kB 🔴 +67.9 kB 🔴 +16.2 kB 🔴 +14 kB
assets/outputAssetUtil-CUHdwril.js (removed) 67.9 kB — 🟢 -67.9 kB 🟢 -16.2 kB 🟢 -14 kB
assets/useLoad3d--WSiyZ2y.js (new) — 26.9 kB 🔴 +26.9 kB 🔴 +6.1 kB 🔴 +5.4 kB
assets/useLoad3d-DwhR-8Fr.js (removed) 26.9 kB — 🟢 -26.9 kB 🟢 -6.1 kB 🟢 -5.4 kB
assets/useLoad3dViewer-CHU_Id-X.js (new) — 21.9 kB 🔴 +21.9 kB 🔴 +5.24 kB 🔴 +4.58 kB
assets/useLoad3dViewer-xiaobX1W.js (removed) 21.9 kB — 🟢 -21.9 kB 🟢 -5.24 kB 🟢 -4.58 kB
assets/useDowngradeToPersonal-DdYYk9Wn.js (removed) 13 kB — 🟢 -13 kB 🟢 -3.02 kB 🟢 -2.6 kB
assets/useDowngradeToPersonal-DgW8SmpE.js (new) — 13 kB 🔴 +13 kB 🔴 +3.02 kB 🔴 +2.6 kB
assets/usePricingTableUrlLoader-B1HkFmOt.js (new) — 4.86 kB 🔴 +4.86 kB 🔴 +1.67 kB 🔴 +1.43 kB
assets/usePricingTableUrlLoader-Bd9AZ-qO.js (removed) 4.86 kB — 🟢 -4.86 kB 🟢 -1.67 kB 🟢 -1.43 kB
assets/useSocialSignIn-BWI2uaYJ.js (new) — 3.13 kB 🔴 +3.13 kB 🔴 +1.36 kB 🔴 +1.16 kB
assets/useSocialSignIn-CPuexK-1.js (removed) 3.13 kB — 🟢 -3.13 kB 🟢 -1.35 kB 🟢 -1.16 kB
assets/useScheduledPlanChange-GOaUoPES.js (new) — 2.4 kB 🔴 +2.4 kB 🔴 +959 B 🔴 +835 B
assets/useScheduledPlanChange-nlf7HXBd.js (removed) 2.4 kB — 🟢 -2.4 kB 🟢 -959 B 🟢 -839 B
assets/useLoad3d-r7Ej68NK.js (removed) 364 B — 🟢 -364 B 🟢 -180 B 🟢 -160 B
assets/useLoad3d-zNTD2Ugq.js (new) — 364 B 🔴 +364 B 🔴 +179 B 🔴 +158 B
assets/useBillingDialogs-DB1l4CvK.js (new) — 104 B 🔴 +104 B 🔴 +94 B 🔴 +88 B
assets/useBillingDialogs-h5ET4PB0.js (removed) 104 B — 🟢 -104 B 🟢 -94 B 🟢 -93 B
assets/useLoad3dViewer-DEMxAXhC.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +85 B
assets/useLoad3dViewer-yy2VJ9IF.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -84 B

Status: 13 added / 13 removed / 50 unchanged

Vendor & Third-Party — 13.9 MB (baseline 13.9 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 17 unchanged

Other — 19.4 MB (baseline 19.4 MB) • 🔴 +465 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/app-92R0kfHi.js (removed) 234 kB — 🟢 -234 kB 🟢 -61.9 kB 🟢 -51.9 kB
assets/app-CcTDED6s.js (new) — 234 kB 🔴 +234 kB 🔴 +61.9 kB 🔴 +51.9 kB
assets/SubscriptionTransitionPreviewWorkspace-CpltqiPH.js (new) — 151 kB 🔴 +151 kB 🔴 +31.7 kB 🔴 +26 kB
assets/SubscriptionTransitionPreviewWorkspace-rWcZphYK.js (removed) 151 kB — 🟢 -151 kB 🟢 -31.7 kB 🟢 -25.9 kB
assets/WorkspaceSettingsPanelContent-BqK1sgfK.js (new) — 132 kB 🔴 +132 kB 🔴 +26.3 kB 🔴 +21.8 kB
assets/WorkspaceSettingsPanelContent-xfrqXgDz.js (removed) 132 kB — 🟢 -132 kB 🟢 -26.3 kB 🟢 -21.9 kB
assets/core-De3euIbQ.js (new) — 126 kB 🔴 +126 kB 🔴 +33.6 kB 🔴 +28.3 kB
assets/core-CXSnNp1A.js (removed) 125 kB — 🟢 -125 kB 🟢 -33.6 kB 🟢 -28.3 kB
assets/WidgetSelect-BJScrCoZ.js (removed) 89.8 kB — 🟢 -89.8 kB 🟢 -20.2 kB 🟢 -17.3 kB
assets/WidgetSelect-BTHLVvLl.js (new) — 89.8 kB 🔴 +89.8 kB 🔴 +20.2 kB 🔴 +17.3 kB
assets/Load3D-DamcUL95.js (new) — 82.9 kB 🔴 +82.9 kB 🔴 +13.4 kB 🔴 +11.3 kB
assets/Load3D-DoMbp6qd.js (removed) 82.9 kB — 🟢 -82.9 kB 🟢 -13.4 kB 🟢 -11.3 kB
assets/WidgetVideoEdit-D6xkW8LR.js (new) — 74.5 kB 🔴 +74.5 kB 🔴 +17.8 kB 🔴 +15.6 kB
assets/WidgetVideoEdit-Rsm_6ngA.js (removed) 74.5 kB — 🟢 -74.5 kB 🟢 -17.8 kB 🟢 -15.5 kB
assets/main-CcLzWrja.js (new) — 56.5 kB 🔴 +56.5 kB 🔴 +17.3 kB 🔴 +14.7 kB
assets/main-b-ZhgEua.js (removed) 56.5 kB — 🟢 -56.5 kB 🟢 -17.3 kB 🟢 -14.7 kB
assets/SubscriptionRequiredDialogContentUnified-Bnmq8LUN.js (new) — 53.3 kB 🔴 +53.3 kB 🔴 +11.1 kB 🔴 +9.72 kB
assets/SubscriptionRequiredDialogContentUnified-CY9hsX5F.js (removed) 53.3 kB — 🟢 -53.3 kB 🟢 -11.1 kB 🟢 -9.71 kB
assets/Preview3d-6NDj83k3.js (removed) 50.7 kB — 🟢 -50.7 kB 🟢 -8.59 kB 🟢 -7.49 kB
assets/Preview3d-RUTltjAP.js (new) — 50.7 kB 🔴 +50.7 kB 🔴 +8.59 kB 🔴 +7.49 kB
assets/LayerEditorContent-4wbscIDA.js (new) — 45.2 kB 🔴 +45.2 kB 🔴 +10.5 kB 🔴 +9.26 kB
assets/LayerEditorContent-DWUC2xyM.js (removed) 45.2 kB — 🟢 -45.2 kB 🟢 -10.5 kB 🟢 -9.25 kB
assets/WidgetBoundingBoxes-B1QoTBAX.js (new) — 35.9 kB 🔴 +35.9 kB 🔴 +9.71 kB 🔴 +8.58 kB
assets/WidgetBoundingBoxes-C0bcQ_13.js (removed) 35.9 kB — 🟢 -35.9 kB 🟢 -9.71 kB 🟢 -8.59 kB
assets/WidgetPainter-C-qwbdCF.js (new) — 32.3 kB 🔴 +32.3 kB 🔴 +7.94 kB 🔴 +7.02 kB
assets/WidgetPainter-D6wmoIKw.js (removed) 32.3 kB — 🟢 -32.3 kB 🟢 -7.94 kB 🟢 -7.04 kB
assets/Load3dViewerContent-DGnjzr5J.js (new) — 30.6 kB 🔴 +30.6 kB 🔴 +6.15 kB 🔴 +5.32 kB
assets/Load3dViewerContent-ERYbuiWb.js (removed) 30.6 kB — 🟢 -30.6 kB 🟢 -6.15 kB 🟢 -5.31 kB
assets/CameraAngle-BW0EDkng.js (new) — 28.2 kB 🔴 +28.2 kB 🔴 +8.12 kB 🔴 +7.2 kB
assets/CameraAngle-Di1uTanZ.js (removed) 28.2 kB — 🟢 -28.2 kB 🟢 -8.13 kB 🟢 -7.19 kB
assets/SubscriptionRequiredDialogContent-DqZkOKgX.js (new) — 27.2 kB 🔴 +27.2 kB 🔴 +6.28 kB 🔴 +5.53 kB
assets/SubscriptionRequiredDialogContent-R6lc8riW.js (removed) 27.2 kB — 🟢 -27.2 kB 🟢 -6.28 kB 🟢 -5.53 kB
assets/CancellationFlowDialogContent-DllBkGzu.js (new) — 27.1 kB 🔴 +27.1 kB 🔴 +6.47 kB 🔴 +5.7 kB
assets/CancellationFlowDialogContent-HUui1PU1.js (removed) 27.1 kB — 🟢 -27.1 kB 🟢 -6.47 kB 🟢 -5.73 kB
assets/SubscriptionRequiredDialogContentWorkspace-CUZk4Lpy.js (new) — 26.7 kB 🔴 +26.7 kB 🔴 +6.05 kB 🔴 +5.34 kB
assets/SubscriptionRequiredDialogContentWorkspace-DjaCQp0l.js (removed) 26.7 kB — 🟢 -26.7 kB 🟢 -6.05 kB 🟢 -5.34 kB
assets/load3d-BsQBrcED.js (removed) 23.3 kB — 🟢 -23.3 kB 🟢 -5.8 kB 🟢 -5.03 kB
assets/load3d-DgbgipiU.js (new) — 23.3 kB 🔴 +23.3 kB 🔴 +5.8 kB 🔴 +5.03 kB
assets/SignInContent-6SZVM_eM.js (new) — 22.8 kB 🔴 +22.8 kB 🔴 +5.77 kB 🔴 +5.06 kB
assets/SignInContent-D5G0ORxT.js (removed) 22.8 kB — 🟢 -22.8 kB 🟢 -5.77 kB 🟢 -5.05 kB
assets/CurrentUserPopoverWorkspace-B4TKuPqN.js (new) — 19.1 kB 🔴 +19.1 kB 🔴 +4.46 kB 🔴 +3.94 kB
assets/CurrentUserPopoverWorkspace-Be0Ur-e-.js (removed) 19.1 kB — 🟢 -19.1 kB 🟢 -4.46 kB 🟢 -3.96 kB
assets/CancelSubscriptionDialogContent-BTpM-2Cp.js (removed) 17.7 kB — 🟢 -17.7 kB 🟢 -4.68 kB 🟢 -4.16 kB
assets/CancelSubscriptionDialogContent-RawKIFCG.js (new) — 17.7 kB 🔴 +17.7 kB 🔴 +4.68 kB 🔴 +4.16 kB
assets/WidgetRecordAudio-BOig9pHX.js (new) — 16.5 kB 🔴 +16.5 kB 🔴 +4.58 kB 🔴 +4.09 kB
assets/WidgetRecordAudio-BTg6jT19.js (removed) 16.5 kB — 🟢 -16.5 kB 🟢 -4.58 kB 🟢 -4.09 kB
assets/localWebSession-CsXh8rXi.js (removed) 13.2 kB — 🟢 -13.2 kB 🟢 -4.62 kB 🟢 -4.03 kB
assets/localWebSession-BcVbkdBW.js (new) — 12.3 kB 🔴 +12.3 kB 🔴 +4.31 kB 🔴 +3.75 kB
assets/onboardingCloudRoutes-BfvftBHs.js (new) — 10.6 kB 🔴 +10.6 kB 🔴 +3.44 kB 🔴 +2.96 kB
assets/onboardingCloudRoutes-WG1x2hlF.js (removed) 10.5 kB — 🟢 -10.5 kB 🟢 -3.41 kB 🟢 -2.94 kB
assets/nodeTemplates-BiEcNfBC.js (new) — 9.6 kB 🔴 +9.6 kB 🔴 +3.19 kB 🔴 +2.8 kB
assets/nodeTemplates-nLg9nV_e.js (removed) 9.6 kB — 🟢 -9.6 kB 🟢 -3.19 kB 🟢 -2.8 kB
assets/InviteMemberDialogContent-CbUoRnt9.js (removed) 9.56 kB — 🟢 -9.56 kB 🟢 -2.82 kB 🟢 -2.51 kB
assets/InviteMemberDialogContent-D8au9Kv9.js (new) — 9.56 kB 🔴 +9.56 kB 🔴 +2.82 kB 🔴 +2.51 kB
assets/WidgetImageCompare-CidHgjx1.js (removed) 9.05 kB — 🟢 -9.05 kB 🟢 -2.7 kB 🟢 -2.39 kB
assets/WidgetImageCompare-D9RGlnDM.js (new) — 9.05 kB 🔴 +9.05 kB 🔴 +2.7 kB 🔴 +2.39 kB
assets/LayoutDefault-BZ6eQAca.js (removed) 8.71 kB — 🟢 -8.71 kB 🟢 -2.56 kB 🟢 -2.25 kB
assets/LayoutDefault-Sht9Xmj6.js (new) — 8.71 kB 🔴 +8.71 kB 🔴 +2.56 kB 🔴 +2.25 kB
assets/WorkspaceSwitcherPopover-0O646DNY.js (new) — 8.57 kB 🔴 +8.57 kB 🔴 +2.5 kB 🔴 +2.22 kB
assets/WorkspaceSwitcherPopover-C8nsPbCO.js (removed) 8.57 kB — 🟢 -8.57 kB 🟢 -2.5 kB 🟢 -2.23 kB
assets/CloudRunButtonWrapper-Bi3pri57.js (removed) 8.05 kB — 🟢 -8.05 kB 🟢 -2.41 kB 🟢 -2.11 kB
assets/CloudRunButtonWrapper-DnC3Bv1S.js (new) — 8.05 kB 🔴 +8.05 kB 🔴 +2.41 kB 🔴 +2.12 kB
assets/load3dPreviewExtensions-CjaJvzCv.js (removed) 6.16 kB — 🟢 -6.16 kB 🟢 -1.88 kB 🟢 -1.67 kB
assets/load3dPreviewExtensions-Dz0Fsi34.js (new) — 6.16 kB 🔴 +6.16 kB 🔴 +1.88 kB 🔴 +1.66 kB
assets/WidgetTextarea-DK_ysu-z.js (new) — 4.84 kB 🔴 +4.84 kB 🔴 +1.87 kB 🔴 +1.63 kB
assets/WidgetTextarea-DoIJxDZA.js (removed) 4.84 kB — 🟢 -4.84 kB 🟢 -1.87 kB 🟢 -1.63 kB
assets/cameraAngle-BMN6UpTL.js (new) — 4.71 kB 🔴 +4.71 kB 🔴 +2.37 kB 🔴 +2.03 kB
assets/cameraAngle-C5-3UP8X.js (removed) 4.67 kB — 🟢 -4.67 kB 🟢 -2.35 kB 🟢 -2.03 kB
assets/saveMesh-BIBBPtFa.js (removed) 4.21 kB — 🟢 -4.21 kB 🟢 -1.4 kB 🟢 -1.24 kB
assets/saveMesh-BpFAjkq2.js (new) — 4.21 kB 🔴 +4.21 kB 🔴 +1.4 kB 🔴 +1.27 kB
assets/RemoveMemberDialogContent-0dh2HYR2.js (new) — 3.71 kB 🔴 +3.71 kB 🔴 +1.37 kB 🔴 +1.19 kB
assets/RemoveMemberDialogContent-BZQZ2ecl.js (removed) 3.71 kB — 🟢 -3.71 kB 🟢 -1.37 kB 🟢 -1.19 kB
assets/RevokeInviteDialogContent-BnkOCliv.js (new) — 3.71 kB 🔴 +3.71 kB 🔴 +1.39 kB 🔴 +1.21 kB
assets/RevokeInviteDialogContent-DkrV4jLJ.js (removed) 3.71 kB — 🟢 -3.71 kB 🟢 -1.39 kB 🟢 -1.21 kB
assets/InviteMemberUpsellDialogContent-BGq81W0Z.js (new) — 3.47 kB 🔴 +3.47 kB 🔴 +1.23 kB 🔴 +1.08 kB
assets/InviteMemberUpsellDialogContent-CLmfZnvs.js (removed) 3.47 kB — 🟢 -3.47 kB 🟢 -1.23 kB 🟢 -1.07 kB
assets/launchCancellationFlow-CU3_QFNR.js (removed) 3.34 kB — 🟢 -3.34 kB 🟢 -1.17 kB 🟢 -1.03 kB
assets/launchCancellationFlow-CxsLd5wo.js (new) — 3.34 kB 🔴 +3.34 kB 🔴 +1.17 kB 🔴 +1.03 kB
assets/SubscribeToRun-BSAjNmty.js (new) — 3.23 kB 🔴 +3.23 kB 🔴 +1.36 kB 🔴 +1.16 kB
assets/SubscribeToRun-DGmivKcz.js (removed) 3.23 kB — 🟢 -3.23 kB 🟢 -1.36 kB 🟢 -1.16 kB
assets/load3dAdvanced-7QPWSg6E.js (new) — 2.87 kB 🔴 +2.87 kB 🔴 +1.11 kB 🔴 +969 B
assets/load3dAdvanced-DKho5Ob8.js (removed) 2.87 kB — 🟢 -2.87 kB 🟢 -1.11 kB 🟢 -966 B
assets/LocalRunButtonWrapper-CCFWPj7C.js (new) — 2.37 kB 🔴 +2.37 kB 🔴 +1.08 kB 🔴 +946 B
assets/LocalRunButtonWrapper-CokSnSiH.js (removed) 2.37 kB — 🟢 -2.37 kB 🟢 -1.08 kB 🟢 -968 B
assets/accessTokenIdentity-DGpU39aM.js (new) — 1.17 kB 🔴 +1.17 kB 🔴 +651 B 🔴 +557 B
assets/Load3DAdvanced-DFmj0xPO.js (removed) 761 B — 🟢 -761 B 🟢 -424 B 🟢 -361 B
assets/Load3DAdvanced-UbSqFsYs.js (new) — 761 B 🔴 +761 B 🔴 +423 B 🔴 +360 B
assets/savedImageUrls-BQ90dmhf.js (removed) 739 B — 🟢 -739 B 🟢 -437 B 🟢 -380 B
assets/savedImageUrls-BuYPqNet.js (new) — 739 B 🔴 +739 B 🔴 +436 B 🔴 +395 B
assets/launchCancellationFlow-C6M6kBJY.js (new) — 176 B 🔴 +176 B 🔴 +121 B 🔴 +107 B
assets/launchCancellationFlow-PdhJb4fI.js (removed) 176 B — 🟢 -176 B 🟢 -121 B 🟢 -106 B
assets/CancelSubscriptionDialogContent-B9xPgXgp.js (removed) 173 B — 🟢 -173 B 🟢 -115 B 🟢 -90 B
assets/CancelSubscriptionDialogContent-D84U8Umd.js (new) — 173 B 🔴 +173 B 🔴 +115 B 🔴 +94 B
assets/Load3dViewerContent-B1ErqdXr.js (removed) 137 B — 🟢 -137 B 🟢 -103 B 🟢 -92 B
assets/Load3dViewerContent-cuY9NI4A.js (new) — 137 B 🔴 +137 B 🔴 +103 B 🔴 +92 B
assets/Load3DAdvanced-BpdTehMu.js (removed) 122 B — 🟢 -122 B 🟢 -97 B 🟢 -98 B
assets/Load3DAdvanced-Cvpgkju3.js (new) — 122 B 🔴 +122 B 🔴 +97 B 🔴 +87 B
assets/LayoutDefault-0tphyLsc.js (new) — 119 B 🔴 +119 B 🔴 +92 B 🔴 +83 B
assets/LayoutDefault-Cgve95nn.js (removed) 119 B — 🟢 -119 B 🟢 -92 B 🟢 -90 B
assets/Load3D-DmDynTtB.js (removed) 98 B — 🟢 -98 B 🟢 -89 B 🟢 -89 B
assets/Load3D-DUCW2BSu.js (new) — 98 B 🔴 +98 B 🔴 +89 B 🔴 +81 B

Status: 51 added / 50 removed / 298 unchanged

⚡ Performance

⏳ Performance tests in progress…

🔬 E2E Coverage

⚠️ Coverage collection failed. Check the CI workflow logs.

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/14/2026, 04:58:02 PM UTC

Links

🌾 Fallow: ❌ Failed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Fallow reports a failing verdict, but this renderer found no findings it
knows how to describe. Open the run log and the Audit new findings
step — and please extend scripts/cicd/fallow-findings.ts so the next
person does not have to.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since d3818ea6b8a93d5ff55b3a677816c8f590494530

Full docs: ADR-DEVEX-LINT-0015

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 14, 2026
@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: eabfcc3b-6456-4c53-bf5b-f04511d38281
📥 Commits

Reviewing files that changed from the base of the PR and between d3818ea and 1117dcc.

📒 Files selected for processing: 4
  • src/platform/workspace/billing/sdk/billingSdkStore.tokenSession.test.ts
  • src/platform/workspace/billing/sdk/billingSdkStore.ts
  • src/platform/workspace/billing/sdk/billingSdkTelemetryOwnership.test.ts
  • src/platform/workspace/billing/sdk/billingSdkTestUtils.ts
 _____________________________________________________________________________________________________________
< Hello, it's me. I was wondering if after all these reviews you'd like to meet...to celebrate bug-free code. >
 -------------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@datadog-official

datadog-official Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 4 Pipeline jobs failed

CI: Tests E2E | e2e-status

View in Datadog · View in GitHub Actions

CI: Tests E2E | fallow / fallow

View in Datadog · View in GitHub Actions

CI: Tests E2E | preflight

View in Datadog · View in GitHub Actions

View all 4 failed jobs.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1117dcc | Docs | View more details | Give us feedback!

@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Superseded by #21004 (FE-3441), which fixes the same capabilities read on the token session. Closing this duplicate.

This branch was previously deployed

1 inactive deployment
website-approval — 1117dcc1 Deployed Oct 14, 2026 by dante01yoon via fast-lane #2670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cloud/1.57 Backport PRs for cloud 1.57 core/1.57 Backport PRs for core 1.57 needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants