Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
311 changes: 311 additions & 0 deletions src/core/graph/widgets/dynamicGroupDiagnostics.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,311 @@
import { nodesMap } from '@comfyorg/comfy-multi-player'
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import * as Y from 'yjs'

import { LGraph, LGraphNode, LiteGraph } from '@/lib/litegraph/src/litegraph'
import { remoteConfig } from '@/platform/remoteConfig/remoteConfig'
import { reportError } from '@/platform/telemetry/reportError'
import { useLitegraphService } from '@/services/litegraphService'
import { useLinkStore } from '@/stores/linkStore'
import { applyRemoteDynamicGroupRowCount } from './dynamicGroupDiagnostics'
import { toNodeId } from '@/types/nodeId'
import { followedDoc } from '@/workbench/extensions/agent/crdt/__fixtures__/followedDoc'
import { LiveGraphApplier } from '@/workbench/extensions/agent/crdt/liveGraphApplier'

const distribution = vi.hoisted(() => ({ isCloud: false }))

vi.mock(import('@/platform/distribution/types'), () => ({
get isCloud() {
return distribution.isCloud
}
}))

vi.mock(import('@/platform/telemetry/reportError'))

function addGroup(node: LGraphNode, min = 0) {
useLitegraphService().addNodeInput(node, {
name: 'rows',
type: 'COMFY_DYNAMICGROUP_V3',
isOptional: false,
min,
max: 3,
template: { required: { strength: ['FLOAT', { default: 1 }] } }
})
}

function group(type: string, { min = 0, count = 2 } = {}) {
const graph = new LGraph()
const node = new LGraphNode('Group', type)
node.serialize_widgets = true
graph.add(node)
addGroup(node, min)
function widget(name: string) {
const found = node.widgets?.find((widget) => widget.name === name)
if (!found) throw new Error(`Missing widget ${name}`)
return found
}
widget('rows').value = count
return { node, widget }
}

function refuseInputChanges() {
vi.spyOn(useLinkStore(), 'updateEndpoints').mockReturnValue({
ok: false,
error: { code: 'unowned-topology', message: 'Rejected' }
})
}

beforeEach(() => {
remoteConfig.value = { enable_telemetry: true }
})

afterEach(() => {
distribution.isCloud = false
remoteConfig.value = {}
})

describe('DynamicGroup row refusal reports', () => {
function rowRefusal(
type: string,
operation: string,
requested: number,
actual: number
) {
return [
expect.objectContaining({ message: 'Refused a DynamicGroup row change' }),
{
errorType: 'failure_resizing_dynamic_group_rows',
surface: 'graph',
level: 'warning',
tags: { node_type: type, operation, in_subgraph: false },
context: { requested, actual }
}
]
}

type Widget = ReturnType<typeof group>['widget']

it.for([
{
name: 'an added row',
operation: 'add_row',
requested: 3,
change: (widget: Widget) => (widget('rows').value = 3)
},
{
name: 'a count reduction',
operation: 'remove_row',
requested: 0,
change: (widget: Widget) => (widget('rows').value = 0)
},
{
name: "a row's remove button",
operation: 'remove_row',
requested: 1,
change: (widget: Widget) => widget('rows.0').callback?.(undefined)
}
])(
'reports a refused change from $name with counts only',
({ name, operation, requested, change }) => {
const { widget } = group(name)
refuseInputChanges()

change(widget)

expect(widget('rows').value).toBe(2)
expect(vi.mocked(reportError).mock.calls).toEqual([
rowRefusal(name, operation, requested, 2)
])
}
)

it('does not report successful changes or a count clamped up to min', () => {
const { widget } = group('Accepted changes', { min: 1, count: 3 })
widget('rows').value = -1
widget('rows.$add').callback?.(undefined)
widget('rows.1').callback?.(undefined)

expect(widget('rows').value).toBe(1)
expect(reportError).not.toHaveBeenCalled()
})

it('reports each node type and operation once per session', () => {
const first = group('Deduped refusal')
const second = group('Deduped refusal')
const other = group('Other refusal')
refuseInputChanges()

first.widget('rows').value = 3
first.widget('rows').value = 0
first.widget('rows').value = 4
second.widget('rows').value = 3
other.widget('rows').value = 3

expect(vi.mocked(reportError).mock.calls).toEqual([
rowRefusal('Deduped refusal', 'add_row', 3, 2),
rowRefusal('Deduped refusal', 'remove_row', 0, 2),
rowRefusal('Other refusal', 'add_row', 3, 2)
])
})

const resizeRefusal = ['failure_resizing_dynamic_group_rows']
it.for([
{ isCloud: false, enableTelemetry: false, reported: [] },
{ isCloud: false, enableTelemetry: true, reported: resizeRefusal },
{ isCloud: true, enableTelemetry: false, reported: resizeRefusal }
])(
'sends with cloud=$isCloud and host telemetry=$enableTelemetry: $reported',
({ isCloud, enableTelemetry, reported }) => {
distribution.isCloud = isCloud
remoteConfig.value = { enable_telemetry: enableTelemetry }
const { widget } = group(`Gated ${isCloud} ${enableTelemetry}`)
refuseInputChanges()

widget('rows').value = 3

expect(
vi
.mocked(reportError)
.mock.calls.map(([, options]) => options.errorType)
).toEqual(reported)
}
)
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
})

describe('remote DynamicGroup row count writes', () => {
it('suppresses only the target node and restores an outer target', () => {
const outer = group('OuterRemoteTarget')
const inner = group('InnerRemoteTarget')
const other = group('LocalDuringRemote')
refuseInputChanges()

applyRemoteDynamicGroupRowCount(outer.node, () => {
applyRemoteDynamicGroupRowCount(inner.node, () => {})
outer.widget('rows').value = 3
other.widget('rows').value = 3
})

expect(
vi.mocked(reportError).mock.calls.map(([, options]) => options.tags)
).toEqual([expect.objectContaining({ node_type: 'LocalDuringRemote' })])
})
})

describe('remote DynamicGroup row count reports', () => {
function remoteNodeType(min: number) {
return class extends LGraphNode {
constructor() {
super('Remote Dynamic Group')
this.serialize_widgets = true
addGroup(this, min)
}
}
}

beforeEach(() => {
LiteGraph.registerNodeType('RemoteDynamicGroup', remoteNodeType(0))
LiteGraph.registerNodeType('MinOneDynamicGroup', remoteNodeType(1))
LiteGraph.registerNodeType('ConsentDynamicGroup', remoteNodeType(0))
})

function remoteGroup(type = 'RemoteDynamicGroup') {
const graph = new LGraph()
const { doc, collector } = followedDoc(
{
nodes: [
{
id: 1,
type,
pos: [0, 0],
size: [210, 100],
widgets_values: [1, 0.5]
}
],
links: []
},
{
types: {
[type]: {
widget_order: ['rows', 'rows.0.strength', 'rows.1.strength']
}
}
}
)
const applier = new LiveGraphApplier({ getGraph: () => graph })
const context = { actor: 'agent:test', opIds: ['op-1'] }
applier.applyChanges(doc, collector.take(), context)
const rows = graph
.getNodeById(toNodeId(1))
?.widgets?.find((widget) => widget.name === 'rows')
if (!rows) throw new Error('DynamicGroup node 1 was not created')
function setRows(count: unknown) {
doc.transact(() => {
const widgets = nodesMap(doc).get('1')?.get('widgets')
if (!(widgets instanceof Y.Map)) throw new Error('named storage')
widgets.set('rows', count)
})
return applier.applyChanges(doc, collector.take(), context).failureCount
}
return { rows, setRows }
}

it('applies a remote row count without reporting', () => {
const { rows, setRows } = remoteGroup()

expect([setRows(2), setRows(0)]).toEqual([0, 0])
expect(rows.value).toBe(0)
expect(reportError).not.toHaveBeenCalled()
})

it.for([
{ type: 'RemoteDynamicGroup', value: 2.5, expected: 2 },
{ type: 'RemoteDynamicGroup', value: -0, expected: 0 },
{ type: 'MinOneDynamicGroup', value: 0, expected: 1 }
])(
'does not report a remote $value the $type setter normalizes',
({ type, value, expected }) => {
const { rows, setRows } = remoteGroup(type)

expect(setRows(value)).toBe(0)
expect(rows.value).toBe(expected)
expect(reportError).not.toHaveBeenCalled()
}
)

it('reports a remote row count the live group did not reach, once per node type', () => {
const { rows, setRows } = remoteGroup()
refuseInputChanges()

expect([setRows(3), setRows(2)]).toEqual([1, 1])
expect(rows.value).toBe(1)
expect(vi.mocked(reportError).mock.calls).toEqual([
[
expect.objectContaining({
message: 'Remote DynamicGroup row count did not apply'
}),
{
errorType: 'agent_graph_dynamic_group_rows_mismatch',
surface: 'agent',
tags: {
subsystem: 'agent-crdt',
layer: 'graph-api',
outcome: 'degraded',
node_type: 'RemoteDynamicGroup',
operation: 'remote_apply',
in_subgraph: false
},
context: { requested: 3, actual: 1 }
}
]
])
})

it('counts but does not send a mismatch without telemetry consent', () => {
remoteConfig.value = {}
const { setRows } = remoteGroup('ConsentDynamicGroup')
refuseInputChanges()

expect(setRows(2)).toBe(1)
expect(reportError).not.toHaveBeenCalled()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — This consent test cannot fail. The reported dedupe Set in dynamicGroupDiagnostics.ts is module-level and persists between tests, and the previous test already recorded agent_graph_dynamic_group_rows_mismatch:RemoteDynamicGroup:remote_apply and failure_resizing_dynamic_group_rows:RemoteDynamicGroup:add_row. Dedupe therefore skips reportError here, and the test would still pass with the telemetry gate removed. Use a distinct node type for this test, as the local gating table does, or reset the dedupe state between tests. Raised by 1 of 6 reviewers (claude-opus-5-5-xhigh edge-case).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in b389726: the consent test now uses its own node type (ConsentDynamicGroup), so earlier tests cannot pre-fill the dedupe set for it.

})
})
Loading
Loading