Repository navigation
Conversation
|
✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
⚡ Performance:
|
This comment has been minimized.
This comment has been minimized.
|
Heads up: this conflicts with #21032. That PR makes English fallback the website policy. It deletes the The 31 missing |
|
That was my agent above I do think we should only have english or just one language be the requirement for PRs, because it seems to scale better when we have a lot more languages, and uses the translation pipeline for more trustable quality but that is only my opinion, maybe I am biased? |
|
Separately, are you a native Japanese speaker? If you are, we can take these 31 strings. If not, I think there's some ongoing work and open PR that should just make the translation run on a cron job or when English locale is added |
|
I have read and agree to the Contributor License Agreement |
Narrowed per review feedback on Comfy-Org#20991: drop the ja parity-test enforcement (it would conflict with the auto-translation workflow in Comfy-Org#21032 and fail CI on English-only PRs) and keep only the Japanese backfill of the strings that were missing at the time.
ddb6899 to
fcba8e9
Compare
|
Thanks for the detailed context! To answer your questions:
Happy to hold this until #21032 lands, or close it if the workflow's first translation PR covers these strings — whichever is easier for you. |
dante01yoon
left a comment
There was a problem hiding this comment.
Thanks for backfilling these strings. Unfortunately this can't land here anymore: apps/website was removed from this repo in #21861 (the site now lives in Comfy-Org/comfy-website), and the PR currently conflicts with main. Separately, the description still describes a translations.test.ts parity change that the narrowed commit no longer contains, and #21032 moved the website to an English-fallback policy.
| "company": "会社情報", | ||
| "contact": "お問い合わせ", | ||
| "enterpriseMsa": "エンタープライズMSA", | ||
| "fishAudio": "Fish Audio", |
There was a problem hiding this comment.
issue: This file no longer exists on main. #21861 removed apps/website and moved comfy.org to Comfy-Org/comfy-website, so the PR cannot merge here. Could we port the backfill to that repo (if the missing ja keys still apply there) and close this one?
Fixes #20978
What was wrong
The catalog parity test in
translations.test.tshard-codedzh-CN, sojasat outside the check entirely — deleting anyjakey passed every gate (measured in the issue), andja/main.jsonhad drifted to 31 missing keys with CI green.The fix
The check, not just the keys. The parity test now derives its locale list from
LOCALE_CODESminusDEFAULT_LOCALE, sojais covered by construction and any future locale lands inside the check automatically instead of needing another one-line edit that someone has to remember:The backfill. The 31 keys
jawas missing are restored: the two footer brand labels, the four model-launch comparison labels, and the 25 keys of thenvidiaRtxpage. Brand and product names stay untranslated per the glossary; wording follows the existingjaconventions in the neighbouringfishAudiosection (e.g.2026年10月更新,ドキュメントを見る,Q&A).Verification
translations.test.ts: 14 passed with the backfill.nvidiaRtx.hero.titlefromja/main.jsonmakes the suite fail with that key listed (1 failed), restoring it goes back to green. That is the failure mode Nothing enforces ja locale parity: a deleted ja key passes every gate, and ja/main.json is already missing 31 keys #20978 asked for: the missing keys become a failing test someone fixes once.npm run locale:check:All locales are up to date with the English sources.(it also independently reports the same 31 keys before the backfill).prettier --checkon both changed files: clean.0eligible keys missing fromja,0extra keys beyonden(excluding the six legal namespacestranslationExclusionsalready exempts).Not in scope
The six excluded legal namespaces (
tos,privacy,enterprise-msa,desktop_privacy,affiliate-terms,minimaxLicense) stay exempt for every locale exactly as before — extending coverage there is a separate decision, since those pages are long-form legal copy.