Repository navigation
[backport cloud/1.56] fix(agent): preserve dragged media URL in sent messages (#20246) - #20980
Conversation
## Summary A dragged nested video lost its own file URL once the message was sent: the sent bubble rebuilt `/view?filename=<display name>&type=input`, which only resolves when the display name equals the storage name. Since #20156 the drag already publishes `media_url`; this PR carries `mediaUrl` through `useAgentSession.recordUser` into `UserAttachment`, and `UserMessage` now prefers it for video and audio (images keep `previewUrl`; anything without a captured URL keeps the `/view?filename=<ref>` fallback). This also stops a video poster from being bound as `<video src>`. Known limits, unchanged from main: the captured URLs live only in the live session, so after a reload or hydrate the bubble falls back to the `ref` lookup; 3D drags carry no `media_url`, so a sent nested `.glb` still uses the fallback. Fixes #20245 ## Verification - `pnpm exec vitest run` over agent `message/`, `useAgentSession`, `services/agent`, `stores/agent`: 934 passed. New cases: an audio row in the reply-grid routing test, and a `useAgentSession` test that the sent user entry keeps `mediaUrl` (each fails when its branch is removed). - `browser_tests/tests/agent/agentNestedOutputSentPreview.spec.ts` is no longer `test.fail`; it drives the real nested-row drag, sends, and asserts the sent video `src` is `/assets/<id>/content` (cloud project). - `pnpm typecheck`, `pnpm typecheck:browser`, oxlint, oxfmt, eslint, knip, and fallow audit pass. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> (cherry picked from commit 3ef3f50)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-17T00:25:19.028Z",
"gitSha": "86b91b87fcd3c3eb9da97b38c5e9bfdd3a43072b",
"branch": "backport-20246-cloud-run8",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2016.6289999999663,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2470000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 232.595,
"heapDeltaBytes": 23143884,
"heapUsedBytes": 77406972,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.484000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.636000000024,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.335999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.023,
"heapDeltaBytes": 977760,
"heapUsedBytes": 69125416,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.040000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1690.3169999999932,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.06,
"layouts": 12,
"layoutDurationMs": 3.789,
"taskDurationMs": 497.43399999999997,
"heapDeltaBytes": -2042824,
"heapUsedBytes": 66735440,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 101.84300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.668000000012,
"styleRecalcs": 71,
"styleRecalcDurationMs": 16.011,
"layouts": 12,
"layoutDurationMs": 3.8199999999999994,
"taskDurationMs": 581.954,
"heapDeltaBytes": -2030584,
"heapUsedBytes": 66048980,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 124.709,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.1620000000303,
"styleRecalcs": 31,
"styleRecalcDurationMs": 7.303000000000003,
"layouts": 6,
"layoutDurationMs": 1.1829999999999998,
"taskDurationMs": 205.664,
"heapDeltaBytes": 3893828,
"heapUsedBytes": 71174448,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.881,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.0350000000008,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.601000000000003,
"layouts": 6,
"layoutDurationMs": 1.157,
"taskDurationMs": 261.3570000000001,
"heapDeltaBytes": 4235300,
"heapUsedBytes": 71978940,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.690000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 478.37700000002314,
"styleRecalcs": 17,
"styleRecalcDurationMs": 4.231999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 304.28499999999997,
"heapDeltaBytes": -6349280,
"heapUsedBytes": 60839628,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 108.42399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 533.6089999999558,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.359,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.241,
"heapDeltaBytes": 14757200,
"heapUsedBytes": 74411356,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.556,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 926.1079999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.735,
"heapDeltaBytes": 11924784,
"heapUsedBytes": 91611672,
"domNodes": 0,
"jsHeapTotalBytes": 1736704,
"scriptDurationMs": 39.830000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 305,
"frameDurationMs": 27.44705882352942,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 890.8030000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.472,
"heapDeltaBytes": 10888468,
"heapUsedBytes": 91964504,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 39.762,
"eventListeners": 0,
"totalBlockingTimeMs": 272,
"frameDurationMs": 26.766666666666673,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 688.367999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 243.4109999999996,
"heapDeltaBytes": 17403096,
"heapUsedBytes": 96978816,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 87.51399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 92,
"frameDurationMs": 20.58529411764705,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 720.5969999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 293.536,
"heapDeltaBytes": 17124952,
"heapUsedBytes": 98555568,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 100.54799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 97,
"frameDurationMs": 21.079411764705878,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5878.168000000016,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.2499999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4937.72,
"heapDeltaBytes": -8843180,
"heapUsedBytes": 68276188,
"domNodes": -143,
"jsHeapTotalBytes": -7999488,
"scriptDurationMs": 3926.062,
"eventListeners": -82,
"totalBlockingTimeMs": 38,
"frameDurationMs": 21.789259259259257,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5977.126999999996,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.3590000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5123.737,
"heapDeltaBytes": -10917728,
"heapUsedBytes": 73549696,
"domNodes": -142,
"jsHeapTotalBytes": -3805184,
"scriptDurationMs": 4056.622,
"eventListeners": -74,
"totalBlockingTimeMs": 27,
"frameDurationMs": 21.368214285714288,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5709.710000000001,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5320000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4948.627,
"heapDeltaBytes": 7831448,
"heapUsedBytes": 85162728,
"domNodes": -142,
"jsHeapTotalBytes": -11931648,
"scriptDurationMs": 3902.5989999999997,
"eventListeners": -78,
"totalBlockingTimeMs": 6,
"frameDurationMs": 21.33022388059701,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5752.879000000007,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.7230000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4954.863,
"heapDeltaBytes": 15965592,
"heapUsedBytes": 93172868,
"domNodes": -142,
"jsHeapTotalBytes": -9048064,
"scriptDurationMs": 3912.9020000000005,
"eventListeners": -74,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.138970588235292,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2009.9190000000249,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8730000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 286.18499999999995,
"heapDeltaBytes": -9890272,
"heapUsedBytes": 78332900,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 22.639999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2007.6609999999846,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.6069999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.85200000000003,
"heapDeltaBytes": -10351252,
"heapUsedBytes": 76873388,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 30.384999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2132.543999999996,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.409,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1009.428,
"heapDeltaBytes": -18622040,
"heapUsedBytes": 69566780,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 570.372,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7984126984127,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2120.627000000013,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.951,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1160.418,
"heapDeltaBytes": -17351676,
"heapUsedBytes": 71270056,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 601.067,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665873015873018,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3074.2369999999823,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.21,
"layouts": 60,
"layoutDurationMs": 14.709,
"taskDurationMs": 1097.31,
"heapDeltaBytes": 2526796,
"heapUsedBytes": 84018108,
"domNodes": 24,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 518.5970000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666486486486484,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3090.692000000047,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.010000000000002,
"layouts": 60,
"layoutDurationMs": 15.190000000000001,
"taskDurationMs": 1173.4450000000002,
"heapDeltaBytes": 2959856,
"heapUsedBytes": 83893484,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 547.7520000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665591397849465,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2240.963000000022,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.909000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1326.061,
"heapDeltaBytes": 11333052,
"heapUsedBytes": 88652020,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 706.6020000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791043,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2232.348000000002,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.657,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1329.909,
"heapDeltaBytes": 2643216,
"heapUsedBytes": 71085340,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 695.9100000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66641791044776,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.363000000012,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6359999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.36499999999995,
"heapDeltaBytes": -10489672,
"heapUsedBytes": 78269388,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 20.583,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.528000000013,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.818,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.123,
"heapDeltaBytes": -9487836,
"heapUsedBytes": 79917588,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 27.570999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 428.08800000000247,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.789999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 262.51599999999996,
"heapDeltaBytes": -11979416,
"heapUsedBytes": 57572344,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 93.466,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 433.257000000026,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.631999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 291.35299999999995,
"heapDeltaBytes": -11929212,
"heapUsedBytes": 57652520,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 100.75099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661538461538456,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2011.0169999999812,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.5429999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 251.45799999999997,
"heapDeltaBytes": 1216708,
"heapUsedBytes": 71203344,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.701999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.433999999956,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.595,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 298.288,
"heapDeltaBytes": 1205700,
"heapUsedBytes": 70904104,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.149999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1673.5519999999724,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.537999999999997,
"layouts": 16,
"layoutDurationMs": 5.6530000000000005,
"taskDurationMs": 527.357,
"heapDeltaBytes": -5877804,
"heapUsedBytes": 64083004,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 85.62100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.159000000027,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.863,
"layouts": 16,
"layoutDurationMs": 5.683000000000001,
"taskDurationMs": 540.784,
"heapDeltaBytes": 17338408,
"heapUsedBytes": 81173504,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 90.374,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 818.1250000000091,
"styleRecalcs": 17,
"styleRecalcDurationMs": 20.654,
"layouts": 5,
"layoutDurationMs": 9.200000000000001,
"taskDurationMs": 626.195,
"heapDeltaBytes": -697440,
"heapUsedBytes": 89653888,
"domNodes": 14227,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 20.038,
"eventListeners": 2463,
"totalBlockingTimeMs": 72,
"frameDurationMs": 19.44523809523809,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8138.569000000018,
"styleRecalcs": 250,
"styleRecalcDurationMs": 41.028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3685.035,
"heapDeltaBytes": -18765480,
"heapUsedBytes": 69714976,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 1905.6580000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598360655738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8234.929000000022,
"styleRecalcs": 250,
"styleRecalcDurationMs": 44.403999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4239.627,
"heapDeltaBytes": -14654164,
"heapUsedBytes": 69092700,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2082.395,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666125760649088,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12450.249999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11824.361,
"heapDeltaBytes": -32607588,
"heapUsedBytes": 180761640,
"domNodes": -3045,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 178.014,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.172619047619047,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-idle",
"durationMs": 12803.55499999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12289.505,
"heapDeltaBytes": -31355176,
"heapUsedBytes": 181924880,
"domNodes": -3045,
"jsHeapTotalBytes": 8933376,
"scriptDurationMs": 188.64600000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.584148397976392,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 14817.950999999994,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.132000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14310.917999999998,
"heapDeltaBytes": -21055472,
"heapUsedBytes": 194659676,
"domNodes": -3045,
"jsHeapTotalBytes": 5173248,
"scriptDurationMs": 629.438,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.422597864768687,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 14865.89300000003,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.878000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14340.211,
"heapDeltaBytes": -28594524,
"heapUsedBytes": 174876004,
"domNodes": -3045,
"jsHeapTotalBytes": 5644288,
"scriptDurationMs": 651.604,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.980036297640655,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-node-resize-workload",
"durationMs": 4507.913999999972,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.83599999999999,
"layouts": 20,
"layoutDurationMs": 22.19,
"taskDurationMs": 4384.695,
"heapDeltaBytes": 1265168,
"heapUsedBytes": 217613236,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 71.64499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.412280701754387,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 4553.0860000000075,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.62999999999999,
"layouts": 20,
"layoutDurationMs": 23.114000000000004,
"taskDurationMs": 4433.5430000000015,
"heapDeltaBytes": -12981540,
"heapUsedBytes": 218400516,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 72.22700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.60701754385965,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6493.2160000000185,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6114.1269999999995,
"heapDeltaBytes": -30646416,
"heapUsedBytes": 181599056,
"domNodes": -3045,
"jsHeapTotalBytes": 6246400,
"scriptDurationMs": 102.07899999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.335738831615124,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6324.639999999931,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5856.168000000001,
"heapDeltaBytes": -41242400,
"heapUsedBytes": 181892884,
"domNodes": -3045,
"jsHeapTotalBytes": 3072000,
"scriptDurationMs": 92.46799999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.32323232323232,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 87.98200000001088,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.335,
"layouts": 2,
"layoutDurationMs": 0.585,
"taskDurationMs": 56.839,
"heapDeltaBytes": 3927696,
"heapUsedBytes": 69234860,
"domNodes": 97,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.434999999999996,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 90.03900000004705,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.129999999999997,
"layouts": 3,
"layoutDurationMs": 1.523,
"taskDurationMs": 62.37100000000001,
"heapDeltaBytes": 3726992,
"heapUsedBytes": 69421612,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.066000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.639999999999965,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 495.9710000000541,
"styleRecalcs": 78,
"styleRecalcDurationMs": 90.89500000000001,
"layouts": 76,
"layoutDurationMs": 24.925,
"taskDurationMs": 461.22599999999994,
"heapDeltaBytes": -10641660,
"heapUsedBytes": 79559960,
"domNodes": 76,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 146.038,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 439.9640000000318,
"styleRecalcs": 78,
"styleRecalcDurationMs": 79.453,
"layouts": 76,
"layoutDurationMs": 20.817,
"taskDurationMs": 410.41700000000003,
"heapDeltaBytes": 13721316,
"heapUsedBytes": 86354736,
"domNodes": 76,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 136.37199999999999,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1116.8350000000373,
"styleRecalcs": 78,
"styleRecalcDurationMs": 293.77799999999996,
"layouts": 76,
"layoutDurationMs": 31.433999999999997,
"taskDurationMs": 1093.766,
"heapDeltaBytes": -20556352,
"heapUsedBytes": 107286728,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 289.93800000000005,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791036,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 873.6770000000433,
"styleRecalcs": 78,
"styleRecalcDurationMs": 210.551,
"layouts": 76,
"layoutDurationMs": 25.285,
"taskDurationMs": 853.7389999999999,
"heapDeltaBytes": -17608400,
"heapUsedBytes": 109012192,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 214.455,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2205 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 07ca10eaefc58f1e3ebbc062dd7b882fd4307cd5
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #20980 +/- ##
=============================================
Coverage ? 85.92%
=============================================
Files ? 2502
Lines ? 142705
Branches ? 39082
=============================================
Hits ? 122626
Misses ? 19693
Partials ? 386
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
christian-byrne
left a comment
There was a problem hiding this comment.
unit / test-shards (8) fails for real, not debris: src/components/sidebar/tabs/AssetsSidebarListView.test.ts > AssetsSidebarListView > dragging an asset out of list view > publishes the asset payload the composer resolves an attachment from (line 226). The backport adds media_url to the dragged-asset payload for playable (video/audio) assets in assetDragUtil.ts, and updates the eventUtils.test.ts fixtures to match, but this test's fixture for a video asset ('clip.mp4') still asserts the old shape without media_url, so the JSON-stringified payload no longer matches. Control: main's ci-tests-unit.yaml runs are green, so this isn't a known flake. Please update this test's expected payload to include media_url, same as the other two fixture files already in this diff. Holding merge until CI is green on the real failure.
Manual backport of #20246 to
cloud/1.56after backport automation did not create a PR.Validation: 228 focused Agent tests passed; app typecheck, formatting, type-aware Oxlint, ESLint, and Knip passed. The change includes the release-compatible local
ComposerAttachmenttype adaptation required by this branch.