Repository navigation
[backport core/1.56] fix(agent): preserve dragged media URL in sent messages (#20246) - #20979
Conversation
## Summary A dragged nested video lost its own file URL once the message was sent: the sent bubble rebuilt `/view?filename=<display name>&type=input`, which only resolves when the display name equals the storage name. Since #20156 the drag already publishes `media_url`; this PR carries `mediaUrl` through `useAgentSession.recordUser` into `UserAttachment`, and `UserMessage` now prefers it for video and audio (images keep `previewUrl`; anything without a captured URL keeps the `/view?filename=<ref>` fallback). This also stops a video poster from being bound as `<video src>`. Known limits, unchanged from main: the captured URLs live only in the live session, so after a reload or hydrate the bubble falls back to the `ref` lookup; 3D drags carry no `media_url`, so a sent nested `.glb` still uses the fallback. Fixes #20245 ## Verification - `pnpm exec vitest run` over agent `message/`, `useAgentSession`, `services/agent`, `stores/agent`: 934 passed. New cases: an audio row in the reply-grid routing test, and a `useAgentSession` test that the sent user entry keeps `mediaUrl` (each fails when its branch is removed). - `browser_tests/tests/agent/agentNestedOutputSentPreview.spec.ts` is no longer `test.fail`; it drives the real nested-row drag, sends, and asserts the sent video `src` is `/assets/<id>/content` (cloud project). - `pnpm typecheck`, `pnpm typecheck:browser`, oxlint, oxfmt, eslint, knip, and fallow audit pass. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> (cherry picked from commit 3ef3f50)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-17T00:29:32.630Z",
"gitSha": "95f96407c7a52dcafd631093b55d5b28b9815e06",
"branch": "backport-20246-core-run8",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.132999999987,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.7689999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.48300000000006,
"heapDeltaBytes": 1195580,
"heapUsedBytes": 69340880,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.84,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2016.793000000007,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4940000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.591,
"heapDeltaBytes": 1017716,
"heapUsedBytes": 68708448,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.439999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1751.9750000000158,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.894,
"layouts": 12,
"layoutDurationMs": 3.9189999999999996,
"taskDurationMs": 768.6619999999999,
"heapDeltaBytes": -2097876,
"heapUsedBytes": 66032324,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 160.611,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1770.7730000000765,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.823,
"layouts": 12,
"layoutDurationMs": 4.537,
"taskDurationMs": 783.2710000000001,
"heapDeltaBytes": -2111240,
"heapUsedBytes": 65503536,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 160.65600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66698113207547,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.5739999999992,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.67,
"layouts": 6,
"layoutDurationMs": 1.134,
"taskDurationMs": 324.611,
"heapDeltaBytes": 4177848,
"heapUsedBytes": 72237956,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.050999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1700.3439999999728,
"styleRecalcs": 32,
"styleRecalcDurationMs": 8.12,
"layouts": 6,
"layoutDurationMs": 1.042,
"taskDurationMs": 246.932,
"heapDeltaBytes": 4124876,
"heapUsedBytes": 71693192,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.268999999999993,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 659.2709999999897,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.1530000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.18100000000004,
"heapDeltaBytes": -7533628,
"heapUsedBytes": 60480336,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 160.572,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102578,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 676.368000000025,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.5709999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.766,
"heapDeltaBytes": -7423436,
"heapUsedBytes": 60806828,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 168.886,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1130.882999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 794.431,
"heapDeltaBytes": 14839976,
"heapUsedBytes": 84654824,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 70.33700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 515,
"frameDurationMs": 34.34242424242425,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1111.866999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 780.534,
"heapDeltaBytes": 15405896,
"heapUsedBytes": 85141424,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 63.080999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 503,
"frameDurationMs": 33.83636363636365,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.4549999999917,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.8740000000004,
"heapDeltaBytes": 17840852,
"heapUsedBytes": 104896168,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 154.837,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.0129999999708,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.62799999999993,
"heapDeltaBytes": 17854776,
"heapUsedBytes": 105793400,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 159.36700000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9049.394999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8151.880999999999,
"heapDeltaBytes": -10727704,
"heapUsedBytes": 67673688,
"domNodes": -142,
"jsHeapTotalBytes": -12193792,
"scriptDurationMs": 6967.182999999999,
"eventListeners": -74,
"totalBlockingTimeMs": 851,
"frameDurationMs": 34.40912547528517,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9216.164000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8484.692,
"heapDeltaBytes": -16935972,
"heapUsedBytes": 68533952,
"domNodes": -172,
"jsHeapTotalBytes": -10358784,
"scriptDurationMs": 6989.728,
"eventListeners": -82,
"totalBlockingTimeMs": 642,
"frameDurationMs": 33.152158273381296,
"p95FrameDurationMs": 66.5
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9180.77599999998,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3549999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8452.379,
"heapDeltaBytes": -4827116,
"heapUsedBytes": 80634288,
"domNodes": -142,
"jsHeapTotalBytes": -10620928,
"scriptDurationMs": 6971.4130000000005,
"eventListeners": -78,
"totalBlockingTimeMs": 769,
"frameDurationMs": 32.563475177304966,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9073.568000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8383.465999999999,
"heapDeltaBytes": 13063604,
"heapUsedBytes": 97789268,
"domNodes": -142,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 6901.957,
"eventListeners": -74,
"totalBlockingTimeMs": 634,
"frameDurationMs": 32.968363636363634,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2007.9840000000218,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.632999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.8709999999999,
"heapDeltaBytes": -9425364,
"heapUsedBytes": 79371788,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.979000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2029.087000000004,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.449,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.873,
"heapDeltaBytes": -7018656,
"heapUsedBytes": 78364264,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 29.95600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2174.3419999999674,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.458999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1515.1830000000002,
"heapDeltaBytes": -16979012,
"heapUsedBytes": 69901540,
"domNodes": 0,
"jsHeapTotalBytes": 1609728,
"scriptDurationMs": 806.506,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153843,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2435.8720000000176,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.423,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1634.123,
"heapDeltaBytes": -17054172,
"heapUsedBytes": 73039400,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 899.554,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78137931034483,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3518.3080000000473,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.917,
"layouts": 60,
"layoutDurationMs": 13.662,
"taskDurationMs": 1453.872,
"heapDeltaBytes": 1596780,
"heapUsedBytes": 69824084,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 767.5609999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665876777251185,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3487.987999999973,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.345999999999998,
"layouts": 60,
"layoutDurationMs": 13.713,
"taskDurationMs": 1615.558,
"heapDeltaBytes": 1632768,
"heapUsedBytes": 69791944,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 768.302,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666028708133975,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3106.8409999999744,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.138,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1826.635,
"heapDeltaBytes": 9210672,
"heapUsedBytes": 77865548,
"domNodes": 0,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 959.9280000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756756756756758,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3136.688999999933,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.909999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1879.864,
"heapDeltaBytes": 16579508,
"heapUsedBytes": 85869300,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 1016.246,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755614973262034,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2023.8479999999868,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.5300000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.60499999999996,
"heapDeltaBytes": 13480184,
"heapUsedBytes": 81423656,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.124,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2013.304000000062,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.201,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.20799999999997,
"heapDeltaBytes": -9248872,
"heapUsedBytes": 81217260,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 29.627,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 583.5059999999999,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.135000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.685,
"heapDeltaBytes": -11743356,
"heapUsedBytes": 57822076,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 138.87000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.7440000000252,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.875999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.55899999999997,
"heapDeltaBytes": -12001948,
"heapUsedBytes": 58257808,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 140.05200000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2002.5319999999738,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.234999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.635,
"heapDeltaBytes": 1360188,
"heapUsedBytes": 71517024,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.628999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.7739999999176,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.443,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.0330000000001,
"heapDeltaBytes": 1379468,
"heapUsedBytes": 71580756,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.013,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.5760000000173,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.475,
"layouts": 16,
"layoutDurationMs": 5.509,
"taskDurationMs": 726.2869999999999,
"heapDeltaBytes": -6027704,
"heapUsedBytes": 64057376,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 108.36099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.35699999997,
"styleRecalcs": 59,
"styleRecalcDurationMs": 16.745000000000005,
"layouts": 16,
"layoutDurationMs": 5.68,
"taskDurationMs": 737.2350000000001,
"heapDeltaBytes": 17287760,
"heapUsedBytes": 80325404,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.51400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.828155339805818,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.063000000022,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.046999999999997,
"layouts": 5,
"layoutDurationMs": 14.734,
"taskDurationMs": 901.553,
"heapDeltaBytes": 2947428,
"heapUsedBytes": 97314568,
"domNodes": 14227,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 28.418,
"eventListeners": 2463,
"totalBlockingTimeMs": 135,
"frameDurationMs": 19.143243243243237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8308.487999999954,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.38,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5323.429,
"heapDeltaBytes": 11202136,
"heapUsedBytes": 91073676,
"domNodes": 0,
"jsHeapTotalBytes": 1277952,
"scriptDurationMs": 2688.407,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666064257028115,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8278.106999999978,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.88000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5481.2919999999995,
"heapDeltaBytes": -16495324,
"heapUsedBytes": 72373580,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2770.258,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17074.126000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16402.04,
"heapDeltaBytes": -32486240,
"heapUsedBytes": 180446020,
"domNodes": -3045,
"jsHeapTotalBytes": 7622656,
"scriptDurationMs": 249.66699999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.904737732656514,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 17795.61000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16925.629999999997,
"heapDeltaBytes": -44470972,
"heapUsedBytes": 178984740,
"domNodes": -3045,
"jsHeapTotalBytes": -679936,
"scriptDurationMs": 254.531,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.81457286432161,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 21422.634000000016,
"styleRecalcs": 177,
"styleRecalcDurationMs": 18.247999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21000.139,
"heapDeltaBytes": -18225372,
"heapUsedBytes": 192826184,
"domNodes": -3045,
"jsHeapTotalBytes": 9945088,
"scriptDurationMs": 900.1149999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 31,
"frameDurationMs": 38.62671480144404,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 21973.00000000007,
"styleRecalcs": 177,
"styleRecalcDurationMs": 19.052999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21628.275999999998,
"heapDeltaBytes": -54117524,
"heapUsedBytes": 167347320,
"domNodes": -3045,
"jsHeapTotalBytes": 1155072,
"scriptDurationMs": 894.242,
"eventListeners": -14915,
"totalBlockingTimeMs": 47,
"frameDurationMs": 40.63290203327172,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6247.837000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.18799999999997,
"layouts": 20,
"layoutDurationMs": 23.521,
"taskDurationMs": 6074.791,
"heapDeltaBytes": 999992,
"heapUsedBytes": 213757064,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 98.269,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.54795321637426,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6294.800999999893,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.63100000000001,
"layouts": 20,
"layoutDurationMs": 23.24899999999999,
"taskDurationMs": 6193.138999999999,
"heapDeltaBytes": 1251540,
"heapUsedBytes": 217815568,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 103.56400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.20517241379311,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8949.640999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8609.656,
"heapDeltaBytes": -32376188,
"heapUsedBytes": 179168416,
"domNodes": -3045,
"jsHeapTotalBytes": 1417216,
"scriptDurationMs": 149.66799999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.19281045751634,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8564.250000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8243.275,
"heapDeltaBytes": -21913028,
"heapUsedBytes": 181218544,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 122.917,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.843097643097646,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 486.37600000006387,
"styleRecalcs": 21,
"styleRecalcDurationMs": 20.123999999999995,
"layouts": 4,
"layoutDurationMs": 2.072,
"taskDurationMs": 138.31799999999998,
"heapDeltaBytes": 6052680,
"heapUsedBytes": 71195808,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 16.75900000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241396,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 120.2970000000505,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.624000000000002,
"layouts": 2,
"layoutDurationMs": 1.2680000000000002,
"taskDurationMs": 73.55300000000001,
"heapDeltaBytes": 3740576,
"heapUsedBytes": 69507564,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.778999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65714285714278,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 785.7750000000578,
"styleRecalcs": 78,
"styleRecalcDurationMs": 93.598,
"layouts": 76,
"layoutDurationMs": 23.201,
"taskDurationMs": 744.325,
"heapDeltaBytes": 17060100,
"heapUsedBytes": 81431224,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 299.017,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66808510638297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 759.2370000000983,
"styleRecalcs": 78,
"styleRecalcDurationMs": 94.436,
"layouts": 76,
"layoutDurationMs": 22.688,
"taskDurationMs": 725.441,
"heapDeltaBytes": -15485672,
"heapUsedBytes": 71724004,
"domNodes": 76,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 299.00100000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667391304347824,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1329.2699999999513,
"styleRecalcs": 78,
"styleRecalcDurationMs": 242.86599999999999,
"layouts": 76,
"layoutDurationMs": 27.133,
"taskDurationMs": 1308.88,
"heapDeltaBytes": -13235748,
"heapUsedBytes": 107242164,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 438.337,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.877215189873432,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1318.7010000000328,
"styleRecalcs": 78,
"styleRecalcDurationMs": 241.757,
"layouts": 76,
"layoutDurationMs": 27.346,
"taskDurationMs": 1298.555,
"heapDeltaBytes": 8342196,
"heapUsedBytes": 113766428,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 439.612,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.098701298701304,
"p95FrameDurationMs": 16.80000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2206 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d8bc82e541a30557f679264e7952b28c4838e888
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.56 #20979 +/- ##
=============================================
+ Coverage 85.83% 85.95% +0.12%
=============================================
Files 2476 2482 +6
Lines 141376 141730 +354
Branches 36506 38724 +2218
=============================================
+ Hits 121348 121824 +476
+ Misses 19644 19522 -122
Partials 384 384
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 61 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
christian-byrne
left a comment
There was a problem hiding this comment.
unit / test-shards (8) fails for real, not debris: src/components/sidebar/tabs/AssetsSidebarListView.test.ts > AssetsSidebarListView > dragging an asset out of list view > publishes the asset payload the composer resolves an attachment from (line 226). The backport adds media_url to the dragged-asset payload for playable (video/audio) assets in assetDragUtil.ts, and updates the eventUtils.test.ts fixtures to match, but this test's fixture for a video asset ('clip.mp4') still asserts the old shape without media_url, so the JSON-stringified payload no longer matches. Control: main's ci-tests-unit.yaml runs are green, so this isn't a known flake. Please update this test's expected payload to include media_url, same as the other two fixture files already in this diff. Holding merge until CI is green on the real failure.
Manual backport of #20246 to
core/1.56after backport automation did not create a PR.Validation: 228 focused Agent tests passed; app typecheck, formatting, type-aware Oxlint, ESLint, and Knip passed. The change includes the release-compatible local
ComposerAttachmenttype adaptation required by this branch.