Skip to content

fix(website): respect reduced motion and add posters on the Nvidia VFX page - #20955

Merged
june-bump merged 3 commits into
mainfrom
claude/nvidia-vfx-followups
Oct 14, 2026
Merged

june-bump merged 3 commits into
mainfrom
claude/nvidia-vfx-followups

Conversation

@claude

@claude claude Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Requested by June · Slack thread

Summary

Follow-up to #19664, fixing three review findings on /nvidia-vfx.

Before: the before/after comparison clips autoplayed and looped even for visitors who ask for reduced motion, and showed an empty dark box until the clips arrived. On phones the full-width workflow screenshot in the gallery was cropped to its middle, losing about 40% of the image.

After: with reduced motion the comparison stays paused on its first frame. Each tab shows a poster frame while its clips load. On phones the workflow screenshot fits inside its card in full (pinned to the top so the caption sits below it); tablet and desktop are unchanged.

How: VideoCompareSlider binds autoplay only after mount and only when prefersReducedMotion() is false (the helper ScrollCarousel uses), so the server markup never carries the attribute. Before/after tabs gain optional beforePosterSrc/afterPosterSrc, bound as poster with preload="none" as in ModelLaunchGalleryCardMedia. The six first-frame posters (extracted from the Nvidia clips) live on media.comfy.org next to the clips (https://media.comfy.org/website/nvidia-rtx/nvidia-vfx-<tab>-{before,after}.jpg), not in git, and each tab's beforePosterSrc/afterPosterSrc points at them. A span: 'full' image card uses object-contain object-top below md and the existing object-cover from md up; /nvidia-vfx is the only page with a full-span card. No zh-CN copy changed. The HDR caption is left for a separate copy decision.

Verification

  • VideoCompareSlider.test.ts: new table test for autoplay with and without reduced motion (fails on the old static autoplay), and a poster test.
  • ModelLaunchGalleryCardMedia.test.ts: covers the full-span image, regular image and full-span video paths.
  • pnpm exec oxlint, pnpm exec eslint apps/website, pnpm --filter @comfyorg/website format:check, pnpm typecheck:website, and website pnpm test:unit all pass locally.
  • Screenshots from the local dev server. Motion itself can't be shown in a still; the reduced-motion shots show the paused first frame. The "while clips load" After shot was taken with the same poster images served locally; they are now served from media.comfy.org (each of the six URLs returns 200 image/jpeg).
Before After
Gallery workflow image, 390 wide
Comparison while clips load, 390 wide
Comparison with reduced motion, 1440 wide

…X page

- VideoCompareSlider only autoplays its two clips after mount and when the
  visitor has not asked for reduced motion; otherwise both stay paused on
  their first frame. Binding autoplay after mount keeps the server markup
  free of the attribute, so hydration cannot leave it set.
- Before/after tabs accept beforePosterSrc/afterPosterSrc, bound as poster
  with preload="none" like the gallery videos. The Nvidia tabs use
  first-frame JPGs extracted from their clips.
- A full-span gallery image fits inside its card below md instead of being
  cropped by aspect-video + object-cover (the 2400x817 pipeline image lost
  about 40% of its width on phones). md and up is unchanged.

Follow-up to #19664.
@claude
claude Bot temporarily deployed to website-approval October 13, 2026 22:14 Inactive
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d9c4cd99-c055-4809-9bfe-da1dbc60dc3b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 99d57a26d17a98186dfb79fba211d1e7dbd210c4

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-20955.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-e9maqev6z-comfyui.vercel.app

Last updated: 2026-10-14T00:01:48Z for d1e988c

@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #20955      +/-   ##
==========================================
- Coverage   86.38%   86.27%   -0.12%     
==========================================
  Files        3672     3567     -105     
  Lines      175225   171991    -3234     
  Branches    48353    47253    -1100     
==========================================
- Hits       151364   148378    -2986     
+ Misses      21817    21727      -90     
+ Partials     2044     1886     -158     
Flag Coverage Δ
billing-web-unit ?
website-unit 80.94% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...bsite/src/components/common/VideoCompareSlider.vue 94.87% <100.00%> (+0.27%) ⬆️
apps/website/src/data/nvidiaRtx.ts 100.00% <ø> (ø)
...tes/model-launch/ModelLaunchBeforeAfterSection.vue 78.94% <ø> (ø)
...lates/model-launch/ModelLaunchGalleryCardMedia.vue 80.00% <100.00%> (+13.33%) ⬆️
apps/website/src/templates/model-launch/types.ts 100.00% <ø> (ø)

... and 107 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 13, 2026
…ia.comfy.org

Media belongs on media.comfy.org, not in git. Remove the six first-frame
JPGs and their beforePosterSrc/afterPosterSrc entries; the optional poster
fields and the binding stay so the URLs can be added once uploaded.

Add a unit test for ModelLaunchGalleryCardMedia covering the full-span
image, regular image and full-span video paths.
@claude
claude Bot temporarily deployed to website-approval October 13, 2026 22:51 Inactive
@claude
claude Bot temporarily deployed to website-approval October 13, 2026 22:51 Inactive
@claude
claude Bot temporarily deployed to website-approval October 13, 2026 22:52 Inactive
@claude
claude Bot temporarily deployed to website-approval October 13, 2026 23:34 Inactive
@claude
claude Bot temporarily deployed to website-approval October 13, 2026 23:34 Inactive
@claude claude Bot assigned bertfy and DrJKL Oct 13, 2026
@mrseek-reviews
mrseek-reviews Bot requested a review from DrJKL October 13, 2026 23:56
@june-bump
june-bump marked this pull request as ready for review October 13, 2026 23:57
@june-bump
june-bump requested a review from a team October 13, 2026 23:57
@june-bump
june-bump added this pull request to the merge queue Oct 13, 2026
@DrJKL DrJKL added greenlight webshepherd Ask the webshepherd-bot to get your code merged into main. webreviewer labels Oct 13, 2026
@DrJKL
DrJKL temporarily deployed to website-approval October 13, 2026 23:58 — with GitHub Actions Inactive
@DrJKL
DrJKL temporarily deployed to website-approval October 13, 2026 23:58 — with GitHub Actions Inactive
@DrJKL
DrJKL temporarily deployed to website-approval October 13, 2026 23:58 — with GitHub Actions Inactive
@comfy-greenlight-bot

comfy-greenlight-bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Swarmhost agentic review

The detailed evaluation is available to employees in the internal Slack review thread.

Evaluation failed to run (author_not_trusted).

Evaluation budget remaining for this pull request: 99 automatic and 99 manual.

Updated by Swarmhost's agentic review process.

@webshepherd-bot

Copy link
Copy Markdown
Collaborator

🐑 The six posters all resolve — that's the check nothing in CI does. Holding the queue for @webreviewer-bot.

This fixes the exact findings that were weighed and accepted on #19664, which is the right way for them to come back.

What I verified myself, because a CDN path that 404s is green in CI and ships as an empty box:

poster status
nvidia-vfx-super-resolution-before.jpg 200 image/jpeg 77,700 B
nvidia-vfx-super-resolution-after.jpg 200 image/jpeg 81,642 B
nvidia-vfx-frame-generation-before.jpg 200 image/jpeg 73,977 B
nvidia-vfx-frame-generation-after.jpg 200 image/jpeg 73,245 B
nvidia-vfx-sdr-to-hdr-before.jpg 200 image/jpeg 30,123 B
nvidia-vfx-sdr-to-hdr-after.jpg 200 image/jpeg 32,397 B

All six live, all sensibly sized, and the hero poster at :76 is in the repo rather than on the CDN. Nothing in this repository checks those URLs, so that's a one-off result rather than a guarantee — but it's the failure mode that would have made this fix worthless, and it isn't present.

Gates at d1e988c1: all five required checks green; @DrJKL approved; website-only; no hold language. UNSTABLE is only two cancelled fast-lane runs and a cancelled deploy-preview, none of them required.

Why I'm not queueing yet. @webreviewer-bot is labelled and hasn't posted. After #20683 — where I armed --auto and a review landed ten minutes later, too late to matter because the merge queue doesn't re-evaluate reviews once a PR is accepted — I hold the queue when a review is plausibly coming rather than arming it and watching. It is plausibly coming here.

That's worth the wait specifically on this PR: the three fixes are reduced motion, poster frames and a mobile crop, which are rendered behaviours. My poster check is a network result, not a rendering one, and @webreviewer-bot measures painted pixels with idle-vs-idle controls. If the reduced-motion gate or the object-contain object-top fix doesn't do what the diff says, that's where it shows up.

Scope-wise this is squarely mine — 7 files, +126/−10, and 88 of the 126 added lines are tests. I'll queue on its verdict.

Merged via the queue into main with commit 3557c08 Oct 14, 2026
144 of 148 checks passed

This branch was previously deployed

1 inactive deployment
website-approval — d1e988c1 Deployed Oct 13, 2026 by DrJKL via fast-lane #1827
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greenlight risk:high PR risk grade (advisory shadow check; grader-owned) webreviewer webshepherd Ask the webshepherd-bot to get your code merged into main.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants