Skip to content

fix(agent): report late billing refresh failures [core/1.56] - #20952

Merged
christian-byrne merged 4 commits into
core/1.56from
christian-byrne/backport-credit-refresh-late-error-core-1.56
Oct 13, 2026
Merged

christian-byrne merged 4 commits into
core/1.56from
christian-byrne/backport-credit-refresh-late-error-core-1.56

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

  • report billing refresh rejection even when it arrives after the freshness timeout
  • expose shared refresh readiness for deterministic reopen tests
  • replace timing sleeps with observable readiness checks

Validation

  • pnpm vitest run src/workbench/extensions/agent/composables/useAgentDockMount.test.ts src/workbench/extensions/agent/stores/agent/agentPanelStore.test.ts (53 passed)
  • pnpm typecheck

Follow-up carrier for #20929 after review.

@christian-byrne
christian-byrne requested review from a team as code owners October 13, 2026 21:36
@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Oct 13, 2026
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 3f15ab85-1aa7-4280-8c35-493a06ee3ebf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/13/2026, 10:11:30 PM UTC

Links

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 8829788816ee1ddafcd77ad476b720a8d0531e98

Full docs: ADR-DEVEX-LINT-0015

🎭 Playwright: ✅ 2204 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2184 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 17 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 13, 2026
@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../extensions/agent/composables/useAgentDockMount.ts 90.90% 1 Missing ⚠️
...h/extensions/agent/stores/agent/agentPanelStore.ts 97.82% 1 Missing ⚠️
@@            Coverage Diff             @@
##           core/1.56   #20952   +/-   ##
==========================================
  Coverage      85.94%   85.94%           
==========================================
  Files           2481     2481           
  Lines         141649   141679   +30     
  Branches       36590    36602   +12     
==========================================
+ Hits          121739   121770   +31     
+ Misses         19526    19525    -1     
  Partials         384      384           
Flag Coverage Δ
unit 82.93% <96.49%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../extensions/agent/composables/useAgentDockMount.ts 92.64% <90.90%> (+1.87%) ⬆️
...h/extensions/agent/stores/agent/agentPanelStore.ts 96.20% <97.82%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 6 finding(s).

Severity Count
🟡 Medium 1
🟢 Low 4
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

@christian-byrne
christian-byrne merged commit 6ebb0df into core/1.56 Oct 13, 2026
113 checks passed
@christian-byrne
christian-byrne deleted the christian-byrne/backport-credit-refresh-late-error-core-1.56 branch October 13, 2026 22:23

This branch was previously deployed

1 inactive deployment
website-approval — 6512ca68 Deployed Oct 13, 2026 by christian-byrne via fast-lane #1615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant