Skip to content

fix(website): stop serving the 5.4 MB fish-audio hero video to phones - #20935

Open
OrangerXu wants to merge 1 commit into
Comfy-Org:mainfrom
OrangerXu:fix/fish-audio-mobile-hero-still
Open

OrangerXu wants to merge 1 commit into
Comfy-Org:mainfrom
OrangerXu:fix/fish-audio-mobile-hero-still

Conversation

@OrangerXu

Copy link
Copy Markdown

Summary

/fish-audio/ serves its ~5.4 MB hero video to phones: fishAudio.ts does not set mobileFallbackImageSrc, so ModelLaunchHeroSection renders the <video> at every viewport size. The opt-in existed in #20898 (fc2184a9, "show the poster still instead of the 44 MB hero video on phones") and was dropped when 3145d92e rewrote the data file for unrelated reasons — nothing asserted it, so nothing failed.

Restores the guard: below the 768px breakpoint (and during SSR) the poster still is served and no <video> element reaches the DOM, so phones never fetch the clip.

Fixes #20932

Verification

  • Tests: new apps/website/src/data/fishAudio.test.ts, following the wan3.test.ts viewport pattern —
    • mobile (375px): document.querySelectorAll('video') is empty (the clip is never fetched);
    • desktop (1280px): exactly one <video> whose src is the full clip;
    • data-level: the mobile still is pinned to the poster.
  • vitest run src/templates/model-launch/modelLaunchPages.test.ts: 98/98 pass with the new field (the suite validates every model-launch page's data, fish-audio included).
  • The viewport tests cannot run in my local Windows environment — the component import chain hits a file:///icons/node-left.svg resolution quirk that also fails the pre-existing wan3.test.ts and ModelLaunchHeroSection.test.ts locally; they follow the identical pattern that is green in CI.
  • oxfmt --check clean; eslint clean.

The /fish-audio hero opts into the poster still below the 768px
breakpoint: phones (and the SSR pass) render no <video> element at all,
so the ~5.4 MB clip is never fetched on mobile. The guard existed in
Comfy-Org#20898 (fc2184a, 'show the poster still instead of the 44 MB hero video
on phones') and was dropped when 3145d92 rewrote the data file for
unrelated reasons - nothing asserted it, so nothing failed.

A fishAudio.test.ts pins the behaviour the way wan3.test.ts does: no
<video> in the DOM on a phone-sized viewport, the full clip on desktop.

Fixes Comfy-Org#20932
@OrangerXu
OrangerXu requested a review from a team October 13, 2026 20:14
@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 2
  • apps/website/src/data/fishAudio.test.ts is excluded by !apps/website/**
  • apps/website/src/data/fishAudio.ts is excluded by !apps/website/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 6c6197fd-5236-407b-b63e-f6b4d9286348

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged.
Posted by the CLA Assistant Lite bot.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

⚡ Performance: ⚠️ Performance tests failed — check the CI workflow logs

🔬 E2E Coverage: ⚠️ Coverage collection failed — check the CI workflow logs

🎭 Playwright: ⏳ Running...

🎨 Storybook: ❌ Failed

❌ Storybook failed. Open the workflow run and fix the build before merging.

Details

⏰ Completed at: 11/12/2026, 09:17:25 PM UTC

Links

@datadog-official

datadog-official Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: be4386a | Docs | View more details | Give us feedback!

@OrangerXu

Copy link
Copy Markdown
Author

recheck

This branch was previously deployed

1 inactive deployment
website-approval — be4386a5 Deployed Oct 13, 2026 by OrangerXu via fast-lane #1343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/fish-audio serves its 5.4 MB hero video to phones: mobileFallbackImageSrc was dropped mid-PR

1 participant