Repository navigation
Conversation
The /fish-audio hero opts into the poster still below the 768px breakpoint: phones (and the SSR pass) render no <video> element at all, so the ~5.4 MB clip is never fetched on mobile. The guard existed in Comfy-Org#20898 (fc2184a, 'show the poster still instead of the 44 MB hero video on phones') and was dropped when 3145d92 rewrote the data file for unrelated reasons - nothing asserted it, so nothing failed. A fishAudio.test.ts pins the behaviour the way wan3.test.ts does: no <video> in the DOM on a phone-sized viewport, the full clip on desktop. Fixes Comfy-Org#20932
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 2
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged. |
⚡ Performance:
|
|
🔗 Commit SHA: be4386a | Docs | View more details | Give us feedback! |
|
recheck |
Summary
/fish-audio/serves its ~5.4 MB hero video to phones:fishAudio.tsdoes not setmobileFallbackImageSrc, soModelLaunchHeroSectionrenders the<video>at every viewport size. The opt-in existed in #20898 (fc2184a9, "show the poster still instead of the 44 MB hero video on phones") and was dropped when3145d92erewrote the data file for unrelated reasons — nothing asserted it, so nothing failed.Restores the guard: below the 768px breakpoint (and during SSR) the poster still is served and no
<video>element reaches the DOM, so phones never fetch the clip.Fixes #20932
Verification
apps/website/src/data/fishAudio.test.ts, following thewan3.test.tsviewport pattern —document.querySelectorAll('video')is empty (the clip is never fetched);<video>whose src is the full clip;vitest run src/templates/model-launch/modelLaunchPages.test.ts: 98/98 pass with the new field (the suite validates every model-launch page's data, fish-audio included).file:///icons/node-left.svgresolution quirk that also fails the pre-existingwan3.test.tsandModelLaunchHeroSection.test.tslocally; they follow the identical pattern that is green in CI.oxfmt --checkclean;eslintclean.