Skip to content

feat(website): link Fish Audio from the footer Models column - #20930

Merged
june-bump merged 1 commit into
mainfrom
claude/fish-audio-footer-link
Oct 13, 2026
Merged

june-bump merged 1 commit into
mainfrom
claude/fish-audio-footer-link

Conversation

@claude

@claude claude Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Requested by June · Slack thread

Summary

Before: The /fish-audio page had no inbound link anywhere on the site, so visitors could only reach it by typing the address.

After: The footer's Models column now ends with a "Fish Audio" link to the page, in English and in Chinese (zh-CN, linking to /zh-CN/fish-audio/).

This adds one footer entry for the Fish Audio launch page; the header and nav menus are untouched, and the page's noindex setting and llms.txt are unchanged.

Verification

How: Added a footer.fishAudio string ("Fish Audio" in en and zh-CN) to apps/website/src/locales/{en,zh-CN}/main.json, appended the link after Flux 3 in the Models column of apps/website/src/components/common/SiteFooter.vue (the existing routes.fishAudio route already localizes), and added a unit test in SiteFooter.test.ts covering en and zh-CN. Checks run: pnpm exec oxlint (0 errors), eslint on apps/website (clean), pnpm --filter @comfyorg/website format:check (clean), pnpm typecheck:website (0 errors), SiteFooter.test.ts (22 passed). The full website unit run passed 11683 of 11686; the 3 failures are in useWorkflowFormDraft.test.ts and fail the same way on the base commit, so they are unrelated to this change. E2E and screenshots were not run.


Generated by Claude Code

Adds the Fish Audio entry to the footer Models column, pointing at the /fish-audio launch page (localized for zh-CN), with en and zh-CN labels and a footer unit test.
@claude
claude Bot requested a review from a team October 13, 2026 19:57
@claude
claude Bot temporarily deployed to website-approval October 13, 2026 19:57 Inactive
@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 18c87d58-bbec-4f71-a230-71ab104bee58

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 36f7c162787e4e29c18dd9dfa39432bf3f59688f

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-20930.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-am50wc7nv-comfyui.vercel.app

Last updated: 2026-10-13T20:05:46Z for e0b34ba

@june-bump june-bump self-assigned this Oct 13, 2026
@june-bump june-bump added the webshepherd Ask the webshepherd-bot to get your code merged into main. label Oct 13, 2026
@june-bump
june-bump enabled auto-merge October 13, 2026 20:01
@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #20930      +/-   ##
==========================================
- Coverage   86.34%   86.23%   -0.12%     
==========================================
  Files        3665     3560     -105     
  Lines      175106   171868    -3238     
  Branches    46228    45125    -1103     
==========================================
- Hits       151195   148203    -2992     
+ Misses      21895    21805      -90     
+ Partials     2016     1860     -156     
Flag Coverage Δ
billing-web-unit ?
website-unit 80.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/components/common/SiteFooter.vue 100.00% <ø> (ø)

... and 105 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@webshepherd-bot

Copy link
Copy Markdown
Collaborator

🐑 The change itself is as simple as it gets. One question before I queue it, and it isn't about the code.

@june-bump scope-wise this is squarely in my lane: 4 files, +23/-1, a footer entry plus a unit test covering en and zh-CN. routes.fishAudio already localises, the header and nav are untouched, and @DrJKL has approved at e0b34baa. Website-only. Nothing here needs fixing.

The question is what it links to. #20898 merged at 19:10:51, so /fish-audio is live now — and I checked the live page and the live docs a minute ago, not the PR branch:

says
comfy.org/fish-audio/ (live) 50% off for your first 30 days — in four places
docs.comfy.org/.../drama-3 (live) $14.30 during the offer, $35.75 from 13 Nov 2026 → 60% off, fixed window

This PR changes that page from "reachable if you know the address" to "linked from every page on the site." That is a real change in reach, and it is the thing I'd want someone to have chosen deliberately rather than inherited from a footer tidy-up.

I'm not re-opening #20898. I raised this three times there, stood down, and the owners merged it — that was their call and I'm not relitigating it through a side door. But queueing this is a fresh affirmative act of mine, and amplifying a live contradiction is squarely the kind of exposure I'm supposed to check before I press the button.

One sentence settles it, either way:

  • "The 50% is correct, the docs are stale" → I queue immediately and someone can fix the docs whenever.
  • "The docs are right" → then the page wants a copy edit first, which is cheap now and cheaper than after it's linked site-wide.

@webreviewer-bot labelled in for the usual pass. website-e2e hasn't been created yet either, so there's no rush on my side.

For the record: if this were a new page or a redesign I'd be weighing it differently, but a footer link with a test is exactly the modest, cosmetic work I'm here to move. The only thing holding my hand is the price on the other end of it.

@june-bump
june-bump added this pull request to the merge queue Oct 13, 2026
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 13, 2026
Merged via the queue into main with commit e6c4d9b Oct 13, 2026
132 checks passed
@june-bump
june-bump deleted the claude/fish-audio-footer-link branch October 13, 2026 20:27
xmarre pushed a commit to xmarre/ComfyUI_frontend that referenced this pull request Oct 14, 2026
…rg#20956)

<!-- claude-slack-attribution -->
_Requested by **June** · [Slack
thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1791930389097529)_

## Summary

**Before:** the footer Models column ends at Fish Audio, so the live
`/nvidia-vfx` page (https://comfy.org/nvidia-vfx) has no footer entry.

**After:** "Nvidia VFX" is the last link in the footer Models column,
linking to `/nvidia-vfx/` (`/zh-CN/nvidia-vfx/` for zh-CN). Mirrors
Comfy-Org#20930 (Fish Audio): new `routes.nvidiaVfx`, a `footer.nvidiaVfx` label
in the en and zh-CN catalogs, and a footer unit test. The Fish Audio
test now checks that link is present instead of last, since Nvidia VFX
takes the last slot.

**Scope note:** footer-only change requested today. There is a nav hold
note (Robert Paige, 2026-10-09, "hold all navigation changes"). The
footer is not the top nav, and the Fish Audio footer link (Comfy-Org#20930)
shipped today on the same basis, but reviewers please object if you read
the hold as covering this.

## Verification

- Tests: `pnpm vitest run src/components/common/SiteFooter.test.ts` in
`apps/website` passes (24 tests).
- `pnpm typecheck` in `apps/website` passes (0 errors); the pre-commit
hook ran lint and typecheck cleanly.
- `pnpm locale:check` reports ja pending translations for the new footer
key, same as the existing Fish Audio entry.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_015n3Ky3a7sDsPnHVCnnVWAj


---
_Generated by [Claude
Code](https://claude.ai/code/session_015n3Ky3a7sDsPnHVCnnVWAj)_

Co-authored-by: Claude <noreply@anthropic.com>

This branch was previously deployed

1 inactive deployment
website-approval — e0b34baa Deployed Oct 13, 2026 by webshepherd-bot via fast-lane #1313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned) webreviewer webshepherd Ask the webshepherd-bot to get your code merged into main.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants