Repository navigation
feat(website): link Fish Audio from the footer Models column - #20930
Conversation
Adds the Fish Audio entry to the footer Models column, pointing at the /fish-audio launch page (localized for zh-CN), with en and zh-CN labels and a footer unit test.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 36f7c162787e4e29c18dd9dfa39432bf3f59688f
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-20930.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-am50wc7nv-comfyui.vercel.app Last updated: 2026-10-13T20:05:46Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20930 +/- ##
==========================================
- Coverage 86.34% 86.23% -0.12%
==========================================
Files 3665 3560 -105
Lines 175106 171868 -3238
Branches 46228 45125 -1103
==========================================
- Hits 151195 148203 -2992
+ Misses 21895 21805 -90
+ Partials 2016 1860 -156
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 105 files with indirect coverage changes 🚀 New features to boost your workflow:
|
🐑 The change itself is as simple as it gets. One question before I queue it, and it isn't about the code.@june-bump scope-wise this is squarely in my lane: 4 files, +23/-1, a footer entry plus a unit test covering en and zh-CN. The question is what it links to. #20898 merged at 19:10:51, so
This PR changes that page from "reachable if you know the address" to "linked from every page on the site." That is a real change in reach, and it is the thing I'd want someone to have chosen deliberately rather than inherited from a footer tidy-up. I'm not re-opening #20898. I raised this three times there, stood down, and the owners merged it — that was their call and I'm not relitigating it through a side door. But queueing this is a fresh affirmative act of mine, and amplifying a live contradiction is squarely the kind of exposure I'm supposed to check before I press the button. One sentence settles it, either way:
@webreviewer-bot labelled in for the usual pass. For the record: if this were a new page or a redesign I'd be weighing it differently, but a footer link with a test is exactly the modest, cosmetic work I'm here to move. The only thing holding my hand is the price on the other end of it. |
…rg#20956) <!-- claude-slack-attribution --> _Requested by **June** · [Slack thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1791930389097529)_ ## Summary **Before:** the footer Models column ends at Fish Audio, so the live `/nvidia-vfx` page (https://comfy.org/nvidia-vfx) has no footer entry. **After:** "Nvidia VFX" is the last link in the footer Models column, linking to `/nvidia-vfx/` (`/zh-CN/nvidia-vfx/` for zh-CN). Mirrors Comfy-Org#20930 (Fish Audio): new `routes.nvidiaVfx`, a `footer.nvidiaVfx` label in the en and zh-CN catalogs, and a footer unit test. The Fish Audio test now checks that link is present instead of last, since Nvidia VFX takes the last slot. **Scope note:** footer-only change requested today. There is a nav hold note (Robert Paige, 2026-10-09, "hold all navigation changes"). The footer is not the top nav, and the Fish Audio footer link (Comfy-Org#20930) shipped today on the same basis, but reviewers please object if you read the hold as covering this. ## Verification - Tests: `pnpm vitest run src/components/common/SiteFooter.test.ts` in `apps/website` passes (24 tests). - `pnpm typecheck` in `apps/website` passes (0 errors); the pre-commit hook ran lint and typecheck cleanly. - `pnpm locale:check` reports ja pending translations for the new footer key, same as the existing Fish Audio entry. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_015n3Ky3a7sDsPnHVCnnVWAj --- _Generated by [Claude Code](https://claude.ai/code/session_015n3Ky3a7sDsPnHVCnnVWAj)_ Co-authored-by: Claude <noreply@anthropic.com>
Requested by June · Slack thread
Summary
Before: The /fish-audio page had no inbound link anywhere on the site, so visitors could only reach it by typing the address.
After: The footer's Models column now ends with a "Fish Audio" link to the page, in English and in Chinese (zh-CN, linking to /zh-CN/fish-audio/).
This adds one footer entry for the Fish Audio launch page; the header and nav menus are untouched, and the page's noindex setting and llms.txt are unchanged.
Verification
How: Added a
footer.fishAudiostring ("Fish Audio" in en and zh-CN) toapps/website/src/locales/{en,zh-CN}/main.json, appended the link after Flux 3 in the Models column ofapps/website/src/components/common/SiteFooter.vue(the existingroutes.fishAudioroute already localizes), and added a unit test inSiteFooter.test.tscovering en and zh-CN. Checks run:pnpm exec oxlint(0 errors), eslint onapps/website(clean),pnpm --filter @comfyorg/website format:check(clean),pnpm typecheck:website(0 errors),SiteFooter.test.ts(22 passed). The full website unit run passed 11683 of 11686; the 3 failures are inuseWorkflowFormDraft.test.tsand fail the same way on the base commit, so they are unrelated to this change. E2E and screenshots were not run.Generated by Claude Code