Skip to content

fix(website): fill missing Japanese catalog messages - #20928

Merged
DrJKL merged 3 commits into
mainfrom
bl/i18n-website-catchup-2026-10-13
Oct 13, 2026
Merged

DrJKL merged 3 commits into
mainfrom
bl/i18n-website-catchup-2026-10-13

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Summary

Fill 3,097 missing Japanese messages against the current English source. Update the runtime and footer expectations for translated Japanese copy while preserving coverage for English fallback on untranslated legal copy.

Part of FE-2045. Catalogs were generated by this workflow run against 964a7509cc69.

Merge after #20366's selective catalog loading. The populated Japanese JSON is 305,805 raw bytes / 81,205 gzip bytes; gzip is a local compression estimate. Current main eagerly imports every locale catalog.

Retain all Chinese values from main: seven source-matched values updated in #20331 and #20660 were restored after generation. The Chinese diff is canonical key ordering only. Japanese product-name consistency remains a copy-review follow-up before merge.

Verification

  • Workflow translated 3,107 strings using 79 requests and updated the locale catalogs and source manifest.
  • Website locale:check: no pending translations, prunable keys, or unbaselined protected-token violations.
  • 35 scoped runtime, footer, and FAQ tests passed. The four stale Japanese expectations failed against the generated catalogs before their updates.
  • A second generation run translated zero strings and changed zero files.
  • The installed Vue I18n message compiler accepted all 10,127 catalog messages without syntax errors.
  • Normal commit checks passed, including website typechecking.
  • Normal push checks passed, including Knip and the diff-scoped Fallow audit.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1
  • apps/website/src/locales/zh-CN/main.json is excluded by !apps/website/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d64e5267-f501-464b-a04f-220ba17eaa54

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 13, 2026
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 964a7509cc69ee9a3db27d0c9a7a9997de91e321

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-20928.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-m8jchx9m0-comfyui.vercel.app

Last updated: 2026-10-13T19:40:36Z for 8ff240d

@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #20928      +/-   ##
==========================================
- Coverage   86.34%   86.23%   -0.12%     
==========================================
  Files        3665     3560     -105     
  Lines      175106   171868    -3238     
  Branches    46228    45125    -1103     
==========================================
- Hits       151195   148203    -2992     
+ Misses      21895    21805      -90     
+ Partials     2016     1860     -156     
Flag Coverage Δ
billing-web-unit ?
website-unit 80.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 105 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benceruleanlu benceruleanlu changed the title fix(website): refresh Japanese and Chinese catalogs fix(website): fill missing Japanese catalog messages Oct 13, 2026
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 13, 2026
@benceruleanlu
benceruleanlu marked this pull request as ready for review October 13, 2026 19:42
@benceruleanlu
benceruleanlu requested a review from a team October 13, 2026 19:42
@mrseek-reviews
mrseek-reviews Bot requested a review from DrJKL October 13, 2026 19:42
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T19:46:48.992229Z 8ff240d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@DrJKL
DrJKL enabled auto-merge October 13, 2026 19:46

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ff240df4b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -1,10 +1,172 @@
{
"about": {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Load the Japanese catalog only for Japanese pages

This expands the Japanese catalog from 9.8 KB to 305.8 KB (about 80 KB gzipped), but src/i18n/translations.ts still statically imports ja/main.json and constructs all three locales. Because BaseLayout.astro hydrates HeaderMain with client:load on normal pages, English and Chinese visitors must also download and parse this entire catalog on nearly every visit. Land the selective catalog-loading change before this expansion, or include it here, so the new payload is requested only for Japanese pages.

Useful? React with 👍 / 👎.

@DrJKL
DrJKL added this pull request to the merge queue Oct 13, 2026
Merged via the queue into main with commit 12ca5a2 Oct 13, 2026
102 of 104 checks passed
@DrJKL
DrJKL deleted the bl/i18n-website-catchup-2026-10-13 branch October 13, 2026 20:07

This branch was previously deployed

1 inactive deployment
website-approval — 8ff240df Deployed Oct 13, 2026 by benceruleanlu via fast-lane #1276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants