Repository navigation
fix(website): fill missing Japanese catalog messages - #20928
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 964a7509cc69ee9a3db27d0c9a7a9997de91e321
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-20928.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-m8jchx9m0-comfyui.vercel.app Last updated: 2026-10-13T19:40:36Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20928 +/- ##
==========================================
- Coverage 86.34% 86.23% -0.12%
==========================================
Files 3665 3560 -105
Lines 175106 171868 -3238
Branches 46228 45125 -1103
==========================================
- Hits 151195 148203 -2992
+ Misses 21895 21805 -90
+ Partials 2016 1860 -156
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ff240df4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,10 +1,172 @@ | |||
| { | |||
| "about": { | |||
There was a problem hiding this comment.
Load the Japanese catalog only for Japanese pages
This expands the Japanese catalog from 9.8 KB to 305.8 KB (about 80 KB gzipped), but src/i18n/translations.ts still statically imports ja/main.json and constructs all three locales. Because BaseLayout.astro hydrates HeaderMain with client:load on normal pages, English and Chinese visitors must also download and parse this entire catalog on nearly every visit. Land the selective catalog-loading change before this expansion, or include it here, so the new payload is requested only for Japanese pages.
Useful? React with 👍 / 👎.
Summary
Fill 3,097 missing Japanese messages against the current English source. Update the runtime and footer expectations for translated Japanese copy while preserving coverage for English fallback on untranslated legal copy.
Part of FE-2045. Catalogs were generated by this workflow run against
964a7509cc69.Merge after #20366's selective catalog loading. The populated Japanese JSON is 305,805 raw bytes / 81,205 gzip bytes; gzip is a local compression estimate. Current main eagerly imports every locale catalog.
Retain all Chinese values from main: seven source-matched values updated in #20331 and #20660 were restored after generation. The Chinese diff is canonical key ordering only. Japanese product-name consistency remains a copy-review follow-up before merge.
Verification
locale:check: no pending translations, prunable keys, or unbaselined protected-token violations.