Repository navigation
[backport core/1.56] Warn when Agent grant transitions to workspace credits - #20927
Conversation
#20400) Addresses [PM-2005](https://linear.app/comfyorg/issue/PM-2005/agent-says-chatting-is-free-but-chat-silently-burned-3500-paid-credits). The Agent panel shows a dismissible notice after it observes the Agent's own credit grant (`scoped_has_funds.agent`) change from available to exhausted while workspace funding remains: "You've used your free agent credits. Further agent activity uses your workspace credits, which may include paid credits." A first read of `false` never arms it. A refill ends the episode, so a later exhaustion shows it again, and a dismissal lasts only for the current episode. The dock mount observes the balance even while the panel is closed. When no workspace funding remains, the standing paywall stays primary. The notice is limited to workspaces with an active subscription (`is_active`). The free-turn notice from #20756 shows only while the grant has funds, so the two never render together. `app:agent_credit_transition_notice` records `shown` and `dismissed`. - Unit: the episode reducer (`creditTransitionNoticeState.test.ts`), `AgentPanelRoot.test.ts`, `useAgentDockMount.test.ts`, and the telemetry provider tests. The standing-paywall table includes a workspace with no active subscription, which fails if the paywall's gate reads `is_active`. - E2E: `agentCreditsExhaustionLifecycle.spec.ts` ends its lifecycle run by exhausting only the grant, then asserts the notice, the absence of a paywall, `shown` and `dismissed` host telemetry, and two goldens:   - Gates: `pnpm typecheck`, `pnpm typecheck:browser`, oxlint, eslint, oxfmt, knip, and `lint:server-facts` pass. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-13T19:48:48.314Z",
"gitSha": "f7b1b501804107a2898fcfe07968cdba22d26180",
"branch": "christian-byrne/backport-20400-core-1.56-v2",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2011.2489999999639,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.54100000000005,
"heapDeltaBytes": 1330276,
"heapUsedBytes": 68754372,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.819999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.1210000000501,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.98,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.182,
"heapDeltaBytes": 952588,
"heapUsedBytes": 68457748,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.322000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1773.497999999961,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.749000000000002,
"layouts": 12,
"layoutDurationMs": 4.336,
"taskDurationMs": 822.9620000000001,
"heapDeltaBytes": -2094836,
"heapUsedBytes": 65713444,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 166.12099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1718.2820000000447,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.271,
"layouts": 12,
"layoutDurationMs": 4.144,
"taskDurationMs": 668.834,
"heapDeltaBytes": -1798792,
"heapUsedBytes": 66256880,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 155.794,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1699.4079999999485,
"styleRecalcs": 33,
"styleRecalcDurationMs": 10.568,
"layouts": 6,
"layoutDurationMs": 1.2570000000000001,
"taskDurationMs": 339.20700000000005,
"heapDeltaBytes": 140848,
"heapUsedBytes": 62393100,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.724000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1694.121999999993,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.836,
"layouts": 6,
"layoutDurationMs": 1.0219999999999998,
"taskDurationMs": 338.1379999999999,
"heapDeltaBytes": 4139400,
"heapUsedBytes": 71725268,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.039000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 690.0120000000243,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.385999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.665,
"heapDeltaBytes": -7408908,
"heapUsedBytes": 61238616,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 171.103,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926843,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 701.7399999999725,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.468999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.037,
"heapDeltaBytes": -7123008,
"heapUsedBytes": 62064792,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.061,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1129.1140000000155,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 789.9709999999999,
"heapDeltaBytes": 15145048,
"heapUsedBytes": 85828516,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 68.515,
"eventListeners": 0,
"totalBlockingTimeMs": 506,
"frameDurationMs": 33.332352941176474,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1152.5139999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 804.118,
"heapDeltaBytes": 16053500,
"heapUsedBytes": 85297532,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 65.73700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 518,
"frameDurationMs": 33.82058823529411,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.6409999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.7049999999995,
"heapDeltaBytes": 17797468,
"heapUsedBytes": 105163660,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 164.91899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 25.491176470588258,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.3680000000077,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.6539999999999,
"heapDeltaBytes": 16683108,
"heapUsedBytes": 104385276,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 168.983,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10685.060000000021,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.35899999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9712.08,
"heapDeltaBytes": 5293568,
"heapUsedBytes": 82686648,
"domNodes": -142,
"jsHeapTotalBytes": -7737344,
"scriptDurationMs": 8082.625999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 1270,
"frameDurationMs": 33.5940251572327,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8805.719000000066,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.4999999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8158.579,
"heapDeltaBytes": -15457464,
"heapUsedBytes": 69717236,
"domNodes": -142,
"jsHeapTotalBytes": -6164480,
"scriptDurationMs": 6954.643,
"eventListeners": -74,
"totalBlockingTimeMs": 974,
"frameDurationMs": 34.91904761904761,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9348.913999999979,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05400000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8612.436000000002,
"heapDeltaBytes": -9761852,
"heapUsedBytes": 68460620,
"domNodes": -142,
"jsHeapTotalBytes": -10096640,
"scriptDurationMs": 7086.152999999999,
"eventListeners": -74,
"totalBlockingTimeMs": 733,
"frameDurationMs": 32.80561403508772,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10216.411999999991,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.43900000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9452.636999999999,
"heapDeltaBytes": -3950388,
"heapUsedBytes": 80587580,
"domNodes": -142,
"jsHeapTotalBytes": -12193792,
"scriptDurationMs": 7866.183,
"eventListeners": -78,
"totalBlockingTimeMs": 932,
"frameDurationMs": 33.60625,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2022.0600000000104,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.854999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.2439999999999,
"heapDeltaBytes": -11912240,
"heapUsedBytes": 67652040,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.270999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2022.2529999999779,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.7800000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.7049999999999,
"heapDeltaBytes": -9461176,
"heapUsedBytes": 79638504,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 38.321999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2324.175000000025,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.603000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1560.1829999999998,
"heapDeltaBytes": -17088204,
"heapUsedBytes": 67896428,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 831.1500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665942028985505,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2443.550000000073,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.718000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1606.29,
"heapDeltaBytes": -20484604,
"heapUsedBytes": 69255864,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 866.4750000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.780689655172406,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3591.836999999998,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.847000000000001,
"layouts": 60,
"layoutDurationMs": 14.172,
"taskDurationMs": 1646.604,
"heapDeltaBytes": -18186488,
"heapUsedBytes": 68607932,
"domNodes": 24,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 785.07,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665581395348838,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3601.841000000036,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.781999999999998,
"layouts": 60,
"layoutDurationMs": 13.806,
"taskDurationMs": 1654.108,
"heapDeltaBytes": 1239040,
"heapUsedBytes": 69944184,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 790.444,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662037037037,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3121.7790000000036,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.053,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1870.6699999999998,
"heapDeltaBytes": 9891172,
"heapUsedBytes": 78841076,
"domNodes": 0,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 988.4060000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756216216216213,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3124.380999999971,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.673000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1873.5539999999999,
"heapDeltaBytes": 8077864,
"heapUsedBytes": 77019124,
"domNodes": 0,
"jsHeapTotalBytes": 2322432,
"scriptDurationMs": 957.9020000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.846486486486487,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2012.959999999964,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.516,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.1540000000001,
"heapDeltaBytes": -8945052,
"heapUsedBytes": 80725340,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 32.66799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2009.7500000000537,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.7960000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.1979999999999,
"heapDeltaBytes": -9060336,
"heapUsedBytes": 81419464,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 31.244999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 616.1329999999907,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.814000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.55499999999995,
"heapDeltaBytes": -11688812,
"heapUsedBytes": 57230128,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 147.94199999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 628.4289999999828,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.81,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.48900000000003,
"heapDeltaBytes": -11687348,
"heapUsedBytes": 58288576,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 142.34199999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.6180000000227,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.343000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.451,
"heapDeltaBytes": 1433700,
"heapUsedBytes": 71748364,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.254999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2011.2209999999777,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.167,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.706,
"heapDeltaBytes": 733712,
"heapUsedBytes": 69078000,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.626999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.1430000000028,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.346,
"layouts": 16,
"layoutDurationMs": 5.335999999999999,
"taskDurationMs": 749.9979999999999,
"heapDeltaBytes": -5575876,
"heapUsedBytes": 64497256,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 109.497,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1703.1049999999368,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.105999999999998,
"layouts": 16,
"layoutDurationMs": 5.352,
"taskDurationMs": 740.1099999999999,
"heapDeltaBytes": -5974056,
"heapUsedBytes": 64127524,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 110.983,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.707999999985,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.249000000000006,
"layouts": 5,
"layoutDurationMs": 14.765,
"taskDurationMs": 908.466,
"heapDeltaBytes": 3011180,
"heapUsedBytes": 99214776,
"domNodes": 14227,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 30.61699999999999,
"eventListeners": 2463,
"totalBlockingTimeMs": 136,
"frameDurationMs": 19.4054794520548,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8477.442999999994,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.934999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5642.974,
"heapDeltaBytes": -15585292,
"heapUsedBytes": 73384820,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2824.967,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283467,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8438.479000000028,
"styleRecalcs": 252,
"styleRecalcDurationMs": 35.839999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5558.115,
"heapDeltaBytes": -18999500,
"heapUsedBytes": 69683588,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2778.9199999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69920792079208,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18144.26400000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17213.897,
"heapDeltaBytes": -53772960,
"heapUsedBytes": 168537160,
"domNodes": -3045,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 279.711,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.248833333333337,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 18148.537000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17256.505999999998,
"heapDeltaBytes": -38887968,
"heapUsedBytes": 179535988,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 330.06,
"eventListeners": -14915,
"totalBlockingTimeMs": 7,
"frameDurationMs": 30.322240802675587,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 21869.388000000014,
"styleRecalcs": 176,
"styleRecalcDurationMs": 19.967999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21473.861,
"heapDeltaBytes": -28654712,
"heapUsedBytes": 184759072,
"domNodes": -3046,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 907.417,
"eventListeners": -14915,
"totalBlockingTimeMs": 32,
"frameDurationMs": 39.97404021937842,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 22554.68200000007,
"styleRecalcs": 177,
"styleRecalcDurationMs": 20.28200000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22080.035000000003,
"heapDeltaBytes": -60322240,
"heapUsedBytes": 166687580,
"domNodes": -3045,
"jsHeapTotalBytes": 7770112,
"scriptDurationMs": 881.721,
"eventListeners": -14915,
"totalBlockingTimeMs": 7,
"frameDurationMs": 41.68040665434381,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6612.874000000033,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.49299999999998,
"layouts": 20,
"layoutDurationMs": 24.558999999999997,
"taskDurationMs": 6481.433999999999,
"heapDeltaBytes": 1736344,
"heapUsedBytes": 212978684,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 111.362,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.28700564971751,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6382.60600000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.36299999999996,
"layouts": 20,
"layoutDurationMs": 23.257,
"taskDurationMs": 6281.4,
"heapDeltaBytes": -13043628,
"heapUsedBytes": 214298892,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 108.173,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.45240963855421,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9106.988000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8682.551,
"heapDeltaBytes": -34141212,
"heapUsedBytes": 179642100,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 178.68,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.03135313531353,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6963.443999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6611.3730000000005,
"heapDeltaBytes": -27342236,
"heapUsedBytes": 179568228,
"domNodes": -3046,
"jsHeapTotalBytes": 6549504,
"scriptDurationMs": 139.76699999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.93630363036304,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 121.11700000002656,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.388,
"layouts": 3,
"layoutDurationMs": 1.0109999999999997,
"taskDurationMs": 91.501,
"heapDeltaBytes": 3950988,
"heapUsedBytes": 69745148,
"domNodes": 98,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.245000000000003,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 127.28500000002896,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.754,
"layouts": 3,
"layoutDurationMs": 1.669,
"taskDurationMs": 85.66299999999998,
"heapDeltaBytes": 3798932,
"heapUsedBytes": 69326024,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.532999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.44999999999997,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 903.9189999999735,
"styleRecalcs": 78,
"styleRecalcDurationMs": 105.984,
"layouts": 76,
"layoutDurationMs": 26.859,
"taskDurationMs": 871.85,
"heapDeltaBytes": 18261704,
"heapUsedBytes": 84372488,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 352.785,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 903.4550000000081,
"styleRecalcs": 78,
"styleRecalcDurationMs": 103.1,
"layouts": 76,
"layoutDurationMs": 25.62,
"taskDurationMs": 867.9870000000001,
"heapDeltaBytes": 18096352,
"heapUsedBytes": 83612360,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 357.754,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664814814814807,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1452.442000000019,
"styleRecalcs": 78,
"styleRecalcDurationMs": 267.42,
"layouts": 76,
"layoutDurationMs": 29.665,
"taskDurationMs": 1435.4140000000002,
"heapDeltaBytes": 8544828,
"heapUsedBytes": 115146648,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 482.65200000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333749999999988,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1389.8229999999785,
"styleRecalcs": 78,
"styleRecalcDurationMs": 250.496,
"layouts": 76,
"layoutDurationMs": 27.581000000000003,
"taskDurationMs": 1363.492,
"heapDeltaBytes": -19011488,
"heapUsedBytes": 110544688,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 450.783,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.511392405063308,
"p95FrameDurationMs": 33.29999999999927
}
]
}🎭 Playwright: ✅ 2206 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (34 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c2322f7f20c8075a475520a15f1b1fc0e4d9f9d1
Full docs: ADR-DEVEX-LINT-0015 |
|
Updating Playwright Expectations |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.56 #20927 +/- ##
===========================================
Coverage 85.94% 85.94%
===========================================
Files 2478 2481 +3
Lines 141460 141566 +106
Branches 36531 36569 +38
===========================================
+ Hits 121576 121675 +99
- Misses 19500 19507 +7
Partials 384 384
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 4 |
| 🟢 Low | 2 |
| ⚪ Nit | 3 |
Panel: 8/8 reviewers contributed findings.
…20937) ## Summary P0 follow-up to #20927: coordinates Agent billing freshness in the shared panel store so concurrent graph/linear hosts cannot adopt a superseded workspace snapshot, duplicate reopen refreshes, or lose the new-identity baseline after rejection. ## Verification - 499 targeted unit tests passed. - `pnpm typecheck` passed. - Focused coverage: concurrent hosts/latest-wins, rejected refresh baseline, deduped reopen and repeat reopen.
Summary
Backports #20400 to core/1.56 so users are told when their Agent-scoped grant is exhausted and subsequent Agent activity uses workspace credits.
Changes
scoped_has_funds.agent, and retains the approved truthfulTry your first chat for free!copy.Review Focus
Please verify the 1.56 conflict resolution preserves the existing standing paywall while showing this notice only after an observed scoped
true → falsetransition with effective Agent funds still available.Verification
pnpm typecheck.Linear
Original: #20400