Skip to content

fix(website): name the signed-out Run link for screen readers and cover the Try in Cloud analytics gate - #20924

Open
mariana953 wants to merge 1 commit into
mainfrom
claude/hub-run-label-a11y
Open

mariana953 wants to merge 1 commit into
mainfrom
claude/hub-run-label-a11y

Conversation

@mariana953

@mariana953 mariana953 commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #20919, addressing webreviewer-bot's two SHOULD FIX findings and one TRIVIAL:

  • Link purpose (WCAG 2.4.4): the signed-out Run is a link to /login/?returnTo=… whose accessible name was just "Run". It now carries aria-label "Sign in to run" (existing workshop.run.signIn key, en + zh-CN) on both ModelDetail.vue and WorkflowRunControls.vue. The visible text stays "Run", and the accessible name contains it (label-in-name).
  • Analytics gate covered: new WorkflowPage.test.ts case "reports no Try in Cloud while Workflows access is off", mirroring the existing download test. It fails if the captureTryInCloud gate is replaced with if (true).
  • Dead operand: the header container's v-if="downloadUrl || cloudHref" becomes v-if="cloudHref", since downloadUrl only exists when a template does.

Verification

  • Unit: ModelDetail, WorkflowRunControls, WorkflowPage, 123/123 pass. Removing either aria-label fails 4 tests, and the gate mutation fails the new test.
  • E2E selectors for the signed-out link updated to "Sign in to run" in models-sign-in-draft, workshop and workshop-workflows.
  • Website typecheck, eslint/oxlint, oxfmt, knip and fallow are clean.

Generated by Claude Code

@mariana953
mariana953 requested a review from a team October 13, 2026 18:08
@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (9)
  • apps/website/e2e/models-sign-in-draft.spec.ts is excluded by !apps/website/**
  • apps/website/e2e/workshop-workflows.spec.ts is excluded by !apps/website/**
  • apps/website/e2e/workshop.spec.ts is excluded by !apps/website/**
  • apps/website/src/components/workshop/ModelDetail.test.ts is excluded by !apps/website/**
  • apps/website/src/components/workshop/ModelDetail.vue is excluded by !apps/website/**
  • apps/website/src/components/workshop/WorkflowPage.test.ts is excluded by !apps/website/**
  • apps/website/src/components/workshop/WorkflowPage.vue is excluded by !apps/website/**
  • apps/website/src/components/workshop/WorkflowRunControls.test.ts is excluded by !apps/website/**
  • apps/website/src/components/workshop/WorkflowRunControls.vue is excluded by !apps/website/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 964b26c6-518b-412d-b0ce-310326f3034b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (13 changed files).

Kind Finding Where Usual remedy
Complexity <template>() — cyclomatic 46, CRAP undefined apps/website/src/components/workshop/ModelDetail.vue:885 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.

Pre-existing findings are baselined in .fallow-baselines/ and are not your
responsibility — see ADR-DEVEX-LINT-0015.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 897a930b8618bf75c640ae54dec2f859eb3bd513

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-20924.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-pzpnp3lz7-comfyui.vercel.app

Last updated: 2026-10-13T18:11:15Z for f544d9c

@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #20924      +/-   ##
==========================================
- Coverage   86.32%   86.21%   -0.12%     
==========================================
  Files        3665     3560     -105     
  Lines      175160   171922    -3238     
  Branches    46270    45167    -1103     
==========================================
- Hits       151209   148218    -2991     
+ Misses      21937    21847      -90     
+ Partials     2014     1857     -157     
Flag Coverage Δ
billing-web-unit ?
website-unit 80.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ps/website/src/components/workshop/ModelDetail.vue 90.37% <ø> (ø)
...s/website/src/components/workshop/WorkflowPage.vue 87.50% <100.00%> (+3.12%) ⬆️
...te/src/components/workshop/WorkflowRunControls.vue 84.84% <ø> (ø)

... and 105 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 13, 2026

This branch was previously deployed

1 inactive deployment
website-approval — f544d9c3 Deployed Oct 14, 2026 by mariana953 via fast-lane #3270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants