Repository navigation
fix(website): name the signed-out Run link for screen readers and cover the Try in Cloud analytics gate - #20924
mariana953 wants to merge 1 commit into
Conversation
…er the Try in Cloud analytics gate
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (9)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (13 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 897a930b8618bf75c640ae54dec2f859eb3bd513
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-20924.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-pzpnp3lz7-comfyui.vercel.app Last updated: 2026-10-13T18:11:15Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20924 +/- ##
==========================================
- Coverage 86.32% 86.21% -0.12%
==========================================
Files 3665 3560 -105
Lines 175160 171922 -3238
Branches 46270 45167 -1103
==========================================
- Hits 151209 148218 -2991
+ Misses 21937 21847 -90
+ Partials 2014 1857 -157
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 105 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Follow-up to #20919, addressing webreviewer-bot's two SHOULD FIX findings and one TRIVIAL:
/login/?returnTo=…whose accessible name was just "Run". It now carriesaria-label"Sign in to run" (existingworkshop.run.signInkey, en + zh-CN) on bothModelDetail.vueandWorkflowRunControls.vue. The visible text stays "Run", and the accessible name contains it (label-in-name).WorkflowPage.test.tscase "reports no Try in Cloud while Workflows access is off", mirroring the existing download test. It fails if thecaptureTryInCloudgate is replaced withif (true).v-if="downloadUrl || cloudHref"becomesv-if="cloudHref", sincedownloadUrlonly exists when a template does.Verification
ModelDetail,WorkflowRunControls,WorkflowPage, 123/123 pass. Removing either aria-label fails 4 tests, and the gate mutation fails the new test.models-sign-in-draft,workshopandworkshop-workflows.Generated by Claude Code