Repository navigation
[backport cloud/1.56] FE-3361 feat(server-facts): type member gates as ServerFact so a recombined gate fails to compile - #20916
Conversation
…mbined gate fails to compile (#20818) ## Why FE-3361 (L1, server-fact guardrails). The changed-line lint (#20679, refined in #20806) is syntactic. It loses a server fact once the fact crosses a function, file, prop or store boundary under another name (#19455 hid its derivation behind a helper). A type travels with the value, so the rule ("a gate renders one server fact as received", ADR-API-SERVER-FACTS-0042) can hold across boundaries. ## How **Design, picked from three options.** A boolean with a phantom brand keyed by the API field: ```ts type ServerFact<Field extends string, T = boolean> = T & { readonly [serverFactKey]: Field } receiveServerFact(field, value) // the only constructor (one cast) narrowServerFact(fact, localAllows) // ADR rule 1: local UI state may withhold, never grant pendingServerFact(ticket, value) // now returns a ServerFact; call shape unchanged ``` A gate slot typed `ServerFact<'can_invite_members'>` rejects all of these at compile time: - `fact || local` - `fact && !isLoading` - `isCloud ? fact : x` - `!fact` - a plain boolean - another field's fact Reading a fact needs no unwrapping (`if (fact)`, `v-if`, a boolean prop), because its runtime value is the boolean. **Rejected options** (probed with `tsc --strict`; full table in the design note): - **An opaque `{ granted }` object read through `renderFact()`.** TypeScript accepts `obj || local`, so the #18662 shape compiles. Worse, `v-if="fact"` on an object is always truthy and vue-tsc doesn't check `v-if`, so one forgotten unwrap silently grants access. - **A ref-shaped alias.** It adds a name, not a guarantee. **Prototype on one surface.** - `useBillingCapabilities` `canInviteMembers` / `canManageMembers` return facts. - `useMembersPanel` `permissions` declares its four gate slots as facts and reads them from `useBillingCapabilities` directly; its `isCloud ? fact : role` lines are gone. The members panel is only registered on Cloud (`useSettingUI`), so the off-Cloud branch was unreachable and is deleted rather than given a local provider. The desktop visibility table in `useMembersPanel.test.ts` only exercised that branch and goes with it. - ADR-API-SERVER-FACTS-0042 now lists `ServerFact<Field>` as adopted surface by surface instead of deferred. - `serverFact.test.ts` proves each forbidden form with `@ts-expect-error`. **Limits.** - The guarantee holds only at slots typed as the fact. A `boolean`-typed gate or an inline template expression still accepts anything. - `factA && factB` assigned to `factB`'s slot compiles, and no encoding closes it. The lint stays required for that case, and a test covers it. ## AS IS / TO BE No UI or behaviour change. | Reintroduce #18662 (`canInviteMembers.value \|\| isPlanEnded.value`) into the gate | AS IS | TO BE | |---|---|---| | Typecheck | passes | `vue-tsc` TS2322 at the slot | | Orthogonality tests (#20694) | fail at runtime | fail at runtime | ## Decisions Resolved since the draft: 1. **Desktop/OSS member facts.** No local provider is needed: the members panel never renders off Cloud, so the role-and-seat fallback was dead code and is deleted. No lint exemption is added. 2. **ADR update.** Revised in this PR (Enforcement list and Alternatives considered). Decided as recommended (reversible): - Names `receiveServerFact` / `narrowServerFact`, so grep and lint targets stay unambiguous. - `pendingServerFact` keeps `(ticket, value)`, so the expiry script is unchanged. - Boolean facts only for now. ## Verification - `vitest run src/platform/serverFacts src/platform/workspace/composables tools/oxlint-plugins/serverFacts.test.ts`: 1140 passed on current main. - Mutation: the #18662 shape fails `vue-tsc` with TS2322 at the slot. - Found while prototyping: `receiveServerFact('x', true)` inferred the literal type `true`, which TypeScript treats as always truthy, so `fact || local` passed. Fixed by widening booleans in both constructors (`FactValue<T>`). The type test caught it. - `pnpm lint:server-facts --base <merge-base>`: no findings on changed lines. - `vitest run src/platform/workspace src/platform/serverFacts tools/oxlint-plugins`: 2950 passed. ## Plan position TDD: [Server-fact guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b). Parent: FE-3360. | Item | Ticket | PR | Status | |---|---|---|---| | L6 A1: render capability reads | FE-3366 | #20805 | Merged | | L6 lint rule refinement | FE-3366 | #20806 | Merged | | **L1 `ServerFact` type (members panel)** | **FE-3361** | **this PR** | **In review** | | L2 local providers | FE-3362 | — | Not started; the members panel needs none | | L1 migration of the remaining surfaces (seats, lifecycle, top-up, subscribe) | FE-3361 | — | After this lands | ```mermaid graph LR A1["L6 A1 (PR 20805, merged)"] --> L1["L1 ServerFact type (this PR)"]:::current R["L6 rules (PR 20806, merged)"] --> L1 L1 --> M["L1 migrate remaining surfaces"] classDef current fill:#f9d71c,stroke:#333,stroke-width:2px ```
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-13T15:02:11.542Z",
"gitSha": "72970cee76d708e0e25d813016926d1332ebcf0f",
"branch": "backport-20818-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.6849999999904,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0109999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 237.322,
"heapDeltaBytes": 903960,
"heapUsedBytes": 69154992,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.4190000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2010.3220000000306,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.222000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 244.11300000000003,
"heapDeltaBytes": 929936,
"heapUsedBytes": 69462724,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.801999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.9620000000127,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.968,
"layouts": 12,
"layoutDurationMs": 4.063000000000001,
"taskDurationMs": 491.33899999999994,
"heapDeltaBytes": -2087088,
"heapUsedBytes": 66022848,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 102.75899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1674.8329999999783,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.533000000000001,
"layouts": 12,
"layoutDurationMs": 3.9839999999999995,
"taskDurationMs": 476.45099999999996,
"heapDeltaBytes": -2390184,
"heapUsedBytes": 65763096,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 98.487,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.321999999982,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.561,
"layouts": 6,
"layoutDurationMs": 1.127,
"taskDurationMs": 209.519,
"heapDeltaBytes": 4139872,
"heapUsedBytes": 73106360,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.677999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.8349999999791,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.798999999999998,
"layouts": 6,
"layoutDurationMs": 1.257,
"taskDurationMs": 211.674,
"heapDeltaBytes": 4133104,
"heapUsedBytes": 72215536,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.215000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 476.8179999999802,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.098999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 298.042,
"heapDeltaBytes": -6537732,
"heapUsedBytes": 61639292,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 105.14199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 427.12000000000216,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.491999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.676,
"heapDeltaBytes": -6451132,
"heapUsedBytes": 61429696,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 104.348,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 994.2729999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.1930000000001,
"heapDeltaBytes": 42362224,
"heapUsedBytes": 114267392,
"domNodes": 0,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 41.81799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 371,
"frameDurationMs": 29.41176470588234,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 871.5329999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.73800000000006,
"heapDeltaBytes": 16094480,
"heapUsedBytes": 85748424,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 33.692999999999984,
"eventListeners": 0,
"totalBlockingTimeMs": 265,
"frameDurationMs": 25.979411764705873,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 687.7569999999764,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 261.2580000000002,
"heapDeltaBytes": 17733564,
"heapUsedBytes": 104452220,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 92.89499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 672.190999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 248.44399999999968,
"heapDeltaBytes": 16689956,
"heapUsedBytes": 103184484,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 86.189,
"eventListeners": 0,
"totalBlockingTimeMs": 81,
"frameDurationMs": 20.09411764705882,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5790.620999999987,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.6780000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4869.516,
"heapDeltaBytes": -2070484,
"heapUsedBytes": 83423848,
"domNodes": -143,
"jsHeapTotalBytes": -5115904,
"scriptDurationMs": 3917.2039999999997,
"eventListeners": -78,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.18351648351648,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5574.419000000034,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9919999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4806.717,
"heapDeltaBytes": 19629536,
"heapUsedBytes": 98128992,
"domNodes": -142,
"jsHeapTotalBytes": -4853760,
"scriptDurationMs": 3852.37,
"eventListeners": -78,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.989097744360905,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5235.130999999996,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.406000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4558.361,
"heapDeltaBytes": 9680588,
"heapUsedBytes": 94235152,
"domNodes": -142,
"jsHeapTotalBytes": -9310208,
"scriptDurationMs": 3598.241,
"eventListeners": -74,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.76626984126984,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5148.074000000008,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.261,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4442.460999999999,
"heapDeltaBytes": -16611104,
"heapUsedBytes": 68849684,
"domNodes": -143,
"jsHeapTotalBytes": -12718080,
"scriptDurationMs": 3521.7799999999997,
"eventListeners": -82,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.369444444444447,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2010.2849999999535,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.794999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 280.822,
"heapDeltaBytes": -9737984,
"heapUsedBytes": 78766572,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 20.470000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2010.879999999986,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.5000000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 274.16400000000004,
"heapDeltaBytes": -9771048,
"heapUsedBytes": 78465220,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 19.590000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2116.8870000000197,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.65,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1029.2400000000002,
"heapDeltaBytes": -18926168,
"heapUsedBytes": 70493052,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 557.3589999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2100.7589999999823,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.293,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1059.959,
"heapDeltaBytes": 12067564,
"heapUsedBytes": 92224420,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 602.552,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666400000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3085.9330000000114,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.896999999999998,
"layouts": 60,
"layoutDurationMs": 14.627999999999998,
"taskDurationMs": 1088.4049999999997,
"heapDeltaBytes": 1639600,
"heapUsedBytes": 69946528,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 528.384,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3138.181999999972,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.911999999999999,
"layouts": 60,
"layoutDurationMs": 14.730000000000002,
"taskDurationMs": 1095.51,
"heapDeltaBytes": -20639676,
"heapUsedBytes": 69434288,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 520.408,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665425531914895,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2166.3180000000466,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.920999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1244.1140000000003,
"heapDeltaBytes": 4292892,
"heapUsedBytes": 73041268,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 678.234,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665891472868214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2146.261999999979,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.354999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1198.829,
"heapDeltaBytes": 7631200,
"heapUsedBytes": 75974080,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 650.0550000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.4410000000053,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.508,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 276.08399999999995,
"heapDeltaBytes": -11091008,
"heapUsedBytes": 69195704,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 22.976999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.6129999999494,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.3159999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 293.093,
"heapDeltaBytes": -8452696,
"heapUsedBytes": 80713020,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 24.261000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 408.8339999999562,
"styleRecalcs": 50,
"styleRecalcDurationMs": 6.581999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 264.425,
"heapDeltaBytes": -11973284,
"heapUsedBytes": 57827608,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 96.39800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 427.5000000000091,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.569,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.99399999999997,
"heapDeltaBytes": -12307208,
"heapUsedBytes": 58215432,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 97.30299999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230772,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2010.313999999994,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.058,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 245.461,
"heapDeltaBytes": 1132268,
"heapUsedBytes": 71914948,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.2160000000000055,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.186999999964,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.0360000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 235.45499999999998,
"heapDeltaBytes": 1161576,
"heapUsedBytes": 71173308,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.115999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1672.28300000005,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.683,
"layouts": 16,
"layoutDurationMs": 5.345,
"taskDurationMs": 475.93600000000004,
"heapDeltaBytes": -6010324,
"heapUsedBytes": 62700784,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 77.86999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1674.4970000000308,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.317999999999998,
"layouts": 16,
"layoutDurationMs": 5.105,
"taskDurationMs": 457.4239999999999,
"heapDeltaBytes": -5931184,
"heapUsedBytes": 64899228,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 76.722,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 767.2709999999938,
"styleRecalcs": 18,
"styleRecalcDurationMs": 17.99,
"layouts": 5,
"layoutDurationMs": 8.248,
"taskDurationMs": 524.296,
"heapDeltaBytes": 1197608,
"heapUsedBytes": 94173104,
"domNodes": 14227,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 16.331,
"eventListeners": 2463,
"totalBlockingTimeMs": 50,
"frameDurationMs": 18.699999999999996,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8104.333999999994,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.201,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3554.934,
"heapDeltaBytes": 11592304,
"heapUsedBytes": 90626984,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 1887.3629999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66604938271605,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8122.990999999956,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.811,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3594.2879999999996,
"heapDeltaBytes": 8017292,
"heapUsedBytes": 96849236,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 1889.472,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666119096509238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11080.115999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10356.112,
"heapDeltaBytes": -21959524,
"heapUsedBytes": 181055240,
"domNodes": -3045,
"jsHeapTotalBytes": 6770688,
"scriptDurationMs": 139.923,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.692905405405405,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 11238.860000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10328.881000000001,
"heapDeltaBytes": -44399448,
"heapUsedBytes": 180780844,
"domNodes": -3045,
"jsHeapTotalBytes": 4825088,
"scriptDurationMs": 142.138,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.97449324324324,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-pan",
"durationMs": 14161.126999999964,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.806999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13584.252,
"heapDeltaBytes": -49615580,
"heapUsedBytes": 174995604,
"domNodes": -3045,
"jsHeapTotalBytes": 8466432,
"scriptDurationMs": 596.784,
"eventListeners": -14915,
"totalBlockingTimeMs": 1,
"frameDurationMs": 25.50845323741007,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 14380.669000000013,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.14399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13969.439999999999,
"heapDeltaBytes": -39462432,
"heapUsedBytes": 183648504,
"domNodes": -3045,
"jsHeapTotalBytes": 12951552,
"scriptDurationMs": 588.4010000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.69666666666667,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4638.313000000039,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.74300000000001,
"layouts": 20,
"layoutDurationMs": 21.07099999999999,
"taskDurationMs": 4264.844999999999,
"heapDeltaBytes": 14759268,
"heapUsedBytes": 214652712,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 68.76700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.179891304347823,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4313.613999999916,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.26200000000001,
"layouts": 20,
"layoutDurationMs": 22.286999999999995,
"taskDurationMs": 4203.027999999999,
"heapDeltaBytes": 1058992,
"heapUsedBytes": 213212168,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 67.14699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.442603550295853,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5694.675999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5304.84,
"heapDeltaBytes": -30841652,
"heapUsedBytes": 182017544,
"domNodes": -3045,
"jsHeapTotalBytes": 7294976,
"scriptDurationMs": 70.95600000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.38707482993197,
"p95FrameDurationMs": 33.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5792.554999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5434.949,
"heapDeltaBytes": -33217520,
"heapUsedBytes": 181779840,
"domNodes": -3045,
"jsHeapTotalBytes": 10231808,
"scriptDurationMs": 74.22599999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.34180602006689,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "workflow-execution",
"durationMs": 455.82500000000437,
"styleRecalcs": 20,
"styleRecalcDurationMs": 15.424000000000001,
"layouts": 3,
"layoutDurationMs": 1.4009999999999998,
"taskDurationMs": 94.526,
"heapDeltaBytes": 5820468,
"heapUsedBytes": 72304660,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.163,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 86.7680000000064,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.235,
"layouts": 2,
"layoutDurationMs": 0.576,
"taskDurationMs": 49.65800000000001,
"heapDeltaBytes": 3783312,
"heapUsedBytes": 68982480,
"domNodes": 94,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.450999999999997,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.680000000000017,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 425.7400000000189,
"styleRecalcs": 78,
"styleRecalcDurationMs": 77.705,
"layouts": 76,
"layoutDurationMs": 19.938000000000002,
"taskDurationMs": 391.769,
"heapDeltaBytes": -17589624,
"heapUsedBytes": 65628912,
"domNodes": 76,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 128.441,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 395.8860000000186,
"styleRecalcs": 78,
"styleRecalcDurationMs": 73.628,
"layouts": 76,
"layoutDurationMs": 17.499000000000002,
"taskDurationMs": 367.207,
"heapDeltaBytes": -17925024,
"heapUsedBytes": 66246064,
"domNodes": 76,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 118.70899999999999,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999984,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 875.2000000000635,
"styleRecalcs": 78,
"styleRecalcDurationMs": 230.844,
"layouts": 76,
"layoutDurationMs": 25.533,
"taskDurationMs": 845.953,
"heapDeltaBytes": 10609688,
"heapUsedBytes": 132883392,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 216.863,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307688,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 726.8699999999626,
"styleRecalcs": 78,
"styleRecalcDurationMs": 192.804,
"layouts": 76,
"layoutDurationMs": 22.83,
"taskDurationMs": 706.398,
"heapDeltaBytes": 9164640,
"heapUsedBytes": 126075212,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 177.142,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909075,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2201 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 496680b80365c18c85ae3819f8f389040d35ddcc
Full docs: ADR-DEVEX-LINT-0015 |
dante01yoon
left a comment
There was a problem hiding this comment.
Diff matches #20818 line for line.
|
🔗 Commit SHA: 124a716 | Docs | View more details | Give us feedback! |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.56 #20916 +/- ##
=============================================
Coverage ? 85.86%
=============================================
Files ? 2486
Lines ? 141708
Branches ? 36277
=============================================
Hits ? 121680
Misses ? 19644
Partials ? 384
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #20818 to
cloud/1.56Automatically created by backport workflow.