Repository navigation
[backport core/1.56] FE-3361 feat(server-facts): type member gates as ServerFact so a recombined gate fails to compile - #20915
Conversation
…mbined gate fails to compile (#20818) ## Why FE-3361 (L1, server-fact guardrails). The changed-line lint (#20679, refined in #20806) is syntactic. It loses a server fact once the fact crosses a function, file, prop or store boundary under another name (#19455 hid its derivation behind a helper). A type travels with the value, so the rule ("a gate renders one server fact as received", ADR-API-SERVER-FACTS-0042) can hold across boundaries. ## How **Design, picked from three options.** A boolean with a phantom brand keyed by the API field: ```ts type ServerFact<Field extends string, T = boolean> = T & { readonly [serverFactKey]: Field } receiveServerFact(field, value) // the only constructor (one cast) narrowServerFact(fact, localAllows) // ADR rule 1: local UI state may withhold, never grant pendingServerFact(ticket, value) // now returns a ServerFact; call shape unchanged ``` A gate slot typed `ServerFact<'can_invite_members'>` rejects all of these at compile time: - `fact || local` - `fact && !isLoading` - `isCloud ? fact : x` - `!fact` - a plain boolean - another field's fact Reading a fact needs no unwrapping (`if (fact)`, `v-if`, a boolean prop), because its runtime value is the boolean. **Rejected options** (probed with `tsc --strict`; full table in the design note): - **An opaque `{ granted }` object read through `renderFact()`.** TypeScript accepts `obj || local`, so the #18662 shape compiles. Worse, `v-if="fact"` on an object is always truthy and vue-tsc doesn't check `v-if`, so one forgotten unwrap silently grants access. - **A ref-shaped alias.** It adds a name, not a guarantee. **Prototype on one surface.** - `useBillingCapabilities` `canInviteMembers` / `canManageMembers` return facts. - `useMembersPanel` `permissions` declares its four gate slots as facts and reads them from `useBillingCapabilities` directly; its `isCloud ? fact : role` lines are gone. The members panel is only registered on Cloud (`useSettingUI`), so the off-Cloud branch was unreachable and is deleted rather than given a local provider. The desktop visibility table in `useMembersPanel.test.ts` only exercised that branch and goes with it. - ADR-API-SERVER-FACTS-0042 now lists `ServerFact<Field>` as adopted surface by surface instead of deferred. - `serverFact.test.ts` proves each forbidden form with `@ts-expect-error`. **Limits.** - The guarantee holds only at slots typed as the fact. A `boolean`-typed gate or an inline template expression still accepts anything. - `factA && factB` assigned to `factB`'s slot compiles, and no encoding closes it. The lint stays required for that case, and a test covers it. ## AS IS / TO BE No UI or behaviour change. | Reintroduce #18662 (`canInviteMembers.value \|\| isPlanEnded.value`) into the gate | AS IS | TO BE | |---|---|---| | Typecheck | passes | `vue-tsc` TS2322 at the slot | | Orthogonality tests (#20694) | fail at runtime | fail at runtime | ## Decisions Resolved since the draft: 1. **Desktop/OSS member facts.** No local provider is needed: the members panel never renders off Cloud, so the role-and-seat fallback was dead code and is deleted. No lint exemption is added. 2. **ADR update.** Revised in this PR (Enforcement list and Alternatives considered). Decided as recommended (reversible): - Names `receiveServerFact` / `narrowServerFact`, so grep and lint targets stay unambiguous. - `pendingServerFact` keeps `(ticket, value)`, so the expiry script is unchanged. - Boolean facts only for now. ## Verification - `vitest run src/platform/serverFacts src/platform/workspace/composables tools/oxlint-plugins/serverFacts.test.ts`: 1140 passed on current main. - Mutation: the #18662 shape fails `vue-tsc` with TS2322 at the slot. - Found while prototyping: `receiveServerFact('x', true)` inferred the literal type `true`, which TypeScript treats as always truthy, so `fact || local` passed. Fixed by widening booleans in both constructors (`FactValue<T>`). The type test caught it. - `pnpm lint:server-facts --base <merge-base>`: no findings on changed lines. - `vitest run src/platform/workspace src/platform/serverFacts tools/oxlint-plugins`: 2950 passed. ## Plan position TDD: [Server-fact guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b). Parent: FE-3360. | Item | Ticket | PR | Status | |---|---|---|---| | L6 A1: render capability reads | FE-3366 | #20805 | Merged | | L6 lint rule refinement | FE-3366 | #20806 | Merged | | **L1 `ServerFact` type (members panel)** | **FE-3361** | **this PR** | **In review** | | L2 local providers | FE-3362 | — | Not started; the members panel needs none | | L1 migration of the remaining surfaces (seats, lifecycle, top-up, subscribe) | FE-3361 | — | After this lands | ```mermaid graph LR A1["L6 A1 (PR 20805, merged)"] --> L1["L1 ServerFact type (this PR)"]:::current R["L6 rules (PR 20806, merged)"] --> L1 L1 --> M["L1 migrate remaining surfaces"] classDef current fill:#f9d71c,stroke:#333,stroke-width:2px ```
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-13T15:06:30.828Z",
"gitSha": "6f046a4346a1530ac34b2f7b6b864e04a8c4efe4",
"branch": "backport-20818-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2015.1870000000258,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.581,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.9510000000001,
"heapDeltaBytes": 1008288,
"heapUsedBytes": 68714112,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.328000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2025.3609999999753,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.861000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.11799999999994,
"heapDeltaBytes": 1126132,
"heapUsedBytes": 69405512,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.841000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1850.409999999954,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.133000000000003,
"layouts": 12,
"layoutDurationMs": 4.737,
"taskDurationMs": 885.461,
"heapDeltaBytes": -2069632,
"heapUsedBytes": 66078432,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 179.272,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1845.9620000000996,
"styleRecalcs": 75,
"styleRecalcDurationMs": 20.378,
"layouts": 12,
"layoutDurationMs": 4.819999999999999,
"taskDurationMs": 884.9580000000001,
"heapDeltaBytes": -2096356,
"heapUsedBytes": 66979928,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 181.69999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765762,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.9349999999772,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.254,
"layouts": 6,
"layoutDurationMs": 1.2689999999999997,
"taskDurationMs": 353.93999999999994,
"heapDeltaBytes": 4102444,
"heapUsedBytes": 72269560,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.948,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352933,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1743.6680000000706,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.299000000000001,
"layouts": 6,
"layoutDurationMs": 1.1210000000000002,
"taskDurationMs": 383.201,
"heapDeltaBytes": 4171172,
"heapUsedBytes": 71410432,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.089999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 711.0910000000104,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.468,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.38599999999997,
"heapDeltaBytes": -7382352,
"heapUsedBytes": 61129036,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 177.785,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 753.7909999999783,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.339,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.925,
"heapDeltaBytes": -6502376,
"heapUsedBytes": 61028180,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 185.61100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1191.9990000000098,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 880.8069999999999,
"heapDeltaBytes": 38446552,
"heapUsedBytes": 108122608,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 73.28099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 559,
"frameDurationMs": 35.86060606060605,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1156.690000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 808.9569999999999,
"heapDeltaBytes": 14870888,
"heapUsedBytes": 85509544,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 68.77699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 517,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 890.8490000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.388,
"heapDeltaBytes": 17742428,
"heapUsedBytes": 105737580,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 172.73000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 236,
"frameDurationMs": 25.23999999999999,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 864.0000000000327,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.421,
"heapDeltaBytes": 17882548,
"heapUsedBytes": 103855012,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 162.54300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 25.491176470588204,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10384.505999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9423.559000000001,
"heapDeltaBytes": -14003176,
"heapUsedBytes": 70811524,
"domNodes": -172,
"jsHeapTotalBytes": -4591616,
"scriptDurationMs": 7756.561,
"eventListeners": -78,
"totalBlockingTimeMs": 1251,
"frameDurationMs": 33.60161812297735,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8913.361000000008,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9509999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8200.876,
"heapDeltaBytes": -16671700,
"heapUsedBytes": 67846732,
"domNodes": -142,
"jsHeapTotalBytes": -11669504,
"scriptDurationMs": 6926.713,
"eventListeners": -74,
"totalBlockingTimeMs": 928,
"frameDurationMs": 34.96627450980392,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10412.91799999999,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4230000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9505.873000000001,
"heapDeltaBytes": 2944528,
"heapUsedBytes": 71877328,
"domNodes": -142,
"jsHeapTotalBytes": -9048064,
"scriptDurationMs": 7853.321999999999,
"eventListeners": -74,
"totalBlockingTimeMs": 1119,
"frameDurationMs": 32.65297805642633,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10576.203000000078,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9708.314999999999,
"heapDeltaBytes": -2120516,
"heapUsedBytes": 77013396,
"domNodes": -142,
"jsHeapTotalBytes": -921600,
"scriptDurationMs": 8066.467,
"eventListeners": -78,
"totalBlockingTimeMs": 1404,
"frameDurationMs": 33.757827476038344,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2021.9129999999836,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.0730000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.4659999999999,
"heapDeltaBytes": -7072412,
"heapUsedBytes": 78412380,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 39.673999999999985,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2021.545999999944,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.646,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.445,
"heapDeltaBytes": -9799892,
"heapUsedBytes": 79071728,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 36.051,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2743.4600000000273,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.911999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1671.828,
"heapDeltaBytes": -19964744,
"heapUsedBytes": 69023004,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 887.565,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.768098159509208,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2863.96400000001,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.021,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1711.0909999999997,
"heapDeltaBytes": -18026700,
"heapUsedBytes": 71448336,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 907.184,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66549707602339,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3851.175000000012,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.688,
"layouts": 60,
"layoutDurationMs": 15.463000000000001,
"taskDurationMs": 1775.3770000000002,
"heapDeltaBytes": 1619652,
"heapUsedBytes": 68552644,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 838.954,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66536796536797,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3788.3620000000064,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.497,
"layouts": 60,
"layoutDurationMs": 14.639,
"taskDurationMs": 1733.495,
"heapDeltaBytes": 1631992,
"heapUsedBytes": 69830212,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 819.802,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66578947368421,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3236.4410000000134,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.094000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2101.272,
"heapDeltaBytes": 9701952,
"heapUsedBytes": 78145732,
"domNodes": 0,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 1120.613,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.8390625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3141.881000000012,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.519999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1945.0430000000001,
"heapDeltaBytes": 8586592,
"heapUsedBytes": 77659092,
"domNodes": 0,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 1016.899,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.754545454545458,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.0260000000012,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.207999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.3229999999999,
"heapDeltaBytes": -9446688,
"heapUsedBytes": 80633832,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 39.720000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2022.277000000031,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.125999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.0190000000001,
"heapDeltaBytes": -9867944,
"heapUsedBytes": 79707416,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 38.246,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 640.8389999999713,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.887999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.8539999999999,
"heapDeltaBytes": -12061080,
"heapUsedBytes": 58017208,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 148.49499999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 674.0250000000287,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.669999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.983,
"heapDeltaBytes": 10697328,
"heapUsedBytes": 74762400,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 152.641,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.9790000000207,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.351000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.66799999999995,
"heapDeltaBytes": -2662032,
"heapUsedBytes": 61221888,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.807,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2023.0419999999185,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.163999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.53899999999993,
"heapDeltaBytes": -2378272,
"heapUsedBytes": 61469744,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.16,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.4059999999936,
"styleRecalcs": 77,
"styleRecalcDurationMs": 20.362,
"layouts": 16,
"layoutDurationMs": 6.061,
"taskDurationMs": 815.615,
"heapDeltaBytes": -5939292,
"heapUsedBytes": 63762760,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 120.88199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1713.5060000000522,
"styleRecalcs": 76,
"styleRecalcDurationMs": 19.712,
"layouts": 16,
"layoutDurationMs": 6.304,
"taskDurationMs": 835.893,
"heapDeltaBytes": -5967572,
"heapUsedBytes": 64140064,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 122.076,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1433.4869999999,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.77400000000001,
"layouts": 5,
"layoutDurationMs": 15.879000000000001,
"taskDurationMs": 1050.977,
"heapDeltaBytes": 30825712,
"heapUsedBytes": 104690044,
"domNodes": 14227,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 36.41599999999999,
"eventListeners": 2463,
"totalBlockingTimeMs": 146,
"frameDurationMs": 19.36756756756755,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9444.837000000007,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.327,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6098.205,
"heapDeltaBytes": 18047272,
"heapUsedBytes": 106562492,
"domNodes": 0,
"jsHeapTotalBytes": 1015808,
"scriptDurationMs": 3107.085,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.695575221238936,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9116.427000000043,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.080000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5846.531,
"heapDeltaBytes": -18707496,
"heapUsedBytes": 70093160,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2876.083,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69652014652015,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18479.615999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17656.582,
"heapDeltaBytes": -43750316,
"heapUsedBytes": 177649040,
"domNodes": -3045,
"jsHeapTotalBytes": -942080,
"scriptDurationMs": 306.623,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.172695652173914,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 17805.57600000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17063.501,
"heapDeltaBytes": -33471248,
"heapUsedBytes": 179273384,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 276.31600000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.664199655765923,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 22787.017000000047,
"styleRecalcs": 178,
"styleRecalcDurationMs": 23.63399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22426.153,
"heapDeltaBytes": -32312700,
"heapUsedBytes": 167422908,
"domNodes": -3046,
"jsHeapTotalBytes": 5787648,
"scriptDurationMs": 909.8290000000001,
"eventListeners": -14919,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.583925233644855,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 22884.608000000073,
"styleRecalcs": 180,
"styleRecalcDurationMs": 22.402000000000033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22459.428,
"heapDeltaBytes": -43142456,
"heapUsedBytes": 175193864,
"domNodes": -3045,
"jsHeapTotalBytes": -942080,
"scriptDurationMs": 945.299,
"eventListeners": -14915,
"totalBlockingTimeMs": 46,
"frameDurationMs": 42.53252788104089,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6369.141999999954,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.52100000000004,
"layouts": 20,
"layoutDurationMs": 24.00999999999999,
"taskDurationMs": 6276.927,
"heapDeltaBytes": 1053152,
"heapUsedBytes": 214602824,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 111.591,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.670414201183426,
"p95FrameDurationMs": 66.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6345.882000000074,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.19799999999996,
"layouts": 20,
"layoutDurationMs": 23.887000000000004,
"taskDurationMs": 6230.195,
"heapDeltaBytes": -12806572,
"heapUsedBytes": 213980276,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 110.218,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.15060240963855,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8965.237000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8651.821000000002,
"heapDeltaBytes": -33629376,
"heapUsedBytes": 179709572,
"domNodes": -3045,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 159.31,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.861034482758622,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8700.566999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8406.936,
"heapDeltaBytes": -32795564,
"heapUsedBytes": 180692372,
"domNodes": -3045,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 128.53500000000005,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.292255892255902,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 491.75900000000183,
"styleRecalcs": 20,
"styleRecalcDurationMs": 19.610000000000003,
"layouts": 5,
"layoutDurationMs": 2.2140000000000004,
"taskDurationMs": 145.971,
"heapDeltaBytes": 5926800,
"heapUsedBytes": 71690300,
"domNodes": 129,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.263000000000005,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 108.15200000001823,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.756,
"layouts": 4,
"layoutDurationMs": 1.885,
"taskDurationMs": 79.65899999999998,
"heapDeltaBytes": 3710556,
"heapUsedBytes": 69481852,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.333000000000005,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.683333333333394,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1099.154999999996,
"styleRecalcs": 78,
"styleRecalcDurationMs": 118.161,
"layouts": 76,
"layoutDurationMs": 29.602,
"taskDurationMs": 1076.556,
"heapDeltaBytes": 19667488,
"heapUsedBytes": 86792192,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 452.717,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668181818181825,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1063.5989999999538,
"styleRecalcs": 78,
"styleRecalcDurationMs": 111.471,
"layouts": 76,
"layoutDurationMs": 29.218,
"taskDurationMs": 1031.2709999999997,
"heapDeltaBytes": 19472212,
"heapUsedBytes": 86028900,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 421.505,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66507936507936,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1442.0350000000326,
"styleRecalcs": 78,
"styleRecalcDurationMs": 264.01599999999996,
"layouts": 76,
"layoutDurationMs": 29.087,
"taskDurationMs": 1412.17,
"heapDeltaBytes": 8495808,
"heapUsedBytes": 114980384,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 467.996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.14430379746835,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1470.2149999999392,
"styleRecalcs": 78,
"styleRecalcDurationMs": 273.48,
"layouts": 76,
"layoutDurationMs": 29.744,
"taskDurationMs": 1446.647,
"heapDeltaBytes": 8659708,
"heapUsedBytes": 115513740,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 481.18,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.332500000000003,
"p95FrameDurationMs": 33.29999999999927
}
]
}🎭 Playwright: ✅ 2202 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since efdcc58857d853ad10eeea7e86559755aecb6604
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
dante01yoon
left a comment
There was a problem hiding this comment.
Diff matches #20818 line for line.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.56 #20915 +/- ##
=============================================
- Coverage 85.94% 85.93% -0.01%
=============================================
Files 2477 2478 +1
Lines 141456 141459 +3
Branches 38508 36531 -1977
=============================================
- Hits 121570 121566 -4
- Misses 19503 19509 +6
- Partials 383 384 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #20818 to
core/1.56Automatically created by backport workflow.