Skip to content

feat(website): Move anything app, an image editor with a floating side panel - #20854

Open
mariana953 wants to merge 17 commits into
mariana/editor-kitfrom
mariana/app-move-anything
Open

mariana953 wants to merge 17 commits into
mariana/editor-kitfrom
mariana/app-move-anything

Conversation

@mariana953

@mariana953 mariana953 commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds Move anything as a Workshop app at /hub/apps/move-anything/, built on the shared editor kit (#20630). The visitor drags the things in a photo somewhere new and the model rebuilds the scene around them. The UI is complete; the run is mocked until the backend exists. Replaces #19758, and no longer sits under or over any other app.

Changes

  • What:
    • Layout. Uses the kit's floating side panel: photo row, Quality, Seed, Advanced and the run button with its cost. Tool pill under the photo (Move, Smart select, Box select, undo, redo), zoom bottom right, slim header with Back, title, GitHub and Download. Phones get a bottom sheet. ?ux=e keeps a bottom-composer variant for review.
    • Arranging. The example detects its three things; on an uploaded photo the visitor selects up to 4 with Smart or Box select. Chips rename or remove a thing. Drag or arrow-nudge to move (Shift goes further); a dashed ghost marks where it was. Undo and redo cover every change.
    • Run and result. A named wait over the photo, the run button becomes Cancel, the result opens on a before-and-after slider and Download unlocks.
    • Mock. runMove in lib/workshop/move-anything/mock-run.ts waits about 2 seconds and answers with the prepared result or the visitor's photo. MOVE_CREDITS is a placeholder.
    • Wiring. Catalogue, routes, hub names, Hub card, redirects. Gated by workshop-move-anything-app-enabled through workshop-model-availability.json.
    • Tests. Unit tests for the box maths, nudge, page state and the page; E2E for flag off, the panel flow, bottom composer, chips, phone sheet and hidden site header.
  • Dependencies: feat(website): shared full-screen editor pieces for the Workshop apps #20630 (editor kit)

Review Focus

  • Backend contract. MoveRequest holds the image URL, each object's from and to boxes as fractions of the image, and the quality; it returns { url, seed }. Detection on the example is prepared, so uploads have no detection yet.
  • Shared files. Editor kit pieces are untouched here. Like every app, it adds one entry to the shared lists (catalogue, routes, names, locales), so sibling app PRs may need a small merge as they land.
  • Shared with the other app PRs. The app registers itself in the kit's EDITOR_APPS list on the studio page (one entry), and its copy goes through lib/workshop/app-copy.ts. Shared helpers (app-copy.ts, and where used load-image.ts, nudge.ts, useSnapshotHistory.ts) are identical in every app PR, so they merge cleanly whichever lands first.

Screenshots (if applicable)

Preview (once deployed): https://comfy-website-preview-pr-20854.vercel.app/hub/apps/move-anything/


Generated by Claude Code

@mariana953
mariana953 requested review from a team and dante01yoon as code owners October 12, 2026 18:59
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: e763d067-8acd-46ba-b923-817afa895b65

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since fa6d451f5d507b9e31956425e939e0ee8d12cd1d

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-20854.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-2wtv33d40-comfyui.vercel.app

Last updated: 2026-10-14T01:00:33Z for 16d1506

@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.15044% with 40 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nents/workshop/move-anything/MoveAnythingStage.vue 79.16% 5 Missing and 5 partials ⚠️
apps/website/src/composables/useMoveAnything.ts 93.10% 1 Missing and 9 partials ⚠️
...onents/workshop/move-anything/MoveAnythingDock.vue 71.42% 3 Missing and 1 partial ⚠️
...ponents/workshop/move-anything/MoveAnythingBox.vue 96.00% 1 Missing and 1 partial ⚠️
...onents/workshop/move-anything/MoveAnythingMain.vue 71.42% 1 Missing and 1 partial ⚠️
...ts/workshop/move-anything/MoveAnythingOutlines.vue 77.77% 0 Missing and 2 partials ⚠️
...ents/workshop/move-anything/MoveAnythingStudio.vue 91.30% 1 Missing and 1 partial ⚠️
...nts/workshop/move-anything/MoveAnythingSummary.vue 50.00% 0 Missing and 2 partials ⚠️
...s/workshop/move-anything/MoveAnythingWorkspace.vue 88.23% 0 Missing and 2 partials ⚠️
...nents/workshop/move-anything/MoveAnythingPanel.vue 93.75% 0 Missing and 1 partial ⚠️
... and 3 more
@@                  Coverage Diff                  @@
##             mariana/editor-kit   #20854   +/-   ##
=====================================================
  Coverage                      ?   86.19%           
=====================================================
  Files                         ?     3637           
  Lines                         ?   172889           
  Branches                      ?    47498           
=====================================================
  Hits                          ?   149030           
  Misses                        ?    21934           
  Partials                      ?     1925           
Flag Coverage Δ
website-unit 80.81% <91.15%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ebsite/src/components/workshop/ModelsCatalogue.vue 100.00% <100.00%> (ø)
.../workshop/cinematic-studio/CinematicStudioPage.vue 91.46% <100.00%> (ø)
...s/workshop/move-anything/MoveAnythingDetecting.vue 100.00% <100.00%> (ø)
...nents/workshop/move-anything/MoveAnythingDocks.vue 100.00% <100.00%> (ø)
...nts/workshop/move-anything/MoveAnythingHistory.vue 100.00% <100.00%> (ø)
...nts/workshop/move-anything/MoveAnythingQuality.vue 100.00% <100.00%> (ø)
...ponents/workshop/move-anything/MoveAnythingRun.vue 100.00% <100.00%> (ø)
...nents/workshop/move-anything/MoveAnythingTools.vue 100.00% <100.00%> (ø)
...ite/src/components/workshop/move-anything/tools.ts 100.00% <100.00%> (ø)
apps/website/src/config/models-catalogue-data.ts 100.00% <ø> (ø)
... and 21 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 12, 2026
# Conflicts:
#	apps/website/src/components/workshop/cinematic-studio/CinematicStudioPage.vue

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The app is well put together on the kit, and the arrange maths and composable have solid unit coverage. Requesting changes for the copy approach (applies to all the stacked app PRs), internal comments, and one undo bug.

Size. This PR is about 3,000 lines (excluding binaries). That is far past the ~300-line guideline and hard to review well in one pass. Could you split it, e.g. (1) wiring: catalogue, routes, flag, Hub card; (2) pure lib/ logic with its tests; (3) components and e2e?

Stacking. Base is mariana/editor-kit (#20630), which is still open with changes requested. Every app PR edits the same shared lists (routes.ts, apps.ts, catalogue-apps.ts, CinematicStudioPage.vue, schema enums, locales, vercel.json), so they will conflict with each other as they land. The identical helpers (app-copy.ts, load-image.ts, useSnapshotHistory.ts, nudge.ts) would be better landed once in #20630 than duplicated in every app branch.

Checks: CI is green; I didn't run tests locally.

named: CopyValues = {}
): string {
const [one, many = one] = (entry[locale] ?? entry.en).split(' | ')
return (named.n === 1 ? one : many).replace(

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: appCopy fills placeholders with .replace and parses | plurals by hand, and the app's strings live in a TS copy.ts instead of src/locales/<locale>/main.json. apps/website/AGENTS.md says copy goes in main.json and is read with translationsFor(locale).t, and to "never fill a placeholder with .replace". Doing it this way also skips the catalog test that compiles each message and checks zh-CN coverage. It also treats a literal {word} the visitor types (a star name, a light name) as a placeholder whenever named has that key.

Could the app's strings move under a namespaced key in main.json (moveAnything.*, relight.*, …) and be read through t(key, named, { locale })? If keeping them out of the site-wide bundle is the real goal (as for catalogue-apps.ts), please get that exception agreed on #20630 first, where all seven apps can share it, without hand-rolled interpolation.

/** Move anything's page state. The run itself is `runMove`, mocked for now. */
export function useMoveAnything(locale: Locale = 'en') {
const image = shallowRef<MoveImage>()
/** The photo taken out last, with its objects, kept so it can be put back. */

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: this PR adds comments to internal, non-exported code, like this one and the others on inner functions of this composable. The repo rule only allows a short JSDoc on exported API. Please drop the internal ones and let the names carry the meaning.

if (tool !== 'move') return
event.preventDefault()
emit('select', object.id)
emit('begin')

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: grab emits begin (→ move.checkpoint()) on every pointerdown with the Move tool, before anything moves. Clicking a box just to select it pushes a snapshot identical to the current objects. The visitor then presses Undo, nothing visibly changes, and they have to press it again. Repro: open the example, click the kitten box without dragging, press Undo; the step is a no-op. Could the checkpoint be taken on the first place of a gesture, or skipped when the drag ends with to unchanged? A composable/page test for "select then undo" would lock it in. (CONFIRMED)

/** The photo taken out last, with its objects, kept so it can be put back. */
const removed = shallowRef<{ image: MoveImage; objects: MoveObject[] }>()
const objects = ref<MoveObject[]>([])
const past = shallowRef<MoveObject[][]>([])

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: this is a hand-rolled copy of useSnapshotHistory (added identically in the sibling app PRs), and Hand product swap and Sprite sheet each carry another one. Using the shared composable here would remove ~25 lines and keep undo semantics the same across apps.


export type MoveQuality = 'fast' | 'best'

export interface MoveRequest {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: MoveRequest is a hand-written request/response contract for a backend that doesn't exist yet. Is there a tracking issue for the endpoint? Once it ships in the OpenAPI spec, these types should be imported from @comfyorg/ingest-types rather than kept by hand. Could you link the issue here (or in the PR body) so the swap isn't forgotten?

const move = useMoveAnything(locale)
const { image, removed, phase } = move
const view = ref<MoveView>('compare')
const panel = computed(() => layout !== 'e')

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: ?ux=e keeps a second, review-only layout (bottom composer + trays) in production code and in the e2e suite. Once the team picks a layout, could the other one be removed? Each app carries roughly a third more components and tests for a variant visitors aren't meant to use.

This branch was previously deployed

1 inactive deployment
website-approval — 16d15068 Deployed Oct 14, 2026 by mariana953 via fast-lane #1912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants