Repository navigation
[backport cloud/1.56] FE-3381 fix(auth): ask for a new login when the session sign-in was revoked - #20847
Conversation
…evoked (#20834) ## Why Prod RUM, right after the 2026-10-12 web-session rollout: a Desktop (Electron) user got "Couldn't load your workspace / Check your connection and try again." and pressed Try again for about 12 minutes before logging out (Datadog issue `8fe722d4`, first seen 12:57Z). Retrying can never succeed, so the screen sends the user into a loop. ## Root cause Ingest refused `POST /api/auth/session` with `401 SESSION_REVOKED` ("This session was signed out; sign in again"). It returns this when the remembered Firebase sign-in predates a revocation of the user's sessions (`websession.ErrSignInPredatesRevocation`, cloud `services/ingest/server/implementation/auth.go`). `useSessionCookie.readSessionError` turned every non-SSO refusal into a plain `Error`, so `WorkspaceAuthGate` classified it as retryable. Each retry replays the same stale sign-in and gets the same 401. ## How - `readSessionError` maps `401` + `code: SESSION_REVOKED` to a typed `SessionRevokedError`. The code comes from the server as received; nothing is derived on the client. - `WorkspaceAuthGate` treats `SessionRevokedError` as non-retryable. The existing non-retryable panel then shows "Sign out and log in again to continue." with only Log Out. - Tests: a table on `ensureSessionCookie` (401 SESSION_REVOKED → typed, 401 UNAUTHORIZED and 403 SESSION_REVOKED → plain), and two rows in the gate's error table (SSO on/off). Red/green: locally the test commit (b567414) fails exactly the 3 new cases and the fix (ceefcd5) passes all 64. On CI the test-only commit's unit job was skipped because fallow flagged an unused class member, so the red is local only. ## AS IS / TO BE | AS IS (`origin/main`) | TO BE (this PR) | |---|---| | <img width="480" alt="AS IS: Couldn't load your workspace, Check your connection and try again, Try again + Log Out" src="https://github.com/user-attachments/assets/e8f289e3-cc1d-44a4-977a-d6e74cba7937" /> | <img width="480" alt="TO BE: Couldn't load your workspace, Sign out and log in again to continue, Log Out only" src="https://github.com/user-attachments/assets/8c2aa720-22d3-4a11-8455-dad1fea55fee" /> | | "Check your connection and try again." + Try again | "Sign out and log in again to continue." + Log Out only | Captured in the real cloud app (local dev server, signed-in session against cloud.comfy.org). Only `POST /api/auth/session` was stubbed (in-page `fetch` override) to return `401 {"code":"SESSION_REVOKED","message":"This session was signed out; sign in again"}`; every other request hit the real backend. Same session and stub for both shots; only the two changed source files differ. ## Plan position | Step | Item | State | |---|---|---| | 1 | Prod flags: session 20%, billing_web 20% | Done 2026-10-12 | | 2 | RUM rollout watch | Running | | 3 | FE-3380: report `unified_web_session` to RUM (#20831) | In review | | **4** | **This PR: revoked sign-in asks for a new login** | **This PR** | | 5 | 1.56 backport of 3 and 4, then ramp decision | After merge | ```mermaid flowchart LR A[Prod flags 20%] --> B[RUM watch] B --> C[FE-3380 RUM cohort tag] B --> D[This PR: SESSION_REVOKED → log in again]:::me C --> E[1.56 backport] D --> E E --> F[Ramp decision] classDef me fill:#f9d71c,stroke:#333,color:#000 ``` - Fixes FE-3381
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-12T18:19:25.416Z",
"gitSha": "bee3382079a36de9462e1fe90c2a41a335d6227c",
"branch": "backport-20834-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.5000000000173,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.680000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.56299999999993,
"heapDeltaBytes": 870904,
"heapUsedBytes": 69731184,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.715,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2014.3929999999273,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.435000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.974,
"heapDeltaBytes": 903500,
"heapUsedBytes": 68786568,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.21899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1783.2760000000007,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.089,
"layouts": 12,
"layoutDurationMs": 4.188000000000001,
"taskDurationMs": 781.1029999999998,
"heapDeltaBytes": -2007756,
"heapUsedBytes": 65600948,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 159.08,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.82264150943396,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1769.1010000000915,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.116,
"layouts": 12,
"layoutDurationMs": 4.231999999999999,
"taskDurationMs": 778.5849999999999,
"heapDeltaBytes": -2090952,
"heapUsedBytes": 65738612,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 161.192,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1696.6919999999845,
"styleRecalcs": 29,
"styleRecalcDurationMs": 8.848,
"layouts": 6,
"layoutDurationMs": 1.136,
"taskDurationMs": 339.999,
"heapDeltaBytes": 4113464,
"heapUsedBytes": 72141936,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.219999999999994,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.246999999954,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.078000000000001,
"layouts": 6,
"layoutDurationMs": 1.0569999999999997,
"taskDurationMs": 337.974,
"heapDeltaBytes": 4123676,
"heapUsedBytes": 72528852,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.206000000000007,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 675.5019999999945,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.849,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.30899999999997,
"heapDeltaBytes": -6735048,
"heapUsedBytes": 61060128,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 161.556,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 706.0759999999391,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.883000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.78299999999996,
"heapDeltaBytes": -7098148,
"heapUsedBytes": 61443648,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 163.545,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1144.3629999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 797.74,
"heapDeltaBytes": 38288036,
"heapUsedBytes": 108162648,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 72.84199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 509,
"frameDurationMs": 34.34242424242425,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1152.2640000000592,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 821.6850000000001,
"heapDeltaBytes": 16253988,
"heapUsedBytes": 85091184,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 68.36,
"eventListeners": 0,
"totalBlockingTimeMs": 531,
"frameDurationMs": 34.84848484848485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.199999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.07599999999974,
"heapDeltaBytes": 17640732,
"heapUsedBytes": 105850788,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 155.92099999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.4640000000691,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.3059999999996,
"heapDeltaBytes": 17663392,
"heapUsedBytes": 105197520,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 164.47100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 25.488235294117604,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9661.941999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8832.042,
"heapDeltaBytes": -17071488,
"heapUsedBytes": 68168952,
"domNodes": -142,
"jsHeapTotalBytes": -11407360,
"scriptDurationMs": 7278.536,
"eventListeners": -78,
"totalBlockingTimeMs": 801,
"frameDurationMs": 33.73986013986014,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9827.129000000014,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3999999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9016.362,
"heapDeltaBytes": 7108760,
"heapUsedBytes": 84884972,
"domNodes": -142,
"jsHeapTotalBytes": -8523776,
"scriptDurationMs": 7444.453,
"eventListeners": -74,
"totalBlockingTimeMs": 886,
"frameDurationMs": 32.612292358803984,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9084.127000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8280.087,
"heapDeltaBytes": -13024244,
"heapUsedBytes": 71835180,
"domNodes": -142,
"jsHeapTotalBytes": -11407360,
"scriptDurationMs": 6762.822,
"eventListeners": -74,
"totalBlockingTimeMs": 599,
"frameDurationMs": 32.20957446808511,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9127.68200000005,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3309999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8399.038,
"heapDeltaBytes": -1244960,
"heapUsedBytes": 83787380,
"domNodes": -142,
"jsHeapTotalBytes": -11407360,
"scriptDurationMs": 6921.215,
"eventListeners": -78,
"totalBlockingTimeMs": 666,
"frameDurationMs": 32.79208633093525,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2014.1490000000317,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.19,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.49700000000007,
"heapDeltaBytes": -9534148,
"heapUsedBytes": 79470308,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 26.683,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2019.7919999999385,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.1789999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.0640000000001,
"heapDeltaBytes": -7157212,
"heapUsedBytes": 77689880,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 29.772999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2213.072000000011,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.844000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1518.139,
"heapDeltaBytes": -20938628,
"heapUsedBytes": 68917500,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 833.6049999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793181818181825,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2246.723999999972,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.195,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1525.029,
"heapDeltaBytes": -18764096,
"heapUsedBytes": 70420864,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 834.526,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791043,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3620.8089999999515,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.863,
"layouts": 60,
"layoutDurationMs": 14.077,
"taskDurationMs": 1637.909,
"heapDeltaBytes": 914452,
"heapUsedBytes": 69996072,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 792.1199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666359447004606,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3601.992999999993,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.176,
"layouts": 60,
"layoutDurationMs": 14.048,
"taskDurationMs": 1651.692,
"heapDeltaBytes": 1745296,
"heapUsedBytes": 70741536,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 816.773,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662037037037,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3135.7150000000047,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.909000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1910.4420000000002,
"heapDeltaBytes": 6718188,
"heapUsedBytes": 75778072,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 1027.585,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.754545454545458,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3140.52700000002,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.228999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1883.6169999999997,
"heapDeltaBytes": -14374604,
"heapUsedBytes": 69230940,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 1013.4110000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755080213903746,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.2220000000038,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.344,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.707,
"heapDeltaBytes": 13443640,
"heapUsedBytes": 81589564,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.042999999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2007.6439999999138,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.3030000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.6340000000001,
"heapDeltaBytes": -8990488,
"heapUsedBytes": 80756176,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 26.18000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 609.3989999999962,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.078,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.82699999999994,
"heapDeltaBytes": -11981136,
"heapUsedBytes": 58127580,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 145.41700000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 601.7640000000029,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.878999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.22999999999996,
"heapDeltaBytes": -12340016,
"heapUsedBytes": 58051840,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 143.40200000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.3209999999767,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.7660000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.80800000000005,
"heapDeltaBytes": 1069112,
"heapUsedBytes": 71908968,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.241000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.1430000000564,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.031,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.55600000000004,
"heapDeltaBytes": 1062720,
"heapUsedBytes": 72070348,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.842000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.0429999999983,
"styleRecalcs": 60,
"styleRecalcDurationMs": 17.037999999999997,
"layouts": 16,
"layoutDurationMs": 5.478999999999999,
"taskDurationMs": 719.6270000000001,
"heapDeltaBytes": -5949444,
"heapUsedBytes": 63261432,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 110.048,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.2760000000353,
"styleRecalcs": 76,
"styleRecalcDurationMs": 19.84,
"layouts": 16,
"layoutDurationMs": 5.975,
"taskDurationMs": 768.3960000000001,
"heapDeltaBytes": 16725780,
"heapUsedBytes": 77981696,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.085,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.6470000000254,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.681000000000004,
"layouts": 5,
"layoutDurationMs": 13.964000000000004,
"taskDurationMs": 896.1649999999998,
"heapDeltaBytes": 3149380,
"heapUsedBytes": 99160716,
"domNodes": 14227,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 29.583,
"eventListeners": 2463,
"totalBlockingTimeMs": 131,
"frameDurationMs": 19.14189189189189,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8486.887000000024,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.814,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5523.854,
"heapDeltaBytes": -19592052,
"heapUsedBytes": 70107764,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 2766.1929999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698818897637796,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8737.913999999932,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.579,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5624.871,
"heapDeltaBytes": -11690028,
"heapUsedBytes": 73287016,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2940.5009999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69790076335878,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17498.148999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16722.174,
"heapDeltaBytes": -42614008,
"heapUsedBytes": 179059800,
"domNodes": -3045,
"jsHeapTotalBytes": 368640,
"scriptDurationMs": 329.951,
"eventListeners": -14915,
"totalBlockingTimeMs": 21,
"frameDurationMs": 30.22348877374784,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 16605.812000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15621.521999999999,
"heapDeltaBytes": -42620084,
"heapUsedBytes": 181088348,
"domNodes": -3045,
"jsHeapTotalBytes": -1990656,
"scriptDurationMs": 225.526,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.32662116040955,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 21577.903999999988,
"styleRecalcs": 175,
"styleRecalcDurationMs": 19.416000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21130.996,
"heapDeltaBytes": -42994084,
"heapUsedBytes": 169847240,
"domNodes": -3045,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 873.379,
"eventListeners": -14915,
"totalBlockingTimeMs": 8,
"frameDurationMs": 38.648387096774194,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 21767.46000000003,
"styleRecalcs": 175,
"styleRecalcDurationMs": 18.953000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21322.434999999998,
"heapDeltaBytes": -42427948,
"heapUsedBytes": 184647740,
"domNodes": -3045,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 895.411,
"eventListeners": -14915,
"totalBlockingTimeMs": 16,
"frameDurationMs": 39.07684021543985,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-node-resize-workload",
"durationMs": 6455.326000000014,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.45400000000002,
"layouts": 20,
"layoutDurationMs": 23.722999999999995,
"taskDurationMs": 6325.327,
"heapDeltaBytes": 798756,
"heapUsedBytes": 213744980,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 112.85600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.03184357541899,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6281.433000000106,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.55099999999999,
"layouts": 20,
"layoutDurationMs": 22.964,
"taskDurationMs": 6116.158,
"heapDeltaBytes": 952824,
"heapUsedBytes": 222508520,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 102.883,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.22196531791907,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9343.523000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8979.027000000002,
"heapDeltaBytes": -25613968,
"heapUsedBytes": 186786748,
"domNodes": -3045,
"jsHeapTotalBytes": 10014720,
"scriptDurationMs": 142.12800000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.801700680272113,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8468.917999999918,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7899.1939999999995,
"heapDeltaBytes": -35310820,
"heapUsedBytes": 180578956,
"domNodes": -3045,
"jsHeapTotalBytes": 6983680,
"scriptDurationMs": 120.12299999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.602702702702707,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 494.3150000000287,
"styleRecalcs": 22,
"styleRecalcDurationMs": 18.068,
"layouts": 4,
"layoutDurationMs": 1.937,
"taskDurationMs": 142.425,
"heapDeltaBytes": 6054456,
"heapUsedBytes": 71839252,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 16.675,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 492.92400000001635,
"styleRecalcs": 21,
"styleRecalcDurationMs": 17.572999999999997,
"layouts": 4,
"layoutDurationMs": 1.8370000000000002,
"taskDurationMs": 129.58000000000004,
"heapDeltaBytes": 5805512,
"heapUsedBytes": 71598892,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.488999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 889.218000000028,
"styleRecalcs": 78,
"styleRecalcDurationMs": 100.76499999999999,
"layouts": 76,
"layoutDurationMs": 25.623,
"taskDurationMs": 854.834,
"heapDeltaBytes": 18122268,
"heapUsedBytes": 82037392,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 353.534,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 763.6919999999918,
"styleRecalcs": 78,
"styleRecalcDurationMs": 96.60199999999999,
"layouts": 76,
"layoutDurationMs": 24.238,
"taskDurationMs": 730.594,
"heapDeltaBytes": -9594036,
"heapUsedBytes": 80376372,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 297.90500000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667391304347824,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1428.0699999999342,
"styleRecalcs": 78,
"styleRecalcDurationMs": 270.62,
"layouts": 76,
"layoutDurationMs": 30.014,
"taskDurationMs": 1408.995,
"heapDeltaBytes": -19137196,
"heapUsedBytes": 108621156,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 482.94399999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.37435897435896,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1394.4020000000137,
"styleRecalcs": 78,
"styleRecalcDurationMs": 253.983,
"layouts": 76,
"layoutDurationMs": 28.474,
"taskDurationMs": 1365.9720000000002,
"heapDeltaBytes": -18960268,
"heapUsedBytes": 108888880,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 463.003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.5,
"p95FrameDurationMs": 16.80000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2201 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 645ba9a6b49f255af363c5f7378e4d8242ec4847
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #20847 +/- ##
=============================================
Coverage ? 85.87%
=============================================
Files ? 2484
Lines ? 141674
Branches ? 36276
=============================================
Hits ? 121665
Misses ? 19626
Partials ? 383
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport; diff matches the merged main PR.
Backport of #20834 to
cloud/1.56Automatically created by backport workflow.