Repository navigation
[backport core/1.56] FE-3381 fix(auth): ask for a new login when the session sign-in was revoked - #20846
Conversation
…evoked (#20834) ## Why Prod RUM, right after the 2026-10-12 web-session rollout: a Desktop (Electron) user got "Couldn't load your workspace / Check your connection and try again." and pressed Try again for about 12 minutes before logging out (Datadog issue `8fe722d4`, first seen 12:57Z). Retrying can never succeed, so the screen sends the user into a loop. ## Root cause Ingest refused `POST /api/auth/session` with `401 SESSION_REVOKED` ("This session was signed out; sign in again"). It returns this when the remembered Firebase sign-in predates a revocation of the user's sessions (`websession.ErrSignInPredatesRevocation`, cloud `services/ingest/server/implementation/auth.go`). `useSessionCookie.readSessionError` turned every non-SSO refusal into a plain `Error`, so `WorkspaceAuthGate` classified it as retryable. Each retry replays the same stale sign-in and gets the same 401. ## How - `readSessionError` maps `401` + `code: SESSION_REVOKED` to a typed `SessionRevokedError`. The code comes from the server as received; nothing is derived on the client. - `WorkspaceAuthGate` treats `SessionRevokedError` as non-retryable. The existing non-retryable panel then shows "Sign out and log in again to continue." with only Log Out. - Tests: a table on `ensureSessionCookie` (401 SESSION_REVOKED → typed, 401 UNAUTHORIZED and 403 SESSION_REVOKED → plain), and two rows in the gate's error table (SSO on/off). Red/green: locally the test commit (b567414) fails exactly the 3 new cases and the fix (ceefcd5) passes all 64. On CI the test-only commit's unit job was skipped because fallow flagged an unused class member, so the red is local only. ## AS IS / TO BE | AS IS (`origin/main`) | TO BE (this PR) | |---|---| | <img width="480" alt="AS IS: Couldn't load your workspace, Check your connection and try again, Try again + Log Out" src="https://github.com/user-attachments/assets/e8f289e3-cc1d-44a4-977a-d6e74cba7937" /> | <img width="480" alt="TO BE: Couldn't load your workspace, Sign out and log in again to continue, Log Out only" src="https://github.com/user-attachments/assets/8c2aa720-22d3-4a11-8455-dad1fea55fee" /> | | "Check your connection and try again." + Try again | "Sign out and log in again to continue." + Log Out only | Captured in the real cloud app (local dev server, signed-in session against cloud.comfy.org). Only `POST /api/auth/session` was stubbed (in-page `fetch` override) to return `401 {"code":"SESSION_REVOKED","message":"This session was signed out; sign in again"}`; every other request hit the real backend. Same session and stub for both shots; only the two changed source files differ. ## Plan position | Step | Item | State | |---|---|---| | 1 | Prod flags: session 20%, billing_web 20% | Done 2026-10-12 | | 2 | RUM rollout watch | Running | | 3 | FE-3380: report `unified_web_session` to RUM (#20831) | In review | | **4** | **This PR: revoked sign-in asks for a new login** | **This PR** | | 5 | 1.56 backport of 3 and 4, then ramp decision | After merge | ```mermaid flowchart LR A[Prod flags 20%] --> B[RUM watch] B --> C[FE-3380 RUM cohort tag] B --> D[This PR: SESSION_REVOKED → log in again]:::me C --> E[1.56 backport] D --> E E --> F[Ramp decision] classDef me fill:#f9d71c,stroke:#333,color:#000 ``` - Fixes FE-3381
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-12T18:16:23.143Z",
"gitSha": "0cd3b5be020518f072e3478ca3e4374ca5be3508",
"branch": "backport-20834-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.3090000000066,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.8310000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.4820000000001,
"heapDeltaBytes": 944300,
"heapUsedBytes": 68092288,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.551000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2010.7130000000097,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.569,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 293.83400000000006,
"heapDeltaBytes": 1219976,
"heapUsedBytes": 69979940,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.963999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1755.989999999997,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.058999999999997,
"layouts": 12,
"layoutDurationMs": 4.632000000000001,
"taskDurationMs": 657.907,
"heapDeltaBytes": -2118192,
"heapUsedBytes": 65720004,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 126.98399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1673.5929999999826,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.533,
"layouts": 12,
"layoutDurationMs": 3.1429999999999993,
"taskDurationMs": 523.52,
"heapDeltaBytes": -2153568,
"heapUsedBytes": 66200676,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 93.807,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.8039999999628,
"styleRecalcs": 29,
"styleRecalcDurationMs": 6.885000000000001,
"layouts": 6,
"layoutDurationMs": 1.0390000000000001,
"taskDurationMs": 242.01500000000001,
"heapDeltaBytes": 4188800,
"heapUsedBytes": 71684204,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.223000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.1679999999824,
"styleRecalcs": 32,
"styleRecalcDurationMs": 7.857000000000001,
"layouts": 6,
"layoutDurationMs": 1.435,
"taskDurationMs": 246.15599999999998,
"heapDeltaBytes": 4113708,
"heapUsedBytes": 71617632,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.433000000000005,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 544.9489999999741,
"styleRecalcs": 17,
"styleRecalcDurationMs": 3.157,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.1499999999999,
"heapDeltaBytes": -7537112,
"heapUsedBytes": 61342340,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 112.16399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000017,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 474.36599999991813,
"styleRecalcs": 17,
"styleRecalcDurationMs": 2.8990000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.09700000000004,
"heapDeltaBytes": -6743676,
"heapUsedBytes": 61302608,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 109.80899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66206896551725,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1027.353000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 660.329,
"heapDeltaBytes": 16391152,
"heapUsedBytes": 85391984,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 43.341,
"eventListeners": 0,
"totalBlockingTimeMs": 402,
"frameDurationMs": 30.80606060606059,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 957.5249999999187,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.9709999999999,
"heapDeltaBytes": 16045508,
"heapUsedBytes": 86217520,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 41.690000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 348,
"frameDurationMs": 29.29393939393939,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 732.3670000000106,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.36900000000037,
"heapDeltaBytes": -8309268,
"heapUsedBytes": 92669152,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 114.79700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 116,
"frameDurationMs": 21.567647058823535,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 718.5540000000401,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 282.9729999999997,
"heapDeltaBytes": -14050800,
"heapUsedBytes": 84796028,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 100.64200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 102,
"frameDurationMs": 21.076470588235306,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7423.112000000003,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9670000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6508.826,
"heapDeltaBytes": -3301352,
"heapUsedBytes": 81391336,
"domNodes": -142,
"jsHeapTotalBytes": -8785920,
"scriptDurationMs": 5027.904,
"eventListeners": -78,
"totalBlockingTimeMs": 103,
"frameDurationMs": 26.20636042402827,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5573.180999999977,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9239999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4778.067999999999,
"heapDeltaBytes": 9310312,
"heapUsedBytes": 94320560,
"domNodes": -142,
"jsHeapTotalBytes": -12455936,
"scriptDurationMs": 3827.76,
"eventListeners": -74,
"totalBlockingTimeMs": 10,
"frameDurationMs": 22.35502008032129,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6414.290999999992,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.0789999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5676.376,
"heapDeltaBytes": -16864700,
"heapUsedBytes": 68545712,
"domNodes": -142,
"jsHeapTotalBytes": -11145216,
"scriptDurationMs": 4343.997,
"eventListeners": -78,
"totalBlockingTimeMs": 81,
"frameDurationMs": 25.36166007905138,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5559.936999999991,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.0869999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4930.059,
"heapDeltaBytes": -4222296,
"heapUsedBytes": 81535496,
"domNodes": -143,
"jsHeapTotalBytes": -10358784,
"scriptDurationMs": 3805.067,
"eventListeners": -82,
"totalBlockingTimeMs": 2,
"frameDurationMs": 22.002371541501976,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-graph-idle",
"durationMs": 2009.1400000000021,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.1989999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.495,
"heapDeltaBytes": -9340876,
"heapUsedBytes": 79616512,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 28.614,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2006.54499999996,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.371,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.809,
"heapDeltaBytes": -9212804,
"heapUsedBytes": 79995776,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 26.455999999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2105.0610000000347,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.081,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1111.5710000000001,
"heapDeltaBytes": -19015640,
"heapUsedBytes": 70254636,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 561.174,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665079365079368,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2151.1669999999867,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.51,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1094.142,
"heapDeltaBytes": -20124272,
"heapUsedBytes": 69163232,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 563.0120000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66640625,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3118.696,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.658000000000001,
"layouts": 60,
"layoutDurationMs": 13.459999999999999,
"taskDurationMs": 1163.2150000000001,
"heapDeltaBytes": 898484,
"heapUsedBytes": 69794772,
"domNodes": 24,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 519.241,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665775401069517,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3093.007000000057,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.591999999999999,
"layouts": 60,
"layoutDurationMs": 13.519,
"taskDurationMs": 1173.931,
"heapDeltaBytes": 5264560,
"heapUsedBytes": 92976524,
"domNodes": 24,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 533.953,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2297.4080000000185,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.913,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1415.8919999999998,
"heapDeltaBytes": 6667864,
"heapUsedBytes": 75825764,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 719.6089999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.788970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2154.9909999999954,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.352999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1282.714,
"heapDeltaBytes": 3026456,
"heapUsedBytes": 71833260,
"domNodes": 0,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 648.455,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.919999999975,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.1640000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 319.666,
"heapDeltaBytes": 11399480,
"heapUsedBytes": 75820624,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 22.948000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.01300000002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.102,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.20399999999995,
"heapDeltaBytes": -11542392,
"heapUsedBytes": 70053560,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 31.140999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 424.3109999999888,
"styleRecalcs": 49,
"styleRecalcDurationMs": 4.768999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 280.35599999999994,
"heapDeltaBytes": -11969544,
"heapUsedBytes": 57672924,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 94.494,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 423.17099999991115,
"styleRecalcs": 50,
"styleRecalcDurationMs": 5.24,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 279.003,
"heapDeltaBytes": -12889048,
"heapUsedBytes": 57957924,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 91.475,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230772,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2011.780999999985,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.7279999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 300.838,
"heapDeltaBytes": 1142260,
"heapUsedBytes": 70747392,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.568999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.5300000000216,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.6910000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 283.05800000000005,
"heapDeltaBytes": 1431476,
"heapUsedBytes": 71155448,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.805999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.7019999999634,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.293,
"layouts": 16,
"layoutDurationMs": 3.6220000000000003,
"taskDurationMs": 540.8929999999999,
"heapDeltaBytes": -5947872,
"heapUsedBytes": 63927696,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 74.152,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.8079999999945,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.827,
"layouts": 16,
"layoutDurationMs": 4.869,
"taskDurationMs": 554.325,
"heapDeltaBytes": -6108500,
"heapUsedBytes": 63528900,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 75.294,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 799.1799999999785,
"styleRecalcs": 18,
"styleRecalcDurationMs": 19.066,
"layouts": 5,
"layoutDurationMs": 8.449000000000002,
"taskDurationMs": 584.703,
"heapDeltaBytes": -2617756,
"heapUsedBytes": 89782604,
"domNodes": 14227,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 19.219999999999995,
"eventListeners": 2463,
"totalBlockingTimeMs": 84,
"frameDurationMs": 20.00250000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8124.3200000000115,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.084,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3876.5899999999997,
"heapDeltaBytes": 10592868,
"heapUsedBytes": 90700724,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 1871.693,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665913757700206,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8140.076000000022,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.223,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3798.3590000000004,
"heapDeltaBytes": -19112304,
"heapUsedBytes": 70185096,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 1817.66,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66618852459016,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11413.764000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10453.648,
"heapDeltaBytes": -32821128,
"heapUsedBytes": 180356192,
"domNodes": -3045,
"jsHeapTotalBytes": 8474624,
"scriptDurationMs": 161.207,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.31675126903553,
"p95FrameDurationMs": 33.30000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12035.595999999941,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11312.341,
"heapDeltaBytes": -28472952,
"heapUsedBytes": 178056792,
"domNodes": -3044,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 182.71900000000002,
"eventListeners": -14905,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.291568296795955,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-pan",
"durationMs": 13546.414000000026,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.455999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12890.874,
"heapDeltaBytes": -15328560,
"heapUsedBytes": 184268852,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 627.951,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.675567190226875,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 15134.185000000001,
"styleRecalcs": 84,
"styleRecalcDurationMs": 15.285999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14394.917,
"heapDeltaBytes": -52193536,
"heapUsedBytes": 169376620,
"domNodes": -3045,
"jsHeapTotalBytes": 1679360,
"scriptDurationMs": 690.735,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.51398601398601,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 3929.6729999999798,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.248999999999995,
"layouts": 20,
"layoutDurationMs": 20.988,
"taskDurationMs": 3745.578,
"heapDeltaBytes": 1201324,
"heapUsedBytes": 214844444,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 61.38400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.729834254143647,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-node-resize-workload",
"durationMs": 4464.474999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.71100000000001,
"layouts": 20,
"layoutDurationMs": 24.916999999999994,
"taskDurationMs": 4343.078000000001,
"heapDeltaBytes": -13155908,
"heapUsedBytes": 213926756,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 74.132,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.913872832369943,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5715.668000000051,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5334.963,
"heapDeltaBytes": -42617312,
"heapUsedBytes": 180109648,
"domNodes": -3045,
"jsHeapTotalBytes": 1679360,
"scriptDurationMs": 78.11200000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.191245791245787,
"p95FrameDurationMs": 33.30000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5892.175999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5510.2390000000005,
"heapDeltaBytes": -32384684,
"heapUsedBytes": 181833076,
"domNodes": -3045,
"jsHeapTotalBytes": 8933376,
"scriptDurationMs": 78.44299999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.20479452054795,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 441.50099999995973,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.591000000000001,
"layouts": 3,
"layoutDurationMs": 1.4320000000000002,
"taskDurationMs": 100.268,
"heapDeltaBytes": 5910104,
"heapUsedBytes": 72369236,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.232000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962965,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 461.1220000000458,
"styleRecalcs": 14,
"styleRecalcDurationMs": 11.991999999999999,
"layouts": 3,
"layoutDurationMs": 1.038,
"taskDurationMs": 102.635,
"heapDeltaBytes": 5675052,
"heapUsedBytes": 72148236,
"domNodes": 101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.936999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 422.93899999992846,
"styleRecalcs": 78,
"styleRecalcDurationMs": 64.874,
"layouts": 76,
"layoutDurationMs": 15.564,
"taskDurationMs": 389.708,
"heapDeltaBytes": 13236336,
"heapUsedBytes": 87382876,
"domNodes": 76,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 131.61599999999999,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667999999999992,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 498.1239999999616,
"styleRecalcs": 78,
"styleRecalcDurationMs": 68.841,
"layouts": 76,
"layoutDurationMs": 16.366,
"taskDurationMs": 460.21099999999996,
"heapDeltaBytes": 14151420,
"heapUsedBytes": 87897260,
"domNodes": 76,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 168.435,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 677.2229999999126,
"styleRecalcs": 78,
"styleRecalcDurationMs": 162.21099999999998,
"layouts": 76,
"layoutDurationMs": 15.848,
"taskDurationMs": 641.738,
"heapDeltaBytes": 8485392,
"heapUsedBytes": 128850276,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.39600000000002,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66341463414634,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 666.3969999999608,
"styleRecalcs": 78,
"styleRecalcDurationMs": 173.985,
"layouts": 76,
"layoutDurationMs": 15.925000000000002,
"taskDurationMs": 637.953,
"heapDeltaBytes": 8514736,
"heapUsedBytes": 122880516,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 171.64000000000001,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2203 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 77bfcc1db2c22db5c036b3de7acc724e85663d15
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.56 #20846 +/- ##
=============================================
- Coverage 85.84% 85.84% -0.01%
=============================================
Files 2475 2475
Lines 141340 141344 +4
Branches 38474 38476 +2
=============================================
Hits 121332 121332
- Misses 19624 19628 +4
Partials 384 384
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport; diff matches the merged main PR.
Backport of #20834 to
core/1.56Automatically created by backport workflow.