Repository navigation
fix(palettes): give nord its own surfaces and sink solarized's canvas - #20842
mariana953 wants to merge 89 commits into
Conversation
Extend the charcoal scale with two darker steps (charcoal-900 #111111, charcoal-950 #09090a) for deeper dark-theme surfaces.
Add semantic tokens for the tab treatment and region strokes, defined per theme (:root derives from each palette's comfy_base vars; .dark-theme uses the tuned charcoal values): - --workflow-tab-divider / -selected-surface / -hover-surface - --region-stroke, --sidebar-surface, --base-background-sunken Restyle the workflow tabs to use them: filled selected tab (not an underline), hover state, right-edge dividers only, close button shown on hover only, and no stray border on the first tab. Unsaved-dot loses its mismatched background.
Drop the borders and shadows on the manage-extensions pill, run actionbar, sidebar and topbar so they read as flat surfaces divided by strokes; match their height and padding to the workflow tabs; make the Share button icon-only; and tighten the bottom canvas toolbar padding. Sidebar right and topbar bottom borders use the theme-aware --region-stroke token; the connected sidebar uses --sidebar-surface.
Give every built-in palette the same subtle dot-grid canvas background: a white dot for the dark palettes (dark/arc/nord/github) and a black dot for light, at low opacity, so the canvas texture is aligned across themes while adapting to each background. The dark palette's canvas also moves to charcoal-950 (#09090A).
The .dark-theme class is applied to every dark palette (solarized, arc, nord, github), so hardcoding charcoal there leaked the default dark colors into all of them. Tag the root with data-color-palette and move the tuned charcoal (sidebar/selected/hover surfaces, sunken) under :root[data-color-palette='dark'] only; other palettes fall back to deriving from their own comfy_base vars (--bg-color/--content-hover-bg), so the sidebar and selected tab share the canvas base level per theme.
Scope the light palette (data-color-palette='light') to the DS light values instead of derived guesses: sidebar and selected tab = smoke-200 (base/background), tab hover = smoke-400 (workflow tab background-hovered), divider = smoke-400, region stroke = smoke-300.
- Remove the now-unused actionbar.share i18n key (Share button is icon-only; the tooltip key stays) - Consume charcoal-950 via the --base-background-sunken token: the app body backdrop uses it in the default dark palette, matching the sunken canvas (no more dead token) - Add a behavioral test that the active tab still closes (its close button is now hover-revealed instead of shown while selected)
The DS light sidebar value (smoke-200) read too grey in-app; nudge the sidebar surface one step lighter to near-white while keeping the selected tab at smoke-200 so it stays distinct from the white tab bar.
Replace the dot-grid BACKGROUND_IMAGE with a thin line grid (white on dark palettes, black on light) while keeping the current canvas colors (charcoal-950 on dark).
Reduce --workflow-tabs-height from 38px to 34px so the workflow tab bar and the topbar action pills hug their 32px controls (Run button, icon buttons) instead of leaving ~3px of vertical slack. Tabs and the run block now read at the same visual height.
Raise the line-grid stroke-opacity baked into each palette's BACKGROUND_IMAGE (dark/arc/nord/github 0.07 -> 0.10, light 0.08 -> 0.12). Only lifts the base pattern opacity; litegraph's zoom_modify_alpha ramp is untouched, so the grid stays subtle at default zoom and gets more visible as you zoom in.
Halve the rendered opacity of the sidebar/topbar region strokes and the workflow tab dividers: the derived tokens drop from 50% to 25% of each palette's --border-color, and the light palette's smoke values gain a 50% mix. Each theme keeps its own colour logic, only the weight changes.
Revert the padding tweaks on the top menu section: root pt-2 back to pt-1, and the extensions pill and actionbar container back to px-2. The bar keeps its aligned height, borderless chrome and icon-only share button; only the spacing returns to what main had.
litegraph only repaints its clear colour below 1.5x zoom; above that the canvas is left transparent and the body shows through. The backdrop was reading --base-background-sunken, which only the default dark palette defines, so light and the custom palettes fell back to transparent and rendered black once zoomed in. Fall back to each palette's own --bg-color so every theme keeps its canvas colour at any zoom level.
The run actionbar and the extensions pill were pinned to a fixed --workflow-tabs-height with no vertical padding, so their 32px controls sat flush against the pill edges. Drop the fixed height and give both py-1, matching the graph mode pill which wraps its own 32px button in p-1. All three now render as 40px pills with 4px of breathing room.
The subgraph breadcrumb wraps the graph mode pill in -mt-3 + pt-4, a net 4px offset that left the actions column sitting 4px higher than it. Pad the actions column by the same amount so the graph pill, the extensions pill and the run actionbar share one baseline: all three now render at the same top, bottom and height.
Arc's canvas was lighter than its own menu surface, inverting the depth the dark palette establishes and leaving nodes flat against the background. Drop it to the same lightness offset dark uses between menu and canvas, measured in OKLCH so arc keeps its own hue and chroma. bg-color moves with it: litegraph stops repainting its clear colour above 1.5x zoom and the body backdrop falls back to --bg-color, so the two have to agree or the background jumps when zoomed in.
Dark stacks three levels: canvas (charcoal-950) below sidebar and selected tab (charcoal-900) below the menu and tab bar (charcoal-800). Custom palettes only aliased the sidebar to --bg-color, which is their canvas colour, so the sidebar dissolved into the canvas and the depth disappeared. Express each level as a lightness offset from the palette's own menu colour and replay it in OKLCH, which keeps the offsets perceptually even while preserving each palette's hue and chroma. --base-background-sunken is derived the same way, so the body backdrop tracks the canvas in every theme rather than falling back to --bg-color. Canvas colours in arc/nord/github are retuned to that offset, and solarized gains the CLEAR_BACKGROUND_COLOR it never had (it was inheriting whatever the previous palette left on the canvas). arc's bg-color returns to its original value, no longer needing to track the canvas for the backdrop.
Per review: fully desaturated #111111 looked out of place next to the rest of the scale. Bumps to #111112 so it carries the faint cool cast the other charcoal steps share, with no perceptible change in value.
Per review: the 24px grid tile no longer lined up with shift-snapping. Nodes snap to CANVAS_GRID_SIZE (10), so a 24px tile drifts off the snap lattice. Back to a 10px tile — every snap point lands on a grid line again, matching the original grid's spacing while keeping the flat line style over the themed canvas.
Per review: the rationale comments on the palette-derived surfaces read as noise in the stylesheet. The reasoning lives in the PR description instead. No behavioural change.
The topbar buttons, node bodies, panels and other surfaces built with the new design-system tokens were still charcoal in solarized/arc/nord/github, reading as neutral grey over a themed canvas. .dark-theme applies to every non-light palette, so those hardcoded charcoal values leaked in. Derive them from each palette's own menu colour with the same OKLCH lightness offsets already used for the sidebar and tabs, scoped away from dark/light so both keep their exact values. Custom themes now render their chrome in their own hue instead of grey.
The merge from main set the run actionbar wrapper to py-1.75, leaving it 6px taller than the extensions pill and the graph mode pill. Back to py-1 so all three topbar pills share the same 40px height again.
Fixes the indentation of the custom-palette selector so oxfmt --check passes; the earlier commits landed without the formatter run.
The imagePastePriority e2e only passed on main because the 38px workflow tab bar swallowed the fixture's title clicks at y=35, so the test never selected or copied anything. The compact 34px tab bar in this branch lets those clicks through, and the test then exposes a real gap in usePaste: with a media node selected and no media in the clipboard, the handler fell through to canvas.pasteFromClipboard() and pasted the previously copied node. Guard that fallback behind the media-node check, matching the behavior the e2e specifies, and update the unit test that had codified the old fallthrough.
The previous guard skipped litegraph's default paste whenever a media node was selected, which broke duplicating a just-copied media node (errorsTabModeAware e2e). Narrow it: compare the clipboard's node metadata against litegraph's internal clipboard. Stale metadata (no match) pastes nothing while a media node is targeted; a fresh in-app copy still pastes. Covers both the imagePastePriority and errorsTabModeAware expectations, with unit tests for each case.
…feat/topbar-theme-refresh
| snapshot | status | changed pixels | | --- | --- | --- | | `tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-lg-chromium-linux.png` | modified | 53437B -> 53062B | | `tests/links/linkVisibility.spec.ts-snapshots/link-hidden-revealed-chromium-linux.png` | modified | 47583B -> 51851B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each rewrite corresponds to a test expected to change.
| snapshot | status | changed pixels | | --- | --- | --- | | `tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-lg-chromium-linux.png` | modified | 53437B -> 53061B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each rewrite corresponds to a test expected to change.
| snapshot | status | changed pixels | | --- | --- | --- | | `tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-lg-chromium-linux.png` | modified | 54025B -> 53005B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each rewrite corresponds to a test expected to change.
Nord's chrome was #161b22, the same near-black family as github, so the canvas derived from it landed at #080d13 and the two palettes became indistinguishable. Moves nord's menu, node and canvas surfaces into its own polar-night family. Solarized's canvas at #2631 sat within one step of its widget background #002b36, so prompt boxes dissolved into the backdrop. Sinks the canvas to #1621. Background grid tiles re-tinted by the same lightness shift in each.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-12T17:37:23.327Z",
"gitSha": "0981d4eeffd0879564325eac510e2d50ac1fa73a",
"branch": "mariana/palette-nord-solarized-contrast",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.7929999999978,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.8190000000000004,
"layouts": 12,
"layoutDurationMs": 2.96,
"taskDurationMs": 476.652,
"heapDeltaBytes": -13375808,
"heapUsedBytes": 66509400,
"domNodes": -163,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 11.083999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2026.2890000000198,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.061,
"layouts": 11,
"layoutDurationMs": 2.935,
"taskDurationMs": 477.187,
"heapDeltaBytes": -877200,
"heapUsedBytes": 67042364,
"domNodes": -163,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.716,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1722.2880000000487,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.722000000000003,
"layouts": 13,
"layoutDurationMs": 3.232,
"taskDurationMs": 739.9599999999999,
"heapDeltaBytes": -7699912,
"heapUsedBytes": 66801008,
"domNodes": -163,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 117.98,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1721.7350000000806,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.527,
"layouts": 12,
"layoutDurationMs": 2.8459999999999996,
"taskDurationMs": 774.1680000000001,
"heapDeltaBytes": -12296876,
"heapUsedBytes": 67999020,
"domNodes": -163,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 126.31599999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.4170000000304,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.863,
"layouts": 13,
"layoutDurationMs": 2.83,
"taskDurationMs": 265.74699999999996,
"heapDeltaBytes": 20224288,
"heapUsedBytes": 87906912,
"domNodes": 47,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 12.012000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.3100000000359,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.7090000000000005,
"layouts": 13,
"layoutDurationMs": 3.6270000000000002,
"taskDurationMs": 338.237,
"heapDeltaBytes": 20121392,
"heapUsedBytes": 88026408,
"domNodes": 47,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.624999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 589.2699999999422,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.8729999999999998,
"layouts": 11,
"layoutDurationMs": 2.9340000000000006,
"taskDurationMs": 407.94499999999994,
"heapDeltaBytes": 5942132,
"heapUsedBytes": 81547916,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 140.67499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 549.9569999999494,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.515999999999999,
"layouts": 10,
"layoutDurationMs": 2.5229999999999997,
"taskDurationMs": 389.406,
"heapDeltaBytes": 663404,
"heapUsedBytes": 68498392,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 133.824,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1062.6439999999775,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 739.9769999999999,
"heapDeltaBytes": -11574576,
"heapUsedBytes": 81510124,
"domNodes": -193,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 49.992999999999995,
"eventListeners": -107,
"totalBlockingTimeMs": 404,
"frameDurationMs": 29.627777777777787,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1052.238999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 721.677,
"heapDeltaBytes": -5943612,
"heapUsedBytes": 81811088,
"domNodes": -193,
"jsHeapTotalBytes": 15736832,
"scriptDurationMs": 48.15499999999999,
"eventListeners": -107,
"totalBlockingTimeMs": 385,
"frameDurationMs": 29.166666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 749.5769999999311,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.2189999999997,
"heapDeltaBytes": -3990060,
"heapUsedBytes": 77162144,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 116.28899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 122,
"frameDurationMs": 22.055882352941165,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 747.7420000000166,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.2769999999996,
"heapDeltaBytes": -4960984,
"heapUsedBytes": 75288532,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 103.37500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 117,
"frameDurationMs": 22.058823529411764,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7848.0830000000315,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.35699999999999965,
"layouts": 2,
"layoutDurationMs": 4.861,
"taskDurationMs": 6892.855,
"heapDeltaBytes": 16054412,
"heapUsedBytes": 94969236,
"domNodes": -259,
"jsHeapTotalBytes": -659456,
"scriptDurationMs": 5222.914000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 83,
"frameDurationMs": 24.684591194968554,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6620.561000000066,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2000000000000005,
"layouts": 1,
"layoutDurationMs": 0.2539999999999999,
"taskDurationMs": 5870.125000000001,
"heapDeltaBytes": 18143676,
"heapUsedBytes": 97512828,
"domNodes": -259,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 4588.443,
"eventListeners": -69,
"totalBlockingTimeMs": 32,
"frameDurationMs": 24.688059701492534,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7398.330999999985,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5859999999999997,
"layouts": 2,
"layoutDurationMs": 0.5999999999999999,
"taskDurationMs": 6569.326,
"heapDeltaBytes": 10338524,
"heapUsedBytes": 88881296,
"domNodes": -259,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 4972.556,
"eventListeners": -69,
"totalBlockingTimeMs": 123,
"frameDurationMs": 24.748160535117055,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7162.8169999999045,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8500000000000001,
"layouts": 3,
"layoutDurationMs": 0.7590000000000001,
"taskDurationMs": 6361.3910000000005,
"heapDeltaBytes": -1136756,
"heapUsedBytes": 96940152,
"domNodes": -259,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 4795.61,
"eventListeners": -69,
"totalBlockingTimeMs": 38,
"frameDurationMs": 24.459044368600683,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 258.39299999995546,
"styleRecalcs": 26,
"styleRecalcDurationMs": 19.488,
"layouts": 13,
"layoutDurationMs": 3.6229999999999993,
"taskDurationMs": 206.61800000000002,
"heapDeltaBytes": -20050020,
"heapUsedBytes": 74493860,
"domNodes": 729,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 13.843,
"eventListeners": 58,
"totalBlockingTimeMs": 28,
"frameDurationMs": 22.727272727272727,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 189.0530000000581,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.391999999999998,
"layouts": 12,
"layoutDurationMs": 2.987,
"taskDurationMs": 148.571,
"heapDeltaBytes": -8486304,
"heapUsedBytes": 86210108,
"domNodes": 917,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.919999999999998,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.366666666666635,
"p95FrameDurationMs": 50.09999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2025.2460000000383,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1759999999999993,
"layouts": 9,
"layoutDurationMs": 2.3360000000000003,
"taskDurationMs": 531.3149999999999,
"heapDeltaBytes": 5500584,
"heapUsedBytes": 84204844,
"domNodes": -259,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 31.775,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.4979999999468,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.11,
"layouts": 9,
"layoutDurationMs": 1.9929999999999999,
"taskDurationMs": 412.727,
"heapDeltaBytes": -832456,
"heapUsedBytes": 82915880,
"domNodes": -259,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 31.28,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2224.609999999984,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.861,
"layouts": 9,
"layoutDurationMs": 2.2839999999999994,
"taskDurationMs": 1278.3229999999999,
"heapDeltaBytes": -1374044,
"heapUsedBytes": 83727404,
"domNodes": -259,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 665.2650000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66616541353383,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2155.6969999999183,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.952000000000001,
"layouts": 9,
"layoutDurationMs": 1.9700000000000004,
"taskDurationMs": 1384.018,
"heapDeltaBytes": 2079696,
"heapUsedBytes": 87048996,
"domNodes": -259,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 642.857,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665891472868214,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3327.058999999963,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.692999999999998,
"layouts": 67,
"layoutDurationMs": 12.807,
"taskDurationMs": 1545.108,
"heapDeltaBytes": -5321308,
"heapUsedBytes": 80628308,
"domNodes": -235,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 643.914,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66633165829146,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3258.6209999999483,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.327000000000002,
"layouts": 66,
"layoutDurationMs": 12.508999999999999,
"taskDurationMs": 1541.1099999999997,
"heapDeltaBytes": -9431264,
"heapUsedBytes": 77579320,
"domNodes": -235,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 627.322,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153847,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2443.204000000037,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.012999999999999,
"layouts": 8,
"layoutDurationMs": 1.9489999999999998,
"taskDurationMs": 1602.5230000000001,
"heapDeltaBytes": 1488388,
"heapUsedBytes": 79306284,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 773.7049999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.781379310344825,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2282.1050000000014,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.5120000000000005,
"layouts": 9,
"layoutDurationMs": 1.9920000000000002,
"taskDurationMs": 1563.545,
"heapDeltaBytes": 7604740,
"heapUsedBytes": 94648944,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 737.608,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.788888888888888,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.8849999999175,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6220000000000003,
"layouts": 8,
"layoutDurationMs": 1.764,
"taskDurationMs": 532.1909999999999,
"heapDeltaBytes": -3883212,
"heapUsedBytes": 83230776,
"domNodes": -259,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 33.64900000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2033.4440000000313,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0780000000000007,
"layouts": 9,
"layoutDurationMs": 2.205,
"taskDurationMs": 530.345,
"heapDeltaBytes": -2677136,
"heapUsedBytes": 84809016,
"domNodes": -259,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 34.88699999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 565.2499999999918,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.018,
"layouts": 12,
"layoutDurationMs": 2.8409999999999997,
"taskDurationMs": 363.13300000000004,
"heapDeltaBytes": 23021852,
"heapUsedBytes": 91160612,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 117.956,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 548.0650000000651,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.498,
"layouts": 11,
"layoutDurationMs": 2.4619999999999997,
"taskDurationMs": 352.989,
"heapDeltaBytes": 22937196,
"heapUsedBytes": 91100924,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 114.12599999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2036.4169999999149,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.395,
"layouts": 12,
"layoutDurationMs": 2.8329999999999997,
"taskDurationMs": 463.156,
"heapDeltaBytes": -9777264,
"heapUsedBytes": 72455368,
"domNodes": -181,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 9.296000000000001,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.4710000000096,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.767999999999999,
"layouts": 11,
"layoutDurationMs": 2.78,
"taskDurationMs": 468.31999999999994,
"heapDeltaBytes": 2434740,
"heapUsedBytes": 70486832,
"domNodes": -181,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 9.719999999999999,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.3870000000352,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.597,
"layouts": 11,
"layoutDurationMs": 2.4870000000000005,
"taskDurationMs": 740.758,
"heapDeltaBytes": -12730132,
"heapUsedBytes": 69056920,
"domNodes": -173,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 89.81900000000002,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1728.4779999999955,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.022999999999996,
"layouts": 12,
"layoutDurationMs": 2.9199999999999995,
"taskDurationMs": 735.3570000000001,
"heapDeltaBytes": -798064,
"heapUsedBytes": 67517900,
"domNodes": -173,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 90.90200000000002,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 915.6659999999874,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.238999999999997,
"layouts": 5,
"layoutDurationMs": 10.838000000000001,
"taskDurationMs": 680.261,
"heapDeltaBytes": 35944584,
"heapUsedBytes": 119578960,
"domNodes": 15956,
"jsHeapTotalBytes": 16130048,
"scriptDurationMs": 24.08,
"eventListeners": 3244,
"totalBlockingTimeMs": 143,
"frameDurationMs": 20.831818181818168,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8231.261000000017,
"styleRecalcs": 251,
"styleRecalcDurationMs": 22.615,
"layouts": 10,
"layoutDurationMs": 2.208,
"taskDurationMs": 5161.253,
"heapDeltaBytes": 14119916,
"heapUsedBytes": 98491032,
"domNodes": -259,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 2376.908,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666194331983807,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8183.667000000014,
"styleRecalcs": 250,
"styleRecalcDurationMs": 22.956999999999997,
"layouts": 9,
"layoutDurationMs": 2.006,
"taskDurationMs": 4885.571,
"heapDeltaBytes": -14154644,
"heapUsedBytes": 68915548,
"domNodes": -259,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 2215.808,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665784114052954,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17173.05499999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16747.262,
"heapDeltaBytes": -50777852,
"heapUsedBytes": 265644560,
"domNodes": -3330,
"jsHeapTotalBytes": 3993600,
"scriptDurationMs": 294.33500000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.108843537414966,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 12826.817000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12165.921999999999,
"heapDeltaBytes": -35816220,
"heapUsedBytes": 258177636,
"domNodes": -3330,
"jsHeapTotalBytes": 2215936,
"scriptDurationMs": 184.37,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.049484536082478,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 20260.617000000024,
"styleRecalcs": 155,
"styleRecalcDurationMs": 15.11599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19937.075999999997,
"heapDeltaBytes": -47289808,
"heapUsedBytes": 264204536,
"domNodes": -3330,
"jsHeapTotalBytes": -10539008,
"scriptDurationMs": 759.5419999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.04881170018282,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 20417.564000000086,
"styleRecalcs": 162,
"styleRecalcDurationMs": 18.38300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20049.805,
"heapDeltaBytes": -36876060,
"heapUsedBytes": 265652616,
"domNodes": -3330,
"jsHeapTotalBytes": 1769472,
"scriptDurationMs": 747.693,
"eventListeners": -651,
"totalBlockingTimeMs": 22,
"frameDurationMs": 37.76802218114602,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6397.039999999947,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.689000000000014,
"layouts": 20,
"layoutDurationMs": 22.289,
"taskDurationMs": 6249.353999999999,
"heapDeltaBytes": -20172624,
"heapUsedBytes": 266049588,
"domNodes": -307,
"jsHeapTotalBytes": 11587584,
"scriptDurationMs": 146.914,
"eventListeners": -7,
"totalBlockingTimeMs": 2,
"frameDurationMs": 36.26704545454545,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6378.205999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.605,
"layouts": 20,
"layoutDurationMs": 28.119999999999994,
"taskDurationMs": 6259.366000000001,
"heapDeltaBytes": -33683200,
"heapUsedBytes": 275687972,
"domNodes": -3330,
"jsHeapTotalBytes": 8507392,
"scriptDurationMs": 97.816,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.013372093023264,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8401.444999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8233.861,
"heapDeltaBytes": 18858784,
"heapUsedBytes": 277738192,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.76500000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.337710437710435,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8388.284,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8213.560999999998,
"heapDeltaBytes": -4356068,
"heapUsedBytes": 274951368,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.012,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.320945945945947,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 484.4140000000152,
"styleRecalcs": 20,
"styleRecalcDurationMs": 13.235000000000001,
"layouts": 13,
"layoutDurationMs": 4.569,
"taskDurationMs": 135.399,
"heapDeltaBytes": 7094672,
"heapUsedBytes": 74468384,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.918,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.257142857142867,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 444.7420000000193,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.837000000000002,
"layouts": 12,
"layoutDurationMs": 3.073,
"taskDurationMs": 94.49100000000001,
"heapDeltaBytes": 6429956,
"heapUsedBytes": 73670956,
"domNodes": 95,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.598999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962965,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 326.9760000000588,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.998,
"layouts": 76,
"layoutDurationMs": 11.842,
"taskDurationMs": 277.687,
"heapDeltaBytes": 10143656,
"heapUsedBytes": 87825904,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.697,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631594,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 311.6820000000189,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.963,
"layouts": 76,
"layoutDurationMs": 12.251,
"taskDurationMs": 257.964,
"heapDeltaBytes": -14805968,
"heapUsedBytes": 78361960,
"domNodes": 4,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 111.71499999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 411.1319999999523,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8639999999999999,
"layouts": 76,
"layoutDurationMs": 11.977,
"taskDurationMs": 368.875,
"heapDeltaBytes": -786200,
"heapUsedBytes": 118783468,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 134.797,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667999999999992,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 407.87599999998747,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.719,
"layouts": 76,
"layoutDurationMs": 11.818999999999999,
"taskDurationMs": 372.84499999999997,
"heapDeltaBytes": -727308,
"heapUsedBytes": 118821080,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 134.079,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667999999999992,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2264 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a9a4555733dc525b53becbcb5c25964cacf0c665
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## feat/topbar-theme-refresh #20842 +/- ##
=============================================================
+ Coverage 86.09% 86.89% +0.79%
=============================================================
Files 3651 2601 -1050
Lines 174221 146008 -28213
Branches 45989 37951 -8038
=============================================================
- Hits 149998 126870 -23128
+ Misses 22213 18751 -3462
+ Partials 2010 387 -1623
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
a9a4555 to
7155206
Compare
Summary
Two things found by opening the editor in all six palettes after #19437, which neither CI nor the screenshot suite can see (every colour shift in that PR measures below Playwright's default
threshold: 0.2). Stacked on #19437 because both values it adjusts are introduced there. Draft: the values are a proposal, not a decision.Nord looked like github. Nord's
comfy-menu-bgwas#161b22, the same near-black family as github's#13171d, and itsNODE_DEFAULT_BGCOLORandtr-odd-bg-colorwere the same value. #19437 derives the canvas from the menu surface, so nord's canvas landed at#080d13against github's#06090e— a 1.02 ratio between them, indistinguishable. Nord's ownbg-colorandWIDGET_BGCOLORare the real polar night#2e3440, so the chrome was the outlier. Moves the three surfaces to#242933(polar night, darkened) and lets the canvas derive to#151a23.Solarized's prompt boxes dissolved into the canvas. #19437 gives solarized a canvas for the first time,
#002631, derived asoklch(from #073642 calc(l - 0.0648) c h). Solarized'sWIDGET_BGCOLORis base03#002b36, which puts the prompt box one step from the backdrop: 1.03:1. Base03 is a canonical Solarized value and the canvas is not, so this sinks the canvas instead, to#001621(l - 0.13on the same derivation).Background grid tiles are re-tinted by the same lightness shift in each palette, so the grid keeps its relationship to the new backdrop and the tile's base colour stays byte-equal to
CLEAR_BACKGROUND_COLOR.Measured, from the running editor
A node graph (7 nodes with widgets) open at 65% zoom, pixels sampled from the captures:
For reference, dark measures 1.61 / 1.24 and light 1.44 / 1.15 on the same points.
Text contrast is unaffected or better. Solarized
fg-coloron the canvas goes 14.73 → 17.13. Nord's derived sidebar surface moves#10151c→#1d222c, which takes the rail's muted icon colour (smoke-800 #8a8a8a) from 5.31 → 4.62, still above AA;fg-coloron the canvas goes 16.11 → 14.42. Those are the two numbers worth a second opinion — a lighter nord costs some of the headroom #19437 gained.Verification
colorPalette.spec.tsassertsrgb(34,34,34),rgb(0,0,0)andrgb(9,9,10)for other palettes, and its solarized case only asserts the node colour changes. There are no nord or solarized screenshot baselines.Open questions
#242933vs a lighter#262b36(icons 4.50, right on the AA line) vs full#2e3440(icons 4.00, below AA).#242933is the lightest value that keeps the rail above AA.WIDGET_BGCOLORoff base03 instead.Generated by Claude Code