Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-14T17:23:23.933Z",
"gitSha": "72e3b4f685908c6e75fe241e8cfe15ad9c4d32f5",
"branch": "vinh/be-20294-open-ui-link",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.440000000031,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.296,
"layouts": 10,
"layoutDurationMs": 2.2929999999999997,
"taskDurationMs": 425.465,
"heapDeltaBytes": -562164,
"heapUsedBytes": 77640908,
"domNodes": -162,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 8.161999999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2008.0900000000383,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.6699999999999995,
"layouts": 10,
"layoutDurationMs": 2.7740000000000005,
"taskDurationMs": 473.808,
"heapDeltaBytes": 1007936,
"heapUsedBytes": 79263912,
"domNodes": -162,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 10.887,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1961.05399999999,
"styleRecalcs": 83,
"styleRecalcDurationMs": 12.400999999999998,
"layouts": 10,
"layoutDurationMs": 2.182,
"taskDurationMs": 901.485,
"heapDeltaBytes": -595092,
"heapUsedBytes": 77502328,
"domNodes": -162,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 117.967,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665254237288135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1876.967000000036,
"styleRecalcs": 51,
"styleRecalcDurationMs": 11.706999999999999,
"layouts": 6,
"layoutDurationMs": 2.2140000000000004,
"taskDurationMs": 904.463,
"heapDeltaBytes": -562532,
"heapUsedBytes": 77633396,
"domNodes": -162,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 132.833,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666371681415928,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1699.7539999999844,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.85,
"layouts": 10,
"layoutDurationMs": 1.8999999999999997,
"taskDurationMs": 297.019,
"heapDeltaBytes": 16897056,
"heapUsedBytes": 79670208,
"domNodes": 47,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 9.616000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1807.6449999999795,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.29,
"layouts": 12,
"layoutDurationMs": 2.355,
"taskDurationMs": 360.12,
"heapDeltaBytes": 18038572,
"heapUsedBytes": 82408196,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.655000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605504587156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 550.2749999999992,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.9110000000000005,
"layouts": 11,
"layoutDurationMs": 2.4920000000000004,
"taskDurationMs": 383.26700000000005,
"heapDeltaBytes": 5305648,
"heapUsedBytes": 83542288,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 131.333,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 582.4770000000399,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.4920000000000004,
"layouts": 9,
"layoutDurationMs": 2.255,
"taskDurationMs": 417.15500000000003,
"heapDeltaBytes": 25460148,
"heapUsedBytes": 88240860,
"domNodes": 0,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 131.062,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1010.3510000000142,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 654.2429999999999,
"heapDeltaBytes": 16363544,
"heapUsedBytes": 95811380,
"domNodes": 0,
"jsHeapTotalBytes": 16678912,
"scriptDurationMs": 51.742999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 381,
"frameDurationMs": 29.902941176470584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1001.6549999999143,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.1210000000001,
"heapDeltaBytes": 16165228,
"heapUsedBytes": 95796100,
"domNodes": 0,
"jsHeapTotalBytes": 17465344,
"scriptDurationMs": 44.988,
"eventListeners": 0,
"totalBlockingTimeMs": 372,
"frameDurationMs": 29.408823529411766,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 769.0959999999905,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.55700000000013,
"heapDeltaBytes": -6559056,
"heapUsedBytes": 72233044,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 108.72800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 152,
"frameDurationMs": 23.233333333333356,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 781.8059999999605,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.4400000000002,
"heapDeltaBytes": -5151800,
"heapUsedBytes": 73371168,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.75399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 23.04117647058825,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7420.125999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6516.979,
"heapDeltaBytes": -18545976,
"heapUsedBytes": 65074024,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 5051.635,
"eventListeners": 0,
"totalBlockingTimeMs": 20,
"frameDurationMs": 24.078896103896106,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7428.199000000006,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2750000000000001,
"layouts": 1,
"layoutDurationMs": 0.18900000000000036,
"taskDurationMs": 6557.354,
"heapDeltaBytes": 58688,
"heapUsedBytes": 83225388,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 5220.733,
"eventListeners": 0,
"totalBlockingTimeMs": 44,
"frameDurationMs": 23.619108280254775,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7146.704999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6322.906,
"heapDeltaBytes": -9485036,
"heapUsedBytes": 73689108,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 4995.993,
"eventListeners": 0,
"totalBlockingTimeMs": 160,
"frameDurationMs": 25.116197183098592,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7001.978000000008,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06100000000000029,
"layouts": 1,
"layoutDurationMs": 0.18400000000000014,
"taskDurationMs": 6265.226000000001,
"heapDeltaBytes": 11482964,
"heapUsedBytes": 94668284,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 4965.664000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 38,
"frameDurationMs": 24.38919860627178,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 168.687000000034,
"styleRecalcs": 23,
"styleRecalcDurationMs": 11.033999999999999,
"layouts": 11,
"layoutDurationMs": 2.4689999999999994,
"taskDurationMs": 125.444,
"heapDeltaBytes": 13254604,
"heapUsedBytes": 77419528,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.772,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.82499999999999,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-combo-open",
"durationMs": 157.7549999999519,
"styleRecalcs": 22,
"styleRecalcDurationMs": 10.825,
"layouts": 11,
"layoutDurationMs": 2.832,
"taskDurationMs": 109.97800000000002,
"heapDeltaBytes": 12996568,
"heapUsedBytes": 76505560,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.054000000000001,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.44285714285713,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2029.8510000000078,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5800000000000007,
"layouts": 7,
"layoutDurationMs": 1.423,
"taskDurationMs": 455.04999999999995,
"heapDeltaBytes": -29901348,
"heapUsedBytes": 69364020,
"domNodes": -258,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 26.899,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2021.408000000065,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9170000000000003,
"layouts": 8,
"layoutDurationMs": 1.866,
"taskDurationMs": 460.13500000000005,
"heapDeltaBytes": -16552768,
"heapUsedBytes": 68796724,
"domNodes": -258,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 27.373,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2164.1349999999875,
"styleRecalcs": 65,
"styleRecalcDurationMs": 5.020000000000001,
"layouts": 4,
"layoutDurationMs": 0.7200000000000002,
"taskDurationMs": 1212.864,
"heapDeltaBytes": 9957860,
"heapUsedBytes": 75825332,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 611.25,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589147286822,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2176.770000000033,
"styleRecalcs": 66,
"styleRecalcDurationMs": 5.3340000000000005,
"layouts": 5,
"layoutDurationMs": 1.003,
"taskDurationMs": 1249.549,
"heapDeltaBytes": 9911408,
"heapUsedBytes": 75409532,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 620.0219999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153847,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3238.958000000025,
"styleRecalcs": 70,
"styleRecalcDurationMs": 6.271,
"layouts": 63,
"layoutDurationMs": 9.068,
"taskDurationMs": 1322.3000000000002,
"heapDeltaBytes": 21093464,
"heapUsedBytes": 88363548,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 609.157,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665979381443297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3221.9010000000026,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.316999999999999,
"layouts": 63,
"layoutDurationMs": 9.347999999999999,
"taskDurationMs": 1335.6970000000001,
"heapDeltaBytes": 21894988,
"heapUsedBytes": 88970652,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 605.62,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580310880829,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2445.6670000000145,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.164999999999999,
"layouts": 3,
"layoutDurationMs": 0.736999999999999,
"taskDurationMs": 1492.0910000000001,
"heapDeltaBytes": 1270112,
"heapUsedBytes": 69907148,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 754.189,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.89655172413793,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2276.004999999941,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.422,
"layouts": 4,
"layoutDurationMs": 0.9229999999999998,
"taskDurationMs": 1480.6409999999998,
"heapDeltaBytes": 705940,
"heapUsedBytes": 67404696,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 729.823,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78962962962963,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.6350000000125,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.0839999999999999,
"layouts": 6,
"layoutDurationMs": 1.2109999999999999,
"taskDurationMs": 431.55,
"heapDeltaBytes": 5377480,
"heapUsedBytes": 70218856,
"domNodes": -259,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.135999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2023.033000000055,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6340000000000001,
"layouts": 8,
"layoutDurationMs": 1.587,
"taskDurationMs": 333.2029999999999,
"heapDeltaBytes": -31513512,
"heapUsedBytes": 70079140,
"domNodes": -258,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 27.040999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 533.157000000017,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.443,
"layouts": 10,
"layoutDurationMs": 2.376,
"taskDurationMs": 338.399,
"heapDeltaBytes": -2379820,
"heapUsedBytes": 71771984,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 115.09899999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 531.1149999999998,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.445,
"layouts": 10,
"layoutDurationMs": 2.4029999999999996,
"taskDurationMs": 347.0450000000001,
"heapDeltaBytes": 120256,
"heapUsedBytes": 80342928,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 118.27399999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.3819999999596,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.327,
"layouts": 10,
"layoutDurationMs": 2.2129999999999996,
"taskDurationMs": 418.922,
"heapDeltaBytes": -23826828,
"heapUsedBytes": 56265596,
"domNodes": -180,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 7.5169999999999995,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.1549999999643,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.4470000000000005,
"layouts": 10,
"layoutDurationMs": 2.142,
"taskDurationMs": 407.14000000000004,
"heapDeltaBytes": -6715412,
"heapUsedBytes": 58370116,
"domNodes": -180,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 7.339999999999999,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1977.6499999999828,
"styleRecalcs": 87,
"styleRecalcDurationMs": 12.531,
"layouts": 10,
"layoutDurationMs": 1.976,
"taskDurationMs": 905.467,
"heapDeltaBytes": -7414200,
"heapUsedBytes": 73213280,
"domNodes": -203,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 81.509,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665546218487396,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.7169999999687,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.544,
"layouts": 11,
"layoutDurationMs": 2.2929999999999997,
"taskDurationMs": 646.14,
"heapDeltaBytes": -1730088,
"heapUsedBytes": 78428308,
"domNodes": -180,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 80.911,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1131.2749999999596,
"styleRecalcs": 20,
"styleRecalcDurationMs": 20.224,
"layouts": 5,
"layoutDurationMs": 11.961,
"taskDurationMs": 806.174,
"heapDeltaBytes": 7911364,
"heapUsedBytes": 102889996,
"domNodes": 15950,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 22.311000000000003,
"eventListeners": 3244,
"totalBlockingTimeMs": 117,
"frameDurationMs": 19.489830508474586,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8160.721000000023,
"styleRecalcs": 249,
"styleRecalcDurationMs": 18.307999999999996,
"layouts": 7,
"layoutDurationMs": 1.5209999999999997,
"taskDurationMs": 3835.386,
"heapDeltaBytes": 17722496,
"heapUsedBytes": 81546064,
"domNodes": -258,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2055.954,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598360655738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8151.722000000063,
"styleRecalcs": 250,
"styleRecalcDurationMs": 18.155,
"layouts": 8,
"layoutDurationMs": 1.8600000000000005,
"taskDurationMs": 3930.317,
"heapDeltaBytes": -21283128,
"heapUsedBytes": 82134252,
"domNodes": -258,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 2120.702,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665848670756645,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 19419.76599999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18895.097999999998,
"heapDeltaBytes": -3382200,
"heapUsedBytes": 279755456,
"domNodes": -3330,
"jsHeapTotalBytes": 13619200,
"scriptDurationMs": 294.573,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.797128378378375,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-idle",
"durationMs": 19332.34799999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18805.176,
"heapDeltaBytes": -20051784,
"heapUsedBytes": 268753392,
"domNodes": -3330,
"jsHeapTotalBytes": 12570624,
"scriptDurationMs": 262.881,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.44723183391003,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 23474.26999999999,
"styleRecalcs": 180,
"styleRecalcDurationMs": 16.626999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23135.691,
"heapDeltaBytes": -24717808,
"heapUsedBytes": 278381928,
"domNodes": -3330,
"jsHeapTotalBytes": 10473472,
"scriptDurationMs": 720.8240000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.12634615384616,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 16811.144000000015,
"styleRecalcs": 120,
"styleRecalcDurationMs": 9.537000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16230.481999999998,
"heapDeltaBytes": 9417124,
"heapUsedBytes": 288497600,
"domNodes": -3330,
"jsHeapTotalBytes": 16433152,
"scriptDurationMs": 669.295,
"eventListeners": -651,
"totalBlockingTimeMs": 3,
"frameDurationMs": 30.519056261343014,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 7074.153000000024,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.845000000000006,
"layouts": 20,
"layoutDurationMs": 21.837999999999997,
"taskDurationMs": 6933.812000000001,
"heapDeltaBytes": -37252456,
"heapUsedBytes": 260611592,
"domNodes": -3330,
"jsHeapTotalBytes": 21483520,
"scriptDurationMs": 104.66399999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 14,
"frameDurationMs": 39.477094972067036,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7011.969000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.904,
"layouts": 20,
"layoutDurationMs": 21.114999999999995,
"taskDurationMs": 6903.856,
"heapDeltaBytes": -38337680,
"heapUsedBytes": 260111336,
"domNodes": -3330,
"jsHeapTotalBytes": 21221376,
"scriptDurationMs": 105.784,
"eventListeners": -653,
"totalBlockingTimeMs": 1,
"frameDurationMs": 39.64067796610169,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9688.451999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9445.985,
"heapDeltaBytes": 33158452,
"heapUsedBytes": 282420244,
"domNodes": 0,
"jsHeapTotalBytes": -20709376,
"scriptDurationMs": 124.50099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.73867595818815,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9989.114999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9575.598999999998,
"heapDeltaBytes": 8961288,
"heapUsedBytes": 285516040,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 142.04900000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.873049645390076,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 100.02799999995204,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.389,
"layouts": 7,
"layoutDurationMs": 2.463,
"taskDurationMs": 72.677,
"heapDeltaBytes": 4599164,
"heapUsedBytes": 80460052,
"domNodes": 97,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.803000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.68333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 109.5149999999876,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.721,
"layouts": 9,
"layoutDurationMs": 2.7270000000000003,
"taskDurationMs": 66.136,
"heapDeltaBytes": 4403432,
"heapUsedBytes": 80433152,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.687000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 272.8939999999511,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.705,
"layouts": 76,
"layoutDurationMs": 11.578,
"taskDurationMs": 229.01399999999998,
"heapDeltaBytes": 9552360,
"heapUsedBytes": 93753792,
"domNodes": 4,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 106.76299999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 279.1789999999992,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8630000000000001,
"layouts": 76,
"layoutDurationMs": 11.5,
"taskDurationMs": 247.251,
"heapDeltaBytes": 9750688,
"heapUsedBytes": 91268180,
"domNodes": 4,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 116.51100000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 330.6039999999939,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.591,
"layouts": 76,
"layoutDurationMs": 10.432,
"taskDurationMs": 282.544,
"heapDeltaBytes": -1673252,
"heapUsedBytes": 114322784,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 104.627,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 362.5000000000682,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.054,
"layouts": 76,
"layoutDurationMs": 11.608,
"taskDurationMs": 318.822,
"heapDeltaBytes": -1451276,
"heapUsedBytes": 114424228,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.906,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge.
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2280 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d6e1b1a8c01147e9b264a765dc22a9751092efe6
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## vinh/fe-2434-release-switcher-pr #20832 +/- ##
===================================================================
Coverage ? 87.21%
===================================================================
Files ? 2624
Lines ? 147484
Branches ? 40478
===================================================================
Hits ? 128623
Misses ? 18471
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation failed to run ( Evaluation budget remaining for this pull request: 99 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
wei-hai
left a comment
There was a problem hiding this comment.
Summary
This adds a Cloud-only deep link (?workspace= + ?deployment=) that runs before the existing workspace URL loader, switches workspace when needed (with a one-shot sessionStorage guard), strips query params before pick/reload, and calls the same deployment pick API the switcher uses. Sign-in preservation and the URL action loader ordering look correct for the platform “Open in ComfyUI” contract.
Reviewed the diff, spot-checked implementation on dbfcf089, and ran focused unit tests on the PR branch: 102 passed in useDeploymentUrlLoader.test.ts, deploymentPickStore.test.ts, and useUrlActionLoaders.test.ts.
Security (deeplink, auth, XSS, leakage)
Query handling — readLinkValue rejects empty, repeated, comma-joined, and non-string values; malformed links drop deployment (and leave workspace for the workspace loader when appropriate). Loader ordering prevents the workspace loader from stripping ?workspace before a cross-workspace deployment link can complete. That matches the threat model (no client-side trust in IDs; server decides membership and pick eligibility).
Auth — No new tokens in the URL; pick/switch still go through existing authenticated API calls. API-key sessions correctly skip deployment pick and only strip deployment. Refused switch/pick paths do not reload or change deployment state.
XSS — Refusal toasts use fixed i18n titles; server text goes to toast.error(..., { description: outcome.message }). Toaster.vue renders description with text interpolation ({{ item.description }}), so HTML in API error messages should not execute. linkWorkspaceRefused uses escapeParameter: false for the workspace name, which is consistent with other workspace toasts; the title is still text-bound in the toaster.
Open redirect — previousFullPath test for /?workspace=…&deployment=… stays within the existing “relative path only, no //” rules.
Abort / race — AbortSignal on pickDeployment, post-auth throwIfAborted, listing/selection backstops, and state-machine changes for link picks while listing is pending address the scary cases (late listing competing picks, hung pick after timeout) without applying a late successful pick after the user has moved on.
Tests
Coverage is strong for the behaviors called out in the PR body: loader order, reload short-circuit, sign-in stash, API-key path, malformed params, switch-once semantics, storage quota on the switch marker, timeout/cancel regressions, and competing-pick scenarios. I did not run Playwright or a manual staging pass (as noted in the PR).
Non-blocking follow-ups
- Staging smoke — Worth a quick manual check with platform#1379 on staging (signed out → sign in with full query, wrong workspace, flag off refusal, already on deployment).
- Server message in toasts — Showing raw API
messageis useful; if ingest ever returns verbose or unusual strings, consider reusing an existing safe-error helper or truncating for UX (not a blocker given text rendering).
Nice work on the boot-order comment and the regression tests around cleanup order and stalled listings. From a backend-adjacent perspective the client honors the PUT pick contract and does not broaden trust in query params beyond what the API already enforces.
|
For the smoke check with the Open in ComfyUI button, I have recorded the signed-out return with the full query, wrong workspace, flag-off refusal, and already-selected deployment cases. I am keeping the full server refusal message here: it tells the user why the deployment could not be opened, and the toast renders it as text. Truncating it now could remove that explanation. If a real response is too long or unclear, we can shorten that message or apply the shared error formatter with a concrete example. No code change for this suggestion. |
a275975 to
207a4ff
Compare
dbfcf08 to
b3516bb
Compare
|
/swarmhost evaluate |
…294) `/?workspace=<id>&deployment=<id>` opens the Cloud editor on that deployment. A new URL action loader runs before the `?workspace=` loader and owns both params when `deployment` is present: in another workspace it switches there (the switcher's own switch) and keeps the link for the boot after the reload, at most once per link; in the named workspace it strips both params and picks with the switcher's request, which reloads onto the deployment's nodes. A refused switch or pick shows the reason and changes nothing. An API-key session, or a link without both values, does nothing. `deployment` is stashed through sign-in like `workspace`. Ref BE-20294
b3516bb to
c8d4f95
Compare
|
🔗 Commit SHA: c8d4f95 | Docs | View more details | Give us feedback! |
|
Folded into #19965, so the switcher and the deployment link merge as one PR. |
…lector (Comfy-Org#19965) ## Summary A member of a workspace on Comfy Cloud can choose which of the workspace's developer-platform deployments this browser runs on, from a switcher under the workspace selector, and a workspace owner can set the workspace default. A link of the form `<cloud>/?workspace=<workspace id>&deployment=<deployment id>` opens the Cloud editor already running on that deployment, for the Developer Platform's **Open in ComfyUI** button and shared links. Ref [FE-2434](https://linear.app/comfyorg/issue/FE-2434), [BE-20294](https://linear.app/comfyorg/issue/BE-20294) (parent [BE-17141](https://linear.app/comfyorg/issue/BE-17141)), [BE-19175](https://linear.app/comfyorg/issue/BE-19175). Folds in Comfy-Org#20832. Folds in Comfy-Org#21009. Backend: cloud#9390 (pick), cloud#9645 (listing), cloud#10901 (workspace default). **Why**: studios on the Developer Platform (Contender's agencies first) want the Cloud editor with their own custom nodes and models. Today a Cloud workspace only runs on Comfy's own node set; the backend can already run a picked browser's jobs on a workspace deployment (cloud#9390, Comfy-Org#9578, run on staging), and this is the control that makes the pick. ## Changes - **What**: - `DeploymentSwitcher.vue` (with `DeploymentSwitcherList`, `DeploymentSwitcherRow`, `DeploymentSwitcherOwnerFooter` and `useDeploymentLabels`) under the workspace selector in the user popover. It shows "Running on: Comfy Cloud", or the picked deployment's name, and lists the workspace's deployments, each row titled by the deployment's name, with its Build name and the Release it runs now, its id and its status in the caption. A deployment the server returns without a name is titled by its Build name and Release version, and by its short id only when those are absent too. Picking one, or going back to Comfy Cloud, reloads the editor, because the pick changes what the editor is served at boot (the node catalog and the packs' JavaScript). - A pick names a deployment, not a Release: a deployment keeps its URL while its owner updates it to new Releases (stable deployments), so a pick follows those updates. - Workspace default: when this browser has no pick of its own it follows the default ("Workspace default"); a browser that picked can return to it ("Use the workspace default"); an owner sets or clears the default from the footer. The page reloads only when the change alters what this browser runs on. - `workspaceApi`: GET `/api/workspaces/{id}/deployments`, PUT/DELETE `/api/workspaces/{id}/deployment` (DELETE with `?follow=workspace`), PUT/DELETE `/api/workspaces/{id}/default-deployment`; the shared automock gains the five methods. - `deploymentPickStore` and `deploymentPickState` hold the listing and the pick state; the pick itself is an HttpOnly cookie the editor never reads. - The switcher renders nothing until the listing answers, and nothing when the account is outside the rollout (`cloud_on_customer_build_enabled`), so nobody sees a control they cannot use. A refused pick shows the server's message as a toast and reloads nothing. - Deployment link (`?workspace=<id>&deployment=<id>`), handled by the new `useDeploymentUrlLoader`, run first among the URL action loaders because with `?deployment` it handles `?workspace` too: - In the named workspace: the two params are removed from the address, then the deployment is picked with the switcher's own request (`deploymentPickStore.pickFromLink`), which reloads the editor onto the deployment's nodes. A link to the deployment this browser already runs on just removes the params. - In another workspace: the editor switches to the named workspace first, with the workspace switcher's own switch, and keeps the link for the page that loads after the switch, which then picks. A switch happens at most once per link, so a switch that does not land never reloads again; if the browser cannot save that marker, the link stays in the current workspace and shows a refusal. - Refused: someone outside the workspace stays where they are, with a toast saying which workspace they are still in. A refused pick (account outside the rollout, a deployment that is gone or not the workspace's) shows the server's message as a toast; the params are removed and nothing changes. - Signed out: sign-in already returns to the full address, query included (`previousFullPath`); `deployment` is also stashed through the sign-in redirect the same way `workspace` is (`preservedQueryDefinitions`). - Not acted on: a link missing either value, a bare or repeated value, an API-key session, and non-Cloud builds. - Bounded: the first deployment listing and the pick each have the shared 45-second startup limit (the 30-second request deadline plus time for authorization). Past it the editor continues startup, asks the user to reopen the link, and cancels the pending request; a late listing, authorization or response cannot pick or reload. Picks are serialized, so a later listing cannot start a competing pick. Three new strings under `deploymentSwitcher`. - **Dependencies**: none new. `WorkspaceDeployment`, `WorkspaceDeploymentList` and `PickWorkspaceDeploymentRequest` come from `@comfyorg/ingest-types`. ## Review Focus - The reload on pick: the editor's node catalog and pack JavaScript are fixed at boot, so a pick reloads instead of swapping in place. - Hidden until the listing answers and outside the rollout. - The deployment link's order against the `?workspace=` loader, and its 45-second startup limit. ## Screenshots (if applicable) Screenshots: in the review ask's Slack thread, and on [FE-2434](https://linear.app/comfyorg/issue/FE-2434) (the switcher, seven states, taken on staging from this branch) and [BE-20294](https://linear.app/comfyorg/issue/BE-20294) (the deployment link, four states, from the local end-to-end test). Design follow-up: once this is on staging, Willie and Pablo use it there and iterate on it; their changes come as follow-up PRs ([BE-20668](https://linear.app/comfyorg/issue/BE-20668)). Try it: [Storybook, Components/DeploymentSwitcher](https://cdd7cb47.comfy-storybook.pages.dev/?path=/story/components-deploymentswitcher--default) (built from this PR's head; the stories cover a pick, the workspace default, a gone default, no deployments, hidden build names and named deployments). Against staging: `pnpm dev:cloud:staging` from this branch, then the account menu, under the workspace selector. For the link, sign in and open `http://localhost:5173/?workspace=<your team workspace id>&deployment=<a deployment id in that workspace>`: with `cloud_on_customer_build_enabled` on for the workspace the editor reloads onto the deployment; with it off you get the refusal toast and nothing changes. Tested: unit tests for the switcher, its labels, its store, the boot listing, the missing-model scan and the deployment link (`useDeploymentUrlLoader`, `pickFromLink`, the URL action order, the sign-in stash, the startup limit and cancellation); the link end to end locally; on staging from this branch (real deployment listing, a pick and its reload, setting and clearing the workspace default, a node the Release lacks). Not run: the browser (Playwright) suite locally; CI runs it.
Why
Homestead's MVP opens a deployment's editor from the Developer Platform's Open in ComfyUI button or a shared link (BE-20294, job 24 of the Homestead MVP TDD). Before this, the only way onto a deployment was to open Cloud and pick it in the account menu's switcher, so there was nothing for that button to link to.
Summary
A link of the form
<cloud>/?workspace=<workspace id>&deployment=<deployment id>opens the Cloud editor already running on that deployment. Before, the only way onto a deployment was to open Cloud and pick it in the account menu's switcher.Ref BE-20294.
In the named workspace: the two params are removed from the address, then the deployment is picked with the switcher's own request (
PUT /api/workspaces/{id}/deployment), which reloads the editor onto the deployment's nodes. A link to the deployment this browser already runs on just removes the params.In another workspace: the editor switches to the named workspace first, with the workspace switcher's own switch, and keeps the link for the page that loads after the switch, which then picks. A switch happens at most once per link, so a switch that does not land never reloads again.
Refused: someone outside the workspace stays where they are, with a toast saying which workspace they are still in. A refused pick (account outside the rollout, a deployment that is gone or not the workspace's) shows the server's message as a toast; the params are removed and nothing changes.
Signed out: sign-in already returns to the full address, query included (
previousFullPath);deploymentis also stashed through the sign-in redirect the same wayworkspaceis (preservedQueryDefinitions).Not acted on: a link missing either value, a bare or repeated value, an API-key session, and non-Cloud builds.
New
useDeploymentUrlLoader, run first among the URL action loaders because with?deploymentit handles?workspacetoo;deploymentPickStore.pickFromLinkuses the existing pick API with a bounded wait and request cancellation. Three new strings underdeploymentSwitcher.If the initial deployment listing exceeds the shared 45-second startup limit (the 30-second request deadline plus time for authorization), the editor continues startup and asks the user to reopen the link. A late listing cannot trigger a delayed pick.
If the browser cannot save the workspace retry marker, the link stays in the current workspace and shows a refusal instead of attempting a reload.
Deployment selection stays busy even without a successful listing, so later listings cannot enable a competing selection.
The selection attempt has its own 45-second limit, including authorization. On timeout, startup continues and the pending request is canceled. Late authorization cannot send a selection, and a late response cannot reload the editor.
Verification
useDeploymentUrlLoader.test.ts(no link; same workspace strips then picks; other workspace switches, then picks on the next load; refused switch; a switch that did not land is not retried; refused pick shows the server's message and strips the params; already on the deployment; link carried through the sign-in stash; API-key login; missing, empty, bare and repeated values),deploymentPickStore.test.ts(pickFromLink: picks after the first listing, no-op on the current deployment, server refusal outside the rollout, refused pick),useUrlActionLoaders.test.ts(runs before the workspace link, stops before every other step when it reloads, off on non-Cloud),previousFullPath.test.ts(the link's query survives sign-in),preservedQueryDefinitions.test.ts.pnpm typecheck, eslint and oxlint on the changed files: clean.Screenshots from the local end-to-end test, also attached to BE-20294:
Try it: run this branch with
pnpm devagainst Cloud staging, sign in, and openhttp://localhost:5173/?workspace=<your team workspace id>&deployment=<a deployment id in that workspace>. Withcloud_on_customer_build_enabledon for the workspace the editor reloads onto the deployment; with it off you get the refusal toast and nothing changes.