Skip to content

BE-20294 feat(workspace): a link opens the editor on a named deployment - #20832

Closed
vqt123 wants to merge 5 commits into
vinh/fe-2434-release-switcher-prfrom
vinh/be-20294-open-ui-link
Closed

vqt123 wants to merge 5 commits into
vinh/fe-2434-release-switcher-prfrom
vinh/be-20294-open-ui-link

Conversation

@vqt123

@vqt123 vqt123 commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Why

Homestead's MVP opens a deployment's editor from the Developer Platform's Open in ComfyUI button or a shared link (BE-20294, job 24 of the Homestead MVP TDD). Before this, the only way onto a deployment was to open Cloud and pick it in the account menu's switcher, so there was nothing for that button to link to.

Summary

A link of the form <cloud>/?workspace=<workspace id>&deployment=<deployment id> opens the Cloud editor already running on that deployment. Before, the only way onto a deployment was to open Cloud and pick it in the account menu's switcher.

Ref BE-20294.

  • In the named workspace: the two params are removed from the address, then the deployment is picked with the switcher's own request (PUT /api/workspaces/{id}/deployment), which reloads the editor onto the deployment's nodes. A link to the deployment this browser already runs on just removes the params.

  • In another workspace: the editor switches to the named workspace first, with the workspace switcher's own switch, and keeps the link for the page that loads after the switch, which then picks. A switch happens at most once per link, so a switch that does not land never reloads again.

  • Refused: someone outside the workspace stays where they are, with a toast saying which workspace they are still in. A refused pick (account outside the rollout, a deployment that is gone or not the workspace's) shows the server's message as a toast; the params are removed and nothing changes.

  • Signed out: sign-in already returns to the full address, query included (previousFullPath); deployment is also stashed through the sign-in redirect the same way workspace is (preservedQueryDefinitions).

  • Not acted on: a link missing either value, a bare or repeated value, an API-key session, and non-Cloud builds.

  • New useDeploymentUrlLoader, run first among the URL action loaders because with ?deployment it handles ?workspace too; deploymentPickStore.pickFromLink uses the existing pick API with a bounded wait and request cancellation. Three new strings under deploymentSwitcher.

  • If the initial deployment listing exceeds the shared 45-second startup limit (the 30-second request deadline plus time for authorization), the editor continues startup and asks the user to reopen the link. A late listing cannot trigger a delayed pick.

  • If the browser cannot save the workspace retry marker, the link stays in the current workspace and shows a refusal instead of attempting a reload.

  • Deployment selection stays busy even without a successful listing, so later listings cannot enable a competing selection.

  • The selection attempt has its own 45-second limit, including authorization. On timeout, startup continues and the pending request is canceled. Late authorization cannot send a selection, and a late response cannot reload the editor.

Verification

  • Unit tests: useDeploymentUrlLoader.test.ts (no link; same workspace strips then picks; other workspace switches, then picks on the next load; refused switch; a switch that did not land is not retried; refused pick shows the server's message and strips the params; already on the deployment; link carried through the sign-in stash; API-key login; missing, empty, bare and repeated values), deploymentPickStore.test.ts (pickFromLink: picks after the first listing, no-op on the current deployment, server refusal outside the rollout, refused pick), useUrlActionLoaders.test.ts (runs before the workspace link, stops before every other step when it reloads, off on non-Cloud), previousFullPath.test.ts (the link's query survives sign-in), preservedQueryDefinitions.test.ts.
  • Focused unit tests: 190 passing across the workspace API, deployment state, store, URL loader and URL action chain. Regression tests reproduce competing picks, a stalled listing and unavailable browser storage before the fixes; the cleanup-order test fails when its production wait is removed. Slow successful listings still select the deployment at 12 seconds and just before the startup limit; stalled listings stop at that limit without picking later.
  • Selection-timeout regressions cover a stalled request after a failed listing, cancellation reaching the transport, late authorization, and a late successful response without a reload.
  • pnpm typecheck, eslint and oxlint on the changed files: clean.
  • Not run: on staging, and the browser (Playwright) suite locally.

Screenshots from the local end-to-end test, also attached to BE-20294:

Before the link

After the link: the Release catalog

Running on the named deployment

Refused with the flag off

Try it: run this branch with pnpm dev against Cloud staging, sign in, and open http://localhost:5173/?workspace=<your team workspace id>&deployment=<a deployment id in that workspace>. With cloud_on_customer_build_enabled on for the workspace the editor reloads onto the deployment; with it off you get the refusal toast and nothing changes.

@vqt123 vqt123 added the ai-assisted Written by a person driving an AI coding agent. Informational: no automation reads it. label Oct 12, 2026
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 2b51df63-7541-464f-833c-3ecafc8bebb8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.9 MB heap
dom-widget-order-dense-n200-w200-i120: · 33.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 377ms TBT · 91.4 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 43.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 156ms TBT · 69.4 MB heap
extension-clean-combined-draw: · 41.9 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 32ms TBT · 70.7 MB heap
extension-rgthree-prototype-draw: · 40.4 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 99ms TBT · 80.3 MB heap
large-combo-open: · 47.3 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 73.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.6 MB heap
legacy-node-drag: · 59.4 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
subgraph-transition-enter: · 51.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 117ms TBT · 98.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.0 MB heap
vue-large-graph-idle: · 30.2 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 261.5 MB heap
vue-large-graph-pan: · 26.4 avg FPS · 13.3 P5 FPS ❌ (target: ≥52) · 2ms TBT · 270.3 MB heap
vue-node-resize-workload: · 25.3 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 8ms TBT · 248.3 MB heap
vue-zoom-out-idle: · 28.7 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 270.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.7 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.2 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 109.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 3ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 10
canvas-idle: style recalc count 10
canvas-idle: task duration 450ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 74.8 MB
canvas-idle: DOM nodes -162
canvas-idle: event listeners -68
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 12ms
canvas-mouse-sweep: layout count 8
canvas-mouse-sweep: style recalc count 67
canvas-mouse-sweep: task duration 903ms
canvas-mouse-sweep: script duration 125ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 74.0 MB
canvas-mouse-sweep: DOM nodes -162
canvas-mouse-sweep: event listeners -68
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 2ms
canvas-zoom-sweep: style recalc duration 4ms
canvas-zoom-sweep: layout count 11
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 329ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 77.3 MB
canvas-zoom-sweep: DOM nodes 47
canvas-zoom-sweep: event listeners 37
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 2ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 10
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 400ms
dom-widget-clipping: script duration 131ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 81.9 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 30ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 647ms
dom-widget-order-dense-n200-w200-i120: script duration 48ms
dom-widget-order-dense-n200-w200-i120: TBT 377ms
dom-widget-order-dense-n200-w200-i120: heap used 91.4 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 23ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 367ms
dom-widget-order-sparse-n1000-w20-i120: script duration 113ms
dom-widget-order-sparse-n1000-w20-i120: TBT 156ms
dom-widget-order-sparse-n1000-w20-i120: heap used 69.4 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 24ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 1
extension-clean-combined-draw: style recalc count 1
extension-clean-combined-draw: task duration 6537ms
extension-clean-combined-draw: script duration 5136ms
extension-clean-combined-draw: TBT 32ms
extension-clean-combined-draw: heap used 70.7 MB
extension-clean-combined-draw: DOM nodes 0
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 25ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 1
extension-rgthree-prototype-draw: style recalc count 1
extension-rgthree-prototype-draw: task duration 6294ms
extension-rgthree-prototype-draw: script duration 4981ms
extension-rgthree-prototype-draw: TBT 99ms
extension-rgthree-prototype-draw: heap used 80.3 MB
extension-rgthree-prototype-draw: DOM nodes 0
extension-rgthree-prototype-draw: event listeners 0
large-combo-open: avg frame time 21ms
large-combo-open: p95 frame time 50ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 11ms
large-combo-open: layout count 11
large-combo-open: style recalc count 23
large-combo-open: task duration 118ms
large-combo-open: script duration 7ms
large-combo-open: TBT 0ms
large-combo-open: heap used 73.4 MB
large-combo-open: DOM nodes 917
large-combo-open: event listeners 195
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 8
large-graph-idle: style recalc count 8
large-graph-idle: task duration 458ms
large-graph-idle: script duration 27ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 65.9 MB
large-graph-idle: DOM nodes -258
large-graph-idle: event listeners -68
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 1ms
large-graph-pan: style recalc duration 5ms
large-graph-pan: layout count 5
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1231ms
large-graph-pan: script duration 616ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 72.1 MB
large-graph-pan: DOM nodes 0
large-graph-pan: event listeners 2
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 9ms
large-graph-zoom: style recalc duration 6ms
large-graph-zoom: layout count 63
large-graph-zoom: style recalc count 70
large-graph-zoom: task duration 1329ms
large-graph-zoom: script duration 607ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 84.6 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 4ms
legacy-node-drag: layout count 4
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 1486ms
legacy-node-drag: script duration 742ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 65.5 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 1ms
minimap-idle: style recalc duration 1ms
minimap-idle: layout count 7
minimap-idle: style recalc count 7
minimap-idle: task duration 382ms
minimap-idle: script duration 28ms
minimap-idle: TBT 0ms
minimap-idle: heap used 66.9 MB
minimap-idle: DOM nodes -259
minimap-idle: event listeners -34
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 2ms
subgraph-dom-widget-clipping: style recalc duration 4ms
subgraph-dom-widget-clipping: layout count 10
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 343ms
subgraph-dom-widget-clipping: script duration 117ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 72.5 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 2ms
subgraph-idle: style recalc duration 2ms
subgraph-idle: layout count 10
subgraph-idle: style recalc count 11
subgraph-idle: task duration 413ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 54.7 MB
subgraph-idle: DOM nodes -180
subgraph-idle: event listeners -114
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 2ms
subgraph-mouse-sweep: style recalc duration 12ms
subgraph-mouse-sweep: layout count 11
subgraph-mouse-sweep: style recalc count 81
subgraph-mouse-sweep: task duration 776ms
subgraph-mouse-sweep: script duration 81ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 72.3 MB
subgraph-mouse-sweep: DOM nodes -192
subgraph-mouse-sweep: event listeners -114
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 20ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 806ms
subgraph-transition-enter: script duration 22ms
subgraph-transition-enter: TBT 117ms
subgraph-transition-enter: heap used 98.1 MB
subgraph-transition-enter: DOM nodes 15950
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 18ms
viewport-pan-sweep: layout count 8
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 3883ms
viewport-pan-sweep: script duration 2088ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 78.0 MB
viewport-pan-sweep: DOM nodes -258
viewport-pan-sweep: event listeners -66
vue-large-graph-idle: avg frame time 33ms
vue-large-graph-idle: p95 frame time 67ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 18850ms
vue-large-graph-idle: script duration 279ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 261.5 MB
vue-large-graph-idle: DOM nodes -3330
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 38ms
vue-large-graph-pan: p95 frame time 75ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 13ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 150
vue-large-graph-pan: task duration 19683ms
vue-large-graph-pan: script duration 695ms
vue-large-graph-pan: TBT 2ms
vue-large-graph-pan: heap used 270.3 MB
vue-large-graph-pan: DOM nodes -3330
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 40ms
vue-node-resize-workload: p95 frame time 83ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 53ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6919ms
vue-node-resize-workload: script duration 105ms
vue-node-resize-workload: TBT 8ms
vue-node-resize-workload: heap used 248.3 MB
vue-node-resize-workload: DOM nodes -3330
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 35ms
vue-zoom-out-idle: p95 frame time 67ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 9511ms
vue-zoom-out-idle: script duration 133ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 270.8 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 3ms
workflow-execution: style recalc duration 9ms
workflow-execution: layout count 8
workflow-execution: style recalc count 9
workflow-execution: task duration 69ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 76.7 MB
workflow-execution: DOM nodes 107
workflow-execution: event listeners 1
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 12ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 238ms
agent-composer-empty-conversation-typing: script duration 112ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 88.2 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 11ms
agent-composer-long-conversation-typing: style recalc duration 2ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 301ms
agent-composer-long-conversation-typing: script duration 110ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 109.1 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-14T17:23:23.933Z",
  "gitSha": "72e3b4f685908c6e75fe241e8cfe15ad9c4d32f5",
  "branch": "vinh/be-20294-open-ui-link",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2007.440000000031,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.296,
      "layouts": 10,
      "layoutDurationMs": 2.2929999999999997,
      "taskDurationMs": 425.465,
      "heapDeltaBytes": -562164,
      "heapUsedBytes": 77640908,
      "domNodes": -162,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 8.161999999999999,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2008.0900000000383,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.6699999999999995,
      "layouts": 10,
      "layoutDurationMs": 2.7740000000000005,
      "taskDurationMs": 473.808,
      "heapDeltaBytes": 1007936,
      "heapUsedBytes": 79263912,
      "domNodes": -162,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 10.887,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1961.05399999999,
      "styleRecalcs": 83,
      "styleRecalcDurationMs": 12.400999999999998,
      "layouts": 10,
      "layoutDurationMs": 2.182,
      "taskDurationMs": 901.485,
      "heapDeltaBytes": -595092,
      "heapUsedBytes": 77502328,
      "domNodes": -162,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 117.967,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665254237288135,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1876.967000000036,
      "styleRecalcs": 51,
      "styleRecalcDurationMs": 11.706999999999999,
      "layouts": 6,
      "layoutDurationMs": 2.2140000000000004,
      "taskDurationMs": 904.463,
      "heapDeltaBytes": -562532,
      "heapUsedBytes": 77633396,
      "domNodes": -162,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 132.833,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666371681415928,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1699.7539999999844,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 3.85,
      "layouts": 10,
      "layoutDurationMs": 1.8999999999999997,
      "taskDurationMs": 297.019,
      "heapDeltaBytes": 16897056,
      "heapUsedBytes": 79670208,
      "domNodes": 47,
      "jsHeapTotalBytes": 2621440,
      "scriptDurationMs": 9.616000000000001,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66568627450981,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1807.6449999999795,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.29,
      "layouts": 12,
      "layoutDurationMs": 2.355,
      "taskDurationMs": 360.12,
      "heapDeltaBytes": 18038572,
      "heapUsedBytes": 82408196,
      "domNodes": 47,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 9.655000000000001,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66605504587156,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 550.2749999999992,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 2.9110000000000005,
      "layouts": 11,
      "layoutDurationMs": 2.4920000000000004,
      "taskDurationMs": 383.26700000000005,
      "heapDeltaBytes": 5305648,
      "heapUsedBytes": 83542288,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 131.333,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663636363636368,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 582.4770000000399,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 2.4920000000000004,
      "layouts": 9,
      "layoutDurationMs": 2.255,
      "taskDurationMs": 417.15500000000003,
      "heapDeltaBytes": 25460148,
      "heapUsedBytes": 88240860,
      "domNodes": 0,
      "jsHeapTotalBytes": 2359296,
      "scriptDurationMs": 131.062,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665714285714277,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1010.3510000000142,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 654.2429999999999,
      "heapDeltaBytes": 16363544,
      "heapUsedBytes": 95811380,
      "domNodes": 0,
      "jsHeapTotalBytes": 16678912,
      "scriptDurationMs": 51.742999999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 381,
      "frameDurationMs": 29.902941176470584,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1001.6549999999143,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 640.1210000000001,
      "heapDeltaBytes": 16165228,
      "heapUsedBytes": 95796100,
      "domNodes": 0,
      "jsHeapTotalBytes": 17465344,
      "scriptDurationMs": 44.988,
      "eventListeners": 0,
      "totalBlockingTimeMs": 372,
      "frameDurationMs": 29.408823529411766,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 769.0959999999905,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 347.55700000000013,
      "heapDeltaBytes": -6559056,
      "heapUsedBytes": 72233044,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 108.72800000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 152,
      "frameDurationMs": 23.233333333333356,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 781.8059999999605,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 387.4400000000002,
      "heapDeltaBytes": -5151800,
      "heapUsedBytes": 73371168,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 116.75399999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 159,
      "frameDurationMs": 23.04117647058825,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7420.125999999982,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6516.979,
      "heapDeltaBytes": -18545976,
      "heapUsedBytes": 65074024,
      "domNodes": 0,
      "jsHeapTotalBytes": 2097152,
      "scriptDurationMs": 5051.635,
      "eventListeners": 0,
      "totalBlockingTimeMs": 20,
      "frameDurationMs": 24.078896103896106,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7428.199000000006,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.2750000000000001,
      "layouts": 1,
      "layoutDurationMs": 0.18900000000000036,
      "taskDurationMs": 6557.354,
      "heapDeltaBytes": 58688,
      "heapUsedBytes": 83225388,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 5220.733,
      "eventListeners": 0,
      "totalBlockingTimeMs": 44,
      "frameDurationMs": 23.619108280254775,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 7146.704999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6322.906,
      "heapDeltaBytes": -9485036,
      "heapUsedBytes": 73689108,
      "domNodes": 0,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 4995.993,
      "eventListeners": 0,
      "totalBlockingTimeMs": 160,
      "frameDurationMs": 25.116197183098592,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 7001.978000000008,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.06100000000000029,
      "layouts": 1,
      "layoutDurationMs": 0.18400000000000014,
      "taskDurationMs": 6265.226000000001,
      "heapDeltaBytes": 11482964,
      "heapUsedBytes": 94668284,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 4965.664000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 38,
      "frameDurationMs": 24.38919860627178,
      "p95FrameDurationMs": 33.40000000000009
    },
    {
      "name": "large-combo-open",
      "durationMs": 168.687000000034,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 11.033999999999999,
      "layouts": 11,
      "layoutDurationMs": 2.4689999999999994,
      "taskDurationMs": 125.444,
      "heapDeltaBytes": 13254604,
      "heapUsedBytes": 77419528,
      "domNodes": 917,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.772,
      "eventListeners": 195,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.82499999999999,
      "p95FrameDurationMs": 49.90000000000009
    },
    {
      "name": "large-combo-open",
      "durationMs": 157.7549999999519,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 10.825,
      "layouts": 11,
      "layoutDurationMs": 2.832,
      "taskDurationMs": 109.97800000000002,
      "heapDeltaBytes": 12996568,
      "heapUsedBytes": 76505560,
      "domNodes": 917,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.054000000000001,
      "eventListeners": 195,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.44285714285713,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2029.8510000000078,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 1.5800000000000007,
      "layouts": 7,
      "layoutDurationMs": 1.423,
      "taskDurationMs": 455.04999999999995,
      "heapDeltaBytes": -29901348,
      "heapUsedBytes": 69364020,
      "domNodes": -258,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 26.899,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665573770491804,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2021.408000000065,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 1.9170000000000003,
      "layouts": 8,
      "layoutDurationMs": 1.866,
      "taskDurationMs": 460.13500000000005,
      "heapDeltaBytes": -16552768,
      "heapUsedBytes": 68796724,
      "domNodes": -258,
      "jsHeapTotalBytes": -524288,
      "scriptDurationMs": 27.373,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760327,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2164.1349999999875,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 5.020000000000001,
      "layouts": 4,
      "layoutDurationMs": 0.7200000000000002,
      "taskDurationMs": 1212.864,
      "heapDeltaBytes": 9957860,
      "heapUsedBytes": 75825332,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 611.25,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66589147286822,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2176.770000000033,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 5.3340000000000005,
      "layouts": 5,
      "layoutDurationMs": 1.003,
      "taskDurationMs": 1249.549,
      "heapDeltaBytes": 9911408,
      "heapUsedBytes": 75409532,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 620.0219999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666153846153847,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3238.958000000025,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 6.271,
      "layouts": 63,
      "layoutDurationMs": 9.068,
      "taskDurationMs": 1322.3000000000002,
      "heapDeltaBytes": 21093464,
      "heapUsedBytes": 88363548,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 609.157,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665979381443297,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3221.9010000000026,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 6.316999999999999,
      "layouts": 63,
      "layoutDurationMs": 9.347999999999999,
      "taskDurationMs": 1335.6970000000001,
      "heapDeltaBytes": 21894988,
      "heapUsedBytes": 88970652,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 605.62,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66580310880829,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2445.6670000000145,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 4.164999999999999,
      "layouts": 3,
      "layoutDurationMs": 0.736999999999999,
      "taskDurationMs": 1492.0910000000001,
      "heapDeltaBytes": 1270112,
      "heapUsedBytes": 69907148,
      "domNodes": 0,
      "jsHeapTotalBytes": 2621440,
      "scriptDurationMs": 754.189,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.89655172413793,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2276.004999999941,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 4.422,
      "layouts": 4,
      "layoutDurationMs": 0.9229999999999998,
      "taskDurationMs": 1480.6409999999998,
      "heapDeltaBytes": 705940,
      "heapUsedBytes": 67404696,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 729.823,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.78962962962963,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2011.6350000000125,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 1.0839999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.2109999999999999,
      "taskDurationMs": 431.55,
      "heapDeltaBytes": 5377480,
      "heapUsedBytes": 70218856,
      "domNodes": -259,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 28.135999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2023.033000000055,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.6340000000000001,
      "layouts": 8,
      "layoutDurationMs": 1.587,
      "taskDurationMs": 333.2029999999999,
      "heapDeltaBytes": -31513512,
      "heapUsedBytes": 70079140,
      "domNodes": -258,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 27.040999999999997,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 533.157000000017,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 4.443,
      "layouts": 10,
      "layoutDurationMs": 2.376,
      "taskDurationMs": 338.399,
      "heapDeltaBytes": -2379820,
      "heapUsedBytes": 71771984,
      "domNodes": 0,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 115.09899999999999,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66562499999999,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 531.1149999999998,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 4.445,
      "layouts": 10,
      "layoutDurationMs": 2.4029999999999996,
      "taskDurationMs": 347.0450000000001,
      "heapDeltaBytes": 120256,
      "heapUsedBytes": 80342928,
      "domNodes": 0,
      "jsHeapTotalBytes": 8912896,
      "scriptDurationMs": 118.27399999999999,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665625000000006,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2009.3819999999596,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.327,
      "layouts": 10,
      "layoutDurationMs": 2.2129999999999996,
      "taskDurationMs": 418.922,
      "heapDeltaBytes": -23826828,
      "heapUsedBytes": 56265596,
      "domNodes": -180,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 7.5169999999999995,
      "eventListeners": -114,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2009.1549999999643,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.4470000000000005,
      "layouts": 10,
      "layoutDurationMs": 2.142,
      "taskDurationMs": 407.14000000000004,
      "heapDeltaBytes": -6715412,
      "heapUsedBytes": 58370116,
      "domNodes": -180,
      "jsHeapTotalBytes": 2359296,
      "scriptDurationMs": 7.339999999999999,
      "eventListeners": -114,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1977.6499999999828,
      "styleRecalcs": 87,
      "styleRecalcDurationMs": 12.531,
      "layouts": 10,
      "layoutDurationMs": 1.976,
      "taskDurationMs": 905.467,
      "heapDeltaBytes": -7414200,
      "heapUsedBytes": 73213280,
      "domNodes": -203,
      "jsHeapTotalBytes": 8650752,
      "scriptDurationMs": 81.509,
      "eventListeners": -114,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665546218487396,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1694.7169999999687,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 11.544,
      "layouts": 11,
      "layoutDurationMs": 2.2929999999999997,
      "taskDurationMs": 646.14,
      "heapDeltaBytes": -1730088,
      "heapUsedBytes": 78428308,
      "domNodes": -180,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 80.911,
      "eventListeners": -114,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1131.2749999999596,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 20.224,
      "layouts": 5,
      "layoutDurationMs": 11.961,
      "taskDurationMs": 806.174,
      "heapDeltaBytes": 7911364,
      "heapUsedBytes": 102889996,
      "domNodes": 15950,
      "jsHeapTotalBytes": 16916480,
      "scriptDurationMs": 22.311000000000003,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 117,
      "frameDurationMs": 19.489830508474586,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8160.721000000023,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 18.307999999999996,
      "layouts": 7,
      "layoutDurationMs": 1.5209999999999997,
      "taskDurationMs": 3835.386,
      "heapDeltaBytes": 17722496,
      "heapUsedBytes": 81546064,
      "domNodes": -258,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 2055.954,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66598360655738,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8151.722000000063,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 18.155,
      "layouts": 8,
      "layoutDurationMs": 1.8600000000000005,
      "taskDurationMs": 3930.317,
      "heapDeltaBytes": -21283128,
      "heapUsedBytes": 82134252,
      "domNodes": -258,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 2120.702,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665848670756645,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 19419.76599999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18895.097999999998,
      "heapDeltaBytes": -3382200,
      "heapUsedBytes": 279755456,
      "domNodes": -3330,
      "jsHeapTotalBytes": 13619200,
      "scriptDurationMs": 294.573,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 32.797128378378375,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 19332.34799999991,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18805.176,
      "heapDeltaBytes": -20051784,
      "heapUsedBytes": 268753392,
      "domNodes": -3330,
      "jsHeapTotalBytes": 12570624,
      "scriptDurationMs": 262.881,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 33.44723183391003,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23474.26999999999,
      "styleRecalcs": 180,
      "styleRecalcDurationMs": 16.626999999999974,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23135.691,
      "heapDeltaBytes": -24717808,
      "heapUsedBytes": 278381928,
      "domNodes": -3330,
      "jsHeapTotalBytes": 10473472,
      "scriptDurationMs": 720.8240000000001,
      "eventListeners": -651,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 45.12634615384616,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16811.144000000015,
      "styleRecalcs": 120,
      "styleRecalcDurationMs": 9.537000000000017,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16230.481999999998,
      "heapDeltaBytes": 9417124,
      "heapUsedBytes": 288497600,
      "domNodes": -3330,
      "jsHeapTotalBytes": 16433152,
      "scriptDurationMs": 669.295,
      "eventListeners": -651,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 30.519056261343014,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7074.153000000024,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 53.845000000000006,
      "layouts": 20,
      "layoutDurationMs": 21.837999999999997,
      "taskDurationMs": 6933.812000000001,
      "heapDeltaBytes": -37252456,
      "heapUsedBytes": 260611592,
      "domNodes": -3330,
      "jsHeapTotalBytes": 21483520,
      "scriptDurationMs": 104.66399999999999,
      "eventListeners": -653,
      "totalBlockingTimeMs": 14,
      "frameDurationMs": 39.477094972067036,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7011.969000000022,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 52.904,
      "layouts": 20,
      "layoutDurationMs": 21.114999999999995,
      "taskDurationMs": 6903.856,
      "heapDeltaBytes": -38337680,
      "heapUsedBytes": 260111336,
      "domNodes": -3330,
      "jsHeapTotalBytes": 21221376,
      "scriptDurationMs": 105.784,
      "eventListeners": -653,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 39.64067796610169,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9688.451999999983,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9445.985,
      "heapDeltaBytes": 33158452,
      "heapUsedBytes": 282420244,
      "domNodes": 0,
      "jsHeapTotalBytes": -20709376,
      "scriptDurationMs": 124.50099999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 33.73867595818815,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9989.114999999969,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9575.598999999998,
      "heapDeltaBytes": 8961288,
      "heapUsedBytes": 285516040,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 142.04900000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 35.873049645390076,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "workflow-execution",
      "durationMs": 100.02799999995204,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.389,
      "layouts": 7,
      "layoutDurationMs": 2.463,
      "taskDurationMs": 72.677,
      "heapDeltaBytes": 4599164,
      "heapUsedBytes": 80460052,
      "domNodes": 97,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.803000000000001,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.68333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 109.5149999999876,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.721,
      "layouts": 9,
      "layoutDurationMs": 2.7270000000000003,
      "taskDurationMs": 66.136,
      "heapDeltaBytes": 4403432,
      "heapUsedBytes": 80433152,
      "domNodes": 117,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.687000000000001,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 272.8939999999511,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.705,
      "layouts": 76,
      "layoutDurationMs": 11.578,
      "taskDurationMs": 229.01399999999998,
      "heapDeltaBytes": 9552360,
      "heapUsedBytes": 93753792,
      "domNodes": 4,
      "jsHeapTotalBytes": 9437184,
      "scriptDurationMs": 106.76299999999999,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662499999999994,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 279.1789999999992,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.8630000000000001,
      "layouts": 76,
      "layoutDurationMs": 11.5,
      "taskDurationMs": 247.251,
      "heapDeltaBytes": 9750688,
      "heapUsedBytes": 91268180,
      "domNodes": 4,
      "jsHeapTotalBytes": 9437184,
      "scriptDurationMs": 116.51100000000001,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 330.6039999999939,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.591,
      "layouts": 76,
      "layoutDurationMs": 10.432,
      "taskDurationMs": 282.544,
      "heapDeltaBytes": -1673252,
      "heapUsedBytes": 114322784,
      "domNodes": 4,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 104.627,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66500000000001,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 362.5000000000682,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.054,
      "layouts": 76,
      "layoutDurationMs": 11.608,
      "taskDurationMs": 318.822,
      "heapDeltaBytes": -1451276,
      "heapUsedBytes": 114424228,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 115.906,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66818181818181,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge.

Metric Covered Total Pct
Lines 56111 86801 64.6% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.6% 1171
src/LGraphNode.ts 70.6% 387
src/platform/workspace/stores/billingOperationStore.ts 7.9% 375
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 78.9% 274
src/platform/workspace/stores/teamWorkspaceStore.ts 47.5% 245
src/core/webSessionIdentity.ts 3.3% 231
src/scripts/pnginfo.ts 20.7% 222
src/platform/workspace/composables/useWorkspaceBilling.ts 29.8% 217

🎭 Playwright: ✅ 2280 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2258 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/14/2026, 05:13:18 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since d6e1b1a8c01147e9b264a765dc22a9751092efe6

Full docs: ADR-DEVEX-LINT-0015

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 12, 2026
@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.58065% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...rm/workspace/composables/useDeploymentUrlLoader.ts 97.14% 2 Missing ⚠️
...c/platform/workspace/stores/deploymentPickStore.ts 97.14% 1 Missing ⚠️
@@                         Coverage Diff                         @@
##             vinh/fe-2434-release-switcher-pr   #20832   +/-   ##
===================================================================
  Coverage                                    ?   87.21%           
===================================================================
  Files                                       ?     2624           
  Lines                                       ?   147484           
  Branches                                    ?    40478           
===================================================================
  Hits                                        ?   128623           
  Misses                                      ?    18471           
  Partials                                    ?      390           
Flag Coverage Δ
e2e 64.82% <0.00%> (?)
unit 85.09% <97.58%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/useUrlActionLoaders.ts 100.00% <100.00%> (ø)
...c/platform/navigation/preservedQueryDefinitions.ts 100.00% <ø> (ø)
...rc/platform/navigation/preservedQueryNamespaces.ts 100.00% <ø> (ø)
src/platform/workspace/api/workspaceApi.ts 88.47% <100.00%> (ø)
src/platform/workspace/deploymentPickState.ts 100.00% <100.00%> (ø)
src/platform/workspace/workspaceConstants.ts 100.00% <ø> (ø)
...c/platform/workspace/stores/deploymentPickStore.ts 97.70% <97.14%> (ø)
...rm/workspace/composables/useDeploymentUrlLoader.ts 97.14% <97.14%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vqt123
vqt123 temporarily deployed to website-approval October 13, 2026 01:23 — with GitHub Actions Inactive
@vqt123
vqt123 temporarily deployed to website-approval October 13, 2026 01:24 — with GitHub Actions Inactive
@vqt123
vqt123 temporarily deployed to website-approval October 13, 2026 01:25 — with GitHub Actions Inactive
@vqt123
vqt123 temporarily deployed to website-approval October 13, 2026 01:27 — with GitHub Actions Inactive
@vqt123
vqt123 marked this pull request as ready for review October 13, 2026 01:40
@vqt123 vqt123 self-assigned this Oct 13, 2026
@vqt123
vqt123 temporarily deployed to website-approval October 13, 2026 01:40 — with GitHub Actions Inactive
@vqt123
vqt123 requested review from james00012 and wei-hai October 13, 2026 01:40
@vqt123
vqt123 temporarily deployed to website-approval October 13, 2026 01:40 — with GitHub Actions Inactive
@vqt123
vqt123 temporarily deployed to website-approval October 13, 2026 01:41 — with GitHub Actions Inactive
@comfy-greenlight-bot

comfy-greenlight-bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Swarmhost agentic review

The detailed evaluation is available to employees in the internal Slack review thread.

Evaluation failed to run (author_not_trusted).

Evaluation budget remaining for this pull request: 99 automatic and 99 manual.

Updated by Swarmhost's agentic review process.

@wei-hai wei-hai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

This adds a Cloud-only deep link (?workspace= + ?deployment=) that runs before the existing workspace URL loader, switches workspace when needed (with a one-shot sessionStorage guard), strips query params before pick/reload, and calls the same deployment pick API the switcher uses. Sign-in preservation and the URL action loader ordering look correct for the platform “Open in ComfyUI” contract.

Reviewed the diff, spot-checked implementation on dbfcf089, and ran focused unit tests on the PR branch: 102 passed in useDeploymentUrlLoader.test.ts, deploymentPickStore.test.ts, and useUrlActionLoaders.test.ts.

Security (deeplink, auth, XSS, leakage)

Query handling — readLinkValue rejects empty, repeated, comma-joined, and non-string values; malformed links drop deployment (and leave workspace for the workspace loader when appropriate). Loader ordering prevents the workspace loader from stripping ?workspace before a cross-workspace deployment link can complete. That matches the threat model (no client-side trust in IDs; server decides membership and pick eligibility).

Auth — No new tokens in the URL; pick/switch still go through existing authenticated API calls. API-key sessions correctly skip deployment pick and only strip deployment. Refused switch/pick paths do not reload or change deployment state.

XSS — Refusal toasts use fixed i18n titles; server text goes to toast.error(..., { description: outcome.message }). Toaster.vue renders description with text interpolation ({{ item.description }}), so HTML in API error messages should not execute. linkWorkspaceRefused uses escapeParameter: false for the workspace name, which is consistent with other workspace toasts; the title is still text-bound in the toaster.

Open redirect — previousFullPath test for /?workspace=…&deployment=… stays within the existing “relative path only, no //” rules.

Abort / race — AbortSignal on pickDeployment, post-auth throwIfAborted, listing/selection backstops, and state-machine changes for link picks while listing is pending address the scary cases (late listing competing picks, hung pick after timeout) without applying a late successful pick after the user has moved on.

Tests

Coverage is strong for the behaviors called out in the PR body: loader order, reload short-circuit, sign-in stash, API-key path, malformed params, switch-once semantics, storage quota on the switch marker, timeout/cancel regressions, and competing-pick scenarios. I did not run Playwright or a manual staging pass (as noted in the PR).

Non-blocking follow-ups

  • Staging smoke — Worth a quick manual check with platform#1379 on staging (signed out → sign in with full query, wrong workspace, flag off refusal, already on deployment).
  • Server message in toasts — Showing raw API message is useful; if ingest ever returns verbose or unusual strings, consider reusing an existing safe-error helper or truncating for UX (not a blocker given text rendering).

Nice work on the boot-order comment and the regression tests around cleanup order and stalled listings. From a backend-adjacent perspective the client honors the PUT pick contract and does not broaden trust in query params beyond what the API already enforces.

@vqt123

vqt123 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

For the smoke check with the Open in ComfyUI button, I have recorded the signed-out return with the full query, wrong workspace, flag-off refusal, and already-selected deployment cases.

I am keeping the full server refusal message here: it tells the user why the deployment could not be opened, and the toast renders it as text. Truncating it now could remove that explanation. If a real response is too long or unclear, we can shorten that message or apply the shared error formatter with a concrete example. No code change for this suggestion.

@vqt123
vqt123 force-pushed the vinh/fe-2434-release-switcher-pr branch from a275975 to 207a4ff Compare October 14, 2026 14:02
@vqt123
vqt123 requested review from a team and dante01yoon as code owners October 14, 2026 14:02
@vqt123
vqt123 force-pushed the vinh/be-20294-open-ui-link branch from dbfcf08 to b3516bb Compare October 14, 2026 14:04
@vqt123
vqt123 temporarily deployed to website-approval October 14, 2026 14:04 — with GitHub Actions Inactive
@vqt123
vqt123 requested review from wei-hai and removed request for wei-hai October 14, 2026 14:05
@vqt123

vqt123 commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

/swarmhost evaluate

…294)

`/?workspace=<id>&deployment=<id>` opens the Cloud editor on that
deployment. A new URL action loader runs before the `?workspace=` loader
and owns both params when `deployment` is present: in another workspace
it switches there (the switcher's own switch) and keeps the link for the
boot after the reload, at most once per link; in the named workspace it
strips both params and picks with the switcher's request, which reloads
onto the deployment's nodes. A refused switch or pick shows the reason
and changes nothing. An API-key session, or a link without both values,
does nothing. `deployment` is stashed through sign-in like `workspace`.

Ref BE-20294
@vqt123
vqt123 force-pushed the vinh/be-20294-open-ui-link branch from b3516bb to c8d4f95 Compare October 14, 2026 17:11
@vqt123
vqt123 temporarily deployed to website-approval October 14, 2026 17:11 — with GitHub Actions Inactive
@datadog-official

datadog-official Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c8d4f95 | Docs | View more details | Give us feedback!

@vqt123 vqt123 added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch cloud/1.56 Backport PRs for cloud 1.56 cloud/1.57 Backport PRs for cloud 1.57 labels Oct 14, 2026
@vqt123
vqt123 temporarily deployed to website-approval October 14, 2026 19:17 — with GitHub Actions Inactive
@vqt123
vqt123 temporarily deployed to website-approval October 14, 2026 19:17 — with GitHub Actions Inactive
@vqt123
vqt123 temporarily deployed to website-approval October 14, 2026 19:17 — with GitHub Actions Inactive
@vqt123

vqt123 commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

Folded into #19965, so the switcher and the deployment link merge as one PR.

@vqt123 vqt123 closed this Oct 14, 2026
@vqt123 vqt123 removed needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch cloud/1.56 Backport PRs for cloud 1.56 cloud/1.57 Backport PRs for cloud 1.57 labels Oct 14, 2026
@vqt123
vqt123 temporarily deployed to website-approval October 14, 2026 19:42 — with GitHub Actions Inactive
@vqt123
vqt123 temporarily deployed to website-approval October 14, 2026 19:42 — with GitHub Actions Inactive
@vqt123
vqt123 temporarily deployed to website-approval October 14, 2026 19:42 — with GitHub Actions Inactive
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 15, 2026
…lector (Comfy-Org#19965)

## Summary

A member of a workspace on Comfy Cloud can choose which of the
workspace's developer-platform deployments this browser runs on, from a
switcher under the workspace selector, and a workspace owner can set the
workspace default. A link of the form `<cloud>/?workspace=<workspace
id>&deployment=<deployment id>` opens the Cloud editor already running
on that deployment, for the Developer Platform's **Open in ComfyUI**
button and shared links.

Ref [FE-2434](https://linear.app/comfyorg/issue/FE-2434),
[BE-20294](https://linear.app/comfyorg/issue/BE-20294) (parent
[BE-17141](https://linear.app/comfyorg/issue/BE-17141)),
[BE-19175](https://linear.app/comfyorg/issue/BE-19175). Folds in Comfy-Org#20832.
Folds in Comfy-Org#21009. Backend: cloud#9390 (pick), cloud#9645 (listing),
cloud#10901 (workspace default).

**Why**: studios on the Developer Platform (Contender's agencies first)
want the Cloud editor with their own custom nodes and models. Today a
Cloud workspace only runs on Comfy's own node set; the backend can
already run a picked browser's jobs on a workspace deployment
(cloud#9390, Comfy-Org#9578, run on staging), and this is the control that makes
the pick.

## Changes

- **What**:
- `DeploymentSwitcher.vue` (with `DeploymentSwitcherList`,
`DeploymentSwitcherRow`, `DeploymentSwitcherOwnerFooter` and
`useDeploymentLabels`) under the workspace selector in the user popover.
It shows "Running on: Comfy Cloud", or the picked deployment's name, and
lists the workspace's deployments, each row titled by the deployment's
name, with its Build name and the Release it runs now, its id and its
status in the caption. A deployment the server returns without a name is
titled by its Build name and Release version, and by its short id only
when those are absent too. Picking one, or going back to Comfy Cloud,
reloads the editor, because the pick changes what the editor is served
at boot (the node catalog and the packs' JavaScript).
- A pick names a deployment, not a Release: a deployment keeps its URL
while its owner updates it to new Releases (stable deployments), so a
pick follows those updates.
- Workspace default: when this browser has no pick of its own it follows
the default ("Workspace default"); a browser that picked can return to
it ("Use the workspace default"); an owner sets or clears the default
from the footer. The page reloads only when the change alters what this
browser runs on.
- `workspaceApi`: GET `/api/workspaces/{id}/deployments`, PUT/DELETE
`/api/workspaces/{id}/deployment` (DELETE with `?follow=workspace`),
PUT/DELETE `/api/workspaces/{id}/default-deployment`; the shared
automock gains the five methods.
- `deploymentPickStore` and `deploymentPickState` hold the listing and
the pick state; the pick itself is an HttpOnly cookie the editor never
reads.
- The switcher renders nothing until the listing answers, and nothing
when the account is outside the rollout
(`cloud_on_customer_build_enabled`), so nobody sees a control they
cannot use. A refused pick shows the server's message as a toast and
reloads nothing.
- Deployment link (`?workspace=<id>&deployment=<id>`), handled by the
new `useDeploymentUrlLoader`, run first among the URL action loaders
because with `?deployment` it handles `?workspace` too:
- In the named workspace: the two params are removed from the address,
then the deployment is picked with the switcher's own request
(`deploymentPickStore.pickFromLink`), which reloads the editor onto the
deployment's nodes. A link to the deployment this browser already runs
on just removes the params.
- In another workspace: the editor switches to the named workspace
first, with the workspace switcher's own switch, and keeps the link for
the page that loads after the switch, which then picks. A switch happens
at most once per link, so a switch that does not land never reloads
again; if the browser cannot save that marker, the link stays in the
current workspace and shows a refusal.
- Refused: someone outside the workspace stays where they are, with a
toast saying which workspace they are still in. A refused pick (account
outside the rollout, a deployment that is gone or not the workspace's)
shows the server's message as a toast; the params are removed and
nothing changes.
- Signed out: sign-in already returns to the full address, query
included (`previousFullPath`); `deployment` is also stashed through the
sign-in redirect the same way `workspace` is
(`preservedQueryDefinitions`).
- Not acted on: a link missing either value, a bare or repeated value,
an API-key session, and non-Cloud builds.
- Bounded: the first deployment listing and the pick each have the
shared 45-second startup limit (the 30-second request deadline plus time
for authorization). Past it the editor continues startup, asks the user
to reopen the link, and cancels the pending request; a late listing,
authorization or response cannot pick or reload. Picks are serialized,
so a later listing cannot start a competing pick. Three new strings
under `deploymentSwitcher`.
- **Dependencies**: none new. `WorkspaceDeployment`,
`WorkspaceDeploymentList` and `PickWorkspaceDeploymentRequest` come from
`@comfyorg/ingest-types`.

## Review Focus

- The reload on pick: the editor's node catalog and pack JavaScript are
fixed at boot, so a pick reloads instead of swapping in place.
- Hidden until the listing answers and outside the rollout.
- The deployment link's order against the `?workspace=` loader, and its
45-second startup limit.

## Screenshots (if applicable)

Screenshots: in the review ask's Slack thread, and on
[FE-2434](https://linear.app/comfyorg/issue/FE-2434) (the switcher,
seven states, taken on staging from this branch) and
[BE-20294](https://linear.app/comfyorg/issue/BE-20294) (the deployment
link, four states, from the local end-to-end test).

Design follow-up: once this is on staging, Willie and Pablo use it there
and iterate on it; their changes come as follow-up PRs
([BE-20668](https://linear.app/comfyorg/issue/BE-20668)).

Try it: [Storybook,
Components/DeploymentSwitcher](https://cdd7cb47.comfy-storybook.pages.dev/?path=/story/components-deploymentswitcher--default)
(built from this PR's head; the stories cover a pick, the workspace
default, a gone default, no deployments, hidden build names and named
deployments). Against staging: `pnpm dev:cloud:staging` from this
branch, then the account menu, under the workspace selector. For the
link, sign in and open `http://localhost:5173/?workspace=<your team
workspace id>&deployment=<a deployment id in that workspace>`: with
`cloud_on_customer_build_enabled` on for the workspace the editor
reloads onto the deployment; with it off you get the refusal toast and
nothing changes.

Tested: unit tests for the switcher, its labels, its store, the boot
listing, the missing-model scan and the deployment link
(`useDeploymentUrlLoader`, `pickFromLink`, the URL action order, the
sign-in stash, the startup limit and cancellation); the link end to end
locally; on staging from this branch (real deployment listing, a pick
and its reload, setting and clearing the workspace default, a node the
Release lacks).
Not run: the browser (Playwright) suite locally; CI runs it.

This branch was previously deployed

1 inactive deployment
website-approval — c8d4f95d Deployed Oct 14, 2026 by vqt123 via fast-lane #2938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted Written by a person driving an AI coding agent. Informational: no automation reads it. greenlight risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants