Skip to content

[backport cloud/1.56] fix(agent): stop a run-mode change from overtaking a message already sent - #20764

Merged
comfy-pr-bot merged 1 commit into
cloud/1.56from
backport-18706-to-cloud-1.56
Oct 11, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.56from
backport-18706-to-cloud-1.56

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backport of #18706 (8bcbd9f3cd) to cloud/1.56. The fix stops a run-mode change picked right after Send from governing the message already sent (PM-1660), with the regression test PM-1661 asks for.

The 1.55 line already has this fix via #20611. core/1.56 and cloud/1.56 did not, and 1.56 is what production serves — so the user-visible defect is still reachable on the served build.

Changes

  • What: cherry-pick of 8bcbd9f3cd. The applied delta is line-for-line identical to the merged main commit (9 files, +495/-7), verified by comparing the added/removed lines of this diff against git show 8bcbd9f3cd.
  • Breaking: none.
  • Dependencies: none.

Review Focus

One conflict, in src/scripts/api.ts, and it is pure context adjacency rather than semantics. The upstream hunk deletes const FETCH_RESPONSE_HEADERS_TIMEOUT_MS = 60_000 so the value can be imported from the new leaf module src/scripts/apiTimeouts.ts. On this release branch the PM-1802 AuthScheme type sits immediately after that constant, inside the same hunk, so git could not place the deletion. Resolved by deleting only the constant and keeping the AuthScheme docblock and type untouched. No behaviour was weakened to make the pick apply.

Verification

…sent (#18706)

A run-mode change picked right after Send used to govern the message
already sent: the composer clears on the click, but `performSend` awaits
`prepareWorkflow()` before issuing the POST, and the server pins a
turn's run mode when that POST *arrives* (`resolveRunMode`, run inside
`postMessage` before the `202`). `agentSendGateStore` now counts this
page's unsettled message POSTs and `agentRunModeStore.save()` waits on
that count before writing, bounded only by the gate's own backstop —
`MAX_HOLD_MS`, 190s, derived from `api.fetchApi`'s auth-init and
response-headers timeouts plus the remint and prepare budgets rather
than hand-summed. Page-scoped: a second tab's write is ordered against
its own sends only, and closing that needs the ordering point to move to
the server. Fixes PM-1660, with the regression test PM-1661 asks for.

- **What**: new `agentSendGateStore` — a page-global in-flight count,
one single-use release per hold, and a backstop so a send that never
settles cannot strand the control. `sendMessage` takes a hold before
`prepareWorkflow()` and releases however the POST settles; `save()`
waits on it inline. `load()` now snapshots `appliedSaveRevision` as
well, so a load started inside the hold cannot put the pre-write mode
back. `api.fetchApi`'s two request bounds move to
`src/scripts/apiTimeouts.ts` so a caller that must *outlast* a request
can derive from them: read from `api.ts` they arrive `undefined` under
the manual mock, and `NaN` arithmetic arms a timer that fires
immediately.
- **Breaking**: none.
- **Dependencies**: none.

- `MAX_HOLD_MS` is a liveness escape hatch, not the ordering guarantee —
the guarantee is the release in `sendMessage`'s `finally`. The budget
covering `getAuthHeader()` and the unified-user wait is explicit, not
provable; a provable bound needs an overall send deadline or a release
tied to dispatch, and both change send behaviour beyond this fix. There
is deliberately no test asserting the budget covers the window: the
constant is derived from the same timeouts the window is built from, so
raising one raises both sides and such a test cannot fail.
- Two residuals documented in `agentSendGateStore`'s docblock rather
than closed: a client-side abort or network error ends the hold without
proving the server discarded the POST (it turns on whether cloud cancels
on client disconnect, which needs an experiment against the service),
and the hold starts in `sendMessage` rather than at `startSubmission`,
leaving one consent round trip on an account's first message.

Local, at `5b66a27` (branch merged with `main`):

- `pnpm vitest run src/workbench/extensions/agent src/scripts` — 190
files, 3548 passed, 0 failures.
- `pnpm typecheck` and `pnpm format:check` clean; `oxlint --type-aware`
and `eslint` clean on the changed files. The whole-repo `oxlint
--type-aware` pass is killed by the dev host on an unmodified tree too,
so it ran per-file through the pre-commit hook and in CI.
- Every new unit test was confirmed red against the code it protects:
removing the gate wiring from `sendMessage` fails both
`useAgentSession.test.ts` cases; removing the superseded-revision check
fails `sends only the latest of two picks parked on one send`; reverting
`load()`'s second snapshot fails `does not let a load started during the
hold undo the saved mode`; removing the backstop fails both
`agentSendGateStore.test.ts` cases by assertion rather than by timeout.
- The `@cloud` Playwright spec is not runnable on the dev host (the
agent panel's entry button does not render against a local CPU backend),
so CI is its only real run. Its setup assertion was racing
`agentRunModeStore.load()` and reaching its own assertion only on a
fourth attempt; `db9a0c9` removes the race, and the no-retry
`playwright-video-new-tests (cloud)` job passed at that head.

Tests live in `agentSendGateStore.test.ts` (new),
`agentRunModeStore.test.ts`, `useAgentSession.test.ts`, and
`browser_tests/tests/agent/agentRunModePopover.spec.ts` (PM-1661).

---------

Co-authored-by: glary <glary@comfy.org>
(cherry picked from commit 8bcbd9f)
@christian-byrne
christian-byrne requested review from a team as code owners October 11, 2026 01:12
@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: bd74642d-f084-4556-b910-9afa8d39ae87

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Oct 11, 2026
@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.2 MB heap
dom-widget-order-dense-n200-w200-i120: · 29.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 519ms TBT · 92.4 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 40.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 225ms TBT · 97.0 MB heap
extension-clean-combined-draw: · 30.1 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 832ms TBT · 85.2 MB heap
extension-rgthree-prototype-draw: · 29.9 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 1004ms TBT · 72.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.3 MB heap
large-graph-pan: · 59.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.2 MB heap
legacy-node-drag: · 59.7 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.9 MB heap
subgraph-transition-enter: · 50.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 133ms TBT · 93.3 MB heap
viewport-pan-sweep: · 59.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap
vue-large-graph-idle: · 32.1 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 172.0 MB heap
vue-large-graph-pan: · 24.2 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 22ms TBT · 172.8 MB heap
vue-node-resize-workload: · 26.5 avg FPS · 13.3 P5 FPS ❌ (target: ≥52) · 4ms TBT · 204.5 MB heap
vue-zoom-out-idle: · 33.4 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 0ms TBT · 172.0 MB heap
workflow-execution: · 50.4 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 17ms TBT · 67.2 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.1 MB heap
agent-composer-long-conversation-typing: · 53.0 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 103.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 4ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 414ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 65.5 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 18ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 804ms
canvas-mouse-sweep: script duration 167ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.8 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 0
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 11ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 355ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 68.7 MB
canvas-zoom-sweep: DOM nodes 53
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 452ms
dom-widget-clipping: script duration 165ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 58.2 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 34ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 802ms
dom-widget-order-dense-n200-w200-i120: script duration 67ms
dom-widget-order-dense-n200-w200-i120: TBT 519ms
dom-widget-order-dense-n200-w200-i120: heap used 92.4 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 469ms
dom-widget-order-sparse-n1000-w20-i120: script duration 167ms
dom-widget-order-sparse-n1000-w20-i120: TBT 225ms
dom-widget-order-sparse-n1000-w20-i120: heap used 97.0 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 33ms
extension-clean-combined-draw: p95 frame time 67ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 1
extension-clean-combined-draw: task duration 8445ms
extension-clean-combined-draw: script duration 7044ms
extension-clean-combined-draw: TBT 832ms
extension-clean-combined-draw: heap used 85.2 MB
extension-clean-combined-draw: DOM nodes -142
extension-clean-combined-draw: event listeners -78
extension-rgthree-prototype-draw: avg frame time 33ms
extension-rgthree-prototype-draw: p95 frame time 67ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 1
extension-rgthree-prototype-draw: task duration 8917ms
extension-rgthree-prototype-draw: script duration 7358ms
extension-rgthree-prototype-draw: TBT 1004ms
extension-rgthree-prototype-draw: heap used 72.3 MB
extension-rgthree-prototype-draw: DOM nodes -143
extension-rgthree-prototype-draw: event listeners -78
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 490ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 75.3 MB
large-graph-idle: DOM nodes 0
large-graph-idle: event listeners 0
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1623ms
large-graph-pan: script duration 871ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 68.0 MB
large-graph-pan: DOM nodes 0
large-graph-pan: event listeners 0
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 15ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 72
large-graph-zoom: task duration 1695ms
large-graph-zoom: script duration 793ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 66.2 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 2000ms
legacy-node-drag: script duration 1056ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 73.9 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 525ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 76.1 MB
minimap-idle: DOM nodes 0
minimap-idle: event listeners 0
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 415ms
subgraph-dom-widget-clipping: script duration 147ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 55.3 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 5ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 12
subgraph-idle: task duration 409ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 63.3 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 18ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 68
subgraph-mouse-sweep: task duration 730ms
subgraph-mouse-sweep: script duration 113ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 60.9 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 0
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 16
subgraph-transition-enter: task duration 891ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 133ms
subgraph-transition-enter: heap used 93.3 MB
subgraph-transition-enter: DOM nodes 14227
subgraph-transition-enter: event listeners 2463
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 5687ms
viewport-pan-sweep: script duration 2855ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 67.5 MB
viewport-pan-sweep: DOM nodes 0
viewport-pan-sweep: event listeners 0
vue-large-graph-idle: avg frame time 31ms
vue-large-graph-idle: p95 frame time 67ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17479ms
vue-large-graph-idle: script duration 293ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 172.0 MB
vue-large-graph-idle: DOM nodes -3045
vue-large-graph-idle: event listeners -14915
vue-large-graph-pan: avg frame time 41ms
vue-large-graph-pan: p95 frame time 83ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 179
vue-large-graph-pan: task duration 22128ms
vue-large-graph-pan: script duration 898ms
vue-large-graph-pan: TBT 22ms
vue-large-graph-pan: heap used 172.8 MB
vue-large-graph-pan: DOM nodes -3045
vue-large-graph-pan: event listeners -14915
vue-node-resize-workload: avg frame time 38ms
vue-node-resize-workload: p95 frame time 75ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 82ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6346ms
vue-node-resize-workload: script duration 117ms
vue-node-resize-workload: TBT 4ms
vue-node-resize-workload: heap used 204.5 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 30ms
vue-zoom-out-idle: p95 frame time 58ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8738ms
vue-zoom-out-idle: script duration 141ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 172.0 MB
vue-zoom-out-idle: DOM nodes -3045
vue-zoom-out-idle: event listeners -14915
workflow-execution: avg frame time 20ms
workflow-execution: p95 frame time 33ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 4
workflow-execution: style recalc count 12
workflow-execution: task duration 175ms
workflow-execution: script duration 11ms
workflow-execution: TBT 17ms
workflow-execution: heap used 67.2 MB
workflow-execution: DOM nodes 112
workflow-execution: event listeners 49
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 28ms
agent-composer-empty-conversation-typing: style recalc duration 109ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 932ms
agent-composer-empty-conversation-typing: script duration 389ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 80.1 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 19ms
agent-composer-long-conversation-typing: p95 frame time 33ms
agent-composer-long-conversation-typing: layout duration 32ms
agent-composer-long-conversation-typing: style recalc duration 289ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 1475ms
agent-composer-long-conversation-typing: script duration 499ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 103.9 MB
agent-composer-long-conversation-typing: DOM nodes 76
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-10-11T01:26:47.876Z",
  "gitSha": "d9cd66fd3190ee93194223e666bf37507c47b343",
  "branch": "backport-18706-to-cloud-1.56",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2014.774999999986,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.173999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 423.617,
      "heapDeltaBytes": 527328,
      "heapUsedBytes": 68714280,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.211,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2014.0310000000454,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 4.694,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 405.02399999999994,
      "heapDeltaBytes": 621344,
      "heapUsedBytes": 68549656,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.524000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1819.7159999999712,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 18.863999999999997,
      "layouts": 12,
      "layoutDurationMs": 4.588,
      "taskDurationMs": 814.715,
      "heapDeltaBytes": -2125176,
      "heapUsedBytes": 65932992,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 169.844,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666055045871556,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1761.1030000000483,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 17.276,
      "layouts": 12,
      "layoutDurationMs": 4.24,
      "taskDurationMs": 792.5680000000001,
      "heapDeltaBytes": -2048128,
      "heapUsedBytes": 65717124,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 163.589,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66603773584906,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1754.9109999999928,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 11.505,
      "layouts": 6,
      "layoutDurationMs": 1.258,
      "taskDurationMs": 355.34,
      "heapDeltaBytes": 4138180,
      "heapUsedBytes": 71920560,
      "domNodes": 53,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 13.072000000000008,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1698.598000000061,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 9.931,
      "layouts": 6,
      "layoutDurationMs": 1.252,
      "taskDurationMs": 355.617,
      "heapDeltaBytes": 4087784,
      "heapUsedBytes": 72155432,
      "domNodes": 53,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 12.203999999999994,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 691.5180000000305,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.8240000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.28799999999995,
      "heapDeltaBytes": -6552724,
      "heapUsedBytes": 60741220,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 160.12599999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536566,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 700.9499999999207,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 4.007000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 461.03700000000003,
      "heapDeltaBytes": -6499940,
      "heapUsedBytes": 61344348,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 168.99900000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1130.7860000000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 777.156,
      "heapDeltaBytes": 15127900,
      "heapUsedBytes": 85335424,
      "domNodes": 0,
      "jsHeapTotalBytes": 2785280,
      "scriptDurationMs": 65.20200000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 499,
      "frameDurationMs": 33.335294117647045,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1170.1829999999518,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 827.39,
      "heapDeltaBytes": 39381028,
      "heapUsedBytes": 108393300,
      "domNodes": 0,
      "jsHeapTotalBytes": 2260992,
      "scriptDurationMs": 69.12500000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 539,
      "frameDurationMs": 34.30882352941177,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 843.6310000000162,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 471.7980000000002,
      "heapDeltaBytes": 17705684,
      "heapUsedBytes": 105233640,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 166.97299999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 227,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 847.4360000000161,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 466.45300000000003,
      "heapDeltaBytes": 16885284,
      "heapUsedBytes": 98094728,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 166.33600000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 223,
      "frameDurationMs": 24.997058823529454,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9721.479999999985,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8819.955,
      "heapDeltaBytes": 12772444,
      "heapUsedBytes": 98021444,
      "domNodes": -142,
      "jsHeapTotalBytes": -10358784,
      "scriptDurationMs": 7213.184,
      "eventListeners": -78,
      "totalBlockingTimeMs": 852,
      "frameDurationMs": 32.49598662207358,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 8778.42499999997,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.4550000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8069.08,
      "heapDeltaBytes": 2377644,
      "heapUsedBytes": 80592276,
      "domNodes": -142,
      "jsHeapTotalBytes": -10620928,
      "scriptDurationMs": 6875.233,
      "eventListeners": -78,
      "totalBlockingTimeMs": 811,
      "frameDurationMs": 34.0422480620155,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9861.717999999997,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.4720000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9148.475,
      "heapDeltaBytes": -2207372,
      "heapUsedBytes": 83011732,
      "domNodes": -142,
      "jsHeapTotalBytes": -11669504,
      "scriptDurationMs": 7559.483,
      "eventListeners": -74,
      "totalBlockingTimeMs": 1050,
      "frameDurationMs": 33.84742268041237,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9488.31400000006,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.07599999999999968,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8685.036,
      "heapDeltaBytes": -17016632,
      "heapUsedBytes": 68524440,
      "domNodes": -143,
      "jsHeapTotalBytes": -9834496,
      "scriptDurationMs": 7155.5199999999995,
      "eventListeners": -82,
      "totalBlockingTimeMs": 958,
      "frameDurationMs": 33.0418118466899,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2008.9039999999727,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.7359999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 497.756,
      "heapDeltaBytes": -9850624,
      "heapUsedBytes": 78998256,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 32.262,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2008.9000000000397,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.448,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.36999999999983,
      "heapDeltaBytes": -9572444,
      "heapUsedBytes": 78909384,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 35.119,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2711.065000000019,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 11.907999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1679.094,
      "heapDeltaBytes": -17330656,
      "heapUsedBytes": 72829112,
      "domNodes": 0,
      "jsHeapTotalBytes": 823296,
      "scriptDurationMs": 911.112,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.769565217391303,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2279.6650000000227,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 11.08,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1566.382,
      "heapDeltaBytes": -20168036,
      "heapUsedBytes": 69769680,
      "domNodes": 0,
      "jsHeapTotalBytes": 823296,
      "scriptDurationMs": 829.8979999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.78823529411765,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3687.767000000008,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 14.754,
      "layouts": 60,
      "layoutDurationMs": 15.088000000000001,
      "taskDurationMs": 1715.3149999999998,
      "heapDeltaBytes": -20427500,
      "heapUsedBytes": 69167564,
      "domNodes": 24,
      "jsHeapTotalBytes": 561152,
      "scriptDurationMs": 813.4590000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66561085972851,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3567.643999999973,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 14.598,
      "layouts": 60,
      "layoutDurationMs": 14.926,
      "taskDurationMs": 1674.4990000000003,
      "heapDeltaBytes": 1239064,
      "heapUsedBytes": 69717120,
      "domNodes": 24,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 772.273,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665887850467293,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3303.5659999999893,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 8.29,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2095.8579999999997,
      "heapDeltaBytes": -15135900,
      "heapUsedBytes": 68443012,
      "domNodes": 0,
      "jsHeapTotalBytes": 823296,
      "scriptDurationMs": 1118.801,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.750510204081635,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3139.0630000000783,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 7.528,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1903.3880000000001,
      "heapDeltaBytes": 17976540,
      "heapUsedBytes": 86507248,
      "domNodes": 0,
      "jsHeapTotalBytes": 1204224,
      "scriptDurationMs": 993.512,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.75537634408602,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2009.8649999999907,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.048000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 542.261,
      "heapDeltaBytes": -9904540,
      "heapUsedBytes": 79380560,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 38.063999999999986,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2015.3480000000172,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 3.7209999999999988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 507.335,
      "heapDeltaBytes": -9283220,
      "heapUsedBytes": 80303668,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 33.677,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 639.614999999992,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 7.095000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 412.04400000000004,
      "heapDeltaBytes": -11942140,
      "heapUsedBytes": 58126408,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 146.036,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665789473684193,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 640.0580000000673,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 6.154999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 417.47200000000004,
      "heapDeltaBytes": -11733716,
      "heapUsedBytes": 57811924,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 147.478,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665789473684193,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2018.2839999999942,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.1099999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 414.18199999999996,
      "heapDeltaBytes": -2645812,
      "heapUsedBytes": 61502084,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.827000000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.5870000000486,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 4.4270000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.952,
      "heapDeltaBytes": 1155776,
      "heapUsedBytes": 71163468,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.079999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760327,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1692.2509999999988,
      "styleRecalcs": 59,
      "styleRecalcDurationMs": 17.697999999999997,
      "layouts": 16,
      "layoutDurationMs": 5.888999999999999,
      "taskDurationMs": 731.417,
      "heapDeltaBytes": -5962152,
      "heapUsedBytes": 63285060,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 113.93400000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352944,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1706.1029999999846,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 18.13,
      "layouts": 16,
      "layoutDurationMs": 5.26,
      "taskDurationMs": 729.178,
      "heapDeltaBytes": -6312264,
      "heapUsedBytes": 64432148,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 111.729,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.2519999999995,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 30.707000000000004,
      "layouts": 5,
      "layoutDurationMs": 14.943999999999996,
      "taskDurationMs": 891.352,
      "heapDeltaBytes": 2947608,
      "heapUsedBytes": 97816992,
      "domNodes": 14227,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 29.392000000000003,
      "eventListeners": 2463,
      "totalBlockingTimeMs": 133,
      "frameDurationMs": 19.676388888888887,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8542.664999999999,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 36.692,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5584.988,
      "heapDeltaBytes": -19262836,
      "heapUsedBytes": 69460320,
      "domNodes": 0,
      "jsHeapTotalBytes": 823296,
      "scriptDurationMs": 2785.696,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.731372549019607,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8778.501000000006,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 38.545,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5789.648999999999,
      "heapDeltaBytes": -17311088,
      "heapUsedBytes": 72128240,
      "domNodes": 0,
      "jsHeapTotalBytes": 1085440,
      "scriptDurationMs": 2923.9359999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.69752380952381,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18441.89899999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17563.949999999997,
      "heapDeltaBytes": -35606500,
      "heapUsedBytes": 180111496,
      "domNodes": -3045,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 285.60300000000007,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 31.591438356164385,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18145.650000000045,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17394.216,
      "heapDeltaBytes": -18590648,
      "heapUsedBytes": 180642384,
      "domNodes": -3045,
      "jsHeapTotalBytes": 8409088,
      "scriptDurationMs": 300.35200000000003,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.709306260575296,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21977.197000000047,
      "styleRecalcs": 177,
      "styleRecalcDurationMs": 19.908000000000037,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21570.172999999995,
      "heapDeltaBytes": -36353904,
      "heapUsedBytes": 176595180,
      "domNodes": -3045,
      "jsHeapTotalBytes": 6574080,
      "scriptDurationMs": 853.0960000000001,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 20,
      "frameDurationMs": 40.33486238532111,
      "p95FrameDurationMs": 83.39999999999782
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23079.45600000005,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 20.957000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22685.968,
      "heapDeltaBytes": -30110204,
      "heapUsedBytes": 185869432,
      "domNodes": -3045,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 942.8180000000002,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 23,
      "frameDurationMs": 42.43088235294118,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6327.960000000019,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.043,
      "layouts": 20,
      "layoutDurationMs": 24.164000000000005,
      "taskDurationMs": 6207.398,
      "heapDeltaBytes": -12571028,
      "heapUsedBytes": 214363752,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 111.194,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 38.05060240963854,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6610.924000000068,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 82.84599999999998,
      "layouts": 20,
      "layoutDurationMs": 24.385000000000005,
      "taskDurationMs": 6484.498,
      "heapDeltaBytes": 785940,
      "heapUsedBytes": 214424432,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 122.44299999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 7,
      "frameDurationMs": 37.28700564971752,
      "p95FrameDurationMs": 83.30000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9083.47900000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8747.317000000001,
      "heapDeltaBytes": -32154152,
      "heapUsedBytes": 180921284,
      "domNodes": -3045,
      "jsHeapTotalBytes": 8237056,
      "scriptDurationMs": 138.04299999999998,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.220999999999997,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9102.776999999947,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8728.279,
      "heapDeltaBytes": -33802360,
      "heapUsedBytes": 179691084,
      "domNodes": -3045,
      "jsHeapTotalBytes": 6049792,
      "scriptDurationMs": 144.333,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.737254901960792,
      "p95FrameDurationMs": 50.10000000000218
    },
    {
      "name": "workflow-execution",
      "durationMs": 514.9359999999206,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 20.567,
      "layouts": 5,
      "layoutDurationMs": 2.4130000000000003,
      "taskDurationMs": 262.02099999999996,
      "heapDeltaBytes": 5927932,
      "heapUsedBytes": 71860436,
      "domNodes": 129,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 15.21999999999999,
      "eventListeners": 65,
      "totalBlockingTimeMs": 34,
      "frameDurationMs": 20.667999999999992,
      "p95FrameDurationMs": 33.30000000000018
    },
    {
      "name": "workflow-execution",
      "durationMs": 132.81899999992675,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 13.816,
      "layouts": 3,
      "layoutDurationMs": 1.7189999999999999,
      "taskDurationMs": 88.222,
      "heapDeltaBytes": 3767540,
      "heapUsedBytes": 68979476,
      "domNodes": 94,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.274999999999997,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 19.04285714285717,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 872.1170000000029,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 103.39099999999999,
      "layouts": 76,
      "layoutDurationMs": 27.442,
      "taskDurationMs": 837.493,
      "heapDeltaBytes": 17736472,
      "heapUsedBytes": 82242132,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 345.844,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667307692307688,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 1051.5229999999747,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 114.131,
      "layouts": 76,
      "layoutDurationMs": 28.938,
      "taskDurationMs": 1026.8890000000001,
      "heapDeltaBytes": 19692084,
      "heapUsedBytes": 85812708,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 432.05899999999997,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66507936507936,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1485.7540000000427,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 283.12,
      "layouts": 76,
      "layoutDurationMs": 31.405,
      "taskDurationMs": 1459.566,
      "heapDeltaBytes": -13218636,
      "heapUsedBytes": 107522312,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 483.125,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.541250000000012,
      "p95FrameDurationMs": 33.30000000000109
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1509.1500000000906,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 294.56399999999996,
      "layouts": 76,
      "layoutDurationMs": 32.723,
      "taskDurationMs": 1491.27,
      "heapDeltaBytes": -18879288,
      "heapUsedBytes": 110420612,
      "domNodes": 76,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 514.817,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 19.197468354430384,
      "p95FrameDurationMs": 33.399999999999636
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 54338 84152 64.6% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.4% 1180
src/LGraphNode.ts 70.6% 387
src/platform/workspace/stores/billingOperationStore.ts 7.7% 374
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/core/billing/operationLifecycle.ts 1.3% 303
src/platform/workspace/stores/teamWorkspaceStore.ts 39.2% 284
src/LGraph.ts 79.0% 272
src/scripts/app.ts 73.0% 255
src/core/webSessionIdentity.ts 3.3% 231
src/scripts/pnginfo.ts 20.7% 222

🎭 Playwright: ✅ 2201 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2181 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 17 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/11/2026, 01:14:24 AM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 9a10127f6374dec19703c2fca72398be09e78bf6

Full docs: ADR-DEVEX-LINT-0015

@mrseek-reviews
mrseek-reviews Bot requested a review from DrJKL October 11, 2026 01:12

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the backport diff rather than re-reviewing #18706. the applied delta here is line-for-line identical to the merged main commit 8bcbd9f3cd — same nine files, same +495/-7, and comparing the added/removed lines of this diff against git show 8bcbd9f3cd yields no difference. so the behaviour carried is exactly what was reviewed and merged upstream.

the one conflict was src/scripts/api.ts, and it is context adjacency rather than semantics. upstream deletes const FETCH_RESPONSE_HEADERS_TIMEOUT_MS = 60_000 so api.ts can import the value from the new leaf module src/scripts/apiTimeouts.ts; on this release branch the PM-1802 AuthScheme docblock and type sit inside that same hunk immediately after the constant, which is why git could not place the deletion. resolved by removing only the constant and leaving AuthScheme untouched — onAuthScheme?: (scheme: AuthScheme) => void in FetchApiOptions still resolves, and FETCH_RESPONSE_HEADERS_TIMEOUT_MS now arrives through the import at the top of the file with no duplicate local binding.

nothing was relaxed to make the pick apply, and no assertion in the four test files was weakened. agentSendGateStore.ts, agentSendGateStore.test.ts, agentRunModeStore.ts and agentRunModeStore.test.ts are byte-identical to their main versions.

merging under the program's standing Agent release-backport grant for the current core/1.55 / cloud/1.55 / core/1.56 / cloud/1.56 trains, after lint-and-format, test and e2e-status are terminal green at this exact head. GitHub will not accept an author approving their own pull request, so this is a COMMENT rather than a manufactured approval.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 11, 2026
@codecov

codecov Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/scripts/api.ts 0.00% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.56   #20764   +/-   ##
=============================================
  Coverage              ?   85.87%           
=============================================
  Files                 ?     2484           
  Lines                 ?   141649           
  Branches              ?    38542           
=============================================
  Hits                  ?   121647           
  Misses                ?    19619           
  Partials              ?      383           
Flag Coverage Δ
e2e 64.48% <100.00%> (?)
unit 82.98% <96.42%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scripts/apiTimeouts.ts 100.00% <100.00%> (ø)
...ensions/agent/composables/agent/useAgentSession.ts 98.79% <100.00%> (ø)
...extensions/agent/stores/agent/agentRunModeStore.ts 97.18% <100.00%> (ø)
...xtensions/agent/stores/agent/agentSendGateStore.ts 100.00% <100.00%> (ø)
src/scripts/api.ts 79.39% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit 5b2834c into cloud/1.56 Oct 11, 2026
143 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-18706-to-cloud-1.56 branch October 11, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants