Repository navigation
[backport core/1.56] fix(agent): stop a run-mode change from overtaking a message already sent - #20763
Conversation
…sent (#18706) A run-mode change picked right after Send used to govern the message already sent: the composer clears on the click, but `performSend` awaits `prepareWorkflow()` before issuing the POST, and the server pins a turn's run mode when that POST *arrives* (`resolveRunMode`, run inside `postMessage` before the `202`). `agentSendGateStore` now counts this page's unsettled message POSTs and `agentRunModeStore.save()` waits on that count before writing, bounded only by the gate's own backstop — `MAX_HOLD_MS`, 190s, derived from `api.fetchApi`'s auth-init and response-headers timeouts plus the remint and prepare budgets rather than hand-summed. Page-scoped: a second tab's write is ordered against its own sends only, and closing that needs the ordering point to move to the server. Fixes PM-1660, with the regression test PM-1661 asks for. - **What**: new `agentSendGateStore` — a page-global in-flight count, one single-use release per hold, and a backstop so a send that never settles cannot strand the control. `sendMessage` takes a hold before `prepareWorkflow()` and releases however the POST settles; `save()` waits on it inline. `load()` now snapshots `appliedSaveRevision` as well, so a load started inside the hold cannot put the pre-write mode back. `api.fetchApi`'s two request bounds move to `src/scripts/apiTimeouts.ts` so a caller that must *outlast* a request can derive from them: read from `api.ts` they arrive `undefined` under the manual mock, and `NaN` arithmetic arms a timer that fires immediately. - **Breaking**: none. - **Dependencies**: none. - `MAX_HOLD_MS` is a liveness escape hatch, not the ordering guarantee — the guarantee is the release in `sendMessage`'s `finally`. The budget covering `getAuthHeader()` and the unified-user wait is explicit, not provable; a provable bound needs an overall send deadline or a release tied to dispatch, and both change send behaviour beyond this fix. There is deliberately no test asserting the budget covers the window: the constant is derived from the same timeouts the window is built from, so raising one raises both sides and such a test cannot fail. - Two residuals documented in `agentSendGateStore`'s docblock rather than closed: a client-side abort or network error ends the hold without proving the server discarded the POST (it turns on whether cloud cancels on client disconnect, which needs an experiment against the service), and the hold starts in `sendMessage` rather than at `startSubmission`, leaving one consent round trip on an account's first message. Local, at `5b66a27` (branch merged with `main`): - `pnpm vitest run src/workbench/extensions/agent src/scripts` — 190 files, 3548 passed, 0 failures. - `pnpm typecheck` and `pnpm format:check` clean; `oxlint --type-aware` and `eslint` clean on the changed files. The whole-repo `oxlint --type-aware` pass is killed by the dev host on an unmodified tree too, so it ran per-file through the pre-commit hook and in CI. - Every new unit test was confirmed red against the code it protects: removing the gate wiring from `sendMessage` fails both `useAgentSession.test.ts` cases; removing the superseded-revision check fails `sends only the latest of two picks parked on one send`; reverting `load()`'s second snapshot fails `does not let a load started during the hold undo the saved mode`; removing the backstop fails both `agentSendGateStore.test.ts` cases by assertion rather than by timeout. - The `@cloud` Playwright spec is not runnable on the dev host (the agent panel's entry button does not render against a local CPU backend), so CI is its only real run. Its setup assertion was racing `agentRunModeStore.load()` and reaching its own assertion only on a fourth attempt; `db9a0c9` removes the race, and the no-retry `playwright-video-new-tests (cloud)` job passed at that head. Tests live in `agentSendGateStore.test.ts` (new), `agentRunModeStore.test.ts`, `useAgentSession.test.ts`, and `browser_tests/tests/agent/agentRunModePopover.spec.ts` (PM-1661). --------- Co-authored-by: glary <glary@comfy.org> (cherry picked from commit 8bcbd9f)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-11T01:26:23.398Z",
"gitSha": "a927260db69cf1f8c13a5c6a95ef6de77e74b203",
"branch": "backport-18706-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.890999999982,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.8080000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.14700000000005,
"heapDeltaBytes": 938368,
"heapUsedBytes": 67824148,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.115000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.344999999973,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.026999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.916,
"heapDeltaBytes": 1218060,
"heapUsedBytes": 68805160,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.327000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1834.8819999999932,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.874000000000002,
"layouts": 12,
"layoutDurationMs": 4.581,
"taskDurationMs": 796.1990000000001,
"heapDeltaBytes": -2071208,
"heapUsedBytes": 66233520,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 164.79399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.3140000000785,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.377000000000002,
"layouts": 12,
"layoutDurationMs": 3.7889999999999997,
"taskDurationMs": 768.825,
"heapDeltaBytes": -2451356,
"heapUsedBytes": 65660492,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 161.112,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.731999999984,
"styleRecalcs": 34,
"styleRecalcDurationMs": 11.767,
"layouts": 6,
"layoutDurationMs": 1.1940000000000002,
"taskDurationMs": 344.63599999999997,
"heapDeltaBytes": 25909308,
"heapUsedBytes": 80169464,
"domNodes": -198,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.165000000000003,
"eventListeners": -145,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.9309999999832,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.484000000000002,
"layouts": 6,
"layoutDurationMs": 1.2919999999999998,
"taskDurationMs": 257.594,
"heapDeltaBytes": 3974784,
"heapUsedBytes": 72219068,
"domNodes": 53,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 11.139999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 717.9779999999596,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.484999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.313,
"heapDeltaBytes": -6432520,
"heapUsedBytes": 61337216,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.172,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 707.7789999999595,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.2509999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.90700000000004,
"heapDeltaBytes": -6771456,
"heapUsedBytes": 61370228,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 170.475,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1159.5360000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 803.0149999999999,
"heapDeltaBytes": 15649648,
"heapUsedBytes": 85033176,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 70.413,
"eventListeners": 0,
"totalBlockingTimeMs": 517,
"frameDurationMs": 33.82058823529411,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1110.8699999999772,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 781.829,
"heapDeltaBytes": 15344764,
"heapUsedBytes": 86126408,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 63.359,
"eventListeners": 0,
"totalBlockingTimeMs": 496,
"frameDurationMs": 33.839393939393936,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 865.9040000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.53999999999974,
"heapDeltaBytes": 17213324,
"heapUsedBytes": 104893728,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 168.46200000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.6610000000401,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.095,
"heapDeltaBytes": 18879544,
"heapUsedBytes": 104728556,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 161.598,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9124.486000000019,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6410000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8343.177000000001,
"heapDeltaBytes": -10696052,
"heapUsedBytes": 66676088,
"domNodes": -142,
"jsHeapTotalBytes": -11669504,
"scriptDurationMs": 7067.812,
"eventListeners": -74,
"totalBlockingTimeMs": 1056,
"frameDurationMs": 35.39883720930232,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8540.150999999923,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.910000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7846.125000000001,
"heapDeltaBytes": -6720692,
"heapUsedBytes": 71613812,
"domNodes": -142,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 6665.737,
"eventListeners": -74,
"totalBlockingTimeMs": 754,
"frameDurationMs": 34.269076305220885,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9919.238000000007,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.45000000000000073,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9108.938,
"heapDeltaBytes": -16700348,
"heapUsedBytes": 68484696,
"domNodes": -143,
"jsHeapTotalBytes": -6950912,
"scriptDurationMs": 7589.019,
"eventListeners": -82,
"totalBlockingTimeMs": 980,
"frameDurationMs": 33.05433333333333,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10073.396000000002,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05400000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9321.386999999999,
"heapDeltaBytes": 13305892,
"heapUsedBytes": 98465312,
"domNodes": -142,
"jsHeapTotalBytes": -3280896,
"scriptDurationMs": 7802.028,
"eventListeners": -74,
"totalBlockingTimeMs": 1392,
"frameDurationMs": 35.07386759581882,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2020.021999999983,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.395999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.4179999999999,
"heapDeltaBytes": -9501604,
"heapUsedBytes": 78734656,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.634,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2007.1450000000368,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.95,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.80499999999995,
"heapDeltaBytes": -9740336,
"heapUsedBytes": 78987368,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 33.897999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2278.429000000017,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.007000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1575.254,
"heapDeltaBytes": -18614868,
"heapUsedBytes": 70457796,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 848.625,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.787499999999994,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2368.4620000000223,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.264,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1581.5919999999996,
"heapDeltaBytes": -18743060,
"heapUsedBytes": 70452276,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 847.285,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78439716312057,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3567.9159999999683,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.030000000000001,
"layouts": 60,
"layoutDurationMs": 14.007,
"taskDurationMs": 1658.1319999999996,
"heapDeltaBytes": 1500592,
"heapUsedBytes": 70189312,
"domNodes": 24,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 782.902,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665887850467293,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3590.0990000000093,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.647999999999998,
"layouts": 60,
"layoutDurationMs": 14.218,
"taskDurationMs": 1619.062,
"heapDeltaBytes": 3898720,
"heapUsedBytes": 82558148,
"domNodes": 24,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 767.672,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740745,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3070.0789999999643,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.102,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1852.729,
"heapDeltaBytes": 8439564,
"heapUsedBytes": 77827036,
"domNodes": 0,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 961.9479999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757377049180324,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3140.527999999904,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.020999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1892.839,
"heapDeltaBytes": -10310116,
"heapUsedBytes": 73369140,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 994.3649999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755080213903746,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2011.165999999946,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.061999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.1889999999999,
"heapDeltaBytes": -10609612,
"heapUsedBytes": 78930116,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.685999999999986,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.5080000000162,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.478,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.10600000000005,
"heapDeltaBytes": -9168400,
"heapUsedBytes": 80587160,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 32.75899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 583.1850000000145,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.902999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.178,
"heapDeltaBytes": -12042948,
"heapUsedBytes": 58022916,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 143.34900000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 602.1480000000565,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.944000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.94499999999994,
"heapDeltaBytes": -12325440,
"heapUsedBytes": 57676588,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 144.725,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.937000000013,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.046000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.119,
"heapDeltaBytes": 1368100,
"heapUsedBytes": 71499968,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.744000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.7280000000337,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.7929999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.23800000000006,
"heapDeltaBytes": 1131452,
"heapUsedBytes": 70655032,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.159999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1703.440999999998,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.166999999999998,
"layouts": 16,
"layoutDurationMs": 5.889,
"taskDurationMs": 766.6800000000001,
"heapDeltaBytes": -5867572,
"heapUsedBytes": 63625740,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 114.63999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.4279999999499,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.602,
"layouts": 16,
"layoutDurationMs": 5.12,
"taskDurationMs": 722.6590000000001,
"heapDeltaBytes": -5895956,
"heapUsedBytes": 64633728,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 111.521,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.9570000000012,
"styleRecalcs": 16,
"styleRecalcDurationMs": 28.889999999999993,
"layouts": 5,
"layoutDurationMs": 14.571999999999997,
"taskDurationMs": 923.7659999999998,
"heapDeltaBytes": 1300312,
"heapUsedBytes": 96383968,
"domNodes": 14227,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 28.67900000000001,
"eventListeners": 2463,
"totalBlockingTimeMs": 128,
"frameDurationMs": 19.634246575342456,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8329.822999999977,
"styleRecalcs": 251,
"styleRecalcDurationMs": 34.629,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5535.676,
"heapDeltaBytes": -17707020,
"heapUsedBytes": 70736908,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 2758.9100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699599198396793,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8433.88200000004,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.095,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4945.112,
"heapDeltaBytes": -16562352,
"heapUsedBytes": 68997592,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 2745.879,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699009900990102,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18073.00200000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17108.688000000002,
"heapDeltaBytes": -43952780,
"heapUsedBytes": 179343960,
"domNodes": -3045,
"jsHeapTotalBytes": 1155072,
"scriptDurationMs": 267.558,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.620338983050846,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 17695.988000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16960.984,
"heapDeltaBytes": -36217336,
"heapUsedBytes": 180227472,
"domNodes": -3046,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 261.756,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.998813559322038,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 21296.470999999998,
"styleRecalcs": 179,
"styleRecalcDurationMs": 18.688999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20856.462,
"heapDeltaBytes": -14264556,
"heapUsedBytes": 198512212,
"domNodes": -3045,
"jsHeapTotalBytes": 7094272,
"scriptDurationMs": 871.174,
"eventListeners": -14915,
"totalBlockingTimeMs": 10,
"frameDurationMs": 39.29723247232473,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 21555.031999999985,
"styleRecalcs": 176,
"styleRecalcDurationMs": 19.679999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21122.833,
"heapDeltaBytes": -23492420,
"heapUsedBytes": 189473464,
"domNodes": -3045,
"jsHeapTotalBytes": 6504448,
"scriptDurationMs": 865.669,
"eventListeners": -14915,
"totalBlockingTimeMs": 19,
"frameDurationMs": 39.06847826086957,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6343.3579999999665,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.355,
"layouts": 20,
"layoutDurationMs": 24.153999999999996,
"taskDurationMs": 6253.5779999999995,
"heapDeltaBytes": -13052316,
"heapUsedBytes": 214834828,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 106.54100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.922754491017955,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6362.773000000061,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.60999999999996,
"layouts": 20,
"layoutDurationMs": 24.080999999999992,
"taskDurationMs": 6272.069,
"heapDeltaBytes": 698088,
"heapUsedBytes": 217388924,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 105.36800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.89583333333334,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9034.797000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8670.616999999998,
"heapDeltaBytes": -39276316,
"heapUsedBytes": 184723608,
"domNodes": -3045,
"jsHeapTotalBytes": 7184384,
"scriptDurationMs": 136.80499999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.210367892976592,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9063.939000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8717.925,
"heapDeltaBytes": -38659620,
"heapUsedBytes": 184904608,
"domNodes": -3045,
"jsHeapTotalBytes": 7970816,
"scriptDurationMs": 140.55999999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.26622073578595,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 492.94300000008207,
"styleRecalcs": 25,
"styleRecalcDurationMs": 21.658000000000005,
"layouts": 5,
"layoutDurationMs": 2.0809999999999995,
"taskDurationMs": 152.69400000000002,
"heapDeltaBytes": 6078132,
"heapUsedBytes": 71566540,
"domNodes": 133,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 18.018999999999995,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241396,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 467.8209999999581,
"styleRecalcs": 14,
"styleRecalcDurationMs": 14.945,
"layouts": 4,
"layoutDurationMs": 1.596,
"taskDurationMs": 114.314,
"heapDeltaBytes": 5666296,
"heapUsedBytes": 64469476,
"domNodes": 101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.091000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 848.4720000000152,
"styleRecalcs": 78,
"styleRecalcDurationMs": 100.268,
"layouts": 76,
"layoutDurationMs": 25.183,
"taskDurationMs": 818.808,
"heapDeltaBytes": 17536600,
"heapUsedBytes": 84498144,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 340.825,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352933,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 800.1970000000256,
"styleRecalcs": 78,
"styleRecalcDurationMs": 98.388,
"layouts": 76,
"layoutDurationMs": 23.224999999999998,
"taskDurationMs": 769.189,
"heapDeltaBytes": 17156752,
"heapUsedBytes": 82001948,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 314.102,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1343.8639999999396,
"styleRecalcs": 78,
"styleRecalcDurationMs": 250.33300000000003,
"layouts": 76,
"layoutDurationMs": 27.558,
"taskDurationMs": 1326.853,
"heapDeltaBytes": -18916600,
"heapUsedBytes": 110283296,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 442.029,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.088607594936708,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1524.4650000000775,
"styleRecalcs": 78,
"styleRecalcDurationMs": 279.30100000000004,
"layouts": 76,
"layoutDurationMs": 30.099999999999998,
"taskDurationMs": 1486.375,
"heapDeltaBytes": 8645472,
"heapUsedBytes": 115464252,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 512.836,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.697560975609743,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2203 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3a643500cbfcd8c4a52a01e7c3dd3b7a83565536
Full docs: ADR-DEVEX-LINT-0015 |
christian-byrne
left a comment
There was a problem hiding this comment.
reviewed the backport diff rather than re-reviewing #18706. the applied delta here is line-for-line identical to the merged main commit 8bcbd9f3cd — same nine files, same +495/-7, and comparing the added/removed lines of this diff against git show 8bcbd9f3cd yields no difference. so the behaviour carried is exactly what was reviewed and merged upstream.
the one conflict was src/scripts/api.ts, and it is context adjacency rather than semantics. upstream deletes const FETCH_RESPONSE_HEADERS_TIMEOUT_MS = 60_000 so api.ts can import the value from the new leaf module src/scripts/apiTimeouts.ts; on this release branch the PM-1802 AuthScheme docblock and type sit inside that same hunk immediately after the constant, which is why git could not place the deletion. resolved by removing only the constant and leaving AuthScheme untouched — onAuthScheme?: (scheme: AuthScheme) => void in FetchApiOptions still resolves, and FETCH_RESPONSE_HEADERS_TIMEOUT_MS now arrives through the import at the top of the file with no duplicate local binding.
nothing was relaxed to make the pick apply, and no assertion in the four test files was weakened. agentSendGateStore.ts, agentSendGateStore.test.ts, agentRunModeStore.ts and agentRunModeStore.test.ts are byte-identical to their main versions.
merging under the program's standing Agent release-backport grant for the current core/1.55 / cloud/1.55 / core/1.56 / cloud/1.56 trains, after lint-and-format, test and e2e-status are terminal green at this exact head. GitHub will not accept an author approving their own pull request, so this is a COMMENT rather than a manufactured approval.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.56 #20763 +/- ##
============================================
Coverage 85.83% 85.83%
============================================
Files 2473 2475 +2
Lines 141260 141285 +25
Branches 38441 36473 -1968
============================================
+ Hits 121251 121277 +26
+ Misses 19626 19625 -1
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Backport of #18706 (
8bcbd9f3cd) tocore/1.56. The fix stops a run-mode change picked right after Send from governing the message already sent (PM-1660), with the regression test PM-1661 asks for.The 1.55 line already has this fix via #20611.
core/1.56andcloud/1.56did not, and1.56is what production serves — so the user-visible defect is still reachable on the served build.Changes
8bcbd9f3cd. The applied delta is line-for-line identical to the mergedmaincommit (9 files, +495/-7), verified by comparing the added/removed lines of this diff againstgit show 8bcbd9f3cd.Review Focus
One conflict, in
src/scripts/api.ts, and it is pure context adjacency rather than semantics. The upstream hunk deletesconst FETCH_RESPONSE_HEADERS_TIMEOUT_MS = 60_000so the value can be imported from the new leaf modulesrc/scripts/apiTimeouts.ts. On this release branch the PM-1802AuthSchemetype sits immediately after that constant, inside the same hunk, so git could not place the deletion. Resolved by deleting only the constant and keeping theAuthSchemedocblock and type untouched. No behaviour was weakened to make the pick apply.Verification
mainfix, as above.lint-and-format,test,e2e-status) are the real run; the@cloudPlaywright spec inbrowser_tests/tests/agent/agentRunModePopover.spec.tsis not runnable against a local CPU backend, which is the same constraint fix(agent): stop a run-mode change from overtaking a message already sent #18706 recorded.