Repository navigation
[backport cloud/1.56] FE-3359 feat(telemetry): report the SSO sign-in funnel and failures - #20752
Conversation
…20733) Reports the SSO sign-in funnel and its client-side failures from the Cloud app and billing-web, per the [SSO telemetry spec](https://www.notion.so/3f56d73d3650813d930cd693ea2b5301) (T1, T2, and the billing-web part of T3). - Fixes FE-3359 Root cause: today the frontend reports one thing about SSO, an exception from the `sso_required` handler via `reportError`. We can't see how many people hit the SSO notice, continue, drop, fail, or land in their org workspace. The backend's `auth_audit_events` sees completed sign-ins only. We need the funnel and failure rate before phase 2 (enforced mode). - account-core `telemetry.ts`: `SSO_TELEMETRY_EVENT` (`app:sso_required_shown`, `app:sso_continue_clicked`, `app:sso_sign_in_failed`, `app:sso_sign_in_completed`, `app:sso_workspace_landed`) with typed properties, `ssoFailureReason()` (reduces `?sso_error=` codes to `state_mismatch` / `org_not_attached` / `server_error`), and `ssoFlowStore`: a random `flow_id` per attempt, kept in sessionStorage across the IdP redirect, marked `continued` on Continue, and cleared on sign-in, failure, dismissal of an uncontinued notice, or another sign-in method completing. Only a continued flow reports completion, so a notice merely shown (or a reload re-firing the session listener) never reports one. If storage throws, the store falls back to memory, so a broken storage never blocks sign-in. - Cloud app: one `trackSsoEvent` on `TelemetryRegistry`. The PostHog provider captures it, and the Datadog RUM provider records it as a custom action. Feature code goes through `useTelemetry()` only. `reportError` is unchanged. - billing-web: the same events through its existing `billingWebTelemetry` sink (RUM + PostHog). - Privacy: event properties hold IDs and enums only. - Side effects: no GTM/Customer.io/Mixpanel changes. SSO events go only to PostHog and Datadog through `trackSsoEvent`; `trackAuth` is not called for SSO. - TD1 (PostHog funnel vs Datadog-only) is still open. Events go through the registry, so moving to a different sink only means changing a provider; call sites stay the same. | Moment | AS IS | TO BE | |---|---|---| | SSO-required notice on login/signup, or the in-app dialog | nothing | `app:sso_required_shown` {surface `cloud_login`/`cloud_signup`/`cloud_customer_create`/`cloud_app`, trigger `firebase_sign_in`/`customer_create`/`session_refused`/`api_key`, presentation `notice`, flow_id}, once per screen (merged refusals don't re-fire) | | Lapsed SSO session sent straight to SSO by the router | nothing | `app:sso_required_shown` {surface `cloud_app`, trigger `session_expired`, presentation `redirect`, flow_id}; the flow counts as continued, so no `sso_continue_clicked` follows | | Continue with SSO (notice, dialog, or the login/signup SSO email that discovers SSO) | nothing | `app:sso_continue_clicked` {surface, flow_id}, once per attempt (the dialog's hand-off to the login page leaves it to that page) | | Return to `/cloud/login?sso_error=…`, or Back from the IdP (bfcache) | error message only | `app:sso_sign_in_failed` {surface, reason, flow_id}; `sso_error` is then removed from the URL so a remount doesn't re-report | | SSO session after an attempt this tab continued | nothing | `app:sso_sign_in_completed` {surface, flow_id} (replaces the earlier `app:user_auth_completed` method `sso`) | | First workspace opened after that sign-in | nothing | `app:sso_workspace_landed` {surface, flow_id, landed_in_default_workspace}: true when it opened the server's `default_workspace_id` (FE-3343), whether newly chosen or restored from the tab's workspace session | | billing-web `SSO_REQUIRED` notice / Continue with SSO | nothing | `app:sso_required_shown` (trigger `session_refused`, presentation `notice`) / `app:sso_continue_clicked`, surface `billing_web` | Event capture screenshots to follow. - account-core `telemetry.test.ts`: the flow carries across a redirect and clears on finish; a continued flow keeps its id; abandon drops only an uncontinued flow; a flow id is still made without `crypto`; every attempt gets a new id; storage that throws keeps the flow in memory; corrupt stored values are ignored; reason mapping table. - Cloud: `ssoRequired`/`ssoRequiredInline` (shown once per screen, surface/trigger, nothing with the flag off), `SsoRequiredDialogContent` (click joins the shown flow), `CloudLoginView` (continue on SSO discovery, nothing for non-SSO email, Back from the IdP → `cancelled`, `?sso_error=` → reason + the attempt's flow_id, sign-in still redirects when sessionStorage throws), `webSessionFlagOn` (SSO session after a continued attempt → `sso_sign_in_completed` and no `trackAuth`; nothing for a shown-but-not-continued attempt, no attempt, or a Google session; lapse redirect → shown `redirect` then completion on the same flow), `teamWorkspaceStore` (landed true/false, also from a restored workspace session, nothing for non-SSO), registry and PostHog/Datadog provider mapping. - billing-web: `SignInView` (shown + continue share a flow, nothing with the flag off), `billingWebTelemetry` (RUM + PostHog). - `pnpm test:unit` on the touched areas (181 files, 4195 tests) and the account-core (1670) and billing-web (1510) suites pass. `typecheck:app`, `typecheck:account-core`, `typecheck:billing-web` are clean. - `cloud_app` is a surface value this PR adds for the in-app dialog (the spec's list has no in-app surface). The spec should list it, or name a different value. - Trigger `api_key` is used for any Cloud API request the refusal answers through `presentForRefusal` (remint/axios path). Please confirm that's the intended meaning. - billing-web ignores `?sso_error=` today, so it doesn't emit failure/completion/landing yet. Platform (rest of T3) is out of scope. (cherry picked from commit c3f2131)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-10T23:00:40.332Z",
"gitSha": "833467c5d8145d3853d7278f37e2e21c8e843551",
"branch": "backport-20733-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.7980000000225,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.6300000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.99,
"heapDeltaBytes": -3237024,
"heapUsedBytes": 58664444,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.301000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2011.107999999922,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.405,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 275.45200000000006,
"heapDeltaBytes": 583444,
"heapUsedBytes": 69406268,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.854999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.5469999999805,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.197000000000001,
"layouts": 12,
"layoutDurationMs": 2.581,
"taskDurationMs": 503.07599999999996,
"heapDeltaBytes": -2155876,
"heapUsedBytes": 66823052,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 92.719,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.6900000000742,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.629000000000001,
"layouts": 12,
"layoutDurationMs": 2.754,
"taskDurationMs": 512.764,
"heapDeltaBytes": -2098476,
"heapUsedBytes": 66414792,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 94.727,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667326732673274,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.404999999957,
"styleRecalcs": 32,
"styleRecalcDurationMs": 6.805999999999999,
"layouts": 6,
"layoutDurationMs": 1.0590000000000002,
"taskDurationMs": 228.35,
"heapDeltaBytes": 4073276,
"heapUsedBytes": 72132020,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.084,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.1360000000013,
"styleRecalcs": 32,
"styleRecalcDurationMs": 7.141,
"layouts": 6,
"layoutDurationMs": 1.22,
"taskDurationMs": 231.75199999999998,
"heapDeltaBytes": 3821956,
"heapUsedBytes": 71236944,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.9249999999999945,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 510.7359999999517,
"styleRecalcs": 16,
"styleRecalcDurationMs": 2.5050000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.64000000000004,
"heapDeltaBytes": -7357272,
"heapUsedBytes": 61410088,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 104.769,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 445.4449999999497,
"styleRecalcs": 16,
"styleRecalcDurationMs": 2.5130000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 291.30999999999995,
"heapDeltaBytes": -7426064,
"heapUsedBytes": 61183824,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 102.16899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 940.858999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.434,
"heapDeltaBytes": 16303608,
"heapUsedBytes": 86482456,
"domNodes": 0,
"jsHeapTotalBytes": 1736704,
"scriptDurationMs": 35.222,
"eventListeners": 0,
"totalBlockingTimeMs": 334,
"frameDurationMs": 28.78787878787879,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 970.8310000000893,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.5920000000001,
"heapDeltaBytes": 15693084,
"heapUsedBytes": 86270764,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 38.596000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 354,
"frameDurationMs": 29.290909090909103,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 701.9760000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.28200000000004,
"heapDeltaBytes": 17763428,
"heapUsedBytes": 103613320,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 83.77300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 95,
"frameDurationMs": 21.209090909090897,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 732.2400000000471,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.6789999999998,
"heapDeltaBytes": 17364560,
"heapUsedBytes": 104942304,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 96.89999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 117,
"frameDurationMs": 21.570588235294107,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5486.516999999993,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8609999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4609.439,
"heapDeltaBytes": -12383804,
"heapUsedBytes": 71900104,
"domNodes": -142,
"jsHeapTotalBytes": -10358784,
"scriptDurationMs": 3613.172,
"eventListeners": -78,
"totalBlockingTimeMs": 4,
"frameDurationMs": 20.458955223880597,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5749.287000000095,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7570000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5067.771,
"heapDeltaBytes": -8939016,
"heapUsedBytes": 75048824,
"domNodes": -142,
"jsHeapTotalBytes": -8261632,
"scriptDurationMs": 3966.3509999999997,
"eventListeners": -74,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.534456928838953,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5818.0340000000115,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7369999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5059.499,
"heapDeltaBytes": 3947080,
"heapUsedBytes": 73644120,
"domNodes": -142,
"jsHeapTotalBytes": -11931648,
"scriptDurationMs": 3972.0850000000005,
"eventListeners": -70,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.899212598425198,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5712.7100000000155,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9519999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5070.652999999999,
"heapDeltaBytes": 16227064,
"heapUsedBytes": 86229672,
"domNodes": -142,
"jsHeapTotalBytes": -3018752,
"scriptDurationMs": 4028.213,
"eventListeners": -74,
"totalBlockingTimeMs": 7,
"frameDurationMs": 22.352156862745097,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-graph-idle",
"durationMs": 2020.5380000000446,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.0170000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.66599999999994,
"heapDeltaBytes": -8922024,
"heapUsedBytes": 80384244,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 20.62,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2012.5069999999141,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4599999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.299,
"heapDeltaBytes": -9500944,
"heapUsedBytes": 79422248,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 19.885,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2094.053000000031,
"styleRecalcs": 70,
"styleRecalcDurationMs": 6.25,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 951.191,
"heapDeltaBytes": -19045676,
"heapUsedBytes": 71032684,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 484.00200000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6648,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2080.8980000000474,
"styleRecalcs": 70,
"styleRecalcDurationMs": 6.411,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 970.282,
"heapDeltaBytes": -19769516,
"heapUsedBytes": 69973020,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 490.776,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3086.5799999999695,
"styleRecalcs": 74,
"styleRecalcDurationMs": 9.371,
"layouts": 60,
"layoutDurationMs": 9.561,
"taskDurationMs": 1043.234,
"heapDeltaBytes": 830824,
"heapUsedBytes": 69793160,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 451.729,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3072.9049999999916,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.110999999999997,
"layouts": 60,
"layoutDurationMs": 9.804,
"taskDurationMs": 1017.1620000000001,
"heapDeltaBytes": 3354388,
"heapUsedBytes": 79716912,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 457.07899999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2156.293000000005,
"styleRecalcs": 49,
"styleRecalcDurationMs": 4.808999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1195.35,
"heapDeltaBytes": 4708404,
"heapUsedBytes": 73269812,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 589.062,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.796875000000004,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2118.6059999999998,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.4289999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1132.9560000000001,
"heapDeltaBytes": 4269600,
"heapUsedBytes": 73343296,
"domNodes": 0,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 558.9860000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.4119999999884,
"styleRecalcs": 11,
"styleRecalcDurationMs": 1.9120000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.916,
"heapDeltaBytes": -9355572,
"heapUsedBytes": 81308268,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 20.774999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2016.0919999999578,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.9439999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.26300000000003,
"heapDeltaBytes": -11254328,
"heapUsedBytes": 71011180,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 21.613,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 476.1890000000335,
"styleRecalcs": 48,
"styleRecalcDurationMs": 3.840000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 286.763,
"heapDeltaBytes": -12361032,
"heapUsedBytes": 57801088,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 94.697,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 410.4939999999715,
"styleRecalcs": 49,
"styleRecalcDurationMs": 4.064000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 262.177,
"heapDeltaBytes": -12606408,
"heapUsedBytes": 58438372,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 89.49799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2006.9369999999935,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.7090000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.651,
"heapDeltaBytes": 1121808,
"heapUsedBytes": 71267728,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.563999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2011.3369999999122,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.449,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 283.54100000000005,
"heapDeltaBytes": 909852,
"heapUsedBytes": 70921516,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.8080000000000025,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1680.988999999954,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.799000000000001,
"layouts": 16,
"layoutDurationMs": 4.021,
"taskDurationMs": 503.17400000000004,
"heapDeltaBytes": -5908716,
"heapUsedBytes": 63504360,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 64.281,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1680.2529999999933,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.418000000000001,
"layouts": 16,
"layoutDurationMs": 3.897,
"taskDurationMs": 477.20300000000003,
"heapDeltaBytes": -6331512,
"heapUsedBytes": 63900688,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 61.072,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 850.1440000000002,
"styleRecalcs": 18,
"styleRecalcDurationMs": 19.532,
"layouts": 5,
"layoutDurationMs": 8.638,
"taskDurationMs": 594.0300000000001,
"heapDeltaBytes": 1189664,
"heapUsedBytes": 93822768,
"domNodes": 14227,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 19.962,
"eventListeners": 2463,
"totalBlockingTimeMs": 84,
"frameDurationMs": 19.767441860465116,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8082.506999999964,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.558,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3376.878,
"heapDeltaBytes": 8080876,
"heapUsedBytes": 96579572,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 1600.2069999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659793814433,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8086.480000000051,
"styleRecalcs": 249,
"styleRecalcDurationMs": 20.619,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3376.201,
"heapDeltaBytes": -19029516,
"heapUsedBytes": 70165708,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 1580.2369999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665979381443297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10221.340999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9330.884999999998,
"heapDeltaBytes": -41377892,
"heapUsedBytes": 180702816,
"domNodes": -3045,
"jsHeapTotalBytes": 1941504,
"scriptDurationMs": 121.757,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.829493891797558,
"p95FrameDurationMs": 33.19999999999982
},
{
"name": "vue-large-graph-idle",
"durationMs": 10029.879000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9083.149000000001,
"heapDeltaBytes": -46787568,
"heapUsedBytes": 179142860,
"domNodes": -3045,
"jsHeapTotalBytes": 8179712,
"scriptDurationMs": 117.733,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.511013986013985,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 13011.464999999987,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.770000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12497.642000000002,
"heapDeltaBytes": -45603292,
"heapUsedBytes": 167938520,
"domNodes": -3045,
"jsHeapTotalBytes": 8409088,
"scriptDurationMs": 626.7009999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.148845470692713,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 12925.298999999995,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.14599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12357.951000000001,
"heapDeltaBytes": -24468480,
"heapUsedBytes": 189081828,
"domNodes": -3046,
"jsHeapTotalBytes": 5259264,
"scriptDurationMs": 626.2449999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 33,
"frameDurationMs": 23.135778175313057,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4310.377999999957,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.046000000000014,
"layouts": 20,
"layoutDurationMs": 22.154000000000007,
"taskDurationMs": 4158.388000000001,
"heapDeltaBytes": 14707864,
"heapUsedBytes": 214509200,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 67.613,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.155617977528085,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 3851.3570000000072,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.007,
"layouts": 20,
"layoutDurationMs": 20.291000000000004,
"taskDurationMs": 3714.0989999999993,
"heapDeltaBytes": 1198500,
"heapUsedBytes": 222949160,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 59.509,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.253179190751446,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5165.830999999912,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4777.6230000000005,
"heapDeltaBytes": -32626288,
"heapUsedBytes": 181731440,
"domNodes": -3045,
"jsHeapTotalBytes": 8933376,
"scriptDurationMs": 70.81300000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.26170212765957,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5378.601000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4782.439,
"heapDeltaBytes": -30228496,
"heapUsedBytes": 186885424,
"domNodes": -3045,
"jsHeapTotalBytes": 9281536,
"scriptDurationMs": 68.27099999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.253061224489787,
"p95FrameDurationMs": 33.20000000000073
},
{
"name": "workflow-execution",
"durationMs": 447.66200000003664,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.996000000000002,
"layouts": 3,
"layoutDurationMs": 1.5299999999999998,
"taskDurationMs": 95.58800000000001,
"heapDeltaBytes": 5811992,
"heapUsedBytes": 71923520,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.453000000000003,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 431.96100000000115,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.162,
"layouts": 4,
"layoutDurationMs": 1.6490000000000002,
"taskDurationMs": 90.92899999999999,
"heapDeltaBytes": 5804088,
"heapUsedBytes": 71798688,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.327,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 380.99399999998695,
"styleRecalcs": 78,
"styleRecalcDurationMs": 64.71000000000001,
"layouts": 76,
"layoutDurationMs": 15.723,
"taskDurationMs": 335.55600000000004,
"heapDeltaBytes": 12778264,
"heapUsedBytes": 85534944,
"domNodes": 76,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 109.192,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 370.65800000004856,
"styleRecalcs": 78,
"styleRecalcDurationMs": 65.724,
"layouts": 76,
"layoutDurationMs": 15.494000000000002,
"taskDurationMs": 338.45399999999995,
"heapDeltaBytes": 12794228,
"heapUsedBytes": 85100948,
"domNodes": 76,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 110.303,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 736.0149999999521,
"styleRecalcs": 78,
"styleRecalcDurationMs": 182.341,
"layouts": 76,
"layoutDurationMs": 16.779,
"taskDurationMs": 700.785,
"heapDeltaBytes": -17648916,
"heapUsedBytes": 106795320,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 192.652,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 622.8039999999737,
"styleRecalcs": 78,
"styleRecalcDurationMs": 163.858,
"layouts": 76,
"layoutDurationMs": 14.248999999999999,
"taskDurationMs": 585.899,
"heapDeltaBytes": -22457560,
"heapUsedBytes": 107290684,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 144.634,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684193,
"p95FrameDurationMs": 16.800000000000182
}
]
}🎭 Playwright: ✅ 2200 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since aa83b45b6a53fa7f840df7bf2bdf9c4d2d757126
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.56 #20752 +/- ##
=============================================
Coverage ? 85.13%
=============================================
Files ? 3524
Lines ? 169418
Branches ? 44173
=============================================
Hits ? 144238
Misses ? 23189
Partials ? 1991
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Manual backport of #20733 to cloud/1.56 (SSO sign-in funnel telemetry). Compared this diff against the merged original line-for-line: every file list matches, and the only differences from the original are import-only and forced by the older base —
PostHogTelemetryProvider.ts/.test.ts:cloud/1.56has noCaptureResultonPostHogand the test file has noassertimport; both kept as the PR body states.ssoRequired.ts/.test.ts:cloud/1.56still usesuseToast/toastStoreanduseAuthDialogsrather thanuseToastStore/dialogService, which main has already renamed — both call sites correctly use the older-base names.
No package.json touched, so no export-surface risk. CI is fully green (billing-web unit/e2e, build, typecheck, lint, cla), mergeable: CLEAN, and there are no open review threads. Approved.
Manual backport of #20733 to cloud/1.56. Auto-backport failed on conflicts in
src/platform/telemetry/providers/cloud/PostHogTelemetryProvider.tsandsrc/platform/telemetry/providers/cloud/PostHogTelemetryProvider.test.ts; resolved by:PostHogTelemetryProvider.ts: import-only conflict; kept cloud/1.56'simport type { PostHog }(noCaptureResulton this branch) and addedSsoTelemetryEventto the account-core telemetry import.PostHogTelemetryProvider.test.ts: import-only conflict; kept cloud/1.56's vitest import (noassert, noCaptureResult) and added theSsoTelemetryEventtype import.All other files applied cleanly.
Tests:
pnpm test:unit src/composables/auth/useAuthActions.test.ts src/platform/auth src/platform/cloud/onboarding src/platform/telemetry src/platform/workspace/stores: 87 files, 1882 tests passvitest run src/telemetry.test.ts: 17 passvitest run src/telemetry src/views/SignInView.test.ts src/auth: 9 files, 158 tests passtypecheck:app,typecheck:account-core,typecheck:billing-web: clean