Repository navigation
docs(adr): record how the Hub browses models, workflows and apps #20737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mariana953
wants to merge
5
commits into
main
Choose a base branch
from
mariana/hub-catalogue-adr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c9b2586
docs(adr): record how the Hub browses models, workflows and apps
mariana953 50f9966
docs(adr): say what the shared toolbar band actually shares
mariana953 df236d6
docs(adr): drop the claim that the sections browse identically
mariana953 4cd4c04
docs(adr): correct what the models and workflows filters share
mariana953 bd1090d
docs(adr): the filter labels do name the difference
mariana953 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
103 changes: 103 additions & 0 deletions
103
docs/adr/WEBSITE-CATALOGUE-0042-models-workflows-and-apps-browse-as-one-hub.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| # ADR-WEBSITE-CATALOGUE-0042: Models, Workflows and Apps Browse as One Hub | ||
|
|
||
| Date: 2026-10-10 | ||
|
|
||
| ## Status | ||
|
|
||
| Accepted | ||
|
|
||
| ## Context | ||
|
|
||
| The site carries three kinds of thing a visitor might want: partner models it | ||
| can run in the browser, workflow templates meant to be opened in ComfyUI, and | ||
| Comfy Apps. V1 shipped the models catalogue alone, at `/models`. V2 had to | ||
| decide whether the other two join the models in one catalogue or browse beside | ||
| them as their own. | ||
|
|
||
| A merged catalogue was asked for and prototyped. The risk raised against it was | ||
| not that merging is wrong but that the difference between a model and a | ||
| workflow has to stay legible to a reader who is not thinking about our data | ||
| model, and a single grid blurs it in specific, countable ways: a model and the | ||
| workflows that run on it are not peers, workflow titles collide with model | ||
| names, a family's operations are configurations rather than competitors, and | ||
| one grid would carry two different next steps. | ||
|
|
||
| The earlier draft of this record (#17791, closed) argued the merge from a | ||
| snapshot of the catalogue taken in September 2026. Those figures are not | ||
| restated here, because they have not been re-measured against what shipped and | ||
| a number nobody can reproduce is worse than no number. | ||
|
|
||
| ## Decision | ||
|
|
||
| Models, workflows and apps browse as **one Hub with three sections**, not as | ||
| one grid and not as separate catalogues. | ||
|
|
||
| - `/hub/models/`, `/hub/workflows/` and `/hub/apps/` are three routes behind | ||
| one tab bar. `ModelsCatalogue.vue` owns the tabs and renders exactly one of | ||
| `WorkshopModelsGrid`, `WorkflowCatalogue` or `AppCatalogue` per section. | ||
| - The sections share their furniture: the same sticky toolbar band, the same | ||
| shelf and grid layout, and the same card shape and width from | ||
| `card-layout.ts`. What the band holds differs by section, and so does what | ||
| the list holds. | ||
| - Each section lists one kind. A model and the workflows that run on it never | ||
| appear in the same list, which is how the central objection to a single grid | ||
| is answered: by not putting them side by side at all, rather than by labelling | ||
| them once they are. | ||
| - Models and workflows both carry search, a filter menu and sort, but they do | ||
| not filter over the same thing. Models filter by the eight use cases in | ||
| `USE_CASES`; workflows filter by their own five categories in | ||
| `workshop-workflow-categories.json`, and additionally by the model a workflow | ||
| runs on, which the models section has no counterpart for. The controls match, | ||
| the vocabulary does not. | ||
| - Apps carry only the tabs. `AppCatalogue` mounts no search, filter or sort, | ||
| because a shelf of a handful of apps is read rather than searched: the band | ||
| is there, with only the tabs in it. The moment the apps list grows past a | ||
| screenful this needs revisiting. | ||
|
|
||
| This settles the shape of browsing. It does not settle what belongs on a | ||
| workflow page, or where Run lives for a workflow that could run here. | ||
|
|
||
| ## Consequences | ||
|
|
||
| ### Positive | ||
|
|
||
| - One set of furniture to build, test and restyle. A change to the toolbar, | ||
| the shelves or the card lands in all three sections at once, which is what | ||
| made the Hub-wide design pass (#20333) a single piece of work. | ||
| - The type of a card is implied by the section it is in, so the interface does | ||
| not have to disambiguate a workflow titled exactly like a model. | ||
| - Each section can answer its own kind honestly: a model card can carry a price | ||
| and a Run, a workflow card does not have to pretend to. | ||
|
|
||
| ### Negative | ||
|
|
||
| - A visitor who does not know whether what they want is a model, a workflow or | ||
| an app has to pick a tab before they can look. Search is per section, so the | ||
| thing they want can be one tab away with no sign of it. | ||
| - Three listings is three surfaces to keep consistent. They share components, | ||
| but nothing structural stops them drifting; consistency is maintained by | ||
| convention and by tests, not by the type system. | ||
| - The two filter menus sit in the same place in the band and narrow over | ||
| different things. Nothing is mislabelled: the models control reads "Use | ||
| cases", and the workflows control reads "Filter" with "Categories" and | ||
| "Model" as the groups inside it. But a visitor who learns the eight use cases | ||
| in the models tab finds a different five in the workflows tab, and whether | ||
| the two should be reconciled is open. | ||
| - The split is by kind rather than by "runs here" against "open in ComfyUI", | ||
| which may be the division a visitor actually has in mind. That remains open. | ||
|
|
||
| ## Notes | ||
|
|
||
| Open questions this record does not answer: | ||
|
|
||
| 1. Where Run lives for a workflow that resolves to a model the site can run. | ||
| 2. Whether the tabs should split on "runs here" against "open in ComfyUI" | ||
| instead of on kind. | ||
| 3. Whether the interface says _workflows_ or _templates_; the Hub, the repo | ||
| data and the copy do not currently agree. | ||
| 4. Whether the models filter and the workflows filter should share one | ||
| vocabulary, and which of the two it would be. | ||
|
|
||
| Written after the fact, from the code as it stands at the Hub design pass | ||
| (#20333). It records a decision already built and in production rather than | ||
| proposing one. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.